Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-10-04 19:21, Lucas Meneghel Rodrigues wrote: > On 10/04/2012 09:27 AM, Jan Kiszka wrote: >> On 2012-10-04 14:10, Lucas Meneghel Rodrigues wrote: >>> On 10/04/2012 07:48 AM, Jan Kiszka wrote: On 2012-10-03 15:19, Paolo Bonzini wrote: > Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: >> Yep, I did send patches with the testdev device present on qemu-kvm.git >> to qemu.git a while ago, but there were many comments on the review, I >> ended up not implementing everything that was asked and the patches were >> archived. >> >> If nobody wants to step up to port it, I'll re-read the original thread >> and will spin up new patches (and try to go through the end with it). >> Executing the KVM unittests is something that we can't afford to lose, >> so I'd say it's important on this last mile effort to get rid of >> qemu-kvm. > > Absolutely, IIRC the problem was that testdev did a little bit of > everything... let's see what's the functionality of testdev: > > - write (port 0xf1), can be replaced in autotest with: > -device isa-debugcon,iobase=0xf1,chardev=... > > - exit code (port 0xf4), see this series: > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html > > - ram size (port 0xd1). If we can also patch kvm-unittests, the memory > is available in the CMOS or in fwcfg. Here is the SeaBIOS code: > > u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); > if (rs) > rs += 16 * 1024 * 1024; > else > rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) > + 1 * 1024 * 1024); > > The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. IIRC, one of the biggest problem with testdev was its hack to inject interrupts. >>> >>> Jan, I assume this commit helps to fix this, right? >>> >>> commit b334ec567f1de9a60349991e7b75083d569ddb0a >>> Author: Jan Kiszka >>> Date: Fri Mar 2 10:30:47 2012 +0100 >>> >>> qemu-kvm: Use upstream kvm-i8259 >>> >>> Drop the qemu-kvm version in favor of the equivalent upstream >>> implementation. This allows to move the i8259 back into the hwlib. >>> >>> Note that this also drops the testdev hack and restores proper >>> isa_get_irq. If testdev scripts exist that inject > IRQ15, they need >>> fixing. Testing for these interrupts on the PIIX3 makes no practical >>> sense anyway as those lines are unused. >>> >>> Signed-off-by: Jan Kiszka >>> Signed-off-by: Avi Kivity >> >> Yes, this improved it a lot as we no longer depend on additional >> changes. I'm not sure if there was resistance beyond that. >> >> When cleaning up the code: register_ioport_read must be replaced with >> the memory API. > > I did look at the MemoryRegionOps/memory_region_init_io and still did > not figure out how to port things. I'll send a v2 addressing all the > comments made so far but this one, just to see if people are OK with the > direction of the full patch, then if you could give me some pointers of > how to do this conversion, it'd be great. > See e.g. http://thread.gmane.org/gmane.comp.emulators.qemu/171217 Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 10/04/2012 09:27 AM, Jan Kiszka wrote: On 2012-10-04 14:10, Lucas Meneghel Rodrigues wrote: On 10/04/2012 07:48 AM, Jan Kiszka wrote: On 2012-10-03 15:19, Paolo Bonzini wrote: Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: Yep, I did send patches with the testdev device present on qemu-kvm.git to qemu.git a while ago, but there were many comments on the review, I ended up not implementing everything that was asked and the patches were archived. If nobody wants to step up to port it, I'll re-read the original thread and will spin up new patches (and try to go through the end with it). Executing the KVM unittests is something that we can't afford to lose, so I'd say it's important on this last mile effort to get rid of qemu-kvm. Absolutely, IIRC the problem was that testdev did a little bit of everything... let's see what's the functionality of testdev: - write (port 0xf1), can be replaced in autotest with: -device isa-debugcon,iobase=0xf1,chardev=... - exit code (port 0xf4), see this series: http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html - ram size (port 0xd1). If we can also patch kvm-unittests, the memory is available in the CMOS or in fwcfg. Here is the SeaBIOS code: u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); if (rs) rs += 16 * 1024 * 1024; else rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) + 1 * 1024 * 1024); The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. IIRC, one of the biggest problem with testdev was its hack to inject interrupts. Jan, I assume this commit helps to fix this, right? commit b334ec567f1de9a60349991e7b75083d569ddb0a Author: Jan Kiszka Date: Fri Mar 2 10:30:47 2012 +0100 qemu-kvm: Use upstream kvm-i8259 Drop the qemu-kvm version in favor of the equivalent upstream implementation. This allows to move the i8259 back into the hwlib. Note that this also drops the testdev hack and restores proper isa_get_irq. If testdev scripts exist that inject > IRQ15, they need fixing. Testing for these interrupts on the PIIX3 makes no practical sense anyway as those lines are unused. Signed-off-by: Jan Kiszka Signed-off-by: Avi Kivity Yes, this improved it a lot as we no longer depend on additional changes. I'm not sure if there was resistance beyond that. When cleaning up the code: register_ioport_read must be replaced with the memory API. I did look at the MemoryRegionOps/memory_region_init_io and still did not figure out how to port things. I'll send a v2 addressing all the comments made so far but this one, just to see if people are OK with the direction of the full patch, then if you could give me some pointers of how to do this conversion, it'd be great. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-10-04 14:10, Lucas Meneghel Rodrigues wrote: > On 10/04/2012 07:48 AM, Jan Kiszka wrote: >> On 2012-10-03 15:19, Paolo Bonzini wrote: >>> Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: Yep, I did send patches with the testdev device present on qemu-kvm.git to qemu.git a while ago, but there were many comments on the review, I ended up not implementing everything that was asked and the patches were archived. If nobody wants to step up to port it, I'll re-read the original thread and will spin up new patches (and try to go through the end with it). Executing the KVM unittests is something that we can't afford to lose, so I'd say it's important on this last mile effort to get rid of qemu-kvm. >>> >>> Absolutely, IIRC the problem was that testdev did a little bit of >>> everything... let's see what's the functionality of testdev: >>> >>> - write (port 0xf1), can be replaced in autotest with: >>> -device isa-debugcon,iobase=0xf1,chardev=... >>> >>> - exit code (port 0xf4), see this series: >>> http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html >>> >>> - ram size (port 0xd1). If we can also patch kvm-unittests, the memory >>> is available in the CMOS or in fwcfg. Here is the SeaBIOS code: >>> >>> u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); >>> if (rs) >>> rs += 16 * 1024 * 1024; >>> else >>> rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) >>>+ 1 * 1024 * 1024); >>> >>> The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. >> >> IIRC, one of the biggest problem with testdev was its hack to inject >> interrupts. > > Jan, I assume this commit helps to fix this, right? > > commit b334ec567f1de9a60349991e7b75083d569ddb0a > Author: Jan Kiszka > Date: Fri Mar 2 10:30:47 2012 +0100 > > qemu-kvm: Use upstream kvm-i8259 > > Drop the qemu-kvm version in favor of the equivalent upstream > implementation. This allows to move the i8259 back into the hwlib. > > Note that this also drops the testdev hack and restores proper > isa_get_irq. If testdev scripts exist that inject > IRQ15, they need > fixing. Testing for these interrupts on the PIIX3 makes no practical > sense anyway as those lines are unused. > > Signed-off-by: Jan Kiszka > Signed-off-by: Avi Kivity Yes, this improved it a lot as we no longer depend on additional changes. I'm not sure if there was resistance beyond that. When cleaning up the code: register_ioport_read must be replaced with the memory API. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 10/04/2012 07:48 AM, Jan Kiszka wrote: On 2012-10-03 15:19, Paolo Bonzini wrote: Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: Yep, I did send patches with the testdev device present on qemu-kvm.git to qemu.git a while ago, but there were many comments on the review, I ended up not implementing everything that was asked and the patches were archived. If nobody wants to step up to port it, I'll re-read the original thread and will spin up new patches (and try to go through the end with it). Executing the KVM unittests is something that we can't afford to lose, so I'd say it's important on this last mile effort to get rid of qemu-kvm. Absolutely, IIRC the problem was that testdev did a little bit of everything... let's see what's the functionality of testdev: - write (port 0xf1), can be replaced in autotest with: -device isa-debugcon,iobase=0xf1,chardev=... - exit code (port 0xf4), see this series: http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html - ram size (port 0xd1). If we can also patch kvm-unittests, the memory is available in the CMOS or in fwcfg. Here is the SeaBIOS code: u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); if (rs) rs += 16 * 1024 * 1024; else rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) + 1 * 1024 * 1024); The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. IIRC, one of the biggest problem with testdev was its hack to inject interrupts. Jan, I assume this commit helps to fix this, right? commit b334ec567f1de9a60349991e7b75083d569ddb0a Author: Jan Kiszka Date: Fri Mar 2 10:30:47 2012 +0100 qemu-kvm: Use upstream kvm-i8259 Drop the qemu-kvm version in favor of the equivalent upstream implementation. This allows to move the i8259 back into the hwlib. Note that this also drops the testdev hack and restores proper isa_get_irq. If testdev scripts exist that inject > IRQ15, they need fixing. Testing for these interrupts on the PIIX3 makes no practical sense anyway as those lines are unused. Signed-off-by: Jan Kiszka Signed-off-by: Avi Kivity -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-10-03 15:19, Paolo Bonzini wrote: > Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: >> Yep, I did send patches with the testdev device present on qemu-kvm.git >> to qemu.git a while ago, but there were many comments on the review, I >> ended up not implementing everything that was asked and the patches were >> archived. >> >> If nobody wants to step up to port it, I'll re-read the original thread >> and will spin up new patches (and try to go through the end with it). >> Executing the KVM unittests is something that we can't afford to lose, >> so I'd say it's important on this last mile effort to get rid of qemu-kvm. > > Absolutely, IIRC the problem was that testdev did a little bit of > everything... let's see what's the functionality of testdev: > > - write (port 0xf1), can be replaced in autotest with: > -device isa-debugcon,iobase=0xf1,chardev=... > > - exit code (port 0xf4), see this series: > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html > > - ram size (port 0xd1). If we can also patch kvm-unittests, the memory > is available in the CMOS or in fwcfg. Here is the SeaBIOS code: > > u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); > if (rs) > rs += 16 * 1024 * 1024; > else > rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) > + 1 * 1024 * 1024); > > The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. IIRC, one of the biggest problem with testdev was its hack to inject interrupts. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On Wed, Oct 03, 2012 at 03:19:56PM +0200, Paolo Bonzini wrote: > Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: > > Yep, I did send patches with the testdev device present on qemu-kvm.git > > to qemu.git a while ago, but there were many comments on the review, I > > ended up not implementing everything that was asked and the patches were > > archived. > > > > If nobody wants to step up to port it, I'll re-read the original thread > > and will spin up new patches (and try to go through the end with it). > > Executing the KVM unittests is something that we can't afford to lose, > > so I'd say it's important on this last mile effort to get rid of qemu-kvm. > > Absolutely, IIRC the problem was that testdev did a little bit of > everything... let's see what's the functionality of testdev: > > - write (port 0xf1), can be replaced in autotest with: > -device isa-debugcon,iobase=0xf1,chardev=... > kvm-unit-tests no longer uses 0xf1 for output. It uses serial. > - exit code (port 0xf4), see this series: > http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html > > - ram size (port 0xd1). If we can also patch kvm-unittests, the memory > is available in the CMOS or in fwcfg. Here is the SeaBIOS code: > > u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); > if (rs) > rs += 16 * 1024 * 1024; > else > rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) > + 1 * 1024 * 1024); > > The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. > > Paolo -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
Il 03/10/2012 12:57, Lucas Meneghel Rodrigues ha scritto: > Yep, I did send patches with the testdev device present on qemu-kvm.git > to qemu.git a while ago, but there were many comments on the review, I > ended up not implementing everything that was asked and the patches were > archived. > > If nobody wants to step up to port it, I'll re-read the original thread > and will spin up new patches (and try to go through the end with it). > Executing the KVM unittests is something that we can't afford to lose, > so I'd say it's important on this last mile effort to get rid of qemu-kvm. Absolutely, IIRC the problem was that testdev did a little bit of everything... let's see what's the functionality of testdev: - write (port 0xf1), can be replaced in autotest with: -device isa-debugcon,iobase=0xf1,chardev=... - exit code (port 0xf4), see this series: http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00818.html - ram size (port 0xd1). If we can also patch kvm-unittests, the memory is available in the CMOS or in fwcfg. Here is the SeaBIOS code: u32 rs = ((inb_cmos(0x34) << 16) | (inb_cmos(0x35) << 24)); if (rs) rs += 16 * 1024 * 1024; else rs = (((inb_cmos(0x30) << 10) | (inb_cmos(0x31) << 18)) + 1 * 1024 * 1024); The rest (ports 0xe0..0xe7, 0x2000..0x2017, MMIO) can be left in testdev. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 10/03/2012 06:55 AM, Gleb Natapov wrote: On Mon, Oct 01, 2012 at 03:26:05PM +0200, Jan Kiszka wrote: On 2012-10-01 15:19, Anthony Liguori wrote: Jan Kiszka writes: On 2012-10-01 11:31, Marcelo Tosatti wrote: It's not just about default configs. We need to validate if the migration formats are truly compatible (qemu-kvm -> QEMU, the other way around definitely not). For the command line switches, we could provide a wrapper script that translates them into upstream format or simply ignores them. That should be harmless to carry upstream. qemu-kvm has: -no-kvm -no-kvm-irqchip -no-kvm-pit -no-kvm-pit-reinjection -tdf <- does nothing There are replacements for all of the above. If we need to add them to qemu.git, it's not big deal to add them. But I don't think we should add them to the source code. This can perfectly be handled my a (disposable) script layer on top of qemu-system-x86_64 - the namespace (qemu-kvm in most cases) is also free. -drive ...,boot= <- this is ignored cpu_set command for CPU hotplug which is known broken in qemu-kvm. Right, so nothing is lost when migrating to QEMU. testdev which is nice but only used for development Jan, do you have a plan for testdev device? It would be a pity to have qemu-kvm just for that. Yep, I did send patches with the testdev device present on qemu-kvm.git to qemu.git a while ago, but there were many comments on the review, I ended up not implementing everything that was asked and the patches were archived. If nobody wants to step up to port it, I'll re-read the original thread and will spin up new patches (and try to go through the end with it). Executing the KVM unittests is something that we can't afford to lose, so I'd say it's important on this last mile effort to get rid of qemu-kvm. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility
On Wed, Oct 03, 2012 at 12:06:57PM +0200, Jan Kiszka wrote: > On 2012-10-03 11:55, Gleb Natapov wrote: > > On Mon, Oct 01, 2012 at 03:26:05PM +0200, Jan Kiszka wrote: > >> On 2012-10-01 15:19, Anthony Liguori wrote: > >>> Jan Kiszka writes: > >>> > On 2012-10-01 11:31, Marcelo Tosatti wrote: > > It's not just about default configs. We need to validate if the > migration formats are truly compatible (qemu-kvm -> QEMU, the other way > around definitely not). For the command line switches, we could provide > a wrapper script that translates them into upstream format or simply > ignores them. That should be harmless to carry upstream. > >>> > >>> qemu-kvm has: > >>> > >>> -no-kvm > >>> -no-kvm-irqchip > >>> -no-kvm-pit > >>> -no-kvm-pit-reinjection > >>> -tdf <- does nothing > >>> > >>> There are replacements for all of the above. If we need to add them to > >>> qemu.git, it's not big deal to add them. > >> > >> But I don't think we should add them to the source code. This can > >> perfectly be handled my a (disposable) script layer on top of > >> qemu-system-x86_64 - the namespace (qemu-kvm in most cases) is also free. > >> > >>> > >>> -drive ...,boot= <- this is ignored > >>> > >>> cpu_set command for CPU hotplug which is known broken in qemu-kvm. > >> > >> Right, so nothing is lost when migrating to QEMU. > >> > >>> > >>> testdev which is nice but only used for development > >>> > > Jan, do you have a plan for testdev device? It would be a pity to have > > qemu-kvm just for that. > > Nope, not on my schedule. > Understood :) -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-10-03 11:55, Gleb Natapov wrote: > On Mon, Oct 01, 2012 at 03:26:05PM +0200, Jan Kiszka wrote: >> On 2012-10-01 15:19, Anthony Liguori wrote: >>> Jan Kiszka writes: >>> On 2012-10-01 11:31, Marcelo Tosatti wrote: It's not just about default configs. We need to validate if the migration formats are truly compatible (qemu-kvm -> QEMU, the other way around definitely not). For the command line switches, we could provide a wrapper script that translates them into upstream format or simply ignores them. That should be harmless to carry upstream. >>> >>> qemu-kvm has: >>> >>> -no-kvm >>> -no-kvm-irqchip >>> -no-kvm-pit >>> -no-kvm-pit-reinjection >>> -tdf <- does nothing >>> >>> There are replacements for all of the above. If we need to add them to >>> qemu.git, it's not big deal to add them. >> >> But I don't think we should add them to the source code. This can >> perfectly be handled my a (disposable) script layer on top of >> qemu-system-x86_64 - the namespace (qemu-kvm in most cases) is also free. >> >>> >>> -drive ...,boot= <- this is ignored >>> >>> cpu_set command for CPU hotplug which is known broken in qemu-kvm. >> >> Right, so nothing is lost when migrating to QEMU. >> >>> >>> testdev which is nice but only used for development >>> > Jan, do you have a plan for testdev device? It would be a pity to have > qemu-kvm just for that. Nope, not on my schedule. Jan signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility
On Mon, Oct 01, 2012 at 03:26:05PM +0200, Jan Kiszka wrote: > On 2012-10-01 15:19, Anthony Liguori wrote: > > Jan Kiszka writes: > > > >> On 2012-10-01 11:31, Marcelo Tosatti wrote: > >> > >> It's not just about default configs. We need to validate if the > >> migration formats are truly compatible (qemu-kvm -> QEMU, the other way > >> around definitely not). For the command line switches, we could provide > >> a wrapper script that translates them into upstream format or simply > >> ignores them. That should be harmless to carry upstream. > > > > qemu-kvm has: > > > > -no-kvm > > -no-kvm-irqchip > > -no-kvm-pit > > -no-kvm-pit-reinjection > > -tdf <- does nothing > > > > There are replacements for all of the above. If we need to add them to > > qemu.git, it's not big deal to add them. > > But I don't think we should add them to the source code. This can > perfectly be handled my a (disposable) script layer on top of > qemu-system-x86_64 - the namespace (qemu-kvm in most cases) is also free. > > > > > -drive ...,boot= <- this is ignored > > > > cpu_set command for CPU hotplug which is known broken in qemu-kvm. > > Right, so nothing is lost when migrating to QEMU. > > > > > testdev which is nice but only used for development > > Jan, do you have a plan for testdev device? It would be a pity to have qemu-kvm just for that. > > Default nic is rtl8139 vs. e1000. > > > > Some logic to move change the default VGA ram size to 16mb for pc-1.2 > > (QEMU uses 16mb by default now too). > > Also nicely manageable in a wrapper. > > > > > I think at this point, none of this matters but I added the various > > distro maintainers to the thread. > > > > I think it's time for the distros to drop qemu-kvm and just ship > > qemu.git. > > +1 > > Jan > > > Is there anything else that needs to happen to make that > > switch? > > > > Regards, > > > > Anthony Liguori > > -- > Siemens AG, Corporate Technology, CT RTC ITP SDP-DE > Corporate Competence Center Embedded Linux -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On Mon, Oct 01, 2012 at 08:19:29AM -0500, Anthony Liguori wrote: > Jan Kiszka writes: > I think at this point, none of this matters but I added the various > distro maintainers to the thread. > > I think it's time for the distros to drop qemu-kvm and just ship > qemu.git. Is there anything else that needs to happen to make that > switch? If that is upstream's recommendation, then I see no issue with switching Fedora 19 / RHEL-7 to use qemu.git instead of qemu-kvm.git. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility (fwd)
Quoting Peter Maydell (peter.mayd...@linaro.org): > On 1 October 2012 15:15, Serge Hallyn wrote: > > We (Ubuntu) plan to switch to qemu in the next release which opens in > > November. I suppose there's likely to be a hiccough or two, but I can't > > think of any offhand. > > Are you planning to do that for all CPU target architectures, or > to maintain the current split between x86 and everything-else ? > > -- PMM I'll have to talk to qemu-linaro folks about that. I don't mind carrying patchsets (that are headed upstream) to enable some chipsets if that's what's needed to consolidate the source trees. The bigger question relates to main vs universe. For instance qemu-system is built against vde2, and qemu-kvm-spice against spice, both of which are in universe. I understand the distinction may change or disappear soon, so this may not be an issue. I intend to schedule a session on this at UDS. -serge -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility
>>> On 10/1/2012 at 07:19 AM, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2012-10-01 11:31, Marcelo Tosatti wrote: >> >> It's not just about default configs. We need to validate if the >> migration formats are truly compatible (qemu-kvm -> QEMU, the other way >> around definitely not). For the command line switches, we could provide >> a wrapper script that translates them into upstream format or simply >> ignores them. That should be harmless to carry upstream. > > qemu-kvm has: > > -no-kvm > -no-kvm-irqchip > -no-kvm-pit > -no-kvm-pit-reinjection > -tdf <- does nothing > > There are replacements for all of the above. If we need to add them to > qemu.git, it's not big deal to add them. > > -drive ...,boot= <- this is ignored > > cpu_set command for CPU hotplug which is known broken in qemu-kvm. > > testdev which is nice but only used for development > > Default nic is rtl8139 vs. e1000. > > Some logic to move change the default VGA ram size to 16mb for pc-1.2 > (QEMU uses 16mb by default now too). > > I think at this point, none of this matters but I added the various > distro maintainers to the thread. > > I think it's time for the distros to drop qemu-kvm and just ship > qemu.git. Is there anything else that needs to happen to make that > switch? We are seriously considering moving to qemu.git for our SP3 release of SUSE SLES 11. There are just a handful of patches that provide the backwards compatibility we need to maintain (default to kvm, default nic model, vga ram size), so assuming there is a 100% commitment to fully supporting kvm in qemu going forward (which I don't doubt) I think this is a good time for us to make that switch. Bruce -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility (fwd)
On 1 October 2012 15:15, Serge Hallyn wrote: > We (Ubuntu) plan to switch to qemu in the next release which opens in > November. I suppose there's likely to be a hiccough or two, but I can't > think of any offhand. Are you planning to do that for all CPU target architectures, or to maintain the current split between x86 and everything-else ? -- PMM -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
Il 01/10/2012 16:07, Alexander Graf ha scritto: >>> -drive ...,boot= <- this is ignored > > It's ignored, but useful for certain things. I don't know how many of > our users use boot= today, but it's certainly still in the code, and > supported. I honestly wouldn't mind to carry a SUSE specific patch > that implements boot= for now until we can deem it deprecated enough > that we can drop it. Extboot is not going to be backported to QEMU, but SeaBIOS can now boot from all emulated device models except MegaSAS. So we may at most have just the option, for example making it an alias for bootindex=1 on the corresponding device. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility (fwd)
We (Ubuntu) plan to switch to qemu in the next release which opens in November. I suppose there's likely to be a hiccough or two, but I can't think of any offhand. -serge Quoting Scott Moser (smo...@ubuntu.com): > you should have been added here. > > > -- Forwarded message -- > Date: Mon, 1 Oct 2012 09:19:29 > From: Anthony Liguori > To: Jan Kiszka , Marcelo Tosatti > Cc: kvm , qemu-devel , > Cole Robinson , Scott Moser , > Andreas Färber , Michael Tokarev > Subject: Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility > > Jan Kiszka writes: > > > On 2012-10-01 11:31, Marcelo Tosatti wrote: > > > > It's not just about default configs. We need to validate if the > > migration formats are truly compatible (qemu-kvm -> QEMU, the other way > > around definitely not). For the command line switches, we could provide > > a wrapper script that translates them into upstream format or simply > > ignores them. That should be harmless to carry upstream. > > qemu-kvm has: > > -no-kvm > -no-kvm-irqchip > -no-kvm-pit > -no-kvm-pit-reinjection > -tdf <- does nothing > > There are replacements for all of the above. If we need to add them to > qemu.git, it's not big deal to add them. > > -drive ...,boot= <- this is ignored > > cpu_set command for CPU hotplug which is known broken in qemu-kvm. > > testdev which is nice but only used for development > > Default nic is rtl8139 vs. e1000. > > Some logic to move change the default VGA ram size to 16mb for pc-1.2 > (QEMU uses 16mb by default now too). > > I think at this point, none of this matters but I added the various > distro maintainers to the thread. > > I think it's time for the distros to drop qemu-kvm and just ship > qemu.git. Is there anything else that needs to happen to make that > switch? > > Regards, > > Anthony Liguori > > > > > But I would really stop worrying about the qemu-kvm code base. > > > > Jan > > > > -- > > Siemens AG, Corporate Technology, CT RTC ITP SDP-DE > > Corporate Competence Center Embedded Linux > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majord...@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-devel] qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 01.10.2012, at 15:19, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2012-10-01 11:31, Marcelo Tosatti wrote: >> >> It's not just about default configs. We need to validate if the >> migration formats are truly compatible (qemu-kvm -> QEMU, the other way >> around definitely not). For the command line switches, we could provide >> a wrapper script that translates them into upstream format or simply >> ignores them. That should be harmless to carry upstream. > > qemu-kvm has: > > -no-kvm Should be easy to have around as backwards compat hack. All it needs to do is set accel=tcg. > -no-kvm-irqchip > -no-kvm-pit > -no-kvm-pit-reinjection Those are quite important, as we need cmdline backwards compatibility. > -tdf <- does nothing > > There are replacements for all of the above. If we need to add them to > qemu.git, it's not big deal to add them. > > -drive ...,boot= <- this is ignored It's ignored, but useful for certain things. I don't know how many of our users use boot= today, but it's certainly still in the code, and supported. I honestly wouldn't mind to carry a SUSE specific patch that implements boot= for now until we can deem it deprecated enough that we can drop it. > cpu_set command for CPU hotplug which is known broken in qemu-kvm. > > testdev which is nice but only used for development > > Default nic is rtl8139 vs. e1000. Couldn't we have a machine option that tells us that -M pc-1.2 is really -M pc-kvm-1.2? That way we could implement the device difference, right? Alex > > Some logic to move change the default VGA ram size to 16mb for pc-1.2 > (QEMU uses 16mb by default now too). > > I think at this point, none of this matters but I added the various > distro maintainers to the thread. > > I think it's time for the distros to drop qemu-kvm and just ship > qemu.git. Is there anything else that needs to happen to make that > switch? > > Regards, > > Anthony Liguori > >> >> But I would really stop worrying about the qemu-kvm code base. >> >> Jan >> >> -- >> Siemens AG, Corporate Technology, CT RTC ITP SDP-DE >> Corporate Competence Center Embedded Linux >> -- >> To unsubscribe from this list: send the line "unsubscribe kvm" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
Paolo Bonzini writes: > Il 01/10/2012 15:19, Anthony Liguori ha scritto: >> I think it's time for the distros to drop qemu-kvm and just ship >> qemu.git. Is there anything else that needs to happen to make that >> switch? > > Perhaps change the default to -machine accel=kvm:tcg? > > Paolo I would be in favor of: #if defined(CONFIG_KVM) accel=kvm #else accel=tcg #endif If KVM is available for your target, you almost certainly want to use it. I'd be very happy with that change for 1.3. Regards, Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-10-01 15:44, Michael Tokarev wrote: > 01.10.2012 17:36, Jan Kiszka wrote: >> On 2012-10-01 15:31, Marcelo Tosatti wrote: > Default nic is rtl8139 vs. e1000. >>> >>> Config file (as suggested earlier on this thread). >> >> If you need to append -config bla, you can also specify the desired NIC >> explicitly - I see no value in the former. If we decide to mangle a >> qemu-kvm command line before calling QEMU binaries, we can adjust this >> variation there. Otherwise it's the same as with all those -kvm*: >> Scripts/management tools will need adjustment. > > I don't think there's a need to "manage" this rtl8139 at > all at this level. Let's declare that "qemu-kvm 1.3+" will > switch from rtl8139 to e1000 by default as a more suitable > in modern world, -- the same way as qemu did the switch > earlier, and be done with that. I think. > > Note that this is JUST for "-net nic" users, which should > be the minority (proper usage is -device rtl8139 or -device > e1000, with explicit model). Well, the alternative to config files or wrapper scripts is just a detailed checklist "how to migrate from qemu-kvm to QEMU". Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-10-01 15:38, Paolo Bonzini wrote: > Il 01/10/2012 15:19, Anthony Liguori ha scritto: >> I think it's time for the distros to drop qemu-kvm and just ship >> qemu.git. Is there anything else that needs to happen to make that >> switch? > > Perhaps change the default to -machine accel=kvm:tcg? That's the old discussion again: This way we generate that "silent failure" (unless you monitor the console output), where users will complain that "QEMU is so slow" because something is blocking KVM. Maybe the risk for the latter is lower these days as modules are auto-loaded now, don't know. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
01.10.2012 17:36, Jan Kiszka wrote: > On 2012-10-01 15:31, Marcelo Tosatti wrote: >>> Default nic is rtl8139 vs. e1000. >> >> Config file (as suggested earlier on this thread). > > If you need to append -config bla, you can also specify the desired NIC > explicitly - I see no value in the former. If we decide to mangle a > qemu-kvm command line before calling QEMU binaries, we can adjust this > variation there. Otherwise it's the same as with all those -kvm*: > Scripts/management tools will need adjustment. I don't think there's a need to "manage" this rtl8139 at all at this level. Let's declare that "qemu-kvm 1.3+" will switch from rtl8139 to e1000 by default as a more suitable in modern world, -- the same way as qemu did the switch earlier, and be done with that. I think. Note that this is JUST for "-net nic" users, which should be the minority (proper usage is -device rtl8139 or -device e1000, with explicit model). Thanks, /mjt -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
Il 01/10/2012 15:19, Anthony Liguori ha scritto: > I think it's time for the distros to drop qemu-kvm and just ship > qemu.git. Is there anything else that needs to happen to make that > switch? Perhaps change the default to -machine accel=kvm:tcg? Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-10-01 15:31, Marcelo Tosatti wrote: > On Mon, Oct 01, 2012 at 08:19:29AM -0500, Anthony Liguori wrote: >> Jan Kiszka writes: >> >>> On 2012-10-01 11:31, Marcelo Tosatti wrote: >>> >>> It's not just about default configs. We need to validate if the >>> migration formats are truly compatible (qemu-kvm -> QEMU, the other way >>> around definitely not). For the command line switches, we could provide >>> a wrapper script that translates them into upstream format or simply >>> ignores them. That should be harmless to carry upstream. >> >> qemu-kvm has: >> >> -no-kvm >> -no-kvm-irqchip >> -no-kvm-pit >> -no-kvm-pit-reinjection >> -tdf <- does nothing >> >> There are replacements for all of the above. If we need to add them to >> qemu.git, it's not big deal to add them. > > At the moment the only purpose of this command line options is for > compability with scripts. My view is that scripts are easily fixed, > so we can just drop them. No need to carry this to QEMU. > >> -drive ...,boot= <- this is ignored >> >> cpu_set command for CPU hotplug which is known broken in qemu-kvm. >> >> testdev which is nice but only used for development >> >> Default nic is rtl8139 vs. e1000. > > Config file (as suggested earlier on this thread). If you need to append -config bla, you can also specify the desired NIC explicitly - I see no value in the former. If we decide to mangle a qemu-kvm command line before calling QEMU binaries, we can adjust this variation there. Otherwise it's the same as with all those -kvm*: Scripts/management tools will need adjustment. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On Mon, Oct 01, 2012 at 08:19:29AM -0500, Anthony Liguori wrote: > Jan Kiszka writes: > > > On 2012-10-01 11:31, Marcelo Tosatti wrote: > > > > It's not just about default configs. We need to validate if the > > migration formats are truly compatible (qemu-kvm -> QEMU, the other way > > around definitely not). For the command line switches, we could provide > > a wrapper script that translates them into upstream format or simply > > ignores them. That should be harmless to carry upstream. > > qemu-kvm has: > > -no-kvm > -no-kvm-irqchip > -no-kvm-pit > -no-kvm-pit-reinjection > -tdf <- does nothing > > There are replacements for all of the above. If we need to add them to > qemu.git, it's not big deal to add them. At the moment the only purpose of this command line options is for compability with scripts. My view is that scripts are easily fixed, so we can just drop them. No need to carry this to QEMU. > -drive ...,boot= <- this is ignored > > cpu_set command for CPU hotplug which is known broken in qemu-kvm. > > testdev which is nice but only used for development > > Default nic is rtl8139 vs. e1000. Config file (as suggested earlier on this thread). > Some logic to move change the default VGA ram size to 16mb for pc-1.2 > (QEMU uses 16mb by default now too). Config file. > I think at this point, none of this matters but I added the various > distro maintainers to the thread. > > I think it's time for the distros to drop qemu-kvm and just ship > qemu.git. Is there anything else that needs to happen to make that > switch? > > Regards, > > Anthony Liguori > > > > > But I would really stop worrying about the qemu-kvm code base. > > > > Jan > > > > -- > > Siemens AG, Corporate Technology, CT RTC ITP SDP-DE > > Corporate Competence Center Embedded Linux > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majord...@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-10-01 15:19, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2012-10-01 11:31, Marcelo Tosatti wrote: >> >> It's not just about default configs. We need to validate if the >> migration formats are truly compatible (qemu-kvm -> QEMU, the other way >> around definitely not). For the command line switches, we could provide >> a wrapper script that translates them into upstream format or simply >> ignores them. That should be harmless to carry upstream. > > qemu-kvm has: > > -no-kvm > -no-kvm-irqchip > -no-kvm-pit > -no-kvm-pit-reinjection > -tdf <- does nothing > > There are replacements for all of the above. If we need to add them to > qemu.git, it's not big deal to add them. But I don't think we should add them to the source code. This can perfectly be handled my a (disposable) script layer on top of qemu-system-x86_64 - the namespace (qemu-kvm in most cases) is also free. > > -drive ...,boot= <- this is ignored > > cpu_set command for CPU hotplug which is known broken in qemu-kvm. Right, so nothing is lost when migrating to QEMU. > > testdev which is nice but only used for development > > Default nic is rtl8139 vs. e1000. > > Some logic to move change the default VGA ram size to 16mb for pc-1.2 > (QEMU uses 16mb by default now too). Also nicely manageable in a wrapper. > > I think at this point, none of this matters but I added the various > distro maintainers to the thread. > > I think it's time for the distros to drop qemu-kvm and just ship > qemu.git. +1 Jan > Is there anything else that needs to happen to make that > switch? > > Regards, > > Anthony Liguori -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
Jan Kiszka writes: > On 2012-10-01 11:31, Marcelo Tosatti wrote: > > It's not just about default configs. We need to validate if the > migration formats are truly compatible (qemu-kvm -> QEMU, the other way > around definitely not). For the command line switches, we could provide > a wrapper script that translates them into upstream format or simply > ignores them. That should be harmless to carry upstream. qemu-kvm has: -no-kvm -no-kvm-irqchip -no-kvm-pit -no-kvm-pit-reinjection -tdf <- does nothing There are replacements for all of the above. If we need to add them to qemu.git, it's not big deal to add them. -drive ...,boot= <- this is ignored cpu_set command for CPU hotplug which is known broken in qemu-kvm. testdev which is nice but only used for development Default nic is rtl8139 vs. e1000. Some logic to move change the default VGA ram size to 16mb for pc-1.2 (QEMU uses 16mb by default now too). I think at this point, none of this matters but I added the various distro maintainers to the thread. I think it's time for the distros to drop qemu-kvm and just ship qemu.git. Is there anything else that needs to happen to make that switch? Regards, Anthony Liguori > > But I would really stop worrying about the qemu-kvm code base. > > Jan > > -- > Siemens AG, Corporate Technology, CT RTC ITP SDP-DE > Corporate Competence Center Embedded Linux > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-10-01 15:03, Marcelo Tosatti wrote: > On Mon, Oct 01, 2012 at 12:21:18PM +0200, Jan Kiszka wrote: >> On 2012-10-01 11:31, Marcelo Tosatti wrote: >>> On Mon, Oct 01, 2012 at 10:05:21AM +0200, Jan Kiszka wrote: On 2012-09-30 21:11, Marcelo Tosatti wrote: > > Option is deprecated and warning has been in place for one year. Do we really care about such cosmetics? >>> >>> We care about removing qemu-kvm to null. >>> What is the big plan for qemu-kvm now? For 1.3 and then beyond? >>> >>> I suggested this: provide a configuration file (and proper guide on >>> how to use it on announce email) to be shipped with qemu 1.3.0. >>> >>> That is: >>> >>> "For compatibility with qemu-kvm 1.2.0, use >>> >>> qemu-system-x86_64 -config /usr/share/qemu/qemu-kvm-1.2-compat.opt" >>> >>> This would work for rtl8139-as-default, vga-ram-size differences. >>> >>> And drop all command line option compatibility (which can be easily fixed >>> by an administrator/end user). >>> >>> Comments? >> >> It's not just about default configs. We need to validate if the >> migration formats are truly compatible (qemu-kvm -> QEMU, the other way >> around definitely not). > > Right, VGA RAM size differences are part of migration compatibility. > > The other two are ACPI and i8254 (will be looking into details soon, > thanks). > >> For the command line switches, we could provide >> a wrapper script that translates them into upstream format or simply >> ignores them. That should be harmless to carry upstream. > > Do you have an objection against just pushing the responsability to > administrators? It can be seen as configuration file format change. This is about helping him in the most appropriate way. > > Most users should not be using direct command line anyway. If you are using the command line, you shouldn't care about qemu-kvm's legacy. But there might be home-grown management stacks or scripts around that have to be adjusted. So some wrapper may help in this process, either as reference or as intermediate adapter. > >> But I would really stop worrying about the qemu-kvm code base. >> >> Jan > > Right, thats what we're trying to do here. Just that I'm missing how this patch correlates with the goal to get QEMU ready for qemu-kvm users. :) Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On Mon, Oct 01, 2012 at 12:21:18PM +0200, Jan Kiszka wrote: > On 2012-10-01 11:31, Marcelo Tosatti wrote: > > On Mon, Oct 01, 2012 at 10:05:21AM +0200, Jan Kiszka wrote: > >> On 2012-09-30 21:11, Marcelo Tosatti wrote: > >>> > >>> Option is deprecated and warning has been in place for one year. > >> > >> Do we really care about such cosmetics? > > > > We care about removing qemu-kvm to null. > > > >> What is the big plan for > >> qemu-kvm now? For 1.3 and then beyond? > > > > I suggested this: provide a configuration file (and proper guide on > > how to use it on announce email) to be shipped with qemu 1.3.0. > > > > That is: > > > > "For compatibility with qemu-kvm 1.2.0, use > > > > qemu-system-x86_64 -config /usr/share/qemu/qemu-kvm-1.2-compat.opt" > > > > This would work for rtl8139-as-default, vga-ram-size differences. > > > > And drop all command line option compatibility (which can be easily fixed > > by an administrator/end user). > > > > Comments? > > It's not just about default configs. We need to validate if the > migration formats are truly compatible (qemu-kvm -> QEMU, the other way > around definitely not). Right, VGA RAM size differences are part of migration compatibility. The other two are ACPI and i8254 (will be looking into details soon, thanks). > For the command line switches, we could provide > a wrapper script that translates them into upstream format or simply > ignores them. That should be harmless to carry upstream. Do you have an objection against just pushing the responsability to administrators? It can be seen as configuration file format change. Most users should not be using direct command line anyway. > But I would really stop worrying about the qemu-kvm code base. > > Jan Right, thats what we're trying to do here. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-10-01 11:31, Marcelo Tosatti wrote: > On Mon, Oct 01, 2012 at 10:05:21AM +0200, Jan Kiszka wrote: >> On 2012-09-30 21:11, Marcelo Tosatti wrote: >>> >>> Option is deprecated and warning has been in place for one year. >> >> Do we really care about such cosmetics? > > We care about removing qemu-kvm to null. > >> What is the big plan for >> qemu-kvm now? For 1.3 and then beyond? > > I suggested this: provide a configuration file (and proper guide on > how to use it on announce email) to be shipped with qemu 1.3.0. > > That is: > > "For compatibility with qemu-kvm 1.2.0, use > > qemu-system-x86_64 -config /usr/share/qemu/qemu-kvm-1.2-compat.opt" > > This would work for rtl8139-as-default, vga-ram-size differences. > > And drop all command line option compatibility (which can be easily fixed > by an administrator/end user). > > Comments? It's not just about default configs. We need to validate if the migration formats are truly compatible (qemu-kvm -> QEMU, the other way around definitely not). For the command line switches, we could provide a wrapper script that translates them into upstream format or simply ignores them. That should be harmless to carry upstream. But I would really stop worrying about the qemu-kvm code base. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On Mon, Oct 01, 2012 at 10:05:21AM +0200, Jan Kiszka wrote: > On 2012-09-30 21:11, Marcelo Tosatti wrote: > > > > Option is deprecated and warning has been in place for one year. > > Do we really care about such cosmetics? We care about removing qemu-kvm to null. > What is the big plan for > qemu-kvm now? For 1.3 and then beyond? I suggested this: provide a configuration file (and proper guide on how to use it on announce email) to be shipped with qemu 1.3.0. That is: "For compatibility with qemu-kvm 1.2.0, use qemu-system-x86_64 -config /usr/share/qemu/qemu-kvm-1.2-compat.opt" This would work for rtl8139-as-default, vga-ram-size differences. And drop all command line option compatibility (which can be easily fixed by an administrator/end user). Comments? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
On 2012-09-30 21:11, Marcelo Tosatti wrote:
>
> Option is deprecated and warning has been in place for one year.
Do we really care about such cosmetics? What is the big plan for
qemu-kvm now? For 1.3 and then beyond?
Jan
>
> Signed-off-by: Marcelo Tosatti
>
> diff --git a/blockdev.c b/blockdev.c
> index 4a5266e..7c83baa 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -432,12 +432,6 @@ DriveInfo *drive_init(QemuOpts *opts, int
> default_to_scsi)
> return NULL;
> }
>
> -if (qemu_opt_get(opts, "boot") != NULL) {
> -fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
> -"ignored. Future versions will reject this parameter. Please
> "
> -"update your scripts.\n");
> -}
> -
> on_write_error = BLOCK_ERR_STOP_ENOSPC;
> if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
> if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO && type
> != IF_NONE) {
> diff --git a/qemu-config.c b/qemu-config.c
> index 3eaee48..eba977e 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -114,10 +114,6 @@ static QemuOptsList qemu_drive_opts = {
> .name = "copy-on-read",
> .type = QEMU_OPT_BOOL,
> .help = "copy read data from backing file into image file",
> -},{
> -.name = "boot",
> -.type = QEMU_OPT_BOOL,
> -.help = "(deprecated, ignored)",
> },
> { /* end of list */ }
> },
>
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
- Original Message -
>
> Option is deprecated and warning has been in place for one year.
>
> Signed-off-by: Marcelo Tosatti
>
> diff --git a/blockdev.c b/blockdev.c
> index 4a5266e..7c83baa 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -432,12 +432,6 @@ DriveInfo *drive_init(QemuOpts *opts, int
> default_to_scsi)
> return NULL;
> }
>
> -if (qemu_opt_get(opts, "boot") != NULL) {
> -fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and
> will be "
> -"ignored. Future versions will reject this
> parameter. Please "
> -"update your scripts.\n");
> -}
> -
> on_write_error = BLOCK_ERR_STOP_ENOSPC;
> if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
> if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO
> && type != IF_NONE) {
> diff --git a/qemu-config.c b/qemu-config.c
> index 3eaee48..eba977e 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -114,10 +114,6 @@ static QemuOptsList qemu_drive_opts = {
> .name = "copy-on-read",
> .type = QEMU_OPT_BOOL,
> .help = "copy read data from backing file into image
> file",
> -},{
> -.name = "boot",
> -.type = QEMU_OPT_BOOL,
> -.help = "(deprecated, ignored)",
> },
> { /* end of list */ }
> },
Reviewed-by: Amos Kong
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
qemu-kvm: remove "boot=on|off" drive parameter compatibility
Option is deprecated and warning has been in place for one year.
Signed-off-by: Marcelo Tosatti
diff --git a/blockdev.c b/blockdev.c
index 4a5266e..7c83baa 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -432,12 +432,6 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
return NULL;
}
-if (qemu_opt_get(opts, "boot") != NULL) {
-fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
-"ignored. Future versions will reject this parameter. Please "
-"update your scripts.\n");
-}
-
on_write_error = BLOCK_ERR_STOP_ENOSPC;
if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO && type !=
IF_NONE) {
diff --git a/qemu-config.c b/qemu-config.c
index 3eaee48..eba977e 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -114,10 +114,6 @@ static QemuOptsList qemu_drive_opts = {
.name = "copy-on-read",
.type = QEMU_OPT_BOOL,
.help = "copy read data from backing file into image file",
-},{
-.name = "boot",
-.type = QEMU_OPT_BOOL,
-.help = "(deprecated, ignored)",
},
{ /* end of list */ }
},
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
