Re: remove compatibility code related toCONFIG_DMAR
On 18/09/08 22:07 +0800, Han, Weidong wrote: The previous patch I sent out (for the kvm kernel tree) changes intel-iommu.h so this compatibility code is no longer needed. Mike This compatibility code for intel_iommu makes VT-d cannot work in current code (version 2.6.28), due to intel_iommu_found() returns 0. Why add this limitation? Randy (Weidong) Mike Day wrote: Compatibility code for intel_iommu no longer needed when dependency on CONFIG_DMAR removed from kvm kernel build. Signed-off-by: Mike D. Day [EMAIL PROTECTED] --- external-module-compat.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/kernel/external-module-compat.c b/kernel/external-module-compat.c index 4b9a9f2..71429c7 100644 --- a/kernel/external-module-compat.c +++ b/kernel/external-module-compat.c @@ -265,14 +265,3 @@ struct pci_dev *pci_get_bus_and_slot(unsigned int bus, unsigned int devfn) } #endif - -#include linux/intel-iommu.h - -#if LINUX_VERSION_CODE KERNEL_VERSION(2,6,28) - -int intel_iommu_found() -{ - return 0; -} - -#endif -- Mike Day http://www.ncultra.org AIM: ncmikeday | Yahoo IM: ultra.runner PGP key: http://www.ncultra.org/ncmike/pubkey.asc -- Mike Day http://www.ncultra.org AIM: ncmikeday | Yahoo IM: ultra.runner PGP key: http://www.ncultra.org/ncmike/pubkey.asc -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: remove compatibility code related toCONFIG_DMAR
Mike, I saw your patch. It's good. Randy (Weidong) Mike Day wrote: On 18/09/08 22:07 +0800, Han, Weidong wrote: The previous patch I sent out (for the kvm kernel tree) changes intel-iommu.h so this compatibility code is no longer needed. Mike This compatibility code for intel_iommu makes VT-d cannot work in current code (version 2.6.28), due to intel_iommu_found() returns 0. Why add this limitation? Randy (Weidong) Mike Day wrote: Compatibility code for intel_iommu no longer needed when dependency on CONFIG_DMAR removed from kvm kernel build. Signed-off-by: Mike D. Day [EMAIL PROTECTED] --- external-module-compat.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/kernel/external-module-compat.c b/kernel/external-module-compat.c index 4b9a9f2..71429c7 100644 --- a/kernel/external-module-compat.c +++ b/kernel/external-module-compat.c @@ -265,14 +265,3 @@ struct pci_dev *pci_get_bus_and_slot(unsigned int bus, unsigned int devfn) } #endif - -#include linux/intel-iommu.h - -#if LINUX_VERSION_CODE KERNEL_VERSION(2,6,28) - -int intel_iommu_found() -{ - return 0; -} - -#endif -- Mike Day http://www.ncultra.org AIM: ncmikeday | Yahoo IM: ultra.runner PGP key: http://www.ncultra.org/ncmike/pubkey.asc -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html