[kvm-devel] Signals for file descriptors

[Anders Melchiorsen]

I am wondering about this commit,

http://git.kernel.org/?p=virt/kvm/kvm-userspace.git;a=commit;h=b4e392c21c4b98c1c13af353caa3d6e6bcb6b8af

which adds signals on tap I/O. It seems a bit half-done to me. For one
thing, it is mixing timers with I/O.

Anyway, my question is about the remaining file descriptors. Should
signals be activated for them as well, for example in
qemu_set_fd_handler2() ? My example on hand is that connecting a VNC
client currently delays until the next timer expiry.


Anders.

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [kvm-devel] Signals for file descriptors

[Anders Melchiorsen]

Avi Kivity [EMAIL PROTECTED] writes:

 In practice it doesn't matter, but yes, any fd which we will
 select() needs to have a signal attached.

It matters to me, because I am removing periodic timers, and so I
ended up where I could not attach with VNC at all (well, strace would
break the loop).

With your answers in mind, I will prepare a patch to add this.


Thanks,
Anders.

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

[kvm-devel] Missing part from qemu merge

[Anders Melchiorsen]

Hi Avi,

is it on purpose that this part of my qemu rearm rework was left out
when the rest was merged into KVM a few days ago? If there is still a
problem with it for KVM, I would like to know.


Cheers,
Anders

--- a/qemu/vl.c
+++ b/qemu/vl.c
@@ -1106,7 +1106,6 @@ static void qemu_run_timers(QEMUTimer **ptimer_head, 
int64_t current_time)
 /* run the callback (the timer list can be modified) */
 ts-cb(ts-opaque);
 }
-qemu_rearm_alarm_timer(alarm_timer);
 }
 
 int64_t qemu_get_clock(QEMUClock *clock)

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel