Re: [kvm-devel] [PATCH] make KVM selectable again
On Feb 10, 2008 2:29 AM, Dave Hansen <[EMAIL PROTECTED]> wrote: > Current git for me (b1d0e4f535e10775cffde922208b49629169aeaa) doesn't > let me build KVM. In fact, I don't seem to have *ANY* kvm-related > symbols in my .config at all. > > I've verified that arch/x86/kvm/Kconfig was getting run by putting some > comments in it. It seems to me like just putting: > > config HAVE_KVM >bool > > isn't letting anything come into my .config at all. I'm not sure why we > do that, and then have: > > select HAVE_KVM > > in arch/x86/Kconfig. > > This patch just defines HAVE_KVM in the x86 Kconfig and is done with it. > Seems to work for me. > > Was there some reason that it was done this way? Was it ever tested? > > -- Dave > > Signed-off-by: Dave Hansen <[EMAIL PROTECTED]> > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 65a70b7..cbbf35d 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -115,7 +115,8 @@ config ARCH_HAS_CPU_RELAX > config HAVE_SETUP_PER_CPU_AREA > def_bool X86_64 > > -select HAVE_KVM > +config HAVE_KVM > + def_bool y > > config ARCH_HIBERNATION_POSSIBLE > def_bool y > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig > index 41962e7..f2177ec 100644 > --- a/arch/x86/kvm/Kconfig > +++ b/arch/x86/kvm/Kconfig > @@ -1,8 +1,6 @@ > # > # KVM configuration > # > -config HAVE_KVM > - bool > > menuconfig VIRTUALIZATION > bool "Virtualization" > Hi, Dave, I did not see your email, until just now. I've posted a patch at http://lkml.org/lkml/2008/2/10/26. Avi has acked it Balbir - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] 2.6.24-rc8-mm1 (KVM build issues)
* Andrew Morton <[EMAIL PROTECTED]> [2008-01-17 02:35:14]:
> - kvm probably doesn't work properly because I couldn't be bothered fixing
> the conflicts between git-kvm and the driver tree
>
Hi, Andrew,
The following changes got KVM up and running for me
This patch fixes the kvm build on 2.6.24-rc8-mm1. First of all, it enables
the KVM build, the second fix moves kset_set_name to the .name member.
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]>
---
arch/x86/Makefile |2 +-
virt/kvm/kvm_main.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff -puN arch/x86/Makefile~fix-kvm-build arch/x86/Makefile
--- linux-2.6.24-rc8/arch/x86/Makefile~fix-kvm-build2008-01-18
22:42:41.0 +0530
+++ linux-2.6.24-rc8-balbir/arch/x86/Makefile 2008-01-18 22:42:47.0
+0530
@@ -185,7 +185,7 @@ core-y += arch/x86/vdso/
core-$(CONFIG_IA32_EMULATION) += arch/x86/ia32/
# kvm host support - uncomment when merging
-# core-$(CONFIG_KVM) += arch/x86/kvm/
+core-$(CONFIG_KVM) += arch/x86/kvm/
# drivers-y are linked after core-y
drivers-$(CONFIG_MATH_EMULATION) += arch/x86/math-emu/
diff -puN virt/kvm/kvm_main.c~fix-kvm-build virt/kvm/kvm_main.c
--- linux-2.6.24-rc8/virt/kvm/kvm_main.c~fix-kvm-build 2008-01-18
22:42:41.0 +0530
+++ linux-2.6.24-rc8-balbir/virt/kvm/kvm_main.c 2008-01-18 22:42:47.0
+0530
@@ -1260,7 +1260,7 @@ static int kvm_resume(struct sys_device
}
static struct sysdev_class kvm_sysdev_class = {
- set_kset_name("kvm"),
+ .name = "kvm",
.suspend = kvm_suspend,
.resume = kvm_resume,
};
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
