Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v3)
Andreas Winkelbauer wrote: hi, I'm sorry for messing up the last patch, I shouldn't work that late... I added the changes to pc.h (VGA_RAM_SIZE) and split up the patch in a qemu part and a vgabios part. Applied, thanks. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)
Hi all,
On Fr, 2008-02-22 at 03:11 +0100, Andreas Winkelbauer wrote:
I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. The
crash was caused by a really _dirty_ hack in a kvm specific part of
vga.c (it took me at least an hour to find this amazing piece of code...
at least the HACK ALERT was a good hint ;-) ).
Ow, that really does qualify as a dirty hack. :) Thanks for finding
that! I currently don't have the time to skim through pages of code, so
sorry for my non-involvement on this issue...
@Arne: Could you please test the patch with your setup? I hope it works
this time...
Yesno. It does (at least kvm does not crash), but it shows the same
dialog problems as reported by Leslie:
I've attached the patch. It works for me (tested with windows xp as
guest os @ 1680x1050). As always, please test the patch. I'd highly
appreciate it if somebody could test it with linux as guest os.
BTW, Leslie: Which patch did you use? I attached a second patch as
Andreas forgot to include the changes in hw/pc.h.
Cheers Good morning to the europeans ;)
Arne
diff -Naur kvm-61.orig/qemu/hw/pc.h kvm-61/qemu/hw/pc.h
--- kvm-61.orig/qemu/hw/pc.h 2008-02-19 15:58:28.0 +0100
+++ kvm-61/qemu/hw/pc.h 2008-02-21 11:52:36.0 +0100
@@ -108,9 +108,9 @@
/* vga.c */
#ifndef TARGET_SPARC
-#define VGA_RAM_SIZE (8192 * 1024)
+#define VGA_RAM_SIZE (16 * 1024 * 1024)
#else
-#define VGA_RAM_SIZE (9 * 1024 * 1024)
+#define VGA_RAM_SIZE (17 * 1024 * 1024)
#endif
int isa_vga_init(DisplayState *ds, uint8_t *vga_ram_base,
diff -Naur kvm-61.orig/qemu/hw/vga.c kvm-61/qemu/hw/vga.c
--- kvm-61.orig/qemu/hw/vga.c 2008-02-19 15:58:28.0 +0100
+++ kvm-61/qemu/hw/vga.c 2008-02-22 10:07:14.0 +0100
@@ -1438,7 +1438,7 @@
long page0, page1, page_min, page_max;
vga_draw_line_func *vga_draw_line;
/* HACK ALERT */
-#define VGA_BITMAP_SIZE ((8*1024*1024) / 4096 / 8 / sizeof(long))
+#define VGA_BITMAP_SIZE ((VGA_RAM_SIZE) / 4096 / 8 / sizeof(long))
unsigned long bitmap[VGA_BITMAP_SIZE];
#ifndef TARGET_IA64
int r;
diff -Naur kvm-61.orig/qemu/hw/vga_int.h kvm-61/qemu/hw/vga_int.h
--- kvm-61.orig/qemu/hw/vga_int.h 2008-02-19 15:58:28.0 +0100
+++ kvm-61/qemu/hw/vga_int.h 2008-02-21 10:54:48.0 +0100
@@ -30,8 +30,8 @@
/* bochs VBE support */
#define CONFIG_BOCHS_VBE
-#define VBE_DISPI_MAX_XRES 1600
-#define VBE_DISPI_MAX_YRES 1200
+#define VBE_DISPI_MAX_XRES 2560
+#define VBE_DISPI_MAX_YRES 1600
#define VBE_DISPI_MAX_BPP 32
#define VBE_DISPI_INDEX_ID 0x0
diff -Naur kvm-61.orig/vgabios/vbetables-gen.c kvm-61/vgabios/vbetables-gen.c
--- kvm-61.orig/vgabios/vbetables-gen.c 2008-02-19 15:58:28.0 +0100
+++ kvm-61/vgabios/vbetables-gen.c 2008-02-21 10:54:48.0 +0100
@@ -2,7 +2,7 @@
#include stdlib.h
#include stdio.h
-#define VBE_DISPI_TOTAL_VIDEO_MEMORY_MB 8
+#define VBE_DISPI_TOTAL_VIDEO_MEMORY_MB 16
typedef struct {
int width;
@@ -13,60 +13,69 @@
ModeInfo modes[] = {
/* standard VESA modes */
-{ 640, 400, 8 , 0x100},
-{ 640, 480, 8 , 0x101},
-{ 800, 600, 4 , 0x102},
-{ 800, 600, 8 , 0x103},
-{ 1024, 768, 4 , 0x104},
-{ 1024, 768, 8 , 0x105},
-{ 1280, 1024, 4, 0x106},
-{ 1280, 1024, 8, 0x107},
+{ 640, 400, 8, 0x100},
+{ 640, 480, 8, 0x101},
+{ 800, 600, 4, 0x102},
+{ 800, 600, 8, 0x103},
+{ 1024, 768, 4 , 0x104},
+{ 1024, 768, 8 , 0x105},
+{ 1280, 1024, 4 , 0x106},
+{ 1280, 1024, 8 , 0x107},
{ 320, 200, 15 , 0x10D},
-{ 320, 200, 16, 0x10E},
-{ 320, 200, 24, 0x10F},
+{ 320, 200, 16 , 0x10E},
+{ 320, 200, 24 , 0x10F},
{ 640, 480, 15 , 0x110},
-{ 640, 480, 16, 0x111},
-{ 640, 480, 24, 0x112},
+{ 640, 480, 16 , 0x111},
+{ 640, 480, 24 , 0x112},
{ 800, 600, 15 , 0x113},
-{ 800, 600, 16, 0x114},
-{ 800, 600, 24, 0x115},
+{ 800, 600, 16 , 0x114},
+{ 800, 600, 24 , 0x115},
{ 1024, 768, 15 , 0x116},
-{ 1024, 768, 16 , 0x117},
-{ 1024, 768, 24 , 0x118},
+{ 1024, 768, 16 , 0x117},
+{ 1024, 768, 24 , 0x118},
{ 1280, 1024, 15 , 0x119},
-{ 1280, 1024, 16 , 0x11A},
-{ 1280, 1024, 24
[kvm-devel] [PATCH] fix widescreen resolution issues (v3)
hi,
I'm sorry for messing up the last patch, I shouldn't work that late...
I added the changes to pc.h (VGA_RAM_SIZE) and split up the patch in a
qemu part and a vgabios part.
cheers,
Andi
--- kvm-61.orig/qemu/hw/vga_int.h 2008-02-19 15:58:28.0 +0100
+++ kvm-61/qemu/hw/vga_int.h 2008-02-22 13:17:33.0 +0100
@@ -30,8 +30,8 @@
/* bochs VBE support */
#define CONFIG_BOCHS_VBE
-#define VBE_DISPI_MAX_XRES 1600
-#define VBE_DISPI_MAX_YRES 1200
+#define VBE_DISPI_MAX_XRES 2560
+#define VBE_DISPI_MAX_YRES 1600
#define VBE_DISPI_MAX_BPP 32
#define VBE_DISPI_INDEX_ID 0x0
--- kvm-61.orig/qemu/hw/vga.c 2008-02-19 15:58:28.0 +0100
+++ kvm-61/qemu/hw/vga.c 2008-02-22 13:18:05.0 +0100
@@ -1438,7 +1438,7 @@
long page0, page1, page_min, page_max;
vga_draw_line_func *vga_draw_line;
/* HACK ALERT */
-#define VGA_BITMAP_SIZE ((8*1024*1024) / 4096 / 8 / sizeof(long))
+#define VGA_BITMAP_SIZE (VGA_RAM_SIZE / 4096 / 8 / sizeof(long))
unsigned long bitmap[VGA_BITMAP_SIZE];
#ifndef TARGET_IA64
int r;
--- kvm-61.orig/qemu/hw/pc.h 2008-02-19 15:58:28.0 +0100
+++ kvm-61/qemu/hw/pc.h 2008-02-22 13:19:12.0 +0100
@@ -108,9 +108,9 @@
/* vga.c */
#ifndef TARGET_SPARC
-#define VGA_RAM_SIZE (8192 * 1024)
+#define VGA_RAM_SIZE (16 * 1024 * 1024)
#else
-#define VGA_RAM_SIZE (9 * 1024 * 1024)
+#define VGA_RAM_SIZE (17 * 1024 * 1024)
#endif
int isa_vga_init(DisplayState *ds, uint8_t *vga_ram_base,
--- kvm-61.orig/vgabios/vbetables-gen.c 2008-02-19 15:58:28.0 +0100
+++ kvm-61/vgabios/vbetables-gen.c 2008-02-22 13:17:33.0 +0100
@@ -2,7 +2,7 @@
#include stdlib.h
#include stdio.h
-#define VBE_DISPI_TOTAL_VIDEO_MEMORY_MB 8
+#define VBE_DISPI_TOTAL_VIDEO_MEMORY_MB 16
typedef struct {
int width;
@@ -55,18 +55,27 @@
{ 1152, 864, 16 , 0x14a},
{ 1152, 864, 24 , 0x14b},
{ 1152, 864, 32 , 0x14c},
-{ 1280, 800, 24 , 0x178},
-{ 1280, 800, 32 , 0x179},
-{ 1280, 960, 24 , 0x180},
-{ 1280, 960, 32 , 0x181},
-{ 1280, 960, 24 , 0x182},
-{ 1280, 960, 32 , 0x183},
-{ 1440, 900, 24 , 0x184},
-{ 1440, 900, 32 , 0x185},
-{ 1400, 1050, 24 , 0x186},
-{ 1400, 1050, 32 , 0x187},
-{ 1680, 1050, 24 , 0x188},
-{ 1680, 1050, 32 , 0x189},
+{ 1280, 800, 16 , 0x178},
+{ 1280, 800, 24 , 0x179},
+{ 1280, 800, 32 , 0x17a},
+{ 1280, 960, 16 , 0x17b},
+{ 1280, 960, 24 , 0x17c},
+{ 1280, 960, 32 , 0x17d},
+{ 1440, 900, 16 , 0x17e},
+{ 1440, 900, 24 , 0x17f},
+{ 1440, 900, 32 , 0x180},
+{ 1400, 1050, 16 , 0x181},
+{ 1400, 1050, 24 , 0x182},
+{ 1400, 1050, 32 , 0x183},
+{ 1680, 1050, 16 , 0x184},
+{ 1680, 1050, 24 , 0x185},
+{ 1680, 1050, 32 , 0x186},
+{ 1920, 1200, 16 , 0x187},
+{ 1920, 1200, 24 , 0x188},
+{ 1920, 1200, 32 , 0x189},
+{ 2560, 1600, 16 , 0x18a},
+{ 2560, 1600, 24 , 0x18b},
+{ 2560, 1600, 32 , 0x18c},
{ 0, },
};
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)
hi, @Arne: Could you please test the patch with your setup? I hope it works this time... Yesno. It does (at least kvm does not crash), but it shows the same dialog problems as reported by Leslie: I'm quite sure that this issue isn't related to the widescreen fixes. This visual bug seems to be around since kvm-60 or so and has been verified by some guys (including me) also at lower resolutions like 1400x1050. See this post: http://article.gmane.org/gmane.comp.emulators.kvm.devel/13409 You could try using -no-kvm or an older kvm release for testing. cheers, Andi - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues
Andreas Winkelbauer wrote: hi, the attached patch fixes the issues with widescreen resolutions for me when using -std-vga. in vgabios/vbetables-gen.c I changed the video memory from 8MB to 16MB which is sufficient for resolutions up to 2560x1600. I've also added some more video modes (up to 2560x1600) with 16, 24, 32bit color depth each and I've removed the duplicate for the 1280x960 mode. in qemu/hw/vga_int.h I've adapted the maximum resolution accordingly. you can download the updated vgabios from http://www.wina.at/vgabios.bin I would appreciate any suggestions, comments and of course testing. @Arne Brutschy: could you please test the 1920x1200 resolution with your setup? What about VGA_RAM_SIZE in qemu/hw/pc.h? -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues
On Thu, 2008-02-21 at 11:29 +0100, Arne Brutschy wrote: Hi, On Mi, 2008-02-20 at 22:16 +0100, Andreas Winkelbauer wrote: the attached patch fixes the issues with widescreen resolutions for me when using -std-vga. I would appreciate any suggestions, comments and of course testing. Thanks for the patch, Andreas! You found the magic limitation to 1600x1200... @Arne Brutschy: could you please test the 1920x1200 resolution with your setup? I did, it does not work. :( I can select the video mode, but upon activation qemu crashes. I think the video memory overwrites system memory because qemu does not allocate the increased vmem properly. So every mode under 8MB of video ram does work, all others do not. 1680x1050x32 = works (7056000 bytes) 1920x1200x24 = works (6912000 bytes) 1920x1200x32 = crashes (9216000 bytes) I haven't found the piece of code that's responsible for vmem allocation yet. Does somebody know where this is done? Is there somebody from qemu reading this? there is a DEFINE name VGA_RAM_SIZE or something like that Arne - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues
Hi, On Mi, 2008-02-20 at 22:16 +0100, Andreas Winkelbauer wrote: the attached patch fixes the issues with widescreen resolutions for me when using -std-vga. I would appreciate any suggestions, comments and of course testing. Thanks for the patch, Andreas! You found the magic limitation to 1600x1200... @Arne Brutschy: could you please test the 1920x1200 resolution with your setup? I did, it does not work. :( I can select the video mode, but upon activation qemu crashes. I think the video memory overwrites system memory because qemu does not allocate the increased vmem properly. So every mode under 8MB of video ram does work, all others do not. 1680x1050x32 = works (7056000 bytes) 1920x1200x24 = works (6912000 bytes) 1920x1200x32 = crashes (9216000 bytes) I haven't found the piece of code that's responsible for vmem allocation yet. Does somebody know where this is done? Is there somebody from qemu reading this? Arne - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues
On Do, 2008-02-21 at 10:56 +0200, Avi Kivity wrote: What about VGA_RAM_SIZE in qemu/hw/pc.h? On Do, 2008-02-21 at 12:40 +0200, Izik Eidus wrote: there is a DEFINE name VGA_RAM_SIZE or something like that D'oh. Must have missed it. :\ Thanks! Unfortunately, it still does not work. Qemu crashes now as windows switches to graphics mode. Safe mode does not work either.. Arne -- Arne Brutschy Ph.D. StudentEmailarne.brutschy(AT)ulb.ac.be IRIDIA CP 194/6 Web iridia.ulb.ac.be/~abrutschy Universite' Libre de Bruxelles Tel +32 2 650 2729 Avenue Franklin Roosevelt 50 Fax +32 2 650 2715 1050 Bruxelles, Belgium (Tel and Fax both IRIDIA secretary) - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues
hi, What about VGA_RAM_SIZE in qemu/hw/pc.h? I already tried changing the VGA_RAM_SIZE value in pc.h to 16 * 1024 * 1024 (16MB), but then kvm crashes when the guest os switches to graphics mode. Changing VGA_RAM_SIZE in pc.h to 16MB works when I use the latest cvs snapshot of qemu (didn't test it with qemu-0.9.1 release version). Unfortunately I am not experienced in debugging kvm or qemu, so I hope someone can find out what's going on in this case. cheers, Andi - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues
hi, D'oh. Must have missed it. :\ Thanks! Unfortunately, it still does not work. Qemu crashes now as windows switches to graphics mode. Safe mode does not work either.. For now I'd suggest trying the following: * download the latest qemu cvs snapshot cvs -z3 -d:pserver:[EMAIL PROTECTED]:/sources/qemu co qemu cd qemu * apply the patch for hw/vga_int.h and change VGA_RAM_SIZE in hw/pc.h to 16 * 1024 * 1024 (16MB) * configure, make and install qemu ./configure --prefix=/usr/local/qemu-cvs make (use whatever prefix you like) # make install (as root) * download, configure, make and install kqemu (optional, but highly suggested) wget http://fabrice.bellard.free.fr/qemu/kqemu-1.3.0pre11.tar.gz tar -xzf kqemu-1.3.0pre11.tar.gz cd kqemu-1.3.0pre11 ./configure make # make install (as root) * copy the modified vgabios.bin to the qemu dir wget http://www.wina.at/vgabios.bin # cp vgabios.bin /usr/local/qemu-cvs/share/qemu (as root; change to target path according to the prefix you used above) * start your vm image as usual, but use /usr/local/qemu-cvs/bin/qemu instead of qemu/kvm. if kqemu does not work, reading the documentation http://fabrice.bellard.free.fr/qemu/kqemu-doc.html might help. Please test it that way. If it works, it should be possible to make it working with kvm as well. cheers, Andi - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues
hi, * copy the modified vgabios.bin to the qemu dir wget http://www.wina.at/vgabios.bin # cp vgabios.bin /usr/local/qemu-cvs/share/qemu (as root; change to target path according to the prefix you used above) I'm guess I've uploaded to wrong vgabios.bin, so if you don't want to compile it yourself and don't have those high resolution modes available, then you can get the vgabios.bin file from http://www.wina.at/vgabios.bin resolutions up to 2560x1600 should be available (although they do not neccessarily work). cheers, Andi - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
[kvm-devel] [PATCH] fix widescreen resolution issues (v2)
hi,
I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. The
crash was caused by a really _dirty_ hack in a kvm specific part of
vga.c (it took me at least an hour to find this amazing piece of code...
at least the HACK ALERT was a good hint ;-) ).
I've attached the patch. It works for me (tested with windows xp as
guest os @ 1680x1050). As always, please test the patch. I'd highly
appreciate it if somebody could test it with linux as guest os.
@Arne: Could you please test the patch with your setup? I hope it works
this time...
cheers,
Andi
--- kvm-61.orig/qemu/hw/vga.c 2008-02-19 15:58:28.0 +0100
+++ kvm-61/qemu/hw/vga.c 2008-02-22 02:43:08.0 +0100
@@ -1438,7 +1438,7 @@
long page0, page1, page_min, page_max;
vga_draw_line_func *vga_draw_line;
/* HACK ALERT */
-#define VGA_BITMAP_SIZE ((8*1024*1024) / 4096 / 8 / sizeof(long))
+#define VGA_BITMAP_SIZE ((VGA_RAM_SIZE) / 4096 / 8 / sizeof(long))
unsigned long bitmap[VGA_BITMAP_SIZE];
#ifndef TARGET_IA64
int r;
--- kvm-61.orig/qemu/hw/vga_int.h 2008-02-19 15:58:28.0 +0100
+++ kvm-61/qemu/hw/vga_int.h 2008-02-20 19:25:35.0 +0100
@@ -30,8 +30,8 @@
/* bochs VBE support */
#define CONFIG_BOCHS_VBE
-#define VBE_DISPI_MAX_XRES 1600
-#define VBE_DISPI_MAX_YRES 1200
+#define VBE_DISPI_MAX_XRES 2560
+#define VBE_DISPI_MAX_YRES 1600
#define VBE_DISPI_MAX_BPP 32
#define VBE_DISPI_INDEX_ID 0x0
--- kvm-61.orig/vgabios/vbetables-gen.c 2008-02-19 15:58:28.0 +0100
+++ kvm-61/vgabios/vbetables-gen.c 2008-02-20 19:22:48.0 +0100
@@ -2,7 +2,7 @@
#include stdlib.h
#include stdio.h
-#define VBE_DISPI_TOTAL_VIDEO_MEMORY_MB 8
+#define VBE_DISPI_TOTAL_VIDEO_MEMORY_MB 16
typedef struct {
int width;
@@ -55,18 +55,27 @@
{ 1152, 864, 16 , 0x14a},
{ 1152, 864, 24 , 0x14b},
{ 1152, 864, 32 , 0x14c},
-{ 1280, 800, 24 , 0x178},
-{ 1280, 800, 32 , 0x179},
-{ 1280, 960, 24 , 0x180},
-{ 1280, 960, 32 , 0x181},
-{ 1280, 960, 24 , 0x182},
-{ 1280, 960, 32 , 0x183},
-{ 1440, 900, 24 , 0x184},
-{ 1440, 900, 32 , 0x185},
-{ 1400, 1050, 24 , 0x186},
-{ 1400, 1050, 32 , 0x187},
-{ 1680, 1050, 24 , 0x188},
-{ 1680, 1050, 32 , 0x189},
+{ 1280, 800, 16 , 0x178},
+{ 1280, 800, 24 , 0x179},
+{ 1280, 800, 32 , 0x17a},
+{ 1280, 960, 16 , 0x17b},
+{ 1280, 960, 24 , 0x17c},
+{ 1280, 960, 32 , 0x17d},
+{ 1440, 900, 16 , 0x17e},
+{ 1440, 900, 24 , 0x17f},
+{ 1440, 900, 32 , 0x180},
+{ 1400, 1050, 16 , 0x181},
+{ 1400, 1050, 24 , 0x182},
+{ 1400, 1050, 32 , 0x183},
+{ 1680, 1050, 16 , 0x184},
+{ 1680, 1050, 24 , 0x185},
+{ 1680, 1050, 32 , 0x186},
+{ 1920, 1200, 16 , 0x187},
+{ 1920, 1200, 24 , 0x188},
+{ 1920, 1200, 32 , 0x189},
+{ 2560, 1600, 16 , 0x18a},
+{ 2560, 1600, 24 , 0x18b},
+{ 2560, 1600, 32 , 0x18c},
{ 0, },
};
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)
Andreas Winkelbauer andreas.winkelbauer at gmx.at writes: hi, I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. The crash was caused by a really _dirty_ hack in a kvm specific part of vga.c (it took me at least an hour to find this amazing piece of code... at least the HACK ALERT was a good hint ). I've attached the patch. It works for me (tested with windows xp as guest os @ 1680x1050). As always, please test the patch. I'd highly appreciate it if somebody could test it with linux as guest os. Patches get me running up to 1920 x 1200 using WinXP guest! Now that I can run higher resolutions I am seeing a screen corruption issue on resolutions greater than 1600x1200. Property dialogs are the easiest way to see the issue, a set of thin horizontal bands through the dialog with the desktop visible. On certain areas of the screen the mouse pointer will also show banding. Les - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)
Andreas Winkelbauer wrote: hi, I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. The crash was caused by a really _dirty_ hack in a kvm specific part of vga.c (it took me at least an hour to find this amazing piece of code... at least the HACK ALERT was a good hint ;-) ). I've attached the patch. It works for me (tested with windows xp as guest os @ 1680x1050). As always, please test the patch. I'd highly appreciate it if somebody could test it with linux as guest os. @Arne: Could you please test the patch with your setup? I hope it works this time... The patch doesn't include the change to VGA_RAM_SIZE! How can this work? Please send separate patches for the bios and qemu. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
[kvm-devel] [PATCH] fix widescreen resolution issues
hi,
the attached patch fixes the issues with widescreen resolutions for me
when using -std-vga.
in vgabios/vbetables-gen.c I changed the video memory from 8MB to 16MB
which is sufficient for resolutions up to 2560x1600. I've also added
some more video modes (up to 2560x1600) with 16, 24, 32bit color depth
each and I've removed the duplicate for the 1280x960 mode.
in qemu/hw/vga_int.h I've adapted the maximum resolution accordingly.
you can download the updated vgabios from http://www.wina.at/vgabios.bin
I would appreciate any suggestions, comments and of course testing.
@Arne Brutschy: could you please test the 1920x1200 resolution with your
setup?
cheers,
Andi
--- kvm-61.orig/vgabios/vbetables-gen.c 2008-02-19 15:58:28.0 +0100
+++ kvm-61/vgabios/vbetables-gen.c 2008-02-20 19:22:48.0 +0100
@@ -2,7 +2,7 @@
#include stdlib.h
#include stdio.h
-#define VBE_DISPI_TOTAL_VIDEO_MEMORY_MB 8
+#define VBE_DISPI_TOTAL_VIDEO_MEMORY_MB 16
typedef struct {
int width;
@@ -55,18 +55,27 @@
{ 1152, 864, 16 , 0x14a},
{ 1152, 864, 24 , 0x14b},
{ 1152, 864, 32 , 0x14c},
-{ 1280, 800, 24 , 0x178},
-{ 1280, 800, 32 , 0x179},
-{ 1280, 960, 24 , 0x180},
-{ 1280, 960, 32 , 0x181},
-{ 1280, 960, 24 , 0x182},
-{ 1280, 960, 32 , 0x183},
-{ 1440, 900, 24 , 0x184},
-{ 1440, 900, 32 , 0x185},
-{ 1400, 1050, 24 , 0x186},
-{ 1400, 1050, 32 , 0x187},
-{ 1680, 1050, 24 , 0x188},
-{ 1680, 1050, 32 , 0x189},
+{ 1280, 800, 16 , 0x178},
+{ 1280, 800, 24 , 0x179},
+{ 1280, 800, 32 , 0x17a},
+{ 1280, 960, 16 , 0x17b},
+{ 1280, 960, 24 , 0x17c},
+{ 1280, 960, 32 , 0x17d},
+{ 1440, 900, 16 , 0x17e},
+{ 1440, 900, 24 , 0x17f},
+{ 1440, 900, 32 , 0x180},
+{ 1400, 1050, 16 , 0x181},
+{ 1400, 1050, 24 , 0x182},
+{ 1400, 1050, 32 , 0x183},
+{ 1680, 1050, 16 , 0x184},
+{ 1680, 1050, 24 , 0x185},
+{ 1680, 1050, 32 , 0x186},
+{ 1920, 1200, 16 , 0x187},
+{ 1920, 1200, 24 , 0x188},
+{ 1920, 1200, 32 , 0x189},
+{ 2560, 1600, 16 , 0x18a},
+{ 2560, 1600, 24 , 0x18b},
+{ 2560, 1600, 32 , 0x18c},
{ 0, },
};
--- kvm-61.orig/qemu/hw/vga_int.h 2008-02-19 15:58:28.0 +0100
+++ kvm-61/qemu/hw/vga_int.h 2008-02-20 19:25:35.0 +0100
@@ -30,8 +30,8 @@
/* bochs VBE support */
#define CONFIG_BOCHS_VBE
-#define VBE_DISPI_MAX_XRES 1600
-#define VBE_DISPI_MAX_YRES 1200
+#define VBE_DISPI_MAX_XRES 2560
+#define VBE_DISPI_MAX_YRES 1600
#define VBE_DISPI_MAX_BPP 32
#define VBE_DISPI_INDEX_ID 0x0
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
