Re: [kvm-devel] [PATCH 1/3] Move common VGAState attributes to VGA_STATE_COMMON
Anthony Liguori wrote: vmware_vga.c uses functions in vga.c to do some things. They need to agree on which parts of their state struct is common and which aren't, otherwise they'll overwrite parts of each other's state. This patch makes it so. Signed-off-by: Soren Hansen [EMAIL PROTECTED] Reviewed-by: Anthony Liguori [EMAIL PROTECTED] The trick to passing through patches is to have a From: Original Author [EMAIL PROTECTED] line in the beginning, which git picks up and uses to maintain authorship information. Also, sign-off normally. Acked-by means I know the author while Reviewed-by means I know the author well. Anyway I applied all these patches, including the vmware BAR patch since it's a dependency. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH 1/3] Move common VGAState attributes to VGA_STATE_COMMON
Avi Kivity wrote: The trick to passing through patches is to have a From: Original Author [EMAIL PROTECTED] line in the beginning, which git picks up and uses to maintain authorship information. Also, sign-off normally. Acked-by means I know the author while Reviewed-by means I know the author well. Does From have to be the first line? git-send-email never seems to do anything with From for me. Regards, Anthony Liguori Anyway I applied all these patches, including the vmware BAR patch since it's a dependency. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH 1/3] Move common VGAState attributes to VGA_STATE_COMMON
Anthony Liguori wrote: Avi Kivity wrote: The trick to passing through patches is to have a From: Original Author [EMAIL PROTECTED] line in the beginning, which git picks up and uses to maintain authorship information. Also, sign-off normally. Acked-by means I know the author while Reviewed-by means I know the author well. Does From have to be the first line? Yes (but after the regular email headers). git-send-email never seems to do anything with From for me. It's 'git am' which is the target of this. When applying such a patch from email, it will set the author automatically. The whole thing should work automatically, so if the patch has the correct authorship in your repo, it should come out fine without further effort. Not sure if format-patch or send-email is responsible. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
