Re: [PATCH] arm64: KVM: Use SMCCC_ARCH_WORKAROUND_1 for Falkor BP hardening

[Timur Tabi]

On Fri, Mar 2, 2018 at 3:50 PM, Shanker Donthineni
 wrote:
> diff --git a/arch/arm64/include/asm/cpucaps.h 
> b/arch/arm64/include/asm/cpucaps.h
> index bb26382..6ecc249 100644
> --- a/arch/arm64/include/asm/cpucaps.h
> +++ b/arch/arm64/include/asm/cpucaps.h
> @@ -43,7 +43,7 @@
>  #define ARM64_SVE  22
>  #define ARM64_UNMAP_KERNEL_AT_EL0  23
>  #define ARM64_HARDEN_BRANCH_PREDICTOR  24
> -#define ARM64_HARDEN_BP_POST_GUEST_EXIT25
> +/* #define ARM64_UNALLOCATED_ENTRY 25 */

Why not just delete the entry?  Is ARM64_NCAPS never supposed to get smaller?
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v3 2/2] arm64: Add software workaround for Falkor erratum 1041

[Timur Tabi]

On Tue, Nov 14, 2017 at 7:05 PM, Stephen Boyd  wrote:

> This also applies to Kryo CPUs. I have a patch[1] for the 1003
> Falkor errata that adds the Kryo MIDR check which can also be
> used for this errata.
>
> [1] https://patchwork.kernel.org/patch/10048987/

Please submit a follow-up patch for E1041 after our patch is merged.
We don't want to submit a patch for your SOCs, even if it's the same
erratum and work-around.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v4 2/4] arm64: Work around Falkor erratum 1003

[Timur Tabi]

On 01/25/2017 09:52 AM, Christopher Covington wrote:

+   .desc = "Qualcomm Falkor erratum 1003",


FYI, this needs to say, "Qualcomm Technologies Falkor ...".  Same thing with 
the 1009 patch.


--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v3 2/5] arm64: Work around Falkor erratum 1003

[Timur Tabi]

On 01/11/2017 12:37 PM, Mark Rutland wrote:

The name, as it is, is perfectly descriptive.

Let's not sacrifice legibility over a non-issue.


I don't want to kick a dead horse or anything, but changing it to 
QCOM_FLKR_ERRATUM_1003 would eliminate all the spacing problems without 
sacrificing anything.


--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003

[Timur Tabi]

Christopher Covington wrote:

> Also, since this can't be changed via the menu, why bother putting it in?

I put it in in response to review comments asking for the magic number to
be clarified by a #define or variable. I could not find a suitably shared
header between the files in question, so I used the Kconfig machinery to
generate the #define.


I don't think that's the right approach.  Kconfigs are not an 
alternative to header files.  Is the ASID configurable?  If you just put 
some text after the "int" then it because a menu option that the user 
can select and change.


--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003

[Timur Tabi]

Christopher Covington wrote:

> Looks like you've made an unrelated whitespace change that affected the 
entire table,
> not just the line you're adding.

I'm making space for "QCOM_FALKOR_ERRATUM_1003".


Ok, but you're also shrinking the other columns.  I think a better 
solution is to make the macro shorter. QCOM_ERRATUM_FLK1003?


--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003

[Timur Tabi]

On 12/29/2016 04:43 PM, Christopher Covington wrote:

+config QCOM_FALKOR_E1003_RESERVED_ASID
+   int
+   default 1
+   depends on QCOM_FALKOR_ERRATUM_1003


Also, since this can't be changed via the menu, why bother putting it in?

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003

[Timur Tabi]

On 12/29/2016 04:43 PM, Christopher Covington wrote:

-| Implementor| Component   | Erratum ID  | Kconfig 
|
-++-+-+-+
-| ARM| Cortex-A53  | #826319 | ARM64_ERRATUM_826319
|
-| ARM| Cortex-A53  | #827319 | ARM64_ERRATUM_827319
|
-| ARM| Cortex-A53  | #824069 | ARM64_ERRATUM_824069
|
-| ARM| Cortex-A53  | #819472 | ARM64_ERRATUM_819472
|
-| ARM| Cortex-A53  | #845719 | ARM64_ERRATUM_845719
|
-| ARM| Cortex-A53  | #843419 | ARM64_ERRATUM_843419
|
-| ARM| Cortex-A57  | #832075 | ARM64_ERRATUM_832075
|
-| ARM| Cortex-A57  | #852523 | N/A 
|
-| ARM| Cortex-A57  | #834220 | ARM64_ERRATUM_834220
|
-| ARM| Cortex-A72  | #853709 | N/A 
|
-| ARM| MMU-500 | #841119,#826419 | N/A 
|
-|| | | 
|
-| Cavium | ThunderX ITS| #22375, #24313  | CAVIUM_ERRATUM_22375
|
-| Cavium | ThunderX ITS| #23144  | CAVIUM_ERRATUM_23144
|
-| Cavium | ThunderX GICv3  | #23154  | CAVIUM_ERRATUM_23154
|
-| Cavium | ThunderX Core   | #27456  | CAVIUM_ERRATUM_27456
|
-| Cavium | ThunderX SMMUv2 | #27704  | N/A|
-|| | | 
|
-| Freescale/NXP  | LS2080A/LS1043A | A-008585| FSL_ERRATUM_A008585 
|
+| Implementor   | Component   | Erratum ID  | Kconfig  
|
++---+-+-+--+
+| ARM   | Cortex-A53  | #826319 | ARM64_ERRATUM_826319 
|
+| ARM   | Cortex-A53  | #827319 | ARM64_ERRATUM_827319 
|
+| ARM   | Cortex-A53  | #824069 | ARM64_ERRATUM_824069 
|
+| ARM   | Cortex-A53  | #819472 | ARM64_ERRATUM_819472 
|
+| ARM   | Cortex-A53  | #845719 | ARM64_ERRATUM_845719 
|
+| ARM   | Cortex-A53  | #843419 | ARM64_ERRATUM_843419 
|
+| ARM   | Cortex-A57  | #832075 | ARM64_ERRATUM_832075 
|
+| ARM   | Cortex-A57  | #852523 | N/A  
|
+| ARM   | Cortex-A57  | #834220 | ARM64_ERRATUM_834220 
|
+| ARM   | Cortex-A72  | #853709 | N/A  
|
+| ARM   | MMU-500 | #841119,#826419 | N/A  
|
+|   | | |  
|
+| Cavium| ThunderX ITS| #22375, #24313  | CAVIUM_ERRATUM_22375 
|
+| Cavium| ThunderX ITS| #23144  | CAVIUM_ERRATUM_23144 
|
+| Cavium| ThunderX GICv3  | #23154  | CAVIUM_ERRATUM_23154 
|
+| Cavium| ThunderX Core   | #27456  | CAVIUM_ERRATUM_27456 
|
+| Cavium| ThunderX SMMUv2 | #27704  | N/A  
|
+|   | | |  
|
+| Freescale/NXP | LS2080A/LS1043A | A-008585| FSL_ERRATUM_A008585  
|
+| Qualcomm  | Falkor v1   | E1003   | QCOM_FALKOR_ERRATUM_1003 
|


Looks like you've made an unrelated whitespace change that affected the entire 
table,
not just the line you're adding.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH] arm64/kvm: Add generic v8 KVM target

[Timur Tabi]

On 06/17/2015 04:00 AM, Suzuki K. Poulose wrote:

  genericv8_target_table);
kvm_register_target_sys_reg_table(KVM_ARM_TARGET_XGENE_POTENZA,
  genericv8_target_table);
+   kvm_register_target_sys_reg_table(KVM_ARM_TARGET_GENERIC_V8,
+ genericv8_target_table);



Shouldn't you also remove all of the previous lines that return 
genericv8_target_table?


--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm