Re: [PATCH 08/10] KVM: arm/arm64: vgic: Add vgic_{get, set}_phys_irq_active

[Eric Auger]

Reviewed-by: Eric Auger eric.au...@linaro.org
On 06/08/2015 07:04 PM, Marc Zyngier wrote:
 In order to control the active state of an interrupt, introduce
 a pair of accessors allowing the state to be set/queried.
 
 This only affects the logical state, and the HW state will only be
 applied at world-switch time.
 
 Signed-off-by: Marc Zyngier marc.zyng...@arm.com
 ---
  include/kvm/arm_vgic.h |  2 ++
  virt/kvm/arm/vgic.c| 12 
  2 files changed, 14 insertions(+)
 
 diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h
 index 33d121a..1c653c1 100644
 --- a/include/kvm/arm_vgic.h
 +++ b/include/kvm/arm_vgic.h
 @@ -349,6 +349,8 @@ int kvm_vgic_vcpu_active_irq(struct kvm_vcpu *vcpu);
  struct irq_phys_map *vgic_map_phys_irq(struct kvm_vcpu *vcpu,
  int virt_irq, int irq);
  int vgic_unmap_phys_irq(struct kvm_vcpu *vcpu, struct irq_phys_map *map);
 +bool vgic_get_phys_irq_active(struct irq_phys_map *map);
 +void vgic_set_phys_irq_active(struct irq_phys_map *map, bool active);
  
  #define irqchip_in_kernel(k) (!!((k)-arch.vgic.in_kernel))
  #define vgic_initialized(k)  (!!((k)-arch.vgic.nr_cpus))
 diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c
 index 495ac7d..f376b56 100644
 --- a/virt/kvm/arm/vgic.c
 +++ b/virt/kvm/arm/vgic.c
 @@ -1744,6 +1744,18 @@ static struct irq_phys_map *vgic_irq_map_search(struct 
 kvm_vcpu *vcpu,
   return this;
  }
  
 +bool vgic_get_phys_irq_active(struct irq_phys_map *map)
 +{
 + BUG_ON(!map);
 + return map-active;
 +}
 +
 +void vgic_set_phys_irq_active(struct irq_phys_map *map, bool active)
 +{
 + BUG_ON(!map);
 + map-active = active;
 +}
 +
  int vgic_unmap_phys_irq(struct kvm_vcpu *vcpu, struct irq_phys_map *map)
  {
   struct vgic_dist *dist = vcpu-kvm-arch.vgic;
 

___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

[PATCH 08/10] KVM: arm/arm64: vgic: Add vgic_{get, set}_phys_irq_active

[Marc Zyngier]

In order to control the active state of an interrupt, introduce
a pair of accessors allowing the state to be set/queried.

This only affects the logical state, and the HW state will only be
applied at world-switch time.

Signed-off-by: Marc Zyngier marc.zyng...@arm.com
---
 include/kvm/arm_vgic.h |  2 ++
 virt/kvm/arm/vgic.c| 12 
 2 files changed, 14 insertions(+)

diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h
index 33d121a..1c653c1 100644
--- a/include/kvm/arm_vgic.h
+++ b/include/kvm/arm_vgic.h
@@ -349,6 +349,8 @@ int kvm_vgic_vcpu_active_irq(struct kvm_vcpu *vcpu);
 struct irq_phys_map *vgic_map_phys_irq(struct kvm_vcpu *vcpu,
   int virt_irq, int irq);
 int vgic_unmap_phys_irq(struct kvm_vcpu *vcpu, struct irq_phys_map *map);
+bool vgic_get_phys_irq_active(struct irq_phys_map *map);
+void vgic_set_phys_irq_active(struct irq_phys_map *map, bool active);
 
 #define irqchip_in_kernel(k)   (!!((k)-arch.vgic.in_kernel))
 #define vgic_initialized(k)(!!((k)-arch.vgic.nr_cpus))
diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c
index 495ac7d..f376b56 100644
--- a/virt/kvm/arm/vgic.c
+++ b/virt/kvm/arm/vgic.c
@@ -1744,6 +1744,18 @@ static struct irq_phys_map *vgic_irq_map_search(struct 
kvm_vcpu *vcpu,
return this;
 }
 
+bool vgic_get_phys_irq_active(struct irq_phys_map *map)
+{
+   BUG_ON(!map);
+   return map-active;
+}
+
+void vgic_set_phys_irq_active(struct irq_phys_map *map, bool active)
+{
+   BUG_ON(!map);
+   map-active = active;
+}
+
 int vgic_unmap_phys_irq(struct kvm_vcpu *vcpu, struct irq_phys_map *map)
 {
struct vgic_dist *dist = vcpu-kvm-arch.vgic;
-- 
2.1.4

___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm