Re: [PATCH V4 10/10] arm64: KVM: add guest SEA support
On Mon, Oct 31, 2016 at 04:36:33PM -0600, Baicar, Tyler wrote: > Hello Russell, > > On 10/31/2016 4:02 AM, Russell King - ARM Linux wrote: > >The subject line on this patch is misleading - it's not only ARM64 > >specific... > Thank you for the feedback! > > I only put ARM64 in the subject line because this patch only really adds > guest SEA support for the ARM64 KVM code. The ARM code had to be edited > since both the ARM and ARM64 KVM code use arch/arm/kvm/mmu.c. I can change > the subject line to "arm/arm64: KVM: add guest SEA support" if you think > that is better. Yes please, I almost skipped over it while catching up because it didn't say "arm", it was only that I'd happened to read the cover message that I'd spotted arch/arm in the diffstat, and then had to go digging for the changes to review. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Re: [PATCH V4 10/10] arm64: KVM: add guest SEA support
Hello Russell,
On 10/31/2016 4:02 AM, Russell King - ARM Linux wrote:
The subject line on this patch is misleading - it's not only ARM64
specific...
Thank you for the feedback!
I only put ARM64 in the subject line because this patch only really adds
guest SEA support for the ARM64 KVM code. The ARM code had to be edited
since both the ARM and ARM64 KVM code use arch/arm/kvm/mmu.c. I can
change the subject line to "arm/arm64: KVM: add guest SEA support" if
you think that is better.
On Fri, Oct 21, 2016 at 11:30:13AM -0600, Tyler Baicar wrote:
diff --git a/arch/arm/include/asm/system_misc.h
b/arch/arm/include/asm/system_misc.h
index a3d61ad..86e1faa 100644
--- a/arch/arm/include/asm/system_misc.h
+++ b/arch/arm/include/asm/system_misc.h
@@ -24,4 +24,9 @@ extern unsigned int user_debug;
#endif /* !__ASSEMBLY__ */
+inline int handle_guest_sea(unsigned long addr, unsigned int esr)
This needs to be static.
I'll make this static.
Thanks,
Tyler
+{
+ return -1;
+}
+
#endif /* __ASM_ARM_SYSTEM_MISC_H */
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Re: [PATCH V4 10/10] arm64: KVM: add guest SEA support
The subject line on this patch is misleading - it's not only ARM64
specific...
On Fri, Oct 21, 2016 at 11:30:13AM -0600, Tyler Baicar wrote:
> diff --git a/arch/arm/include/asm/system_misc.h
> b/arch/arm/include/asm/system_misc.h
> index a3d61ad..86e1faa 100644
> --- a/arch/arm/include/asm/system_misc.h
> +++ b/arch/arm/include/asm/system_misc.h
> @@ -24,4 +24,9 @@ extern unsigned int user_debug;
>
> #endif /* !__ASSEMBLY__ */
>
> +inline int handle_guest_sea(unsigned long addr, unsigned int esr)
This needs to be static.
> +{
> + return -1;
> +}
> +
> #endif /* __ASM_ARM_SYSTEM_MISC_H */
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
___
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
