Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/notify-changed-by-field into lp:launchpad
Review: Approve code Diff comments: > === modified file 'lib/lp/soyuz/mail/packageupload.py' > --- lib/lp/soyuz/mail/packageupload.py2015-09-02 12:05:15 + > +++ lib/lp/soyuz/mail/packageupload.py2016-10-16 13:55:46 + > @@ -338,6 +342,17 @@ > add_recipient( > recipients, permission.person, > PackageUploadRecipientReason.forPPAUploader, > logger=logger) > + > +# If the "Launchpad-Notify-Changed-By: yes" field is set in the > +# .changes file, we also consider changed-by. The latter is > +# intended for use by systems that automatically sign uploads on > +# behalf of developers, in which case we want to make sure to > +# notify the developer in question. I think the key point is this: unlike normal PPA users, we assume that a system that is clever enough to set Launchpad-Notify-Changed-By is probably also clever enough to not be unthinkingly uploading things with misleading Changed-Bys. > +if info['notify_changed_by']: > +debug(logger, "Adding changed-by to recipients") > +add_recipient( > +recipients, changer, > +PackageUploadRecipientReason.forChangedBy, logger=logger) > elif archive.is_copy: > # For copy archives, notifying anyone else will probably only > # confuse them. -- https://code.launchpad.net/~cjwatson/launchpad/notify-changed-by-field/+merge/308587 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-refactor-name-validation into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-refactor-name-validation/+merge/308576 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/codeimport-git-namespace-macaroons into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-namespace-macaroons/+merge/308902 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-contents-header into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-contents-header/+merge/309750 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pcj-better-oops into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/pcj-better-oops/+merge/308612 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
