[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup into lp:launchpad
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup into lp:launchpad has been updated. Description changed to: Sitesearch code cleanup: - Add unittests based on sitesearch doctests. - These doctests are still tested; unsure of removing as they're still useful documentation. - Add tests for PageMatch and PageMatches. - Use test scenarios to deduplicate sitesearch testservices testing code. - Deduplicate lp.app.browser search doctests. - Run lp.app.stories.launchpad_search.site-search.txt on all search backends (was launchpad_root.site-search.txt). - Fix permissions on googletestservice.py script. - Fix content type of bingtestservice responses. - Move config.{bing,google}.url_rewrite_exceptions into config.sitesearch. - Update python sources following the standard template. - Make Bing the default (see https://code.launchpad.net/~maxiberta/launchpad/sitesearch-default-bing/+merge/342473). For more details, see: https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup/+merge/342472 -- Your team Launchpad code reviewers is requested to review the proposed merge of lp:~maxiberta/launchpad/sitesearch-cleanup into lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup into lp:launchpad
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup into lp:launchpad has been updated. Description changed to: Sitesearch code cleanup: - Add unittests based on sitesearch doctests. - These doctests are still tested; unsure of removing as they're still useful documentation. - Add tests for PageMatch and PageMatches. - Use test scenarios to deduplicate sitesearch testservices testing code. - Deduplicate lp.app.browser search doctests. - Run lp.app.stories.launchpad_search.site-search.txt on all search backends (was launchpad_root.site-search.txt). - Fix permissions on googletestservice.py script. - Fix content type of bingtestservice responses. - Move config.{bing,google}.url_rewrite_exceptions into config.sitesearch. - Update python sources following the standard template. For more details, see: https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup/+merge/342472 -- Your team Launchpad code reviewers is requested to review the proposed merge of lp:~maxiberta/launchpad/sitesearch-cleanup into lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/sitesearch-cleanup into lp:launchpad
The proposal to merge lp:~maxiberta/launchpad/sitesearch-cleanup into lp:launchpad has been updated. Description changed to: Sitesearch code cleanup: - Add unittests based on sitesearch doctests. - These doctests are still tested; unsure of removing as they're still useful documentation. - Add tests for PageMatch and PageMatches. - Use test scenarios to deduplicate sitesearch testservices testing code. - Fix permissions on googletestservice.py script. - Fix content type of bingtestservice responses. - Move config.{bing,google}.url_rewrite_exceptions into config.sitesearch. - Update python sources following the standard template. For more details, see: https://code.launchpad.net/~maxiberta/launchpad/sitesearch-cleanup/+merge/342472 -- Your team Launchpad code reviewers is requested to review the proposed merge of lp:~maxiberta/launchpad/sitesearch-cleanup into lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp