Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/job-oops-timeline into lp:launchpad
Review: Approve code Last time I looked at this I decided I didn't really want to risk enabling SQL logging for jobs (see the request_starttime conditon in connection_raw_execute), but it shouldn't be too terrible hopefully. -- https://code.launchpad.net/~cjwatson/launchpad/job-oops-timeline/+merge/341554 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/gpg-timeline into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/gpg-timeline/+merge/340554 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-build-channels into lp:launchpad
Review: Approve code
Diff comments:
> === modified file 'lib/lp/snappy/interfaces/snap.py'
> --- lib/lp/snappy/interfaces/snap.py 2017-08-22 11:36:30 +
> +++ lib/lp/snappy/interfaces/snap.py 2018-02-08 13:37:58 +
> @@ -281,17 +282,23 @@
> @operation_parameters(
> archive=Reference(schema=IArchive),
> distro_arch_series=Reference(schema=IDistroArchSeries),
> -pocket=Choice(vocabulary=PackagePublishingPocket))
> +pocket=Choice(vocabulary=PackagePublishingPocket),
> +channels=Dict(
> +title=_("Source channels to use for this build."),
Can you copy_field this from ISnapBuild['channels'], or at least bring the
title across from there?
> +key_type=TextLine(), required=False))
> # Really ISnapBuild, patched in lp.snappy.interfaces.webservice.
> @export_factory_operation(Interface, [])
> @operation_for_version("devel")
> -def requestBuild(requester, archive, distro_arch_series, pocket):
> +def requestBuild(requester, archive, distro_arch_series, pocket,
> + channels=None):
> """Request that the snap package be built.
>
> :param requester: The person requesting the build.
> :param archive: The IArchive to associate the build with.
> :param distro_arch_series: The architecture to build for.
> :param pocket: The pocket that should be targeted.
> +:param channels: A dictionary mapping snap names to channels to use
> +for this build.
> :return: `ISnapBuild`.
> """
>
> @@ -509,6 +516,14 @@
> "The package stream within the source distribution series to use
> "
> "when building the snap package.")))
>
> +auto_build_channels = exported(Dict(
> +title=_("Source channels for automatic builds"),
"Source snap channels" maybe? Otherwise it sounds like some weird source code
thing.
> +key_type=TextLine(), required=False, readonly=False,
> +description=_(
> +"A dictionary mapping snap names to channels to use when
> building "
> +"this snap package. Currently only 'core' and 'snapcraft' keys "
> +"are supported.")))
> +
> is_stale = Bool(
> title=_("Snap package is stale and is due to be rebuilt."),
> required=True, readonly=False)
>
> === modified file 'lib/lp/snappy/model/snap.py'
> --- lib/lp/snappy/model/snap.py 2017-11-10 11:23:27 +
> +++ lib/lp/snappy/model/snap.py 2018-02-08 13:37:58 +
> @@ -917,6 +926,15 @@
> SnapBuild.snap_id == Snap.id,
> SnapBuild.archive_id == Snap.auto_build_archive_id,
> SnapBuild.pocket == Snap.auto_build_pocket,
> +# These columns are nullable so require some care, since
> +# a straightforward equality check will compile to
> +# "SnapBuild.channels = Snap.auto_build_channels" which
> +# is false if both are NULL.
> +Or(
> +And(
> +SnapBuild.channels == None,
> +Snap.auto_build_channels == None),
> +SnapBuild.channels == Snap.auto_build_channels),
IsDistinctFrom?
> # We only want Snaps that haven't had an automatic
> # SnapBuild dispatched for them recently.
> SnapBuild.date_created >= threshold_date)),
--
https://code.launchpad.net/~cjwatson/launchpad/snap-build-channels/+merge/337360
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/archivepublisher-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/archivepublisher-tests-future-imports/+merge/337053 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/optimise-spec-search into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/optimise-spec-search/+merge/338425 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/ppa-vocabulary-strip-prefix into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/ppa-vocabulary-strip-prefix/+merge/340257 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dispatch-build-url into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/dispatch-build-url/+merge/340249 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/anon-dsp into lp:launchpad
William Grant has proposed merging lp:~wgrant/launchpad/anon-dsp into lp:launchpad. Commit message: Allow anonymous launchpad.View on IDistributionSourcePackage. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~wgrant/launchpad/anon-dsp/+merge/338362 Allow anonymous launchpad.View on IDistributionSourcePackage. -- Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/anon-dsp into lp:launchpad. === modified file 'lib/lp/security.py' --- lib/lp/security.py 2017-07-18 16:22:03 + +++ lib/lp/security.py 2018-02-21 01:10:49 + @@ -1167,6 +1167,11 @@ return user.isOwner(self.obj) or user.in_admin +class ViewDistributionSourcePackage(AnonymousAuthorization): +"""Anyone can view a DistributionSourcePackage.""" +usedfor = IDistributionSourcePackage + + class BugSuperviseDistributionSourcePackage(AuthorizationBase): """The owner of a distribution should be able to edit its source package information""" ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/refactor-run-parts-subprocess into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/refactor-run-parts-subprocess/+merge/336298 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/soyuz-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/soyuz-tests-future-imports/+merge/337042 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pep-3113 into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/pep-3113/+merge/336686 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/no-legacy-store-search into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/no-legacy-store-search/+merge/337122 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/no-xrange into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/no-xrange/+merge/337044 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/range-iterator into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/range-iterator/+merge/337043 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/soyuz-browser-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/soyuz-browser-tests-future-imports/+merge/337010 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/who-cares-about-anonymous-consumer-keys into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/who-cares-about-anonymous-consumer-keys/+merge/336864 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/buildmaster-getFile-rename into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/buildmaster-getFile-rename/+merge/336709 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/no-explicit-keyserver-port into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/no-explicit-keyserver-port/+merge/336724 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/more-obvious-updating-repository-notice into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/more-obvious-updating-repository-notice/+merge/336680 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-webservice-get-commit into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-webservice-get-commit/+merge/336604 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/always-https-codebrowse into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/always-https-codebrowse/+merge/336376 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/zope.pagetemplate-4.3.0 into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/zope.pagetemplate-4.3.0/+merge/335582 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/twisted-16.5.0 into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/twisted-16.5.0/+merge/335534 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/modern-testtools-cleanup into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/modern-testtools-cleanup/+merge/335396 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/no-logtail-only-webhooks into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/no-logtail-only-webhooks/+merge/336479 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/buildd-manager-feature-controller into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/buildd-manager-feature-controller/+merge/336018 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/build-score-threshold-arch into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/build-score-threshold-arch/+merge/335934 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/build-score-threshold-feature into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/build-score-threshold-feature/+merge/335861 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/upgrade-testtools into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/upgrade-testtools/+merge/335395 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/docutils-0.14 into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/docutils-0.14/+merge/335551 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pypi-dulwich into lp:launchpad
Review: Approve code Diff comments: > > === modified file 'sourcecode/Makefile' > --- sourcecode/Makefile 2011-11-07 20:29:29 + > +++ sourcecode/Makefile 2017-12-22 10:00:58 + > @@ -3,7 +3,7 @@ > # the ones we test. If we fix them all to have EITHER a good makefile > # (build and check targets work), or no makefile we can reenable auto > # detection. > -build_dirs:=cscvs dulwich pygettextpo pygpgme subvertpy > +build_dirs:=cscvs pygettextpo pygpgme subvertpy Might as well ditch pygpgme and subvertpy while you're here. > test_dirs:=cscvs pygettextpo > > TEST_ENV_VARS = PYTHON=$(PYTHON) -- https://code.launchpad.net/~cjwatson/launchpad/pypi-dulwich/+merge/335539 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/upgrade-keystoneclient-swiftclient into lp:launchpad
Review: Approve code
We'll probably need to tweak staging configs a bit to effectively test this.
Have you verified in any depth against a non-prod Swift?
Diff comments:
>
> === modified file 'lib/lp/services/librarianserver/swift.py'
> --- lib/lp/services/librarianserver/swift.py 2015-02-16 00:09:14 +
> +++ lib/lp/services/librarianserver/swift.py 2017-12-19 17:02:21 +
> @@ -29,6 +34,23 @@
> ONE_DAY = 24 * 60 * 60
>
>
> +@contextmanager
> +def disable_swiftclient_logging():
Given how this tends to be used, I'd be tempted to make it
dammit_openstack_first_pbr_now_this(func, *args, **kwargs), allowing you to
collapse most of the wrapper functions. A few extra assignment operations (due
to the lack of nesting) won't hurt that much.
> +# swiftclient has some very rude logging practices: the low-level API
> +# calls `logger.exception` when a request fails, without considering
> +# whether the caller might handle it and recover. This was introduced
> +# in 1.6.0 and removed in 3.2.0; until we're on a new enough version not
> +# to need to worry about this, we shut up the noisy logging around calls
> +# whose failure we can handle.
Do XXX this; we'll upgrade past the badness relatively soon, but this
unhighlighted comment is sure to be missed.
> +# Messier still, logging.getLogger('swiftclient') doesn't necessarily
> +# refer to the Logger instance actually being used by swiftclient, so we
> +# have to use swiftclient.logger directly.
> +old_disabled = swiftclient.logger.disabled
> +swiftclient.logger.disabled = True
> +yield
> +swiftclient.logger.disabled = old_disabled
> +
> +
> def to_swift(log, start_lfc_id=None, end_lfc_id=None, remove_func=False):
> '''Copy a range of Librarian files from disk into Swift.
>
--
https://code.launchpad.net/~cjwatson/launchpad/upgrade-keystoneclient-swiftclient/+merge/335391
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/tidy-makefile into lp:launchpad
Review: Approve code Diff comments: > === modified file 'Makefile' > --- Makefile 2018-01-01 20:24:26 + > +++ Makefile 2018-01-02 04:49:50 + > @@ -472,6 +468,7 @@ > -e 's,%LISTEN_ADDRESS%,$(LISTEN_ADDRESS),' \ > configs/development/local-launchpad-apache > \ > /etc/apache2/sites-available/$$base > + mkdir -p $(CODEHOSTING_ROOT) This is *meant* to be arranged by codehosting-dir, though that 777 is pretty sweet. Should we just fix that up to DTRT and dep on it? > touch $(CODEHOSTING_ROOT)/rewrite.log > chown -R $(SUDO_UID):$(SUDO_GID) $(CODEHOSTING_ROOT) > if [ ! -d /srv/launchpad.dev ]; then \ -- https://code.launchpad.net/~cjwatson/launchpad/tidy-makefile/+merge/335614 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/eslint-eqeqeq into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/eslint-eqeqeq/+merge/335615 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/eslint-regexes into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/eslint-regexes/+merge/335613 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/relocate-mailman into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/relocate-mailman/+merge/335535 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/buildqueue-hide-empty into lp:launchpad
William Grant has proposed merging lp:~wgrant/launchpad/buildqueue-hide-empty
into lp:launchpad.
Commit message:
Hide the virt/nonvirt queue portlets on BuilderSet:+index if they'd be empty.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~wgrant/launchpad/buildqueue-hide-empty/+merge/335533
Hide the virt/nonvirt queue portlets on BuilderSet:+index if they'd be empty.
--
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~wgrant/launchpad/buildqueue-hide-empty into lp:launchpad.
=== modified file 'lib/lp/buildmaster/browser/tests/test_builder.py'
--- lib/lp/buildmaster/browser/tests/test_builder.py 2015-10-21 09:37:08 +
+++ lib/lp/buildmaster/browser/tests/test_builder.py 2017-12-21 21:06:05 +
@@ -12,6 +12,7 @@
from lp.buildmaster.interfaces.builder import IBuilderSet
from lp.services.job.model.job import Job
from lp.testing import (
+admin_logged_in,
record_two_runs,
TestCaseWithFactory,
)
@@ -22,7 +23,7 @@
def builders_homepage_render():
builders = getUtility(IBuilderSet)
-create_initialized_view(builders, "+index").render()
+return create_initialized_view(builders, "+index").render()
class TestBuildersHomepage(TestCaseWithFactory, BuildCreationMixin):
@@ -90,3 +91,27 @@
recorder1, recorder2 = record_two_runs(
builders_homepage_render, create_builds, nb_objects)
self.assertThat(recorder2, HasQueryCount.byEquality(recorder1))
+
+def test_category_portlet_not_shown_if_empty(self):
+content = builders_homepage_render()
+self.assertIn("Virtual build status", content)
+self.assertIn("Non-virtual build status", content)
+
+with admin_logged_in():
+getUtility(IBuilderSet).getByName('frog').active = False
+content = builders_homepage_render()
+self.assertNotIn("Virtual build status", content)
+self.assertIn("Non-virtual build status", content)
+
+with admin_logged_in():
+getUtility(IBuilderSet).getByName('bob').active = False
+getUtility(IBuilderSet).getByName('frog').active = True
+content = builders_homepage_render()
+self.assertIn("Virtual build status", content)
+self.assertNotIn("Non-virtual build status", content)
+
+with admin_logged_in():
+getUtility(IBuilderSet).getByName('frog').active = False
+content = builders_homepage_render()
+self.assertNotIn("Virtual build status", content)
+self.assertNotIn("Non-virtual build status", content)
=== modified file 'lib/lp/buildmaster/templates/builders-index.pt'
--- lib/lp/buildmaster/templates/builders-index.pt 2016-10-03 13:02:24 +
+++ lib/lp/buildmaster/templates/builders-index.pt 2017-12-21 21:06:05 +
@@ -79,17 +79,19 @@
-
+
-
+
-
+
-
+
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/virtualenv-pip into lp:launchpad
Review: Approve code I've played with it locally and can't obviously break it. I'm sure it'll break the build process and production in unknown ways, but we can hardly avoid that. -- https://code.launchpad.net/~cjwatson/launchpad/virtualenv-pip/+merge/331388 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/tidy-swift-fixture into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/tidy-swift-fixture/+merge/334917 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/webservice-commit-feature-flag into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/webservice-commit-feature-flag/+merge/335287 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/refresh-test-ssh-key into lp:launchpad
Review: Approve code "Twisted >= 16.0.0 uses cryptography, which forbids such short keys." is a little ambiguous, but neither meaning is particularly wrong... -- https://code.launchpad.net/~cjwatson/launchpad/refresh-test-ssh-key/+merge/335257 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bmp-export-scheduleDiffUpdates into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/bmp-export-scheduleDiffUpdates/+merge/334256 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad-buildd/buildd-slave-tac-manifest-fix into lp:launchpad-buildd
William Grant has proposed merging lp:~wgrant/launchpad-buildd/buildd-slave-tac-manifest-fix into lp:launchpad-buildd. Commit message: Fix inclusion of buildd-slave.tac in MANIFEST.in. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~wgrant/launchpad-buildd/buildd-slave-tac-manifest-fix/+merge/334234 Fix inclusion of buildd-slave.tac in MANIFEST.in. -- Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad-buildd/buildd-slave-tac-manifest-fix into lp:launchpad-buildd. === modified file 'MANIFEST.in' --- MANIFEST.in 2017-09-08 17:26:34 + +++ MANIFEST.in 2017-11-24 12:27:50 + @@ -11,4 +11,5 @@ include debian/changelog include sbuildrc include template-buildd-slave.conf -recursive-include lpbuildd/tests *.diff *.tar.gz buildd-slave.tac buildd-slave-test.conf buildlog buildlog.long +include lpbuildd/buildd-slave.tac +recursive-include lpbuildd/tests *.diff *.tar.gz buildd-slave-test.conf buildlog buildlog.long === modified file 'debian/changelog' --- debian/changelog 2017-11-22 15:31:09 + +++ debian/changelog 2017-11-24 12:27:50 + @@ -1,5 +1,6 @@ launchpad-buildd (157) UNRELEASED; urgency=medium + [ Colin Watson ] * Normalise Python packaging. We now install our modules on the normal system path, using pybuild. setup.py now installs buildd-slave.tac in the lpbuildd package rather than data_files in order not to pollute the @@ -7,6 +8,9 @@ * Fall back to the package name from AC_INIT when expanding $(PACKAGE) in translation configuration files if no other definition can be found. + [ William Grant ] + * Fix inclusion of buildd-slave.tac in MANIFEST.in. + -- Colin Watson <cjwat...@ubuntu.com> Wed, 22 Nov 2017 15:24:06 + launchpad-buildd (156) xenial; urgency=medium ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/upgrade-zope-interface into lp:launchpad
Review: Approve code Yes. -- https://code.launchpad.net/~cjwatson/launchpad/upgrade-zope-interface/+merge/334110 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/use-more-statistics into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/use-more-statistics/+merge/333933 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-rocketfuel-flakes-leftover into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-rocketfuel-flakes-leftover/+merge/333932 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/download-cache-git into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/download-cache-git/+merge/333931 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/staging-restore-hax into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~wgrant/launchpad/staging-restore-hax/+merge/333787 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/staging-restore-hax into lp:launchpad
William Grant has proposed merging lp:~wgrant/launchpad/staging-restore-hax
into lp:launchpad.
Commit message:
Fix staging restores and make them more verbose.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~wgrant/launchpad/staging-restore-hax/+merge/333787
Fix staging restores and make them more verbose.
--
Your team Launchpad code reviewers is requested to review the proposed merge of
lp:~wgrant/launchpad/staging-restore-hax into lp:launchpad.
=== modified file 'database/replication/Makefile'
--- database/replication/Makefile 2016-09-06 14:02:09 +
+++ database/replication/Makefile 2017-11-16 03:40:07 +
@@ -56,8 +56,10 @@
stagingsetup:
# List the dump first to make sure it is usable before destroying
# anything.
+ # XXX wgrant 2017-11-16: Exclude tsearch2 bits that are
+ # erreonously being dumped now.
pg_restore --list ${STAGING_DUMP} | grep -v 'TRIGGER public _sl_' \
- > ${DUMPLIST}
+ | grep -v 'OPERATOR FAMILY ts2' > ${DUMPLIST}
# Deny new connections to the main DBs and kill any leftovers.
${STAGING_PGBOUNCER} -c 'DISABLE launchpad_staging'
@@ -82,7 +84,7 @@
cat ${STAGING_DUMP} \
| ./walblock.py -n 5000 -d /var/lib/postgresql/9.3/staging/pg_xlog \
| pg_restore --dbname=lpmain_staging --no-owner ${EXIT_ON_ERROR} \
- --use-list=${DUMPLIST}
+ --use-list=${DUMPLIST} -v
rm ${DUMPLIST}
# Apply database patches.
@echo Running upgrade.py `date`.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-fix-js-status into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-fix-js-status/+merge/330015 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/utilities-run-as into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/utilities-run-as/+merge/332290 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/beautifulsoup-wrapper into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/beautifulsoup-wrapper/+merge/332599 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/beautifulsoup-no-deprecated into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/beautifulsoup-no-deprecated/+merge/332601 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/gather-more-statistics into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/gather-more-statistics/+merge/333481 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/front-page-bulk into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/front-page-bulk/+merge/333510 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/hasquerycount-legible-mismatch into lp:launchpad
Review: Approve code Oh nice, I hadn't realised colourisation was viable. -- https://code.launchpad.net/~cjwatson/launchpad/hasquerycount-legible-mismatch/+merge/333244 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/branch-unscan-affordances into lp:launchpad
Review: Approve code Diff comments: > > === modified file 'lib/lp/code/interfaces/branch.py' > --- lib/lp/code/interfaces/branch.py 2016-11-11 12:51:58 + > +++ lib/lp/code/interfaces/branch.py 2017-11-06 09:48:10 + > @@ -538,6 +538,10 @@ > pending_writes = Attribute( > "Whether there is new Bazaar data for this branch.") > > +pending_updates = Attribute( > +"Whether there is an update job of some kind (mirroring or scanning) > " > +"pending for the Bazaar data in this branch.") Perhaps worth noting that this isn't always true when pending_writes is. A naïve reading would leave one with an erroneous assumption. > + > def latest_revisions(quantity=10): > """A specific number of the latest revisions in that branch.""" > -- https://code.launchpad.net/~cjwatson/launchpad/branch-unscan-affordances/+merge/333251 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-precise-hacks into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-precise-hacks/+merge/332892 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/improve-dpkg-architecture-cache into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/improve-dpkg-architecture-cache/+merge/332853 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/eslint into lp:launchpad
Review: Approve code Diff comments: > > === modified file 'utilities/lint' > --- utilities/lint2017-01-17 22:23:39 + > +++ utilities/lint2017-07-23 03:47:01 + > @@ -31,10 +31,21 @@ > fi > > # Sample data contains auto generated files with long lines. > -pocketlint_files=`echo "$files" | env -i grep -v ".sql$"` > +pocketlint_files=`echo "$files" | env -i grep -v '\.sql$'` Probably worth renaming the variable now. > if [ -z "$pocketlint_files" ]; then > exit 0 > fi > - > -echo "" > -pocketlint $pocketlint_files 2>&1 > +pocketlint_files=`echo "$pocketlint_files" | tr " " "\n"` > + > +non_js_files=`echo "$pocketlint_files" | env -i grep -v '\.js$'` > +js_files=`echo "$pocketlint_files" | env -i grep '\.js$'` > + > +ret=0 > +if [ "$non_js_files" ]; then > +echo "" > +pocketlint $non_js_files 2>&1 || ret=$? > +fi > +if [ "$js_files" ]; then > +nodejs node_modules/.bin/eslint $js_files 2>&1 || ret=$? Do we want a blank line here as well? > +fi > +exit $ret > > === modified file 'yarn.lock' > --- yarn.lock 2017-07-23 03:47:01 + > +++ yarn.lock 2017-07-23 03:47:01 + > @@ -24,10 +339,283 @@ > combined-stream "~0.0.4" > mime "~1.2.2" > > +fs.realpath@^1.0.0: > + version "1.0.0" > + resolved > "https://registry.yarnpkg.com/fs.realpath/-/fs.realpath-1.0.0.tgz#1504ad2523158caa40db4a2787cb01411994ea4f; > + > +glob@^7.0.3, glob@^7.0.5, glob@^7.1.2: > + version "7.1.2" > + resolved > "https://registry.yarnpkg.com/glob/-/glob-7.1.2.tgz#c19c9df9a028702d678612384a6552404c636d15; > + dependencies: > +fs.realpath "^1.0.0" > +inflight "^1.0.4" > +inherits "2" > +minimatch "^3.0.4" > +once "^1.3.0" > +path-is-absolute "^1.0.0" > + > +globals@^9.17.0: > + version "9.18.0" > + resolved > "https://registry.yarnpkg.com/globals/-/globals-9.18.0.tgz#aa3896b3e69b487f17e31ed2143d69a8e30c2d8a; > + > +globby@^5.0.0: > + version "5.0.0" > + resolved > "https://registry.yarnpkg.com/globby/-/globby-5.0.0.tgz#ebd84667ca0dbb330b99bcfc68eac2bc54370e0d; > + dependencies: > +array-union "^1.0.1" > +arrify "^1.0.0" > +glob "^7.0.3" > +object-assign "^4.0.1" > +pify "^2.0.0" > +pinkie-promise "^2.0.0" > + > +graceful-fs@^4.1.2: > + version "4.1.11" > + resolved > "https://registry.yarnpkg.com/graceful-fs/-/graceful-fs-4.1.11.tgz#0e8bdfe4d1ddb8854d64e04ea7c00e2a026e5658; > + > +has-ansi@^2.0.0: > + version "2.0.0" > + resolved > "https://registry.yarnpkg.com/has-ansi/-/has-ansi-2.0.0.tgz#34f5049ce1ecdf2b0649af3ef24e45ed35416d91; > + dependencies: > +ansi-regex "^2.0.0" > + > +has-flag@^2.0.0: > + version "2.0.0" > + resolved > "https://registry.yarnpkg.com/has-flag/-/has-flag-2.0.0.tgz#e8207af1cc7b30d446cc70b734b5e8be18f88d51; > + > +iconv-lite@^0.4.17: > + version "0.4.18" > + resolved > "https://registry.yarnpkg.com/iconv-lite/-/iconv-lite-0.4.18.tgz#23d8656b16aae6742ac29732ea8f0336a4789cf2; > + > +ignore@^3.3.3: > + version "3.3.3" > + resolved > "https://registry.yarnpkg.com/ignore/-/ignore-3.3.3.tgz#432352e57accd87ab3110e82d3fea0e47812156d; > + > +imurmurhash@^0.1.4: > + version "0.1.4" > + resolved > "https://registry.yarnpkg.com/imurmurhash/-/imurmurhash-0.1.4.tgz#9218b9b2b928a238b13dc4fb6b6d576f231453ea; > + > +inflight@^1.0.4: > + version "1.0.6" > + resolved > "https://registry.yarnpkg.com/inflight/-/inflight-1.0.6.tgz#49bd6331d7d02d0c09bc910a1075ba8165b56df9; > + dependencies: > +once "^1.3.0" > +wrappy "1" > + > +inherits@2, inherits@^2.0.3, inherits@~2.0.3: > + version "2.0.3" > + resolved > "https://registry.yarnpkg.com/inherits/-/inherits-2.0.3.tgz#633c2c83e3da42a502f52466022480f4208261de; > + > +inquirer@^3.0.6: > + version "3.2.0" > + resolved > "https://registry.yarnpkg.com/inquirer/-/inquirer-3.2.0.tgz#45b44c2160c729d7578c54060b3eed94487bb42b; > + dependencies: > +ansi-escapes "^2.0.0" > +chalk "^2.0.0" > +cli-cursor "^2.1.0" > +cli-width "^2.0.0" > +external-editor "^2.0.4" > +figures "^2.0.0" > +lodash "^4.3.0" > +mute-stream "0.0.7" > +run-async "^2.2.0" > +rx-lite "^4.0.8" > +rx-lite-aggregates "^4.0.8" > +string-width "^2.1.0" > +strip-ansi "^4.0.0" > +through "^2.3.6" > + > +is-fullwidth-code-point@^2.0.0: > + version "2.0.0" > + resolved > "https://registry.yarnpkg.com/is-fullwidth-code-point/-/is-fullwidth-code-point-2.0.0.tgz#a3b30a5c4f199183167aaab93beefae3ddfb654f; > + > +is-path-cwd@^1.0.0: > + version "1.0.0" > + resolved > "https://registry.yarnpkg.com/is-path-cwd/-/is-path-cwd-1.0.0.tgz#d225ec23132e89edd38fda767472e62e65f1106d; > + > +is-path-in-cwd@^1.0.0: > + version "1.0.0" > + resolved > "https://registry.yarnpkg.com/is-path-in-cwd/-/is-path-in-cwd-1.0.0.tgz#6477582b8214d602346094567003be8a9eac04dc; > + dependencies: > +is-path-inside "^1.0.0" > + > +is-path-inside@^1.0.0: > + version "1.0.0" > + resolved >
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/blueprints-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/blueprints-tests-future-imports/+merge/332799 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bugtracker-sanitize-name-lowercase into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/bugtracker-sanitize-name-lowercase/+merge/332715 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/answers-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/answers-tests-future-imports/+merge/332778 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/answers-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/answers-tests-future-imports/+merge/332778 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bugzilla-without-credentials into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/bugzilla-without-credentials/+merge/332735 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snappy-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snappy-tests-future-imports/+merge/332570 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bugtracker-redhat-fixes into lp:launchpad
Diff comments: > > === modified file 'lib/lp/bugs/externalbugtracker/bugzilla.py' > --- lib/lp/bugs/externalbugtracker/bugzilla.py2017-01-14 07:41:41 > + > +++ lib/lp/bugs/externalbugtracker/bugzilla.py2017-10-20 11:30:23 > + > @@ -839,12 +844,18 @@ > comment = self._bugs[actual_bug_id]['comments'][comment_id] > display_name, email = parseaddr(comment['author']) > > -# If the name is empty then we return None so that > -# IPersonSet.ensurePerson() can actually do something with it. > -if not display_name: > -display_name = None > - > -return (display_name, email) > +# If the email isn't valid, return the email address as the > +# display name (a Launchpad Person will be created with this > +# name). > +if not valid_email(email): > +return email, None I'd marginally prefer the "if '@' not in email:" approach, but up to you. > +# If the display name is empty, set it to None so that it's > +# useable by IPersonSet.ensurePerson(). > +elif display_name == '': > +return None, email > +# Both displayname and email are valid, return both. > +else: > +return display_name, email > > def getMessageForComment(self, remote_bug_id, comment_id, poster): > """See `ISupportsCommentImport`.""" -- https://code.launchpad.net/~cjwatson/launchpad/bugtracker-redhat-fixes/+merge/332559 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/bugtracker-redhat-fixes into lp:launchpad
Review: Approve code
Diff comments:
>
> === modified file 'lib/lp/bugs/externalbugtracker/bugzilla.py'
> --- lib/lp/bugs/externalbugtracker/bugzilla.py2017-01-14 07:41:41
> +
> +++ lib/lp/bugs/externalbugtracker/bugzilla.py2017-10-20 11:30:23
> +
> @@ -296,6 +300,7 @@
> ('WONTFIX', 'WILL_NOT_FIX', 'NOTOURBUG', 'UPSTREAM',
> BugTaskStatus.WONTFIX),
> ('OBSOLETE', 'INSUFFICIENT_DATA', 'INCOMPLETE', 'EXPIRED',
> + 'EOL', 'DEFERRED',
> BugTaskStatus.EXPIRED),
EOL and DEFERRED (and possibly OBSOLETE) really seem more like Won't Fix to me,
but since OBSOLETE's already Expired...
> ('INVALID', 'WORKSFORME', 'NOTABUG', 'CANTFIX',
> 'UNREPRODUCIBLE', 'DUPLICATE',
> @@ -839,12 +844,18 @@
> comment = self._bugs[actual_bug_id]['comments'][comment_id]
> display_name, email = parseaddr(comment['author'])
>
> -# If the name is empty then we return None so that
> -# IPersonSet.ensurePerson() can actually do something with it.
> -if not display_name:
> -display_name = None
> -
> -return (display_name, email)
> +# If the email isn't valid, return the email address as the
> +# display name (a Launchpad Person will be created with this
> +# name).
> +if not valid_email(email):
> +return email, None
Is it okay to disclose the email address publicly? Also do we have precedent
for auto-importing users with no email address?
> +# If the display name is empty, set it to None so that it's
> +# useable by IPersonSet.ensurePerson().
> +elif display_name == '':
> +return None, email
> +# Both displayname and email are valid, return both.
> +else:
> +return display_name, email
>
> def getMessageForComment(self, remote_bug_id, comment_id, poster):
> """See `ISupportsCommentImport`."""
--
https://code.launchpad.net/~cjwatson/launchpad/bugtracker-redhat-fixes/+merge/332559
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/optimise-bin-py into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/optimise-bin-py/+merge/331863 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/meta-lp-deps/frontend-dependencies into lp:meta-lp-deps
Review: Approve code -- https://code.launchpad.net/~cjwatson/meta-lp-deps/frontend-dependencies/+merge/331760 Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/code-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/code-tests-future-imports/+merge/331764 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/batch-snap-listing into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/batch-snap-listing/+merge/332085 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/answers-hide-inactive-projects into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/answers-hide-inactive-projects/+merge/331981 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/pyopenssl-0.15.1 into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/pyopenssl-0.15.1/+merge/331889 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/python-memcached-1.58 into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/python-memcached-1.58/+merge/331911 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/meta-lp-deps/pyopenssl-deps into lp:meta-lp-deps
Review: Approve code -- https://code.launchpad.net/~cjwatson/meta-lp-deps/pyopenssl-deps/+merge/331954 Your team Launchpad code reviewers is subscribed to branch lp:meta-lp-deps. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/code-bzr-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/code-bzr-tests-future-imports/+merge/331762 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/code-git-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/code-git-tests-future-imports/+merge/331761 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/code-browser-tests-future-imports into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/code-browser-tests-future-imports/+merge/331758 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/htpasswd-salt into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/htpasswd-salt/+merge/332013 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/sorted-apache-logs-by-age into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/sorted-apache-logs-by-age/+merge/331890 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/sorted-apache-logs into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/sorted-apache-logs/+merge/331809 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] lp:~wgrant/launchpad/gPPFID-email-argh into lp:launchpad
William Grant has proposed merging lp:~wgrant/launchpad/gPPFID-email-argh into lp:launchpad. Commit message: Fix getPrecachedPersonsFromIDs to handle teams with mailing lists. Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~wgrant/launchpad/gPPFID-email-argh/+merge/331517 Fix getPrecachedPersonsFromIDs to handle teams with mailing lists. Previously, when need_preferred_email was true, a team with a mailing list but no contact address (an email address, but only a non-preferred one) would be filtered out by the WHERE, resulting in no precaching, and indeed not being returned by the method at all. -- Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/gPPFID-email-argh into lp:launchpad. === modified file 'lib/lp/registry/model/person.py' --- lib/lp/registry/model/person.py 2017-06-09 00:03:35 + +++ lib/lp/registry/model/person.py 2017-09-28 18:04:26 + @@ -4012,12 +4012,12 @@ # Checking validity requires having a preferred email. if not need_api and need_preferred_email and not need_validity: # Teams don't have email, so a left join -origin.append( -LeftJoin(EmailAddress, EmailAddress.person == Person.id)) +origin.append(LeftJoin( +EmailAddress, +And( +EmailAddress.person == Person.id, +EmailAddress.status == EmailAddressStatus.PREFERRED))) columns.append(EmailAddress) -conditions = And(conditions, -Or(EmailAddress.status == None, - EmailAddress.status == EmailAddressStatus.PREFERRED)) if need_validity or need_api: valid_stuff = Person._validity_queries() origin.extend(valid_stuff["joins"]) === modified file 'lib/lp/registry/tests/test_personset.py' --- lib/lp/registry/tests/test_personset.py 2016-05-25 06:41:01 + +++ lib/lp/registry/tests/test_personset.py 2017-09-28 18:04:26 + @@ -1,4 +1,4 @@ -# Copyright 2009-2016 Canonical Ltd. This software is licensed under the +# Copyright 2009-2017 Canonical Ltd. This software is licensed under the # GNU Affero General Public License version 3 (see the file LICENSE). """Tests for PersonSet.""" @@ -7,6 +7,7 @@ from testtools.matchers import ( +Equals, GreaterThan, LessThan, ) @@ -154,6 +155,39 @@ person.teamowner self.assertThat(recorder, HasQueryCount(LessThan(1))) +def test_getPrecachedPersonsFromIDs_preferred_email(self): +# getPrecachedPersonsFromIDs() sets preferredemail to the preferred +# address if it exists, but otherwise leaves it as none. +team_no_contact = self.factory.makeTeam(email=None) +team_contact = self.factory.makeTeam(email=u't...@example.com') +team_list = self.factory.makeTeam(email=None) +self.factory.makeMailingList(team_list, team_list.teamowner) +person_normal = self.factory.makePerson() +person_unactivated = self.factory.makePerson( +account_status=AccountStatus.NOACCOUNT) +person_ids = [ +t.id for t in [ +team_no_contact, team_contact, team_list, person_normal, +person_unactivated]] +transaction.commit() + +with StormStatementRecorder() as recorder: +list(self.person_set.getPrecachedPersonsFromIDs( +person_ids, need_preferred_email=True)) +self.assertThat(recorder, HasQueryCount(Equals(1))) + +with StormStatementRecorder() as recorder: +self.assertIsNone(team_no_contact.preferredemail) +self.assertEqual( +EmailAddressStatus.PREFERRED, +team_contact.preferredemail.status) +self.assertIsNone(team_list.preferredemail) +self.assertIsNone(person_unactivated.preferredemail) +self.assertEqual( +EmailAddressStatus.PREFERRED, +person_normal.preferredemail.status) +self.assertThat(recorder, HasQueryCount(Equals(0))) + def test_getPrecachedPersonsFromIDs_is_ubuntu_coc_signer(self): # getPrecachedPersonsFromIDs() sets is_ubuntu_coc_signer # correctly. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/external-dependencies-trusted into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/external-dependencies-trusted/+merge/331490 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/external-dependencies-trusted into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/external-dependencies-trusted/+merge/331490 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/fix-memcache-error-message into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/fix-memcache-error-message/+merge/331417 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/dsp-code into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/dsp-code/+merge/331424 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/drop-sourcecodegen into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/drop-sourcecodegen/+merge/331265 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-apiindex into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-apiindex/+merge/331241 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/build-twisted-plugin-cache into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/build-twisted-plugin-cache/+merge/331240 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/allow-header-syntax into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/allow-header-syntax/+merge/330885 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/ampoule-0.2.0.post1 into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/ampoule-0.2.0.post1/+merge/330862 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/simplify-buildout-recipes into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/simplify-buildout-recipes/+merge/330159 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/disable-pot-generation into lp:launchpad
Review: Approve code what will we ever do -- https://code.launchpad.net/~cjwatson/launchpad/disable-pot-generation/+merge/330157 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/remove-geonames-identity into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/remove-geonames-identity/+merge/330355 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/simplify-mime-tests into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/simplify-mime-tests/+merge/330156 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/storm-datetime into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/storm-datetime/+merge/330086 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/buildd-148-compat into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/buildd-148-compat/+merge/330661 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/snap-set-git-path into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/snap-set-git-path/+merge/329360 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/upgrade-oops into lp:launchpad
Review: Approve code -- https://code.launchpad.net/~cjwatson/launchpad/upgrade-oops/+merge/330118 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
