[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/lp-1729580-2 into lp:launchpad

2018-02-22 Thread noreply
The proposal to merge lp:~maxiberta/launchpad/lp-1729580-2 into lp:launchpad 
has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/lp-1729580-2/+merge/338562
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp


[Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/lp-1729580-2 into lp:launchpad

2018-02-22 Thread Maximiliano Bertacchini
Maximiliano Bertacchini has proposed merging 
lp:~maxiberta/launchpad/lp-1729580-2 into lp:launchpad.

Commit message:
Use target="_blank" in extended snap build error links.

Requested reviews:
  Colin Watson (cjwatson)

For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/lp-1729580-2/+merge/338562

Use target="_blank" in extended snap build error links. Fixes browsers refusing 
to load external links due to "X-Frame-Options: sameorigin".
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
=== modified file 'lib/lp/snappy/templates/snapbuild-index.pt'
--- lib/lp/snappy/templates/snapbuild-index.pt	2018-02-19 17:51:30 +
+++ lib/lp/snappy/templates/snapbuild-index.pt	2018-02-22 15:53:34 +
@@ -185,7 +185,7 @@
   
   (?)
 
   

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp


Re: [Launchpad-reviewers] [Merge] lp:~maxiberta/launchpad/lp-1729580-2 into lp:launchpad

2018-02-22 Thread Colin Watson
Review: Approve


-- 
https://code.launchpad.net/~maxiberta/launchpad/lp-1729580-2/+merge/338562
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp