[Lazarus] Replacement for deprecated symbol "Lookup"

[Juha Manninen]

I try to clean out warnings from LCL. How to solve these?

Compile package LCLBase 1.7: Success, Warnings: 6
dbctrls.pp(1422,56) Warning: Symbol "Lookup" is deprecated
dbgrids.pas(1233,20) Warning: Symbol "Lookup" is deprecated
dbgrids.pas(3270,54) Warning: Symbol "Lookup" is deprecated
dbgrids.pas(3291,28) Warning: Symbol "Lookup" is deprecated
dbgrids.pas(4026,30) Warning: Symbol "Lookup" is deprecated

Regards,
Juha

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] New menu designer

[Juha Manninen]

On Sat, Dec 26, 2015 at 1:09 PM, Péter Gábor  wrote:
> Some examples of resourcestrings that can/must be merged
> ...

Yes, I didn't even notice that.


> Also a question: can this (new) menu designer implemented as a
> separate/installable package to allow the usage of old one?

No, my idea was to replace the old menu designer with a new one.
Something is wrong with the design of the old one. Everybody who has
modified and improved it says the same. Some improvements just feel
impossible without a complete rewrite.
So, this was the rewrite we were asking for.

I was hoping the author Howard Page-Clark would participate in the
discussion and improve his designer based on feedback. Maintenance is
always an important part of any code.
I have not studied details of the code yet but I plan to do it soon.
In any case, if I will be a sole maintainer of this code then I am
disappointed. I was hoping for a shared effort.

Juha

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] Replacement for deprecated symbol "Lookup"

[Michael Van Canneyt]

On Sat, 26 Dec 2015, Juha Manninen wrote:


I try to clean out warnings from LCL. How to solve these?

Compile package LCLBase 1.7: Success, Warnings: 6
dbctrls.pp(1422,56) Warning: Symbol "Lookup" is deprecated
dbgrids.pas(1233,20) Warning: Symbol "Lookup" is deprecated
dbgrids.pas(3270,54) Warning: Symbol "Lookup" is deprecated
dbgrids.pas(3291,28) Warning: Symbol "Lookup" is deprecated
dbgrids.pas(4026,30) Warning: Symbol "Lookup" is deprecated


Use Locate instead.

Michael.

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] Replacement for deprecated symbol "Lookup"

[Juha Manninen]

On Sat, Dec 26, 2015 at 7:25 PM, Michael Van Canneyt
 wrote:
> Use Locate instead.

They are actually TField.Lookup properties. TField does not have Locate.
All the "deprecated" warnings come from Lookup getters which is implemented as :

function TField.GetLookup: Boolean;
begin
  Result := FieldKind = fkLookup;
end;

Maybe I just use "FieldKind = fkLookup". Easy piecy. Unfortunately
there is no hint message after the "deprecated" keyword saying like
"Use xxx instead". Such hints were not supported by FPC a while ago.

Juha

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] New menu designer

[Howard Page-Clark]

On 26/12/2015 19:06, Juha Manninen wrote:

On Sat, Dec 26, 2015 at 1:09 PM, Péter Gábor  wrote:

Some examples of resourcestrings that can/must be merged



No, my idea was to replace the old menu designer with a new one.
Something is wrong with the design of the old one. Everybody who has
modified and improved it says the same. Some improvements just feel
impossible without a complete rewrite.
So, this was the rewrite we were asking for.

I was hoping the author Howard Page-Clark would participate in the
discussion and improve his designer based on feedback. Maintenance is
always an important part of any code.
I have not studied details of the code yet but I plan to do it soon.
In any case, if I will be a sole maintainer of this code then I am
disappointed. I was hoping for a shared effort.


I was waiting for more feedback about the design/functionality, and for 
responses to settle into some sort of consensus about what needs to be 
changed/improved/removed. (I had nothing to add to the fsStayOnTop 
discussion). I am perfectly happy to amend the code in line with what is 
agreed here. The resourcestrings, for instance, need the attention Peter 
indicated, plus more. This was a clear oversight on my part.


However, if functionality is to be removed, the pruning of the 
resourcestrings would be more drastic. Is it agreed to remove the 
RadioItem/CheckMark dialog? Is the left panel not needed at all?
The redundancy of duplicated items in that panel was part of the design, 
a bit of hand-holding for beginners, but perhaps it out of place.


The opening mini-wizard-style question when dropping a new menu on a 
form could be handled differently, or additionally have a section in the 
main IDE Options dialog, for instance that provided a default, and a 
choice of whether the wizard were ever shown.


I certainly expect to share in the maintainance of anything I 
contribute. However, you will realize that I am a hobbyist, not a 
professional programmer, and so my skills are limited compared to most 
of those who read this list, and I am hampered by little experience of 
operating systems other than Windows variants.


If there are reproducible crashes arising from the new editor, that 
certainly requires diagnosis and attention. I don't get them here, but 
if others do...


yours

Howard




---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] Lazarus 1.6RC1 on various platforms

[Salvatore Coppola]

Thought not 1.6 specific ther'is an annoying bug with the IDE undo. If you
create an  event for instance
procedure TForm1.Button1Click(Sender: TObject);
begin

end;

do ctrl+z

and only Button1Click from source is removed and not its reference in the
OI. So if you try to recreate the Button1Click event via OI or dbclick on
button1 the IDE is give a error msg that didnt help to find the problem
(unit section enlighted)

Salvatore

___
> Lazarus mailing list
> Lazarus@lists.lazarus.freepascal.org
> http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
>
--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] New menu designer

[Péter Gábor]

Hi!

2015-12-23 12:31 keltezéssel, Maxim Ganetsky írta:
> BTW, from localizer POV 150-180 extra resource strings that were added
> with this patch (which is a VERY bug number) point to likely
> functionality duplication. :)

Some examples of resourcestrings that can/must be merged

Editing %s.%s - no menu item selected
Editing %s.%s - no menuitem selected





Resolved conflicts: %d
Resolved conflicts: 0

Shortcut items: %d
Shortcut items: n/a

%s: Shortcuts & accelerator keys
%s: Shortcuts and accelerator keys

.. and there may be a lot more.

Also a question: can this (new) menu designer implemented as a
separate/installable package to allow the usage of old one?

(an example of what I'm talking about is Sparta Docked Form Editor in
components/sparta/)

-- 
Péter Gábor
p...@freemail.hu



--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] New menu designer

[Juha Manninen]

Howard, as the author you also have voting power over the GUI.
Besides GUI design is difficult, there is never a "right" solution
that everybody would agree upon.
Yet I feel some things should be changed. All settings that duplicate
OI properties should either be moved to a bottom section of a popup
menu, or they should be removed completely.
Then the remaing GroupIndex feature from "Checkmark and radioitem
properties" dialog could be moved to the main window of menu designer
and the dialog then removed completely.

There are other usability issues, too.

I haven't seen crashes either. How to reproduce?

>From Kostas:
> Since the menu editor is redesigned, why not do it like in Windows Forms
> and NetBeans with the "inline editor" which is part of the form editor?

Good idea but how to implement it? It may not be a trivial task. We
can plan a future third iteration of menu designer to be an "inline
editor".

Juha

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus