Re: [Lazarus] ./lcl/intfgraphics.pas and tiff
On 5-6-2012 0:27, Bernd wrote: > 2012/6/4 Mattias Gaertner : >>> Ignore it, the fpc tree had a commit, and even the first problem "gone". >> >> The fpc commit came shortly before the lazarus commit. >> The tiff reader now supports reading multi page files, tiles, CMYK and >> a few other improvements. >> The TTiffIDF was a typo and was fixed to TTiffIFD. > > Unfortunately it wont compile with the 2.6 branch anymore now. I think > the only solution would be an $ifdef for the next few years until 2.6 > will be considered "old and unsupported" Issue was partly fixed; there's still an include file: lcl/include/tiffimage.inc that needs fixing. See http://bugs.freepascal.org/view.php?id=22199 for patch Thanks, Reinier -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] ./lcl/intfgraphics.pas and tiff
2012/6/4 Mattias Gaertner : >> Ignore it, the fpc tree had a commit, and even the first problem "gone". > > The fpc commit came shortly before the lazarus commit. > The tiff reader now supports reading multi page files, tiles, CMYK and > a few other improvements. > The TTiffIDF was a typo and was fixed to TTiffIFD. Unfortunately it wont compile with the 2.6 branch anymore now. I think the only solution would be an $ifdef for the next few years until 2.6 will be considered "old and unsupported" -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] ./lcl/intfgraphics.pas and tiff
On Mon, 4 Jun 2012 13:44:43 +0300
ik wrote:
> On Mon, Jun 4, 2012 at 1:23 PM, ik wrote:
>
> > Hello,
> >
> > There are two issues at the moment I found with ./lcl/intfgraphics.pas :
> > 1. Misspelled TTiffIDF to TTiffIFD
> > 2. at line 635
> > procedure DoCreateImage(ImgFileDir: TTiffIDF); {$IF
> > FPC_FULLVERSION>=20701}override;{$ENDIF}
> >
> > FPC (from the latest svn revision - r21482), does not contain such method.
> >
> > I can send a patch to fix the first problem, but I need to better
> > understand the need for the second one.
> > It might that the code was not yet been committed, or it was removed.
> >
> > What should I do with the second "fix" ?
> >
> > Thanks,
> > Ido
> >
>
>
> Ignore it, the fpc tree had a commit, and even the first problem "gone".
The fpc commit came shortly before the lazarus commit.
The tiff reader now supports reading multi page files, tiles, CMYK and
a few other improvements.
The TTiffIDF was a typo and was fixed to TTiffIFD.
Mattias
--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] ./lcl/intfgraphics.pas and tiff
On Mon, Jun 4, 2012 at 1:23 PM, ik wrote:
> Hello,
>
> There are two issues at the moment I found with ./lcl/intfgraphics.pas :
> 1. Misspelled TTiffIDF to TTiffIFD
> 2. at line 635
> procedure DoCreateImage(ImgFileDir: TTiffIDF); {$IF
> FPC_FULLVERSION>=20701}override;{$ENDIF}
>
> FPC (from the latest svn revision - r21482), does not contain such method.
>
> I can send a patch to fix the first problem, but I need to better
> understand the need for the second one.
> It might that the code was not yet been committed, or it was removed.
>
> What should I do with the second "fix" ?
>
> Thanks,
> Ido
>
Ignore it, the fpc tree had a commit, and even the first problem "gone".
--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
[Lazarus] ./lcl/intfgraphics.pas and tiff
Hello,
There are two issues at the moment I found with ./lcl/intfgraphics.pas :
1. Misspelled TTiffIDF to TTiffIFD
2. at line 635
procedure DoCreateImage(ImgFileDir: TTiffIDF); {$IF
FPC_FULLVERSION>=20701}override;{$ENDIF}
FPC (from the latest svn revision - r21482), does not contain such method.
I can send a patch to fix the first problem, but I need to better
understand the need for the second one.
It might that the code was not yet been committed, or it was removed.
What should I do with the second "fix" ?
Thanks,
Ido
--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
