Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On 2014-05-15 23:05, Bart wrote: On 5/15/14, Torsten Bonde Christiansen t...@epidata.info wrote: I found a minor bug in the TCustomEditButton code regarding OnEditingDone. I have created a bug-report here (with included patch): http://bugs.freepascal.org/view.php?id=26171 Fixed in r45044. Thanks for the patch. Please close the bugreport. Bart -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus Closed... -Torsten. -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On 2014-04-06 17:33, Bart wrote: Hi all, As per r44623 (trunk) the new TButtonEdit component replaces the TEditButton component. The new TButtonEdit is designed as Grouped Control, so it should properly anchor and align. (You need to clean build Lazarus in order to update the componentpallette.) Hi Bart. I found a minor bug in the TCustomEditButton code regarding OnEditingDone. I have created a bug-report here (with included patch): http://bugs.freepascal.org/view.php?id=26171 And thank you for a great component :) Regards, Torsten -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On 5/15/14, Torsten Bonde Christiansen t...@epidata.info wrote: I found a minor bug in the TCustomEditButton code regarding OnEditingDone. I have created a bug-report here (with included patch): http://bugs.freepascal.org/view.php?id=26171 Fixed in r45044. Thanks for the patch. Please close the bugreport. Bart -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
Thank you Bart, All voids goes to Bart at this time :) I tested, kubuntu 13.10 x64. if different color is clDefault (TEditButton.ColorclDefault), write it in lfm, if its equal to clDefault, not in lfm, but property value is clDefault ( if some one looking for in lfm file, can not see Color = clDefault) Thank you very much 10-04-2014 20:57 tarihinde, Bart yazdı: On 4/10/14, Bart bartjun...@gmail.com wrote: I can confirm this. It does not store in LFM. That's a wrong conclusion it seems. It does store in LFM, see snippet: object EditButton1: TEditButton Left = 8 Height = 23 Top = 46 Width = 160 ButtonWidth = 23 Color = clYellow == MaxLength = 0 NumGlyphs = 1 OnButtonClick = EditButton1ButtonClick But upon loading it the color of FEdit gets reset to it's parent color. Fixed in r44669. Please test. Bart -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
Hello Bart, I was used TCustomEditButton class. Color property need variable so can write it in lfm. FEdit: TBeEdit; has no color property, its come always clBtnFace on my system. Kubuntu 13.10 x64. last trunc. In design time change to any color, look at lfm file, no color property value there. Regards 09-04-2014 19:14 tarihinde, Bart yazdı: As per r44623 (trunk) the new TButtonEdit component replaces the TEditButton component. -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On 4/10/14, FreeMan freema...@delphiturkiye.com wrote:
I was used TCustomEditButton class. Color property need variable so can
write it in lfm. FEdit: TBeEdit; has no color property, its come
always clBtnFace on my system. Kubuntu 13.10 x64. last trunc. In design
time change to any color, look at lfm file, no color property value there.
Regards
I can confirm this. It does not store in LFM.
Not sure why given the definition:
property Color: TColor read GetColor write SetColor stored True
default {$ifdef UseCLDefault}clDefault{$else}clWindow{$endif};
Please open a ticket in bugtracker.
Bart
--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On 4/10/14, Bart bartjun...@gmail.com wrote: I can confirm this. It does not store in LFM. That's a wrong conclusion it seems. It does store in LFM, see snippet: object EditButton1: TEditButton Left = 8 Height = 23 Top = 46 Width = 160 ButtonWidth = 23 Color = clYellow == MaxLength = 0 NumGlyphs = 1 OnButtonClick = EditButton1ButtonClick But upon loading it the color of FEdit gets reset to it's parent color. Fixed in r44669. Please test. Bart -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On 4/6/14, Bart bartjun...@gmail.com wrote: As per r44623 (trunk) the new TButtonEdit component replaces the TEditButton component. After a long discussion with the Lazarus deveopers it was decided that the new name of the component was causing too much regressions and maintenance problems in the future. The old TEditButton implementation therefore has now been replaced with the implementation of the previously new developed TButtonEdit component. The USEOLDEDITBUTTON define to use the old implementation has been removed. This ensures that regressions of the new implementation (missing properties, wrong functionality etc.) will be reported much sooner and by more people. Since the new implementation inherits from a new ancestor, custom-derived controls that override TCustomMaskEdit's (protected) methods may not compile anymore. For the most common ones alternatives have been implemented with names reflecting the inner working e.g: - TCustomEditButton.EditChange instead of the old inherited TCustomEditButton.Change Most notably the DoButtonClick(Sender: TObject) now is replaced by ButtonClick; (no parameters). I would like to thank all of you for testing and your valuable feedback. Please keep reporting regressions and other bugs in the bugtracker. Bart -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On Sun, 6 Apr 2014, Bart wrote: On 4/6/14, Michael Van Canneyt mich...@freepascal.org wrote: The old design was a poor one Well, it used what was available at the time in the LCL, which was not much compared to what can be done today :) Well, maybe that was frased a little crude, but no offense was intended by all means. No offense taken. On the contrary, I'm very glad to see that things improve, this is the main point ! Michael. -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
[Lazarus] Ann: TButtonEdit as replacement for TEditButton
Hi all, As per r44623 (trunk) the new TButtonEdit component replaces the TEditButton component. The new TButtonEdit is designed as Grouped Control, so it should properly anchor and align. (You need to clean build Lazarus in order to update the componentpallette.) TEditButton is, for the time being, an alias for TButtonEdit, so that forms with a TEditButton still can load. If you find any regressions please report them in the bugtracker. For the time being you can build Lazarus with -dUSEOLDEDITBUTTON to still use the old implementation. I would like to thank Derit Agustin for the initial implementation of the new TCustomButtonEdit. Bart -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
Finally :) *executing: svn up -- View this message in context: http://free-pascal-lazarus.989080.n3.nabble.com/Lazarus-Ann-TButtonEdit-as-replacement-for-TEditButton-tp4036553p4036554.html Sent from the Free Pascal - Lazarus mailing list archive at Nabble.com. -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
Hello, I have some notes. The main is that messages (like WMLButton etc.) does not work. This may in theory break other peoples' code. The second is that default AutoSize was changed to False and initial height is hardcoded to 23 (but on my Qt are edits 21 pixel high so it's not consistent). I would keep AutoSIze = True as initial. The third is that it's derived from TCustomControl. Since the only difference to TWinControl that I see here is the Canvas, which is useless here, I would derive from TWinControl. Vojtech a.k.a. Blaazen __ Od: Bart bartjun...@gmail.com Komu: Lazarus mailing list lazarus@lists.lazarus.freepascal.org Datum: 06.04.2014 17:35 Předmět: [Lazarus] Ann: TButtonEdit as replacement for TEditButton -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On 4/6/14, Vojtěch Čihák vojtech.ci...@atlas.cz wrote: I have some notes. The main is that messages (like WMLButton etc.) does not work. This may in theory break other peoples' code. Not sure if that can be fixed. The old design was a poor one and had to be fixed in a way similar to the current one where the edit and the button are part of the container. The second is that default AutoSize was changed to False and initial height is hardcoded to 23 (but on my Qt are edits 21 pixel high so it's not consistent). I would keep AutoSIze = True as initial. Hmm... It uses same numbers as (hardcode?) in TCustomEdit for height. Autosize needs to be true. I'll fix that. (It was false by default because it didn't work as expected in a previous commit). The third is that it's derived from TCustomControl. Since the only difference to TWinControl that I see here is the Canvas, which is useless here, I would derive from TWinControl. Done that in a previous version, but IIRC it then looked different (ugly), so I changed it back to TCustomControl. Bart -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On 4/6/14, Vojtěch Čihák vojtech.ci...@atlas.cz wrote: The second is that default AutoSize was changed to False Fixed. The third is that it's derived from TCustomControl. Since the only difference to TWinControl that I see here is the Canvas, which is useless here, I would derive from TWinControl. Looked at it again. If done so then the buttons won't draw until you hoover the mouse over them. Can't see why this is happening. Bart -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On Sun, 6 Apr 2014, Bart wrote: On 4/6/14, Vojtěch Čihák vojtech.ci...@atlas.cz wrote: I have some notes. The main is that messages (like WMLButton etc.) does not work. This may in theory break other peoples' code. Not sure if that can be fixed. The old design was a poor one Well, it used what was available at the time in the LCL, which was not much compared to what can be done today :) Michael.-- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
Re: [Lazarus] Ann: TButtonEdit as replacement for TEditButton
On 4/6/14, Michael Van Canneyt mich...@freepascal.org wrote: The old design was a poor one Well, it used what was available at the time in the LCL, which was not much compared to what can be done today :) Well, maybe that was frased a little crude, but no offense was intended by all means. Bart -- ___ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
