Re: [LEDE-DEV] [PATCH] ipq806x: Archer C2600: fix switch ports numbering

[Mathias Kresin]

14.09.2017 11:36, Baptiste Jonglez:

Can this be merged to lede-17.01?  As I mentioned in the commit, it
applies cleanly.


Done!

Mathias

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] ath10k: Re-enable intermediate softqueues for all devices

[Baptiste Jonglez]

Hi,

On 14-09-17, Toke Høiland-Jørgensen wrote:
> Toke Høiland-Jørgensen  writes:
> 
> > The upstream ath10k driver disables the intermediate softqueues for some
> > devices. This patch reverts that behaviour and always enables the
> > softqueues (and associated bufferbloat fixes). We have had reports of people
> > running this with good results:
> > https://lists.bufferbloat.net/pipermail/make-wifi-fast/2017-September/001497.html
> 
> So there seems to be some issues with QCA9980 with this patch. See
> https://lists.bufferbloat.net/pipermail/make-wifi-fast/2017-September/001505.html

I have updated my Archer C2600 to 53839da46e a few days ago (your patch
was just merged) and did not notice any particular performance issue.  The
Archer C2600 also has a QCA9980.

I will stress it a bit more tomorrow to see if there is a performance
problem.

Baptiste


signature.asc
Description: PGP signature
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] x86 sysupgrade: preserve partition table

[Philip Prindeville]

That’s what the -p flag to sysupgrade is for.

Also, there’s not much point in resizing the rootdisk partition: even applying 
several upgrades and maybe adding some new packages, the amount of used space 
isn’t going to grow significantly.

You’re better off creating a 3rd EXT4 partition as /var or something like that. 
 Logs and collectd information are what grow the most.




> On Sep 14, 2017, at 4:21 AM, Nishant Sharma  wrote:
> 
> Hi,
> 
> I am using Lede 17.01.2 on PCEngines APU2. In order to utilise full 16GB SSD, 
> I resize the partition after "dd"-ing the Lede image to it.
> 
> On sysupgrade, the partition table is re-written and "/" partition is back to 
> 256 MB.
> 
> Is there a way the existing partition table or at least "/" partition size 
> could be preserved?
> 
> Thanks in advance.
> 
> Regards,
> Nishant


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH libubox 2/2] uloop: Enable utracing of multi-threaded programs

[Michal Sojka]

On Thu, Sep 14 2017, Yousong Zhou wrote:
> On 12 September 2017 at 19:12, Michal Sojka  wrote:
>> This is needed for Linux < 4.7 or < 4.4.13 to report ptrace events in
>> threads.
>>
>> Signed-off-by: Michal Sojka 
>> ---
>>  uloop.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/uloop.c b/uloop.c
>> index 3813e18..e6d77df 100644
>> --- a/uloop.c
>> +++ b/uloop.c
>> @@ -369,7 +369,7 @@ static void uloop_handle_processes(void)
>> do_sigchld = false;
>>
>> while (1) {
>> -   pid = waitpid(-1, , WNOHANG);
>> +   pid = waitpid(-1, , WNOHANG|__WALL);
>> if (pid < 0 && errno == EINTR)
>> continue;
>>
>
> NACK because this changes the current behaviour of only handling
> termination of child processes notified via SIGCHLD signal.  It may
> break existing users of the library.

OK. It should not influence the rest of the patch series, because LEDE
seems to ship newer kernel versions than those needing this patch.

-Michal

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] is it feasible to use a recent linux distro & LEDE to build openwrt 15.05.1?

[Yousong Zhou]

On 14 September 2017 at 19:06, Robert P. J. Day  wrote:
>
>   here's hoping someone can give me a short answer on whether this is
> possible, or whether it's just not worth the trouble.
>
>   i was recently handed an existing openwrt-based project, which is
> based on openwrt 15.05.1. the problem (unsurprisingly) is that some of
> the structure of openwrt that old is that parts of it are simply
> unbuildable with a modern linux distro, like my fully-updated fedora
> 26 system.
>
>   when i first tried to build that project, the first failure was
> simply trying to build the toolchain, as gcc 6 was unable to compile
> the older gcc 4 that was being selected for the toolchain. another
> tweak was to patch glib2 to be buildable by gcc 6, that sort of thing.
>
>   once i got past that, next was simply ignoring the bazillion
> "WARNING: No feed for package '' found, maybe it's already part of
> the standard packages?" messages.
>
>   next, the prereq-build.mk test for "git" failed, given that the test
> from back then is no longer valid, so i just tossed that test out of
> that makefile.
>
>   at that point, now that i've upgraded, the newer gcc7 failed to
> compile tools/mkimage as the compiler complained (unsurprisingly)
> about a missing include/linux/compiler-gcc7.h header file, so i threw
> one in and resumed, to get compilation errors in
> u-boot-2014.10/lib/rsa/ras-sign.c:
>
> .../rsa-sign.c:279:21: error: dereferencing pointer to incomplete type 'RSA 
> {aka struct rsa_st}'
>   if (BN_num_bits(key->e) > 64)
>
> etc ... etc ... you get the idea.
>
>   the other approach i tried was, since changes to 15.05.1 to support
> the board in question had been made in a git repo, i figured i could
> just go back and effectively rebase all the board support changes on
> top of LEDE, but:
>
> 1) the commits are totally chaotic and incomprehensible, and
> 2) the folks in charge are adamantly opposed to trying to bring this
> source up to date -- "it works, don't touch it"
>
>   at the moment, the build succeeds only because it's being done in a
> VM running an old version of ubuntu that's compatible with 15.05.1.
> yuck.
>
>   i would dearly love to somehow get this code up-to-date with LEDE,
> but i'm starting to think there's no pleasant way to do that.
>
>   thoughts?
>
> rday

I have been using an old debian wheezy virtual machine for years when
working on OpenWrt/LEDE...  It just works.  If you are working alone
and man power is a scarce and precious resource, I would say it's very
likely not worth the time and effort: will the gain in bringing up the
old repo in new dev environment really work out?

my two cents,
yousong

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] is there a reason not to use "git --version" to check for git?

[Jo-Philipp Wich]

Hi,

extracting, sanitizing and testing the version number would be a way
more complex one-liner compared to just grepping for the required flag.

~ Jo

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] is there a reason not to use "git --version" to check for git?

[Jo-Philipp Wich]

Hi,

extracting, sanitizing and testing the version number would be a way
more complex one-liner compared to just grepping for the required flag.

~ Jo

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] is it feasible to use a recent linux distro & LEDE to build openwrt 15.05.1?

[Robert P. J. Day]

  here's hoping someone can give me a short answer on whether this is
possible, or whether it's just not worth the trouble.

  i was recently handed an existing openwrt-based project, which is
based on openwrt 15.05.1. the problem (unsurprisingly) is that some of
the structure of openwrt that old is that parts of it are simply
unbuildable with a modern linux distro, like my fully-updated fedora
26 system.

  when i first tried to build that project, the first failure was
simply trying to build the toolchain, as gcc 6 was unable to compile
the older gcc 4 that was being selected for the toolchain. another
tweak was to patch glib2 to be buildable by gcc 6, that sort of thing.

  once i got past that, next was simply ignoring the bazillion
"WARNING: No feed for package '' found, maybe it's already part of
the standard packages?" messages.

  next, the prereq-build.mk test for "git" failed, given that the test
from back then is no longer valid, so i just tossed that test out of
that makefile.

  at that point, now that i've upgraded, the newer gcc7 failed to
compile tools/mkimage as the compiler complained (unsurprisingly)
about a missing include/linux/compiler-gcc7.h header file, so i threw
one in and resumed, to get compilation errors in
u-boot-2014.10/lib/rsa/ras-sign.c:

.../rsa-sign.c:279:21: error: dereferencing pointer to incomplete type 'RSA 
{aka struct rsa_st}'
  if (BN_num_bits(key->e) > 64)

etc ... etc ... you get the idea.

  the other approach i tried was, since changes to 15.05.1 to support
the board in question had been made in a git repo, i figured i could
just go back and effectively rebase all the board support changes on
top of LEDE, but:

1) the commits are totally chaotic and incomprehensible, and
2) the folks in charge are adamantly opposed to trying to bring this
source up to date -- "it works, don't touch it"

  at the moment, the build succeeds only because it's being done in a
VM running an old version of ubuntu that's compatible with 15.05.1.
yuck.

  i would dearly love to somehow get this code up-to-date with LEDE,
but i'm starting to think there's no pleasant way to do that.

  thoughts?

rday

-- 


Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] x86 sysupgrade: preserve partition table

[Nishant Sharma]

Hi,

I am using Lede 17.01.2 on PCEngines APU2. In order to utilise full 16GB 
SSD, I resize the partition after "dd"-ing the Lede image to it.


On sysupgrade, the partition table is re-written and "/" partition is 
back to 256 MB.


Is there a way the existing partition table or at least "/" partition 
size could be preserved?


Thanks in advance.

Regards,
Nishant

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] is there a reason not to use "git --version" to check for git?

[Robert P. J. Day]

  just noticed the following in include/prereq-build.mk, which checks
for an acceptable version of git:

$(eval $(call SetupHostCommand,git,Please install Git (git-core) >= 1.7.12.2, \
git --exec-path | xargs -I % -- grep -q -- --recursive %/git-submodule))


  is there a reason that makefile doesn't just invoke "git --version"
like most of the command checks in that makefile to test for the
version of git?

rday

p.s. this is a leadup to another post coming shortly.

-- 


Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] ath10k: Re-enable intermediate softqueues for all devices

[Toke Høiland-Jørgensen]

Toke Høiland-Jørgensen  writes:

> The upstream ath10k driver disables the intermediate softqueues for some
> devices. This patch reverts that behaviour and always enables the
> softqueues (and associated bufferbloat fixes). We have had reports of people
> running this with good results:
> https://lists.bufferbloat.net/pipermail/make-wifi-fast/2017-September/001497.html

So there seems to be some issues with QCA9980 with this patch. See
https://lists.bufferbloat.net/pipermail/make-wifi-fast/2017-September/001505.html

It may be safest to revert for now...

-Toke

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] ipq806x: Archer C2600: fix switch ports numbering

[Baptiste Jonglez]

Can this be merged to lede-17.01?  As I mentioned in the commit, it
applies cleanly.

Thanks,
Baptiste

On 23-08-17, Baptiste Jonglez wrote:
> The order of LAN ports shown in Luci is reversed compared to what is
> written on the case of the device.  Fix the order so that they match.
> 
> Signed-off-by: Baptiste Jonglez 
> ---
> This patch applies cleanly to the lede-17.01 branch and should
> be backported there too.
> 
>  target/linux/ipq806x/base-files/etc/board.d/02_network | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/target/linux/ipq806x/base-files/etc/board.d/02_network 
> b/target/linux/ipq806x/base-files/etc/board.d/02_network
> index 28e42dcaf8..28dc405c8a 100755
> --- a/target/linux/ipq806x/base-files/etc/board.d/02_network
> +++ b/target/linux/ipq806x/base-files/etc/board.d/02_network
> @@ -13,7 +13,6 @@ board=$(board_name)
>  
>  case "$board" in
>  ap148 |\
> -c2600 |\
>  d7800 |\
>  r7500 |\
>  r7500v2 |\
> @@ -22,6 +21,10 @@ vr2600v)
>   ucidef_add_switch "switch0" \
>   "1:lan" "2:lan" "3:lan" "4:lan" "6@eth1" "5:wan" "0@eth0"
>   ;;
> +c2600)
> + ucidef_add_switch "switch0" \
> + "1:lan:4" "2:lan:3" "3:lan:2" "4:lan:1" "6@eth1" "5:wan" 
> "0@eth0"
> + ;;
>  db149)
>   ucidef_set_interface_lan "eth1 eth2 eth3"
>   ucidef_add_switch "switch0" \


signature.asc
Description: PGP signature
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] scripts/download.pl: fail loudly if provided hash is unsupported

[Baptiste Jonglez]

Thanks for merging, can this be merged to lede-17.01 as well?

On 03-09-17, Baptiste Jonglez wrote:
> Currently, if the provided hash is unsupported (length different from 32
> or 64 bytes), we happily download the requested file without any kind of
> checksum verification.
> 
> This is quite dangerous and may provide a false sense of security, because
> a single typo in the hash (e.g. one character deleted by mistake) may skip
> checksum verification entirely.
> 
> Instead, fail immediately if we don't support the provided hash.
> In particular, if an external package repository decides to change the
> hash algorithm one day, we will now fail loudly instead of skipping
> checksum verification without complaints.
> 
> Note: if some users of scripts/download.pl knowingly provide an empty hash
> because they don't need checksum verification, this change will break
> them.  This does not seem to be the case currently, but if this feature is
> ever needed, an option should be added to download.pl instead of relying
> on the hash being empty.
> 
> Fixes: eaa4eba10a89 ("scripts/download.pl: add SHA-256 support")
> 
> Signed-off-by: Baptiste Jonglez 
> ---
>  scripts/download.pl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/download.pl b/scripts/download.pl
> index bf9fe8c761..775408934a 100755
> --- a/scripts/download.pl
> +++ b/scripts/download.pl
> @@ -88,6 +88,7 @@ sub download_cmd($) {
>  }
>  
>  my $hash_cmd = hash_cmd();
> +$hash_cmd or die "Cannot find appropriate hash command, ensure the provided 
> hash is either a MD5 or SHA256 checksum.\n";
>  
>  sub download
>  {


signature.asc
Description: PGP signature
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev