Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH
On 26 October 2017 at 17:50, Baptiste Jonglez wrote: > When calling a download target, hash verification is now completely > skipped if the SKIPHASH variable is set. > > This allows to easily bump package version: > > # Update PKG_VERSION in the package Makefile > $ make package//download SKIPHASH=1 V=s > $ make package//check FIXUP=1 V=s > > This will download the new version of the package, and then automatically > update PKG_HASH with the hash of the new version. Of course, it is still > the responsibility of the packager to ensure that the new tarball is > legitimate, because it is downloaded from a possibly untrusted source. Introducing another knob to the build system seems cubersome. I remembered that hash checking would be skipped if PKG_MD5SUM var was empty and the behaviour is very likely the same with PKG_HASH. The workflow can be simply emptying PKG_HASH var while bumping the versions, then do the download and hash fixup on the second command. This should eliminate the need for SKIPHASH var. Regards, yousong ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH v2] merge: add OpenWrt branding
On 27 October 2017 at 00:32, Imre Kaloz wrote: > Hi Paul, > > On 2017-10-26 18:16, p...@oranjevos.nl wrote: > > Please, could you add some info on what has changed with the new version of > the patch ? > And, it would be appreciated when the SOB would not use an openwrt.org mail > address (assuming Imre has another suitable mail available). > > Paul > > Op 26 okt. 2017, om 17:41 heeft Zoltan HERPAI het volgende > geschreven: > > Given that we've decided to sail under the same flag for > the benefit of the whole community, and acknowledge the > achievements of the LEDE project, let's start the final > steps of the merge. > > The git and other sources are untouched until the infra merge. > > v2: - dismiss bugtracker and forum change >- update uhttpd cert gen >- update banner >- update busybox NSLOOKUP patch > > Signed-off-by: Zoltan HERPAI > Signed-off-by: Imre Kaloz > > > Please find the changes listed in the description, but left it in above as > well. As for using another email address, I won't use my personal one for > this as I don't use this for that, simply as that. This is fully following > what the merge agreement that has been voted for and got accepted defined. > > > Best, > > Imre According to the first clause of v3 of the proposal, current LEDE project rules will be adopted into the merged OpenWrt project and that means we need to either start another voting round to reword the project rules on email accounts or the proposal itself contradicts/invalidates itself. Now we are having much fun with the rules... yousong ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] Testing ARM images
> On Oct 25, 2017, at 8:32 PM, Yousong Zhou wrote: > > On 26 October 2017 at 08:08, Philip Prindeville > wrote: >> Hi. >> >> I was recently working on updating Perl 5.26.1 which required making >> machine-specific parameters for cross-builds (because Perl doesn’t use >> autoconf), and was able to test for x86_64 on KVM/libvirt, but have not >> tried any other platforms (well, I built armvirt but haven’t run anything in >> a Qemu emulator). >> >> Can someone please update the Wiki to include: >> >> (1) what parameters to set when building a LEDE image like >> CONFIG_TARGET_, CONFIG_TARGET_BOARD, CONFIG_ARCH, etc. > > I got two defconfigs for malta and armvirt at github > > - https://github.com/yousong/gists/blob/master/lede/defconfig/malta-mini-be > - https://github.com/yousong/gists/blob/master/lede/defconfig/armvirt-mini > >> >> (2) also image parameters >> >> (3) how to provision the VM itself, perhaps including the XML for >> virsh/libvirt. >> > > scripts/qemustart can serve as a quickstart guide on running in QEMU machine. > > Regards, >yousong Thanks. Was hoping for a .xml template for “virsh” that I could use with “virsh define my_arm.xml” to provision. -Philip ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v2] merge: add OpenWrt branding
Hannu Nyman wrote: > Zoltan HERPAI kirjoitti 26.10.2017 klo 18:41: > > + - > > + * 2 oz. Orange Juice Combine all juices in a > > + * 2 oz. Pineapple Juice tall glass filled with > > + * 2 oz. Grapefruit Juice ice, stir well. > > + * 2 oz. Cranberry Juice > > + - > > > Still promoting the drink recipe although the voting is clearly > going against release names and also all given feedback about > drinks has been negative? Not all. I quite like the drinks, I was just strongly against going back to the old name. right now. When DD was chosen it was far from 100% one way or the other too. Cheers, Karl P signature.html Description: OpenPGP Digital Signature ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [OpenWrt-Devel] [RFC] A new developper documentation for OpenWrt/LEDE
Hi Baptiste,
first of all I think that is a great initiative!
> So, here is a RFC proposal of a new developer documentation based on
> git and Sphinx:
>
> https://files.polyno.me/openwrt/doc/index.html git clone
> git://git.polyno.me/openwrt-doc
The layout is okay and the ASCII markup looks reasonably simple to allow
for distraction-free text writing so LGTM here.
> This is really early work in progress, because it's good to have
> early feedback before I spend too much time on this :)
>
> The idea (which of course needs to be discussed) would be to keep
> this documentation in the same git repository as the main project.
> The main advantages compared with the wiki ("developer guide" [1] and
> associated pages [2,3]) would be:
That would be fine with me. There used to be some rudimentary
documentation in the past (see
http://git.lede-project.org/882f4d2d63272abce8c1966983aa10178e2e971f)
but it never got really updated.
> - ensuring the doc is reasonably up-to-date, because of fate
> sharing: whenever a patch modifies something substantial in the code
> base, it can update the documentation at the same time;
Such a policy can be introduced once the docs are reasonably complete,
before that it would likely put off contributors.
> - more focused scope: the scope is explicitly limited to developer
> documentation. This makes it easier to produce good, complete and
> consistent documentation. Also, as a contributor, searching for a
> particular topic would become easier than in the wiki;
I like that, yes.
> - allow release branches for the documentation. For instance, if a
> feature is changed in trunk, the documentation in the 17.01 branch
> would still be correct for LEDE 17.01. Likewise, when backporting a
> feature from trunk to a stable release, the associated documentation
> would be backported as well. This is exactly what Django does with
> its documentation [4].
That would be an upside as well; while I do not expect release branch
documentation to receive much maintenance it would at the very least
ensure that future documentation updates do not invalidate config that
used to be correct for a past release.
> On the downside, it would become harder to contribute to the
> documentation: this is likely a reason for the failure of the LEDE
> "web presence". But I think another important reason for this
> failure was the scope, which was too broad (both user + developer
> documentation).
That is a valid point but I would give it a try; after all I suspect
this documentation to target contributors already aware of how to use Git.
> Of course, this proposal is not meant to *replace* the existing
> documentation on the wiki, but rather to *complement* it. In my
> opinion, this new doc would serve as a detailed and up-to-date
> reference for OpenWrt internals, while the wiki would still be
> extremely useful for user-oriented documentation (which hopefully
> would become even more relevant and accurate thanks to this new
> reference documentation).
I think we can figure out a way to automatically mirror the
documentation to the wiki so that users have a common location for user
and developer documentation.
> I can commit to setting it up, and help keeping it alive over the
> next few months/years. But of course it is not possible nor
> desirable to do this alone! Help would be required in the following
> areas:
>
> 1) define the general structure of the doc: what should go in, what
> shouldn't, and how to organize the content; 2) initial effort:
> importing/refreshing relevant bits from the wiki, and writing the
> rest; 3) define some consensual rules on how to keep the doc
> up-to-date with the codebase.
You can count me in on 1) and 2). 3) should be deferred until a
reasonable base line is established. To simplify bootstrapping the
project we can also setup a scratch repo somewhere with direct push
access to documentation contributors.
> Now for the questions:
>
> - does this seem to go in the right direction?
Definitely!
> - would all developers be willing to spend a reasonable amount of
> time and effort to keep this documentation project alive and
> up-to-date over time?
I cannot speak for the others but I am personally interested in working
on the documentation. I also wrote parts of the existing uci references
and generally like working on such things. I cannot promise that I'll
have much time to write lots of text but I can certainly explain things
and help with answering questions.
> - what should be the general structure of this documentation? It
> would have been nice to brainstorm on this at the OpenWrt summit,
> but unfortunately I cannot attend.
It might make sense to set up an etherpad here to gather some structural
ideas.
Cheers,
Jo
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] Please add support for Easybox-904xDSL
Hi all, is it possible that somewhere add the great work from QAuge to the lede-project ? Support of the Easybox 904xDSL inside the next Major release will be great. https://forum.openwrt.org/viewtopic.php?id=3D44676 https://github.com/Quallenauge/Easybox-904-XDSL ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v2] merge: add OpenWrt branding
On 10/26/2017 9:05 PM, Dave Taht wrote: "Blurry fish butt" I think was (until recently) a codename for the linux kernel. It's just Torvalds making fun of codenames, the linux kernel "codename" isn't used anywhere outside of Torvalds posts. -Alberto ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v2] merge: add OpenWrt branding
Hannu Nyman writes: > Zoltan HERPAI kirjoitti 26.10.2017 klo 18:41: >> + - >> + * 2 oz. Orange Juice Combine all juices in a >> + * 2 oz. Pineapple Juice tall glass filled with >> + * 2 oz. Grapefruit Juice ice, stir well. >> + * 2 oz. Cranberry Juice >> + - > > > Still promoting the drink recipe although the voting is clearly going against > release names and also all given feedback about drinks has been negative? I incidentally have always liked the in-your-face anti-establishment flair of using codenames based on alcoholic beverages. The drink meme beats the hell out of corporate blandness with selecting codenames out of a marketing jar - "Project Olympus!", and is easier to remember than 17.X.Y. "Blurry fish butt" I think was (until recently) a codename for the linux kernel. and I've joked elsewhere that I'd like a codename named "green goddess". https://www.allbud.com/marijuana-strains/sativa-dominant-hybrid/green-goddess > Please get rid of it. It makes the whole thing looks adolescent. And replace it with what? (where was the voting?) ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v2] merge: add OpenWrt branding
Zoltan HERPAI kirjoitti 26.10.2017 klo 18:41: + - + * 2 oz. Orange Juice Combine all juices in a + * 2 oz. Pineapple Juice tall glass filled with + * 2 oz. Grapefruit Juice ice, stir well. + * 2 oz. Cranberry Juice + - Still promoting the drink recipe although the voting is clearly going against release names and also all given feedback about drinks has been negative? Please get rid of it. It makes the whole thing looks adolescent. ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] Merged: kernel: enable CONFIG_ADVISE_SYSCALLS
Merged into my staging tree with http://git.lede-project.org/?p=lede/jow/staging.git;a=commitdiff;h=bc584ac5d1. Thank you! ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v2] merge: add OpenWrt branding
Please, could you add some info on what has changed with the new version of the patch ? And, it would be appreciated when the SOB would not use an openwrt.org mail address (assuming Imre has another suitable mail available). Paul > Op 26 okt. 2017, om 17:41 heeft Zoltan HERPAI het volgende > geschreven: > > Given that we've decided to sail under the same flag for > the benefit of the whole community, and acknowledge the > achievements of the LEDE project, let's start the final > steps of the merge. > > The git and other sources are untouched until the infra merge. > > v2: - dismiss bugtracker and forum change >- update uhttpd cert gen >- update banner >- update busybox NSLOOKUP patch > > Signed-off-by: Zoltan HERPAI > Signed-off-by: Imre Kaloz > --- > Config.in | 2 +- > Makefile | 2 +- > README | 6 +++--- > include/image-commands.mk | 6 +++--- > include/image.mk | 2 +- > include/prereq-build.mk| 2 +- > include/version.mk | 8 > package/base-files/Makefile| 2 +- > package/base-files/files/bin/config_generate | 10 +- > package/base-files/files/etc/banner| 23 -- > package/base-files/files/etc/init.d/system | 2 +- > .../files/lib/preinit/10_indicate_preinit | 2 +- > package/base-files/image-config.in | 10 +- > package/boot/uboot-layerscape-armv8_32b/Makefile | 2 +- > .../kernel/broadcom-wl/files/lib/wifi/broadcom.sh | 2 +- > package/kernel/mac80211/files/lib/wifi/mac80211.sh | 2 +- > package/network/services/hostapd/files/hostapd.sh | 4 ++-- > package/network/services/lldpd/files/lldpd.config | 2 +- > package/network/services/lldpd/files/lldpd.init| 2 +- > .../network/services/samba36/files/samba.config| 4 ++-- > package/network/services/samba36/files/samba.init | 6 +++--- > .../network/services/uhttpd/files/uhttpd.config| 2 +- > package/network/services/uhttpd/files/uhttpd.init | 2 +- > package/network/utils/iproute2/Makefile| 2 +- > package/utils/busybox/Config-defaults.in | 4 ++-- > package/utils/busybox/config/networking/Config.in | 12 +-- > .../busybox/patches/230-add_nslookup_lede.patch| 16 +++ > package/utils/ct-bugcheck/src/bugcheck.sh | 4 ++-- > scripts/brcmImage.pl | 2 +- > scripts/checkpatch.pl | 2 +- > scripts/config/mconf.c | 2 +- > scripts/qemustart | 12 +-- > target/imagebuilder/Config.in | 2 +- > target/imagebuilder/files/repositories.conf| 2 +- > target/linux/apm821xx/image/Makefile | 2 +- > target/linux/ar71xx/image/generic.mk | 4 ++-- > target/linux/ar71xx/image/legacy.mk| 4 ++-- > target/linux/ar71xx/image/tp-link.mk | 2 +- > target/linux/armvirt/README| 16 +++ > target/linux/brcm63xx/image/bcm63xx.mk | 6 +++--- > target/linux/lantiq/image/Makefile | 2 +- > target/linux/mcs814x/image/Makefile| 2 +- > target/linux/mvebu/image/cfbase-boot.script| 4 ++-- > target/linux/mvebu/image/cfpro-boot.script | 4 ++-- > .../linux/omap24xx/base-files/etc/config/wireless | 2 +- > target/linux/uml/README| 5 +++-- > target/linux/x86/image/grub-iso.cfg| 2 +- > target/linux/x86/image/grub.cfg| 4 ++-- > target/sdk/Config.in | 4 ++-- > target/sdk/files/README.SDK| 4 ++-- > target/toolchain/Config.in | 6 +++--- > target/toolchain/files/README.TOOLCHAIN| 2 +- > toolchain/gcc/common.mk| 4 ++-- > 53 files changed, 124 insertions(+), 120 deletions(-) > > diff --git a/Config.in b/Config.in > index ddbc4e2..d30c048 100644 > --- a/Config.in > +++ b/Config.in > @@ -4,7 +4,7 @@ > # See /LICENSE for more information. > # > > -mainmenu "LEDE Configuration" > +mainmenu "OpenWrt Configuration" > > config MODULES > option modules > diff --git a/Makefile b/Makefile > index 09db75c..0a1f96a 100644 > --- a/Makefile > +++ b/Makefile > @@ -14,7 +14,7 @@ export TOPDIR LC_ALL LANG TZ > > empty:= > space:= $(empty) $(empty) > -$(if $(findstring $(space),$(TOPDIR)),$(error ERROR: The path to the LEDE > directory must not include any spaces)) > +$(if $(findstring $(space),$(TOPDIR)),$(error ERROR: The path to the OpenWrt > directory must not include any spaces)) > > world: > > diff --git a/README b/README > index 405c18b..864ea2f 1006
[LEDE-DEV] 34c3 CyberCompetenceCenter Infrastructure
Dear Free Infrastructure Enthusiasts, as you know the 34c3 is taking place in Leipzig and the organ team wants to shift more of the planning to the Communities. The orga wants to place all assemblies that have an infrastructure focus into a "CyberCompetenceCenter Infratsructure" :) The years before we have been placed anyways nearby by the assembly-orga ... Since Freifunk had already last year a speakers corner with some sessions, we have been asked to organize a stage for the CyberCompetenceCenter Infrastructure. Our current planning consists on 4 parts we will organize for all Infra-Assemblies or people in common, but we need your support to make it happen: An Exhibition area -> Please provide us Infrastructure pieces, posters or projections or whatever … A stage - We hope to have video streaming -> Please contribute to program with updates regarding your network, talks, quizzes, panels, discussions … -> Also I had the idea to show videos/documentaries in the evening, like from the Argentinians or Sarantaporo -> please send me links (lost them) -> Please invite speakers, you find interesting in terms of community or infrastructure topics, if they are attending the congress … unfortunately we cannot sponsor travel costs -> Please enter your session here: https://wiki.freifunk.net/34c3/Timetable Info desk -> Please bring or send flyers, buttons, stickers, books … if you need a postal address, please send me an email A Chillout area -> Sofas … we will organize that ;) -> We also do need help in terms of decoration and stage heralds (to start video and help speakers) and a DJs for the Infra-Drinkup! -> Join the OrgaMailinglist here: https://lists.freifunk.net/mailman/listinfo/34c3-orga-freifunk.net -> Do spread this mail to your channels or other groups that may be interested in infra topics! Who is attending the 34c3? We look forward to meet with you and collaborate for a gorgeous infrastructure space! Greetings from the Freifunk 34c3 Orgateam ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] [PATCH v2] merge: add OpenWrt branding
Given that we've decided to sail under the same flag for the benefit of the whole community, and acknowledge the achievements of the LEDE project, let's start the final steps of the merge. The git and other sources are untouched until the infra merge. v2: - dismiss bugtracker and forum change - update uhttpd cert gen - update banner - update busybox NSLOOKUP patch Signed-off-by: Zoltan HERPAI Signed-off-by: Imre Kaloz --- Config.in | 2 +- Makefile | 2 +- README | 6 +++--- include/image-commands.mk | 6 +++--- include/image.mk | 2 +- include/prereq-build.mk| 2 +- include/version.mk | 8 package/base-files/Makefile| 2 +- package/base-files/files/bin/config_generate | 10 +- package/base-files/files/etc/banner| 23 -- package/base-files/files/etc/init.d/system | 2 +- .../files/lib/preinit/10_indicate_preinit | 2 +- package/base-files/image-config.in | 10 +- package/boot/uboot-layerscape-armv8_32b/Makefile | 2 +- .../kernel/broadcom-wl/files/lib/wifi/broadcom.sh | 2 +- package/kernel/mac80211/files/lib/wifi/mac80211.sh | 2 +- package/network/services/hostapd/files/hostapd.sh | 4 ++-- package/network/services/lldpd/files/lldpd.config | 2 +- package/network/services/lldpd/files/lldpd.init| 2 +- .../network/services/samba36/files/samba.config| 4 ++-- package/network/services/samba36/files/samba.init | 6 +++--- .../network/services/uhttpd/files/uhttpd.config| 2 +- package/network/services/uhttpd/files/uhttpd.init | 2 +- package/network/utils/iproute2/Makefile| 2 +- package/utils/busybox/Config-defaults.in | 4 ++-- package/utils/busybox/config/networking/Config.in | 12 +-- .../busybox/patches/230-add_nslookup_lede.patch| 16 +++ package/utils/ct-bugcheck/src/bugcheck.sh | 4 ++-- scripts/brcmImage.pl | 2 +- scripts/checkpatch.pl | 2 +- scripts/config/mconf.c | 2 +- scripts/qemustart | 12 +-- target/imagebuilder/Config.in | 2 +- target/imagebuilder/files/repositories.conf| 2 +- target/linux/apm821xx/image/Makefile | 2 +- target/linux/ar71xx/image/generic.mk | 4 ++-- target/linux/ar71xx/image/legacy.mk| 4 ++-- target/linux/ar71xx/image/tp-link.mk | 2 +- target/linux/armvirt/README| 16 +++ target/linux/brcm63xx/image/bcm63xx.mk | 6 +++--- target/linux/lantiq/image/Makefile | 2 +- target/linux/mcs814x/image/Makefile| 2 +- target/linux/mvebu/image/cfbase-boot.script| 4 ++-- target/linux/mvebu/image/cfpro-boot.script | 4 ++-- .../linux/omap24xx/base-files/etc/config/wireless | 2 +- target/linux/uml/README| 5 +++-- target/linux/x86/image/grub-iso.cfg| 2 +- target/linux/x86/image/grub.cfg| 4 ++-- target/sdk/Config.in | 4 ++-- target/sdk/files/README.SDK| 4 ++-- target/toolchain/Config.in | 6 +++--- target/toolchain/files/README.TOOLCHAIN| 2 +- toolchain/gcc/common.mk| 4 ++-- 53 files changed, 124 insertions(+), 120 deletions(-) diff --git a/Config.in b/Config.in index ddbc4e2..d30c048 100644 --- a/Config.in +++ b/Config.in @@ -4,7 +4,7 @@ # See /LICENSE for more information. # -mainmenu "LEDE Configuration" +mainmenu "OpenWrt Configuration" config MODULES option modules diff --git a/Makefile b/Makefile index 09db75c..0a1f96a 100644 --- a/Makefile +++ b/Makefile @@ -14,7 +14,7 @@ export TOPDIR LC_ALL LANG TZ empty:= space:= $(empty) $(empty) -$(if $(findstring $(space),$(TOPDIR)),$(error ERROR: The path to the LEDE directory must not include any spaces)) +$(if $(findstring $(space),$(TOPDIR)),$(error ERROR: The path to the OpenWrt directory must not include any spaces)) world: diff --git a/README b/README index 405c18b..864ea2f 100644 --- a/README +++ b/README @@ -1,4 +1,4 @@ -This is the buildsystem for the LEDE Linux distribution. +This is the buildsystem for the OpenWrt Linux distribution. Please use "make menuconfig" to choose your preferred configuration for the toolchain and firmware. @@ -23,7 +23,7 @@ the lack of case sensitiveness in the file system. Sunshine! - Your LEDE Community - http://www.lede-project.org + Your OpenWrt Communi
Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH
Baptiste Jonglez wrote: > When calling a download target, hash verification is now completely > skipped if the SKIPHASH variable is set. > This allows to easily bump package version: > # Update PKG_VERSION in the package Makefile > $ make package//download SKIPHASH=1 V=s > $ make package//check FIXUP=1 V=s Maybe better introduce DL_OPT and use it? ifdef SKIPHASH DL_OPT += --skip-hash endif ... $(SCRIPT_DIR)/download.pl $(DL_OPT) "$(DL_DIR)" "$(FILE)" "$(HASH)" "$(URL_FILE)" $(foreach url,$(URL),"$(url)") \ ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH
Baptiste Jonglez wrote:
> When calling a download target, hash verification is now
> completely skipped if the SKIPHASH variable is set.
>
> This allows to easily bump package version:
>
> # Update PKG_VERSION in the package Makefile
> $ make package//download SKIPHASH=1 V=s
> $ make package//check FIXUP=1 V=s
>
> This will download the new version of the package, and then
> automatically update PKG_HASH with the hash of the new version.
> Of course, it is still the responsibility of the packager to
> ensure that the new tarball is legitimate, because it is
> downloaded from a possibly untrusted source.
>
> Fixes: b30ba14e ("scripts/download.pl: fail loudly if provided
> hash is unsupported") Signed-off-by: Baptiste Jonglez
>
Until/if your new documentation project takes off, please
consider adding this to the "how to package" doc pages. none of
these extra magical parameters are discoverable in any way right
now.
signature.html
Description: OpenPGP Digital Signature
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH
When calling a download target, hash verification is now completely
skipped if the SKIPHASH variable is set.
This allows to easily bump package version:
# Update PKG_VERSION in the package Makefile
$ make package//download SKIPHASH=1 V=s
$ make package//check FIXUP=1 V=s
This will download the new version of the package, and then automatically
update PKG_HASH with the hash of the new version. Of course, it is still
the responsibility of the packager to ensure that the new tarball is
legitimate, because it is downloaded from a possibly untrusted source.
Fixes: b30ba14e ("scripts/download.pl: fail loudly if provided hash is
unsupported")
Signed-off-by: Baptiste Jonglez
---
include/download.mk | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/download.mk b/include/download.mk
index 0a25641738..a6821b5304 100644
--- a/include/download.mk
+++ b/include/download.mk
@@ -102,12 +102,18 @@ check_md5 = \
hash_var = $(if $(filter-out x,$(1)),MD5SUM,HASH)
endif
+ifdef SKIPHASH
+DOWNLOAD_CMD = $(SCRIPT_DIR)/download.pl --skip-hash
+else
+DOWNLOAD_CMD = $(SCRIPT_DIR)/download.pl
+endif
+
define DownloadMethod/unknown
echo "ERROR: No download method available"; false
endef
define DownloadMethod/default
- $(SCRIPT_DIR)/download.pl "$(DL_DIR)" "$(FILE)" "$(HASH)" "$(URL_FILE)"
$(foreach url,$(URL),"$(url)") \
+ $(DOWNLOAD_CMD) "$(DL_DIR)" "$(FILE)" "$(HASH)" "$(URL_FILE)" $(foreach
url,$(URL),"$(url)") \
$(if $(filter check,$(1)), \
$(call check_hash,$(FILE),$(HASH),$(2)$(call
hash_var,$(MD5SUM))) \
$(call check_md5,$(MD5SUM),$(2)MD5SUM,$(2)HASH) \
--
2.11.0
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
[LEDE-DEV] [PATCH 1/2] scripts/download.pl: Add a --skip-hash option
When the new "--skip-hash" option is passed to scripts/download.pl, hash
verification of the downloaded files is completely skipped. This can be
useful when bumping package version, since the hash may not be known in
advance.
Signed-off-by: Baptiste Jonglez
---
scripts/download.pl | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/scripts/download.pl b/scripts/download.pl
index 775408934a..e0bf187559 100755
--- a/scripts/download.pl
+++ b/scripts/download.pl
@@ -13,9 +13,11 @@ use File::Basename;
use File::Copy;
use Text::ParseWords;
-@ARGV > 2 or die "Syntax: $0
[ ...]\n";
+@ARGV > 2 or die "Syntax: $0 [--skip-hash] [ ...]\n";
my $url_filename;
+my $skip_hash = 0;
+$skip_hash = shift @ARGV if $ARGV[0] eq "--skip-hash";
my $target = glob(shift @ARGV);
my $filename = shift @ARGV;
my $file_hash = shift @ARGV;
@@ -87,8 +89,13 @@ sub download_cmd($) {
;
}
-my $hash_cmd = hash_cmd();
-$hash_cmd or die "Cannot find appropriate hash command, ensure the provided
hash is either a MD5 or SHA256 checksum.\n";
+my $hash_cmd;
+if ($skip_hash) {
+ print("Warning: skipping hash verification as requested.\n");
+} else {
+ $hash_cmd = hash_cmd();
+ $hash_cmd or die "Cannot find appropriate hash command, ensure the
provided hash is either a MD5 or SHA256 checksum.\n";
+}
sub download
{
--
2.11.0
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
