[LEDE-DEV] [PATCH] ath10k-ct: Update firmware to latest.

2018-03-26 Thread greearb
From: Ben Greear 

Wave-1 firmware has a fix for 'addba' not finding the peer.  Thanks to Hauke
for finding and reporting this.

Wave-2 firmware has a fix for leaking a peer multicast key when a monitor device
is created.

And I re-ordered the '4019' firmware images in the Makefile to match the order
of the others.  No functional change for that reorder.

Signed-off-by: Ben Greear 
---
 package/firmware/ath10k-firmware/Makefile | 58 +++
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/package/firmware/ath10k-firmware/Makefile 
b/package/firmware/ath10k-firmware/Makefile
index 0099146..a8c3e7d 100644
--- a/package/firmware/ath10k-firmware/Makefile
+++ b/package/firmware/ath10k-firmware/Makefile
@@ -64,92 +64,92 @@ define Download/ct-firmware-htt
   URL_FILE:=$($(1)_FIRMWARE_FILE_CT_HTT)
 endef
 
-QCA988X_FIRMWARE_FILE_CT:=firmware-2-ct-full-community-20.bin.lede.001
+QCA988X_FIRMWARE_FILE_CT:=firmware-2-ct-full-community-20.bin.lede.006
 define Download/ath10k-firmware-qca988x-ct
   $(call Download/ct-firmware,QCA988X,)
-  HASH:=77a57d4e0da5fa1efab64cb36e0363ce49d7b7638bcfd1e8c8e323673c4abef8
+  HASH:=b28ff3eb10f15033be68bbedc91abcf40f7369cc44da4273e3c0df285c74a4f8
 endef
 $(eval $(call Download,ath10k-firmware-qca988x-ct))
 
-QCA988X_FIRMWARE_FILE_CT_HTT:=firmware-2-ct-full-htt-mgt-community-20.bin.lede.001
+QCA988X_FIRMWARE_FILE_CT_HTT:=firmware-2-ct-full-htt-mgt-community-20.bin.lede.006
 define Download/ath10k-firmware-qca988x-ct-htt
   $(call Download/ct-firmware-htt,QCA988X,)
-  HASH:=a1f90d9de19bb148f3e4c6570bf7572cf90c7c6870d0afcf8a87d67114eab701
+  HASH:=08dd8d339079c9a704cf3f91787cc06a73168a9f57eeb777edaa9cd4194c246c
 endef
 $(eval $(call Download,ath10k-firmware-qca988x-ct-htt))
 
 
-QCA9887_FIRMWARE_FILE_CT:=firmware-2-ct-full-community-20.bin.lede.001
+QCA9887_FIRMWARE_FILE_CT:=firmware-2-ct-full-community-20.bin.lede.006
 define Download/ath10k-firmware-qca9887-ct
   $(call Download/ct-firmware,QCA9887,ath10k-9887)
-  HASH:=94081f86e7058083170fe25fa3735026a99fe535890b80ac81b28d0f5e0cc089
+  HASH:=8d3fd2fb62479efa955e0d0487ca8971409e68b395f3a2df28569ec243bd937d
 endef
 $(eval $(call Download,ath10k-firmware-qca9887-ct))
 
-QCA9887_FIRMWARE_FILE_CT_HTT:=firmware-2-ct-full-htt-mgt-community-20.bin.lede.001
+QCA9887_FIRMWARE_FILE_CT_HTT:=firmware-2-ct-full-htt-mgt-community-20.bin.lede.006
 define Download/ath10k-firmware-qca9887-ct-htt
   $(call Download/ct-firmware-htt,QCA9887,ath10k-9887)
-  HASH:=f31e5f5f546ef7c104b9526d0a95faf4c291b21e7512a19f624c5a015dee80f1
+  HASH:=f192b5a8ac4b90d828cace0a2279c02fda689fa936f5154f08df6658d0230e9b
 endef
 $(eval $(call Download,ath10k-firmware-qca9887-ct-htt))
 
 
-QCA99X0_FIRMWARE_FILE_CT:=firmware-5-ct-full-community-10.bin-lede.001
+QCA99X0_FIRMWARE_FILE_CT:=firmware-5-ct-full-community-10.bin-lede.006
 define Download/ath10k-firmware-qca99x0-ct
   $(call Download/ct-firmware,QCA99X0,ath10k-10-4)
-  HASH:=5d0765496982cb504a233395b91407b10b82a334adb928324489c67916f349f1
+  HASH:=1aa21acab7974651af6c0a2698891fc8792edb5124824fac1587123d3b48df67
 endef
 $(eval $(call Download,ath10k-firmware-qca99x0-ct))
 
-QCA99X0_FIRMWARE_FILE_CT_HTT:=firmware-5-ct-full-htt-mgt-community-10.bin-lede.001
+QCA99X0_FIRMWARE_FILE_CT_HTT:=firmware-5-ct-full-htt-mgt-community-10.bin-lede.006
 define Download/ath10k-firmware-qca99x0-ct-htt
   $(call Download/ct-firmware-htt,QCA99X0,ath10k-10-4)
-  HASH:=520f0ecfeba034056a196793d2f0e628d4c89bd1080c6a811fdc3a4b35bfe8d6
+  HASH:=e3d89c00f194975649b2f41ff5f5ffc34d60c393d15800df6ea56a8ac29a
 endef
 $(eval $(call Download,ath10k-firmware-qca99x0-ct-htt))
 
 
-QCA9984_FIRMWARE_FILE_CT:=firmware-5-ct-full-community-10.bin-lede.001
+QCA9984_FIRMWARE_FILE_CT:=firmware-5-ct-full-community-10.bin-lede.006
 define Download/ath10k-firmware-qca9984-ct
   $(call Download/ct-firmware,QCA9984,ath10k-9984-10-4)
-  HASH:=1bb526349182e23be79f73ca4e9761bc0f20b2672efdce9976f31804df750e96
+  HASH:=f9700cafb4e2cebe8364eb6fe1754eb2c37b1b02a7408ded908ecc78954380a3
 endef
 $(eval $(call Download,ath10k-firmware-qca9984-ct))
 
-QCA9984_FIRMWARE_FILE_CT_HTT:=firmware-5-ct-full-htt-mgt-community-10.bin-lede.001
+QCA9984_FIRMWARE_FILE_CT_HTT:=firmware-5-ct-full-htt-mgt-community-10.bin-lede.006
 define Download/ath10k-firmware-qca9984-ct-htt
   $(call Download/ct-firmware-htt,QCA9984,ath10k-9984-10-4)
-  HASH:=cf18bd88f8995d383be25fe302b205b8cde3f593b88e34bdffe05732520abfde
+  HASH:=c8c288cd38f3e6b378d7ed8407ee6b01cfcc73acc03d6ad5b8d392a8a346dd82
 endef
 $(eval $(call Download,ath10k-firmware-qca9984-ct-htt))
 
 
-QCA4019_FIRMWARE_FILE_CT_HTT:=firmware-5-ct-full-htt-mgt-community-10.bin-lede.003
-define Download/ath10k-firmware-qca4019-ct-htt
-  $(call Download/ct-firmware-htt,QCA4019,ath10k-4019-10-4)
-  HASH:=7648902c9bc7b173b0845da79b7e469b87c192efb387e25505007edbe5661a17
-endef
-$(eval $(call Download,ath10k-firmware-qca4019-ct-htt))
-

Re: [LEDE-DEV] [PATCH] uci: fix a potential use-after-free in uci_set()

2018-03-26 Thread Hans Dedecker
On Sun, Mar 25, 2018 at 3:30 AM, Jordan Miner  wrote:
> When calling uci_set() to update an option, if ptr->o != NULL and
> ptr->option == NULL, then uci_expand_ptr() will set ptr->option to
> ptr->o->e.name (or the caller could set ptr->option to that value). In
> this case, the option will be freed just before calling
> uci_alloc_option() with ptr->option, which was just freed.
Patch applied with a minor tweak; thx

Hans
>
> Signed-off-by: Jordan Miner 
> ---
>  list.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/list.c b/list.c
> index 0347138..3c46a0b 100644
> --- a/list.c
> +++ b/list.c
> @@ -666,6 +666,7 @@ int uci_set(struct uci_context *ctx, struct uci_ptr *ptr)
>  {
> /* NB: UCI_INTERNAL use means without delta tracking */
> bool internal = ctx && ctx->internal;
> +   struct uci_option *o;
>
> UCI_HANDLE_ERR(ctx);
> uci_expand_ptr(ctx, ptr, false);
> @@ -698,8 +699,9 @@ int uci_set(struct uci_context *ctx, struct uci_ptr *ptr)
> if ((ptr->o->type == UCI_TYPE_STRING) &&
> !strcmp(ptr->o->v.string, ptr->value))
> return 0;
> -   uci_free_option(ptr->o);
> +   o = ptr->o;
> ptr->o = uci_alloc_option(ptr->s, ptr->option, ptr->value);
> +   uci_free_option(o);
> ptr->last = >o->e;
> } else if (ptr->s && ptr->section) { /* update section */
> char *s = uci_strdup(ctx, ptr->value);
> --
> 2.7.4
>
>
> ___
> Lede-dev mailing list
> Lede-dev@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev


[LEDE-DEV] [PATCH] leds-apu2: add newer board names

2018-03-26 Thread Sebastian Fleer
In recent firmware releases the board names changed from "apuX" to "PC Engines 
apuX"

Signed-off-by: Sebastian Fleer 
---
 package/kernel/leds-apu2/src/leds-apu2.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/package/kernel/leds-apu2/src/leds-apu2.c 
b/package/kernel/leds-apu2/src/leds-apu2.c
index 4ea552c..2fefa85 100644
--- a/package/kernel/leds-apu2/src/leds-apu2.c
+++ b/package/kernel/leds-apu2/src/leds-apu2.c
@@ -335,7 +335,10 @@ static int __init gpio_apu2_init (void)
if (!board_name \
|| !board_vendor \
|| strcasecmp(board_vendor, "PC Engines") \
-   || (strcasecmp(board_name, "apu2") && 
strcasecmp(board_name, "apu3"))) {
+   || (strcasecmp(board_name, "apu2") \
+   && strcasecmp(board_name, "apu3") \
+   && strcasecmp(board_name, "PC Engines apu2") \
+   && strcasecmp(board_name, "PC Engines apu3"))) {
err = -ENODEV;
goto exit;
}
-- 
2.7.4


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev


[LEDE-DEV] netifd: l2tp connections no longer working

2018-03-26 Thread Alin Năstac
Hi Felix,

A setup using an l2tp interface that connects to an on-link L2TP
server stopped working after cherry picking this netifd commit:
authorFelix Fietkau 
Thu, 8 Mar 2018 00:14:57 +0200 (23:14 +0100)
commit1f5a29c3de6e3fec5883796ee772e25d56db6a69
ip: do not add local routes for host dependencies

This avoids creating invalid routes in cases where another daemon is
handling local routes for an interface, e.g. on mesh interfaces

I've found that l2tp connection fails to start in 2 different
scenarios. In both cases the IP addresses and routes are configured
entirely through netifd.

1) l2tp server is reachable through wan interface, configured as follows:
uci set network.wan.proto=dhcp
uci set network.wan.ifname=eth4
uci set network.wan.reqopts='1 33 121'
uci set network.wan.iface6rd='0'
uci set network.wan.release='1'
uci set network.wan.metric=10
uci set network.wan.ipv6='0'
uci set network.l2tp=interface
uci set network.l2tp.proto='l2tp'
uci set network.l2tp.server='l2tp.domain.com'
uci set network.l2tp.username='qacafe'
uci set network.l2tp.password='qacafe123'
uci set network.l2tp.checkup_interval='20'
In this case CDROUTER host connected to the wan interface play roles
of DHCP, DNS and L2TP server.

2) l2tp server is reachable through the lan interface:
uci set network.lan=interface
uci set network.lan.type='bridge'
uci set network.lan.proto='static'
uci set network.lan.ipaddr='192.168.1.1'
uci set network.lan.netmask='255.255.255.0'
uci set network.lan.ifname='eth0 eth1 eth2 eth3'
uci set network.l2tp=interface
uci set network.l2tp.proto='l2tp'
uci set network.l2tp.server='192.168.1.10'
uci set network.l2tp.username='qacafe'
uci set network.l2tp.password='qacafe123'
uci set network.l2tp.checkup_interval='20'

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev