Re: [LEDE-DEV] [PATCH mdns] Add simple "Fall through" comment to the announce_timer function switch

[John Crispin]

On 08/02/2017 15:20, Rafał Miłecki wrote:
> From: Rafał Miłecki 
> 
> It's a common practice to add such comments to make it clear break
> instruction was skipped on purpose.
> 
> Signed-off-by: Rafał Miłecki 
Acked-by: John Crispin 

feel free to push the changes to the repo

> ---
>  announce.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/announce.c b/announce.c
> index d1aca5b..03c7b8f 100644
> --- a/announce.c
> +++ b/announce.c
> @@ -62,6 +62,7 @@ announce_timer(struct uloop_timeout *timeout)
>   return;
>   }
>   iface->announce_state++;
> + /* Fall through */
>  
>   case STATE_ANNOUNCE:
>   service_announce(iface, announce_ttl);
> 

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] [PATCH mdns] Add simple "Fall through" comment to the announce_timer function switch

[Rafał Miłecki]

From: Rafał Miłecki 

It's a common practice to add such comments to make it clear break
instruction was skipped on purpose.

Signed-off-by: Rafał Miłecki 
---
 announce.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/announce.c b/announce.c
index d1aca5b..03c7b8f 100644
--- a/announce.c
+++ b/announce.c
@@ -62,6 +62,7 @@ announce_timer(struct uloop_timeout *timeout)
return;
}
iface->announce_state++;
+   /* Fall through */
 
case STATE_ANNOUNCE:
service_announce(iface, announce_ttl);
-- 
2.11.0


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev