Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing, capabilities
Hi Mauro, I am afraid no luck with send-email: $ git send-email git: 'send-email' is not a git command. See 'git --help'. $ git --version git version 2.7.4 $ uname -a Linux sirius.ezplanet.org 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Ubuntu (and Debian) keep git-send-email in a separate package named "git-email" - just install this package using your preferred package manager client (e.g. "apt-get install git-email"). HTH, Richard ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing capabilities
@John, I send this patch using git send-email. Please let me know if this one is OK. Please note that patches sent previously are superseded by this version. Mauro On 28/02/17 15:54, ma...@ezplanet.org wrote: From: Mauro MozzarelliIPVS (IP Virtual Server) implements transport-layer load balancing inside the Linux kernel, so called Layer-4 switching. IPVS running on a host acts as a load balancer at the front of a cluster of real servers, it can direct requests for TCP/UDP based services to the real servers, and makes services of the real servers to appear as a virtual service on a single IP address. This patch adds kmod-nf-ipvs kernel modules option to LEDE kernel netfilter Signed-off-by: Mauro Mozzarelli --- package/kernel/linux/modules/netfilter.mk | 89 +++ 1 file changed, 89 insertions(+) diff --git a/package/kernel/linux/modules/netfilter.mk b/package/kernel/linux/modules/netfilter.mk index 6162dbc..3e4d0ba 100644 --- a/package/kernel/linux/modules/netfilter.mk +++ b/package/kernel/linux/modules/netfilter.mk @@ -77,6 +77,17 @@ endef $(eval $(call KernelPackage,nf-conntrack)) +define KernelPackage/nf-conntrack-ftp + SUBMENU:=$(NF_MENU) + TITLE:=FTP connection tracking + KCONFIG:=CONFIG_NF_CONNTRACK_FTP + DEPENDS:=kmod-nf-conntrack + FILES:=$(LINUX_DIR)/net/netfilter/nf_conntrack_ftp.ko +endef + +$(eval $(call KernelPackage,nf-conntrack-ftp)) + + define KernelPackage/nf-conntrack6 SUBMENU:=$(NF_MENU) TITLE:=Netfilter IPv6 connection tracking @@ -271,6 +282,84 @@ define KernelPackage/ipt-ipset endef $(eval $(call KernelPackage,ipt-ipset)) +IPVS_MODULES:= \ +ipvs/ip_vs \ +ipvs/ip_vs_lc \ +ipvs/ip_vs_wlc \ +ipvs/ip_vs_rr \ +ipvs/ip_vs_wrr \ +ipvs/ip_vs_lblc \ +ipvs/ip_vs_lblcr \ +ipvs/ip_vs_dh \ +ipvs/ip_vs_sh \ +ipvs/ip_vs_fo \ +ipvs/ip_vs_ovf \ +ipvs/ip_vs_nq \ +ipvs/ip_vs_sed \ +xt_ipvs + +define KernelPackage/nf-ipvs + SUBMENU:=Netfilter Extensions + TITLE:=IP Virtual Server modules + DEPENDS:=@IPV6 +kmod-lib-crc32c +kmod-ipt-conntrack +kmod-nf-conntrack + KCONFIG:= \ +CONFIG_IP_VS \ +CONFIG_IP_VS_IPV6=y \ +CONFIG_IP_VS_DEBUG=n \ +CONFIG_IP_VS_PROTO_TCP=y \ +CONFIG_IP_VS_PROTO_UDP=y \ +CONFIG_IP_VS_PROTO_AH_ESP=y \ +CONFIG_IP_VS_PROTO_ESP=y \ +CONFIG_IP_VS_PROTO_AH=y \ +CONFIG_IP_VS_PROTO_SCTP=y \ +CONFIG_IP_VS_TAB_BITS=12 \ +CONFIG_IP_VS_RR \ +CONFIG_IP_VS_WRR \ +CONFIG_IP_VS_LC \ +CONFIG_IP_VS_WLC \ +CONFIG_IP_VS_FO \ +CONFIG_IP_VS_OVF \ +CONFIG_IP_VS_LBLC \ +CONFIG_IP_VS_LBLCR \ +CONFIG_IP_VS_DH \ +CONFIG_IP_VS_SH \ +CONFIG_IP_VS_SED \ +CONFIG_IP_VS_NQ \ +CONFIG_IP_VS_SH_TAB_BITS=8 \ +CONFIG_IP_VS_NFCT=y \ +CONFIG_NETFILTER_XT_MATCH_IPVS + + FILES:=$(foreach mod,$(IPVS_MODULES),$(LINUX_DIR)/net/netfilter/$(mod).ko) + $(call AddDepends/ipt,+kmod-ipt-conntrack,+kmod-nf-conntrack) +endef +$(eval $(call KernelPackage,nf-ipvs)) + +define KernelPackage/nf-ipvs/description + IPVS (IP Virtual Server) implements transport-layer load balancing inside the Linux kernel + so called Layer-4 switching. +endef + +define KernelPackage/nf-ipvs-ftp + SUBMENU:=$(NF_MENU) + TITLE:=Virtual Server FTP protocol support + KCONFIG:=CONFIG_IP_VS_FTP + DEPENDS:=kmod-nf-ipvs +kmod-nf-nat +kmod-nf-conntrack-ftp + FILES:=$(LINUX_DIR)/net/netfilter/ipvs/ip_vs_ftp.ko +endef + +$(eval $(call KernelPackage,nf-ipvs-ftp)) + + +define KernelPackage/nf-ipvs-sip + SUBMENU:=$(NF_MENU) + TITLE:=Virtual Server SIP protocol support + KCONFIG:=CONFIG_IP_VS_PE_SIP + DEPENDS:=kmod-nf-ipvs +kmod-nf-nathelper-extra + FILES:=$(LINUX_DIR)/net/netfilter/ipvs/ip_vs_pe_sip.ko +endef + +$(eval $(call KernelPackage,nf-ipvs-sip)) + define KernelPackage/ipt-nat TITLE:=Basic NAT targets ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing, capabilities
On 28/02/17 12:28, Mauro Mozzarelli wrote: John, I confirm I copy and paste using Thunderbird. My mail server requires authentication. I am afraid no luck with send-email: $ git-send-email you need to install the git email package. Something like sudo apt install git-email Cheers, Kevin ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing, capabilities
John, I confirm I copy and paste using Thunderbird. My mail server requires authentication. I am afraid no luck with send-email: $ git-send-email git-send-email: command not found $ git send-email git: 'send-email' is not a git command. See 'git --help'. $ git --version git version 2.7.4 $ uname -a Linux sirius.ezplanet.org 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux $ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=16.04 DISTRIB_CODENAME=xenial DISTRIB_DESCRIPTION="Ubuntu 16.04.2 LTS" On 28/02/17 11:53, John Crispin wrote: On 28/02/2017 12:52, Mauro Mozzarelli wrote: Then I take the output from git format-patch and I post it to the mailing list. How exactly did you do this ? i assume using copy into your mail client ? try using "git send-email" ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing, capabilities
To obtain a functional Load Balancer, in addition to the kernel modules we require also the "ipvsadm" tool which is used to create and manage the load balancer kernel table. I prepared a separate package that includes other than ipvsadm also the necessary startup and configuration scripts conforming with openwrt/lede standards. The package fits in /package/network/utils. Please could you let me know whether I can post the patch to add ipvsadm here or if I have to follow a different process? Mauro On 28/02/17 11:52, Mauro Mozzarelli wrote: Hello John, I sent the first patch using the output of git show, but there was something wrong and it was suggested to use git format-patch, so I sent the last using the following method: I do a git pull for trunk first, then inside the trunk directory: 1. git checkout -b ipvs 2. I apply my changes 3. git add path to changed file(s) 4. git commit and edit comments 5. git show to show id. and git format-patch -1 Then I take the output from git format-patch and I post it to the mailing list. Please could you let me know what would be the correct procedure? Mauro On 27/02/17 10:30, John Crispin wrote: On 24/02/2017 12:42, Mauro Mozzarelli wrote: IPVS (IP Virtual Server) implements transport-layer load balancing inside the Linux kernel, so called Layer-4 switching. IPVS running on a host acts as a load balancer at the front of a cluster of real servers, it can direct requests for TCP/UDP based services to the real servers, and makes services of the real servers to appear as a virtual service on a single IP address. This patch adds kmod-nf-ipvs kernel modules option to LEDE kernel netfilter Signed-off-by: Mauro MozzarelliHi Mauro, How do you send your patches ? patchwork fails to pick them up properly https://patchwork.ozlabs.org/patch/732113/ John --- package/kernel/linux/modules/netfilter.mk | 89 +++ 1 file changed, 89 insertions(+) diff --git a/package/kernel/linux/modules/netfilter.mk b/package/kernel/linux/modules/netfilter.mk index 6162dbc..9cef8fd 100644 --- a/package/kernel/linux/modules/netfilter.mk +++ b/package/kernel/linux/modules/netfilter.mk @@ -77,6 +77,17 @@ endef $(eval $(call KernelPackage,nf-conntrack)) +define KernelPackage/nf-conntrack-ftp + SUBMENU:=$(NF_MENU) + TITLE:=FTP connection tracking + KCONFIG:=CONFIG_NF_CONNTRACK_FTP + DEPENDS:=kmod-nf-conntrack + FILES:=$(LINUX_DIR)/net/netfilter/nf_conntrack_ftp.ko +endef + +$(eval $(call KernelPackage,nf-conntrack-ftp)) + + define KernelPackage/nf-conntrack6 SUBMENU:=$(NF_MENU) TITLE:=Netfilter IPv6 connection tracking @@ -271,6 +282,84 @@ define KernelPackage/ipt-ipset endef $(eval $(call KernelPackage,ipt-ipset)) +IPVS_MODULES:= \ +ipvs/ip_vs \ +ipvs/ip_vs_lc \ +ipvs/ip_vs_wlc \ +ipvs/ip_vs_rr \ +ipvs/ip_vs_wrr \ +ipvs/ip_vs_lblc \ +ipvs/ip_vs_lblcr \ +ipvs/ip_vs_dh \ +ipvs/ip_vs_sh \ +ipvs/ip_vs_fo \ +ipvs/ip_vs_ovf \ +ipvs/ip_vs_nq \ +ipvs/ip_vs_sed \ +xt_ipvs + +define KernelPackage/nf-ipvs + SUBMENU:=Netfilter Extensions + TITLE:=IP Virtual Server modules + DEPENDS:=@IPV6 +kmod-lib-crc32c +kmod-ipt-conntrack +kmod-nf-conntrack + KCONFIG:= \ +CONFIG_IP_VS \ +CONFIG_IP_VS_IPV6=y \ +CONFIG_IP_VS_DEBUG=n \ +CONFIG_IP_VS_PROTO_TCP=y \ +CONFIG_IP_VS_PROTO_UDP=y \ +CONFIG_IP_VS_PROTO_AH_ESP=y \ +CONFIG_IP_VS_PROTO_ESP=y \ +CONFIG_IP_VS_PROTO_AH=y \ +CONFIG_IP_VS_PROTO_SCTP=y \ +CONFIG_IP_VS_TAB_BITS=12 \ +CONFIG_IP_VS_RR \ +CONFIG_IP_VS_WRR \ +CONFIG_IP_VS_LC \ +CONFIG_IP_VS_WLC \ +CONFIG_IP_VS_FO \ +CONFIG_IP_VS_OVF \ +CONFIG_IP_VS_LBLC \ +CONFIG_IP_VS_LBLCR \ +CONFIG_IP_VS_DH \ +CONFIG_IP_VS_SH \ +CONFIG_IP_VS_SED \ +CONFIG_IP_VS_NQ \ +CONFIG_IP_VS_SH_TAB_BITS=8 \ +CONFIG_IP_VS_NFCT=y \ +CONFIG_NETFILTER_XT_MATCH_IPVS + + FILES:=$(foreach mod,$(IPVS_MODULES),$(LINUX_DIR)/net/netfilter/$(mod).ko) + $(call AddDepends/ipt,+kmod-ipt-conntrack,+kmod-nf-conntrack) +endef +$(eval $(call KernelPackage,nf-ipvs)) + +define KernelPackage/nf-ipvs/description + IPVS (IP Virtual Server) implements transport-layer load balancing inside the Linux kernel + so called Layer-4 switching. +endef + +define KernelPackage/nf-ipvs-ftp + SUBMENU:=$(NF_MENU) + TITLE:=Virtual Server FTP protocol support + KCONFIG:=CONFIG_IP_VS_FTP + DEPENDS:=kmod-nf-ipvs +kmod-nf-nat +kmod-nf-conntrack-ftp + FILES:=$(LINUX_DIR)/net/netfilter/ipvs/ip_vs_ftp.ko +endef + +$(eval $(call KernelPackage,nf-ipvs-ftp)) + + +define KernelPackage/nf-ipvs-sip + SUBMENU:=$(NF_MENU) + TITLE:=Virtual Server SIP protocol support + KCONFIG:=CONFIG_IP_VS_PE_SIP + DEPENDS:=kmod-nf-ipvs +kmod-nf-nathelper-extra + FILES:=$(LINUX_DIR)/net/netfilter/ipvs/ip_vs_pe_sip.ko +endef + +$(eval $(call KernelPackage,nf-ipvs-sip)) + define KernelPackage/ipt-nat
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing, capabilities
On 28/02/2017 12:52, Mauro Mozzarelli wrote: > Then I take the output from git format-patch and I post it to the > mailing list. How exactly did you do this ? i assume using copy into your mail client ? try using "git send-email" ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing, capabilities
Hello John, I sent the first patch using the output of git show, but there was something wrong and it was suggested to use git format-patch, so I sent the last using the following method: I do a git pull for trunk first, then inside the trunk directory: 1. git checkout -b ipvs 2. I apply my changes 3. git add path to changed file(s) 4. git commit and edit comments 5. git show to show id. and git format-patch -1 Then I take the output from git format-patch and I post it to the mailing list. Please could you let me know what would be the correct procedure? Mauro On 27/02/17 10:30, John Crispin wrote: On 24/02/2017 12:42, Mauro Mozzarelli wrote: IPVS (IP Virtual Server) implements transport-layer load balancing inside the Linux kernel, so called Layer-4 switching. IPVS running on a host acts as a load balancer at the front of a cluster of real servers, it can direct requests for TCP/UDP based services to the real servers, and makes services of the real servers to appear as a virtual service on a single IP address. This patch adds kmod-nf-ipvs kernel modules option to LEDE kernel netfilter Signed-off-by: Mauro MozzarelliHi Mauro, How do you send your patches ? patchwork fails to pick them up properly https://patchwork.ozlabs.org/patch/732113/ John --- package/kernel/linux/modules/netfilter.mk | 89 +++ 1 file changed, 89 insertions(+) diff --git a/package/kernel/linux/modules/netfilter.mk b/package/kernel/linux/modules/netfilter.mk index 6162dbc..9cef8fd 100644 --- a/package/kernel/linux/modules/netfilter.mk +++ b/package/kernel/linux/modules/netfilter.mk @@ -77,6 +77,17 @@ endef $(eval $(call KernelPackage,nf-conntrack)) +define KernelPackage/nf-conntrack-ftp + SUBMENU:=$(NF_MENU) + TITLE:=FTP connection tracking + KCONFIG:=CONFIG_NF_CONNTRACK_FTP + DEPENDS:=kmod-nf-conntrack + FILES:=$(LINUX_DIR)/net/netfilter/nf_conntrack_ftp.ko +endef + +$(eval $(call KernelPackage,nf-conntrack-ftp)) + + define KernelPackage/nf-conntrack6 SUBMENU:=$(NF_MENU) TITLE:=Netfilter IPv6 connection tracking @@ -271,6 +282,84 @@ define KernelPackage/ipt-ipset endef $(eval $(call KernelPackage,ipt-ipset)) +IPVS_MODULES:= \ +ipvs/ip_vs \ +ipvs/ip_vs_lc \ +ipvs/ip_vs_wlc \ +ipvs/ip_vs_rr \ +ipvs/ip_vs_wrr \ +ipvs/ip_vs_lblc \ +ipvs/ip_vs_lblcr \ +ipvs/ip_vs_dh \ +ipvs/ip_vs_sh \ +ipvs/ip_vs_fo \ +ipvs/ip_vs_ovf \ +ipvs/ip_vs_nq \ +ipvs/ip_vs_sed \ +xt_ipvs + +define KernelPackage/nf-ipvs + SUBMENU:=Netfilter Extensions + TITLE:=IP Virtual Server modules + DEPENDS:=@IPV6 +kmod-lib-crc32c +kmod-ipt-conntrack +kmod-nf-conntrack + KCONFIG:= \ +CONFIG_IP_VS \ +CONFIG_IP_VS_IPV6=y \ +CONFIG_IP_VS_DEBUG=n \ +CONFIG_IP_VS_PROTO_TCP=y \ +CONFIG_IP_VS_PROTO_UDP=y \ +CONFIG_IP_VS_PROTO_AH_ESP=y \ +CONFIG_IP_VS_PROTO_ESP=y \ +CONFIG_IP_VS_PROTO_AH=y \ +CONFIG_IP_VS_PROTO_SCTP=y \ +CONFIG_IP_VS_TAB_BITS=12 \ +CONFIG_IP_VS_RR \ +CONFIG_IP_VS_WRR \ +CONFIG_IP_VS_LC \ +CONFIG_IP_VS_WLC \ +CONFIG_IP_VS_FO \ +CONFIG_IP_VS_OVF \ +CONFIG_IP_VS_LBLC \ +CONFIG_IP_VS_LBLCR \ +CONFIG_IP_VS_DH \ +CONFIG_IP_VS_SH \ +CONFIG_IP_VS_SED \ +CONFIG_IP_VS_NQ \ +CONFIG_IP_VS_SH_TAB_BITS=8 \ +CONFIG_IP_VS_NFCT=y \ +CONFIG_NETFILTER_XT_MATCH_IPVS + + FILES:=$(foreach mod,$(IPVS_MODULES),$(LINUX_DIR)/net/netfilter/$(mod).ko) + $(call AddDepends/ipt,+kmod-ipt-conntrack,+kmod-nf-conntrack) +endef +$(eval $(call KernelPackage,nf-ipvs)) + +define KernelPackage/nf-ipvs/description + IPVS (IP Virtual Server) implements transport-layer load balancing inside the Linux kernel + so called Layer-4 switching. +endef + +define KernelPackage/nf-ipvs-ftp + SUBMENU:=$(NF_MENU) + TITLE:=Virtual Server FTP protocol support + KCONFIG:=CONFIG_IP_VS_FTP + DEPENDS:=kmod-nf-ipvs +kmod-nf-nat +kmod-nf-conntrack-ftp + FILES:=$(LINUX_DIR)/net/netfilter/ipvs/ip_vs_ftp.ko +endef + +$(eval $(call KernelPackage,nf-ipvs-ftp)) + + +define KernelPackage/nf-ipvs-sip + SUBMENU:=$(NF_MENU) + TITLE:=Virtual Server SIP protocol support + KCONFIG:=CONFIG_IP_VS_PE_SIP + DEPENDS:=kmod-nf-ipvs +kmod-nf-nathelper-extra + FILES:=$(LINUX_DIR)/net/netfilter/ipvs/ip_vs_pe_sip.ko +endef + +$(eval $(call KernelPackage,nf-ipvs-sip)) + define KernelPackage/ipt-nat TITLE:=Basic NAT targets ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing, capabilities
On 24/02/2017 12:42, Mauro Mozzarelli wrote: > IPVS (IP Virtual Server) implements transport-layer load balancing > inside the Linux kernel, so called Layer-4 switching. IPVS running on a > host acts as a load balancer at the front of a cluster of real servers, > it can direct requests for TCP/UDP based services to the real servers, > and makes services of the real servers to appear as a virtual service on > a single IP address. > > This patch adds kmod-nf-ipvs kernel modules option to LEDE kernel netfilter > > Signed-off-by: Mauro MozzarelliHi Mauro, How do you send your patches ? patchwork fails to pick them up properly https://patchwork.ozlabs.org/patch/732113/ John > --- > package/kernel/linux/modules/netfilter.mk | 89 > +++ > 1 file changed, 89 insertions(+) > > diff --git a/package/kernel/linux/modules/netfilter.mk > b/package/kernel/linux/modules/netfilter.mk > index 6162dbc..9cef8fd 100644 > --- a/package/kernel/linux/modules/netfilter.mk > +++ b/package/kernel/linux/modules/netfilter.mk > @@ -77,6 +77,17 @@ endef > $(eval $(call KernelPackage,nf-conntrack)) > > > +define KernelPackage/nf-conntrack-ftp > + SUBMENU:=$(NF_MENU) > + TITLE:=FTP connection tracking > + KCONFIG:=CONFIG_NF_CONNTRACK_FTP > + DEPENDS:=kmod-nf-conntrack > + FILES:=$(LINUX_DIR)/net/netfilter/nf_conntrack_ftp.ko > +endef > + > +$(eval $(call KernelPackage,nf-conntrack-ftp)) > + > + > define KernelPackage/nf-conntrack6 >SUBMENU:=$(NF_MENU) >TITLE:=Netfilter IPv6 connection tracking > @@ -271,6 +282,84 @@ define KernelPackage/ipt-ipset > endef > $(eval $(call KernelPackage,ipt-ipset)) > > +IPVS_MODULES:= \ > +ipvs/ip_vs \ > +ipvs/ip_vs_lc \ > +ipvs/ip_vs_wlc \ > +ipvs/ip_vs_rr \ > +ipvs/ip_vs_wrr \ > +ipvs/ip_vs_lblc \ > +ipvs/ip_vs_lblcr \ > +ipvs/ip_vs_dh \ > +ipvs/ip_vs_sh \ > +ipvs/ip_vs_fo \ > +ipvs/ip_vs_ovf \ > +ipvs/ip_vs_nq \ > +ipvs/ip_vs_sed \ > +xt_ipvs > + > +define KernelPackage/nf-ipvs > + SUBMENU:=Netfilter Extensions > + TITLE:=IP Virtual Server modules > + DEPENDS:=@IPV6 +kmod-lib-crc32c +kmod-ipt-conntrack +kmod-nf-conntrack > + KCONFIG:= \ > +CONFIG_IP_VS \ > +CONFIG_IP_VS_IPV6=y \ > +CONFIG_IP_VS_DEBUG=n \ > +CONFIG_IP_VS_PROTO_TCP=y \ > +CONFIG_IP_VS_PROTO_UDP=y \ > +CONFIG_IP_VS_PROTO_AH_ESP=y \ > +CONFIG_IP_VS_PROTO_ESP=y \ > +CONFIG_IP_VS_PROTO_AH=y \ > +CONFIG_IP_VS_PROTO_SCTP=y \ > +CONFIG_IP_VS_TAB_BITS=12 \ > +CONFIG_IP_VS_RR \ > +CONFIG_IP_VS_WRR \ > +CONFIG_IP_VS_LC \ > +CONFIG_IP_VS_WLC \ > +CONFIG_IP_VS_FO \ > +CONFIG_IP_VS_OVF \ > +CONFIG_IP_VS_LBLC \ > +CONFIG_IP_VS_LBLCR \ > +CONFIG_IP_VS_DH \ > +CONFIG_IP_VS_SH \ > +CONFIG_IP_VS_SED \ > +CONFIG_IP_VS_NQ \ > +CONFIG_IP_VS_SH_TAB_BITS=8 \ > +CONFIG_IP_VS_NFCT=y \ > +CONFIG_NETFILTER_XT_MATCH_IPVS > + > + FILES:=$(foreach > mod,$(IPVS_MODULES),$(LINUX_DIR)/net/netfilter/$(mod).ko) > + $(call AddDepends/ipt,+kmod-ipt-conntrack,+kmod-nf-conntrack) > +endef > +$(eval $(call KernelPackage,nf-ipvs)) > + > +define KernelPackage/nf-ipvs/description > + IPVS (IP Virtual Server) implements transport-layer load balancing > inside the Linux kernel > + so called Layer-4 switching. > +endef > + > +define KernelPackage/nf-ipvs-ftp > + SUBMENU:=$(NF_MENU) > + TITLE:=Virtual Server FTP protocol support > + KCONFIG:=CONFIG_IP_VS_FTP > + DEPENDS:=kmod-nf-ipvs +kmod-nf-nat +kmod-nf-conntrack-ftp > + FILES:=$(LINUX_DIR)/net/netfilter/ipvs/ip_vs_ftp.ko > +endef > + > +$(eval $(call KernelPackage,nf-ipvs-ftp)) > + > + > +define KernelPackage/nf-ipvs-sip > + SUBMENU:=$(NF_MENU) > + TITLE:=Virtual Server SIP protocol support > + KCONFIG:=CONFIG_IP_VS_PE_SIP > + DEPENDS:=kmod-nf-ipvs +kmod-nf-nathelper-extra > + FILES:=$(LINUX_DIR)/net/netfilter/ipvs/ip_vs_pe_sip.ko > +endef > + > +$(eval $(call KernelPackage,nf-ipvs-sip)) > + > > define KernelPackage/ipt-nat >TITLE:=Basic NAT targets ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing, capabilities
Unfortunately this version of the patch creates an installation conflict during the build in case nf-nathelper-extra is selected (which isn't by default), because this package contains also nf_conntrack_sip module. I am posting a new version that puts ip_vs_pe_sip dependency on nf-nathelper-extra. Mauro On 24/02/17 10:43, Mauro Mozzarelli wrote: IPVS (IP Virtual Server) implements transport-layer load balancing inside the Linux kernel, so called Layer-4 switching. IPVS running on a host acts as a load balancer at the front of a cluster of real servers, it can direct requests for TCP/UDP based services to the real servers, and makes services of the real servers to appear as a virtual service on a single IP address. This patch adds kmod-nf-ipvs kernel modules option to LEDE kernel netfilter Signed-off-by: Mauro Mozzarelli--- package/kernel/linux/modules/netfilter.mk | 100 ++ 1 file changed, 100 insertions(+) diff --git a/package/kernel/linux/modules/netfilter.mk b/package/kernel/linux/modules/netfilter.mk index 6162dbc..b712909 100644 --- a/package/kernel/linux/modules/netfilter.mk +++ b/package/kernel/linux/modules/netfilter.mk @@ -77,6 +77,28 @@ endef $(eval $(call KernelPackage,nf-conntrack)) +define KernelPackage/nf-conntrack-ftp + SUBMENU:=$(NF_MENU) + TITLE:=FTP connection tracking + KCONFIG:=CONFIG_NF_CONNTRACK_FTP + DEPENDS:=kmod-nf-conntrack + FILES:=$(LINUX_DIR)/net/netfilter/nf_conntrack_ftp.ko +endef + +$(eval $(call KernelPackage,nf-conntrack-ftp)) + + +define KernelPackage/nf-conntrack-sip + SUBMENU:=$(NF_MENU) + TITLE:=SIP connection tracking + KCONFIG:=CONFIG_NF_CONNTRACK_SIP + DEPENDS:=kmod-nf-conntrack + FILES:=$(LINUX_DIR)/net/netfilter/nf_conntrack_sip.ko +endef + +$(eval $(call KernelPackage,nf-conntrack-sip)) + + define KernelPackage/nf-conntrack6 SUBMENU:=$(NF_MENU) TITLE:=Netfilter IPv6 connection tracking @@ -271,6 +293,84 @@ define KernelPackage/ipt-ipset endef $(eval $(call KernelPackage,ipt-ipset)) +IPVS_MODULES:= \ +ipvs/ip_vs \ +ipvs/ip_vs_lc \ +ipvs/ip_vs_wlc \ +ipvs/ip_vs_rr \ +ipvs/ip_vs_wrr \ +ipvs/ip_vs_lblc \ +ipvs/ip_vs_lblcr \ +ipvs/ip_vs_dh \ +ipvs/ip_vs_sh \ +ipvs/ip_vs_fo \ +ipvs/ip_vs_ovf \ +ipvs/ip_vs_nq \ +ipvs/ip_vs_sed \ +xt_ipvs + +define KernelPackage/nf-ipvs + SUBMENU:=Netfilter Extensions + TITLE:=IP Virtual Server modules + DEPENDS:=@IPV6 +kmod-lib-crc32c +kmod-ipt-conntrack +kmod-nf-conntrack + KCONFIG:= \ +CONFIG_IP_VS \ +CONFIG_IP_VS_IPV6=y \ +CONFIG_IP_VS_DEBUG=n \ +CONFIG_IP_VS_PROTO_TCP=y \ +CONFIG_IP_VS_PROTO_UDP=y \ +CONFIG_IP_VS_PROTO_AH_ESP=y \ +CONFIG_IP_VS_PROTO_ESP=y \ +CONFIG_IP_VS_PROTO_AH=y \ +CONFIG_IP_VS_PROTO_SCTP=y \ +CONFIG_IP_VS_TAB_BITS=12 \ +CONFIG_IP_VS_RR \ +CONFIG_IP_VS_WRR \ +CONFIG_IP_VS_LC \ +CONFIG_IP_VS_WLC \ +CONFIG_IP_VS_FO \ +CONFIG_IP_VS_OVF \ +CONFIG_IP_VS_LBLC \ +CONFIG_IP_VS_LBLCR \ +CONFIG_IP_VS_DH \ +CONFIG_IP_VS_SH \ +CONFIG_IP_VS_SED \ +CONFIG_IP_VS_NQ \ +CONFIG_IP_VS_SH_TAB_BITS=8 \ +CONFIG_IP_VS_NFCT=y \ +CONFIG_NETFILTER_XT_MATCH_IPVS + + FILES:=$(foreach mod,$(IPVS_MODULES),$(LINUX_DIR)/net/netfilter/$(mod).ko) + $(call AddDepends/ipt,+kmod-ipt-conntrack,+kmod-nf-conntrack) +endef +$(eval $(call KernelPackage,nf-ipvs)) + +define KernelPackage/nf-ipvs/description + IPVS (IP Virtual Server) implements transport-layer load balancing inside the Linux kernel + so called Layer-4 switching. +endef + +define KernelPackage/nf-ipvs-ftp + SUBMENU:=$(NF_MENU) + TITLE:=Virtual Server FTP protocol support + KCONFIG:=CONFIG_IP_VS_FTP + DEPENDS:=kmod-nf-ipvs +kmod-nf-nat +kmod-nf-conntrack-ftp + FILES:=$(LINUX_DIR)/net/netfilter/ipvs/ip_vs_ftp.ko +endef + +$(eval $(call KernelPackage,nf-ipvs-ftp)) + + +define KernelPackage/nf-ipvs-sip + SUBMENU:=$(NF_MENU) + TITLE:=Virtual Server SIP protocol support + KCONFIG:=CONFIG_IP_VS_PE_SIP + DEPENDS:=kmod-nf-ipvs +kmod-nf-conntrack-sip + FILES:=$(LINUX_DIR)/net/netfilter/ipvs/ip_vs_pe_sip.ko +endef + +$(eval $(call KernelPackage,nf-ipvs-sip)) + define KernelPackage/ipt-nat TITLE:=Basic NAT targets ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing capabilities
On 20 February 2017 at 10:47, Jonas Gorskiwrote: > On 19 February 2017 at 13:01, Mauro Mozzarelli wrote: >> Author: Mauro Mozzarelli >> Date: Sun Feb 19 11:33:23 2017 + >> >> IPVS (IP Virtual Server) implements transport-layer load balancing >> inside the Linux kernel, so called Layer-4 switching. IPVS running on a host >> acts as a load balancer at the front of a cluster of real servers, it can >> direct requests for TCP/UDP based services to the real servers, and makes >> services of the real servers to appear as a virtual service on a single IP >> address. >> >> This patch adds kmod-nf-ipvs kernel modules option to LEDE kernel >> netfilter >> >> Signed-off-by: Mauro Mozzarelli >> >> diff --git a/package/kernel/linux/modules/netfilter.mk >> b/package/kernel/linux/modules/netfilter.mk >> index 6162dbc..7c51d9f 100644 >> --- a/package/kernel/linux/modules/netfilter.mk >> +++ b/package/kernel/linux/modules/netfilter.mk >> @@ -271,6 +271,117 @@ define KernelPackage/ipt-ipset >> endef >> $(eval $(call KernelPackage,ipt-ipset)) >> >> +IPVS_K3_MODULES:= \ >> +ip_vs \ >> +ip_vs_lc \ >> +ip_vs_wlc \ >> +ip_vs_rr \ >> +ip_vs_wrr \ >> +ip_vs_lblc \ >> +ip_vs_lblcr \ >> +ip_vs_dh \ >> +ip_vs_sh \ >> +ip_vs_fo \ >> +ip_vs_nq \ >> +ip_vs_sed \ >> +ip_vs_ftp > > (snip) > >> +IPVS_K4_MODULES:= \ >> +ip_vs \ >> +ip_vs_lc \ >> +ip_vs_wlc \ >> +ip_vs_rr \ >> +ip_vs_wrr \ >> +ip_vs_lblc \ >> +ip_vs_lblcr \ >> +ip_vs_dh \ >> +ip_vs_sh \ >> +ip_vs_fo \ >> +ip_vs_nq \ >> +ip_vs_sed > > These seem mostly the same, the only difference is ip_vs_ftp in 3.18. > You can annotate the FILES with kernel versions, e.g. > ip_vs_ftp.ko@lt4.0" would mean "copy this file only if kernel version > is less than 4.0". That way you should be able to just have one > KernelPackage definition. Actually looking at the linux sources, ip_vs_ftp is still present in 4.10, so I don't see why you need to do the distinction at all. Does it not build? Regards Jonas ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing capabilities
On 2017-02-20 20:08, Mauro Mozzarelli wrote: > Hello John, > > Thank you for reviewing the patch. I extracted it with "git show" which > added the tabs, but I can always edit the patch file manually and remove > them if it helps. > > Please could you clarify what is the problem with line wrapping? It is > there for better readability, would you like everything to be in one line? > > Also I am not sure I understand your reference to "patchwork mangling". > > To create the patch file I do the following (to a freshly cloned LEDE > trunk repository): > > 1. git checkout -b myproject > 2. Apply changes > 3. git add path to changed files > 4. git commit and edit comments (I add my comments without tabs) > 5. git show to extract patch file (git adds the tabs here) > > Please could you let me know if there is a best practice to create patch > files? Please use git send-email to send them directly. If you really need to generate them manually, use git format-patch. - Felix ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing capabilities
Hello John, Thank you for reviewing the patch. I extracted it with "git show" which added the tabs, but I can always edit the patch file manually and remove them if it helps. Please could you clarify what is the problem with line wrapping? It is there for better readability, would you like everything to be in one line? Also I am not sure I understand your reference to "patchwork mangling". To create the patch file I do the following (to a freshly cloned LEDE trunk repository): 1. git checkout -b myproject 2. Apply changes 3. git add path to changed files 4. git commit and edit comments (I add my comments without tabs) 5. git show to extract patch file (git adds the tabs here) Please could you let me know if there is a best practice to create patch files? Best regards, Mauro On 20/02/17 08:31, John Crispin wrote: Hi, comments inline On 19/02/2017 13:01, Mauro Mozzarelli wrote: Author: Mauro MozzarelliDate: Sun Feb 19 11:33:23 2017 + IPVS (IP Virtual Server) implements transport-layer load balancing ^ stray tab inside the Linux kernel, so called Layer-4 switching. IPVS running on a host acts as a load balancer at the front of a cluster of real servers, it can direct requests for TCP/UDP based services to the real servers, and makes services of the real servers to appear as a virtual service on a single IP address. This patch adds kmod-nf-ipvs kernel modules option to LEDE kernel ^ stray tab netfilter Signed-off-by: Mauro Mozzarelli ^ stray tab and obfuscated mail addr diff --git a/package/kernel/linux/modules/netfilter.mk b/package/kernel/linux/modules/netfilter.mk index 6162dbc..7c51d9f 100644 --- a/package/kernel/linux/modules/netfilter.mk +++ b/package/kernel/linux/modules/netfilter.mk @@ -271,6 +271,117 @@ define KernelPackage/ipt-ipset endef $(eval $(call KernelPackage,ipt-ipset)) +IPVS_K3_MODULES:= \ +ip_vs \ +ip_vs_lc \ +ip_vs_wlc \ +ip_vs_rr \ +ip_vs_wrr \ +ip_vs_lblc \ +ip_vs_lblcr \ +ip_vs_dh \ +ip_vs_sh \ +ip_vs_fo \ +ip_vs_nq \ +ip_vs_sed \ +ip_vs_ftp + +define KernelPackage/nf-ipvs + SUBMENU:=Netfilter Extensions + TITLE:=IP Virtual Server modules Kernel 3 + DEPENDS:=+kmod-lib-crc32c @(LINUX_3_18) + KCONFIG:= \ +CONFIG_IP_VS \ +CONFIG_IP_VS_IPV6=y \ +CONFIG_IP_VS_DEBUG=n \ +CONFIG_IP_VS_PROTO_TCP=y \ +CONFIG_IP_VS_PROTO_UDP=y \ +CONFIG_IP_VS_PROTO_AH_ESP=y \ +CONFIG_IP_VS_PROTO_ESP=y \ +CONFIG_IP_VS_PROTO_AH=y \ +CONFIG_IP_VS_PROTO_SCTP=y \ +CONFIG_IP_VS_TAB_BITS=12 \ +CONFIG_IP_VS_RR \ +CONFIG_IP_VS_WRR \ +CONFIG_IP_VS_LC \ +CONFIG_IP_VS_WLC \ +CONFIG_IP_VS_FO \ +CONFIG_IP_VS_OVF \ +CONFIG_IP_VS_LBLC \ +CONFIG_IP_VS_LBLCR \ +CONFIG_IP_VS_DH \ +CONFIG_IP_VS_SH \ +CONFIG_IP_VS_SED \ +CONFIG_IP_VS_NQ \ +CONFIG_IP_VS_SH_TAB_BITS=8 \ +CONFIG_IP_VS_NFCT=n \ +CONFIG_IP_VS_FTP=m \ +CONFIG_NETFILTER_XT_MATCH_IPVS=n + + FILES:=$(foreach mod,$(IPVS_K3_MODULES),$(LINUX_DIR)/net/netfilter/ipvs/$(mod).ko) ^ line wrapping, there are various more of these below. additionally you sent this in some obscure way leading to patchwork mangling it -> https://patchwork.ozlabs.org/patch/729538/ please fix and resend a properly formatted patch so that we can review it. John + $(call AddDepends/ipt,+kmod-ipt-conntrack) +endef +$(eval $(call KernelPackage,nf-ipvs)) + +define KernelPackage/nf-ipvs/description + IPVS (IP Virtual Server) implements transport-layer load balancing inside the Linux kernel + so called Layer-4 switching. +endef + +IPVS_K4_MODULES:= \ +ip_vs \ +ip_vs_lc \ +ip_vs_wlc \ +ip_vs_rr \ +ip_vs_wrr \ +ip_vs_lblc \ +ip_vs_lblcr \ +ip_vs_dh \ +ip_vs_sh \ +ip_vs_fo \ +ip_vs_nq \ +ip_vs_sed + +define KernelPackage/nf-ipvs + SUBMENU:=Netfilter Extensions + TITLE:=IP Virtual Server modules + DEPENDS:=+kmod-lib-crc32c @!(LINUX_3_18) + KCONFIG:= \ +CONFIG_IP_VS \ +CONFIG_IP_VS_IPV6=y \ +CONFIG_IP_VS_DEBUG=n \ +CONFIG_IP_VS_PROTO_TCP=y \ +CONFIG_IP_VS_PROTO_UDP=y \ +CONFIG_IP_VS_PROTO_AH_ESP=y \ +CONFIG_IP_VS_PROTO_ESP=y \ +CONFIG_IP_VS_PROTO_AH=y \ +CONFIG_IP_VS_PROTO_SCTP=y \ +CONFIG_IP_VS_TAB_BITS=12 \ +CONFIG_IP_VS_RR \ +CONFIG_IP_VS_WRR \ +CONFIG_IP_VS_LC \ +CONFIG_IP_VS_WLC \ +CONFIG_IP_VS_FO \ +CONFIG_IP_VS_OVF \ +CONFIG_IP_VS_LBLC \ +CONFIG_IP_VS_LBLCR \ +CONFIG_IP_VS_DH \ +CONFIG_IP_VS_SH \ +CONFIG_IP_VS_SED \ +CONFIG_IP_VS_NQ \ +CONFIG_IP_VS_SH_TAB_BITS=8 \ +CONFIG_IP_VS_NFCT=n \ +CONFIG_NETFILTER_XT_MATCH_IPVS=n + + FILES:=$(foreach mod,$(IPVS_K4_MODULES),$(LINUX_DIR)/net/netfilter/ipvs/$(mod).ko) + $(call AddDepends/ipt,+kmod-ipt-conntrack) +endef +$(eval $(call KernelPackage,nf-ipvs)) + +define KernelPackage/nf-ipvs/description + IPVS (IP Virtual Server) implements transport-layer load
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing capabilities
On 19 February 2017 at 13:01, Mauro Mozzarelliwrote: > Author: Mauro Mozzarelli > Date: Sun Feb 19 11:33:23 2017 + > > IPVS (IP Virtual Server) implements transport-layer load balancing > inside the Linux kernel, so called Layer-4 switching. IPVS running on a host > acts as a load balancer at the front of a cluster of real servers, it can > direct requests for TCP/UDP based services to the real servers, and makes > services of the real servers to appear as a virtual service on a single IP > address. > > This patch adds kmod-nf-ipvs kernel modules option to LEDE kernel > netfilter > > Signed-off-by: Mauro Mozzarelli > > diff --git a/package/kernel/linux/modules/netfilter.mk > b/package/kernel/linux/modules/netfilter.mk > index 6162dbc..7c51d9f 100644 > --- a/package/kernel/linux/modules/netfilter.mk > +++ b/package/kernel/linux/modules/netfilter.mk > @@ -271,6 +271,117 @@ define KernelPackage/ipt-ipset > endef > $(eval $(call KernelPackage,ipt-ipset)) > > +IPVS_K3_MODULES:= \ > +ip_vs \ > +ip_vs_lc \ > +ip_vs_wlc \ > +ip_vs_rr \ > +ip_vs_wrr \ > +ip_vs_lblc \ > +ip_vs_lblcr \ > +ip_vs_dh \ > +ip_vs_sh \ > +ip_vs_fo \ > +ip_vs_nq \ > +ip_vs_sed \ > +ip_vs_ftp (snip) > +IPVS_K4_MODULES:= \ > +ip_vs \ > +ip_vs_lc \ > +ip_vs_wlc \ > +ip_vs_rr \ > +ip_vs_wrr \ > +ip_vs_lblc \ > +ip_vs_lblcr \ > +ip_vs_dh \ > +ip_vs_sh \ > +ip_vs_fo \ > +ip_vs_nq \ > +ip_vs_sed These seem mostly the same, the only difference is ip_vs_ftp in 3.18. You can annotate the FILES with kernel versions, e.g. ip_vs_ftp.ko@lt4.0" would mean "copy this file only if kernel version is less than 4.0". That way you should be able to just have one KernelPackage definition. Regards Jonas ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH] Add ip_vs kernel netfilter modules to enable load balancing capabilities
Hi, comments inline On 19/02/2017 13:01, Mauro Mozzarelli wrote: > Author: Mauro Mozzarelli> Date: Sun Feb 19 11:33:23 2017 + > > IPVS (IP Virtual Server) implements transport-layer load balancing ^ stray tab > inside the Linux kernel, so called Layer-4 switching. IPVS running on a > host acts as a load balancer at the front of a cluster of real servers, > it can direct requests for TCP/UDP based services to the real servers, > and makes services of the real servers to appear as a virtual service on > a single IP address. > > This patch adds kmod-nf-ipvs kernel modules option to LEDE kernel ^ stray tab > netfilter > > Signed-off-by: Mauro Mozzarelli > ^ stray tab and obfuscated mail addr > diff --git a/package/kernel/linux/modules/netfilter.mk > b/package/kernel/linux/modules/netfilter.mk > index 6162dbc..7c51d9f 100644 > --- a/package/kernel/linux/modules/netfilter.mk > +++ b/package/kernel/linux/modules/netfilter.mk > @@ -271,6 +271,117 @@ define KernelPackage/ipt-ipset > endef > $(eval $(call KernelPackage,ipt-ipset)) > > +IPVS_K3_MODULES:= \ > +ip_vs \ > +ip_vs_lc \ > +ip_vs_wlc \ > +ip_vs_rr \ > +ip_vs_wrr \ > +ip_vs_lblc \ > +ip_vs_lblcr \ > +ip_vs_dh \ > +ip_vs_sh \ > +ip_vs_fo \ > +ip_vs_nq \ > +ip_vs_sed \ > +ip_vs_ftp > + > +define KernelPackage/nf-ipvs > + SUBMENU:=Netfilter Extensions > + TITLE:=IP Virtual Server modules Kernel 3 > + DEPENDS:=+kmod-lib-crc32c @(LINUX_3_18) > + KCONFIG:= \ > +CONFIG_IP_VS \ > +CONFIG_IP_VS_IPV6=y \ > +CONFIG_IP_VS_DEBUG=n \ > +CONFIG_IP_VS_PROTO_TCP=y \ > +CONFIG_IP_VS_PROTO_UDP=y \ > +CONFIG_IP_VS_PROTO_AH_ESP=y \ > +CONFIG_IP_VS_PROTO_ESP=y \ > +CONFIG_IP_VS_PROTO_AH=y \ > +CONFIG_IP_VS_PROTO_SCTP=y \ > +CONFIG_IP_VS_TAB_BITS=12 \ > +CONFIG_IP_VS_RR \ > +CONFIG_IP_VS_WRR \ > +CONFIG_IP_VS_LC \ > +CONFIG_IP_VS_WLC \ > +CONFIG_IP_VS_FO \ > +CONFIG_IP_VS_OVF \ > +CONFIG_IP_VS_LBLC \ > +CONFIG_IP_VS_LBLCR \ > +CONFIG_IP_VS_DH \ > +CONFIG_IP_VS_SH \ > +CONFIG_IP_VS_SED \ > +CONFIG_IP_VS_NQ \ > +CONFIG_IP_VS_SH_TAB_BITS=8 \ > +CONFIG_IP_VS_NFCT=n \ > +CONFIG_IP_VS_FTP=m \ > +CONFIG_NETFILTER_XT_MATCH_IPVS=n > + > + FILES:=$(foreach > mod,$(IPVS_K3_MODULES),$(LINUX_DIR)/net/netfilter/ipvs/$(mod).ko) ^ line wrapping, there are various more of these below. additionally you sent this in some obscure way leading to patchwork mangling it -> https://patchwork.ozlabs.org/patch/729538/ please fix and resend a properly formatted patch so that we can review it. John > + $(call AddDepends/ipt,+kmod-ipt-conntrack) > +endef > +$(eval $(call KernelPackage,nf-ipvs)) > + > +define KernelPackage/nf-ipvs/description > + IPVS (IP Virtual Server) implements transport-layer load balancing > inside the Linux kernel > + so called Layer-4 switching. > +endef > + > +IPVS_K4_MODULES:= \ > +ip_vs \ > +ip_vs_lc \ > +ip_vs_wlc \ > +ip_vs_rr \ > +ip_vs_wrr \ > +ip_vs_lblc \ > +ip_vs_lblcr \ > +ip_vs_dh \ > +ip_vs_sh \ > +ip_vs_fo \ > +ip_vs_nq \ > +ip_vs_sed > + > +define KernelPackage/nf-ipvs > + SUBMENU:=Netfilter Extensions > + TITLE:=IP Virtual Server modules > + DEPENDS:=+kmod-lib-crc32c @!(LINUX_3_18) > + KCONFIG:= \ > +CONFIG_IP_VS \ > +CONFIG_IP_VS_IPV6=y \ > +CONFIG_IP_VS_DEBUG=n \ > +CONFIG_IP_VS_PROTO_TCP=y \ > +CONFIG_IP_VS_PROTO_UDP=y \ > +CONFIG_IP_VS_PROTO_AH_ESP=y \ > +CONFIG_IP_VS_PROTO_ESP=y \ > +CONFIG_IP_VS_PROTO_AH=y \ > +CONFIG_IP_VS_PROTO_SCTP=y \ > +CONFIG_IP_VS_TAB_BITS=12 \ > +CONFIG_IP_VS_RR \ > +CONFIG_IP_VS_WRR \ > +CONFIG_IP_VS_LC \ > +CONFIG_IP_VS_WLC \ > +CONFIG_IP_VS_FO \ > +CONFIG_IP_VS_OVF \ > +CONFIG_IP_VS_LBLC \ > +CONFIG_IP_VS_LBLCR \ > +CONFIG_IP_VS_DH \ > +CONFIG_IP_VS_SH \ > +CONFIG_IP_VS_SED \ > +CONFIG_IP_VS_NQ \ > +CONFIG_IP_VS_SH_TAB_BITS=8 \ > +CONFIG_IP_VS_NFCT=n \ > +CONFIG_NETFILTER_XT_MATCH_IPVS=n > + > + FILES:=$(foreach > mod,$(IPVS_K4_MODULES),$(LINUX_DIR)/net/netfilter/ipvs/$(mod).ko) > + $(call AddDepends/ipt,+kmod-ipt-conntrack) > +endef > +$(eval $(call KernelPackage,nf-ipvs)) > + > +define KernelPackage/nf-ipvs/description > + IPVS (IP Virtual Server) implements transport-layer load balancing > inside the Linux kernel > + so called Layer-4 switching. > +endef > > define KernelPackage/ipt-nat >TITLE:=Basic NAT targets > > > ___ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev