Re: PR's now required for the master and devel branches
And after I said this is a good idea, I just accidentally merged my changes to VR3 to upstream/devel instead of origin/devel. Grrr. No harm done, I think, because these changes were the ones that start to add asciidoc rendering, and they work on my computer at least. They don't change any other functionality that someone would be using. But I had better make sure I know how to avoid this in the future. I've been working with Git Extensions, and somewhere I didn't notice that it had changed my checkout branch from origin to upstream. On Thursday, August 20, 2020 at 7:05:55 PM UTC-4, Edward K. Ream wrote: > > This is an experimental restriction. It can easily be removed. > > I think requiring PR's for devel and master makes sense. They alert > everyone of proposed changes before they take effect. The PR's themselves > are a permanent record of changes. > > Let me know if you have any considerations about this new policy. > > Edward > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/88280e38-464e-4c6a-8314-5c5fee4c8272o%40googlegroups.com.
Re: PR's now required for the master and devel branches
On Thu, Aug 20, 2020 at 5:05 PM Edward K. Ream wrote: > This is an experimental restriction. It can easily be removed. > > I think requiring PR's for devel and master makes sense. They alert > everyone of proposed changes before they take effect. The PR's themselves > are a permanent record of changes. > > Let me know if you have any considerations about this new policy. > > I for one like it. I've messed up too much with my own private git, so pull requests to make any mergeable changes sounds quite good. I've been quiet but definitely following progress; at some point I'll start using Leo again, but this whole leointeg thing seems very nice. Mike -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAN%2B%2B4hF_Sox44-jDKvJGqmiHPkS-ZKLRu33kT--cr9EXN8ej%3DQ%40mail.gmail.com.
PR's now required for the master and devel branches
This is an experimental restriction. It can easily be removed. I think requiring PR's for devel and master makes sense. They alert everyone of proposed changes before they take effect. The PR's themselves are a permanent record of changes. Let me know if you have any considerations about this new policy. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/8f10c467-c34f-4e4e-b935-6e6630fe5a7co%40googlegroups.com.
