Re: @string initial_split_orientation = horizontal no effect

[Edward K. Ream]

On Sat, Apr 23, 2016 at 5:18 PM, SegundoBob  wrote:

> I hope you intend to quickly make* @string initial_split_orientation =
> horizontal* work again.
>

​Yes.  Please have just a tad bit of patience.  This is a major project.

The obvious workaround is to use a previous rev.

EKR

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

[SegundoBob]

On Saturday, April 23, 2016 at 4:22:59 PM UTC-7, Terry Brown wrote:
>
>
> A per file workaround. 
>
> (1) Alt-X free-layout-context-menu 
> (2) select the Save layout option, and save your layout as 'Default' or 
> whatever. 
>
>
Thanks.  This helps, but @string initial_split_orientation = horizontal 
would be better for me.

So far as I have been able to determine, the layout is saved in the 
Leo-Editor database.  Unfortunately this database is difficult for a person 
to navigate.  I mistrust and prefer to avoid everything that an application 
hides from me.  Hence, despite the clutter of the @settings node and @data 
free-layout-layout node, I prefer "Embed layout" to "Save layout". 

Thanks again.

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

['Terry Brown' via leo-editor]

On Sat, 23 Apr 2016 15:18:03 -0700 (PDT)
SegundoBob  wrote:

> I hope you intend to quickly make* @string initial_split_orientation
> = horizontal* work again.  This has been my default for several years
> and I'm very tired of hitting Alt-W, s every time I open a Leo-Editor
> file.

A per file workaround.

(1) Alt-X free-layout-context-menu
(2) select the Save layout option, and save your layout as 'Default' or
whatever.

after that, the layout for that file should remain unchanged on
subsequent loadings.  Set it up the way you want it before doing the
above, of course.

Cheers -Terry

> I used git bisect to find the commit that broke it:
> 
> $ git bisect bad
> 3ead1ebb6544ed9b845834f727470e7a74453698 is the first bad commit
> commit 3ead1ebb6544ed9b845834f727470e7a74453698
> Author: Edward K. Ream 
> Date:   Sat Apr 16 11:48:58 2016 -0500
> 
> Added comment that changing the main splitter's name could break
> saved layouts
> 
> :04 04 030e3ba07eb6d9d35b4c04c2f56cbbefa5c1da89 
> f8ed72f1c70b155a7b7e76b702480746c76b83bf M leo
> 2016-04-23 15:05:37 /pri/git/leo-editor

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

[SegundoBob]

I hope you intend to quickly make* @string initial_split_orientation = 
horizontal* work again.  This has been my default for several years and I'm 
very tired of hitting Alt-W, s every time I open a Leo-Editor file.

I used git bisect to find the commit that broke it:

$ git bisect bad
3ead1ebb6544ed9b845834f727470e7a74453698 is the first bad commit
commit 3ead1ebb6544ed9b845834f727470e7a74453698
Author: Edward K. Ream 
Date:   Sat Apr 16 11:48:58 2016 -0500


Added comment that changing the main splitter's name could break saved 
layouts


:04 04 030e3ba07eb6d9d35b4c04c2f56cbbefa5c1da89 
f8ed72f1c70b155a7b7e76b702480746c76b83bf M leo
2016-04-23 15:05:37 /pri/git/leo-editor



-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

[Edward K. Ream]

On Fri, Apr 22, 2016 at 10:36 AM, 'Terry Brown' via leo-editor <
leo-editor@googlegroups.com> wrote:

>
> > When does that happen? I doesn't happen on save, or when using the
> > Easter-egg interface.
>
> Tch, sorry, will have to retract that, didn't do it now in a simple
> test.
>

​No problem.  At the risk of breaking code that wasn't broken, ref 998c2af
contains the new code in free_layout_load.  Let me know if this causes any
problems.

EKR

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

['Terry Brown' via leo-editor]

On Fri, 22 Apr 2016 08:23:56 -0700 (PDT)
"Edward K. Ream"  wrote:

> 
> On Tuesday, April 19, 2016 at 9:23:20 AM UTC-5, Terry Brown wrote:
> 
> > there's a bug in c.db, when you create and save a new file, c.db in
> > that 
> file gives a key error 
> 
> When does that happen? I doesn't happen on save, or when using the 
> Easter-egg interface. 

Tch, sorry, will have to retract that, didn't do it now in a simple
test.

Cheers -Terry

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

[Edward K. Ream]

On Friday, April 22, 2016 at 10:23:57 AM UTC-5, Edward K. Ream wrote:
>
>
> On Tuesday, April 19, 2016 at 9:23:20 AM UTC-5, Terry Brown wrote:
>
> > there's a bug in c.db, when you create and save a new file, c.db in that 
> file gives a key error 
>
> When does that happen? I doesn't happen on save, or when using the 
> Easter-egg interface. 
>

Attempting to answer my own question, I did a cff on ".db".

The only code that didn't use db.get (and thus could raise a KeyError) was 
this, in  free_layout_load:

layout = g.app.db['ns_layouts'][name]

Probably should be this instead:

layouts = g.app.db.get('ns_layouts', {})
layout = layouts.get(name)
if layout:
c.free_layout.get_top_splitter().load_layout(layout)

What do you think, Terry?

EKR

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

[Edward K. Ream]

On Tuesday, April 19, 2016 at 9:23:20 AM UTC-5, Terry Brown wrote:

> there's a bug in c.db, when you create and save a new file, c.db in that 
file gives a key error 

When does that happen? I doesn't happen on save, or when using the 
Easter-egg interface. 

EKR

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

[lewis]

I have a note of the split setting not working back when I was running an 
older build:


*Leo 5.1-final, build 20150706110823, Mon Jul  6 11:08:23 CDT 2015Git repo 
info: branch = master, commit = 2ce861dd01c9Python 3.4.3, PyQt version 
4.8.7*

At that time the split setting still worked fine if I switched from py3.4.3 
to python 2.7.10 

But it only recently broke for me if using python 2.7.11

Regards
Lewis 

On Wednesday, 20 April 2016 00:23:20 UTC+10, Terry Brown wrote:
>
>
> It might be older than you think.  [snip]
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

['Terry Brown' via leo-editor]

On Tue, 19 Apr 2016 13:00:55 -0500
"'Terry Brown' via leo-editor"  wrote:

> New files, in
> particular new never saved files, are a sort of edge case
> (surprisingly, I guess we don't create new .leo files too much).  But
> all it needs is c.db to behave like a defaultdict and create an empty
> entry for paths that didn't exist at app. level start up.

Although thinking about it, there's no path for a never saved file, so
maybe in that case c.db should put something like "Please save the
outline and try again" in the log.

Cheers -Terry

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

['Terry Brown' via leo-editor]

On Tue, 19 Apr 2016 11:16:33 -0500
"Edward K. Ream"  wrote:

> On Tue, Apr 19, 2016 at 9:23 AM, 'Terry Brown' via leo-editor <
> leo-editor@googlegroups.com> wrote:
[snip]
> As soon as you save a layout using
> > ​ ​
> > free_layout that becomes the persistent layout for that outline
> > (based ​ ​
> > on the path, as with other things in c.db).
> 
> What commands save this data?

free-layout-context-menu :-/  That is an Alt-x command, but not the
answer you were looking for.  The Save item on that menu saves layouts.

> > So if there is a saved
> > ​ ​
> > layout, which would be the recommended way of setting initial
> > ​ ​
> > appearance, initial_split_orientation should be ignored.
> > c.db.get('_ns_layout') will tell you if there is a saved layout.
> 
> ​Big sigh. The startup code, including settings, is pretty
> mind-boggling.
> 
> Maybe we should just retire @string initial_split_orientation??? But
> that seems a bit extreme for those who never use layouts.

I don't think it's too much of a job, assuming
initial_split_orientation is only applied in one place, it can just be
ignored there if c.db.get('_ns_layout') is not None, or whatever the
free_layout equivalent is can be applied.  

c.free_layout.get_top_splitter().rotate()

might be sufficient.

> a) there's a bug in c.db, when you create and save a new file, c.db
> > in that file gives a key error
> 
> ​Is it reasonable simply to catch that error and ignore it?​

This is a separate issue of course, purely c.db related.  Trouble with
ignoring it is that c.db functionality should work without having to
close and reload the file, or maybe even save the file.  New files, in
particular new never saved files, are a sort of edge case
(surprisingly, I guess we don't create new .leo files too much).  But
all it needs is c.db to behave like a defaultdict and create an empty
entry for paths that didn't exist at app. level start up.
 
> b) when your new file's called ~/r/test.leo (~/r is a RAM disk I use
> > for temp things) it remembers the saved layout name from a
> > previous ~/r/test.leo, but ~/r/notthattest.leo worked as expected,
> > i.e. c.db.get('_ns_layout') == None
> 
> ​I don't understand.  Yes, the two "test" files aren't the same, but
> how is the cache to know that?

It can't, I just thought it was funny, particularly given the
volatility of a RAM disk.  I'm trying to check that free_layout doesn't
do something clever like creating a "Default" saved layout for a new
file (it doesn't), but my first attempt told me the brand new file's
saved layout has somehow been set to "Bookmarks".  I don't think
there's any issue to address here though.

Cheers -Terry

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

[Edward K. Ream]

On Tue, Apr 19, 2016 at 9:23 AM, 'Terry Brown' via leo-editor <
leo-editor@googlegroups.com> wrote:

​[
> ​
> @string initial_split_orientation = horizontal bug] ​
> might be older than you think.


​Thanks for these investigations.  Caching is great, except when it causes
no end of troubles :-)

I feel like Alice in Wonderland, running as hard as I can to stay in one
place.  Hehe.  Ah well, there is no great need to release 5.3-b1 this week.
Much more important to fix everything.

As soon as you save a layout using
> ​ ​
> free_layout that becomes the persistent layout for that outline (based
> ​ ​
> on the path, as with other things in c.db).


What commands save this data?
​


> So if there is a saved
> ​ ​
> layout, which would be the recommended way of setting initial
> ​ ​
> appearance, initial_split_orientation should be ignored.
> c.db.get('_ns_layout') will tell you if there is a saved layout.
>

​Big sigh. The startup code, including settings, is pretty mind-boggling.

Maybe we should just retire @string initial_split_orientation??? But that
seems a bit extreme for those who never use layouts.

a) there's a bug in c.db, when you create and save a new file, c.db
> in that file gives a key error
>

​Is it reasonable simply to catch that error and ignore it?​


b) when your new file's called ~/r/test.leo (~/r is a RAM disk I use
> for temp things) it remembers the saved layout name from a previous
> ~/r/test.leo, but ~/r/notthattest.leo worked as expected, i.e.
> c.db.get('_ns_layout') == None
>

​I don't understand.  Yes, the two "test" files aren't the same, but how is
the cache to know that?

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

['Terry Brown' via leo-editor]

On Tue, 19 Apr 2016 05:17:21 -0500
"Edward K. Ream"  wrote:

> On Tue, Apr 19, 2016 at 12:40 AM,  wrote:
> 
> I set "@string initial_split_orientation = horizontal"  in
> leoSettings.leo
> > but no
> > ​ effect​
> > ​.
> > ​..​Is that a bug?
> >
> 
> ​It looks that way.  Probably a side effect of recent work.​

It might be older than you think.  As soon as you save a layout using
free_layout that becomes the persistent layout for that outline (based
on the path, as with other things in c.db).  So if there is a saved
layout, which would be the recommended way of setting initial
appearance, initial_split_orientation should be ignored.
c.db.get('_ns_layout') will tell you if there is a saved layout.

Heh - which leads to various other things:

 a) there's a bug in c.db, when you create and save a new file, c.db
in that file gives a key error

 b) when your new file's called ~/r/test.leo (~/r is a RAM disk I use
for temp things) it remembers the saved layout name from a previous
~/r/test.leo, but ~/r/notthattest.leo worked as expected, i.e.
c.db.get('_ns_layout') == None

Cheers -Terry

> ​I'll fix it immediately.
> 
> ​Edward
> 

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: @string initial_split_orientation = horizontal no effect

[Edward K. Ream]

On Tue, Apr 19, 2016 at 12:40 AM,  wrote:

I set "@string initial_split_orientation = horizontal"  in leoSettings.leo
> but no
> ​ effect​
> ​.
> ​..​Is that a bug?
>

​It looks that way.  Probably a side effect of recent work.​

​I'll fix it immediately.

​Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.