Re: Another mass update: PR #3367

[Edward K. Ream]

On Sat, Jun 10, 2023 at 8:57 AM Thomas Passin  wrote:

> That trystar error shows up on my Windows 3.11 machine too:


It will show up on any Python 3.11 machine :-)

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/CAMF8tS1dxBOr3GPdF3uJFmESTTHo6Soo3q4nFJ6tnPN5DcBvng%40mail.gmail.com.

Re: Another mass update: PR #3367

[Thomas Passin]

That trystar error shows up on my Windows 3.11 machine too:

C:\Tom\git\leo-editor\leo\scripts>test-leo
test-leo
..Missing
 
visitor: TokenOrderGenerator.TryStar
F..s..
==
FAIL: test_visitors_exist 
(leo.unittests.core.test_leoAst.TestTokens.test_visitors_exist)
Ensure that visitors for all ast nodes exist.
--
Traceback (most recent call last):
  File "C:\Tom\git\leo-editor\leo\unittests\core\test_leoAst.py", line 
2745, in test_visitors_exist
assert not errors, msg
AssertionError: 63 node types, 32 op types, 1 errors

--
Ran 848 tests in 9.476s

FAILED (failures=1, skipped=1)

On Saturday, June 10, 2023 at 3:40:20 AM UTC-4 Edward K. Ream wrote:

> On Sat, Jun 10, 2023 at 12:58 AM Viktor Ransmayr  
> wrote:
>
>  I've tested the 'leo-editor:devel' branch in a Fedora 37 VM.
>>
>> Running Leo's unit tests reports two errors:
>>
>
> Thanks for the report. The failing test_visitors_exist test is due to the 
> new `trystar` ast node in Python 3.11. See Leo issue #3368 
> .
>
> The failing test_bug_3270_at_path test is likely due to a problem with 
> the test itself. See Leo issue #3369 
> .
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/82f8e34f-a23b-4a6b-ac14-d197786736dbn%40googlegroups.com.

Re: Another mass update: PR #3367

[Edward K. Ream]

On Sat, Jun 10, 2023 at 12:58 AM Viktor Ransmayr 
wrote:

 I've tested the 'leo-editor:devel' branch in a Fedora 37 VM.
>
> Running Leo's unit tests reports two errors:
>

Thanks for the report. The failing test_visitors_exist test is due to the
new `trystar` ast node in Python 3.11. See Leo issue #3368
.

The failing test_bug_3270_at_path test is likely due to a problem with the
test itself. See Leo issue #3369
.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/CAMF8tS0hssYADg-KEWGxSRY0XzMCnPH%3DFiTmtQxE0iN3fU0fpw%40mail.gmail.com.

Re: Another mass update: PR #3367

[Edward K. Ream]

On Fri, Jun 9, 2023 at 2:09 PM Thomas Passin  wrote:

> Leo loaded using Python 3.11 on Windows.  So that's good.
>

Thanks for testing.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/CAMF8tS3m6UnEDPz-dwHFabaHmESTDVs9RngKZF7-dbn%2B-N%3D5XQ%40mail.gmail.com.

Re: Another mass update: PR #3367

[Viktor Ransmayr]

Hello Edward,

Edward K. Ream schrieb am Freitag, 9. Juni 2023 um 20:04:31 UTC+2:

PR #3367  imports 
Callable from collections.abc instead of typing.  typing.Callable is 
deprecated, but is not presently scheduled for removal. Nevertheless I 
thought it best to do the replacement.

To my knowledge no further changes to Leo's mypy-related code are needed.

Please report any problems.


 I've tested the 'leo-editor:devel' branch in a Fedora 37 VM.

Running Leo's unit tests reports two errors:

::

(Leo) [user@fedora-leo-study-vm Leo]$ 
(Leo) [user@fedora-leo-study-vm Leo]$ cd leo-editor/leo
(Leo) [user@fedora-leo-study-vm leo]$ python -m unittest








..Missing visitor: 
TokenOrderGenerator.TryStar

F..F





.s..
..
(python:1814): Gdk-CRITICAL **: 07:30:49.345: gdk_atom_intern: 
assertion 'atom_name != NULL' failed

(python:1814): Gdk-CRITICAL **: 07:30:49.345: gdk_atom_intern: 
assertion 'atom_name != NULL' failed

.s..
..cursesGui2.py: Tk module required for clipboard 
handling.
s.
==
FAIL: test_visitors_exist 
(unittests.core.test_leoAst.TestTokens.test_visitors_exist)
Ensure that visitors for all ast nodes exist.
--
Traceback (most recent call last):
  File 
"/home/user/PyVE/GitHub/Leo/leo-editor/leo/unittests/core/test_leoAst.py", 
line 2745, in test_visitors_exist
assert not errors, msg
AssertionError: 63 node types, 32 op types, 1 errors

==
FAIL: test_bug_3270_at_path 
(unittests.core.test_leoAtFile.TestAtFile.test_bug_3270_at_path)
--
Traceback (most recent call last):
  File 
"/home/user/PyVE/GitHub/Leo/leo-editor/leo/unittests/core/test_leoAtFile.py", 
line 102, in test_bug_3270_at_path
self.assertEqual(path, expected)
AssertionError: 
'/home/user/PyVE/GitHub/Leo/leo-editor/leo/core/c:/temp/leo/at_file_test.py' 
!= 'c:/temp/leo/at_file_test.py'
- 
/home/user/PyVE/GitHub/Leo/leo-editor/leo/core/c:/temp/leo/at_file_test.py
+ c:/temp/leo/at_file_test.py


--
Ran 848 tests in 5.994s

FAILED (failures=2, skipped=3)
(Leo) [user@fedora-leo-study-vm leo]$ 

Leo's unit tests should not make the assumption, that everyone is running 
them on Windows ;-)

With kind regards,

Viktor

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/2bbe94a2-b136-4f94-9db3-95ff9a970623n%40googlegroups.com.

Re: Another mass update: PR #3367

[Thomas Passin]

Leo loaded using Python 3.11 on Windows.  So that's good.

On Friday, June 9, 2023 at 2:04:31 PM UTC-4 Edward K. Ream wrote:

> PR #3367  imports 
> Callable from collections.abc instead of typing.  typing.Callable is 
> deprecated, but is not presently scheduled for removal. Nevertheless I 
> thought it best to do the replacement.
>
> To my knowledge no further changes to Leo's mypy-related code are needed.
>
> Please report any problems.
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/46c19cba-f863-448e-8e47-9b15f0894044n%40googlegroups.com.