Re: [libav-devel] VDD meeting notes
On 22 Sep 2014, at 16:33, Derek Buitenhuis wrote: > On 9/21/2014 12:43 PM, Andrew Kelley wrote: >> more things to remove? > > avpicture_deinterlace I thought this was already gone? Tim ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] configure: Place all temporary files in one separate directory
On 22/09/14 19:09, Michał Górny wrote: > Sorry, I missed that. And yes, I forgot the extra 'mkdir' in my patch. > > However, I don't see any reason not to use 'mktemp -d' if 'mktemp -u' > works. Atomicity is the key point in preventing race conditions. I like mktemp -d better as well. lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] livestream.com us-local news channels
Hi, On Mon, Sep 22, 2014 at 12:35 PM, Georg Stein wrote: > when i call > > int result = avformat_open_input(&this->avFormatContext, fileNameChar, fmt, > NULL); > > the result is 0 but the AVFormatContext does not has any codec/stream in > the command line tool from ffmepg can download the stream fine with the url > i use in my app avformat_find_stream_info(). Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] configure: Place all temporary files in one separate directory
Dnia 2014-09-22, o godz. 18:43:11
Diego Biurrun napisał(a):
> On Sun, Sep 21, 2014 at 06:31:04PM +0200, Michał Górny wrote:
> > Dnia 2014-09-21, o godz. 11:52:25
> > Diego Biurrun napisał(a):
> > > This reduces TMPDIR pollution and possibly avoids race conditions with
> > > temporary files that are not atomically created.
> > >
> > > Based on a patch from Michał Górny .
> > > ---
> > > --- a/configure
> > > +++ b/configure
> > > @@ -2593,15 +2593,18 @@ if ! check_cmd mktemp -u XX; then
> > >
> > > +AVTMPDIR=$(mktemp -u "${TMPDIR}/avconf." 2> /dev/null)
> > > +
> > > +mkdir $AVTMPDIR || die "Unable to create temporary directory in $TMPDIR."
> >
> > Your patch no longer avoids race conditions since once again you are
> > using 'mktemp -u'. In fact, I don't understand at all why you are
> > creating the directory manually when 'mktemp -d' will do that for you.
>
> There are systems without mktemp().
>
> > Additionally, you removed the fallback for when 'mktemp' is not
> > available. You don't have any checks for that case, so configure will
> > simply attempt to run with empty $AVTMPDIR which -- depending on
> > implementation of mkdir -- will either fail because mkdir is called
> > with no arguments or continue trying to create files in root directory.
>
> No, I'm keeping the mktemp() replacement that you removed. Have you tested
> what happens w/o mktemp() in your implementation? You only create the subdir
> if "mktemp -d" works, so creating the actual temporary files should fail.
Sorry, I missed that. And yes, I forgot the extra 'mkdir' in my patch.
However, I don't see any reason not to use 'mktemp -d' if 'mktemp -u'
works. Atomicity is the key point in preventing race conditions.
--
Best regards,
Michał Górny
signature.asc
Description: PGP signature
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] configure: Place all temporary files in one separate directory
On Sun, Sep 21, 2014 at 06:31:04PM +0200, Michał Górny wrote:
> Dnia 2014-09-21, o godz. 11:52:25
> Diego Biurrun napisał(a):
> > This reduces TMPDIR pollution and possibly avoids race conditions with
> > temporary files that are not atomically created.
> >
> > Based on a patch from Michał Górny .
> > ---
> > --- a/configure
> > +++ b/configure
> > @@ -2593,15 +2593,18 @@ if ! check_cmd mktemp -u XX; then
> >
> > +AVTMPDIR=$(mktemp -u "${TMPDIR}/avconf." 2> /dev/null)
> > +
> > +mkdir $AVTMPDIR || die "Unable to create temporary directory in $TMPDIR."
>
> Your patch no longer avoids race conditions since once again you are
> using 'mktemp -u'. In fact, I don't understand at all why you are
> creating the directory manually when 'mktemp -d' will do that for you.
There are systems without mktemp().
> Additionally, you removed the fallback for when 'mktemp' is not
> available. You don't have any checks for that case, so configure will
> simply attempt to run with empty $AVTMPDIR which -- depending on
> implementation of mkdir -- will either fail because mkdir is called
> with no arguments or continue trying to create files in root directory.
No, I'm keeping the mktemp() replacement that you removed. Have you tested
what happens w/o mktemp() in your implementation? You only create the subdir
if "mktemp -d" works, so creating the actual temporary files should fail.
> Finally, you didn't quote $AVTMPDIR.
Thanks, good catch.
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] livestream.com us-local news channels
Hello, i try now for some time to dump with a small app written in c by using the ffmpeg libs to download the streams of a us local news channel streamed on livestream.com - without success. the stream url looks like (there is an auth key in): http://api.new.livestream.com/broadcasts/62834750.m3u8?dw=100&hdnea=st=14114 03505~exp=1411404405~acl=/i/1864610_1649849_f007e646_1@188864/*~hmac=be25315 e9f3dd58ac529bb167a3889b336af7faddaa02b8cae99b82969900097 and http://livestream-f.akamaihd.net/i/1864610_1649849_f007e646_1@188864/master. m3u8?dw=100&__b__=678&hdnea=st=1411403505~exp=1411404405~acl=/i/1864610_1649 849_f007e646_1@188864/*~hmac=be25315e9f3dd58ac529bb167a3889b336af7faddaa02b8 cae99b82969900097 when i call int result = avformat_open_input(&this->avFormatContext, fileNameChar, fmt, NULL); the result is 0 but the AVFormatContext does not has any codec/stream in the command line tool from ffmepg can download the stream fine with the url i use in my app so perhaps somebody has here a hint for me to solve my problem thx Georg --- Diese E-Mail ist frei von Viren und Malware, denn der avast! Antivirus Schutz ist aktiv. http://www.avast.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] avutil: fix 6.1 channel layout
On Fri, Sep 19, 2014 at 03:46:33PM +0200, Marc-Antoine ARNAUD wrote: > > I don't understand your remark. > Just looking enums which describe the type of 6.1, we have 3 possibilities. > And (before) string will no mention difference between AV_CH_LAYOUT_6POINT1 > and AV_CH_LAYOUT_6POINT1_BACK. > > It's just to made difference between enums on string. Yes, and you are only differentiating one pair of strings, when there are four pairs of layouts where each pair is described by the same string. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] VDD meeting notes
On 9/21/2014 12:43 PM, Andrew Kelley wrote: > more things to remove? avpicture_deinterlace - Derek ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] configure: Place all temporary files in one separate directory
On 21/09/14 18:31, Michał Górny wrote:
> Dnia 2014-09-21, o godz. 11:52:25
> Diego Biurrun napisał(a):
>
>> This reduces TMPDIR pollution and possibly avoids race conditions with
>> temporary files that are not atomically created.
>>
>> Based on a patch from Michał Górny .
>> ---
>>
>> Rewritten to be less intrusive.
>>
>> configure | 11 +++
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 59dd453..ea3244c 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2593,15 +2593,18 @@ if ! check_cmd mktemp -u XX; then
>> }
>> fi
>>
>> +AVTMPDIR=$(mktemp -u "${TMPDIR}/avconf." 2> /dev/null)
>> +
>> +mkdir $AVTMPDIR || die "Unable to create temporary directory in $TMPDIR."
>> +
>
> Your patch no longer avoids race conditions since once again you are
> using 'mktemp -u'. In fact, I don't understand at all why you are
> creating the directory manually when 'mktemp -d' will do that for you.
>
> Additionally, you removed the fallback for when 'mktemp' is not
> available. You don't have any checks for that case, so configure will
> simply attempt to run with empty $AVTMPDIR which -- depending on
> implementation of mkdir -- will either fail because mkdir is called
> with no arguments or continue trying to create files in root directory.
>
> Finally, you didn't quote $AVTMPDIR.
Actually I tested that we do not really support paths with spaces for
tmp variables. One more item to fix.
lu
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] configure: Place all temporary files in one separate directory
On 21/09/14 18:31, Michał Górny wrote:
> Dnia 2014-09-21, o godz. 11:52:25
> Diego Biurrun napisał(a):
>
>> This reduces TMPDIR pollution and possibly avoids race conditions with
>> temporary files that are not atomically created.
>>
>> Based on a patch from Michał Górny .
>> ---
>>
>> Rewritten to be less intrusive.
>>
>> configure | 11 +++
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 59dd453..ea3244c 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2593,15 +2593,18 @@ if ! check_cmd mktemp -u XX; then
>> }
>> fi
>>
>> +AVTMPDIR=$(mktemp -u "${TMPDIR}/avconf." 2> /dev/null)
>> +
>> +mkdir $AVTMPDIR || die "Unable to create temporary directory in $TMPDIR."
>> +
>
> Your patch no longer avoids race conditions since once again you are
> using 'mktemp -u'. In fact, I don't understand at all why you are
> creating the directory manually when 'mktemp -d' will do that for you.
Thanks a lot for spotting!
lu
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] vc1: use logical operation instead of bitwise for twomv
On 21/09/14 16:16, Tim Walker wrote: > From: Michael Niedermayer > > CC: libav-sta...@libav.org > Signed-off-by: Michael Niedermayer > (cherry picked from commit 1e2ab98460761c86268993e7a7ee690876df5efd) Drop the cherry-pick line. > Signed-off-by: Tim Walker > --- > libavcodec/vc1dec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) The rest looks fine. lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
