[libav-devel] [PATCH] Remove Benjamin Larsson from consulting
--- src/consulting | 8 1 file changed, 8 deletions(-) diff --git a/src/consulting b/src/consulting index 4ac26a0..60cd85a 100644 --- a/src/consulting +++ b/src/consulting @@ -44,14 +44,6 @@ E.g.: " --> -Benjamin Larsson - -Benjamin Larsson is located in Stockholm, Sweden and is available for -contracting work. He has worked on FFmpeg and Libav since 2004. Main -area of expertise is audio codecs. You can contact him by email at -mailto:benjamin%20at%20southpole%20dot%20se";>benjamin at southpole dot se. - - Diego Biurrun Diego is located in Aachen, Germany and available for contracting work. He -- 2.5.0 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH V2] flv: Workaround for buggy Omnia A/XE encoder
This fixes https://bugzilla.libav.org/show_bug.cgi?id=599.
MvH
Benjamin Larsson
>From d4bbe456698502fa56269ba425f154cf05518faf Mon Sep 17 00:00:00 2001
From: Benjamin Larsson
Date: Sun, 5 Jan 2014 14:42:14 +0100
Subject: [PATCH] flv: Workaround for buggy Omnia A/XE encoder
The Omnia A/XE encoder writes the explicit extra data incorrectly
and wrongly disables parametric stereo. Truncating the extra data
by setting the size to 2 works around this. The AAC extra data
parser will then only parse the correct parts.
Bug-id: 599
---
libavformat/flvdec.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index c65c90c..72d3ca4 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -915,6 +915,12 @@ skip:
return ret;
if (st->codec->codec_id == AV_CODEC_ID_AAC) {
MPEG4AudioConfig cfg;
+
+/* Workaround for buggy Omnia A/XE encoder */
+AVDictionaryEntry *t = av_dict_get(s->metadata, "Encoder", NULL, 0);
+if (t && !strcmp(t->value,"Omnia A/XE"))
+st->codec->extradata_size = 2;
+
avpriv_mpeg4audio_get_config(&cfg, st->codec->extradata,
st->codec->extradata_size * 8, 1);
st->codec->channels = cfg.channels;
--
1.8.3.2
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH] flv: Workaround for buggy Omnia A/XE encoder
This fixes https://bugzilla.libav.org/show_bug.cgi?id=599.
MvH
Benjamin Larsson
>From 2529a34d6f2a517ddfe27de58ed1c9352b984110 Mon Sep 17 00:00:00 2001
From: Benjamin Larsson
Date: Sun, 5 Jan 2014 14:42:14 +0100
Subject: [PATCH] flv: Workaround for buggy Omnia A/XE encoder
The Omnia A/XE encoder writes the explicit extra data incorrectly.
It disables parametric stereo wrongly, as a fix truncate the extra
data by setting the size to 2. The aac extra data parser will then
only parse the correct parts.
---
libavformat/flvdec.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index c65c90c..a83c65b 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -915,6 +915,12 @@ skip:
return ret;
if (st->codec->codec_id == AV_CODEC_ID_AAC) {
MPEG4AudioConfig cfg;
+
+/* Workaround for buggy Omnia A/XE encoder */
+AVDictionaryEntry *t = av_dict_get(s->metadata, "Encoder", NULL, 0);
+if (!strcmp(t->value,"Omnia A/XE"))
+st->codec->extradata_size = 2;
+
avpriv_mpeg4audio_get_config(&cfg, st->codec->extradata,
st->codec->extradata_size * 8, 1);
st->codec->channels = cfg.channels;
--
1.8.3.2
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] vc1: Remove now unused variables
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/4] jpeg2000: Native decoder for DCinema.
On 03/16/2013 05:24 PM, Diego Biurrun wrote:
On Fri, Mar 15, 2013 at 03:35:14PM +0100, Nicolas Bertrand wrote:
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -2561,6 +2561,12 @@ typedef struct AVCodecContext {
#define FF_PROFILE_MPEG4_SIMPLE_STUDIO 14
#define FF_PROFILE_MPEG4_ADVANCED_SIMPLE 15
+#define FF_PROFILE_JPEG2000_CSTRM_RSTRCTN_0 0
+#define FF_PROFILE_JPEG2000_CSTRM_RSTRCTN_1 1
+#define FF_PROFILE_JPEG2000_CSTRM_NO_RSTRCTN2
+#define FF_PROFILE_JPEG2000_DCINEMA_2K 3
+#define FF_PROFILE_JPEG2000_DCINEMA_4K 4
Don't we have a way to export these per-codec? Anton?
http://git.libav.org/?p=libav.git;a=blob;f=libavcodec/dcadec.c;h=e53b03e8f9dcd58bf51ac83b2827b55a7b8142d1;hb=HEAD#l1939
MvH
Benjamin Larsson
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] atrac3: avoid oversized shifting in decode_bytes()
On 03/15/2013 11:31 AM, Xi Wang wrote: When `off' is 0, `0x537F6103 << 32' in the following expression invokes undefined behavior, the result of which is not necessarily 0. (0x537F6103 >> (off * 8)) | (0x537F6103 << (32 - (off * 8))) This patch avoids oversized shifting. Signed-off-by: Xi Wang OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 12/17] fate: Add more dependencies for the fft tests
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] (3-clause) BSD licenses
As a matter of principle I'd just state that MIT/ISC is preferred and BSD-3 is fine surely if it is because the external dependency for that code is BSD-3 as well. +1, I'd be willing to accept it as well, I wouldn't want to throw away a perfectly good contribution just due to that. Yes, it's not ideal to pile up more of these, but since relicensing is a complicated matter in this case, I'd be willing to accept it. // Martin I agree with Martin. We could adopt a policy of not accepting code to core libav with BSD-3. But things that needs to be enabled is ok. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] Use ptrdiff_t instead of int for {avg, put}_pixels line_size parameter.
On 01/30/2013 12:13 PM, Reinhard Tartler wrote: On Wed, Jan 30, 2013 at 11:35 AM, Benjamin Larsson wrote: On 01/29/2013 10:13 PM, Diego Biurrun wrote: This avoids SIMD-optimized functions having to sign-extend their line size argument manually to be able to do pointer arithmetic. --- This is ugly and obfuscating. I have a hard time to follow your reasoning. Please elaborate. Using a pointer difference type when you express a simple size. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] Use ptrdiff_t instead of int for {avg, put}_pixels line_size parameter.
On 01/29/2013 10:13 PM, Diego Biurrun wrote: This avoids SIMD-optimized functions having to sign-extend their line size argument manually to be able to do pointer arithmetic. --- This is ugly and obfuscating. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/5] h264: Fix assignments in if()
All ok ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/5] cook: use a multiple of 16 length for vector_clipf()
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] Integration of OpenEncode and OpenDecode into libav
On 01/08/2013 11:31 AM, Yuan Yeow Leow wrote: Hi there, I would like to ask if libav would accept the integration of OpenDecode (mpeg2, H264 & VC1) and OpenEncode (H264) into Libav if it is implemented? Thank you. Leow Yuan Yeow Patches are welcome. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] dca_parser: Handle loss of bitstream sync better
On 01/06/2013 11:37 PM, John Stebbins wrote:
On 01/04/2013 04:11 PM, John Stebbins wrote:
On 01/03/2013 10:32 AM, John Stebbins wrote:
On 01/03/2013 12:36 AM, Diego Biurrun wrote:
On Wed, Jan 02, 2013 at 11:49:40AM -0800, John Stebbins wrote:
A change in framesize caused a perpetual loss of synchronization. So
when the sync pattern is not found where it is expected, reset and
recalculate the framesize.
--- a/libavcodec/dca_parser.c
+++ b/libavcodec/dca_parser.c
@@ -88,6 +88,17 @@ static int dca_find_frame_end(DCAParseContext * pc1, const
uint8_t * buf,
pc1->size = 0;
return i - 3;
}
+else if (pc1->size == pc1->framesize)
+{
nit: } else if () {
+// Lost sync, search for sync and reset framesize as it may
+// have changed mid-stream
+pc->frame_start_found = 0;
+pc->state = -1;
+pc1->size = 0;
+pc1->framesize = 0;
+pc1->lastmarker = 0;
+return END_NOT_FOUND;
nit: = could be aligned
This looks reasonable to me. Ben? Justin?
Address nits...
I found a problem, so ignore this for now. It breaks DTS-HD. I'm working on
an alternate patch.
Here's an update that fixes the above dts-hd problem. It uses the fsize field
from the dca header instead of computing
framesize by counting bytes between sync patterns. Ideally, parsing the header
should happen before
dca_find_frame_end(). But that would require quite a lot more rearrangement of
code, and what I have done works
sufficiently well. It will result in the loss of a frame or two if there is a
transition from a larger frame size to a
smaller frame size.
LGTM
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] ac3dec: fix non-optimal dithering of zero bit mantissas
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/6] mlp: store the channel layout for each substream.
1-4 looks ok /Benjamin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/2] flvenc: Check whether seeking back to the header succeeded
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] sapenc: Pass the title on to the chained muxers
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/2] mss2: prevent potential uninitialized reads
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] binkaudio: set channel layout
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] yuv4mpeg: reject unsupported codecs
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] function parameter updates
Cook patches ok. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 42/45] wma: do not keep private copies of some AVCodecContext fields
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 40/45] twinvq: validate sample rate code
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 39/45] twinvq: set channel layout
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 38/45] twinvq: validate that channels is not <= 0
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 36/45] sipr: set channel layout
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 32/45] qdm2: remove unneeded checks for channel count
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 31/45] qdm2: make sure channels is not <= 0 and set channel layout
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 17/45] dcadec: allow the decoder to change the channel layout mid-stream
Well, a dca stream isn't allowed to change configuration midstream. But I guess is the decoder can handle it the patch is OK even though it is a violation of the specs. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 15/45] cook: move samples_per_frame from COOKSubpacket to where it is used
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 14/45] cook: use av_get_channel_layout_nb_channels() instead of cook_count_channels()
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 13/45] cook: reverse a condition so that the code makes more sense
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 12/45] cook: remove unneeded COOKContext variable, sample_rate
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 11/45] cook: remove unneeded COOKContext variable, bit_rate
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 10/45] cook: use AVCodecContext.channels instead of keeping a private copy
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] riff: remove a write-only variable
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] wav (de)muxer changes
LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] Restructure av_log_missing_feature message
LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/2] libfdk-aac: reindent after last commit
Awesome ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] libfdk-aac: Limit to supported sample rates.
Jolly good! ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] libfdk-aac: Limit to supported sample rates.
On 09/25/2012 12:16 AM, Nathan Caldwell wrote:
---
libavcodec/libfdk-aacenc.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c
index c9ecc4c..4c17a95 100644
--- a/libavcodec/libfdk-aacenc.c
+++ b/libavcodec/libfdk-aacenc.c
@@ -393,6 +393,11 @@ static const uint64_t aac_channel_layout[] = {
0,
};
+static const int aac_sample_rates[15] = {
+96000, 88200, 64000, 48000, 44100, 32000,
+24000, 22050, 16000, 12000, 11025, 8000
+};
+
I think you need a 0 entry last. Otherwise I don't know how this would
work properly.
MvH
Benjamin Larsson
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 09/31] iac: use planar sample format
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 08/31] dcadec: use float planar sample format
LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 07/31] cook: use planar sample format
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 06/31] atrac3: use float planar sample format
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 15/15] avconv: remove pointless continue at the end of a while() block
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 13/15] twinvq: do not discard the first 2 decoded frames
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 12/15] twinvq: add a flush function to zero previous frame samples on seek
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 06/15] 8svx: consume packet after it has been fully decoded
LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 05/15] apedec: consume packet after it has been fully decoded
LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 04/15] libspeex: consume packet after it has been fully decoded
LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/3] aacsbr: silence bogus clang and gcc warning
On 09/18/2012 07:52 PM, Alex Converse wrote:
On Tue, Sep 18, 2012 at 10:08 AM, Benjamin Larsson
wrote:
On 09/18/2012 07:05 PM, Alex Converse wrote:
On Mon, Sep 17, 2012 at 4:35 PM, Benjamin Larsson
wrote:
gcc:
libavcodec/aacsbr.c:399:8: warning: ‘max_qmf_subbands’ may be used
uninitialized in this function [-Wuninitialized]
libavcodec/aacsbr.c:326:24: note: ‘max_qmf_subbands’ was declared here
clang:
libavcodec/aacsbr.c:391:16: warning: variable 'max_qmf_subbands' is used
uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
} else if (sbr->sample_rate>= 48000)
^
libavcodec/aacsbr.c:394:33: note: uninitialized use occurs here
if (sbr->k[2] - sbr->k[0]> max_qmf_subbands) {
^~~~
Reorder and change the if else block so that the max_qmf_subbands
variable always will be set. This change is valid as the only allowed
sample rate betwen 32000 and 48000 is 41000.
---
libavcodec/aacsbr.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c
index 5eca115..35e7c72 100644
--- a/libavcodec/aacsbr.c
+++ b/libavcodec/aacsbr.c
@@ -386,10 +386,10 @@ static int sbr_make_f_master(AACContext *ac,
SpectralBandReplication *sbr,
// Requirements (14496-3 sp04 p205)
if (sbr->sample_rate<= 32000) {
max_qmf_subbands = 48;
-} else if (sbr->sample_rate == 44100) {
-max_qmf_subbands = 35;
-} else if (sbr->sample_rate>= 48000)
+} else if (sbr->sample_rate>= 48000) {
max_qmf_subbands = 32;
+} else /*if (sbr->sample_rate == 44100) */
+max_qmf_subbands = 35;
Is there a reason you are changing the order?
To be able to change the 44100 else if block to an else.
why not just change the "else if (sbr->sample_rate>= 48000)" to an else?
Lets keep the ranges sane even though there is only one valid sample
rate between 32kHz and 48kHz.
MvH
Benjamin Larsson
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/3] aacsbr: silence bogus clang and gcc warning
On 09/18/2012 07:05 PM, Alex Converse wrote:
On Mon, Sep 17, 2012 at 4:35 PM, Benjamin Larsson wrote:
gcc:
libavcodec/aacsbr.c:399:8: warning: ‘max_qmf_subbands’ may be used
uninitialized in this function [-Wuninitialized]
libavcodec/aacsbr.c:326:24: note: ‘max_qmf_subbands’ was declared here
clang:
libavcodec/aacsbr.c:391:16: warning: variable 'max_qmf_subbands' is used
uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
} else if (sbr->sample_rate>= 48000)
^
libavcodec/aacsbr.c:394:33: note: uninitialized use occurs here
if (sbr->k[2] - sbr->k[0]> max_qmf_subbands) {
^~~~
Reorder and change the if else block so that the max_qmf_subbands
variable always will be set. This change is valid as the only allowed
sample rate betwen 32000 and 48000 is 41000.
---
libavcodec/aacsbr.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c
index 5eca115..35e7c72 100644
--- a/libavcodec/aacsbr.c
+++ b/libavcodec/aacsbr.c
@@ -386,10 +386,10 @@ static int sbr_make_f_master(AACContext *ac,
SpectralBandReplication *sbr,
// Requirements (14496-3 sp04 p205)
if (sbr->sample_rate<= 32000) {
max_qmf_subbands = 48;
-} else if (sbr->sample_rate == 44100) {
-max_qmf_subbands = 35;
-} else if (sbr->sample_rate>= 48000)
+} else if (sbr->sample_rate>= 48000) {
max_qmf_subbands = 32;
+} else /*if (sbr->sample_rate == 44100) */
+max_qmf_subbands = 35;
Is there a reason you are changing the order?
To be able to change the 44100 else if block to an else.
MvH
Benjamin Larsson
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] lpc: initialize 'err' to 0 at declaration in compute_lpc_coefs()
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/3] aacsbr: silence bogus clang and gcc warning
On 09/18/2012 01:42 AM, Måns Rullgård wrote:
Benjamin Larsson writes:
gcc:
libavcodec/aacsbr.c:399:8: warning: ‘max_qmf_subbands’ may be used
uninitialized in this function [-Wuninitialized]
libavcodec/aacsbr.c:326:24: note: ‘max_qmf_subbands’ was declared here
clang:
libavcodec/aacsbr.c:391:16: warning: variable 'max_qmf_subbands' is used
uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
} else if (sbr->sample_rate>= 48000)
^
libavcodec/aacsbr.c:394:33: note: uninitialized use occurs here
if (sbr->k[2] - sbr->k[0]> max_qmf_subbands) {
^~~~
Reorder and change the if else block so that the max_qmf_subbands
variable always will be set. This change is valid as the only allowed
sample rate betwen 32000 and 48000 is 41000.
---
libavcodec/aacsbr.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c
index 5eca115..35e7c72 100644
--- a/libavcodec/aacsbr.c
+++ b/libavcodec/aacsbr.c
@@ -386,10 +386,10 @@ static int sbr_make_f_master(AACContext *ac,
SpectralBandReplication *sbr,
// Requirements (14496-3 sp04 p205)
if (sbr->sample_rate<= 32000) {
max_qmf_subbands = 48;
-} else if (sbr->sample_rate == 44100) {
-max_qmf_subbands = 35;
-} else if (sbr->sample_rate>= 48000)
+} else if (sbr->sample_rate>= 48000) {
max_qmf_subbands = 32;
+} else /*if (sbr->sample_rate == 44100) */
+max_qmf_subbands = 35;
Might be clearer:
if (sbr->sample_rate<= 32000) {
max_qmf_subbands = 48;
} else if (sbr->sample_rate< 48000) {
max_qmf_subbands = 35;
} else {
max_qmf_subbands = 32;
}
The specifications use this strange range construct. I prefer to keep it
resembling the spec. But either way is fine by me.
MvH
Benjamin Larsson
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH 3/3] aacsbr: silence bogus clang and gcc warning
gcc:
libavcodec/aacsbr.c:399:8: warning: ‘max_qmf_subbands’ may be used
uninitialized in this function [-Wuninitialized]
libavcodec/aacsbr.c:326:24: note: ‘max_qmf_subbands’ was declared here
clang:
libavcodec/aacsbr.c:391:16: warning: variable 'max_qmf_subbands' is used
uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
} else if (sbr->sample_rate >= 48000)
^
libavcodec/aacsbr.c:394:33: note: uninitialized use occurs here
if (sbr->k[2] - sbr->k[0] > max_qmf_subbands) {
^~~~
Reorder and change the if else block so that the max_qmf_subbands
variable always will be set. This change is valid as the only allowed
sample rate betwen 32000 and 48000 is 41000.
---
libavcodec/aacsbr.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c
index 5eca115..35e7c72 100644
--- a/libavcodec/aacsbr.c
+++ b/libavcodec/aacsbr.c
@@ -386,10 +386,10 @@ static int sbr_make_f_master(AACContext *ac,
SpectralBandReplication *sbr,
// Requirements (14496-3 sp04 p205)
if (sbr->sample_rate <= 32000) {
max_qmf_subbands = 48;
-} else if (sbr->sample_rate == 44100) {
-max_qmf_subbands = 35;
-} else if (sbr->sample_rate >= 48000)
+} else if (sbr->sample_rate >= 48000) {
max_qmf_subbands = 32;
+} else /*if (sbr->sample_rate == 44100) */
+max_qmf_subbands = 35;
if (sbr->k[2] - sbr->k[0] > max_qmf_subbands) {
av_log(ac->avctx, AV_LOG_ERROR,
--
1.7.9.5
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH 2/3] a64multienc: silence bogus gcc warning
libavcodec/a64multienc.c: In function ‘a64multi_encode_frame’:
libavcodec/a64multienc.c:342:17: warning: ‘buf’ may be used uninitialized in
this function [-Wuninitialized]
The compiler has trouble to figure out that the if block
if (c->mc_frame_counter == c->mc_lifetime) {
never should be entered with both values being 0. So add
an explicit check on one of the parameters.
---
libavcodec/a64multienc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/a64multienc.c b/libavcodec/a64multienc.c
index c9d3b3c..9d3dca5 100644
--- a/libavcodec/a64multienc.c
+++ b/libavcodec/a64multienc.c
@@ -304,7 +304,7 @@ static int a64multi_encode_frame(AVCodecContext *avctx,
AVPacket *pkt,
}
/* lifetime reached so now convert X frames at once */
-if (c->mc_frame_counter == c->mc_lifetime) {
+if ((c->mc_frame_counter == c->mc_lifetime) && c->mc_lifetime) {
req_size = 0;
/* any frames to encode? */
if (c->mc_lifetime) {
--
1.7.9.5
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH 1/3] yuv2rgb: silence bogus gcc warning
The calculation of abase depends on the variable needAlpha, but one can safely calculate and set the abase variable even though it isn't used. --- libswscale/yuv2rgb.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index f1ce4aa..416e3c4 100644 --- a/libswscale/yuv2rgb.c +++ b/libswscale/yuv2rgb.c @@ -862,8 +862,7 @@ av_cold int ff_yuv2rgb_c_init_tables(SwsContext *c, const int inv_table[4], gbase = base + 8; bbase = base + (isRgb ? 0 : 16); needAlpha = CONFIG_SWSCALE_ALPHA && isALPHA(c->srcFormat); -if (!needAlpha) -abase = (base + 24) & 31; +abase = (base + 24) & 31; c->yuvTable = av_malloc(1024 * 3 * 4); y_table32 = c->yuvTable; yb = -(384 << 16) - oy; -- 1.7.9.5 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] rmdec: silence real warning
On 09/17/2012 11:14 PM, Måns Rullgård wrote: Benjamin Larsson writes: if len gets the value 0 the st pointer will never be initialized and will later on be dereferenced, amend this by increasing the range check for valid len values. --- libavformat/rmdec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I'd prefer that you used a more descriptive subject line, something like "rmdec: fix use of uninitialised value". I think I found a nice template for these kind of issues, I'll resend the patch with better description. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/3] binkaudio: use float sample format
LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/3] binkaudio: remove unneeded GET_BITS_SAFE macro
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/3] binkaudio: use a different value for s->root for the DCT codec
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 8/8] avfiltergraph: silence an uninitialized variable warning
On 09/16/2012 10:18 AM, Anton Khirnov wrote: The warning is: libavfilter/avfiltergraph.c: In function ‘avfilter_graph_config’: libavfilter/avfiltergraph.c:528:9: warning: ‘best_idx’ may be used uninitialized in this function [-Wuninitialized] libavfilter/avfiltergraph.c:479:13: note: ‘best_idx’ was declared here Initialize it to an invalid value and add an assert that it's properly set later. The compiler can't figure out that if (diff < best_diff) will be true. with int best_idx, best_diff = INT_MAX; int diff = abs(sample_rate - outlink->in_samplerates->formats[j]); So patch LGTM. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH] rmdec: silence real warning
if len gets the value 0 the st pointer will never be initialized and will later on be dereferenced, amend this by increasing the range check for valid len values. --- libavformat/rmdec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index 6549454..474d135 100644 --- a/libavformat/rmdec.c +++ b/libavformat/rmdec.c @@ -894,7 +894,7 @@ static int rm_read_packet(AVFormatContext *s, AVPacket *pkt) st = s->streams[i]; } -if(len<0 || s->pb->eof_reached) +if(len<=0 || s->pb->eof_reached) return AVERROR(EIO); res = ff_rm_parse_packet (s, s->pb, st, st->priv_data, len, pkt, -- 1.7.9.5 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] flvenc: silence bogus warning, gcc failes to figure out that enc->codec_type can only have 3 different values. Thus when an if/else is encountered it triggers on the possibil
On 09/17/2012 09:37 PM, Luca Barbato wrote: On 9/17/12 9:32 PM, Benjamin Larsson wrote: On 09/17/2012 09:20 PM, Derek Buitenhuis wrote: On 17/09/2012 3:14 PM, Benjamin Larsson wrote: --- libavformat/flvenc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Should uh, probably reformat that commit message. - Derek Any guess what might cause the commit messages to be broken ? Missing enlines when needed I guess ^^; (never use commit -m) I don't, I'll change editor. lu MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] flvenc: silence bogus warning, gcc failes to figure out that enc->codec_type can only have 3 different values. Thus when an if/else is encountered it triggers on the possibil
On 09/17/2012 09:20 PM, Derek Buitenhuis wrote: On 17/09/2012 3:14 PM, Benjamin Larsson wrote: --- libavformat/flvenc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Should uh, probably reformat that commit message. - Derek Any guess what might cause the commit messages to be broken ? MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH] flvenc: silence bogus warning, gcc failes to figure out that enc->codec_type can only have 3 different values. Thus when an if/else is encountered it triggers on the possibility
--- libavformat/flvenc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index 57e7aac..839b9b0 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -421,7 +421,7 @@ static int flv_write_packet(AVFormatContext *s, AVPacket *pkt) unsigned ts; int size = pkt->size; uint8_t *data = NULL; -int flags, flags_size; +int flags = 0, flags_size; // av_log(s, AV_LOG_DEBUG, "type:%d pts: %"PRId64" size:%d\n", //enc->codec_type, timestamp, size); -- 1.7.9.5 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [RFC] warning silencing
On 09/16/2012 10:24 PM, Benjamin Larsson wrote: On 09/16/2012 10:14 PM, Ronald S. Bultje wrote: Hi, On Sun, Sep 16, 2012 at 1:02 PM, Måns Rullgård wrote: Benjamin Larsson writes: Should we (me) aim to get rid of the "may be used uninitialized" and other warnings in the code? Most of the cases we just need to initialize the offending variable to silence the warning. For example this case: /libavdevice/v4l2.c: In function 'v4l2_read_header': /libavdevice/v4l2.c:686: warning: 'codec_id' may be used uninitialized in this function Is this wanted or should I go and do something else ? Some of those warnings are probably genuine. We need to find those and fix them properly, then shut up the rest. Simply adding a random initialiser is not a proper fix. Do we have a av_unitialized macro (like av_unused)? libvpx has something like that. Yeah, that's another topic, can we remove that ? It's an abomination imo. To clarify, in non speed critical code why not just initialize the value instead of cluttering code with av_unused macros. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [RFC] warning silencing
On 09/16/2012 10:14 PM, Ronald S. Bultje wrote: Hi, On Sun, Sep 16, 2012 at 1:02 PM, Måns Rullgård wrote: Benjamin Larsson writes: Should we (me) aim to get rid of the "may be used uninitialized" and other warnings in the code? Most of the cases we just need to initialize the offending variable to silence the warning. For example this case: /libavdevice/v4l2.c: In function 'v4l2_read_header': /libavdevice/v4l2.c:686: warning: 'codec_id' may be used uninitialized in this function Is this wanted or should I go and do something else ? Some of those warnings are probably genuine. We need to find those and fix them properly, then shut up the rest. Simply adding a random initialiser is not a proper fix. Do we have a av_unitialized macro (like av_unused)? libvpx has something like that. Yeah, that's another topic, can we remove that ? It's an abomination imo. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [RFC] warning silencing
On 09/16/2012 10:02 PM, Måns Rullgård wrote: Benjamin Larsson writes: Should we (me) aim to get rid of the "may be used uninitialized" and other warnings in the code? Most of the cases we just need to initialize the offending variable to silence the warning. For example this case: /libavdevice/v4l2.c: In function 'v4l2_read_header': /libavdevice/v4l2.c:686: warning: 'codec_id' may be used uninitialized in this function Is this wanted or should I go and do something else ? Some of those warnings are probably genuine. We need to find those and fix them properly, then shut up the rest. Simply adding a random initialiser is not a proper fix. Ok, I'll start fixing things then. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [RFC] warning silencing
Should we (me) aim to get rid of the "may be used uninitialized" and other warnings in the code? Most of the cases we just need to initialize the offending variable to silence the warning. For example this case: /libavdevice/v4l2.c: In function 'v4l2_read_header': /libavdevice/v4l2.c:686: warning: 'codec_id' may be used uninitialized in this function Is this wanted or should I go and do something else ? MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/3] Use proper value for unsigned variable
On 09/16/2012 01:21 PM, Måns Rullgård wrote: Benjamin Larsson writes: On 09/16/2012 01:09 PM, Måns Rullgård wrote: Yes, and that might be forgotten. Also, how would you initialise a uintptr_t to all ones? I'm not promoting to change all initializations like this. So far this one for the reasons I stated before. I'm not opposed to changing things to silence warnings, but such changes should never leave the code worse off than it was. The proposed change is unsafe in the same way that "type *foo = malloc(sizeof(type))" is less safe than using sizeof(*foo). So is that a NACK on this patch ? MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/3] Use proper value for unsigned variable
On 09/16/2012 01:09 PM, Måns Rullgård wrote: Yes, and that might be forgotten. Also, how would you initialise a uintptr_t to all ones? I'm not promoting to change all initializations like this. So far this one for the reasons I stated before. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/3] Use proper value for unsigned variable
On 09/16/2012 12:54 PM, Måns Rullgård wrote:
Benjamin Larsson writes:
On 09/16/2012 12:16 PM, Måns Rullgård wrote:
Benjamin Larsson writes:
---
libavformat/dtsdec.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/dtsdec.c b/libavformat/dtsdec.c
index 28cccd3..7ea9fe7 100644
--- a/libavformat/dtsdec.c
+++ b/libavformat/dtsdec.c
@@ -31,7 +31,7 @@
static int dts_probe(AVProbeData *p)
{
const uint8_t *buf, *bufp;
-uint32_t state = -1;
+uint32_t state = 0x;
-1 is perfectly fine as an all-ones initialiser. The conversion rules
are unambiguous.
I suspected that, this change silences a warning and makes the use of
the variable clearer.
libavformat/dtsdec.c(34) : warning C4245: 'initializing' : conversion
from 'int' to 'uint32_t', signed/unsigned mismatch
Stupid compiler. What about -1u?
I don't have a working MSVC setup yet.
Writing out the unsigned value explicitly is actually a bad thing.
Consider what would happen if the type were to be changed to uint64_t
some time in the future.
Then the code would need to change also. Anyway I have no strong feeling
if this goes in or not. Imo this change makes the code clearer and
silence a (somewhat bogus) warning.
MvH
Benjamin Larsson
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/3] Use proper value for unsigned variable
On 09/16/2012 12:16 PM, Måns Rullgård wrote:
Benjamin Larsson writes:
---
libavformat/dtsdec.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/dtsdec.c b/libavformat/dtsdec.c
index 28cccd3..7ea9fe7 100644
--- a/libavformat/dtsdec.c
+++ b/libavformat/dtsdec.c
@@ -31,7 +31,7 @@
static int dts_probe(AVProbeData *p)
{
const uint8_t *buf, *bufp;
-uint32_t state = -1;
+uint32_t state = 0x;
-1 is perfectly fine as an all-ones initialiser. The conversion rules
are unambiguous.
I suspected that, this change silences a warning and makes the use of
the variable clearer.
libavformat/dtsdec.c(34) : warning C4245: 'initializing' : conversion
from 'int' to 'uint32_t', signed/unsigned mismatch
MvH
Benjamin Larssson
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/3] Fix alaw handling in flv demuxer
All look fine, the commit messages might enjoy some formatting, mind if I push them with such amended message: flvdec: fix alaw handling dtsdec: use proper value for unsigned variable etc ? lu Please do that. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH 3/3] Remove unused variable.
---
libavformat/xwma.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/xwma.c b/libavformat/xwma.c
index 46ca0b8..baabf57 100644
--- a/libavformat/xwma.c
+++ b/libavformat/xwma.c
@@ -42,7 +42,7 @@ static int xwma_probe(AVProbeData *p)
static int xwma_read_header(AVFormatContext *s)
{
-int64_t size, av_uninit(data_size);
+int64_t size;
int ret;
uint32_t dpds_table_size = 0;
uint32_t *dpds_table = 0;
--
1.7.9.5
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH 1/3] Fix alaw handling in flv demuxer
--- libavformat/flvdec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 868cc6b..421f554 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -119,7 +119,7 @@ static int flv_same_audio_codec(AVCodecContext *acodec, int flags) return acodec->sample_rate == 8000 && acodec->codec_id == AV_CODEC_ID_PCM_MULAW; case FLV_CODECID_PCM_ALAW: -return acodec->sample_rate = 8000 && +return acodec->sample_rate == 8000 && acodec->codec_id == AV_CODEC_ID_PCM_ALAW; default: return acodec->codec_tag == (flv_codecid >> FLV_AUDIO_CODECID_OFFSET); -- 1.7.9.5 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH 2/3] Use proper value for unsigned variable
---
libavformat/dtsdec.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/dtsdec.c b/libavformat/dtsdec.c
index 28cccd3..7ea9fe7 100644
--- a/libavformat/dtsdec.c
+++ b/libavformat/dtsdec.c
@@ -31,7 +31,7 @@
static int dts_probe(AVProbeData *p)
{
const uint8_t *buf, *bufp;
-uint32_t state = -1;
+uint32_t state = 0x;
int markers[3] = {0};
int sum, max;
--
1.7.9.5
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] 0.9 release
On 09/11/2012 10:32 AM, Diego Biurrun wrote: It would be nice if we could get at least shared lib linking with MSVC before 0.9 is released. Releasing half-working MSVC support seems... meh. Nobody appears to have started working on this, Not true. I'm all for waiting until shared libs are working. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 08/11] mpegaudioenc: use planar sample format
On 09/11/2012 06:32 AM, Ronald S. Bultje wrote: Hi, On Sat, Aug 25, 2012 at 8:01 PM, Justin Ruggles wrote: --- libavcodec/mpegaudioenc.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) Is there a speed loss / gain with common tasks (e.g. playback)? My understanding for most of these was that the interleaving is a separate step in the decoder, which isn't the case here. So I'd actually expect a speed loss with this patch using e.g. avplay, which eventually needs interleaved audio. That wouldn't be a good thing imo. Ronald You just move the interleaving from one place to another. In the case where you work on planar data not doing any interleaving is faster. For example decoder -> encoder. In the case where you one decode and the playback the audio you might need to interleave the data and where you do it doesn't really matter, you still have to do it once. All in all the change is good. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 06/11] adpcmenc: move 'ch' variable to higher scope
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] cavsdsp: set idct permutation independently of dsputil
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] configure: Disable some more warnings in MSVC
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 5/5] svq1enc: Set picture_structure correctly
LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 4/5] mpegvideo: remove last_picture_ptr / h264 assert.
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/5] mpegvideo_enc: remove assert that has become obsolete with the new API
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/5] h264: disable assert on current_picture_ptr being null.
On 09/04/2012 03:20 PM, Martin Storsjö wrote:
From: Michael Niedermayer
It is possible in various error pathes as well as gap handling
that this has already been allocated. Its not clear why that
would be a problem with the current code, thus disable the
assert to avoid common assert failure when asserts are enabled.
---
libavcodec/h264.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/h264.c b/libavcodec/h264.c
index 2c4f07d..24c7a80 100644
--- a/libavcodec/h264.c
+++ b/libavcodec/h264.c
@@ -2773,7 +2773,7 @@ static int decode_slice_header(H264Context *h,
H264Context *h0)
}
} else {
/* Frame or first field in a potentially complementary pair */
-assert(!s0->current_picture_ptr);
+// assert(!s0->current_picture_ptr);
s0->first_field = FIELD_PICTURE;
}
Remove instead.
MvH
Benjamin Larsson
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] adpcmenc: Calculate the IMA_QT predictor without overflow
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] Optimization of decoders for MIPS.
On 08/25/2012 05:15 PM, Luca Barbato wrote: That said there isn't much we can do to help since mips hardware is sadly scarce lately. lu I have access to plenty of mips hardware. If anyone wants some send me a message. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/2] libavcodec: drop bogus dependencies from mpc[78] and qdm2
On 08/23/2012 09:30 PM, Måns Rullgård wrote: Benjamin Larsson writes: On 08/23/2012 07:52 PM, Mans Rullgard wrote: Signed-off-by: Mans Rullgard --- acelp_filters.o -OBJS-$(CONFIG_QDM2_DECODER)+= qdm2.o mpegaudiodec.o\ - mpegaudiodecheader.o mpegaudio.o \ - mpegaudiodata.o +OBJS-$(CONFIG_QDM2_DECODER)+= qdm2.o qdm2 needed the synth filter from the mpeg decoder is that not true anymore ? It uses it through mpegaudiodsp which is _selected in configure. OK /Benjamin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/2] libavcodec: drop bogus dependencies from mpc[78] and qdm2
On 08/23/2012 07:52 PM, Mans Rullgard wrote: Signed-off-by: Mans Rullgard --- acelp_filters.o -OBJS-$(CONFIG_QDM2_DECODER)+= qdm2.o mpegaudiodec.o\ - mpegaudiodecheader.o mpegaudio.o \ - mpegaudiodata.o +OBJS-$(CONFIG_QDM2_DECODER)+= qdm2.o qdm2 needed the synth filter from the mpeg decoder is that not true anymore ? MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] x86: remove FASTDIV inline asm
ping LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 3/3] vorbisenc: set AVCodecContext.bit_rate to 0
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/3] vorbisenc: fix quality parameter
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/3] vorbisenc: use float planar sample format
On 08/20/2012 07:37 PM, Justin Ruggles wrote: +const float * const *audio = frame ? (const float * const *)frame->extended_data : NULL; This looks insane. /Benjamin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] build: amrwb: Drop redundant lsp dependency declaration
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] x86: remove FASTDIV inline asm
On 08/18/2012 09:26 PM, Mans Rullgard wrote: GCC 4.3 and later do the right thing with the plain C code. Based on that patch is OK. MvH Benjamin Larsson ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] xtea: Fix doxygen comments
OK ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
