Re: [libav-devel] [PATCH] avutil: Add AVERROR_EXPERIMENTAL

2012-10-21 Thread Anton Khirnov 

On Sun, 21 Oct 2012 22:39:08 +0200, Luca Barbato  wrote:
> From: Nathan Caldwell 
> 
> Signed-off-by: Luca Barbato 
> ---
> 
> I used "feature" to describe what is experimental. Better wording welcome.
> 
>  doc/APIchanges  | 3 +++
>  libavutil/error.c   | 1 +
>  libavutil/error.h   | 1 +
>  libavutil/version.h | 2 +-
>  4 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 0c9a455..ed479df 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -13,6 +13,9 @@ libavutil: 2011-04-18
>  
>  API changes, most recent first:
>  
> +2012-10-18 - xxx - lavu 51.45.0 - error.h
> +  Add AVERROR_EXPERIMENTAL
> +
>  2012-10-12 - xxx - lavu 51.44.0 - pixdesc.h
>Add functions for accessing pixel format descriptors.
>Accessing the av_pix_fmt_descriptors array directly is now
> diff --git a/libavutil/error.c b/libavutil/error.c
> index c335cde..6803d2d 100644
> --- a/libavutil/error.c
> +++ b/libavutil/error.c
> @@ -41,6 +41,7 @@ int av_strerror(int errnum, char *errbuf, size_t 
> errbuf_size)
>  case AVERROR_STREAM_NOT_FOUND:  errstr = "Stream not found"  
>; break;
>  case AVERROR_BUG:   errstr = "Bug detected, please report 
> the issue"; break;
>  case AVERROR_UNKNOWN:   errstr = "Unknown error occurred"
>; break;
> +case AVERROR_EXPERIMENTAL:  errstr = "Experimental feature"  
>; break;
>  }
>  
>  if (errstr) {
> diff --git a/libavutil/error.h b/libavutil/error.h
> index 61d5fb9..3dfd880 100644
> --- a/libavutil/error.h
> +++ b/libavutil/error.h
> @@ -60,6 +60,7 @@
>  #define AVERROR_STREAM_NOT_FOUND   (-0x2dabac08) ///< Stream not found
>  #define AVERROR_BUG(-0x5fb8aabe) ///< Bug detected, please 
> report the issue
>  #define AVERROR_UNKNOWN(-0x31b4b1ab) ///< Unknown error, 
> typically from an external library
> +#define AVERROR_EXPERIMENTAL   (-0x2bb2afa8) ///< Requested feature is 
> flagged experimental. Set strict_std_compliance if you really want to use it.

I would move the commen to the error string.

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] avutil: Add AVERROR_EXPERIMENTAL

2012-10-21 Thread Luca Barbato 
From: Nathan Caldwell 

Signed-off-by: Luca Barbato 
---

I used "feature" to describe what is experimental. Better wording welcome.

 doc/APIchanges  | 3 +++
 libavutil/error.c   | 1 +
 libavutil/error.h   | 1 +
 libavutil/version.h | 2 +-
 4 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/doc/APIchanges b/doc/APIchanges
index 0c9a455..ed479df 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -13,6 +13,9 @@ libavutil: 2011-04-18
 
 API changes, most recent first:
 
+2012-10-18 - xxx - lavu 51.45.0 - error.h
+  Add AVERROR_EXPERIMENTAL
+
 2012-10-12 - xxx - lavu 51.44.0 - pixdesc.h
   Add functions for accessing pixel format descriptors.
   Accessing the av_pix_fmt_descriptors array directly is now
diff --git a/libavutil/error.c b/libavutil/error.c
index c335cde..6803d2d 100644
--- a/libavutil/error.c
+++ b/libavutil/error.c
@@ -41,6 +41,7 @@ int av_strerror(int errnum, char *errbuf, size_t errbuf_size)
 case AVERROR_STREAM_NOT_FOUND:  errstr = "Stream not found"
 ; break;
 case AVERROR_BUG:   errstr = "Bug detected, please report the 
issue"; break;
 case AVERROR_UNKNOWN:   errstr = "Unknown error occurred"  
 ; break;
+case AVERROR_EXPERIMENTAL:  errstr = "Experimental feature"
 ; break;
 }
 
 if (errstr) {
diff --git a/libavutil/error.h b/libavutil/error.h
index 61d5fb9..3dfd880 100644
--- a/libavutil/error.h
+++ b/libavutil/error.h
@@ -60,6 +60,7 @@
 #define AVERROR_STREAM_NOT_FOUND   (-0x2dabac08) ///< Stream not found
 #define AVERROR_BUG(-0x5fb8aabe) ///< Bug detected, please 
report the issue
 #define AVERROR_UNKNOWN(-0x31b4b1ab) ///< Unknown error, typically 
from an external library
+#define AVERROR_EXPERIMENTAL   (-0x2bb2afa8) ///< Requested feature is 
flagged experimental. Set strict_std_compliance if you really want to use it.
 
 /**
  * Put a description of the AVERROR code errnum in errbuf.
diff --git a/libavutil/version.h b/libavutil/version.h
index 4cc2f7c..4de2a94 100644
--- a/libavutil/version.h
+++ b/libavutil/version.h
@@ -37,7 +37,7 @@
  */
 
 #define LIBAVUTIL_VERSION_MAJOR 51
-#define LIBAVUTIL_VERSION_MINOR 44
+#define LIBAVUTIL_VERSION_MINOR 45
 #define LIBAVUTIL_VERSION_MICRO  0
 
 #define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
-- 
1.7.12

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel