Re: [libav-devel] [PATCH] configure: Revert some incorrect uses of check_cc()

2018-03-29 Thread James Almer
On 3/29/2018 4:28 AM, Diego Biurrun wrote:
> ---
> 
> Thanks to James for pointing this out.
> 
>  configure | 16 +++-
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/configure b/configure
> index 90fb6f07ca..a64f241560 100755
> --- a/configure
> +++ b/configure
> @@ -4841,7 +4841,9 @@ check_disable_warning_headers -Wno-unused-variable
>  
>  check_objcflags -fobjc-arc && enable objc_arc
>  
> -check_cc blocks_extension "" "void (^block)(void)"
> +test_cc < +void (^block)(void);
> +EOF
>  
>  # add some linker flags
>  check_ldflags -Wl,--warn-common
> @@ -4895,10 +4897,14 @@ if enabled proper_dce; then
>  if test_ldflags -Wl,${version_script},$TMPV; then
>  append SHFLAGS '-Wl,${version_script},\$(SUBDIR)lib\$(NAME).ver'
>  quotes='""'
> -check_cc symver_asm_label "" "void ff_foo(void) __asm__ 
> ("av_foo@VERSION");
> -  void ff_foo(void) { 
> ${inline_asm+__asm__($quotes);} }"
> -check_cc symver_gnu_asm   "" "__asm__(".symver 
> ff_foo,av_foo@VERSION");
> -  void ff_foo(void) {}"
> +test_cc < +void ff_foo(void) __asm__ ("av_foo@VERSION");
> +void ff_foo(void) { ${inline_asm+__asm__($quotes);} }
> +EOF
> +test_cc < +__asm__(".symver ff_foo,av_foo@VERSION");
> +void ff_foo(void) {}
> +EOF
>  fi
>  fi

LGTM
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] configure: Revert some incorrect uses of check_cc()

2018-03-29 Thread Luca Barbato

On 29/03/2018 09:28, Diego Biurrun wrote:

---

Thanks to James for pointing this out.

  configure | 16 +++-
  1 file changed, 11 insertions(+), 5 deletions(-)



Probably Ok.

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] configure: Revert some incorrect uses of check_cc()

2018-03-29 Thread Diego Biurrun
---

Thanks to James for pointing this out.

 configure | 16 +++-
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index 90fb6f07ca..a64f241560 100755
--- a/configure
+++ b/configure
@@ -4841,7 +4841,9 @@ check_disable_warning_headers -Wno-unused-variable
 
 check_objcflags -fobjc-arc && enable objc_arc
 
-check_cc blocks_extension "" "void (^block)(void)"
+test_cc