Re: [libav-devel] [PATCH] lavc/qsv: default la_ds to MFX_LOOKAHEAD_DS_UNKNOWN

2018-02-11 Thread Luca Barbato 

On 11/02/2018 13:40, Maxym Dmytrychenko wrote:

looks reasonable.



+1

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] lavc/qsv: default la_ds to MFX_LOOKAHEAD_DS_UNKNOWN

2018-02-11 Thread Maxym Dmytrychenko 
looks reasonable.

On Sun, Feb 11, 2018 at 8:43 AM, Ruiling Song 
wrote:

> MFX_LOOKAHEAD_DS_UNKNOWN means auto.
> -1 is not a valid value.
>
> Signed-off-by: Ruiling Song 
> ---
>  libavcodec/qsvenc.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h
> index 088a61d..6a8f119 100644
> --- a/libavcodec/qsvenc.h
> +++ b/libavcodec/qsvenc.h
> @@ -71,8 +71,9 @@
>  { "slow",   NULL, 0, AV_OPT_TYPE_CONST, { .i64 =
> MFX_TARGETUSAGE_BEST_QUALITY  }, INT_MIN, INT_MAX, VE, "preset" },
>\
>  { "la_depth", "Number of frames to analyze before encoding.",
> OFFSET(qsv.la_depth), AV_OPT_TYPE_INT, { .i64 = 9 },   9, 100, VE,
> "la_depth" },  \
>  { "unset", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 9 }, INT_MIN, INT_MAX,
>VE, "la_depth" },  \
> -{ "la_ds", "Downscaling factor for the frames saved for the lookahead
> analysis", OFFSET(qsv.la_ds), AV_OPT_TYPE_INT, { .i64 = -1 },   -1,
> MFX_LOOKAHEAD_DS_4x, VE, "la_ds" }, \
> -{ "auto", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = -1 }, INT_MIN, INT_MAX,
>VE, "la_ds" }, \
> +{ "la_ds", "Downscaling factor for the frames saved for the lookahead
> analysis", OFFSET(qsv.la_ds), AV_OPT_TYPE_INT,\
> +{ .i64 = MFX_LOOKAHEAD_DS_UNKNOWN },
> MFX_LOOKAHEAD_DS_UNKNOWN, MFX_LOOKAHEAD_DS_4x, VE, "la_ds" },
> \
> +{ "auto", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_LOOKAHEAD_DS_UNKNOWN
> }, INT_MIN, INT_MAX, VE, "la_ds" }, \
>  { "off", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_LOOKAHEAD_DS_OFF },
> INT_MIN, INT_MAX,  VE, "la_ds" }, \
>  { "2x", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_LOOKAHEAD_DS_2x },
> INT_MIN, INT_MAX,VE, "la_ds" },
> \
>  { "4x", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_LOOKAHEAD_DS_4x },
> INT_MIN, INT_MAX,VE, "la_ds" },
> \
> --
> 2.7.4
>
> ___
> libav-devel mailing list
> libav-devel@libav.org
> https://lists.libav.org/mailman/listinfo/libav-devel
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] lavc/qsv: default la_ds to MFX_LOOKAHEAD_DS_UNKNOWN

2018-02-10 Thread Ruiling Song 
MFX_LOOKAHEAD_DS_UNKNOWN means auto.
-1 is not a valid value.

Signed-off-by: Ruiling Song 
---
 libavcodec/qsvenc.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h
index 088a61d..6a8f119 100644
--- a/libavcodec/qsvenc.h
+++ b/libavcodec/qsvenc.h
@@ -71,8 +71,9 @@
 { "slow",   NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_TARGETUSAGE_BEST_QUALITY  
}, INT_MIN, INT_MAX, VE, "preset" }, \
 { "la_depth", "Number of frames to analyze before encoding.", 
OFFSET(qsv.la_depth), AV_OPT_TYPE_INT, { .i64 = 9 },   9, 100, VE, "la_depth" 
},  \
 { "unset", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 9 }, INT_MIN, INT_MAX, 
  VE, "la_depth" },  \
-{ "la_ds", "Downscaling factor for the frames saved for the lookahead 
analysis", OFFSET(qsv.la_ds), AV_OPT_TYPE_INT, { .i64 = -1 },   -1, 
MFX_LOOKAHEAD_DS_4x, VE, "la_ds" }, \
-{ "auto", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = -1 }, INT_MIN, INT_MAX, 
  VE, "la_ds" }, \
+{ "la_ds", "Downscaling factor for the frames saved for the lookahead 
analysis", OFFSET(qsv.la_ds), AV_OPT_TYPE_INT,\
+{ .i64 = MFX_LOOKAHEAD_DS_UNKNOWN }, 
MFX_LOOKAHEAD_DS_UNKNOWN, MFX_LOOKAHEAD_DS_4x, VE, "la_ds" },   
   \
+{ "auto", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_LOOKAHEAD_DS_UNKNOWN }, 
INT_MIN, INT_MAX, VE, "la_ds" }, \
 { "off", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_LOOKAHEAD_DS_OFF }, INT_MIN, 
INT_MAX,  VE, "la_ds" }, \
 { "2x", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_LOOKAHEAD_DS_2x }, INT_MIN, 
INT_MAX,VE, "la_ds" }, \
 { "4x", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_LOOKAHEAD_DS_4x }, INT_MIN, 
INT_MAX,VE, "la_ds" }, \
-- 
2.7.4

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel