[libav-devel] [PATCH] vp3dsp: don't do aligned reads on input.

2013-01-22 Thread Ronald S. Bultje 
From: Ronald S. Bultje rsbul...@gmail.com

The input is not guarenteed to be aligned.
---
 libavcodec/vp3dsp.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c
index 1883099..0ce6b81 100644
--- a/libavcodec/vp3dsp.c
+++ b/libavcodec/vp3dsp.c
@@ -282,11 +282,11 @@ static void put_no_rnd_pixels_l2(uint8_t *dst, const 
uint8_t *src1,
 for (i = 0; i  h; i++) {
 uint32_t a, b;
 
-a = AV_RN32A(src1[i * stride]);
-b = AV_RN32A(src2[i * stride]);
+a = AV_RN32(src1[i * stride]);
+b = AV_RN32(src2[i * stride]);
 AV_WN32A(dst[i * stride], no_rnd_avg32(a, b));
-a = AV_RN32A(src1[i * stride + 4]);
-b = AV_RN32A(src2[i * stride + 4]);
+a = AV_RN32(src1[i * stride + 4]);
+b = AV_RN32(src2[i * stride + 4]);
 AV_WN32A(dst[i * stride + 4], no_rnd_avg32(a, b));
 }
 }
-- 
1.8.0

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] vp3dsp: don't do aligned reads on input.

2013-01-22 Thread Martin Storsjö 

On Tue, 22 Jan 2013, Ronald S. Bultje wrote:


From: Ronald S. Bultje rsbul...@gmail.com

The input is not guarenteed to be aligned.
---
libavcodec/vp3dsp.c | 8 
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c
index 1883099..0ce6b81 100644
--- a/libavcodec/vp3dsp.c
+++ b/libavcodec/vp3dsp.c
@@ -282,11 +282,11 @@ static void put_no_rnd_pixels_l2(uint8_t *dst, const 
uint8_t *src1,
for (i = 0; i  h; i++) {
uint32_t a, b;

-a = AV_RN32A(src1[i * stride]);
-b = AV_RN32A(src2[i * stride]);
+a = AV_RN32(src1[i * stride]);
+b = AV_RN32(src2[i * stride]);
AV_WN32A(dst[i * stride], no_rnd_avg32(a, b));
-a = AV_RN32A(src1[i * stride + 4]);
-b = AV_RN32A(src2[i * stride + 4]);
+a = AV_RN32(src1[i * stride + 4]);
+b = AV_RN32(src2[i * stride + 4]);
AV_WN32A(dst[i * stride + 4], no_rnd_avg32(a, b));
}
}
--
1.8.0


Looks about right, I guess this will fix the fate failures on archs that 
don't support unaligned reads.


// Martin
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] vp3dsp: don't do aligned reads on input.

2013-01-22 Thread Luca Barbato 
On 22/01/13 21:45, Ronald S. Bultje wrote:
 From: Ronald S. Bultje rsbul...@gmail.com

 The input is not guarenteed to be aligned.

guaranteed

 ---
  libavcodec/vp3dsp.c | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)
 
 diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c
 index 1883099..0ce6b81 100644
 --- a/libavcodec/vp3dsp.c
 +++ b/libavcodec/vp3dsp.c
 @@ -282,11 +282,11 @@ static void put_no_rnd_pixels_l2(uint8_t *dst, const 
 uint8_t *src1,
  for (i = 0; i  h; i++) {
  uint32_t a, b;
  
 -a = AV_RN32A(src1[i * stride]);
 -b = AV_RN32A(src2[i * stride]);
 +a = AV_RN32(src1[i * stride]);
 +b = AV_RN32(src2[i * stride]);
  AV_WN32A(dst[i * stride], no_rnd_avg32(a, b));
 -a = AV_RN32A(src1[i * stride + 4]);
 -b = AV_RN32A(src2[i * stride + 4]);
 +a = AV_RN32(src1[i * stride + 4]);
 +b = AV_RN32(src2[i * stride + 4]);
  AV_WN32A(dst[i * stride + 4], no_rnd_avg32(a, b));
  }
  }
 

Patch ok.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel