[libav-devel] [PATCH 1/1] checkasm: fix MSVC build by adding a zero initializer for an empty array

2015-07-20 Thread Janne Grunau 
---
 tests/checkasm/h264pred.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/checkasm/h264pred.c b/tests/checkasm/h264pred.c
index a5eb033..6d59d8c 100644
--- a/tests/checkasm/h264pred.c
+++ b/tests/checkasm/h264pred.c
@@ -88,6 +88,7 @@ static const char * const pred8x8_modes[4][11] = {
 [TOP_DC_PRED8x8 ] = top_dc_rv40,
 },
 { /* SVQ3 */
+0,
 },
 };
 
-- 
2.4.6

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/1] checkasm: fix MSVC build by adding a zero initializer for an empty array

2015-07-20 Thread Janne Grunau 
On 2015-07-20 22:31:28 +0200, Henrik Gramner wrote:
 On Mon, Jul 20, 2015 at 11:58 AM, Janne Grunau janne-li...@jannau.net wrote:
  ---
   tests/checkasm/h264pred.c | 1 +
   1 file changed, 1 insertion(+)
 
 Shouldn't it be NULL instead of 0 since those are pointers?

only to make the intent clearer. it makes no difference to compilers, 
'0' is the null pointer constant and the array initialization clearly 
happens in pointer context.

I guess I'll just remove the empty array for SVQ3 (but not the comment)

Janne
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/1] checkasm: fix MSVC build by adding a zero initializer for an empty array

2015-07-20 Thread Henrik Gramner 
On Mon, Jul 20, 2015 at 11:58 AM, Janne Grunau janne-li...@jannau.net wrote:
 ---
  tests/checkasm/h264pred.c | 1 +
  1 file changed, 1 insertion(+)

Shouldn't it be NULL instead of 0 since those are pointers?

Otherwise OK.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel