Re: [libav-devel] [PATCH 20/25] lavf: Add non diegetic stream disposition flag

2017-06-29 Thread Vittorio Giovara 
On Thu, Jun 29, 2017 at 4:02 AM, Diego Biurrun  wrote:
> On Wed, Jun 28, 2017 at 06:11:04PM -0400, Vittorio Giovara wrote:
>> Signed-off-by: Vittorio Giovara 
>> ---
>>  libavformat/avformat.h | 6 ++
>>  libavformat/dump.c | 2 ++
>>  2 files changed, 8 insertions(+)
>
> non-diegetic
>
>> --- a/libavformat/dump.c
>> +++ b/libavformat/dump.c
>> @@ -482,6 +482,8 @@ static void dump_stream_format(AVFormatContext *ic, int 
>> i,
>>  if (st->disposition & AV_DISPOSITION_CLEAN_EFFECTS)
>>  av_log(NULL, AV_LOG_INFO, " (clean effects)");
>> +if (st->disposition & AV_DISPOSITION_NON_DIEGETIC)
>> +av_log(NULL, AV_LOG_INFO, " (non diegetic)");
>
> same

applied locally

-- 
Vittorio
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 20/25] lavf: Add non diegetic stream disposition flag

2017-06-29 Thread Diego Biurrun 
On Wed, Jun 28, 2017 at 06:11:04PM -0400, Vittorio Giovara wrote:
> Signed-off-by: Vittorio Giovara 
> ---
>  libavformat/avformat.h | 6 ++
>  libavformat/dump.c | 2 ++
>  2 files changed, 8 insertions(+)

non-diegetic

> --- a/libavformat/dump.c
> +++ b/libavformat/dump.c
> @@ -482,6 +482,8 @@ static void dump_stream_format(AVFormatContext *ic, int i,
>  if (st->disposition & AV_DISPOSITION_CLEAN_EFFECTS)
>  av_log(NULL, AV_LOG_INFO, " (clean effects)");
> +if (st->disposition & AV_DISPOSITION_NON_DIEGETIC)
> +av_log(NULL, AV_LOG_INFO, " (non diegetic)");

same

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 20/25] lavf: Add non diegetic stream disposition flag

2017-06-28 Thread Vittorio Giovara 
Signed-off-by: Vittorio Giovara 
---
 libavformat/avformat.h | 6 ++
 libavformat/dump.c | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/libavformat/avformat.h b/libavformat/avformat.h
index 1bf66b15d1..47f7a445dd 100644
--- a/libavformat/avformat.h
+++ b/libavformat/avformat.h
@@ -673,6 +673,12 @@ typedef struct AVIndexEntry {
  * It can also be accessed at any time in AVStream.attached_pic.
  */
 #define AV_DISPOSITION_ATTACHED_PIC  0x0400
+/**
+ * The stream is intended to be mixed with a spatial audio track. For example,
+ * it could be used for narration or stereo music, and may remain unchanged by
+ * listener head rotation.
+ */
+#define AV_DISPOSITION_NON_DIEGETIC 0x1000
 
 typedef struct AVStreamInternal AVStreamInternal;
 
diff --git a/libavformat/dump.c b/libavformat/dump.c
index e1f6848547..b29f0ad834 100644
--- a/libavformat/dump.c
+++ b/libavformat/dump.c
@@ -482,6 +482,8 @@ static void dump_stream_format(AVFormatContext *ic, int i,
 av_log(NULL, AV_LOG_INFO, " (visual impaired)");
 if (st->disposition & AV_DISPOSITION_CLEAN_EFFECTS)
 av_log(NULL, AV_LOG_INFO, " (clean effects)");
+if (st->disposition & AV_DISPOSITION_NON_DIEGETIC)
+av_log(NULL, AV_LOG_INFO, " (non diegetic)");
 av_log(NULL, AV_LOG_INFO, "\n");
 
 dump_metadata(NULL, st->metadata, "");
-- 
2.13.1

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel