Re: [libav-devel] [PATCH 4/5] configure: Miscellaneous minor changes to config file handling

2017-11-02 Thread Diego Biurrun 
On Thu, Nov 02, 2017 at 12:00:39AM +0200, Martin Storsjö wrote:
> On Thu, 26 Oct 2017, Diego Biurrun wrote:
> 
> > - Move generating config.fate to a more sensible place.
> > - Move printing warnings to a more appropriate place.
> > - Improve "generated by" comment in libavutil/avconfig.h.
> > - Drop pointless informative output about generating config files.
> > - Write a standard comment header to config.asm as well.
> > ---
> > configure | 24 
> > 1 file changed, 12 insertions(+), 12 deletions(-)
> 
> Probably ok, assuming that the new location for printing warnings isn't so
> far up that it might get missed.

The warnings appear in the exact same place of the configure output. Only
the internal position of the code that prints the warnings has changed.

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 4/5] configure: Miscellaneous minor changes to config file handling

2017-11-01 Thread Martin Storsjö 

On Thu, 26 Oct 2017, Diego Biurrun wrote:


- Move generating config.fate to a more sensible place.
- Move printing warnings to a more appropriate place.
- Improve "generated by" comment in libavutil/avconfig.h.
- Drop pointless informative output about generating config files.
- Write a standard comment header to config.asm as well.
---
configure | 24 
1 file changed, 12 insertions(+), 12 deletions(-)


Probably ok, assuming that the new location for printing warnings isn't so 
far up that it might get missed.


// Martin
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 4/5] configure: Miscellaneous minor changes to config file handling

2017-10-26 Thread Diego Biurrun 
- Move generating config.fate to a more sensible place.
- Move printing warnings to a more appropriate place.
- Improve "generated by" comment in libavutil/avconfig.h.
- Drop pointless informative output about generating config files.
- Write a standard comment header to config.asm as well.
---
 configure | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/configure b/configure
index 8b35d565e6..9f23883bca 100755
--- a/configure
+++ b/configure
@@ -4105,12 +4105,6 @@ esac
 check_compile_assert flt_lim "float.h limits.h" "DBL_MAX == (double)DBL_MAX" ||
 add_cppflags '-I\$(SRC_PATH)/compat/float'
 
-esc(){
-echo "$*" | sed 's/%/%25/g;s/:/%3a/g'
-}
-
-echo "config:$arch:$subarch:$cpu:$target_os:$(esc $cc_ident):$(esc 
$LIBAV_CONFIGURATION)" > avbuild/config.fate
-
 check_cpp_condition stdlib.h "defined(__PIC__) || defined(__pic__) || 
defined(PIC)" && enable_weak pic
 
 set_default $PATHS_LIST
@@ -5188,12 +5182,18 @@ fi
 
 echo "License: $license"
 
-echo "Creating configuration files ..."
-
 fi # test "$quiet" != "yes"
 
+test -n "$WARNINGS" && printf "\n$WARNINGS"
+
 test -e Makefile || echo "include $source_path/Makefile" > Makefile
 
+esc(){
+echo "$*" | sed 's/%/%25/g;s/:/%3a/g'
+}
+
+echo "config:$arch:$subarch:$cpu:$target_os:$(esc $cc_ident):$(esc 
$LIBAV_CONFIGURATION)" > avbuild/config.fate
+
 config_files="$TMPH avbuild/config.mak"
 
 cat > avbuild/config.mak <$TMPASM
+cat > $TMPASM <> $TMPH
@@ -5353,7 +5355,7 @@ touch avbuild/.config
 enabled x86asm && cp_if_changed $TMPASM config.asm
 
 cat > $TMPH < avbuild/config.sh