Re: [libav-devel] [PATCH 2/3] lavc/vaapi: Add VP8 decode hwaccel

2016-09-06 Thread Luca Barbato 
On 06/09/16 23:19, Mark Thompson wrote:
> On 06/09/16 21:54, Mark Thompson wrote:
>> ---
>>  configure  |   2 +
>>  libavcodec/Makefile|   1 +
>>  libavcodec/allcodecs.c |   1 +
>>  libavcodec/vaapi_vp8.c | 231 
>> +
>>  libavcodec/vp8.c   |   3 +
>>  5 files changed, 238 insertions(+)
>>  create mode 100644 libavcodec/vaapi_vp8.c
>>
>> diff --git a/configure b/configure
>> index 7ad920f4..1026ba6 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2185,6 +2185,8 @@ vc1_vaapi_hwaccel_deps="vaapi"
>>  vc1_vaapi_hwaccel_select="vc1_decoder"
>>  vc1_vdpau_hwaccel_deps="vdpau"
>>  vc1_vdpau_hwaccel_select="vc1_decoder"
>> +vp8_vaapi_hwaccel_deps="vaapi"
>> +vp8_vaapi_hwaccel_select="vp8_decoder"
>>  wmv3_d3d11va_hwaccel_select="vc1_d3d11va_hwaccel"
>>  wmv3_dxva2_hwaccel_select="vc1_dxva2_hwaccel"
>>  wmv3_vaapi_hwaccel_select="vc1_vaapi_hwaccel"
> 
> We need a further check here: VP8 decoding was introduced in libva 1.3.0 
> (VAAPI 0.35).
> 


Sounds fine.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/3] lavc/vaapi: Add VP8 decode hwaccel

2016-09-06 Thread Mark Thompson 
On 06/09/16 21:54, Mark Thompson wrote:
> ---
>  configure  |   2 +
>  libavcodec/Makefile|   1 +
>  libavcodec/allcodecs.c |   1 +
>  libavcodec/vaapi_vp8.c | 231 
> +
>  libavcodec/vp8.c   |   3 +
>  5 files changed, 238 insertions(+)
>  create mode 100644 libavcodec/vaapi_vp8.c
> 
> diff --git a/configure b/configure
> index 7ad920f4..1026ba6 100755
> --- a/configure
> +++ b/configure
> @@ -2185,6 +2185,8 @@ vc1_vaapi_hwaccel_deps="vaapi"
>  vc1_vaapi_hwaccel_select="vc1_decoder"
>  vc1_vdpau_hwaccel_deps="vdpau"
>  vc1_vdpau_hwaccel_select="vc1_decoder"
> +vp8_vaapi_hwaccel_deps="vaapi"
> +vp8_vaapi_hwaccel_select="vp8_decoder"
>  wmv3_d3d11va_hwaccel_select="vc1_d3d11va_hwaccel"
>  wmv3_dxva2_hwaccel_select="vc1_dxva2_hwaccel"
>  wmv3_vaapi_hwaccel_select="vc1_vaapi_hwaccel"

We need a further check here: VP8 decoding was introduced in libva 1.3.0 (VAAPI 
0.35).

Changed to:

diff --git a/configure b/configure
index 7ad920f4..520f07c 100755
--- a/configure
+++ b/configure
@@ -2185,6 +2185,8 @@ vc1_vaapi_hwaccel_deps="vaapi"
 vc1_vaapi_hwaccel_select="vc1_decoder"
 vc1_vdpau_hwaccel_deps="vdpau"
 vc1_vdpau_hwaccel_select="vc1_decoder"
+vp8_vaapi_hwaccel_deps="vaapi VAPictureParameterBufferVP8"
+vp8_vaapi_hwaccel_select="vp8_decoder"
 wmv3_d3d11va_hwaccel_select="vc1_d3d11va_hwaccel"
 wmv3_dxva2_hwaccel_select="vc1_dxva2_hwaccel"
 wmv3_vaapi_hwaccel_select="vc1_vaapi_hwaccel"
@@ -4544,6 +4546,7 @@ check_type "windows.h dxva.h" "DXVA_PicParams_HEVC" 
-DWINAPI_FAMILY=WINAPI_FAMIL
 check_type "windows.h d3d11.h" "ID3D11VideoDecoder"
 check_type "d3d9.h dxva2api.h" DXVA2_ConfigPictureDecode -D_WIN32_WINNT=0x0602

+check_type "va/va.h va/va_dec_vp8.h" "VAPictureParameterBufferVP8"
 check_type "va/va.h va/va_vpp.h" "VAProcPipelineParameterBuffer"
 check_type "va/va.h va/va_enc_h264.h" "VAEncPictureParameterBufferH264"
 check_type "va/va.h va/va_enc_hevc.h" "VAEncPictureParameterBufferHEVC"

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/3] lavc/vaapi: Add VP8 decode hwaccel

2016-09-06 Thread Anton Khirnov 
Quoting Mark Thompson (2016-09-04 14:46:37)
> ---
> Tested on Skylake.
> 
> Passes the conformance tests, except for 6 and 14 (the ones with odd frame 
> dimensions).

Looks ok other than the stuff already mentioned.

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/3] lavc/vaapi: Add VP8 decode hwaccel

2016-09-04 Thread Mark Thompson 
On 04/09/16 14:49, Diego Biurrun wrote:
> On Sun, Sep 04, 2016 at 01:46:37PM +0100, Mark Thompson wrote:
>> --- /dev/null
>> +++ b/libavcodec/vaapi_vp8.c
>> @@ -0,0 +1,225 @@
>> +/*
>> + * This file is part of FFmpeg.
> 
> Nah ;)

Oops, fixed.  (Much of this was written months ago, I just dug it out and made 
it actually work now.)

> +#include "libavutil/avassert.h"

Also removed, it was only there for testing and isn't actually used in the 
final version.

- Mark

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/3] lavc/vaapi: Add VP8 decode hwaccel

2016-09-04 Thread Diego Biurrun 
On Sun, Sep 04, 2016 at 01:46:37PM +0100, Mark Thompson wrote:
> --- /dev/null
> +++ b/libavcodec/vaapi_vp8.c
> @@ -0,0 +1,225 @@
> +/*
> + * This file is part of FFmpeg.

Nah ;)

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel