Re: [Libdbi-drivers-devel] sqlite3 leaks
On Thu, 2008-08-14 at 12:53 +0200, Markus Hoenicka wrote: Quoting Balazs Scheidler [EMAIL PROTECTED]: hi, I've found some leaks in the sqlite3 driver. As the code in question is difficult to understand and easy to break (for me), I'd like to request a review before I go on and commit it. Are you using the current cvs revision? I've checked in two patches just yesterday which may affect the code you are about to fix. If you are using the latest code, I'll have a look at your patches tonight. I was trying to run the testsuite this time, but without much success. As it seems the tests subdirectory is not even referenced in the root Makefile and neither from the configure script. So no Makefile is generated for it. The test suite has been present from day one and should run by just typing make check in the top level directory. It worked just fine on my box yesterday. I'll try a fresh checkout tonight to see if something is missing in the cvs repository. hmm.. How does the tests/Makefile.am get processed? As far as I know, it should be present in AC_OUTPUT() in configure.in, but it doesn't. It should also be present in root's Makefile.am listed as a SUBDIR, but again I can't see it there. I'm looking at our local git repository where you CVS repository is imported into. Ahh.. I think I've found the culprit. There's a test program in the libdbi repository, and you are probably talking about libdbi-drivers. In that repo, I can see how it gets processed. Sorry for the noise. (although it would probably be nice to remove the test-dbi program from libdbi as it does not work there). -- Bazsi - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ Libdbi-drivers-devel mailing list Libdbi-drivers-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libdbi-drivers-devel
Re: [Libdbi-drivers-devel] sqlite3 leaks
Quoting Balazs Scheidler [EMAIL PROTECTED]: (although it would probably be nice to remove the test-dbi program from libdbi as it does not work there). That's a good point. The test program is a leftover from the times when libdbi shipped the mysql and pgsql drivers. Now that all drivers are in the libdbi-drivers project, libdbi does not have much to test. I'll put that on my todo list. regards, Markus -- Markus Hoenicka [EMAIL PROTECTED] (Spam-protected email: replace the quadrupeds with mhoenicka) http://www.mhoenicka.de - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ Libdbi-drivers-devel mailing list Libdbi-drivers-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libdbi-drivers-devel
Re: [Libdbi-drivers-devel] sqlite3 leaks
Quoting Balazs Scheidler [EMAIL PROTECTED]: hi, I've found some leaks in the sqlite3 driver. As the code in question is difficult to understand and easy to break (for me), I'd like to request a review before I go on and commit it. Are you using the current cvs revision? I've checked in two patches just yesterday which may affect the code you are about to fix. If you are using the latest code, I'll have a look at your patches tonight. I was trying to run the testsuite this time, but without much success. As it seems the tests subdirectory is not even referenced in the root Makefile and neither from the configure script. So no Makefile is generated for it. The test suite has been present from day one and should run by just typing make check in the top level directory. It worked just fine on my box yesterday. I'll try a fresh checkout tonight to see if something is missing in the cvs repository. regards, Markus -- Markus Hoenicka [EMAIL PROTECTED] (Spam-protected email: replace the quadrupeds with mhoenicka) http://www.mhoenicka.de - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ Libdbi-drivers-devel mailing list Libdbi-drivers-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libdbi-drivers-devel
