Re: libev-4.27 timeout not being respected?

2019-08-28 Thread Marc Lehmann
On Wed, Aug 28, 2019 at 10:30:36AM +1200, Samuel Williams 
 wrote:
> We noticed some regressions in timeout handling in libev-4.27 vs 4.25
> 
> I am just starting to investigate, but I thought I'd start a discussion
> here too.

There shouldn't be any intentional changes to timer handling, but bugs can
always creep in, of course. Without knowing what regressions you see, it
is a bit moot to discuss.

> In addition, some changes to the source code are generating a lot of
> warnings. You can see the test failures and warnings here:

Well, which changes specifically? I only get one warning with current
versions of gcc, so you probably use another compiler with its own
warnings or enable extra warnings tailored to your specific coding style
or needs.

You can read a bit more about this in the documentation:

http://pod.tst.eu/http://cvs.schmorp.de/libev/ev.pod#COMPILER_WARNINGS


-- 
The choice of a   Deliantra, the free code+content MORPG
  -==- _GNU_  http://www.deliantra.net
  ==-- _   generation
  ---==---(_)__  __   __  Marc Lehmann
  --==---/ / _ \/ // /\ \/ /  schm...@schmorp.de
  -=/_/_//_/\_,_/ /_/\_\

___
libev mailing list
libev@lists.schmorp.de
http://lists.schmorp.de/mailman/listinfo/libev


Re: libev-4.27 timeout not being respected?

2019-08-27 Thread Samuel Williams
Okay - on the timeout issue, after investigating, I found it was a bug with
our local modifications to libev. It's fixed now, and the issue has gone
away.

Regarding the warnings, there are still a lot of them. Maybe worth a casual
glance to see if anything worth fixing.

Kind regards,
Samuel

On Wed, 28 Aug 2019 at 10:30, Samuel Williams <
space.ship.travel...@gmail.com> wrote:

> We noticed some regressions in timeout handling in libev-4.27 vs 4.25
>
> I am just starting to investigate, but I thought I'd start a discussion
> here too.
>
> In addition, some changes to the source code are generating a lot of
> warnings. You can see the test failures and warnings here:
>
> https://travis-ci.org/socketry/nio4r/jobs/577582532
>
> Kind regards,
> Samuel
>
___
libev mailing list
libev@lists.schmorp.de
http://lists.schmorp.de/mailman/listinfo/libev


libev-4.27 timeout not being respected?

2019-08-27 Thread Samuel Williams
We noticed some regressions in timeout handling in libev-4.27 vs 4.25

I am just starting to investigate, but I thought I'd start a discussion
here too.

In addition, some changes to the source code are generating a lot of
warnings. You can see the test failures and warnings here:

https://travis-ci.org/socketry/nio4r/jobs/577582532

Kind regards,
Samuel
___
libev mailing list
libev@lists.schmorp.de
http://lists.schmorp.de/mailman/listinfo/libev