Re: [Libguestfs] [PATCH] v2v: Add attribute containing disk virtual size.

[Pino Toscano]

On Monday, 18 June 2018 11:41:32 CEST Richard W.M. Jones wrote:
> Required ever since this change was made to oVirt:
> https://gerrit.ovirt.org/#/c/91902/
> 
> Thanks: Arik Hadas
> ---

It looks compatible with oVirt before the aforementioned patch, so
LGTM.

Thanks,
-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.
___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [PATCH] v2v: Add attribute containing disk virtual size.

[Richard W.M. Jones]

Required ever since this change was made to oVirt:
https://gerrit.ovirt.org/#/c/91902/

Thanks: Arik Hadas
---
 v2v/create_ovf.ml| 1 +
 v2v/test-v2v-o-rhv.ovf.expected  | 2 +-
 v2v/test-v2v-o-vdsm-options.ovf.expected | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/v2v/create_ovf.ml b/v2v/create_ovf.ml
index ac3c61b13..e0f81e0a2 100644
--- a/v2v/create_ovf.ml
+++ b/v2v/create_ovf.ml
@@ -835,6 +835,7 @@ and add_disks targets guestcaps output_alloc sd_uuid 
image_uuids vol_uuids
   | OVirt -> image_uuid
   | RHVExportStorageDomain -> vol_uuid);
   "ovf:size", Int64.to_string size_gb;
+  "ovf:capacity", Int64.to_string ov.ov_virtual_size;
   "ovf:fileRef", fileref;
   "ovf:parentRef", "";
   "ovf:vm_snapshot_id", uuidgen ();
diff --git a/v2v/test-v2v-o-rhv.ovf.expected b/v2v/test-v2v-o-rhv.ovf.expected
index 342eb99d3..1deec9c9d 100644
--- a/v2v/test-v2v-o-rhv.ovf.expected
+++ b/v2v/test-v2v-o-rhv.ovf.expected
@@ -10,7 +10,7 @@
   
   
 List of Virtual Disks
-
+
   
   
 windows
diff --git a/v2v/test-v2v-o-vdsm-options.ovf.expected 
b/v2v/test-v2v-o-vdsm-options.ovf.expected
index af1ca01db..c2a3e336c 100644
--- a/v2v/test-v2v-o-vdsm-options.ovf.expected
+++ b/v2v/test-v2v-o-vdsm-options.ovf.expected
@@ -10,7 +10,7 @@
   
   
 List of Virtual Disks
-
+
   
   
 windows
-- 
2.16.2

___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs