Re: [Libguestfs] [PATCH nbdkit 0/2 v2] golang: Compile against the local nbdkit build.

2020-04-23 Thread Daniel P . Berrangé 
On Thu, Apr 23, 2020 at 07:04:13PM +0100, Richard W.M. Jones wrote:
> Version 1 was here:
> https://www.redhat.com/archives/libguestfs/2020-April/thread.html#00160
> 
> Version 2 side-steps the objections to the first patch by using a
> well-formed alternate nbdkit.pc file and running ordinary pkg-config
> against it, so any parsing of --cflags etc will be done by pkg-config.
> 
> The first patch is essentially the same idea as:
> 
> https://github.com/libguestfs/libnbd/commit/dc87a1a6d6918ac5477e1d6b225998ff7fedc86e
> 
> (which follows on from similar tricks in libguestfs and libvirt).

For both patches

Reviewed-by: Daniel P. Berrangé 

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [PATCH nbdkit 0/2 v2] golang: Compile against the local nbdkit build.

2020-04-23 Thread Richard W.M. Jones 
Version 1 was here:
https://www.redhat.com/archives/libguestfs/2020-April/thread.html#00160

Version 2 side-steps the objections to the first patch by using a
well-formed alternate nbdkit.pc file and running ordinary pkg-config
against it, so any parsing of --cflags etc will be done by pkg-config.

The first patch is essentially the same idea as:

https://github.com/libguestfs/libnbd/commit/dc87a1a6d6918ac5477e1d6b225998ff7fedc86e

(which follows on from similar tricks in libguestfs and libvirt).

Rich.


___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs