On Mon, May 15, 2023 at 07:55:29PM +0200, Laszlo Ersek wrote:
> In the LUKS-on-LVM conversion test, repeat the null conversion with such
> "--key" options that exercise the recent "/dev/mapper/VG-LV" ->
> "/dev/VG/LV" translation (unescaping) from libguestfs-common.
>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2168506
> Signed-off-by: Laszlo Ersek
> ---
> tests/test-v2v-fedora-luks-on-lvm-conversion.sh | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tests/test-v2v-fedora-luks-on-lvm-conversion.sh
> b/tests/test-v2v-fedora-luks-on-lvm-conversion.sh
> index 7ad17e0d827f..605b19fb523a 100755
> --- a/tests/test-v2v-fedora-luks-on-lvm-conversion.sh
> +++ b/tests/test-v2v-fedora-luks-on-lvm-conversion.sh
> @@ -34,3 +34,10 @@ keys=(--key /dev/Volume-Group/Root:key:FEDORA-Root
>--key /dev/Volume-Group/Logical-Volume-3:key:FEDORA-LV3)
>
> $VG virt-v2v --debug-gc -i disk $f -o null "${keys[@]}"
> +
> +keys=(--key /dev/mapper/Volume--Group-Root:key:FEDORA-Root
> + --key /dev/mapper/Volume--Group-Logical--Volume--1:key:FEDORA-LV1
> + --key /dev/mapper/Volume--Group-Logical--Volume--2:key:FEDORA-LV2
> + --key /dev/mapper/Volume--Group-Logical--Volume--3:key:FEDORA-LV3)
> +
> +$VG virt-v2v --debug-gc -i disk $f -o null "${keys[@]}"
Yup all good:
Reviewed-by: Richard W.M. Jones
However I think the common/ patch needs to use PCRE2.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
___
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
