Re: [Libhugetlbfs-devel] [PATCH] Makefile: Recognize all ix86 arches
On Thu, 06 Nov 2014, Gary S. Robertson wrote: From: Gary S. Robertson gary.robert...@linaro.org The makefile only recognized i386 or x86_64 arches. Added support to recognize i486, i586, i686. Signed-off-by: Gary S. Robertson gary.robert...@linaro.org --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 91502e1..0bfaee8 100644 --- a/Makefile +++ b/Makefile @@ -71,7 +71,7 @@ ELF64 = aarch64elf TMPLIB64 = lib64 CUSTOM_LDSCRIPTS = no else -ifeq ($(ARCH),i386) +ifneq (,$(filter i386 i486 i586 i686,$(ARCH))) This is not necessary, line 35 of the Makfile covers the i.86 case. CC32 = $(CC) ELF32 = elf_i386 TMPLIB32 = lib -- 1.7.9.5 -- ___ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel signature.asc Description: Digital signature -- ___ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
Re: [Libhugetlbfs-devel] [PATCH] Makefile: Recognize all ix86 arches
Wow! Thanks for the quick response - I had not noticed line 35 in the Makefile - looks like it should take care of the issue, all right. However, when I run a make for the x86 in our OE build (they specify ARCH=i586), I get the following failure without this patch: DEBUG: Executing shell function do_compile NOTE: make ARCH=i586 OPT= -O2 -pipe -g -feliminate-unused-debug-types -fexpensive-optimizations -frename-registers -fomit-frame-pointer -g0 CC=i586-oe-linux-gcc -m32 -march=i586 -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed --sysroot=/volatile/jenkins-setup/build-qemux86/tmp-glibc/sysroots/qemux86 LIB32=lib LIB64=lib BUILDTYPE=NATIVEONLY V=2 Makefile:108: *** Unrecognized architecture (i586). Stop. ERROR: oe_runmake failed WARNING: exit code 1 from a shell command. With the patch in place the make operation succeeds. Gary R. On Thu, Nov 6, 2014 at 12:13 PM, Eric B Munson emun...@mgebm.net wrote: On Thu, 06 Nov 2014, Gary S. Robertson wrote: From: Gary S. Robertson gary.robert...@linaro.org The makefile only recognized i386 or x86_64 arches. Added support to recognize i486, i586, i686. Signed-off-by: Gary S. Robertson gary.robert...@linaro.org --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 91502e1..0bfaee8 100644 --- a/Makefile +++ b/Makefile @@ -71,7 +71,7 @@ ELF64 = aarch64elf TMPLIB64 = lib64 CUSTOM_LDSCRIPTS = no else -ifeq ($(ARCH),i386) +ifneq (,$(filter i386 i486 i586 i686,$(ARCH))) This is not necessary, line 35 of the Makfile covers the i.86 case. CC32 = $(CC) ELF32 = elf_i386 TMPLIB32 = lib -- 1.7.9.5 -- ___ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel -- ___ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
Re: [Libhugetlbfs-devel] [PATCH] Makefile: Recognize all ix86 arches
Ahh! Looking again at line 35 I see that it depends on the arch of the host operating system and thus doesn't work in the cross-compile environment. On Thu, Nov 6, 2014 at 3:23 PM, Gary Robertson gary.robert...@linaro.org wrote: Wow! Thanks for the quick response - I had not noticed line 35 in the Makefile - looks like it should take care of the issue, all right. However, when I run a make for the x86 in our OE build (they specify ARCH=i586), I get the following failure without this patch: DEBUG: Executing shell function do_compile NOTE: make ARCH=i586 OPT= -O2 -pipe -g -feliminate-unused-debug-types -fexpensive-optimizations -frename-registers -fomit-frame-pointer -g0 CC=i586-oe-linux-gcc -m32 -march=i586 -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed --sysroot=/volatile/jenkins-setup/build-qemux86/tmp-glibc/sysroots/qemux86 LIB32=lib LIB64=lib BUILDTYPE=NATIVEONLY V=2 Makefile:108: *** Unrecognized architecture (i586). Stop. ERROR: oe_runmake failed WARNING: exit code 1 from a shell command. With the patch in place the make operation succeeds. Gary R. On Thu, Nov 6, 2014 at 12:13 PM, Eric B Munson emun...@mgebm.net wrote: On Thu, 06 Nov 2014, Gary S. Robertson wrote: From: Gary S. Robertson gary.robert...@linaro.org The makefile only recognized i386 or x86_64 arches. Added support to recognize i486, i586, i686. Signed-off-by: Gary S. Robertson gary.robert...@linaro.org --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 91502e1..0bfaee8 100644 --- a/Makefile +++ b/Makefile @@ -71,7 +71,7 @@ ELF64 = aarch64elf TMPLIB64 = lib64 CUSTOM_LDSCRIPTS = no else -ifeq ($(ARCH),i386) +ifneq (,$(filter i386 i486 i586 i686,$(ARCH))) This is not necessary, line 35 of the Makfile covers the i.86 case. CC32 = $(CC) ELF32 = elf_i386 TMPLIB32 = lib -- 1.7.9.5 -- ___ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel -- ___ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
