Re: [Libreoffice] Merge changes from OOO330_m9
Michael Meeks wrote: Yes, good idea. But why bail out - can't we just ./download from the makefile? Urk - not an ideal solution IMHO ;-) I would prefer a clean exit, rather than having the build need a network connection to download things personally. Hm - but we need the download anyway? And do so later on inside rawbuild potentially? If a packager puts all the pieces in, there'll be no download. If the occasional hacker starts a build has to manually type in all kinds of non-standard things (like ./download), likely after returning to his terminal after a while - wouldn't he be pleased to have make take care of all the prerequisites? Cheers, -- Thorsten pgpuYHT5LpcRW.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Merge changes from OOO330_m9
Hi Michael, On 2010-10-06 at 22:53 +0100, Michael Meeks wrote: Please note that you might experience a build breakage in sdext - please rm unxlng*.pro in sdext (or the appropriate windows version of that), clean build seems to work fine. I guess we should fix these build dependency problems properly when we find them - if at all possible. I also fell over the 'more_fonts' problem as well (again). I'd prefer if somebody else than the one doing the update does that, because with the pace of the changes, one has to be quick with the push of the bigger change, like the merge from OOo :-) But generally yes, great idea - smooth transition is really what we need. Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] auto-download during make ...
Michael Meeks wrote: And do so later on inside rawbuild potentially ? Urk ? surely not. and In general it is so dangerous for repeatability for packagers to have the build randomly downloading things, and is so unexpected for users that I don't believe we should do it ;-) Right - missed the fact that we indeed do not set DO_FETCH_TARBALLS, so no auto-download from rawbuild's bootstrap - so let me withdraw the proposal, it's consistent then. :) OTOH - pushing onto the agenda for the next tech call. Not needed, I think. Cheers, -- Thorsten pgpD2Z3h6City.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] fixguard.py
calla...@xmission.com píše v Út 05. 10. 2010 v 22:07 -0600: I forgot to add that on the last one the replacement pattern is the empty string rather than \\1. Grr, you are right. Unfortunately, I did it in a hurry and did not remove the commented out headers. Well, there were not that many removed lines, so it not that big loss. Also I see that there are comments above some commented out includes. It would be better to remove them at the same time which is the other easy task ;-) Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Some more features
On Thu, Oct 07, 2010 at 12:42:01PM +0100, Michael Meeks michael.me...@novell.com wrote: Oooh ! :-) do we have old, obsolete, and non-compiled code in git master ? Does that make sense ? can we remove the old RTF cruft that we no longer use ? That's right - when the RTF rework was a patch I just removed old files from the makfiles, then they didn't get removed when the patch was moved to the repos. I think Cedric will fix this - though if I should do it, please let me know. Thanks. pgptp40B2DRj0.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Some more features
Hi Miklos, Michael, On Thu, 2010-10-07 at 16:10 +0200, Miklos Vajna wrote: I think Cedric will fix this - though if I should do it, please let me know. I just removed those files in sw/source/filter/rtf/. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] splitrepos query
Would *splitting* an existing dir/module across two repos would be a real pain or trivial ?, e.g. moving say just part of the java dir of libs-core/scripting out of from libs-core/scripting into something like extensions/scriptingproviders I've no immediate need to do that, just curious if it's a trivial or difficult thing to achieve. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] cppcheck error in sal/osl/unx/profile.c
On Thu, 2010-10-07 at 17:18 +0300, Harri Pitkänen wrote: This patch closes a file that would be left open if memory allocation fails. The cppcheck error was [profile.c:248]: (error) Memory leak: pFile Harri Thanks for the nice patch, looked good to me, pushed regards, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Some more features...
On Thu, 2010-10-07 at 10:28 -0400, Kohei Yoshida wrote: Having said that, once we remove this, it won't be easy to add it back. So I'd personally like to be a bit careful on making decision here. For example, can anybody provide any arguments for keeping the current behavior? No, +1 for removal Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Some more features...
- Kohei Yoshida kyosh...@novell.com a écrit : [...] No disagreement there. I would be among the first ones to support removal of this cruft. Great :-) Having said that, once we remove this, it won't be easy to add it back. So I'd personally like to be a bit careful on making decision here. I completely agree with you here. That's why I was happy but when Caolán McNamara implemented yesterday a change I had been wainting for (no auto conversion of numbers in Writer's tables by default) but also worried that it hadn't been validated at UX level. I think it would be good for everyone if we can reach a broad consensus on this, including from OOo's UX team. I have started formalizing my arguments in favour of this change there : http://wiki.services.openoffice.org/wiki/User:Camillem/aboutFramework#Read_Only_files_should_be_open_in_R.2FW_mode For example, can anybody provide any arguments for keeping the current behavior? That's also what I'd like to know. I'll post on OOoUX list about that tonight. Cheers, Camille ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] LDFLAGS break configure
ArchLinux has preset LDFLAGS=-Wl,--hash-style=gnu -Wl,--as-needed. I have to unset LDFLAGS to pass configure. It breaks build: PROPAGATED_ARGS=' '\''--with-distro=ArchLinux'\'' '\''--with-build-version=3.2.99.1 ArchLinux build-2 (ooo330-m7)'\'' '\''--without-git'\'' '\''--with-srcdir=/build/src'\'' '\''--with-max-jobs=5'\'' '\''--with-installed-libreoffice-dirname=libreoffice'\'' '\''--prefix=/usr'\'' '\''--exec-prefix=/usr'\'' '\''--sysconfdir=/etc'\'' '\''--with-docdir=/usr/share/doc/packages/libreoffice'\'' '\''--mandir=/usr/share/man'\'' '\''--with-lang='\'' '\''--with-dict=ALL'\'' '\''--with-binsuffix=no'\'' '\''--enable-cairo'\'' '\''--enable-crashdump'\'' '\''--enable-evolution2'\'' '\''--enable-graphite'\'' '\''--disable-gio'\'' '\''--disable-kde'\'' '\''--enable-kde4'\'' '\''--enable-ldap'\'' '\''--enable-lockdown'\'' '\''--enable-minimizer'\'' '\''--enable-odk'\'' '\''--enable-opengl'\'' '\''--enable-pdfimport'\'' '\''--enable-presenter-console'\'' '\''--enable-presenter-extra-ui'\'' '\''--enable-report-builder'\'' '\''--enable-wiki-publisher'\'' '\''--enable-ogltrans'\'' '\''--without-fonts'\'' '\''--without-afms'\'' '\''--without-ppds'\'' '\''--without-system-agg'\'' '\''--without-system-libwps'\'' '\''--without-system-mdds'\'' '\''--with-system-cppunit'\'' '\''--with-system-libwpg'\'' '\''--with-system-redland'\'' '\''--without-system-saxon'\'' '\''--with-openldap'\'' '\''--with-ant-home=/usr/share/java/apache-ant'\'' '\''--with-system-boost'\'' '\''--with-system-cairo'\'' '\''--with-system-libs'\'' '\''--with-system-mythes'\'' '\''--with-system-unixodbc-headers'\'' '\''--with-system-xrender-headers'\'' '\''--with-system-headers'\'' '\''--with-alloc=system'\'' '\''--with-system-lucene'\'' '\''--with-lucene-core-jar=/usr/share/java/lucene-core.jar'\'' '\''--with-lucene-analyzers-jar=/usr/share/java/lucene-analyzers.jar'\'' '\''--without-stlport'\'' '\''LDFLAGS=-Wl,--hash-style=gnu -Wl,--as-needed'\''' ... configure: error: unrecognized option: `-Wl,--as-needed' Try `./configure --help' for more information make: *** [stamp/build] Error 1 This didn't happen in last go-oo releases. Any idea? -Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translation of comments from German to English (no. 8)
On Thu, 2010-10-07 at 20:53 +0200, Andreas Mantke wrote: translation into English Committed, with thanks ! :-) Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Building error : Hunk #1 FAILED at 58
Hi, I've just done these steps : git pull -r ./autogen.sh --with-git --disable-kde --disable-kde4 ./download make And here are the error logs : dbaccess-default-varchar-lenght.diff: testing... /home/serval/libreoffice-source/build/patches/dev300/./dbaccess-default-varchar-lenght.diff patch --fuzz=0 -l -p0 -d /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.1 --dry-run patching file dbaccess/source/ui/tabledesign/FieldDescriptions.cxx Hunk #1 FAILED at 58. 1 out of 1 hunk FAILED -- saving rejects to file dbaccess/source/ui/tabledesign/FieldDescriptions.cxx.rej Testing patch dbaccess-default-varchar-lenght.diff failed. at /home/serval/libreoffice-source/build/patches/apply.pl line 98. make: *** [stamp/patch.apply] Erreur 1 Env : Debian testing updated (x86) Regards. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Using gnu-cp on Mac OS X for building LibreOffice
Hi Eric, On 2010-10-07 at 16:03 +0200, Eric Hoch wrote: And now we go a step back and need to install gnu-copy again? OK, gnu-copy is not that big a think but it's a beginning and it could end up in adding more and more libs and binaries needed which aren't in a default Mac OS X installation or one after installing XCode. From what I read, the BSD cp has very annoying behavior wrt. recursive copying of directories, so I understand why GNU cp is preferred ;-) But if you are interested in fixing the places where the breakage happens, I am sure we'll accept your patch, and remove the need for GNU cp again. Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LDFLAGS break configure
On Thu, Oct 07, 2010 at 06:15:35PM +0200, Andreas Radke a.ra...@arcor.de wrote: '\''--without-git'\'' '\''--with-srcdir=/build/src'\'' Did you try --with-git? There has been some issue with proper quoting when passing args to the internal configure, and that has been fixed in git since beta1. Thanks. pgp4DUtcYdgyA.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Mac OS X Build
On my 10.6.4 machine, I had to install the following to get things to build: autoconf2.68 automake1.11.1 coreutils 8.5 gettext 0.18.1.1 git 1.7.2.3 glib2.26.0 gmp 5.0.1 libIDL 0.8.14 libiconv1.13.1 - I was having some issues with the base one not be recognized as GNU libidn 1.19 libxml2 2.7.7 - Not sure why configure didn't find the base one (maybe because it's in Framework which is mac only) libxslt 1.1.26 m4 1.4.15 pkg-config 0.25 wget1.12 I wouldn't worry too much about the gcp issue. On a side note, I now hate MacPorts. I'm using a MacPro and installing -i386 fails on about half of the above installs. -x86_64 fails on about half (and if you don't include it, this is the default). The +universal option again fails on about half of them. I ended up just downloading the base .tar.gz files and building them all from scratch. Most of them allow you to just set the compiler flags to -arch i386 -arch x86_64 to automatically build fat versions. Two of them required building one -arch, doing the install, and the building the 2nd -arch, and then manually create the fat version. Joe P. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice