Re: [Libreoffice] ucb/source/ucb compilation error

[Norbert Thiebaud]

The first thing I'd check is : Is IllegalIdentifierException defined
in this context ?, try adding ucb:: in front of it, if that doesn't
work then try adding #include
"com/sun/start/ucb/IllegalIdentifierException.hpp"

Norbert



On Thu, Oct 21, 2010 at 12:11 AM, Kevin Hunter  wrote:
> On 10/20/2010 04:58 PM, Thomas Klausner wrote:
>>
>> On Tue, Oct 19, 2010 at 02:44:17PM +0200, Thomas Klausner wrote:
>>>
>>> With up-to-date git, I now see:
>>> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx: In member
>>> function 'virtual
>>> com::sun::star::uno::Reference
>>>  fileaccess::FileProvider::queryContent(const
>>> com::sun::star::uno::Reference&)':
>>> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error:
>>> expected primary-expression before '(' token
>>> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error:
>>> expected primary-expression before '(' token
>>> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error:
>>> expected `)' before '__PRETTY_FUNCTION__'
>>> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error:
>>> expected primary-expression before ')' token
>>> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error:
>>> expected `)' before '__PRETTY_FUNCTION__'
>>> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error:
>>> expected `)' before ';' token
>>> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error:
>>> expected `)' before ';' token
>>>
>>> Line 342 is:
>>>     throw IllegalIdentifierException( ::rtl::OUString(
>>> RTL_CONSTASCII_USTRINGPARAM( OSL_LOG_PREFIX ) ), uno::Reference<
>>>  uno::XInterface>() );
>>
>> Looking with g++ -E, this expands to:
>>         throw IllegalIdentifierException( ::rtl::OUString(
>> "/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx" ":"
>> __PRETTY_FUNCTION__ ":" "342" "; ",
>> ((sal_Int32)(sizeof("/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx"
>> ":" __PRETTY_FUNCTION__ ":" "342" "; ")-1)), (((rtl_TextEncoding) 11)) ),
>> uno::Reference<  uno::XInterface>() );
>
> I can't finish a compile, or get your error right now, but I've three
> thoughts:
>
> 1. Macro use?
> 
> LibreOffice is using macros.  They aren't bad per se, but can lead to
> /really/ obscure (difficult!) to find errors.  In this case, I don't think
> the macro is the problem; however, since the bug is in a line that contains
> a one, my "spidey sense" went all haywire.  There went 10 minutes.
>
> 2. Extra parentheses?
> =
> I'm grasping at straws here, but I broke the long line into parts:
>
> throw IllegalIdentifierException(
>  ::rtl::OUString(
>    "/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx" ":"
> __PRETTY_FUNCTION__ ":" "342" "; ",
>    (   // <--- 1
>
> (sal_Int32)(sizeof("/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx"
> ":" __PRETTY_FUNCTION__ ":" "342" "; ") -1)
>    ),  // <--- 1
>    (   // <--- 2
>      ( // <--- 3
>        (rtl_TextEncoding) 11
>      ) // <--- 3
>    )   // <--- 2
>  ),
>  uno::Reference< uno::XInterface >()
> );
>
> Are any of those parenthesis pairs a problem?  (1, 2, or 3)
>
> 3. Misinterpretation of __PRETTY_FUNCTION__?
> 
> What is __PRETTY_FUNCTION__?  It changed in GCC 3.4, I believe.  Now,
> contrary to the implicit understanding from its all caps nature, it is *not*
> a macro; it's a language identifier:
>
> http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html
>
> The clue that it's not a macro (aside from reading the documentation) is
> that it does not get processed out by the -E flag to g++.  Thus, the trip up
> is that it can't be concatenated as if it were an inline string.  See the
> attached example CPP code.  Note that to make it compile, you'll need to
> comment out line 37.
>
> So, I believe the issue *is* with the macro definition, but, as is usual
> with macros, not where one expects.
>
> Cheers,
>
> Kevin
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Address Books

[Eric Hoch]

Hi Jospeh, 

sorry for two mails but I missed to include the mailinglist in the 
first reply. 

Am Wed, 20 Oct 2010 19:54:21 -0700 schrieb Joseph Powers:
> 
On Oct 20, 2010, at 8:05 AM, Caolán McNamara wrote:

>> On Wed, 2010-10-20 at 06:09 -0700, Joseph Powers wrote:

> I think on Mac they disabled MozAB and use AppleAB instead. Which 
is ok, but we should leave both enabled. Mail.app is very limited 
so it's quite likely that someone may use Thunderbird instead. In 
which case we should allow the users to select the preferred 
address book.

+1

 (side note: thunderbird also has an option to use 
> the AppleAB by default)

Indeed but at the moment, at least in TB 3.1.4 or the Eudora OSE 
Edition, which is based on TB 3.0.4, it is read only, which bothers 
me a bit because I use both Mail and TB. 

Eric

-- 
## de.OpenOffice.org - Office für MacOS X, Linux, Solaris & Windows
## Openoffice.org - ich steck mit drin!
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] "damaged" file: sysui's dummy/localize.sdf

[Kevin Hunter]

Hullo List,

I'm a noob to compiling LO, and am having a difficult time compiling it. 
 I've done well enough so far by just waiting and the using the 'bin/g 
pull -r' tidbit.  But this error seems to be recurring, and I can't 
immediately find a link to any section of code or the build process. 
Can anyone point me in the right direction?


-
~/devel/libreoffice$ make
...
Entering /home/kevin/devel/libreoffice/build/libreoffice-3.2.99.2/sysui/util

/usr/bin/perl checksize.pl
Checking:../unxlngx6.pro/
Error: ../unxlngx6.pro/misc/sysui/dummy/localize.sdf 0 Bytes!
Error: 1 damaged files encountered
dmake:  Error code 1, while making '../unxlngx6.pro/misc/checksize.done'
-

Thanks for any help!

Kevin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] ucb/source/ucb compilation error

[Kevin Hunter]

At 1:11am -0400 Thu, 21 Oct 2010, Kevin Hunter wrote:

3. Misinterpretation of __PRETTY_FUNCTION__?

What is __PRETTY_FUNCTION__?  It changed in GCC 3.4, I believe.  Now,
contrary to the implicit understanding from its all caps nature, it is
*not* a macro; it's a language identifier:



http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html


I need to learn to read more thoroughly.  For C only, it was changed in 
GCC 3.4.  It's apparently always been treated as a variable in C++:


"In C++, __FUNCTION__ and __PRETTY_FUNCTION__ have always been variables."

Cheers,

Kevin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] ucb/source/ucb compilation error

[Kevin Hunter]

On 10/20/2010 04:58 PM, Thomas Klausner wrote:

On Tue, Oct 19, 2010 at 02:44:17PM +0200, Thomas Klausner wrote:

With up-to-date git, I now see:
/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx: In member function 'virtual 
com::sun::star::uno::Reference  
fileaccess::FileProvider::queryContent(const 
com::sun::star::uno::Reference&)':
/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
expected primary-expression before '(' token
/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
expected primary-expression before '(' token
/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
expected `)' before '__PRETTY_FUNCTION__'
/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
expected primary-expression before ')' token
/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
expected `)' before '__PRETTY_FUNCTION__'
/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
expected `)' before ';' token
/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
expected `)' before ';' token

Line 342 is:
 throw IllegalIdentifierException( ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( 
OSL_LOG_PREFIX ) ), uno::Reference<  uno::XInterface>() );


Looking with g++ -E, this expands to:
 throw IllegalIdentifierException( ::rtl::OUString( "/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx" ":" __PRETTY_FUNCTION__ ":" 
"342" "; ", ((sal_Int32)(sizeof("/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx" ":" __PRETTY_FUNCTION__ ":" 
"342" "; ")-1)), (((rtl_TextEncoding) 11)) ), uno::Reference<  uno::XInterface>() );


I can't finish a compile, or get your error right now, but I've three 
thoughts:


1. Macro use?

LibreOffice is using macros.  They aren't bad per se, but can lead to 
/really/ obscure (difficult!) to find errors.  In this case, I don't 
think the macro is the problem; however, since the bug is in a line that 
contains a one, my "spidey sense" went all haywire.  There went 10 minutes.


2. Extra parentheses?
=
I'm grasping at straws here, but I broke the long line into parts:

throw IllegalIdentifierException(
  ::rtl::OUString(
"/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx" ":" 
__PRETTY_FUNCTION__ ":" "342" "; ",

(   // <--- 1

(sal_Int32)(sizeof("/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx" 
":" __PRETTY_FUNCTION__ ":" "342" "; ") -1)

),  // <--- 1
(   // <--- 2
  ( // <--- 3
(rtl_TextEncoding) 11
  ) // <--- 3
)   // <--- 2
  ),
  uno::Reference< uno::XInterface >()
);

Are any of those parenthesis pairs a problem?  (1, 2, or 3)

3. Misinterpretation of __PRETTY_FUNCTION__?

What is __PRETTY_FUNCTION__?  It changed in GCC 3.4, I believe.  Now, 
contrary to the implicit understanding from its all caps nature, it is 
*not* a macro; it's a language identifier:


http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html

The clue that it's not a macro (aside from reading the documentation) is 
that it does not get processed out by the -E flag to g++.  Thus, the 
trip up is that it can't be concatenated as if it were an inline string. 
 See the attached example CPP code.  Note that to make it compile, 
you'll need to comment out line 37.


So, I believe the issue *is* with the macro definition, but, as is usual 
with macros, not where one expects.


Cheers,

Kevin
#include 

#define TEST_1  "This is a test!\n"
#define TEST_2  "This" " is" " a" " test!\n"
#define HALF_1  "This is"
#define HALF_2  " a test!\n"

int main ( int argc, char **argv ) {
	// These 9 printf lines are all legal syntax, because the
	// compiler converts "one " "TWO" to "one TWO"
	printf( "Test 0: This is a test!\n" );
	printf( "Test 0: " "This" " is" " a" " test!\n" );

	printf( "Test 1 (formatted): %s", TEST_1 );
	printf( "Test 1: "TEST_1 );

	printf( "Test 2 (formatted): %s", TEST_2 );
	printf( "Test 2: "TEST_2 );

	printf( "Halves (formatted): %s%s", HALF_1, HALF_2 ); // note commas
	printf( "Halves (formatted): %s",   HALF_1  HALF_2 ); // note commas
	printf( "Halves: "  HALF_1  HALF_2 ); // note commas

	// legal syntax, but should at least produce a warning.  I hope
	// LibreOffice is not suppressing warnings ...
	printf( __PRETTY_FUNCTION__ );

	// Legal, because treating __PRETTY_FUNCTION__ as
	// a variable
	printf( "\n__PRETTY_FUNCTION__: %s\n", __PRETTY_FUNCTION__ );

	// Not legal, because __PRETTY_FUNCTION__ doesn't get preprocessed
	// to an inline string: it's a /language/ identifier:
	printf( "__PRETTY_FUNCTION__: " __PRETTY_FUNCTION__ "\n" );

	return( 0 );
}___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] remove pam in writer sw

[Nadav Vinik]

remove pam in writer sw

diff --git a/sw/source/filter/writer/writer.cxx
b/sw/source/filter/writer/writer.cxx
index db72a3c..708ab29 100644
--- a/sw/source/filter/writer/writer.cxx
+++ b/sw/source/filter/writer/writer.cxx
@@ -40,7 +40,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/sw/source/filter/writer/wrt_fn.cxx
b/sw/source/filter/writer/wrt_fn.cxx
index bab8f82..8a6273c 100644
--- a/sw/source/filter/writer/wrt_fn.cxx
+++ b/sw/source/filter/writer/wrt_fn.cxx
@@ -34,7 +34,6 @@

 #include "shellio.hxx"
 #include "wrt_fn.hxx"
-#include "pam.hxx"
 #include "node.hxx"
 #include "format.hxx"




-- 
הבלוג שלי:
http://nadavvin.com
diff --git a/sw/source/filter/writer/writer.cxx b/sw/source/filter/writer/writer.cxx
index db72a3c..708ab29 100644
--- a/sw/source/filter/writer/writer.cxx
+++ b/sw/source/filter/writer/writer.cxx
@@ -40,7 +40,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/sw/source/filter/writer/wrt_fn.cxx b/sw/source/filter/writer/wrt_fn.cxx
index bab8f82..8a6273c 100644
--- a/sw/source/filter/writer/wrt_fn.cxx
+++ b/sw/source/filter/writer/wrt_fn.cxx
@@ -34,7 +34,6 @@
 
 #include "shellio.hxx"
 #include "wrt_fn.hxx"
-#include "pam.hxx"
 #include "node.hxx"
 #include "format.hxx"
 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] compilation error: error 65280 occurred while making /media/data_/projects/build/build/libreoffice-3.2.99.2/more_fonts/fonts/ttf_linlibertineg

[Nadav Vinik]

What is the problem?

thanks
Nadav

-- 
הבלוג שלי:
http://nadavvin.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Address Books

[Joseph Powers]

On Oct 20, 2010, at 8:05 AM, Caolán McNamara wrote:

> On Wed, 2010-10-20 at 06:09 -0700, Joseph Powers wrote:
>> It looks like someone already connected Base to Apple's Address Book (no 
>> bonus points for me)
>> 
>> On my mac, I can't get the Mozilla Address Book driver to work.
> 
> Hmm, see connectivity/source/drivers/mozab/makefile.mk 
> Apparently on the mac its not built if I'm reading that right

Which explains why the connection couldn't find the libraries.


>> Preferences -> LibreOffice Base -> Connections shows that
> com.sun.star.comp.sdbc.MozabDriver is installed.
> 
> probably should find out where that's coming from then
> 

This could be caused by the fact that the Connection was compiled into the 
program.

> C.
> 

So the short answer is: If the connection is compiled, you'll see the driver 
listed; however, if the external driver isn't found you can't using the 
connection and no error is given.

Thanks for the help... now to see if I can force it to compile so I can play 
with it :)

I think on Mac they disabled MozAB and use AppleAB instead. Which is ok, but we 
should leave both enabled. Mail.app is very limited so it's quite likely that 
someone may use Thunderbird instead. In which case we should allow the users to 
select the preferred address book. (side note: thunderbird also has an option 
to use the AppleAB by default)

Joe P.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Added perl module required for commit f8114ef6051e0fb5cb02d97ea468a2da7d2047fa

[libreoffice]

---
 solenv/bin/modules/Digest.pm |  315 +++
 solenv/bin/modules/Digest/MD5.pm |  376 ++
 2 files changed, 691 insertions(+), 0 deletions(-)
 create mode 100644 solenv/bin/modules/Digest.pm
 create mode 100644 solenv/bin/modules/Digest/MD5.pm

diff --git a/solenv/bin/modules/Digest.pm b/solenv/bin/modules/Digest.pm
new file mode 100644
index 000..fb5b0d7
--- /dev/null
+++ b/solenv/bin/modules/Digest.pm
@@ -0,0 +1,315 @@
+package Digest;
+
+use strict;
+use vars qw($VERSION %MMAP $AUTOLOAD);
+
+$VERSION = "1.15";
+
+%MMAP = (
+  "SHA-1"  => ["Digest::SHA1", ["Digest::SHA", 1], ["Digest::SHA2", 1]],
+  "SHA-224"=> [["Digest::SHA", 224]],
+  "SHA-256"=> [["Digest::SHA", 256], ["Digest::SHA2", 256]],
+  "SHA-384"=> [["Digest::SHA", 384], ["Digest::SHA2", 384]],
+  "SHA-512"=> [["Digest::SHA", 512], ["Digest::SHA2", 512]],
+  "HMAC-MD5"   => "Digest::HMAC_MD5",
+  "HMAC-SHA-1" => "Digest::HMAC_SHA1",
+  "CRC-16" => [["Digest::CRC", type => "crc16"]],
+  "CRC-32" => [["Digest::CRC", type => "crc32"]],
+  "CRC-CCITT"  => [["Digest::CRC", type => "crcccitt"]],
+);
+
+sub new
+{
+shift;  # class ignored
+my $algorithm = shift;
+my $impl = $MMAP{$algorithm} || do {
+$algorithm =~ s/\W+//;
+"Digest::$algorithm";
+};
+$impl = [$impl] unless ref($impl);
+my $err;
+for  (@$impl) {
+my $class = $_;
+my @args;
+($class, @args) = @$class if ref($class);
+no strict 'refs';
+unless (exists ${"$class\::"}{"VERSION"}) {
+eval "require $class";
+if ($@) {
+$err ||= $@;
+next;
+}
+}
+return $class->new(@args, @_);
+}
+die $err;
+}
+
+sub AUTOLOAD
+{
+my $class = shift;
+my $algorithm = substr($AUTOLOAD, rindex($AUTOLOAD, '::')+2);
+$class->new($algorithm, @_);
+}
+
+1;
+
+__END__
+
+=head1 NAME
+
+Digest - Modules that calculate message digests
+
+=head1 SYNOPSIS
+
+  $md5  = Digest->new("MD5");
+  $sha1 = Digest->new("SHA-1");
+  $sha256 = Digest->new("SHA-256");
+  $sha384 = Digest->new("SHA-384");
+  $sha512 = Digest->new("SHA-512");
+
+  $hmac = Digest->HMAC_MD5($key);
+
+=head1 DESCRIPTION
+
+The C modules calculate digests, also called "fingerprints"
+or "hashes", of some data, called a message.  The digest is (usually)
+some small/fixed size string.  The actual size of the digest depend of
+the algorithm used.  The message is simply a sequence of arbitrary
+bytes or bits.
+
+An important property of the digest algorithms is that the digest is
+I to change if the message change in some way.  Another
+property is that digest functions are one-way functions, that is it
+should be I to find a message that correspond to some given
+digest.  Algorithms differ in how "likely" and how "hard", as well as
+how efficient they are to compute.
+
+Note that the properties of the algorithms change over time, as the
+algorithms are analyzed and machines grow faster.  If your application
+for instance depends on it being "impossible" to generate the same
+digest for a different message it is wise to make it easy to plug in
+stronger algorithms as the one used grow weaker.  Using the interface
+documented here should make it easy to change algorithms later.
+
+All C modules provide the same programming interface.  A
+functional interface for simple use, as well as an object oriented
+interface that can handle messages of arbitrary length and which can
+read files directly.
+
+The digest can be delivered in three formats:
+
+=over 8
+
+=item I
+
+This is the most compact form, but it is not well suited for printing
+or embedding in places that can't handle arbitrary data.
+
+=item I
+
+A twice as long string of lowercase hexadecimal digits.
+
+=item I
+
+A string of portable printable characters.  This is the base64 encoded
+representation of the digest with any trailing padding removed.  The
+string will be about 30% longer than the binary version.
+L tells you more about this encoding.
+
+=back
+
+
+The functional interface is simply importable functions with the same
+name as the algorithm.  The functions take the message as argument and
+return the digest.  Example:
+
+  use Digest::MD5 qw(md5);
+  $digest = md5($message);
+
+There are also versions of the functions with "_hex" or "_base64"
+appended to the name, which returns the digest in the indicated form.
+
+=head1 OO INTERFACE
+
+The following methods are available for all C modules:
+
+=over 4
+
+=item $ctx = Digest->XXX($arg,...)
+
+=item $ctx = Digest->new(XXX => $arg,...)
+
+=item $ctx = Digest::XXX->new($arg,...)
+
+The constructor returns some object that encapsulate the state of the
+message-digest algorithm.  You can add data to the object and finally
+ask for the digest.  The "XXX" should of course be replaced by the proper
+name of the digest algorithm you want to use.
+
+The two first fo

[Libreoffice] [PATCH] Created installer::languages::shorten_language_string

[Sean McMurray]

Replaced similar code in other loactions to point to here.
Used Digest::MD5 instead of spawning a separate os process.

This patch is public domain.

---
 solenv/bin/make_installer.pl  |8 +---
 solenv/bin/modules/installer/control.pm   |   12 ++--
 solenv/bin/modules/installer/languages.pm |   15 +++
 solenv/bin/modules/installer/systemactions.pm |   12 ++--
 4 files changed, 20 insertions(+), 27 deletions(-)

diff --git a/solenv/bin/make_installer.pl b/solenv/bin/make_installer.pl
index 9c6c771..6d0cfee 100644
--- a/solenv/bin/make_installer.pl
+++ b/solenv/bin/make_installer.pl
@@ -660,13 +660,7 @@ for ( my $n = 0; $n <= 
$#installer::globals::languageproducts; $n++ )
 
 my $loglanguagestring = $$languagestringref;
 my $loglanguagestring_orig = $loglanguagestring;
-if (length($loglanguagestring) > $installer::globals::max_lang_length)
-{
-my $number_of_languages = 
installer::systemactions::get_number_of_langs($loglanguagestring);
-chomp(my $shorter = `echo $loglanguagestring | md5sum | sed -e "s/ 
.*//g"`);
-my $id = substr($shorter, 0, 8); # taking only the first 8 digits
-$loglanguagestring = "lang_" . $number_of_languages . "_id_" . $id;

-}
+$loglanguagestring = 
installer::languages::shorten_language_string($loglanguagestring);
 
 $installer::globals::logfilename = "log_" . $installer::globals::build;
 if ( $logminor ne "" ) { $installer::globals::logfilename .= "_" . 
$logminor; }
diff --git a/solenv/bin/modules/installer/control.pm 
b/solenv/bin/modules/installer/control.pm
index 5f7c2ca..0d9e238 100644
--- a/solenv/bin/modules/installer/control.pm
+++ b/solenv/bin/modules/installer/control.pm
@@ -32,6 +32,7 @@ use installer::converter;
 use installer::exiter;
 use installer::files;
 use installer::globals;
+use installer::languages;
 use installer::pathanalyzer;
 use installer::scriptitems;
 use installer::systemactions;
@@ -409,16 +410,7 @@ sub determine_ship_directory
 
 my $shipdrive = $ENV{'SHIPDRIVE'};
 
-my $languagestring = $$languagesref;
-
-if (length($languagestring) > $installer::globals::max_lang_length )
-{
-my $number_of_languages = 
installer::systemactions::get_number_of_langs($languagestring);
-chomp(my $shorter = `echo $languagestring | md5sum | sed -e "s/ 
.*//g"`);
-# $languagestring = $shorter;
-my $id = substr($shorter, 0, 8); # taking only the first 8 digits
-$languagestring = "lang_" . $number_of_languages . "_id_" . $id;   

-}
+my $languagestring = 
installer::languages::shorten_language_string($$languagesref);
 
 my $productstring = $installer::globals::product;
 my $productsubdir = "";
diff --git a/solenv/bin/modules/installer/languages.pm 
b/solenv/bin/modules/installer/languages.pm
index 84828bf..29f3b78 100644
--- a/solenv/bin/modules/installer/languages.pm
+++ b/solenv/bin/modules/installer/languages.pm
@@ -27,6 +27,7 @@
 
 package installer::languages;
 
+use Digest::MD5;
 use installer::converter;
 use installer::existence;
 use installer::exiter;
@@ -376,4 +377,18 @@ sub get_java_language
 return $javalanguage;
 }
 
+sub shorten_language_string {
+chomp;
+my $languagestring = shift;
+if (length($languagestring) > $installer::globals::max_lang_length )
+{
+my $number_of_languages = 
installer::systemactions::get_number_of_langs($languagestring);
+my $shorter = Digest::MD5->new($languagestring);
+$shorter =~s/ .*//g;
+my $id = substr($shorter, 0, 8); # taking only the first 8 digits
+$languagestring = "lang_" . $number_of_languages . "_id_" . $id;
+}
+return $languagestring;
+}
+
 1;
diff --git a/solenv/bin/modules/installer/systemactions.pm 
b/solenv/bin/modules/installer/systemactions.pm
index e3ef783..0c39477 100644
--- a/solenv/bin/modules/installer/systemactions.pm
+++ b/solenv/bin/modules/installer/systemactions.pm
@@ -32,6 +32,7 @@ use File::Copy;
 use installer::converter;
 use installer::exiter;
 use installer::globals;
+use installer::languages;
 use installer::pathanalyzer;
 use installer::remover;
 
@@ -397,16 +398,7 @@ sub create_directories
 
 if (!($locallanguagesref eq "" ))  # this will be a path like 
"01_49", for Profiles and ConfigurationFiles, idt-Files
 {
-my $languagestring = $$languagesref;
-
-if (length($languagestring) > $installer::globals::max_lang_length 
)
-{
-my $number_of_languages = get_number_of_langs($languagestring);
-chomp(my $shorter = `echo $languagestring | md5sum | sed -e 
"s/ .*//g"`);
-# $languagestring = $shorter;
-my $id = substr($shorter, 0, 8); # taking only the first 8 
digits
-$languagestring = "lang_" . $number_of_languages . "_id_" . 
$id;   

[Libreoffice] [PATCH] Filters - Clean up comments in sw_unosett.cxx

[jgraeme]

A patch to clean up comments.

Graeme
From c16ca6be0594106268dc94646b1fc0724e924461 Mon Sep 17 00:00:00 2001
From: J. Graeme Lingard 
Date: Thu, 21 Oct 2010 00:27:09 +0100
Subject: [PATCH] Clean up comments in sw_unosett.cxx

---
 binfilter/bf_sw/source/core/unocore/sw_unosett.cxx |  217 +--
 1 files changed, 12 insertions(+), 205 deletions(-)

diff --git a/binfilter/bf_sw/source/core/unocore/sw_unosett.cxx b/binfilter/bf_sw/source/core/unocore/sw_unosett.cxx
index eb1e439..9a03998 100644
--- a/binfilter/bf_sw/source/core/unocore/sw_unosett.cxx
+++ b/binfilter/bf_sw/source/core/unocore/sw_unosett.cxx
@@ -26,7 +26,6 @@
  *
  /
 
-
 #ifdef _MSC_VER
 #pragma hdrstop
 #endif
@@ -113,7 +112,7 @@ struct PropValData
 };
 
 typedef PropValData* PropValDataPtr;
-SV_DECL_PTRARR(PropValDataArr, PropValDataPtr, 5, 5 )//STRIP008 ;
+SV_DECL_PTRARR(PropValDataArr, PropValDataPtr, 5, 5 )
 SV_IMPL_PTRARR(PropValDataArr, PropValDataPtr)
 
 
@@ -210,9 +209,6 @@ const SfxItemPropertyMap* GetLineNumberingMap()
 return aLineNumberingMap_Impl;
 }
 
-/* -05.05.98 08:30---
- *
- * --*/
 SwCharFmt* lcl_getCharFmt(SwDoc* pDoc, const uno::Any& aValue)
 {
 SwCharFmt* pRet = 0;
@@ -233,9 +229,7 @@ SwCharFmt* lcl_getCharFmt(SwDoc* pDoc, const uno::Any& aValue)
 }
 return pRet;
 }
-/* -05.05.98 08:30---
- *
- * --*/
+
 SwTxtFmtColl* lcl_GetParaStyle(SwDoc* pDoc, const uno::Any& aValue)
 {
 OUString uTmp;
@@ -251,9 +245,7 @@ SwTxtFmtColl* lcl_GetParaStyle(SwDoc* pDoc, const uno::Any& aValue)
 }
 return pRet;
 }
-/* -05.05.98 08:30---
- *
- * --*/
+
 SwPageDesc* lcl_GetPageDesc(SwDoc* pDoc, const uno::Any& aValue)
 {
 SwPageDesc* pRet = 0;
@@ -279,9 +271,7 @@ SwPageDesc* lcl_GetPageDesc(SwDoc* pDoc, const uno::Any& aValue)
 }
 return pRet;
 }
-/**
- *
- **/
+
 // Numerierung
 const unsigned short aSvxToUnoAdjust[] =
 {
@@ -306,23 +296,16 @@ const unsigned short aUnoToSvxAdjust[] =
 /**
  * SwXFootnoteProperties
  **/
-/* -06.04.00 11:43
-
- ---*/
 OUString SwXFootnoteProperties::getImplementationName(void) throw( RuntimeException )
 {
 return C2U("SwXFootnoteProperties");
 }
-/* -06.04.00 11:43
 
- ---*/
 BOOL SwXFootnoteProperties::supportsService(const OUString& rServiceName) throw( RuntimeException )
 {
 return C2U("com.sun.star.text.FootnoteSettings") == rServiceName;
 }
-/* -06.04.00 11:43
 
- ---*/
 Sequence< OUString > SwXFootnoteProperties::getSupportedServiceNames(void) throw( RuntimeException )
 {
 Sequence< OUString > aRet(1);
@@ -330,33 +313,24 @@ Sequence< OUString > SwXFootnoteProperties::getSupportedServiceNames(void) throw
 pArray[0] = C2U("com.sun.star.text.FootnoteSettings");
 return aRet;
 }
-/*-- 14.12.98 14:03:20---
 
-  ---*/
 SwXFootnoteProperties::SwXFootnoteProperties(SwDoc* pDc) :
 pDoc(pDc),
 _pMap(GetFootnoteMap())
 {
 }
-/*-- 14.12.98 14:03:20---
 
-  ---*/
 SwXFootnoteProperties::~SwXFootnoteProperties()
 {
-
 }
-/*-- 14.12.98 14:03:20---
 
-  ---*/
 uno::Reference< beans::XPropertySetInfo >  SwXFootnoteProperties::getPropertySetInfo(void)
 throw( uno::RuntimeException )
 {
 static uno::Reference< beans::XPropertySetInfo >  aRef = new SfxItemPropertySetInfo( _pMap );
 return aRef;
 }
-/*-- 14.12.98 14:03:20---
 
-  ---*/
 void SwXFootnoteProperties::setPropertyValue(const OUString& rPropertyName, const uno::Any& aValue)
 throw( beans::UnknownPropertyException, beans::PropertyVetoException, lang::IllegalArgumentException, lang::Wr

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

[Thorsten Behrens]

Caolan McNamara wrote:
> sc/qa/unit had an existing cppunit test to ensure that calc can do
> =SUM(A1:A2) correctly but it was currently disabled seeing as it didn't
> work, mostly due to miserable bootstrapping problems. I've fixed that
> test (I think), so I hope it can now provide a basis for adding more.
> [...]
>
Hi Caolan -

interesting, cool that this is actually possible - I kinda evaded
the full-scale bootstrapping problem somehow, mostly doing 
scaffolding for testing parts of app functionality. There are three 
patches where I ended up with useful unit tests:

lobuild/patches/unittesting/unittesting-more-sw.diff
lobuild/patches/dev300/impress-autolayout.diff
lobuild/patches/dev300/sd_effects_styles.diff

The impress autolayout actually gets away w/o any uno setup; the
writer test fakes a uno.ini (see the makefile there) - I guess,
there's a fine line between trying to fake a ~whole office setup,
vs. testing exactly one class (and doing some scaffolding and/or
refactoring to really only test that one class) - for the former,
maybe the complextest framework is a closer fit?

> So, one suggestion I have it to look at stripmining testtool and
> try and start to *move* the calc tests out of the unreliable and
> painful testtool and into hopefully reliable cppunit tests which
> are run at buildtime
> 
That would be a *very* useful end result.

Cheers,

-- Thorsten


pgpCUdBcRciNq.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] how can we import/export .cbz/.cbr files on LibreOffice Impress?

[Joop Kiefte]

One feature in here (that I really liked about the newest powerpoint)
is the ease to fill slides with just photo's.

2010/10/20 Thorsten Behrens :
> Paulo Silva wrote:
>> A missing awesome feature on LibreOffice Impress would be the possibility on
>> importing/exporting .cbz and .cbr files on LibreOffice Impress.
>>
> Hi Paulo,
>
> hm, that almost sound like a useful thing to have outside LibO - you
> can reasonably easily synthesize odf files - there are interfaces to
> handle odf packages & xml details e.g. for java, python and perl.
>
> Would you be interested in having a go with that?
>
> Cheers,
>
> -- Thorsten
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>



-- 
Linux-user #496644 (http://counter.li.org) - first touch of linux in 2004

Demandoj en aŭ pri Esperanto? Questions about Esperanto? Vragen over
Esperanto? Perguntas sobre o Esperanto? - http://demandoj.tk
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] how can we import/export .cbz/.cbr files on LibreOffice Impress?

[Thorsten Behrens]

Paulo Silva wrote:
> A missing awesome feature on LibreOffice Impress would be the possibility on
> importing/exporting .cbz and .cbr files on LibreOffice Impress.
> 
Hi Paulo,

hm, that almost sound like a useful thing to have outside LibO - you
can reasonably easily synthesize odf files - there are interfaces to
handle odf packages & xml details e.g. for java, python and perl.

Would you be interested in having a go with that?

Cheers,

-- Thorsten


pgprj7XrpenGY.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Building on gentoo ...

[René Kjellerup]

As for disable it per default, look at another enable clause. But the quick
glance at it tells me the then and else blocks needs to be reversed
if test "z$enable_kde" != "zyes"; then
   
else
   
fi

Hope it makes sense
René
On Oct 20, 2010 8:00 PM, "Wols Lists"  wrote:
> On 20/10/10 14:39, Wols Lists wrote:
>> On 20/10/10 08:28, Sebastian Spaeth wrote:
>>> On Tue, 19 Oct 2010 23:45:11 +0200, René Kjellerup <
rk.katana.st...@gmail.com> wrote:
>>>
 On the other matter unless you're still running kde 3 then you need
 --disable-kde else the config will fail when it can't find Qt 3.x
>>> On that matter can, we please --disable-kde by default. I don't know of
>>> recent distros that ship kde3 but not KDE4, and those who do can turn it
>>> on in their distro-specific defaults.
>> Forgive the newbie question, but while I've got a lot of programming
>> experience large chunks of detail here (gnu tools, frinstance) are new
>> to me.
>>
>> I've dug a bit, found configure.in, and found
>>
>> AC_ARG_ENABLE(kde,
>> [
>> --disable-kde Disables KDE native widgets.],
>> ,)
>>
>> Does this switch it on? Will deleting it disable kde by default?
>>
>> If it will, I'll put a patch in.
>>> Even better, our make should detect the lack of qt3 headers and disable
>>> it automatically rather than bailing out.
>> That's a bit deeper ... won't stop me having a go if someone would care
>> to give me a few guidelines :-)
>>
>>> Sebastian
>>>
>> Cheers,
>> Wol
>> ___
>>
>
> Just found a bit more ...
>
> if test "$enable_kde" != "no"; then
> if test "z$with_win32" = "z" -a "z`uname -s`" != "zDarwin" -a
> "z$with_distro" != "zCrossWin32"; then
> OOO_WIDGET_FLAGS="--enable-kde"
> widget_sets="kde"
> fi
> else
> OOO_WIDGET_FLAGS="--disable-kde"
> fi
>
> I'm going to try changing != "no" to = "yes" - is that a sensible thing
> to do? I'm sure it'll work for me, but will it make it blow up when
> people want kde3 - does enable default to a value of yes?
>
> Cheers,
> Wol
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Fwd: Re: Building on gentoo ...

[René Kjellerup]

-- Forwarded message --
From: "René Kjellerup" 
Date: Oct 20, 2010 11:51 PM
Subject: Re: [Libreoffice] Building on gentoo ...
To: "Wols Lists" 

I'd consider removing that block completely... ?

Without the kde(3), there is still the GTK widgets but then there would
be a considerable qt3 code clean up too

Reasoning from gentoo too, the qt3 and kde3 have been masked/removed from
the tree.

@wols, if you want kde for you build, use "--enabled-kde4 --enabled-kde=no"
this will give you your kde widgets
On Oct 20, 2010 8:00 PM, "Wols Lists"  wrote:
> On 20/10/10 14:39, Wols Lists wrote:
>> On 20/10/10 08:28, Sebastian Spaeth wrote:
>>> On Tue, 19 Oct 2010 23:45:11 +0200, René Kjellerup <
rk.katana.st...@gmail.com> wrote:
>>>
 On the other matter unless you're still running kde 3 then you need
 --disable-kde else the config will fail when it can't find Qt 3.x
>>> On that matter can, we please --disable-kde by default. I don't know of
>>> recent distros that ship kde3 but not KDE4, and those who do can turn it
>>> on in their distro-specific defaults.
>> Forgive the newbie question, but while I've got a lot of programming
>> experience large chunks of detail here (gnu tools, frinstance) are new
>> to me.
>>
>> I've dug a bit, found configure.in, and found
>>
>> AC_ARG_ENABLE(kde,
>> [
>> --disable-kde Disables KDE native widgets.],
>> ,)
>>
>> Does this switch it on? Will deleting it disable kde by default?
>>
>> If it will, I'll put a patch in.
>>> Even better, our make should detect the lack of qt3 headers and disable
>>> it automatically rather than bailing out.
>> That's a bit deeper ... won't stop me having a go if someone would care
>> to give me a few guidelines :-)
>>
>>> Sebastian
>>>
>> Cheers,
>> Wol
>> ___
>>
>
> Just found a bit more ...
>
> if test "$enable_kde" != "no"; then
> if test "z$with_win32" = "z" -a "z`uname -s`" != "zDarwin" -a
> "z$with_distro" != "zCrossWin32"; then
> OOO_WIDGET_FLAGS="--enable-kde"
> widget_sets="kde"
> fi
> else
> OOO_WIDGET_FLAGS="--disable-kde"
> fi
>
> I'm going to try changing != "no" to = "yes" - is that a sensible thing
> to do? I'm sure it'll work for me, but will it make it blow up when
> people want kde3 - does enable default to a value of yes?
>
> Cheers,
> Wol
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Short reminder: OOo HackFest 6./7. November in Hamburg

[Thorsten Behrens]

Hi folks,

a short reminder that there's an OpenOffice.org HackFest taking
place in Hamburg, Germany two weeks from now - if you're around, or
can make it there, it's a great opportunity to meet hackers from
OOo/LibO in person.

More details here:

http://wiki.services.openoffice.org/wiki/Hackfest2010

Cheers,

-- Thorsten


pgpaTnXfR9TAw.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] ucb/source/ucb compilation error

[Thomas Klausner]

On Tue, Oct 19, 2010 at 02:44:17PM +0200, Thomas Klausner wrote:
> With up-to-date git, I now see:
> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx: In member 
> function 'virtual 
> com::sun::star::uno::Reference 
> fileaccess::FileProvider::queryContent(const 
> com::sun::star::uno::Reference&)':
> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
> expected primary-expression before '(' token
> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
> expected primary-expression before '(' token
> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
> expected `)' before '__PRETTY_FUNCTION__'
> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
> expected primary-expression before ')' token
> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
> expected `)' before '__PRETTY_FUNCTION__'
> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
> expected `)' before ';' token
> /build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx:342: error: 
> expected `)' before ';' token
> 
> Line 342 is:
> throw IllegalIdentifierException( ::rtl::OUString( 
> RTL_CONSTASCII_USTRINGPARAM( OSL_LOG_PREFIX ) ), uno::Reference< 
> uno::XInterface >() );

Looking with g++ -E, this expands to:
throw IllegalIdentifierException( ::rtl::OUString( 
"/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx" ":" 
__PRETTY_FUNCTION__ ":" "342" "; ", 
((sal_Int32)(sizeof("/build/libreoffice-3.2.99.2/ucb/source/ucp/file/prov.cxx"
 ":" __PRETTY_FUNCTION__ ":" "342" "; ")-1)), (((rtl_TextEncoding) 11)) ), 
uno::Reference< uno::XInterface >() );

Does anyone see what the problem is here?
 Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Fix for #i93300#: Crash when inserting 32 bit TIFF image

[Harri Pitkänen]

On Wednesday 20 October 2010, Caolán McNamara wrote:
> What would be awesome of course is to work on supporting those current
> unknown formats :-)

Thanks, I will check if there is something I could do to extend the range of 
supported formats.

Harri
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Is there tag/property in the following example that LO not support yet?

[Nadav Vinik]

On Wed, Oct 20, 2010 at 9:47 PM, Nadav Vinik  wrote:
> Hello
>
> I have docx document that LO failed load is images.
>
> The image can added to document, altough the XML code is defer.
>
> this is the part of the document.xml of the image.
>
> Do you know if it's because LO can't parse this part? (for any
> tag/property for example)
>
>  I still investigate the wordfilter code area, but I still don't know
> how to check it

When I add the image to new document I got the following error in console:
$ ERROR: meta.c (179): wmf_header_read: this isn't a wmf file
ERROR: meta.c (179): wmf_header_read: this isn't a wmf file
ERROR: meta.c (179): wmf_header_read: this isn't a wmf file

(this time I add it in OO 3.2)

>
> thanks
> Nadav
>
> 
> −
> 
> −
>  style="width:472.5pt;height:260.25pt" o:ole="">
> 
> 
>  ShapeID="_x_i1035" DrawAspect="Content" ObjectID="_1343106124"
> r:id="rId27"/>
> 
> 
>
> --
> הבלוג שלי:
> http://nadavvin.com
>



-- 
הבלוג שלי:
http://nadavvin.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Is there tag/property in the following example that LO not support yet?

[Nadav Vinik]

Hello

I have docx document that LO failed load is images.

The image can added to document, altough the XML code is defer.

this is the part of the document.xml of the image.

Do you know if it's because LO can't parse this part? (for any
tag/property for example)

 I still investigate the wordfilter code area, but I still don't know
how to check it

thanks
Nadav


−

−







-- 
הבלוג שלי:
http://nadavvin.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

[Caolán McNamara]

On Tue, 2010-10-19 at 13:37 +0100, Caolán McNamara wrote:
> sc/qa/unit had an existing cppunit test to ensure that calc can do
> =SUM(A1:A2) correctly but it was currently disabled seeing as it didn't
> work, mostly due to miserable bootstrapping problems. I've fixed that
> test (I think)

So the sc test, while working reliably for me, is apparently not working
for Kohei and others, so its disabled from being run by default for the
moment again. The trigger is definitely an uncaught exception, I'd guess
from some config using path which I'm not seeing for some reason or
other. So I've now added some debugging infrastructure to help track the
problem down.

Can you (g pull -r, etc.) and do...

export DEBUGCPPUNIT=1
cd sc/qa/unit
dmake

(hopefully in a build where --enable-symbols has been enabled in the
first place)

and send me/make available the gdbtrace.log which should eventually pop
out from that. That should contain the last throw/catch backtraces to
track where the offender is coming from.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

[Noel Power]

 On 20/10/10 11:15, Noel Power wrote:
I've looked at the basic part, looks good to me, currently I am in the 
middle of a build, I will apply it later, check again and push it ( 
will post here about that ). Thanks again!!! much apprecialted


Noel

done, and thanks,

Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [discuss] OpenOffice is it a community

[Cor Nouws]

Christian Lippka wrote (20-10-10 19:19)


So who is the merchant of doubt which will harm our project?
I already know that at least one of them will answer to my
mail and tell the world it is Oracle.


I hope not someone from us :-\

--
 - giving openoffice.org its foundation :: The Document Foundation -
 - ideas/remarks for the community council? See
   http://wiki.services.openoffice.org/wiki/Community_Council

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] LibreOffice and Java

[Constantin Makshin]

AFAIK, Java is optional and is used to extend core LO functionality.

Are the warnings you get related to Java-based extensions? If yes and you're on 
Windows, there's a thread with a suggestion to improve the LibreOffice installer
http://lists.freedesktop.org/archives/libreoffice/2010-October/000660.html
Unfortunately, that thread seems to be unnoticed/ignored by LO developers.

On Wednesday 20 October 2010 03:50:45 Cesare Leonardi wrote:
> Hi all.
> 
> There's a thing not clear to me and that involved go-oo too: the 
> relationship between LibreOffice and Java. Here i'm referring to the 
> Windows environment but under Linux/Mac should be the same.
> 
> Is it Java a requirements or it is considered an optional component?
> If Java isn't installed the user can see many warnings and some part of 
> the suite doesn't work, but the biggest part works. But Java isn't 
> provided with the installer as with OpenOffice...
> 
> I'd like to hear your point of view.
> 
> Cesare.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Building on gentoo ...

[Wols Lists]

 On 20/10/10 14:39, Wols Lists wrote:
>  On 20/10/10 08:28, Sebastian Spaeth wrote:
>> On Tue, 19 Oct 2010 23:45:11 +0200, René Kjellerup 
>>  wrote:
>>
>>> On the other matter unless you're still running kde 3 then you need
>>> --disable-kde else the config will fail when it can't find Qt 3.x
>> On that matter can, we please --disable-kde by default. I don't know of
>> recent distros that ship kde3 but not KDE4, and those who do can turn it
>> on in their distro-specific defaults.
> Forgive the newbie question, but while I've got a lot of programming
> experience large chunks of detail here (gnu tools, frinstance) are new
> to me.
>
> I've dug a bit, found configure.in, and found
>
> AC_ARG_ENABLE(kde,
> [
>   --disable-kde   Disables KDE native widgets.],
> ,)
>
> Does this switch it on? Will deleting it disable kde by default?
>
> If it will, I'll put a patch in.
>> Even better, our make should detect the lack of qt3 headers and disable
>> it automatically rather than bailing out.
> That's a bit deeper ... won't stop me having a go if someone would care
> to give me a few guidelines :-)
>
>> Sebastian
>>
> Cheers,
> Wol
> ___
>

Just found a bit more ...

if test "$enable_kde" != "no"; then
   if test "z$with_win32" = "z" -a "z`uname -s`" != "zDarwin" -a
"z$with_distro" != "zCrossWin32"; then
  OOO_WIDGET_FLAGS="--enable-kde"
  widget_sets="kde"
   fi
else
   OOO_WIDGET_FLAGS="--disable-kde"
fi

I'm going to try changing != "no" to = "yes" - is that a sensible thing
to do? I'm sure it'll work for me, but will it make it blow up when
people want kde3 - does enable default to a value of yes?

Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Patch] SAL_N_ELEMENTS Easy Hack

[Sean McMurray]

 From dff6ef1a53dd5f76ce9f33819106e860dd63a3e2 Mon Sep 17 00:00:00 2001
Date: Tue, 19 Oct 2010 16:10:36 -0700
Subject: [PATCH] Easy Hack for SAL_N_ELEMENTS

This patch is public domain.

---
 reportdesign/source/ui/inspection/metadata.cxx |3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/reportdesign/source/ui/inspection/metadata.cxx 
b/reportdesign/source/ui/inspection/metadata.cxx
index db219c8..e3610c4 100644
--- a/reportdesign/source/ui/inspection/metadata.cxx
+++ b/reportdesign/source/ui/inspection/metadata.cxx
@@ -173,9 +173,8 @@ namespace rptui
 };
 
 s_pPropertyInfos = aPropertyInfos;
-s_nCount = sizeof(aPropertyInfos) / sizeof(OPropertyInfoImpl);
 
-::std::sort( aPropertyInfos, aPropertyInfos + s_nCount, 
PropertyInfoLessByName() );
+::std::sort( aPropertyInfos, aPropertyInfos + 
SAL_N_ELEMENTS(aPropertyInfos), PropertyInfoLessByName() );
 
 return s_pPropertyInfos;
 }
-- 
1.6.2.5

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] More URLs to OOo sites

[Florian Effenberger]

Hi,

Thorsten Behrens wrote on 2010-10-20 15.25:


One additional one: http://libreoffice.org/credits.html

(I'll make sure that an up-to-date list of names is there)


let's use www.libreoffice.org/credits.html, as www is added nontheless 
by our Apache ;)


Florian

--
Florian Effenberger 
Steering Committee and Founding Member of The Document Foundation
Tel: +49 8341 99660880 | Mobile: +49 151 14424108
Skype: floeff | Twitter/Identi.ca: @floeff
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE #3

[Jacek Wolszczak]

Thanks for spotting the mistakes. I try to review patches before
sending, but will try better next time.

I haven't been able to compile LibreO yet. Had some problems in the past
and still trying to compile it now. It takes ages on a netbook.

BTW, I sometimes use the following script to help me with replacing:

for i in `grep -rle 'DBG_ASSERT' *` ; do sed 's/DBG_ASSERT/OSL_ENSURE/g'
$i > /tmp/modified.txt; mv /tmp/modified.txt $i ; done

Posting for reference should someone find this basic script useful :)

Of course a lot of error messages require DE->EN translation and you
can't make that one automatic. 

Regards,

Jacek


Dnia 2010-10-20, śro o godzinie 16:10 +0100, Caolán McNamara pisze:
> On Mon, 2010-10-18 at 18:47 +0200, Jacek Wolszczak wrote:
> > Hi,
> > 
> > Another patch replacing DBG_ stuff with OSL_ equivalents.
> > 
> > Didn't know what to replace
> > http://opengrok.go-oo.org/xref/writer/sw/source/ui/dbui/dbinsdlg.cxx#1190 
> > with. 
> 
> I'm swayed towards OSL_ENSURE(false, "message"); for the general case.
> 
> > I am not sure where changes in lines 3838-3857 in my patch come from.
> > Probably result from some changes introduced by other contributors in
> > the meantime. If so, please ignore this part of my patch.
> 
> I just chopped that bit out. And you accidentally removed a neccessary
> "}" along the way, there was one OSl_ENSURE instead of OSL_ENSURE, and
> another little gotcha here and there. Make sure you compile your changes
> and that'll catch those :-)
> 
> Otherwise looks good, committed and pushed. Thanks.
> 
> C.
> 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE #3

[Caolán McNamara]

On Mon, 2010-10-18 at 18:47 +0200, Jacek Wolszczak wrote:
> Hi,
> 
> Another patch replacing DBG_ stuff with OSL_ equivalents.
> 
> Didn't know what to replace
> http://opengrok.go-oo.org/xref/writer/sw/source/ui/dbui/dbinsdlg.cxx#1190 
> with. 

I'm swayed towards OSL_ENSURE(false, "message"); for the general case.

> I am not sure where changes in lines 3838-3857 in my patch come from.
> Probably result from some changes introduced by other contributors in
> the meantime. If so, please ignore this part of my patch.

I just chopped that bit out. And you accidentally removed a neccessary
"}" along the way, there was one OSl_ENSURE instead of OSL_ENSURE, and
another little gotcha here and there. Make sure you compile your changes
and that'll catch those :-)

Otherwise looks good, committed and pushed. Thanks.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Address Books

[Caolán McNamara]

On Wed, 2010-10-20 at 06:09 -0700, Joseph Powers wrote:
> It looks like someone already connected Base to Apple's Address Book (no 
> bonus points for me)
> 
> On my mac, I can't get the Mozilla Address Book driver to work.

Hmm, see connectivity/source/drivers/mozab/makefile.mk 
Apparently on the mac its not built if I'm reading that right.

> Preferences -> LibreOffice Base -> Connections shows that
com.sun.star.comp.sdbc.MozabDriver is installed.

probably should find out where that's coming from then

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] bootstrap/soenv: remove tcsh version of LinuxX86-64Env.Set

[Sebastian Spaeth]

On Wed, 20 Oct 2010 15:52:50 +0200, Christian Lohmaier wrote:
> To require bash for the buildtools is different than imposing to use
> bash for the user (not that I would be affected, I'm using bash as
> login shell anyway), but be aware of that difference.

I asked in the IRC channel and people felt comfortable removing the
non-.sh version. I don't care strong one way or the other if the tcsh
version is named differently so it doesn't get into my autocompletion
way.

Sebastian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] bootstrap/set_soenv: remove unused variables

[Sebastian Spaeth]

The variables $unsetenv, $setenv, $unset, $set $D, $answer were unused
in this script and have been removed.

Signed-off-by: Sebastian Spaeth 
---
 set_soenv.in |   11 ++-
 1 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/set_soenv.in b/set_soenv.in
index 7f55e47..b4b1616 100644
--- a/set_soenv.in
+++ b/set_soenv.in
@@ -1,8 +1,6 @@
 #...@perl@ -w
 #
 # Program: set_soenv.in
-# Version: $Revision: 1.201 $
-# Date:$Date: 2008-09-05 14:14:29 $
 # Author:  Willem van Dorp, Ross Nicholson, Oisin Boydell - Sun 
Microsystems, Ireland.
 #
 #---
@@ -39,8 +37,8 @@ use File::Basename;
 #
 #
 my ( $outfile, $bootfile, $newline, $comment,
- $compiler, $unsetenv, $setenv, $unset, $set, $ds, $ps,
- $wps, $cur_dir, $par_dir, $I, $L, $D, $buildenv, $answer, $tmp, $MINGW,
+ $compiler, $ds, $ps,
+ $wps, $cur_dir, $par_dir, $I, $L, $tmp, $MINGW,
  $USE_MINGW, $platform,
  $cygwinver, $empty, $no_ant, $no_stl, $no_gcc_include,
  $no_gxx_include, $warnfile, $Warning, $result, $unsetvars, $exportvars, 
$win_format_var, $perl_os, @mingw_lib_include_paths, $mingw_lib_include_path);
@@ -110,10 +108,6 @@ chomp( $platform );
 
 $UPD= '@UPD@';  # the project's UPD
 $newline= "\n"; # Perl newline character
-$unsetenv   = "unsetenv";   # c-shell command
-$setenv = "setenv"; # c-shell command
-$unset  = "unset";  # msdos batch file command
-$set= "set";# msdos batch file command
 $ds = "/";  # directory separator
 $ps = ":";  # path separator
 $wps= ":";  # path separator, will be set to ';' for 
windows later.
@@ -121,7 +115,6 @@ $cur_dir= ".";  # current directory
 $par_dir= ".."; # parrent directory
 $I  = " -I";# include search path
 $L  = " -L";# library search path
-$D  = " -D";# define search path
 $empty  = "";   # used as argument
 $no_stl = "NO_STLPORT4";# possible argument
 $warnfile   = "warn";   # logfile configure warnings.
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Building on gentoo ...

[Wols Lists]

 On 20/10/10 15:22, James L wrote:
>>  On 20/10/10 08:28, Sebastian Spaeth wrote:
>>> On Tue, 19 Oct 2010 23:45:11 +0200, René Kjellerup
>>>  wrote:
>>>
 On the other matter unless you're still running kde 3 then you need
 --disable-kde else the config will fail when it can't find Qt 3.x
>>> On that matter can, we please --disable-kde by default. I don't know of
>>> recent distros that ship kde3 but not KDE4, and those who do can turn it
>>> on in their distro-specific defaults.
>> Forgive the newbie question, but while I've got a lot of programming
>> experience large chunks of detail here (gnu tools, frinstance) are new
>> to me.
>>
>> I've dug a bit, found configure.in, and found
>>
>> AC_ARG_ENABLE(kde,
>> [
>>   --disable-kde   Disables KDE native widgets.],
>> ,)
>>
>> Does this switch it on? Will deleting it disable kde by default?
>>
>> If it will, I'll put a patch in.
>>> Even better, our make should detect the lack of qt3 headers and disable
>>> it automatically rather than bailing out.
>> That's a bit deeper ... won't stop me having a go if someone would care
>> to give me a few guidelines :-)
>>
>>> Sebastian
>>>
>> Cheers,
>> Wol
> That means '--disable-kde' is a command line option to 'configure'.
> I think 'configure' is called from the .ebuild and the .ebuild sets the
> configure command line based on USE flags.
>
>
That's portage. I'm not using portage. I'm using
http://www.documentfoundation.org/develop/

And the aim is to fix it UPSTREAM, not for gentoo. It's just that my
system is gentoo.

Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Building on gentoo ...

[James L]

>  On 20/10/10 08:28, Sebastian Spaeth wrote:
>> On Tue, 19 Oct 2010 23:45:11 +0200, René Kjellerup
>>  wrote:
>>
>>> On the other matter unless you're still running kde 3 then you need
>>> --disable-kde else the config will fail when it can't find Qt 3.x
>> On that matter can, we please --disable-kde by default. I don't know of
>> recent distros that ship kde3 but not KDE4, and those who do can turn it
>> on in their distro-specific defaults.
> Forgive the newbie question, but while I've got a lot of programming
> experience large chunks of detail here (gnu tools, frinstance) are new
> to me.
>
> I've dug a bit, found configure.in, and found
>
> AC_ARG_ENABLE(kde,
> [
>   --disable-kde   Disables KDE native widgets.],
> ,)
>
> Does this switch it on? Will deleting it disable kde by default?
>
> If it will, I'll put a patch in.
>> Even better, our make should detect the lack of qt3 headers and disable
>> it automatically rather than bailing out.
>
> That's a bit deeper ... won't stop me having a go if someone would care
> to give me a few guidelines :-)
>
>> Sebastian
>>
> Cheers,
> Wol

That means '--disable-kde' is a command line option to 'configure'.
I think 'configure' is called from the .ebuild and the .ebuild sets the
configure command line based on USE flags.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem w:/BASIC

[Noel Power]

 On 20/10/10 14:39, Jean-Etienne SIX wrote:

Hello
I'm testing libo beta2 + langpack fr under linux(slax) without jre
get Erreur d'exécution BASIC
message : the external file picker does not run

works fine under windows
happy if you can help

what exact steps do you do? can you give some more detail please


Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] bootstrap/soenv: remove tcsh version of LinuxX86-64Env.Set

[Sebastian Spaeth]

Previously we would have been writing out LinuxX86-64Env.Set and
LinuxX86-64Env.Set.sh which made my autocompletion useless. As we
require bash anyway, it has been agreed on to just provide the bash
version. Simplify the set_soenv.in to actually only produce 1 version.

Signed-off-by: Sebastian Spaeth 
---
I have tested the correct function of this patch on x86_64 Linux and I don't 
see any reason why it should break on other platforms. I don't know how fragile 
Windows is in that regard though.
 set_soenv.in |  117 +-
 1 files changed, 42 insertions(+), 75 deletions(-)

diff --git a/set_soenv.in b/set_soenv.in
index 5a3313c..7f55e47 100644
--- a/set_soenv.in
+++ b/set_soenv.in
@@ -38,12 +38,12 @@ use File::Basename;
 # IIa. Declaring variables for the system commands, etc.
 #
 #
-my ( $outfile, $outfile_sh, $bootfile, $newline, $comment,
+my ( $outfile, $bootfile, $newline, $comment,
  $compiler, $unsetenv, $setenv, $unset, $set, $ds, $ps,
  $wps, $cur_dir, $par_dir, $I, $L, $D, $buildenv, $answer, $tmp, $MINGW,
  $USE_MINGW, $platform,
  $cygwinver, $empty, $no_ant, $no_stl, $no_gcc_include,
- $no_gxx_include, $warnfile, $Warning, $result, $unsetvars, $unsetvarssh, 
$unsetvarsbat, $exportvars, $win_format_var, $perl_os, 
@mingw_lib_include_paths, $mingw_lib_include_path);
+ $no_gxx_include, $warnfile, $Warning, $result, $unsetvars, $exportvars, 
$win_format_var, $perl_os, @mingw_lib_include_paths, $mingw_lib_include_path);
 #
 #-
 # IIb. Declaring environment values (constants).
@@ -205,10 +205,10 @@ if ( $platform =~ m/solaris/ )
if ($platform =~ m/^i[3456]86/)
{
   if ( $CC =~ "gcc") {
- $outfile= "SolarisX86GccEnv.Set";
+ $outfile= "SolarisX86GccEnv.Set.sh";
  $OUTPATH= "unxsogi";
   } else {
- $outfile= "SolarisX86Env.Set";
+ $outfile= "SolarisX86Env.Set.sh";
  $OUTPATH= "unxsoli4";
   }
   $CPU= "I";
@@ -221,10 +221,10 @@ if ( $platform =~ m/solaris/ )
else
{
   if ( $CC =~ "gcc") {
- $outfile= "SolarisSparcGccEnv.Set";
+ $outfile= "SolarisSparcGccEnv.Set.sh";
  $OUTPATH= "unxsogs";
   } else {
- $outfile= "SolarisSparcEnv.Set";
+ $outfile= "SolarisSparcEnv.Set.sh";
  $OUTPATH= "unxsols4";
   }
   $CPU= "S";
@@ -256,7 +256,7 @@ elsif ( $platform =~ m/netbsd/ )
 #Set platform specific values:
if ($platform =~ m/^i[3456]86/)
{  print "Setting NetBSD x86 specific values... ";
-  $outfile= "NetBSDX86Env.Set";
+  $outfile= "NetBSDX86Env.Set.sh";
   $CPU= "I";
   $CPUNAME= "INTEL";
   $OUTPATH= "unxbsdi";
@@ -266,7 +266,7 @@ elsif ( $platform =~ m/netbsd/ )
}
elsif ($platform =~ m/^sparc/)
{  print "Setting NetBSD Sparc specific values... ";
-  $outfile= "NetBSDSparcEnv.Set";
+  $outfile= "NetBSDSparcEnv.Set.sh";
   $CPU= "S";
   $CPUNAME= "SPARC";
   $OUTPATH= "unxbsds";
@@ -276,7 +276,7 @@ elsif ( $platform =~ m/netbsd/ )
}
elsif ($platform =~ m/powerpc/)
{  print "Setting NetBSD PPC specific values... ";
-  $outfile= "NetBSDPPCEnv.Set";
+  $outfile= "NetBSDPPCEnv.Set.sh";
   $CPU= "P";
   $CPUNAME= "POWERPC";
   $OUTPATH= "unxbsdppc";
@@ -319,7 +319,7 @@ elsif ( $platform =~ m/kfreebsd/ )
 #Set platform specific values:
if ($platform =~ m/^i[3456]86/)
{  print "Setting GNU/kFreeBSD x86 specific values... ";
-  $outfile= "GNUkFreeBSDX86Env.Set";
+  $outfile= "GNUkFreeBSDX86Env.Set.sh";
   $CPU= "I";
   $CPUNAME= "INTEL";
   $OUTPATH= "unxkfgi6";
@@ -331,7 +331,7 @@ elsif ( $platform =~ m/kfreebsd/ )
}
elsif ($platform =~ m/^x86_64/)
{  print "Setting GNU/kFreeBSD x86-64 specific values... ";
-  $outfile= "GNUkFreeBSDX86-64Env.Set";
+  $outfile= "GNUkFreeBSDX86-64Env.Set.sh";
   $CPU= "X";
   $CPUNAME= "X86_64";
   $OUTPATH= "unxkfgx6";
@@ -357,7 +357,7 @@ elsif ( $platform =~ m/freebsd/ )
if ($platform =~ m/^amd64/)
{  my ( $JAVA_OS );
   print "Setting FreeBSD AMD64 specific values... ";
-  $outfile= "FreeBSDAMDEnv.Set";
+  $outfile= "FreeBSDAMDEnv.Set.sh";
   $CPU= "X";
   $CPUNAME= "X86_64";
   $OUTPATH= "unxfbsdx";
@@ -376,7 +376,7 @@ elsif ( $platform =~ m/freebsd/ )
}
elsif ($platform =~ m/^i386/)
{  print "Setting FreeBSD x86 specific values... ";
-  $outfile= "FreeBSDX86Env.Set";
+  $outfi

[Libreoffice] Problem w:/BASIC

[Jean-Etienne SIX]

Hello
I'm testing libo beta2 + langpack fr under linux(slax) without jre
get Erreur d'exécution BASIC
message : the external file picker does not run

works fine under windows
happy if you can help
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Building on gentoo ...

[Wols Lists]

 On 20/10/10 08:28, Sebastian Spaeth wrote:
> On Tue, 19 Oct 2010 23:45:11 +0200, René Kjellerup 
>  wrote:
>
>> On the other matter unless you're still running kde 3 then you need
>> --disable-kde else the config will fail when it can't find Qt 3.x
> On that matter can, we please --disable-kde by default. I don't know of
> recent distros that ship kde3 but not KDE4, and those who do can turn it
> on in their distro-specific defaults.
Forgive the newbie question, but while I've got a lot of programming
experience large chunks of detail here (gnu tools, frinstance) are new
to me.

I've dug a bit, found configure.in, and found

AC_ARG_ENABLE(kde,
[
  --disable-kde   Disables KDE native widgets.],
,)

Does this switch it on? Will deleting it disable kde by default?

If it will, I'll put a patch in.
> Even better, our make should detect the lack of qt3 headers and disable
> it automatically rather than bailing out.

That's a bit deeper ... won't stop me having a go if someone would care
to give me a few guidelines :-)

> Sebastian
>
Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] More URLs to OOo sites

[Thorsten Behrens]

Florian Effenberger wrote:
> templates.tdf and extensions.tdf will exist for a while, until beta2 is out.
> 
> templates.libo and extensions.tdf redirect, just as the .tdf
> variants, to the OOo repo respectively the FSFE repo.
> 
One additional one: http://libreoffice.org/credits.html

(I'll make sure that an up-to-date list of names is there)

> All other host names point to empty directories as of now. Let me
> know what we should fill in there. ;)
> 
Good question - let me put that on the agenda for the next
engineering call. :)

Cheers,

-- Thorsten


pgpyfw2LAvH7Z.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Address Books

[Joseph Powers]

It looks like someone already connected Base to Apple's Address Book (no bonus 
points for me)

On my mac, I can't get the Mozilla Address Book driver to work.
1. Preferences -> LibreOffice Base -> Connections shows that 
com.sun.star.comp.sdbc.MozabDriver is installed.
2. Trying to open the abook.mab file as an existing database fails (it doesn't 
recognize the file as being a database).
3. The connect to an existing database drop down doesn't include the Moz Driver.

I'm working on trying to isolate all the Moz Driver code out of the seamonkey 
source so it can be build with seamonkey disabled. I'd also like to update the 
code something a little more modern like v2ish of seamonkey (I'm going to look 
into Thunderbird's code and see if it uses seamonkey's address book code).

Also, does anyone know of any documentation on how the connectors work? 
(libs-core -> connectivity -> source -> drivers) 

Any pointers on any of the above would be nice.

Joe P.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Fix for #i93300#: Crash when inserting 32 bit TIFF image

[Caolán McNamara]

On Tue, 2010-10-19 at 20:25 +0300, Harri Pitkänen wrote:
> This patch has been tested on a 64 bit Linux system using the samples
> in the bug and some images from libtiff sample collection at
> ftp://ftp.remotesensing.org/pub/libtiff/pics-3.8.0.tar.gz

I ran through this one, and yeah fixes a pile of crashes, so test-suite
doesn't crash LO after applying, and simpler tiffs continue to work
(including recently added tiff alpha channel support). So committed and
pushed, thanks.

What would be awesome of course is to work on supporting those current
unknown formats :-)

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Building on windows 7-64bit with Visual Studio 2010 Express

[Caolán McNamara]

On Tue, 2010-10-19 at 22:46 +0100, Martin Gallwey wrote:
> Okay! Most of the battle so far was figuring out what cygwin packages
> to install and how to get the correct cygdrive paths - can someone add
> a windows section to
> http://www.freedesktop.org/wiki/Software/LibreOffice/HowToBuild with
> the info in this email?

You should be able to add it yourself I believe, that's probably the
best thing to do if possible.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] shutdownicon.cxx: rename getDotAutostart() -> getAutostartDir()

[Caolán McNamara]

On Wed, 2010-10-20 at 13:11 +0200, Sebastian Spaeth wrote:
> I was puzzled by the name and the new one is much clearer. Also add
> proper documentation to that function as to what it does and what the
> params mean. All callers have been adapted to the new name.

Look ok to me, committed + pushed.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] shutdownicon.cxx: rename getDotAutostart() -> getAutostartDir()

[Sebastian Spaeth]

I was puzzled by the name and the new one is much clearer. Also add
proper documentation to that function as to what it does and what the
params mean. All callers have been adapted to the new name.

Signed-off-by: Sebastian Spaeth 
---
 sfx2/source/appl/shutdownicon.cxx |   16 
 1 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/sfx2/source/appl/shutdownicon.cxx 
b/sfx2/source/appl/shutdownicon.cxx
index 1ff2164..3d8e4b6 100644
--- a/sfx2/source/appl/shutdownicon.cxx
+++ b/sfx2/source/appl/shutdownicon.cxx
@@ -771,12 +771,20 @@ bool ShutdownIcon::IsQuickstarterInstalled()
 // ---
 
 #if defined (ENABLE_QUICKSTART_APPLET) && defined (UNX)
-static OUString getDotAutostart( bool bCreate = false )
+/**
+* Return the XDG autostart directory.
+* http://standards.freedesktop.org/autostart-spec/autostart-spec-latest.html
+* Available in Unix and with Quickstart enabled.
+* @param bCreate Create the directory if it does not exist yet.
+* @return OUString containing the autostart directory path.
+*/
+static OUString getAutostartDir( bool bCreate = false )
 {
 OUString aShortcut;
 const char *pConfigHome;
 if( (pConfigHome = getenv("XDG_CONFIG_HOME") ) )
-aShortcut = OStringToOUString( OString( pConfigHome ), 
RTL_TEXTENCODING_UTF8 );
+aShortcut = OStringToOUString( OString( pConfigHome ), 
+   RTL_TEXTENCODING_UTF8 );
 else
 {
 OUString aHomeURL;
@@ -816,7 +824,7 @@ rtl::OUString ShutdownIcon::getShortcutName()
 aShortcut += OUString( RTL_CONSTASCII_USTRINGPARAM( "\\" ) );
 aShortcut += aShortcutName;
 #else // UNX
-OUString aShortcut = getDotAutostart();
+OUString aShortcut = getAutostartDir();
 aShortcut += OUString( RTL_CONSTASCII_USTRINGPARAM( "/qstart.desktop" ) );
 #endif // UNX
 return aShortcut;
@@ -857,7 +865,7 @@ void ShutdownIcon::SetAutostart( bool bActivate )
 #ifdef WNT
 EnableAutostartW32( aShortcut );
 #else // UNX
-getDotAutostart( true );
+getAutostartDir( true );
 
 OUString aPath( 
RTL_CONSTASCII_USTRINGPARAM("${BRAND_BASE_DIR}/share/xdg/qstart.desktop" ) );
 Bootstrap::expandMacros( aPath );
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

[Noel Power]

 sending again :/
On 18/10/10 14:06, Povilas Kanapickas wrote:

Hello,

I've done some work on entry level tasks. Specifically, I've removed 
all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus 
comments like /*N*/, /*?*/ and so on were removed. As more than 
thousand of files have been changed I didn't try to make a separate 
patch for each one. Some of the resulting patches were really large 
(10MB+) thus I uploaded them to external storage. Here's the link:


https://docs.google.com/leaf?id=0B17lV1Y1fK9UMTM3ZDRlOWUtMjFlNi00YTE0LTg2NjgtYjdlOGVkNTljZDZj&hl=en&authkey=CNjS9v0C 



I contribute under LGPLv3+. Hope you can merge my contributions :)

Regards,
Povilas

I've looked at the basic part, looks good to me, currently I am in the 
middle of a build, I will apply it later, check again and push it ( will 
post here about that ). Thanks again!!! much apprecialted


Noel

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

[Noel Power]

 On 18/10/10 14:06, Povilas Kanapickas wrote:

Hello,

I've done some work on entry level tasks. Specifically, I've removed 
all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus 
comments like /*N*/, /*?*/ and so on were removed. As more than 
thousand of files have been changed I didn't try to make a separate 
patch for each one. Some of the resulting patches were really large 
(10MB+) thus I uploaded them to external storage. Here's the link:


https://docs.google.com/leaf?id=0B17lV1Y1fK9UMTM3ZDRlOWUtMjFlNi00YTE0LTg2NjgtYjdlOGVkNTljZDZj&hl=en&authkey=CNjS9v0C 



I contribute under LGPLv3+. Hope you can merge my contributions :)

Regards,
Povilas

I've looked at the basic part, looks good to me, currently I am in the 
middle of a build, I will apply it later, check again and push it ( will 
post here about that ). Thanks again!!! much apprecialted


Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

[Kohei Yoshida]

On Wed, 2010-10-20 at 04:46 -0500, Norbert Thiebaud wrote:
> On Wed, Oct 20, 2010 at 4:24 AM, Kohei Yoshida  wrote:
> > On Mon, 2010-10-18 at 14:06 -0400, Kohei Yoshida wrote:
> >> On Mon, 2010-10-18 at 16:53 +0100, Michael Meeks wrote:
> >> > Everything except the 'filters' patch has been either pushed,
> >> > or sent
> >> > to the component maintainer for review.
> >>
> >> And I'm reviewing the calc part of your patch.  At first glance there
> >> are several hunks that I'd like to keep, but I'll go through it soon.
> >> I'll be traveling in the next few days, so my time will be rather
> >> limited while traveling...
> >
> > Just finished reviewing and applied most of your changes.  Thanks a lot!
> >
> 
> Was it intentional to add dead code in the remove dead code patch :-) ?

Yes, because I wanted to keep that code, but it made no sense to disable
only what's inside the if statement.  Instead, I've opted to disable the
whole if statement block.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

[Norbert Thiebaud]

On Wed, Oct 20, 2010 at 4:24 AM, Kohei Yoshida  wrote:
> On Mon, 2010-10-18 at 14:06 -0400, Kohei Yoshida wrote:
>> On Mon, 2010-10-18 at 16:53 +0100, Michael Meeks wrote:
>> >         Everything except the 'filters' patch has been either pushed,
>> > or sent
>> > to the component maintainer for review.
>>
>> And I'm reviewing the calc part of your patch.  At first glance there
>> are several hunks that I'd like to keep, but I'll go through it soon.
>> I'll be traveling in the next few days, so my time will be rather
>> limited while traveling...
>
> Just finished reviewing and applied most of your changes.  Thanks a lot!
>

Was it intentional to add dead code in the remove dead code patch :-) ?

--- sc/source/ui/docshell/docsh4.cxx ---
index 49d763c..353fff9 100644
@@ -2128,6 +2128,7 @@ void ScDocShell::Print( SfxProgress& rProgress,
PrintDialog* pPrintDialog,
 }
 }

+#if 0
 if ( n+1 < nCollateCopies &&
  (pPrinter->GetDuplexMode() == DUPLEX_SHORTEDGE ||
pPrinter->GetDuplexMode() == DUPLEX_LONGEDGE) &&
  ( nPrinted % 2 ) == 1 )
@@ -2138,11 +2139,10 @@ void ScDocShell::Print( SfxProgress&
rProgress, PrintDialog* pPrintDialog,
 // (same as in Writer ViewShell::Prt)

 // FIXME: needs to be adapted to XRenderable interface
-#if 0
 pPrinter->StartPage();
 pPrinter->EndPage();
-#endif
 }
+#endif
 }
 }

Norbert

> Kohei
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc
> 
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

[Kohei Yoshida]

On Mon, 2010-10-18 at 14:06 -0400, Kohei Yoshida wrote:
> On Mon, 2010-10-18 at 16:53 +0100, Michael Meeks wrote:
> > Everything except the 'filters' patch has been either pushed,
> > or sent
> > to the component maintainer for review. 
> 
> And I'm reviewing the calc part of your patch.  At first glance there
> are several hunks that I'd like to keep, but I'll go through it soon.
> I'll be traveling in the next few days, so my time will be rather
> limited while traveling...

Just finished reviewing and applied most of your changes.  Thanks a lot!

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [FIX] forgot semicolon in svx/source/intro/ooo.src

[Caolán McNamara]

On Tue, 2010-10-19 at 21:52 +0200, julien wrote:
> Hi,
> 
> Just a quick fix for this file.

Thanks, wiz committed and pushed this one.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Building on gentoo ...

[Sebastian Spaeth]

On Tue, 19 Oct 2010 23:45:11 +0200, René Kjellerup  
wrote:

> On the other matter unless you're still running kde 3 then you need
> --disable-kde else the config will fail when it can't find Qt 3.x

On that matter can, we please --disable-kde by default. I don't know of
recent distros that ship kde3 but not KDE4, and those who do can turn it
on in their distro-specific defaults.

Even better, our make should detect the lack of qt3 headers and disable
it automatically rather than bailing out.

Sebastian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice