[Libreoffice] [PATCH] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 3
HI, here are some more in libs-core Regards. 10_libs-core.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Questions about ./sdext/source/minimizer/unodialog.cxx
On Sun, Nov 7, 2010 at 7:00 AM, julien serval2...@yahoo.fr wrote:
Hello,
I'm currently running a cppcheck on the clone directory (i had try to launch
cppcheck on the build/libreoffice... but it seemed it freezed).
I've seen this issue :
[./extensions/sdext/source/minimizer/unodialog.cxx:359]: (error) Division by
zero
I opened the file and saw this :
sal_Int32 UnoDialog::getMapsFromPixels( sal_Int32 nPixels ) const
{
double dMaps = 0;
try
{
sal_Int32 nMapWidth = 0;
const OUString sWidth( RTL_CONSTASCII_USTRINGPARAM( Width ) );
if ( mxDialogModelPropertySet-getPropertyValue( sWidth ) =
nMapWidth )
{
Reference XWindow xWindow( mxDialog, UNO_QUERY_THROW );
double pxWidth = xWindow-getPosSize().Width;
double mapRatio = ( pxWidth / nMapWidth ); --- HERE IS THE
DIVSION BY ZERO DETECTED BY CPPCHECK
dMaps = nPixels / mapRatio;
}
}
catch ( Exception )
{
}
return static_cast sal_Int32 ( dMaps );
}
Questions :
- what's the use of nMapWidth since it's initialized to 0 and stays at this
value ?
- What's the use of making a right rotation of bits of 0 ?
(mxDialogModelPropertySet-getPropertyValue( sWidth ) = nMapWidth)
Ahh, welcome to the wonderful world of operator overload.
= is not a right shift but instead, here, nMapWith get populated with the
property (uno) value, converted to a int32.
and the if() can only be true if that value is not 0
so here you have a false positive.
Norbert
- what's the use of a catch with nothing in it except for hidding a bug ?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] use LIBTARGET=NO to avoid multiple definition of target recipe
The diff makes i18npool/source/paper/makefile.mk define LIBTARGET=NO just like other makefiles in the i18npool/source/ directory. Without this patch I always get: dmake: /home/robert/build/build/libreoffice-3.2.99.2/solenv/inc/_tg_lib.mk: line 1020: Error: -- Multiply defined recipe for target ../../unxobsd.pro/slb/i18npaper.lib Okay to push? --- i18npool/source/paper/makefile.mk |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/i18npool/source/paper/makefile.mk b/i18npool/source/paper/makefile.mk index fa05cc2..ea67c19 100644 --- a/i18npool/source/paper/makefile.mk +++ b/i18npool/source/paper/makefile.mk @@ -29,6 +29,7 @@ PRJ=..$/.. PRJNAME=i18npool TARGET=i18npaper +LIBTARGET=NO ENABLE_EXCEPTIONS=TRUE -- 1.7.3.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] EasyHacks: Accelerate Perl Installer
Hi,
I was looking at the perl installer, and attached are patches to
change most of the chmod system calls into calls to the built-in
command. This change alone doesn't seem to make a big difference (it
cut about 5 seconds off of a 4 1/2 minute run of ooinstall for me).
The second patch includes the replacement of a couple of two-step
chmod calls with a single built-in call; the original code indicated
that it was a work-around for removing the sticky bit on Macs. I
don't have a Mac to test that the new call handles sticky bits in the
same way, but expect that it will from checking the current perlport
doc.
LGPLv3+/MPL.
Jordan Ayers
From 09210008700de4243b249e157a3df83a317bbac2 Mon Sep 17 00:00:00 2001
From: Jordan Ayers jordan.ay...@gmail.com
Date: Sun, 7 Nov 2010 18:02:12 -0600
Subject: [PATCH 1/2] Perl Installer: Use built-in chmod
Replace several system calls which performed single-file permission sets with the built-in chmod command.
---
solenv/bin/modules/installer/copyproject.pm | 24 +---
solenv/bin/modules/installer/download.pm |6 ++
solenv/bin/modules/installer/epmfile.pm | 21 ++---
solenv/bin/modules/installer/javainstaller.pm |6 ++
solenv/bin/modules/installer/languagepack.pm |3 +--
solenv/bin/modules/installer/parameter.pm |3 +--
solenv/bin/modules/installer/simplepackage.pm | 12 +++-
solenv/bin/modules/installer/worker.pm| 12
8 files changed, 24 insertions(+), 63 deletions(-)
diff --git a/solenv/bin/modules/installer/copyproject.pm b/solenv/bin/modules/installer/copyproject.pm
index 88f3b79..93f4d29 100644
--- a/solenv/bin/modules/installer/copyproject.pm
+++ b/solenv/bin/modules/installer/copyproject.pm
@@ -69,17 +69,14 @@ sub copy_project
installer::systemactions::copy_one_file($source, $destination);
-if ( $destination =~ /install\s*$/ )
+if ( $onefile-{'UnixRights'} )
{
-my $localcall = chmod 775 $destination \\/dev\/null 2\\1;
-system($localcall);
+chmod oct($onefile-{'UnixRights'}), $destination;
}
-
-if ( $onefile-{'UnixRights'} )
+elsif ( $destination =~ /install\s*$/ )
{
-my $localcall = chmod $onefile-{'UnixRights'} $destination \\/dev\/null 2\\1;
-system($localcall);
-}
+chmod 0775, $destination;
+}
}
# copy ScpActions
@@ -93,16 +90,13 @@ sub copy_project
installer::systemactions::copy_one_file($source, $destination);
-if ( $destination =~ /install\s*$/ )
+if ( $onefile-{'UnixRights'} )
{
-my $localcall = chmod 775 $destination \\/dev\/null 2\\1;
-system($localcall);
+chmod oct($onefile-{'UnixRights'}), $destination;
}
-
-if ( $onefile-{'UnixRights'} )
+elsif ( $destination =~ /install\s*$/ )
{
-my $localcall = chmod $onefile-{'UnixRights'} $destination \\/dev\/null 2\\1;
-system($localcall);
+chmod 0775, $destination;
}
}
diff --git a/solenv/bin/modules/installer/download.pm b/solenv/bin/modules/installer/download.pm
index 8e70bbb..7b30c43 100644
--- a/solenv/bin/modules/installer/download.pm
+++ b/solenv/bin/modules/installer/download.pm
@@ -118,8 +118,7 @@ sub save_script_file
if ( ! $installer::globals::iswindowsbuild )
{
-my $localcall = chmod 775 $newscriptfilename \\/dev\/null 2\\1;
-system($localcall);
+chmod 0775, $newscriptfilename;
}
return $newscriptfilename;
@@ -339,8 +338,7 @@ sub tar_package
push( @installer::globals::logfileinfo, $infoline);
}
-my $localcall = chmod 775 $tarfilename \\/dev\/null 2\\1;
-$returnvalue = system($localcall);
+chmod 0775, $tarfilename;
return ( -s $tarfilename );
}
diff --git a/solenv/bin/modules/installer/epmfile.pm b/solenv/bin/modules/installer/epmfile.pm
index 2af2f3c..0e1b18a 100644
--- a/solenv/bin/modules/installer/epmfile.pm
+++ b/solenv/bin/modules/installer/epmfile.pm
@@ -2875,23 +2875,7 @@ sub create_new_directory_structure
}
# Setting unix rights to 775 for $newdir (RPMS or packages)
-
-my $localcall = chmod 775 $newdir \\/dev\/null 2\\1;
-my $callreturnvalue = system($localcall);
-
-my $callinfoline = Systemcall: $localcall\n;
-push( @installer::globals::logfileinfo, $callinfoline);
-
-if ($callreturnvalue)
-{
-$callinfoline = ERROR: Could not execute \$localcall\!\n;
-push( @installer::globals::logfileinfo, $callinfoline);
-}
-else
-{
-$callinfoline = Success: Executed \$localcall\ successfully!\n;
-push( @installer::globals::logfileinfo, $callinfoline);
-}
+chmod 0775, $newdir;
}
Re: [Libreoffice] Build on Ubuntu 10.10 fails with 'missing image.hxx'
On Sun, Nov 7, 2010 at 11:08 AM, Fred Jendrzejewki fred.jendrzejew...@gmail.com wrote: Hello, I try to build on Ubuntu 10.10 amd64 the master branch. Then I get the following error message: build -- version: 275224 = Building module canvas = ... dmake: Error: -- `image.hxx' not found, and can't be made Didn't find anything in the archives about that. Fred, as discussed on IRC, this is most likely a 'ghost' dependency. that require a rebuild of the said module based on the instruction given in the wiki: http://wiki.documentfoundation.org/Development/How_to_build#The_Build_Failed..._What_can_I_do.C2.A0.3F Norbert Kind regards, Fred ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Some more rtl easy hack goodness
Hullo List, Some accessibility tabbar RTL_CONST conversion goodness. Kevin 0001-EasyHack-createFromAscii-RTL_CONST.-macro.patch.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][Pushed] one last patch for base/dbaccess/core/api
On Sun, Nov 7, 2010 at 11:12 AM, Wols Lists antli...@youngman.org.uk wrote: Just deleting a bit of commented out code - that's dbaccess/source/core/api pretty much done. Pushed, thanks. Norbert Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] comment removal, rtl easy hack
Hullo Committers, A patch set against directory: accessibility/source/helper Cheers, Kevin comment_removal_2.tgz Description: application/compressed-tar 0001-EasyHack-convert-createFromAscii-to-RTL.-macro.patch.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] large swathes of commented/#if 0 code removed
Hullo Committers, Subject says it all. Patch against three files under automation/source/ Builds successfully here. Cheers, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] large swathes of commented/#if 0 code removed
At 2:17am -0500 Mon, 08 Nov 2010, Kevin Hunter wrote: Subject says it all. Patch against three files under automation/source/ Doh! Helps to actually /attach/ the file. Kevin large_swathes_gone.tbz Description: application/bzip-compressed-tar ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
