Re: [Libreoffice] How to use gprof on LibO?
Thank you for your answers, I will try both approces. Oh - fun :-) is a complete expunging of the obsolete types not possible ? I very much hope it is possible, but tools/list is in the codebase used for both classic list purposes and for situations where the object is created once, is sorted, and then there is a lot of random access, so here a vector would be better. But to find out which of these two cases we are in, profiling could help. Regards Sören 2011/1/31 Michael Meeks michael.me...@novell.com: Hi Soeren, On Sat, 2011-01-29 at 15:50 +0100, Soeren Moeller wrote: In our effort of replacing deprecated data types from tools/ by std:: types we would like to use gprof for profiling (to choose the right data types). Oh - fun :-) is a complete expunging of the obsolete types not possible ? But unfortunately, we don't know to set the -pg flag, and where the gmon.out file would go. Has anyone of you experiences with profiling LibO, and would like to tell us, how to do? I always use callgrind instead; and I use it like this: export OOO_DISABLE_RECOVERY=1 valgrind --tool=callgrind --simulate-cache=yes --dump-instr=yes ./soffice.bin -writer -splash-pipe=0 Then I use 'kcachegrind' on the output. Now - possibly you want to use callgrind_control -z just before you start doing something fun in calc - so that you can not get swamped by the startup cost; and of course - this method is fairly slow, and really you need to build with debug symbols to get a good view of what is up. OTOH - it is a wonderful tool ;-) HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] GTK: remove menu when we press the alt key
On Mon, 2011-01-31 at 11:22 +, Michael Meeks wrote: Do you want this on the libreoffice-3-3 branch ? I'd be happy to have it there, if you're ok to review it Looks fine to me. Pushed to 3-3. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
2011/2/1 Jean-Baptiste Faure jbf.fa...@orange.fr: Yes but instead of having the choice between default installation and custom installation, I suggest that the installer gives the alternative : 1/ choose yourself the components and dictionaries you want to be installed in this case select by default only the language of the locale. 2/ full installation : all components and all dictionaries will be installed Another possibilty is: 1/ only your locale (default) 2/ full installation 3/ choose yourself What is the software used to make the MS-Windows Installer ? NSIS ? In fact there is http://opengrok.go-oo.org/xref/components/setup_native/source/packinfo/spellchecker_selection.txt that can be used. The information in this file can be hacked into the respective trans_lang.mst files, so they will give sensible defaults. If you agree, I'll file a bug and start to work on implementation details. Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Call-catcher: removed unused functions in calc
Hi,
Please find attached patch (made available under LGPLv3+/MPL) containing
removal
of unused functions in calc as identified by call-catcher.
Patch has been rebased and compiled without errors.
Please, disregard my previous patch commenting out these calc functions, as
Cedric suggested, this new patch directly removes the functions.
Thanks regards,
Alfonso
From 18e45467342802383fa944c469141f4042bd0c8b Mon Sep 17 00:00:00 2001
From: Alfonso Eusebio alfonso_euse...@yahoo.co.uk
Date: Tue, 1 Feb 2011 08:20:47 +
Subject: [PATCH] Call-catcher: removed unused functions in calc
Removed unused functions from calc using the call-catcher list available
in Easy Tasks (first batch).
---
sc/inc/compressedarray.hxx | 154 ---
sc/source/core/data/attarray.cxx |1 -
sc/source/core/data/compressedarray.cxx| 155
sc/source/filter/excel/xestream.cxx| 11 +--
sc/source/filter/excel/xestring.cxx| 16 ---
sc/source/filter/excel/xihelper.cxx|5 -
sc/source/filter/excel/xipivot.cxx | 18 ---
sc/source/filter/excel/xistream.cxx| 19
sc/source/filter/excel/xltracer.cxx|6 -
sc/source/filter/inc/XclImpChangeTrack.hxx |6 -
sc/source/filter/inc/xestream.hxx |2 -
sc/source/filter/inc/xestring.hxx | 20 +---
sc/source/filter/inc/xihelper.hxx |7 --
sc/source/filter/inc/xipivot.hxx |4 -
sc/source/filter/inc/xistream.hxx |4 -
sc/source/filter/inc/xltracer.hxx |1 -
16 files changed, 4 insertions(+), 425 deletions(-)
diff --git a/sc/inc/compressedarray.hxx b/sc/inc/compressedarray.hxx
index efc5cd7..12a5940 100644
--- a/sc/inc/compressedarray.hxx
+++ b/sc/inc/compressedarray.hxx
@@ -89,18 +89,11 @@ public:
/** Get value for a row, and it's region end row */
const DGetValue( A nPos, size_t nIndex, A nEnd ) const;
-/** Get value for a row, and it's region start row and end row */
-const DGetValue( A nPos, size_t nIndex, A nStart, A nEnd ) const;
-
/** Get next value and it's region end row. If nIndexnCount, nIndex is
incremented first. If the resulting nIndex=nCount, the value of the
last entry is returned again. */
const DGetNextValue( size_t nIndex, A nEnd ) const;
-/** Get previous value and it's region start row. If nIndex==0, nIndex is
-not decremented and the value of the first entry is returned again. */
-const DGetPrevValue( size_t nIndex, A nStart ) const;
-
/** Insert rows before nStart and copy value for inserted rows from
nStart-1, return that value. */
const DInsert( A nStart, size_t nCount );
@@ -117,8 +110,6 @@ public:
SC_DLLPUBLIC size_t Search( A nPos ) const;
/** Get number of entries */
size_t GetEntryCount() const;
-/** Get data entry for an index */
-const DataEntryGetDataEntry( size_t nIndex ) const;
protected:
@@ -171,17 +162,6 @@ const D ScCompressedArrayA,D::GetValue( A nPos, size_t nIndex, A nEnd ) con
template typename A, typename D
-const D ScCompressedArrayA,D::GetValue( A nPos, size_t nIndex, A nStart,
-A nEnd ) const
-{
-nIndex = Search( nPos);
-nStart = (nIndex 0 ? pData[nIndex-1].nEnd + 1 : 0);
-nEnd = pData[nIndex].nEnd;
-return pData[nIndex].aValue;
-}
-
-
-template typename A, typename D
const D ScCompressedArrayA,D::GetNextValue( size_t nIndex, A nEnd ) const
{
if (nIndex nCount)
@@ -193,30 +173,12 @@ const D ScCompressedArrayA,D::GetNextValue( size_t nIndex, A nEnd ) const
template typename A, typename D
-const D ScCompressedArrayA,D::GetPrevValue( size_t nIndex, A nStart ) const
-{
-if (nIndex 0)
---nIndex;
-nStart = (nIndex 0 ? pData[nIndex-1].nEnd + 1 : 0);
-return pData[nIndex].aValue;
-}
-
-
-template typename A, typename D
size_t ScCompressedArrayA,D::GetEntryCount() const
{
return nCount;
}
-template typename A, typename D
-const typename ScCompressedArrayA,D::DataEntry
-ScCompressedArrayA,D::GetDataEntry( size_t nIndex ) const
-{
-return pData[nIndex];
-}
-
-
// === ScCompressedArrayIterator =
/** Iterator for ScCompressedArray.
@@ -474,21 +436,6 @@ public:
meets this condition, ::std::numeric_limitsA::max() is returned. */
A GetLastAnyBitAccess( A nStart,
const D rBitMask ) const;
-
-/** Sum values of a ScSummableCompressedArray for each row where in *this*
-array the condition is met: ((aValue rBitMask) == rMaskedCompare). */
-template typename S
-SC_DLLPUBLIC unsigned long SumCoupledArrayForCondition( A nStart, A nEnd,
-
[Libreoffice] [PATCH] bsdtar works as fine as gnu tar
Hi, On FreeBSD we use bsdtar (libarchive) and from my testings it works great with libreoffice (no regression compared to gnu tar) here is an attempt to allow checking for both bsdtar and gnu tar in configure (against build git repository) Hope this is ok regards, Bapt diff --git a/configure.in b/configure.in index d23440c..b427511 100755 --- a/configure.in +++ b/configure.in @@ -1334,9 +1334,9 @@ if test -z $BASH; then fi AC_SUBST(BASH) -AC_MSG_CHECKING([for GNU tar]) +AC_MSG_CHECKING([for GNU or BSD tar]) for a in $GNUTAR gtar gnutar tar; do - $a --version 2 /dev/null | grep GNU 21 /dev/null + $a --version 2 /dev/null | egrep GNU|bsdtar 21 /dev/null if test $? -eq 0; then GNUTAR=$a break @@ -1344,7 +1344,7 @@ for a in $GNUTAR gtar gnutar tar; do done AC_MSG_RESULT($GNUTAR) if test -z $GNUTAR; then -AC_MSG_ERROR([not found. install GNU tar.]) +AC_MSG_ERROR([not found. install GNU or BSD tar.]) fi AC_SUBST(GNUTAR) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
In fact there is http://opengrok.go-oo.org/xref/components/setup_native/source/packinfo/spellchecker_selection.txt that can be used. I strongly oppose. That file makes exactly the kind of political choices that very many people will find at least odd, awkward, and at worst interpret as signs of some hidden agenda and cultural imperialism. For instance, I find it a bit odd that a Finnish dictionary would not be included (in a quick install) if I in Finland install LibreOffice, just because if I happen to be running a Swedish (my native language) localisation of Windows. I live in Finland and know and use Finnish daily. So a Swedish UI should then imply including a Finnish dictionary, right? (The Swedes in Sweden might wonder a bit, but probably wouldn't mind.) And surely then also a Finnish UI should imply including a Swedish dictionary, as legally speaking both languages have equal status here. But on the other hand, especially among the majority language (Finnish) speakers here some are very antagonistic to the minority language, and that would then piss many of them off, LibreOffice is clearly in favour if pakkoruotsi (google for it), screw them, I'll start a boycott group on Facebook!. Etc, you get the point, and Finland is a very peaceful country and (hopefully) only a small minority have these strong opinions. I can imagine the reactions among more hot-blooded youths elsewhere. And do we *really* want to imply than American English is needed by everyone? Why not British English? Shouldn't we here in Europe at least be writing in British English? And should we really take the stand that German is needed in many European countries, but certainly not in France (that sounds almost like joking about people's prejudices, doesn't it) or Britain for instance? Better to not try to make any automatic guesstimates here, and just install all the available dictionaries, if the person running the installer can't be bothered to do a custom installation and select dictionaries explicitly him/herself. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove Mizi Research copyright note for hwpfilter
On Mon, 2011-01-31 at 22:30 +0100, Thomas Arnhold wrote: Thanks. Filed a bug #33782. I moved your findings over to Oracle, seeing as they own the copyrights on those. But looking at your list, I think that those .awk scripts and weird .r files are simply unused junk that could be deleted entirely. You could see if anything breaks if they are removed and try deleting them. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] bsdtar works as fine as gnu tar
On Tue, 2011-02-01 at 10:26 +0100, Baptiste Daroussin wrote: On FreeBSD we use bsdtar (libarchive) and from my testings it works great with libreoffice (no regression compared to gnu tar) Good stuff; pushed it - lets see if someone else has a problem with egrep ;-) ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: fontconfig / l10n issue with font names ...
On Mon, 2011-01-31 at 13:18 +, Michael Meeks wrote: Hi Caolan, Any chance you could review Petr Gajdos's attached patch; AFAIR you are a bit of a fontconfig wizard ;-) It is to fix this: Looks good, though we don't need to add to the to/from localized name map the Bold Italic terms in the same same way we cache the Localized font names, so I added another tweak to exclude the style names from the cache. If someone wants to review and cherry-pick them for 3-3, then libs-gui: 650ad1697d1e8087159f6c7de51e36a9ae428de4 b77f7f6cf6cf8789d82f1cbda7298fc290728143 As an aside, this font stuff used to live in a module called psprint which was built before vcl, now it lives inside vcl, so we've ended up with basically duplicated enums of psp::width/FontWidth, psp::italic/FontItalic, etc and convert to and from them rather pointlessly. If someone has an interest they could probably strip out and replace the psp:: variants with the main-stream vcl ones and simplify the code somewhat. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error in en_us readme file ?
On Sun, 2011-01-30 at 16:38 -0500, drew wrote: Updated readme file attached. Do you think you could make a patch against the original README content, i.e. readlicense_oo/docs/readme/readme.xrm ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] translated some german comments
Hi Pascal, On Mon, 2011-01-31 at 21:51 +0100, TentleXS wrote: I do not have much time right now. So the comments in the file are not all translated yet. But every litte bit helps, right? :) Right ! :-) much appreciated, pushed it. Incidentally - I know people like things like 'sw', but I was reading (eg.) svtools/inc/ruler.hxx yesterday - specifying an easy-hack around there, and noticed some monster German comment that is (perhaps) easier to translate: five or six pages of text ;-) [ almost certainly inaccurate by now - but perhaps interesting in English ]. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Easy hacks: removed double line spacing
On Mon, 2011-01-31 at 14:49 +0100, Christina Roßmanith wrote: Yes. LGPLv3+ and MPL as usual. no patch was attached. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] remove old icon themes ...
On Mon, 2011-01-31 at 16:51 +, Michael Meeks wrote: +--with-theme=default hicontrast tango But would that leave tools-options-libreoffice-view-icon size and style listing themes that aren't available ? Or does it all work out ok. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] ure: Some fixes to documentation (part 6)
On Mon, 2011-01-31 at 19:51 +0200, Aurimas Fišeras wrote: This is the last part in the series. Looks good, pushed, thanks for this. P. S. Also attached for reference: 1. ure_spellcheck.sh my crude, organically grown shell script that I used to significantly speed up this spell checking process. 2. .hunspell_en_US_libo - personal hunspell dictionary that resulted from this spell checking process. Do you want to try and cook up e.g. a make spellcheck target in Makefile.am to auto-run your script, which you could e.g. put in solenv/bin and stash the personal dictionary somewhere in there too ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
On Tue, 2011-02-01 at 02:51 -0700, Tor Lillqvist wrote: But on the other hand, especially among the majority language (Finnish) speakers here some are very antagonistic to the minority language ... Should we try to add some flags into the mix to clarify the situation ? ;- I really think the solution is simply to partition / categorise the extensions in the list - it should be that simple. The code in question is here: desktop/source/deployment/gui/dp_gui_dialog2.src and desktop/source/deplyoment/gui/dp_gui_extlistbox.* Shouldn't be impossibly hard to add some simple filtering to that for built-in / bundled extensions that would hide most of them from people and default to not showing bundled extensions. I'll add an easy hack for it if no-one jumps onto it. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] remove old icon themes ...
On Tue, 2011-02-01 at 10:33 +, Caolán McNamara wrote: On Mon, 2011-01-31 at 16:51 +, Michael Meeks wrote: +--with-theme=default hicontrast tango But would that leave tools-options-libreoffice-view-icon size and style listing themes that aren't available ? Or does it all work out ok. It works out ok. The list shrinks to the set of available icon sets - and we fallback to the platform default icon set if we had previously been configured to use an icon set that no longer exists - ie. it just works(TM) ;-) [ at least in my tests here ]. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: fontconfig / l10n issue with font names ...
On Tue, 2011-02-01 at 10:21 +, Caolán McNamara wrote: If someone wants to review and cherry-pick them for 3-3, then libs-gui: 650ad1697d1e8087159f6c7de51e36a9ae428de4 b77f7f6cf6cf8789d82f1cbda7298fc290728143 Bug has been open since 2008 ;-) so there is no huge rush for libreoffice-3-3 I think, unless you're recommending it. As an aside, this font stuff used to live in a module called psprint which was built before vcl, now it lives inside vcl, so we've ended up with basically duplicated enums of psp::width/FontWidth, I'll add an easy hack for this. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] [EPS Export] Fix Save as Picture
On Tue, 2011-02-01 at 13:54 +0900, KUROSAWA, Takeshi wrote: Hi, Currently Save as Picture feature in Writer, Impress, or Draw produces a broken EPS file when I save an image as EPS format. # Export feature produces a correct file. Here is a patch to fix this issue. Seems reasonable, if the graphic doesn't have a metafile, i.e. is a bitmap then render the bitmap into a temporary metafile and export that instead. Thanks for this, now pushed. I did add another tweak to basically retain and use the original else branch, but this time only if the metafile returned from GetGDIMetaFile() has an ActionCount. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: fontconfig / l10n issue with font names ...
On Tue, 2011-02-01 at 11:10 +, Michael Meeks wrote: On Tue, 2011-02-01 at 10:21 +, Caolán McNamara wrote: If someone wants to review and cherry-pick them for 3-3, then libs-gui: 650ad1697d1e8087159f6c7de51e36a9ae428de4 b77f7f6cf6cf8789d82f1cbda7298fc290728143 Bug has been open since 2008 ;-) so there is no huge rush for libreoffice-3-3 I think, unless you're recommending it. Nah, doesn't hurt anyone seriously I guess. As an aside, this font stuff used to live in a module called psprint which was built before vcl, now it lives inside vcl, so we've ended up with basically duplicated enums of psp::width/FontWidth, I'll add an easy hack for this. Thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] leak per frame, mac input request.
So, after clearing up a pile of circular ownership things to clear out deadwood blocking valgrind from telling me what I wanted to know I tracked down a a leak in framework/source/services/frame.cxx where for each frame we do a new WindowCommandDispatch, and the comment claims that the WindowCommandDispatch will release itself at frame destruction. It doesn't of course, its implemented as a uno XEventListener but doesn't register itself as a uno listener to the frame to even have a chance of doing the right thing. It itself registers itself as a vcl listener to the frame, and doesn't delete itself on OBJ_DYING. So, I could remove the XEventListener foo, add a delete this on OBJ_DYING to remove the leak. My open question though, is it that this WindowCommandDispatch exists apparently do bind some mac About and Preferences events to do the right thing on that platform. What's special about About/Preferences in Mac ?, and does it currently work correctly ?, i.e. its worth fixing this rather than removing it entirely. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
On 1 February 2011 07:53, Tor Lillqvist tlillqv...@novell.com wrote: With the clarification that it is the *Cygwin* command line, yes. seems I already have gnu make in my path on windows from the mingw Nah, that is not usable for this. It must be the Cygwin make that is used for this (and other Cygwin tools, as described in the wiki). (The Cygwin make is as such not used for much in the LO build process, just at the very top level. For the rest LO's own dmake is used.) And to avoid any possibility of confusion, make sure your non-related development environment(s) don't show up in any environment variables (PATH, LIBS, etc) in the LO build environment. --tml Ok, I've not done any more work on developing this as I have been working on getting a win32 (actually 64 bit win 7) build environment working tonight. I haven't got very far but I will try to note the steps I've taken as I go. I'm currently going to have to give up for the night as it is complaining about the MozillaBuildSetup tools and it's 79 MB and coming down from ftp.mozilla.com at dialup speed :( I'm very new to git so I gave up on --reference and just did a straight clone from my SMB share, which was relatively quick, but of course I only got the bootstrap. Once I get past bootstrap stage, is the git part going to grab relative to bootstrap or go straight to libreoffice.org? I was thinking about manually cloning each of the repositories in the clone directory if necessary to short circuit this. Here's my steps so far: 1. Install Cygwin - pick all development tools and install (much later) 2. Clone the bootstrap git project from SMB share and copied the src files. 3. In Cygwin shell, the autogen failed with an odd error related to Native programs and symlinks. I got past this by doing the following: cd /bin rm /usr/bin/awk cp /usr/bin/gawk.exe awk.exe cp /usr/bin/gzip.exe gunzip.exe 4. After this, it seemed to pick my MSVC2008 Express install as the compiler (I also had several cygwin gcc versions installed but it seems to have ignored them), then I needed to add the jdk 6 home to the config option ./autogen.sh --with-jdk-home=/cygdrive/c/Program\ Files/Java/jdk1.6.0_18/ 5. I now find I need the mozilla build tools and to add another config option Download http://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32/MozillaBuildSetup-Latest.exe (very slow 2 hour download :( ) will install it in the morning if it's finished downloading... I'll keep adding to this list in case it helps someone else out. -- Regards, Steven Butler ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Fix for bug n#664516
Hi all, I have just fixed the bug n#664516, around the new writer table formulas and would like to integrate it in 3.3 branch. This bug only affects the distributions adding the patches/dev300/fields-table-formula.diff The fix to push is on master, could anyone review it? http://cgit.freedesktop.org/libreoffice/build/commit/?id=1bdae011acbbd886e6d13a8e45ab908d8e8c8296 Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] Fix for bug n#664516
Hello Michael, On Tue, 2011-02-01 at 13:57 +, Michael Meeks wrote: On Tue, 2011-02-01 at 14:27 +0100, Cedric Bosdonnat wrote: I have just fixed the bug n#664516, around the new writer table formulas and would like to integrate it in 3.3 branch. This bug only affects the distributions adding the patches/dev300/fields-table-formula.diff The fix to push is on master, could anyone review it? http://cgit.freedesktop.org/libreoffice/build/commit/?id=1bdae011acbbd886e6d13a8e45ab908d8e8c8296 Looks fine to me; and as you say a minority problem; can you cherry pick it ? Thanks for the review. I have cherry-picked it then. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Call-catcher: removed unused functions in calc
On Tue, 2011-02-01 at 08:59 +, Alfonso Eusebio wrote: Hi, Please find attached patch (made available under LGPLv3+/MPL) containing removal of unused functions in calc as identified by call-catcher. Patch has been rebased and compiled without errors. Thanks. Pushed. I also removed the one method you'd commented out. That one appears to be unused. I'm build-testing it in debug mode right now. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Call-catcher: removed unused functions in calc
On Tue, 2011-02-01 at 09:31 -0500, Kohei Yoshida wrote: I'm build-testing it in debug mode right now. Done. build debug=t also builds fine. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] How to use gprof on LibO?
Hi Soeren, On Tue, 2011-02-01 at 09:33 +0100, Soeren Moeller wrote: Thank you for your answers, I will try both approces. Oh - fun :-) is a complete expunging of the obsolete types not possible ? .. I very much hope it is possible, but tools/list is in the codebase used for both classic list purposes and for situations where the object is created once, is sorted, and then there is a lot of random Ah - right :-) so, I suspect the common way to handle these is simply to look around at the code accessing a given list, and consider how frequently it is likely to be accessed. The std::vector also (kohei suggested) is fast to append to if we do it carefully - so ... Ultimately, run-time profiling will only show you what your data set touches, and (as yet) we have no reliable set of representative calc documents together to know what they look like ;-) So - I would personally, just recommend converting them using a bit of common sense / poking around to infer their use. We'll get performance regression complaints later if we go too far wrong no doubt :-) Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] freebsd support
Hey, I am not sure that the a/desktop/scripts/soffice.sh diff is needed on FreeBSD, I tought $ORIGIN works fine there. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] freebsd support
2011/2/1 Robert Nagy rob...@openbsd.org: Hey, I am not sure that the a/desktop/scripts/soffice.sh diff is needed on FreeBSD, I tought $ORIGIN works fine there. nope I wasn't able to run it without sur LD_LIBRARY_PATH but maybe there is something I don't know which would prevent me from doing that :) regards, Bapt ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] custom icon
Hello all,
Is it possible to build LibOffice with a custom icon.
For example, we want to use a customized icon
by adding a drum to the background of LibO icon like this
http://vi.openoffice.org/images/oooviet3.png
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] bsdtar works as fine as gnu tar
On Tue, Feb 1, 2011 at 4:26 PM, Baptiste Daroussin b...@freebsd.org wrote:
Hi,
On FreeBSD we use bsdtar (libarchive) and from my testings it works
great with libreoffice (no regression compared to gnu tar)
here is an attempt to allow checking for both bsdtar and gnu tar in
configure (against build git repository)
A person who tries to compile LibO *is* a programmer++.
So, to make things simple, let's force user having GNU tar, not BSD tar.
GNU tar can be installed on BSD as well as other non-Linux OSes.
I am use we don't want too much checking in configure.in in order to
make LibO support more platforms.
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
On Tue, Feb 1, 2011 at 3:51 AM, Tor Lillqvist tlillqv...@novell.com wrote: In fact there is http://opengrok.go-oo.org/xref/components/setup_native/source/packinfo/spellchecker_selection.txt that can be used. I strongly oppose. That file makes exactly the kind of political choices that very many people will find at least odd, awkward, and at worst interpret as signs of some hidden agenda and cultural imperialism. [...] Better to not try to make any automatic guesstimates here, and just install all the available dictionaries, if the person running the installer can't be bothered to do a custom installation and select dictionaries explicitly him/herself. I agree with Tor, and enjoyed the colorful illustration of just a tiny slice of the insanity that would surely derive from this. I would suggest to look into the direction of 'hiding' these 'default pre-installed extension/dictionary' in the extension list. Norbert --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] leak per frame, mac input request.
On Tue, Feb 1, 2011 at 5:47 AM, Caolán McNamara caol...@redhat.com wrote: So, after clearing up a pile of circular ownership things to clear out deadwood blocking valgrind from telling me what I wanted to know I tracked down a a leak in framework/source/services/frame.cxx where for each frame we do a new WindowCommandDispatch, and the comment claims that the WindowCommandDispatch will release itself at frame destruction. It doesn't of course, its implemented as a uno XEventListener but doesn't register itself as a uno listener to the frame to even have a chance of doing the right thing. It itself registers itself as a vcl listener to the frame, and doesn't delete itself on OBJ_DYING. So, I could remove the XEventListener foo, add a delete this on OBJ_DYING to remove the leak. My open question though, is it that this WindowCommandDispatch exists apparently do bind some mac About and Preferences events to do the right thing on that platform. What's special about About/Preferences in Mac ?, and does it currently work correctly ?, i.e. its worth fixing this rather than removing it entirely. Yes there is somethng special on Mac: there is one menu bar only and it is at the top of the display. it has a little apple icon as first menu, then a menu that is named with the name of the application. in that later menu you should find the About item and the Preference Item. Norbert C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] bsdtar works as fine as gnu tar
2011/2/1 Nguyen Vu Hung vuhung16p...@gmail.com:
On Tue, Feb 1, 2011 at 4:26 PM, Baptiste Daroussin b...@freebsd.org wrote:
Hi,
On FreeBSD we use bsdtar (libarchive) and from my testings it works
great with libreoffice (no regression compared to gnu tar)
here is an attempt to allow checking for both bsdtar and gnu tar in
configure (against build git repository)
A person who tries to compile LibO *is* a programmer++.
So, to make things simple, let's force user having GNU tar, not BSD tar.
GNU tar can be installed on BSD as well as other non-Linux OSes.
I am use we don't want too much checking in configure.in in order to
make LibO support more platforms.
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
Seriously why not supporting bsdtar? It has a great effort is made to
make it gnu compatible in fact compatible with the largest possible
set of archive formats.
All the testing I have done with bsd tar shows it performs at least as
well as gnu tar.
The patch is minimalistic and works. it is not as if it added 10+
lines of cryptic code.
regards,
Bapt
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=32894 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||33744 --- Comment #14 from Petr Mladek pmla...@suse.cz 2011-02-01 09:22:58 PST --- Added bug 33744. The BrOffice branding does always work on Linux. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error in en_us readme file ?
On Tue, 2011-02-01 at 18:46 +0100, Andras Timar wrote: 2011/2/1 Caolán McNamara caol...@redhat.com On Sun, 2011-01-30 at 16:38 -0500, drew wrote: Updated readme file attached. Do you think you could make a patch against the original README content, i.e. readlicense_oo/docs/readme/readme.xrm ? Here you go, please approve. Cheers, Hola Andras Thanks - I didn't move quick enough.. Drew ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Convert tools/list.hxx usage to std::list
The attached patch replaces usage of LinkList (declared as
DECLARE_LIST(LinkList, Link*) with std::listLink.
I used listLink instead of listLink* because 1) the elements of the
list were only ever used from within the .cxx file declaring the list
itself and 2) each element was already allocated on addition and
deallocated on removal, so I just made that more explicit by letting
std::list handle it.
As with all my patches, this is LGPLv3+/MPL.
From ee05143cb845bf7f82cf1a55b5e72f7a932946c0 Mon Sep 17 00:00:00 2001
From: Jonathan Callen a...@gentoo.org
Date: Tue, 1 Feb 2011 01:32:54 -0500
Subject: [PATCH] Convert tools/list.hxx usage to std::list
---
svtools/source/config/htmlcfg.cxx | 18 --
svtools/source/config/menuoptions.cxx | 33 +++--
svtools/source/config/miscopt.cxx | 22 +-
3 files changed, 32 insertions(+), 41 deletions(-)
diff --git a/svtools/source/config/htmlcfg.cxx
b/svtools/source/config/htmlcfg.cxx
index b44dfe2..2de1f14 100644
--- a/svtools/source/config/htmlcfg.cxx
+++ b/svtools/source/config/htmlcfg.cxx
@@ -33,9 +33,9 @@
#include svtools/parhtml.hxx
#include unotools/syslocale.hxx
#include tools/debug.hxx
-#include tools/list.hxx
#include tools/link.hxx
#include sal/macros.h
+#include list
// ---
#define HTMLCFG_UNKNOWN_TAGS 0x01
@@ -54,13 +54,11 @@ using namespace com::sun::star::uno;
static SvxHtmlOptions* pOptions = 0;
-DECLARE_LIST( LinkList, Link * )
-
#define C2U(cChar) OUString::createFromAscii(cChar)
struct HtmlOptions_Impl
{
-LinkListaList;
+::std::listLink aList;
sal_Int32 nFlags;
sal_Int32 nExportMode;
sal_Int32 aFontSizeArr[HTML_FONT_COUNT];
@@ -268,16 +266,16 @@ void SvxHtmlOptions::Commit()
void SvxHtmlOptions::AddListenerLink( const Link rLink )
{
-pImp-aList.Insert( new Link( rLink ) );
+pImp-aList.push_back( rLink );
}
void SvxHtmlOptions::RemoveListenerLink( const Link rLink )
{
-for ( USHORT n=0; npImp-aList.Count(); n++ )
+for ( ::std::listLink::iterator iter = pImp-aList.begin(); iter !=
pImp-aList.end(); ++iter )
{
-if ( (*pImp-aList.GetObject(n) ) == rLink )
+if ( *iter == rLink )
{
-delete pImp-aList.Remove(n);
+pImp-aList.erase(iter);
break;
}
}
@@ -285,8 +283,8 @@ void SvxHtmlOptions::RemoveListenerLink( const Link rLink )
void SvxHtmlOptions::CallListeners()
{
-for ( USHORT n = 0; n pImp-aList.Count(); ++n )
-pImp-aList.GetObject(n)-Call( this );
+for ( ::std::listLink::const_iterator iter = pImp-aList.begin(); iter
!= pImp-aList.end(); ++iter )
+iter-Call( this );
}
diff --git a/svtools/source/config/menuoptions.cxx
b/svtools/source/config/menuoptions.cxx
index e0b57c5..7703738 100644
--- a/svtools/source/config/menuoptions.cxx
+++ b/svtools/source/config/menuoptions.cxx
@@ -40,6 +40,8 @@
#include rtl/logfile.hxx
#include itemholder2.hxx
+#include list
+
//_
// namespaces
//_
@@ -71,8 +73,6 @@ using namespace ::com::sun::star::uno ;
#define PROPERTYCOUNT 4
#include tools/link.hxx
-#include tools/list.hxx
-DECLARE_LIST( LinkList, Link * )
//_
// private declarations!
@@ -85,7 +85,7 @@ class SvtMenuOptions_Impl : public ConfigItem
//-
private:
-LinkListaList;
+::std::listLink aList;
sal_Bool m_bDontHideDisabledEntries ;
/// cache DontHideDisabledEntries of Menu section
sal_Bool m_bFollowMouse
; /// cache FollowMouse of Menu section
sal_Int16 m_nMenuIcons
; /// cache MenuIcons of Menu section
@@ -171,8 +171,8 @@ class SvtMenuOptions_Impl : public ConfigItem
{
m_bDontHideDisabledEntries = bState;
SetModified();
-for ( USHORT n=0; naList.Count(); n++ )
-aList.GetObject(n)-Call( this );
+for ( ::std::listLink::const_iterator iter =
aList.begin(); iter != aList.end(); ++iter )
+iter-Call( this );
Commit();
}
@@ -180,8 +180,8 @@ class SvtMenuOptions_Impl : public ConfigItem
{
Re: [Libreoffice] [PUSHED] Re: SmNodeToTextVisitor Fixes
I don't think it's critial... None of the commits that removes brackets and improves SmNodeToTextVisitor have been applied to libreoffice-3-3... The SmNodeToTextVisitor there uses a lot of brackets, so there's hopefully no major issues with it... In fact I've kept all the changes to the visual formula editor in the master branch... Some of them can, as previous changes to SmNodeToVisitor might have done, cause issues... -- Regards Jonas Finnemann Jensen. On Mon, Jan 31, 2011 at 11:58, Michael Meeks michael.me...@novell.comwrote: On Sat, 2011-01-29 at 13:01 +, Luke Dixon wrote: Some of the tests are the same kind as the one from last time. It can be a bit difficult to get the right node tree for the test from the parser, which also seems to put in more expression nodes than doing it with the cursor, which confused me for a bit. Quick query - did we want the core part of this on the libreoffice-3-3 branch as well ? Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] bsdtar works as fine as gnu tar
Hi *, On Tue, Feb 1, 2011 at 5:48 PM, Nguyen Vu Hung vuhung16p...@gmail.com wrote: On Tue, Feb 1, 2011 at 4:26 PM, Baptiste Daroussin b...@freebsd.org wrote: On FreeBSD we use bsdtar (libarchive) and from my testings it works great with libreoffice (no regression compared to gnu tar) here is an attempt to allow checking for both bsdtar and gnu tar in configure (against build git repository) A person who tries to compile LibO *is* a programmer++. So, to make things simple, let's force user having GNU tar, not BSD tar. I completely disagree. Mac doesn't use gnu-tar by default either, and the code doesn't make use of gnu-specific features. It is just with the bashisms in preparation scripts - they get added because people are not aware, not because it is required. Same for cp command. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice and Wayland support
Michael Meeks wrote: [1] - we prolly have to fall back to an in-memory surface for that, unfortunately - and also (I guess) start to hand-code things; but XOR rendering should be by far the exception not the rule around the place. No need to hand-code, it's all there already. Have a look into basebmp/inc/basebmp/bitmapdevice.hxx, which is a full-featured software renderer for LibO's current graphic subsystem. Including XOR. Cheers, -- Thorsten pgpb5Eeh4TvxT.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] configure: WARNING: Your gcc is not -fvisibility=hidden safe. Disabling visibility
Norbert Thiebaud wrote: Which make we thing that the 'uncobbering' of CXX done a couple of day ago may be the culprit But that was only on -3-3 - I gather we're talking master here? -- Thorsten pgpS2Wm5DBZKe.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] OSF1 typo in set_soenv.in
Hi all, While patching set_soenv.in, I found a typo on line 1142: if ($platform =~ m/linux|netbsd|odf1|freebsd|aix|solaris|openbsd/) I believe odf1 is a typo for osf1 The code below the test on line 1142 is responsible for setting PATH; I'm not 100% sure but I believe that if the operating system is not recognized here, the build cannot proceed. The typo is present in the oldest recorded version of set_soenv.in, which is dated from 2009-01-21. It would seem that Open/LibreOffice has not been able to be built on OSF1 systems for more than 2 years, and no one has noticed so far. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
On 01/02/11 09:51, Tor Lillqvist wrote: And do we *really* want to imply than American English is needed by everyone? Why not British English? Shouldn't we here in Europe at least be writing in British English? British English? What's that? THERE'S NO SUCH THING! I'm a brit, and all this stuff about British English really pisses me off personally. English is spoken by the saxons (the English). Sassenachs (Angles, or Lowland Scots) speak Scots. The true Scot speaks Gaelic. And the Welsh, surprisingly, speak Welsh. (Interesting snippet. Scotia - the land of the Scots - is in fact Ireland.) This picture is, of course, not helped by the fact that the majority of people living in Scotland are, in fact, English - the Scots themselves having for the most part been driven out and emigrated to the colonies. And the majority of people living in Wales are also English (typically Cornish tin miners who moved north, but who are probably more closely related to the Welsh than the saxon English!). Britain is NOT a homogenous country with a homogenous language. There is no such thing as British English (which is an American invention) because, culturally speaking, there is no such thing as Britain to share a common language! Sorry - this blast isn't particularly aimed at anyone - but it does show the dangers of outsiders presuming to know what is appropriate for somewhere else! However, if we are going to go down this sort of route, seeing as the installer knows the country (hopefully), maybe we could go down the route of all dictionaries, all dictionaries for your country, choose from all dictionaries, choose from all dictionaries for your country. So, for example, Britain would come up with English, Gaelic, Welsh (and maybe Scots, Cornish, whatever). Finland would give Finnish, Swedish. Etc etc. That would make the initial choice far simpler and more comprehensible, but if people *want* an enormous choice they can get it. And all this from someone proud to consider themselves European :-) My father was English through and through, my mother is the daughter of a German and a white Jaimaican/Scot. Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
British English? What's that? THERE'S NO SUCH THING! English is spoken [...] speak Scots [...] speaks Gaelic [...] speak Welsh. I was not talking about spoken language. It will take a few years before LibreOffice can be used for dictionary checking of spoken language. Your message perfectly shows the kind of emotions languages can evoke. all dictionaries, all dictionaries for your country, choose from all dictionaries, choose from all dictionaries for your country. That would get quite complicated. I am sure some people could be annoyed also by being reminded that there are languages spoken in their country that they perhaps consider leftovers from invaders and not real language of their country. Or the other way around, people feeling they belong to an oppressed linguistic minority would complain if a dictionary of their language isn't installed even if they choose all dictionaries for your country. Surely we want to avoid stepping into such a minefield. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error in en_us readme file ?
2011.02.01. 21:54 keltezéssel, Caolán McNamara írta: On Tue, 2011-02-01 at 18:46 +0100, Andras Timar wrote: Here you go, please approve Looks good to me if you want to push this back to 3-3 as well as master. C. Done. All localizations have been updated on libreoffice-3-3, too. Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
Hi, On 1 February 2011 22:26, Michael Meeks michael.me...@novell.com wrote: Hi Steve, 3. In Cygwin shell, the autogen failed with an odd error related to Native programs and symlinks. I got past this by doing the following: cd /bin rm /usr/bin/awk cp /usr/bin/gawk.exe awk.exe cp /usr/bin/gzip.exe gunzip.exe Urk; I guess we should try to patch/fix our autogen.sh to work more nicely - or is this unavoidable ? It says its because non-cygwin programs (native Windows) can't execute them - I have no idea where they are used (or if they are used) so I followed some hints off the net to make it stop complaining :) 4. After this, it seemed to pick my MSVC2008 Express install as the compiler (I also had several cygwin gcc versions installed but it seems to have ignored them), then I needed to add the jdk 6 home to the config option ./autogen.sh --with-jdk-home=/cygdrive/c/Program\ Files/Java/jdk1.6.0_18/ After finally installing mozilla-build with the following steps: 7. Rerun autogen: ./autogen.sh --with-jdk-home=/cygdrive/c/Program\ Files/Java/jdk1.6.0_18/ --with-mozilla-build=/cygdrive/c/mozilla-build/ configure: error: Building SeaMonkey is supported with Microsoft Visual Studio 2005 only. 8. I downloaded prebuilt seamonkey from here: http://tools.openoffice.org/moz_prebuild/OOo3.2/ grabbed 3 files started with WNT but I'm not sure what to do with them... Where should I put these to make it all go? Regards Steven Butler ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
2011/2/1 Steven Butler sebut...@gmail.com: configure: error: Building SeaMonkey is supported with Microsoft Visual Studio 2005 only. 8. I downloaded prebuilt seamonkey from here: http://tools.openoffice.org/moz_prebuild/OOo3.2/ grabbed 3 files started with WNT but I'm not sure what to do with them... Where should I put these to make it all go? clone\libs-extern-sys\moz\zipped\ Cheers, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
On Tue, Feb 1, 2011 at 11:44 PM, Steven Butler sebut...@gmail.com wrote: Hi, On 1 February 2011 22:26, Michael Meeks michael.me...@novell.com wrote: Hi Steve, 3. In Cygwin shell, the autogen failed with an odd error related to Native programs and symlinks. I got past this by doing the following: cd /bin rm /usr/bin/awk cp /usr/bin/gawk.exe awk.exe cp /usr/bin/gzip.exe gunzip.exe Urk; I guess we should try to patch/fix our autogen.sh to work more nicely - or is this unavoidable ? It says its because non-cygwin programs (native Windows) can't execute them - I have no idea where they are used (or if they are used) so I followed some hints off the net to make it stop complaining :) 4. After this, it seemed to pick my MSVC2008 Express install as the compiler (I also had several cygwin gcc versions installed but it seems to have ignored them), then I needed to add the jdk 6 home to the config option ./autogen.sh --with-jdk-home=/cygdrive/c/Program\ Files/Java/jdk1.6.0_18/ After finally installing mozilla-build with the following steps: 7. Rerun autogen: ./autogen.sh --with-jdk-home=/cygdrive/c/Program\ Files/Java/jdk1.6.0_18/ --with-mozilla-build=/cygdrive/c/mozilla-build/ configure: error: Building SeaMonkey is supported with Microsoft Visual Studio 2005 only. 8. I downloaded prebuilt seamonkey from here: http://tools.openoffice.org/moz_prebuild/OOo3.2/ grabbed 3 files started with WNT but I'm not sure what to do with them... Where should I put these to make it all go? In the directory moz/zipped. -- Jesús Corrius je...@softcatala.org Document Foundation founding member Skype: jcorrius | Twitter: @jcorrius ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Parse 'color' property (fdo#33551)
Michael Meeks wrote: I've pushed it to master. Thorsten - if you're happy can you cherry-pick it for libreoffice-3-3 ? Good catch, safe fix - cherry-picked for -3-3 -- Thorsten pgptYbAvcXSJk.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] solenv/inc/settings.mk overwrites CDEFS
Hi, I just found out, that settings.mk resets all CDEFS which were defined in some makefiles. For example: sc/source/ui/vba/makefile.mk defines: CDEFS+=-DVBA_OOBUILD_HACK But some lines later settings.mk is included (which is solenv/inc/settings.mk) .INCLUDE : settings.mk In this file CDEFS is reset. So VBA_OOBUILD_HACK doesn't get defined for sc/source/ui/vba. Is this intended or a bug? -Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Use product name for EPS Creator header
Michael Meeks wrote: Here is a patch to make the filter use product name for the header. And cherry-picked for -3-3. Clearly this was wrong, and very confusing information. -- Thorsten pgp09p1vYGFjT.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Updated Serbian translation for 3.3.1
Patch against the libreoffice-3-3 branch attached. Goran From 3492bdacd976e6d797c1216830a0273d025fb327 Mon Sep 17 00:00:00 2001 From: Goran Rakic gra...@devbase.net Date: Wed, 2 Feb 2011 00:28:28 +0100 Subject: [PATCH] Updated Serbian translation --- po/lo-build-sh.po | 156 +++- po/lo-build-sr.po | 49 ++--- 2 files changed, 133 insertions(+), 72 deletions(-) diff --git a/po/lo-build-sh.po b/po/lo-build-sh.po index d7552e3..7a5549b 100644 --- a/po/lo-build-sh.po +++ b/po/lo-build-sh.po @@ -1,11 +1,14 @@ # Serbian translation of LibreOffice -# Courtesy of http://sr.openoffice.org team -- 2010. +# Courtesy of http://sr.openoffice.org team -- 2011. +# # This file is distributed under the terms of the GNU Lesser General # Public License as published by the Free Software Foundation; either # version 3, or (at your option) any later version. -# Nikola Stojković nikola.stojko...@phplab.biz, 2009, 2010. +# +# Nikola Stojković nikola.stojko...@phplab.biz, 2009, 2010, 2011. # Miloš Popović gpo...@gmail.com, 2010. -# Goran Rakić gra...@devbase.net, 2010. +# Goran Rakić gra...@devbase.net, 2010, 2011. +# #. extracted from (input file name not known) msgid msgstr @@ -270,14 +273,13 @@ msgstr ahelp hid=\SC:CHECKBOX:RID_SCPAGE_SORT_OPTIONS:BTN_NATURALSORT\Prirodno ređanje je algoritam ređanja koji pravi poredak među brojevima sa slovnim prefiksom zasnovan na vrednosti broja, umesto tradicionalnog leksikografskog -ređanja./ahelp Na primer, pretpostavimo niz vrednosti: A1, A2, A3, A4, -A5, A6, ..., A19, A20, A21. Po unosu vrednosti u neki opseg ćelija i -ređanjem niz će postati A1, A11, A12, A13, ..., A19, A2, A20, A21, A3, A4, -A5, ..., A9. Iako ovaj redosled ima smisla za one koji razumeju -leksikografsko sortiranje, gledano sa strane izgleda potpuno sulud i -neodgovarajući. Ako je prirodno ređanje omogućeno vrednosti iz niza u -primeru će biti „ispravno“ poređane što obezbeđuje veću ugodnost pri -korišćenju ove funkcije. +ređanja./ahelp Na primer, pretpostavimo niz vrednosti: A1, A2, A3, A4, A5, +A6, ..., A19, A20, A21. Po unosu vrednosti u neki opseg ćelija i ređanjem +niz će postati A1, A11, A12, A13, ..., A19, A2, A20, A21, A3, A4, A5, ..., +A9. Iako ovaj redosled ima smisla za one koji razumeju leksikografsko +sortiranje, gledano sa strane izgleda potpuno sulud i neodgovarajući. Ako je +prirodno ređanje omogućeno vrednosti iz niza u primeru će biti „ispravno“ +poređane što obezbeđuje veću ugodnost pri korišćenju ove funkcije. #: helpcontent2/source/text/scalc/guide/multioperation.xhp#par_id3148584.4.help.text msgid @@ -358,12 +360,18 @@ msgid enhancements, write your own article in an FAQ, how-to, manual, create a video tutorial, etc. msgstr +Ako želite da se aktivno pridružite širom sveta rasutoj %PRODUCTNAME zajednici, +možete poslati komentar, razgovarati o mogućnostima, predložiti unapređenja +napisati tekst na često postavljana pitanja, vodič, uputstvo, napraviti video +prilog za obuku i slično. #: helpcontent2/source/text/shared/05/0001.xhp#par_id0120200910361874.help.text msgid Visit the link href=\http://www.libreoffice.org/get-involved/\;Get involved page on the website/link and follow the links for contributors. msgstr +Posetite link href=\http://www.libreoffice.org/get-involved/\;Priključite se +stranicu na sajtu (engl.)/link i saznajte kako da doprinesete. #: helpcontent2/source/text/shared/05/0001.xhp#par_id0804200803314235.help.text msgid @@ -373,11 +381,17 @@ msgid list/link. If you want to discuss any issue with other users, send an email to the public mail list us...@libreoffice.org. msgstr +Ako ste zabrinuti u vezi neke teme oko sigurnosti korišćenja ovog softvera +možete kontaktirati programere preko link +href=\http://lists.freedesktop.org/mailman/listinfo/libreoffice\;javne +dopisne liste (engl.)/link. Ako želite da se o tome obratite korisnicima, pošaljite +e-pismo na javnu dopisnu listu us...@libreoffice.org. #: helpcontent2/source/text/shared/05/0001.xhp#par_id0915200811081778.help.text msgid You can access web forums to ask and answer questions about %PRODUCTNAME. msgstr +Možete koristiti forume da postavite nova i šaljete odgovore na pitanja o paketu %PRODUCTNAME. #: helpcontent2/source/text/shared/05/0001.xhp#par_id1318380.help.text msgid @@ -388,18 +402,28 @@ msgid help and support in English language on the %PRODUCTNAME website at link href=\http://www.libreoffice.org/get-help/\;www.libreoffice.org/link. msgstr +Projekti lokalizacije paketa %PRODUCTNAME pripremaju stranice za podršku na +pojedinačnim jezicima. Pogledajte pregled projekata na stranici link +href=\http://www.libreoffice.org/international-; +sites/\http://www.libreoffice.org/international-sites//link. Pomoć i dokumentaciju +na engleskom potražite na sajtu projekta %PRODUCTNAME na adresi link
Re: [Libreoffice] solenv/inc/settings.mk overwrites CDEFS
On Tue, Feb 1, 2011 at 5:05 PM, Thomas Arnhold tho...@arnhold.org wrote: Hi, I just found out, that settings.mk resets all CDEFS which were defined in some makefiles. For example: sc/source/ui/vba/makefile.mk defines: CDEFS+=-DVBA_OOBUILD_HACK But some lines later settings.mk is included (which is solenv/inc/settings.mk) .INCLUDE : settings.mk In this file CDEFS is reset. So VBA_OOBUILD_HACK doesn't get defined for sc/source/ui/vba. Is this intended or a bug? based on the other 2 uses of VBA_OOBUILD_HACK, I'd imagine that the CDEF should be _after_ the include setting.mk Norbert -Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] bugfixes for 3.3.1
Hi, As promised, I have some suggestions to look at for the 3.3.1 This with in mind that we want to serve business users too. An issue in our users list wrt Roaming profiles: http://www.mail-archive.com/users@libreoffice.org/msg01674.html I seen no issue in Bugzilla, but there is the OOo issue: http://www.openoffice.org/issues/show_bug.cgi?id=115778 Also one from OOo: Basic cannot make calls to win-functions: http://www.openoffice.org/issues/show_bug.cgi?id=115795 Then there is an issue with scrolling and Charts: http://www.openoffice.org/issues/show_bug.cgi?id=110384 For me, the bugdoc from that issue does not even open (LibO freezes) http://www.openoffice.org/nonav/issues/showattachment.cgi/68636/100323_U1_Logg_test.ods Are we sure the Python macro thing is solved? https://bugs.freedesktop.org/show_bug.cgi?id=32939 I can issue bugs if needed. but am unsure if that is desired in all cases. Therefore first this mail. Best, Cor Michael Meeks wrote (31-01-11 17:47) -- - giving openoffice.org its foundation :: The Document Foundation - ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Convert tools/list.hxx usage to std::list
On 02/01/2011 01:57 PM, Jonathan Callen wrote:
The attached patch replaces usage of LinkList (declared as
DECLARE_LIST(LinkList, Link*) with std::listLink.
I used listLink instead of listLink* because 1) the elements of the
list were only ever used from within the .cxx file declaring the list
itself and 2) each element was already allocated on addition and
deallocated on removal, so I just made that more explicit by letting
std::list handle it.
As with all my patches, this is LGPLv3+/MPL.
This version of the patch uses BOOST_FOREACH to simplify a few of the loops.
--
Jonathan Callen
From 64ddb5ec682dd7bd2adfd8ced73f57c7e4f72f07 Mon Sep 17 00:00:00 2001
From: Jonathan Callen a...@gentoo.org
Date: Tue, 1 Feb 2011 01:32:54 -0500
Subject: [PATCH] Convert tools/list.hxx usage to std::list
---
svtools/prj/build.lst |2 +-
svtools/source/config/htmlcfg.cxx | 19 -
svtools/source/config/menuoptions.cxx | 34 +++-
svtools/source/config/miscopt.cxx | 23 +
4 files changed, 36 insertions(+), 42 deletions(-)
diff --git a/svtools/prj/build.lst b/svtools/prj/build.lst
index a7d8569..e8ac011 100644
--- a/svtools/prj/build.lst
+++ b/svtools/prj/build.lst
@@ -1,4 +1,4 @@
-st svtools : l10n svl offuh toolkit ucbhelper unotools JPEG:jpeg
cppu cppuhelper comphelper sal sot jvmfwk NULL
+st svtools : l10n svl offuh toolkit ucbhelper unotools JPEG:jpeg
cppu cppuhelper comphelper sal sot jvmfwk BOOST:boost NULL
st svtools usr1
- all st_mkout NULL
st svtools\inc nmake
- all st_inc NULL
st svtools\bmpmakernmake -
all st_bmp st_inc NULL
diff --git a/svtools/source/config/htmlcfg.cxx
b/svtools/source/config/htmlcfg.cxx
index b44dfe2..18a3fdd 100644
--- a/svtools/source/config/htmlcfg.cxx
+++ b/svtools/source/config/htmlcfg.cxx
@@ -33,9 +33,10 @@
#include svtools/parhtml.hxx
#include unotools/syslocale.hxx
#include tools/debug.hxx
-#include tools/list.hxx
#include tools/link.hxx
#include sal/macros.h
+#include list
+#include boost/foreach.hpp
// ---
#define HTMLCFG_UNKNOWN_TAGS 0x01
@@ -54,13 +55,11 @@ using namespace com::sun::star::uno;
static SvxHtmlOptions* pOptions = 0;
-DECLARE_LIST( LinkList, Link * )
-
#define C2U(cChar) OUString::createFromAscii(cChar)
struct HtmlOptions_Impl
{
-LinkListaList;
+::std::listLink aList;
sal_Int32 nFlags;
sal_Int32 nExportMode;
sal_Int32 aFontSizeArr[HTML_FONT_COUNT];
@@ -268,16 +267,16 @@ void SvxHtmlOptions::Commit()
void SvxHtmlOptions::AddListenerLink( const Link rLink )
{
-pImp-aList.Insert( new Link( rLink ) );
+pImp-aList.push_back( rLink );
}
void SvxHtmlOptions::RemoveListenerLink( const Link rLink )
{
-for ( USHORT n=0; npImp-aList.Count(); n++ )
+for ( ::std::listLink::iterator iter = pImp-aList.begin(); iter !=
pImp-aList.end(); ++iter )
{
-if ( (*pImp-aList.GetObject(n) ) == rLink )
+if ( *iter == rLink )
{
-delete pImp-aList.Remove(n);
+pImp-aList.erase(iter);
break;
}
}
@@ -285,8 +284,8 @@ void SvxHtmlOptions::RemoveListenerLink( const Link rLink )
void SvxHtmlOptions::CallListeners()
{
-for ( USHORT n = 0; n pImp-aList.Count(); ++n )
-pImp-aList.GetObject(n)-Call( this );
+BOOST_FOREACH(const Link link, pImp-aList)
+link.Call( this );
}
diff --git a/svtools/source/config/menuoptions.cxx
b/svtools/source/config/menuoptions.cxx
index e0b57c5..48e7678 100644
--- a/svtools/source/config/menuoptions.cxx
+++ b/svtools/source/config/menuoptions.cxx
@@ -40,6 +40,9 @@
#include rtl/logfile.hxx
#include itemholder2.hxx
+#include list
+#include boost/foreach.hpp
+
//_
// namespaces
//_
@@ -71,8 +74,6 @@ using namespace ::com::sun::star::uno ;
#define PROPERTYCOUNT 4
#include tools/link.hxx
-#include tools/list.hxx
-DECLARE_LIST( LinkList, Link * )
//_
// private declarations!
@@ -85,7 +86,7 @@ class SvtMenuOptions_Impl : public ConfigItem
//-
private:
-LinkListaList;
+::std::listLink aList;
sal_Bool m_bDontHideDisabledEntries
[Libreoffice] [PATCH] Use generic base64 encoder
Hi,
SVG export filter has own Base64 encoder in FastString class.
But we have several more generic Base64 encoders in the code tree. e.g.
* Converter::encodeBase64
http://opengrok.go-oo.org/xref/libs-gui/sax/source/tools/converter.cxx#encodeBase64
* SvXMLUnitConverter::encodeBase64
http://opengrok.go-oo.org/xref/libs-core/xmloff/source/core/xmluconv.cxx#encodeBase64
* Base64Codec::encodeBase64
http://opengrok.go-oo.org/xref/filters/filter/source/placeware/Base64Codec.cxx#encodeBase64
* Base64Codec::encodeBase64
http://opengrok.go-oo.org/xref/components/package/source/manifest/Base64Codec.cxx#133
We can replace FastString's encoder by an another.
The patche uses SvXMLUnitConverter's because SVG Import filter also
uses SvXMLUnitConverter::decodeBase64.
The patch is under the LGPLv3+ / MPL.
Cheers,
--
KUROSAWA Takeshi taken@gmail.com
From e30307dd55c5e8472943daa0d34b7f3d3e931dda Mon Sep 17 00:00:00 2001
From: Takeshi Kurosawa taken@gmail.com
Date: Wed, 2 Feb 2011 12:39:36 +0900
Subject: [PATCH] Use SvXMLUnitConverter's base64 encoder
SVGActionWriter uses FastString class to encode an image to a base64 string.
But there are several more generic encoders. We can use one of them.
---
filter/source/svg/svgwriter.cxx | 168 +++
filter/source/svg/svgwriter.hxx |4 +-
2 files changed, 14 insertions(+), 158 deletions(-)
diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 7765ea5..b33e84a 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -68,19 +68,6 @@ static const char aXMLAttrHeight[] = height;
static const char aXMLAttrPoints[] = points;
static const char aXMLAttrXLinkHRef[] = xlink:href;
-static const sal_Unicode pBase64[] =
-{
-//0 1 2 3 4 5 6 7
- 'A','B','C','D','E','F','G','H', // 0
- 'I','J','K','L','M','N','O','P', // 1
- 'Q','R','S','T','U','V','W','X', // 2
- 'Y','Z','a','b','c','d','e','f', // 3
- 'g','h','i','j','k','l','m','n', // 4
- 'o','p','q','r','s','t','u','v', // 5
- 'w','x','y','z','0','1','2','3', // 6
- '4','5','6','7','8','9','+','/' // 7
-};
-
// --
// - FastString -
// --
@@ -98,64 +85,6 @@ FastString::FastString( sal_uInt32 nInitLen, sal_uInt32 nIncrement ) :
// -
-FastString::FastString( sal_Char* pBufferForBase64Encoding, sal_uInt32 nBufLen ) :
-mnBufInc( 2048 ),
-mnPartPos( 0 )
-{
-DBG_ASSERT( pBufferForBase64Encoding nBufLen, invalid arguments );
-
-const sal_uInt32 nQuadCount = nBufLen / 3;
-const sal_uInt32 nRest = nBufLen % 3;
-
-if( nQuadCount || nRest )
-{
-mnBufLen = mnCurLen = ( ( nQuadCount + ( nRest ? 1 : 0 ) ) 2 );
-mpBuffer = new sal_Unicode[ mnBufLen * sizeof( sal_Unicode ) ];
-
-sal_Char* pTmpSrc = pBufferForBase64Encoding;
-sal_Unicode* pTmpDst = mpBuffer;
-
-for( sal_uInt32 i = 0; i nQuadCount; i++ )
-{
-const sal_Int32 nA = *pTmpSrc++;
-const sal_Int32 nB = *pTmpSrc++;
-const sal_Int32 nC = *pTmpSrc++;
-
-*pTmpDst++ = pBase64[ ( nA 2 ) 0x3f ];
-*pTmpDst++ = pBase64[ ( ( nA 4 ) 0x30 ) + ( ( nB 4 ) 0xf ) ];
-*pTmpDst++ = pBase64[ ( ( nB 2 ) 0x3c ) + ( ( nC 6 ) 0x3 ) ];
-*pTmpDst++ = pBase64[ nC 0x3f ];
-}
-
-if( 1 == nRest )
-{
-const sal_Int32 nA = *pTmpSrc;
-
-*pTmpDst++ = pBase64[ ( nA 2 ) 0x3f ];
-*pTmpDst++ = pBase64[ ( nA 4 ) 0x30 ];
-*pTmpDst++ = '=';
-*pTmpDst = '=';
-}
-else if( 2 == nRest )
-{
-const sal_Int32 nA = *pTmpSrc++;
-const sal_Int32 nB = *pTmpSrc;
-
-*pTmpDst++ = pBase64[ ( nA 2 ) 0x3f ];
-*pTmpDst++ = pBase64[ ( ( nA 4 ) 0x30 ) + ( ( nB 4 ) 0xf ) ];
-*pTmpDst++ = pBase64[ ( nB 2 ) 0x3c ];
-*pTmpDst = '=';
-}
-}
-else
-{
-mpBuffer = new sal_Unicode[ ( mnBufLen = 1 ) * sizeof( sal_Unicode ) ];
-mnCurLen = 0;
-}
-}
-
-// -
-
FastString::~FastString()
{
delete[] mpBuffer;
@@ -198,39 +127,6 @@ const NMSP_RTL::OUString FastString::GetString() const
return maString;
}
-// -
-
-sal_Bool FastString::GetFirstPartString( const sal_uInt32 nPartLen, NMSP_RTL::OUString rPartString )
-{
-const sal_uInt32 nLength = Min( mnCurLen, nPartLen );
-
-mnPartPos = 0;
-
-if( nLength )
-{
-rPartString = NMSP_RTL::OUString( mpBuffer, nLength );
-mnPartPos = nLength;
-}
-
-return( rPartString.getLength() 0 );
-}
-
-//
[Libreoffice] Remove old Word 6.0/95 save as support
Hi all, I'd like to get opinions (and preferably consensus) on removing old Microsoft formats save as support, specifically: Word 6.0 Word 95 Excel 5.0 Excel 95 The usability problem I've seen is that users: * want to save in MS Word format, but don't know what version to use * the pick 6.0 or 95 thinking many different things (lower number means it will work with more computers?) * since this is there only copy of the file, they lose all tables and more We currently have the same This document may contain formatting or content that can not be saved in... message for if you are saving to Word 97/2000/XP (very good at saving) or Word 6.0 (very bad at saving). I also do not think customizing this text to make it more specific will help. Users have become trained by the interface to ignore this message (this is a different usability issue, NOT a user issue). I believe the old binary StarOffice file save as support is going away soon as well. So, Does anyone still need to save in an extremely old version of Word or Excel? Or can we get rid of it? Thanks! Bryan P.S. Please copy me on any replies. P.S.S. I've previously reported this as a bug against OpenOffice (http://www.openoffice.org/issues/show_bug.cgi?id=107711). Should I report it against LibreOffice as well? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Easy Hack: Remove obsolete BmpColorMode enum
Hi,
Released under the LGPLv3+ / MPL
Tested and runs under Debian Linux x86_64
Enjoy,
Chris Carpenter(mordocai)
From c32b2f44f347f9e9ea013791e7878f6651bfca41 Mon Sep 17 00:00:00 2001
From: Chris Carpenter(mordocai) mordo...@gmail.com
Date: Tue, 1 Feb 2011 23:39:29 -0600
Subject: [PATCH] Complete Easy Hack: Remove obsolete BmpColorMode enum
---
vcl/inc/vcl/bitmap.hxx | 10 +
vcl/inc/vcl/bitmapex.hxx|2 +-
vcl/inc/vcl/image.h |2 +-
vcl/inc/vcl/outdev.hxx |2 -
vcl/source/gdi/bitmap.cxx | 32 --
vcl/source/gdi/bitmapex.cxx | 30
vcl/source/gdi/image.cxx| 45 ---
vcl/source/gdi/impimage.cxx | 18 -
8 files changed, 3 insertions(+), 138 deletions(-)
diff --git a/vcl/inc/vcl/bitmap.hxx b/vcl/inc/vcl/bitmap.hxx
index 58195e9..dba8ba0 100644
--- a/vcl/inc/vcl/bitmap.hxx
+++ b/vcl/inc/vcl/bitmap.hxx
@@ -145,14 +145,6 @@ enum BmpFilter
//
-enum BmpColorMode
-{
-BMP_COLOR_NORMAL = 0,
-BMP_COLOR_HIGHCONTRAST = 1,
-BMP_COLOR_MONOCHROME_BLACK = 2,
-BMP_COLOR_MONOCHROME_WHITE = 3
-};
-
//
// - FilterParameters -
//
@@ -362,7 +354,7 @@ public:
ULONG GetChecksum() const;
Bitmap CreateDisplayBitmap( OutputDevice* pDisplay );
-Bitmap GetColorTransformedBitmap( BmpColorMode eColorMode ) const;
+Bitmap GetColorTransformedBitmap() const;
static const BitmapPalette GetGreyPalette( int nEntries );
diff --git a/vcl/inc/vcl/bitmapex.hxx b/vcl/inc/vcl/bitmapex.hxx
index 79cee21..4227b66 100644
--- a/vcl/inc/vcl/bitmapex.hxx
+++ b/vcl/inc/vcl/bitmapex.hxx
@@ -105,7 +105,7 @@ public:
BitmapGetBitmap( const Color* pTransReplaceColor = NULL ) const;
BitmapGetMask() const;
-BitmapExGetColorTransformedBitmapEx( BmpColorMode eColorMode ) const;
+BitmapExGetColorTransformedBitmapEx() const;
BOOLIsAlpha() const;
AlphaMask GetAlpha() const;
diff --git a/vcl/inc/vcl/image.h b/vcl/inc/vcl/image.h
index 0234d57..a7a9a22 100644
--- a/vcl/inc/vcl/image.h
+++ b/vcl/inc/vcl/image.h
@@ -54,7 +54,7 @@ public:
void Replace( USHORT nPos, const BitmapEx rBmpEx );
voidReplaceColors( const Color* pSrcColors, const Color* pDstColors, ULONG nColorCount );
-void ColorTransform( BmpColorMode eColorMode );
+void ColorTransform();
void Invert();
BitmapEx GetBitmapEx( USHORT nPosCount, USHORT* pPosAry ) const;
diff --git a/vcl/inc/vcl/outdev.hxx b/vcl/inc/vcl/outdev.hxx
index e975de6..cef22b9 100644
--- a/vcl/inc/vcl/outdev.hxx
+++ b/vcl/inc/vcl/outdev.hxx
@@ -198,8 +198,6 @@ struct KerningPair
#define IMAGE_DRAW_DEACTIVE ((USHORT)0x0004)
#define IMAGE_DRAW_COLORTRANSFORM ((USHORT)0x0008)
#define IMAGE_DRAW_SEMITRANSPARENT ((USHORT)0x0010)
-#define IMAGE_DRAW_MONOCHROME_BLACK ((USHORT)0x0020)
-#define IMAGE_DRAW_MONOCHROME_WHITE ((USHORT)0x0040)
#define IMAGE_DRAW_3DLOOK 0
#define IMAGE_DRAW_BTNLOOK 0
diff --git a/vcl/source/gdi/bitmap.cxx b/vcl/source/gdi/bitmap.cxx
index 8fa4ab6..543d948 100644
--- a/vcl/source/gdi/bitmap.cxx
+++ b/vcl/source/gdi/bitmap.cxx
@@ -1739,38 +1739,6 @@ Bitmap Bitmap::CreateDisplayBitmap( OutputDevice* pDisplay )
// --
-Bitmap Bitmap::GetColorTransformedBitmap( BmpColorMode eColorMode ) const
-{
-Bitmap aRet;
-
-if( BMP_COLOR_HIGHCONTRAST == eColorMode )
-{
-Color* pSrcColors = NULL;
-Color* pDstColors = NULL;
-ULONG nColorCount = 0;
-
-aRet = *this;
-
-Image::GetColorTransformArrays( (ImageColorTransform) eColorMode, pSrcColors, pDstColors, nColorCount );
-
-if( nColorCount pSrcColors pDstColors )
- aRet.Replace( pSrcColors, pDstColors, nColorCount );
-
-delete[] pSrcColors;
-delete[] pDstColors;
-}
-else if( BMP_COLOR_MONOCHROME_BLACK == eColorMode ||
- BMP_COLOR_MONOCHROME_WHITE == eColorMode )
-{
-aRet = *this;
-aRet.MakeMono( BMP_COLOR_MONOCHROME_THRESHOLD );
-}
-
-return aRet;
-}
-
-// --
-
BOOL Bitmap::CombineSimple( const Bitmap rMask, BmpCombine eCombine )
{
BitmapReadAccess* pMaskAcc = ( (Bitmap) rMask ).AcquireReadAccess();
diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index ccd2672..fc44917 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -298,36 +298,6 @@ Bitmap BitmapEx::GetBitmap( const Color* pTransReplaceColor ) const
//
[Libreoffice] [Patch] SVG export filter improvements
Hi,
Here are some patches to improve SVG export filter.
0001: Make filter export Gradients and Hatches as SVG patterns.
This tend not to change a visual look but improve semantic structure of a file.
# Actually,hatches go outside of a shape sometimes without this patch.
0003: Make filter export linear and axial gradients as SVG linearGradients.
Use SVG's native gradient instead of polygon fallback.
With this patch, gradient steps of linear and axial gradient are ignored.
In other words, linear and axial gradients are always exported as
smooth gradients.
However, as far as I know, the manual steps function is for printing.
So I suppose ignoring gradient steps is safe.
To support native gradients, I need to calculate a bounding box of a gradient.
Currently it is done in OutputDevice::ImplDrawLinearGradient and
OutputDevice::ImplDrawComplexGradient.
So I moved that to Gradient class (0002 patch) to use it in filter code.
0004: Make filter export transparencies as SVG masks.
SVG export filter supports only solid transparency of solid fill (i.e.
color) until now.
The patch extends support to support solid and gradient transparency
of all fill styles.
# Some SVG viewers including WebKit don't support mask yet :-(.
The patches are under the LGPLv3+ / MPL.
Cheers,
--
KUROSAWA Takeshi taken@gmail.com
From 6254c025823c829e56fe6b5775c91c014eb2b87c Mon Sep 17 00:00:00 2001
From: Takeshi Kurosawa taken@gmail.com
Date: Wed, 2 Feb 2011 14:31:59 +0900
Subject: [PATCH 1/3] Export hatches and gradients as SVG patterns
This tend not to change a visual look, but improve semantic structure of a file.
---
filter/source/svg/svgwriter.cxx | 85 +++
filter/source/svg/svgwriter.hxx |3 +
2 files changed, 62 insertions(+), 26 deletions(-)
diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 7765ea5..1599cc6 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -39,6 +39,7 @@
static const char aXMLElemG[] = g;
static const char aXMLElemDefs[] = defs;
static const char aXMLElemClipPath[] = clipPath;
+static const char aXMLElemPattern[] = pattern;
static const char aXMLElemLine[] = line;
static const char aXMLElemRect[] = rect;
static const char aXMLElemEllipse[] = ellipse;
@@ -66,6 +67,7 @@ static const char aXMLAttrRY[] = ry;
static const char aXMLAttrWidth[] = width;
static const char aXMLAttrHeight[] = height;
static const char aXMLAttrPoints[] = points;
+static const char aXMLAttrPatternUnits[] = patternUnits;
static const char aXMLAttrXLinkHRef[] = xlink:href;
static const sal_Unicode pBase64[] =
@@ -483,7 +485,8 @@ SVGActionWriter::SVGActionWriter( SvXMLExport rExport, SVGFontExport rFontExpo
mrFontExport( rFontExport ),
mpContext( NULL ),
mbClipAttrChanged( sal_False ),
-mnCurClipId( 1 )
+mnCurClipId( 1 ),
+mnCurPatternId( 1 )
{
mpVDev = new VirtualDevice;
mpVDev-EnableOutput( sal_False );
@@ -763,48 +766,81 @@ void SVGActionWriter::ImplWritePolyPolygon( const PolyPolygon rPolyPoly, sal_Bo
// -
-void SVGActionWriter::ImplWriteGradientEx( const PolyPolygon rPolyPoly, const Gradient rGradient,
- const NMSP_RTL::OUString* pStyle, sal_uInt32 nWriteFlags )
+void SVGActionWriter::ImplWritePattern( const PolyPolygon rPolyPoly,
+const Hatch* pHatch,
+const Gradient* pGradient,
+const NMSP_RTL::OUString* pStyle,
+sal_uInt32 nWriteFlags )
{
if( rPolyPoly.Count() )
{
-SvXMLElementExport aElemG( mrExport, XML_NAMESPACE_NONE, aXMLElemG, TRUE, TRUE );
-FastString aClipId;
-FastString aClipStyle;
+SvXMLElementExport aElemG( mrExport, XML_NAMESPACE_NONE, aXMLElemG, TRUE, TRUE );
-aClipId += B2UCONST( clip );
-aClipId += NMSP_RTL::OUString::valueOf( ImplGetNextClipId() );
+FastString aPatternId;
+aPatternId += B2UCONST( pattern );
+aPatternId += GetValueString( ImplGetNextPatternId() );
{
SvXMLElementExport aElemDefs( mrExport, XML_NAMESPACE_NONE, aXMLElemDefs, TRUE, TRUE );
-mrExport.AddAttribute( XML_NAMESPACE_NONE, aXMLAttrId, aClipId.GetString() );
+mrExport.AddAttribute( XML_NAMESPACE_NONE, aXMLAttrId, aPatternId.GetString() );
+
+Rectangle aRect( ImplMap( rPolyPoly.GetBoundRect() ) );
+mrExport.AddAttribute( XML_NAMESPACE_NONE, aXMLAttrX, GetValueString( aRect.Left() ) );
+mrExport.AddAttribute( XML_NAMESPACE_NONE, aXMLAttrY, GetValueString( aRect.Top() ) );
+mrExport.AddAttribute( XML_NAMESPACE_NONE, aXMLAttrWidth, GetValueString( aRect.GetWidth() ) );
+mrExport.AddAttribute(
Re: [Libreoffice] MS-Windows : about dictionaries installation
On Sun, 30 Jan 2011 03:01:08 -0800, Jean-Baptiste Faure jbf.fa...@orange.fr wrote: Yes, but why ~20 dictionaries ? Do you know peoples who need and are able to write twenty different languages ? No, but for example, I speak Spanish and English. I like English as the UI even though Spanish is my native language and I live in a Spanish-speaking country. I really *hate* to be looking for dictionaries like Spanish and having to install them separately, being Spanish on of the top-5 languages. However, you don't know what language combination other users need. I think the best user friendly installation method should be to ask the user to choose itself the dictionnaries he wants, whatever the installation method chosen is (default or custom). With two buttons deselect all and select all. Spelling check in different languages is something a user just doesn't want to deal with. It just wants it installed. Otherwise you will make him go and look for it and guess if either he needs an extension, a package or whatever else depending on his platform. Now, from the above, it is really nice that LibreOffice makes this just work, providing this out of the box. If you don't want that there should be a good reason. A good reason to me is package size. So either you provide the languages (without giving any options, what for?) or you provide with a minimal download a la Debian net install in which you can ask the installer to install X or Y components from the net, having a minimal initial download. -- Octavio. Twitter: @alvarezp2000 -- Identi.ca: @alvarezp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
