Re: [Libreoffice] [PATCH] [PUSHED] DBG_ASSERT - OSL_ENSURE (dbaccess)
On Thu, Feb 03, 2011 at 12:42:41AM +0100, Kenneth Venken wrote: Hi, this patch replaces all occurrences of DBG_ASSERT with OSL_ENSURE in dbacces. Thanks. In addition, I changed several #ifdef DBG_UTIL lines enclosing declarations of variables/functions accessed in the debug macros to #if OSL_DEBUG_LEVEL 0 (so the code is actually compilable :) and removed a bunch of now unnecessary includes of tools/debug.hxx . Btw, i couldn't find any reference to VOS_ASSERT (see Easy Hack: align ASSERT ( friends) macro foo) So i guess this could be removed from the backgroud description. Yeah, the whole vos thing was removed already. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Recording changes: Deleted lines 'misbehaving'.
... with recorded changes on MSWord shows ... should be read as ... with recorded changes, previously *made* on MSWord, shows ... to resolve any ambiguity! Andy On Feb 2, 2011 10:59 PM, Andy Hearn cuviers...@gmail.com wrote: All, Here's another issue affecting collaborative authors. (FWIW: I'm on master branch, pulled today, around 1900GMT) SW: when an author deletes an existing body of text whilst 'Record Changes' is running, the strike-through'ed text soon disintegrates, leaving swathes of meaningless long lines. And, if the deleted sentence continues to an end of a paragraph, the entire text plus strike-through disappears, leaving a small vertical bar at the LHS as the remaining indicator. Reproducing: 1. New odt. Fill a page of text, say four or five paragraphs. 2. Start recording changes (enable 'Show' changes too). 3. Delete, I use highlight + del key, a number of words, sentences, and at least the last sentence of a paragraph. 4. Watch the strike-throughs while hovering mouse cursor over them - the bubble 'erases' text. Sometimes the text disappear on their 'own accord' after a while. 5. Hit Ctrl-S. Some strike-thoughs disappear completely. Also, loading a .doc with recorded changes on MSWord shows same behaviour for deleted text. Inserted text appear to be unaffected. This behaviour cannot be replicated on OOo, nor MSWord. Is anyone already aware of this, or is working on/with Recording Changes? If not, then I want to dive in. Cheers Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer)
On Wed, Feb 02, 2011 at 08:46:07PM +0900, Suguru Hirahara wrote: Hi, please review this one. changes are available under LGPLv3+ / MPL. I reverted the hunks removing @author OD from class/function descriptions. I think we do not want to remove these. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] DBG_ASSERT - OSL_ENSURE (dbaccess)
Thanks. In addition, I changed several #ifdef DBG_UTIL lines enclosing declarations of variables/functions accessed in the debug macros to #if OSL_DEBUG_LEVEL 0 Is that something we can/should do in general everywhere? What about the #ifdef PRODUCT things, can those too be #if OSL_DEBUG_LEVEL0 ? (Sounds like a potentially good idea to me; I never fully understood the logic of having the separate product vs. non-product build dichotomy, and the one time I tried a non-product build it failed miserably anyway.) If we do this, can we then get rid of the .pro sufffix on the build directories, too, please? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] DBG_ASSERT - OSL_ENSURE (dbaccess)
Tor Lillqvist wrote: (Sounds like a potentially good idea to me; I never fully understood the logic of having the separate product vs. non-product build dichotomy, and the one time I tried a non-product build it failed miserably anyway.) If we do this, can we then get rid of the .pro sufffix on the build directories, too, please? Hm, no really strong opinion on that one, but at least this is the rationale - a non-product build is there to have compile-time extra debug / sanity checks in it, like for example stlport debug - and individual stuff, usually specific to subsystems or applications. At least for the code that I know, those have been proven quite helpful at times, nicely complementing valgrind (by e.g. pointing out mem clobberage that went into already-allocated areas, and was thus not noticed by valgrind). And for me, --enable-dbgutil builds, on the platform I work on. Now, you prolly don't want this debug code shipped, since it adds substantial overhead (at times) - ideally, we'd have unit tests for all those things now handled by in-line debug code, but we're not quite there yet, so I'd be a bit reluctant with axing non-pro ... My 2 cents, -- Thorsten pgpgjbfSdGOJM.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] BUG: Auto filter
Hello! I read on www.libreoffice.org that it's best to file bugs to this mailinglist. So here's one. AutoFilter (Data-Filter-AutoFilter) in LibreOffice Calc is buggy. Enabling and disabling autofilter on multiple sheets generates in various visual defects and bugs. How to reproduce: - On Sheet1, create arbitrary data. - On Sheet2, create arbitrary data. - Enable autofilter on Sheet2. - Enable autofilter on Sheet1. - Disable autofilter on Sheet1. Now the autofilter buttons are gone on Sheet2 but the content is still filtered. I'm using windows version: LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 best regards Joel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] DBG_ASSERT - OSL_ENSURE (dbaccess)
Now, you prolly don't want this debug code shipped, debug code meaning non-product, i.e. DBG_UTIL defined if I understand correctly. But the same holds for code built with OSL_DEBUG_LEVEL0, too, right? In many cases that adds significant overhead, too, doesn't it? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] DBG_ASSERT - OSL_ENSURE (dbaccess)
On Thu, Feb 03, 2011 at 01:41:19AM -0700, Tor Lillqvist wrote: Thanks. In addition, I changed several #ifdef DBG_UTIL lines enclosing declarations of variables/functions accessed in the debug macros to #if OSL_DEBUG_LEVEL 0 Is that something we can/should do in general everywhere? What about the #ifdef PRODUCT things, can those too be #if OSL_DEBUG_LEVEL0 ? That should be #if OSL_DEBUG_LEVEL == 0, i.e., PRODUCT implies no debugging. (Sounds like a potentially good idea to me; I never fully understood the logic of having the separate product vs. non-product build dichotomy, and the one time I tried a non-product build it failed miserably anyway.) Actually, there is a bit more to it than just product/non-product :) Like compact builds (whatever that means), profiling builds, etc.; just search for Produkt auf einen Wert setzen and Pfade setzen in solenv/inc/settings.mk . I suspect that stuff has been unusable for years and can be removed safely... If we do this, can we then get rid of the .pro sufffix on the build directories, too, please? I started on that at some point in the past, but left it unfinished. Maybe I'll do it this weekend, if I feel like it :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] remove unused declaration - an unlikely fix for armel segfault in regcomp
On 2/2/11 10:01 PM, Kevin Hunter wrote: At 3:31pm -0500 Wed, 02 Feb 2011, Michael Meeks wrote: On Wed, 2011-02-02 at 13:44 +, Wols Lists wrote: Not quite sure what you mean by legacy Intel, but if you're referring to all single-processor CPUs, they still power most of the budget brand new laptops! Surely those guys are hyper-threaded by now ? at least the Atom (which is cheap as chips [sic] ;-) is. I recognize this comment was in gest, but thought I'd chime in with a tidbit. I believe that Intel removed HTT after the Pentium 4 chip. Of note, as well, is that hyperthreading (HTT) is not as universal an upgrade as true multi-core chips. In fact, the general practice in the High Performance Computing (HPC) community is to turn off hyperthreading because it degrades performance for most workloads. A further note is that there is some skepticism as to the security of HTT, in terms of side-channel monitoring of in-core process data. Actually, now that I just wrote the above, I seem to recall a discussion of HTT technology in the Nehalem chip. When I have time, I might research that ... Cheers, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Kevin you are right the current i7's support HTT. It has come back with a vengeance. the i5's and the i3's don't support hyper threading. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] translated some german comments
I'll take this one. Christina Am 01.02.2011 11:30, schrieb Michael Meeks: Hi Pascal, On Mon, 2011-01-31 at 21:51 +0100, TentleXS wrote: I do not have much time right now. So the comments in the file are not all translated yet. But every litte bit helps, right? :) Right ! :-) much appreciated, pushed it. Incidentally - I know people like things like 'sw', but I was reading (eg.) svtools/inc/ruler.hxx yesterday - specifying an easy-hack around there, and noticed some monster German comment that is (perhaps) easier to translate: five or six pages of text ;-) [ almost certainly inaccurate by now - but perhaps interesting in English ]. Thanks, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] HTML formatting in comments?
Hi, I came across comments with html formatting which makes it difficult to read them. Can this formatting be removed? example: TRUE/ if and only if parsing was successful, FALSE/ if default handling should... (file: libs-core/connectivity/inc/connectivity/sqlnode.hxx) Christina Rossmanith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Accelerate Perl installer builder
On 2011-01-28 Michael Meeks wrote:
Can you confirm your work is under LGPLv3+/MPL please too ?
Yes, of course. The patch is released under LGPLv3+.
Heh - we ask for a dual LGPLv3+ -and- MPL license for changes; so
LGPLv3+/MPL is the question :-)
OK, it's LGPLv3+/MPL then.
I have attached another patch. It makes get_all_items_from_script
run about twice as fast. According to
http://users.freedesktop.org/~michael/make_installer.txt that should
save ~5-7% time on windows.
Oh, and the patch is LGPLv3+/MPL ;-)
regards,
Jan
From 45afa54efa76d7b853b29cd028437134f8425933 Mon Sep 17 00:00:00 2001
From: Jan Darmochwal jdarmoch...@gmx.de
Date: Thu, 3 Feb 2011 12:30:37 +0100
Subject: [PATCH] Accelerate Perl installer builder
speed up get_all_items_from_script
---
solenv/bin/modules/installer/remover.pm |4 +-
solenv/bin/modules/installer/setupscript.pm | 127 +++---
2 files changed, 56 insertions(+), 75 deletions(-)
diff --git a/solenv/bin/modules/installer/remover.pm b/solenv/bin/modules/installer/remover.pm
index 75af6e8..2c039ec 100644
--- a/solenv/bin/modules/installer/remover.pm
+++ b/solenv/bin/modules/installer/remover.pm
@@ -37,8 +37,8 @@ sub remove_leading_and_ending_whitespaces
{
my ( $stringref ) = @_;
-$$stringref =~ s/^\s*//;
-$$stringref =~ s/\s*$//;
+$$stringref =~ s/^\s+//;
+$$stringref =~ s/\s+$//;
}
sub remove_leading_and_ending_quotationmarks
diff --git a/solenv/bin/modules/installer/setupscript.pm b/solenv/bin/modules/installer/setupscript.pm
index 7d3f77f..4e2fbf6 100644
--- a/solenv/bin/modules/installer/setupscript.pm
+++ b/solenv/bin/modules/installer/setupscript.pm
@@ -303,94 +303,75 @@ sub get_all_items_from_script
my ($scriptref, $searchitem) = @_;
my @allitemarray = ();
-
-my ($itemkey, $itemvalue, $valuecounter);
+
+my ($itemkey, $itemvalue);
for ( my $i = 0; $i = $#{$scriptref}; $i++ )
{
my $line = ${$scriptref}[$i];
-
-if ( $line =~ /^\s*\Q$searchitem\E\s+(\S+)\s*$/ )
+
+next unless ($line =~ /^\s*\Q$searchitem\E\s+(\S+)\s*$/);
+my $gid = $1;
+
+my %oneitemhash = ();
+my $ismultilang = 0;
+
+$oneitemhash{'gid'} = $gid;
+
+while (!( $line =~ /^\s*End\s*$/ ))
{
-my $gid = $1;
-my $counter = $i + 1;
-
-my %oneitemhash = ();
-my $ismultilang = 0;
-
-$oneitemhash{'gid'} = $gid;
-
-while (!( $line =~ /^\s*End\s*$/ ))
+if ( $i = $#{$scriptref} ) {
+installer::exiter::exit_program(Invalid setup script file. End of file reached before 'End' line of '$searchitem' section., get_all_items_from_script);
+}
+$line = ${$scriptref}[++$i];
+
+if ( $line =~ /^\s*(.+?)\=\s*(.+?)\;\s*$/ ) # only oneliner!
{
-if ( $counter $#{$scriptref} ) {
-installer::exiter::exit_program(Invalid setup script file. End of file reached before 'End' line of '$searchitem' section., get_all_items_from_script);
-}
-$line = ${$scriptref}[$counter];
-$counter++;
+$itemkey = $1;
+$itemvalue = $2;
-if ( $line =~ /^\s*(.+?)\s*\=\s*(.+?)\s*\;\s*$/ ) # only oneliner!
-{
-$itemkey = $1;
-$itemvalue = $2;
+$itemkey =~ s/\s+$//;
+$itemvalue =~ s/\s+$//;
-installer::remover::remove_leading_and_ending_quotationmarks(\$itemvalue);
-$itemvalue =~ s/\s*$//; # removing ending whitespaces. Could be introduced by empty variables.
+installer::remover::remove_leading_and_ending_quotationmarks(\$itemvalue);
-$oneitemhash{$itemkey} = $itemvalue;
+$oneitemhash{$itemkey} = $itemvalue;
-if ( $itemkey =~ /^\s*\S+\s+\(\S+\)\s*$/ )
-{
-$ismultilang = 1;
-}
-}
-else
+$ismultilang ||= $itemkey =~ /^\S+\s+\(\S+\)$/;
+}
+elsif (($searchitem eq Module)
+ ($line =~ /^\s*.+?\s*\=\s*\(/)
+ (!($line =~ /\)\;\s*$/))) # more than one line, for instance files at modules!
+{
+$line =~ /^\s*(.+?)\s*\=\s*(.+?)\s*$/; # the first line
+$itemkey = $1;
+$itemvalue = $2;
+
+# collecting the complete itemvalue
+do
{
-if ( $searchitem eq Module ) # more than one line, for instance files at modules!
-{
-if (( $line =~ /^\s*(.+?)\s*\=\s*\(/ ) (!($line =~ /\)\;\s*$ / )))
-{
-
Re: [Libreoffice] Breaking in hunspell (Re: Missing vcl resource. This indicates that files vital to localization are missing. You might have a corrupt installation.)
On Wed, 2011-02-02 at 14:49 -0800, David Dumaresq wrote: Hi, I'm getting a failure in hunspell hunspell.cxx:502: error: 'gettext' was not declared in this scope This is probably because gettext development headers/libraries aren't installed. We probably shouldn't need them for the libhunspell and basic command line testing tool that we build, so... can you try and add --disable-nls to CONFIGURE_FLAGS in libo/hunspell/makefile.mk i.e. search for --disable-shared and put --disable-nls at the end of that line. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OSF1 typo in set_soenv.in
On Tue, 2011-02-01 at 22:09 +0100, Francois Tigeot wrote: Hi all, I believe odf1 is a typo for osf1 Fixed now. It would seem that Open/LibreOffice has not been able to be built on OSF1 systems for more than 2 years, and no one has noticed so far. Hmm, I don't think it actually does build under OSF1. I seriously doubt it actually given there's apparently no uno bridge for that platform. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Need help with compile error. Was: How do I update my download?
Hi, maybe make clean prior to build helps? Christina Rossmanith ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] avoid ambiguous else
Hi Kohei, Thomas, On Wed, 02 Feb 2011 17:44:37 -0500, Kohei Yoshida kyosh...@novell.com wrote: On Wed, 2011-02-02 at 23:27 +0100, Thomas Arnhold wrote: Oh, I think this was a mistake o mine. I removed the brackets, didn't really thought, that the else statement could be associated with the inner if. I attached the patch to bring the brackets back. No worries I'd already put the fix in before you sent your patch. :-) Thanks a lot for your quick response fix! FYI, ANSI/ISO C takes care of the ambiguous else by describing like: An else is associated with the lexically immediately preceding else -less if that is in the same block (but not in an enclosed block). but I could not find the equivalent statement in ISO C++ specification. Well, I am a fan of such a meta-ambiguity ;) Cheers, -- Takeshi Abe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: Horizontal glyph adjustments are ignored with ICU layout
On Fri, Jan 28, 2011 at 02:17:44PM +, Caolán McNamara wrote: Can we take it that your submission is under our recommended LGPLv3+/MPL licence ? Sure, this and any future submissions are LGPLv3+/MPL licensed. -- Khaled Hosny Egyptian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] HTML formatting in comments?
On Thu, 2011-02-03 at 12:46 +0100, Christina Roßmanith wrote: Hi, I came across comments with html formatting which makes it difficult to read them. Can this formatting be removed? example: TRUE/ if and only if parsing was successful, FALSE/ if default handling should... (file: libs-core/connectivity/inc/connectivity/sqlnode.hxx) I think doxygen and javadoc both support certain html tags, and I personally find them acceptable (to a certain degree). I myself also use certain html tags, such as b/b and i/i, because it's useful to emphasize certain things and some doxygen/javadoc interpreters (including one in my editor) support some basic html tags, and they are not that unpleasant when read in the raw form (IMO). Having said that, I don't know about this particular tag TRUE/ and FALSE/. This is used a lot across the code base, but I don't think they are html tags. I'm neutral on this; they don't bother me when I read them, but I don't personally use them. So, no strong opinion from me. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] remove unused declaration - an unlikely fix for armel segfault in regcomp
Jonathan, This is now my fourth mail on this issue with no action. It is rather rude to add a few lines at the bottom of a mail without removing the context. To help you count the lines, and re-inforce the point, I will manually number them below; please count them out loud with me: 1 On Thu, 2011-02-03 at 11:42 +0100, Jonathan Aquilina wrote: 2 On 2/2/11 10:01 PM, Kevin Hunter wrote: 3 At 3:31pm -0500 Wed, 02 Feb 2011, Michael Meeks wrote: 4 On Wed, 2011-02-02 at 13:44 +, Wols Lists wrote: 5 Not quite sure what you mean by legacy Intel, but if you're 6 referring to all single-processor CPUs, they still power most of 7 the budget brand new laptops! 8 9 Surely those guys are hyper-threaded by now ? at least the Atom 10 (which is cheap as chips [sic] ;-) is. 11 12 I recognize this comment was in gest, but thought I'd chime in with a 13 tidbit. I believe that Intel removed HTT after the Pentium 4 chip. 14 Of note, as well, is that hyperthreading (HTT) is not as universal 15 an upgrade as true multi-core chips. In fact, the general practice in 16 the High Performance Computing (HPC) community is to turn off 17 hyperthreading because it degrades performance for most workloads. 18 19 A further note is that there is some skepticism as to the security of 20 HTT, in terms of side-channel monitoring of in-core process data. 21 22 Actually, now that I just wrote the above, I seem to recall a 23 discussion of HTT technology in the Nehalem chip. When I have time, I 24 might research that ... 25 26 Cheers, 27 28 Kevin 29 ___ 30 LibreOffice mailing list 31 LibreOffice@lists.freedesktop.org 32 http://lists.freedesktop.org/mailman/listinfo/libreoffice Notice, not even removing the ML signature. And then we have the two lines of content: Kevin you are right the current i7's support HTT. It has come back with a vengeance. the i5's and the i3's don't support hyper threading. Then I read the content, and do the obligatory google search to see if in fact what you are saying is reliable and useful (it is worth researching what you say before saying it right ?). Intel's pages on their current i5 and i3 processors (eg. http://www.intel.com/consumer/products/processors/corei5.htm ) strongly suggests the opposite. I'm sorry if this seems harsh; but - I would like a lower noise level; absent that - we'll move you to moderated posting until things improve :-) Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Fwd: Re: [PUSHED] translated some german comments]
I didn't notice it wasn't sent to the list, sorry for that! Tobias Am 03.02.2011 16:04, schrieb Michael Meeks: Hi Christina, Can you integrate Tobias' work :-) Tobias - so sorry ! I was out Wednesday, and Thur morning, and didn't see your lovely work - which is tragic. Please always CC the dev list; we're a friendly bunch and love to get new contributors involved. Thanks guys ! Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] leak per frame, mac input request.
On Wed, Feb 2, 2011 at 10:10 AM, Caolán McNamara caol...@redhat.com wrote: On Tue, 2011-02-01 at 10:59 -0600, Norbert Thiebaud wrote: Yes there is somethng special on Mac: there is one menu bar only and it is at the top of the display. it has a little apple icon as first menu, then a menu that is named with the name of the application. in that later menu you should find the About item and the Preference Item. I pushed the changes I wanted to make to this thing, could you check that it still works now. It still works. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Recording changes: Deleted lines 'misbehaving'.
Hi Andy, On Wed, 2011-02-02 at 22:59 +, Andy Hearn wrote: Here's another issue affecting collaborative authors. Nice catch :-) (FWIW: I'm on master branch, pulled today, around 1900GMT) Glad you're up-to-speed. 1. New odt. Fill a page of text, say four or five paragraphs. ... Sounds like this needs turning into a unit test; any chance you could start with that ? the whole redlining world is in desparate need of deep torture testing :-) I would hack at: sw/qa/core/swdoc-test.cpp Where you should have a near full Writer instance run headless as a unit test, and replicate what the key-entries are doing (I suppose) programatically (manipulating the document). Interestingly, if you are showing the red-lining (with strikethrough) I would expect things to be more reliable ;-) when it is not shown, per-key-stroke (or so) we re-insert all the red-lining, add the keystroke, then remove all the red-lining from the model [ this is not wonderful for performance, as perhaps you can imagine ;-]. Anyhow, I would dig into: sw/inc/redline.hxx and its uses around the place (the feature is called 'redlining') traditionally. Also, loading a .doc with recorded changes on MSWord shows same behaviour for deleted text. Inserted text appear to be unaffected. Great. Is anyone already aware of this, or is working on/with Recording Changes? If not, then I want to dive in. It would be just great to have you working on it, and its all yours :-) All the best, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [Fwd: [PATCH] new De-Java-ised flat XML export]
Hi Peter, On 2011-02-03 at 00:00 +0100, Jan Holesovsky wrote: I am just integrating that, fixing few minor things there (we should not do 'use namespace' in the headers); but looks great overall! I hope I'll be able to push later tonight. I've reviewed your patches, and have them building in my local tree. I'll do few tests tomorrow, and push :-) Wrt. the 'using namespace', I fixed those only in the sax header, but left the private headers (like LibXSLTTransformer.hxx) as they are. I also named your implementation of odfflatxml to OdfFlatXml.cxx, and removed a bit more in scp2. Please have a look at the git history when I push this, I hope I did not break your intentions too much ;-) I pushed everything but libxslt-xsltfilter-impl.patch; the flat odf export and import works like a charm - it is fast and nice, thank you for that! :-) Great stuff. Unfortunately, the libxslt-xsltfilter-impl.patch changes break the Word 2003 XML export for me (even though you wrote that it should use the old implementation for that one, right?). The error I am getting is: compilation error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 28 element stylesheet xsl:version: only 1.0 features are supported xmlXPathCompOpEval: function new not found XPath error : Unregistered function xmlXPathCompiledEval: evaluation failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 30 element param Evaluating global variable var/param being computed failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 31 element param Variable 'oleExtractor' has not been declared. xmlXPathCompOpEval: parameter error xmlXPathCompiledEval: evaluation failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 31 element param Evaluating global variable var/param being computed failed xmlXPathCompOpEval: function new not found XPath error : Unregistered function xmlXPathCompiledEval: evaluation failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 30 element param Evaluating global variable var/param being computed failed Attached the document that triggered that for me (if it is of any value). Regards, Kendy flat-xml.fodt Description: application/vnd.oasis.opendocument.text ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OSF1 typo in set_soenv.in
On Thu, Feb 03, 2011 at 01:19:13PM +, Caolán McNamara wrote: On Tue, 2011-02-01 at 22:09 +0100, Francois Tigeot wrote: It would seem that Open/LibreOffice has not been able to be built on OSF1 systems for more than 2 years, and no one has noticed so far. Hmm, I don't think it actually does build under OSF1. I seriously doubt it actually given there's apparently no uno bridge for that platform. My thoughts exactly. Should references to it be removed from the build system ? Would it be worth it ? I hope the new Gnu Make build system won't need to have all sorts of platform details defined everywhere like now... -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use generic base64 encoder
On Wed, 2011-02-02 at 12:44 +0900, KUROSAWA, Takeshi wrote: SVG export filter has own Base64 encoder in FastString class. But we have several more generic Base64 encoders in the code tree. e.g. Lol :-) we have at least four of them ? I wonder if we could consolidate the others at the same time ? Great work, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] HTML formatting in comments?
Ok, didn't know, that idl files get handled another way. How do we
clearly identify IDL and related files, which shouldn't be handled by
doxygen?! Are these only files with the idl extension? And is the
doxygen documentation complete without these files?
As an simple alternative we could define aliases for TRUE/FALSE and so
on with doxygen, say it replaces TRUE/ with TRUE.
Thomas
On 02/03/2011 05:50 PM, Cedric Bosdonnat wrote:
You need to pay attention to the internal javadoc-like tool used for IDL
files and some hxx files as well. This has some special tags... all the
doc is here:
http://api.openoffice.org/docs/DevelopersGuide/Appendix/IDLDocumentationGuide/IDLDocumentationGuide.xhtml
TRUE/ and FALSE/ are valid for this one. I would be in favor of
removing the use of that tool in C++ code and replace it by doxygen
comments... Keeping that thing for IDL only would be nice.
Regards,
On Thu, 2011-02-03 at 17:41 +0100, Thomas Arnhold wrote:
In addition to this:
There's the possibility to define multiple return values with \retval.
So we would get a nice formatted list like with param.
From the doxyfile documentation:
-
\retval return value { description }
Starts a description for a function's return value with name return
value, followed by a description of the return value. The text of the
paragraph that forms the description has no special internal structure.
All visual enhancement commands may be used inside the paragraph.
Multiple adjacent \retval commands will be joined into a single
paragraph. Each return value description will start on a new line. The
\retval description ends when a blank line or some other sectioning
command is encountered.
-
I think it would be nice to use this. I could write a simple script
which replaces TRUE/FALSE with @retval.
Thomas
On 02/03/2011 04:28 PM, Thomas Arnhold wrote:
Hi Christina,
seems like a XHMTL or XML tag. But doxygen doesn't know them. Here is
the list of known tags to doxygen:
http://www.stack.nl/~dimitri/doxygen/htmlcmds.html
http://www.stack.nl/~dimitri/doxygen/xmlcmds.html
If you run doxygen it says: Unsupported xml/html tag TRUE found. So
you're right. We could simply replace this with TRUE and FALSE.
Thomas
On 02/03/2011 12:46 PM, Christina Roßmanith wrote:
Hi,
I came across comments with html formatting which makes it difficult to
read them. Can this formatting be removed?
example: TRUE/ if and only if parsing was successful, FALSE/ if
default handling should...
(file: libs-core/connectivity/inc/connectivity/sqlnode.hxx)
Christina Rossmanith
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: [Fwd: [PATCH] new De-Java-ised flat XML export]
Ouch! I forgot to include the changed configuration files for the office2003 filters. I'll send that missing patch as soon as I'm home. Sorry, Peter Am 03.02.2011 um 17:54 schrieb Jan Holesovsky ke...@suse.cz: Hi Peter, On 2011-02-03 at 00:00 +0100, Jan Holesovsky wrote: I am just integrating that, fixing few minor things there (we should not do 'use namespace' in the headers); but looks great overall! I hope I'll be able to push later tonight. I've reviewed your patches, and have them building in my local tree. I'll do few tests tomorrow, and push :-) Wrt. the 'using namespace', I fixed those only in the sax header, but left the private headers (like LibXSLTTransformer.hxx) as they are. I also named your implementation of odfflatxml to OdfFlatXml.cxx, and removed a bit more in scp2. Please have a look at the git history when I push this, I hope I did not break your intentions too much ;-) I pushed everything but libxslt-xsltfilter-impl.patch; the flat odf export and import works like a charm - it is fast and nice, thank you for that! :-) Great stuff. Unfortunately, the libxslt-xsltfilter-impl.patch changes break the Word 2003 XML export for me (even though you wrote that it should use the old implementation for that one, right?). The error I am getting is: compilation error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 28 element stylesheet xsl:version: only 1.0 features are supported xmlXPathCompOpEval: function new not found XPath error : Unregistered function xmlXPathCompiledEval: evaluation failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 30 element param Evaluating global variable var/param being computed failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 31 element param Variable 'oleExtractor' has not been declared. xmlXPathCompOpEval: parameter error xmlXPathCompiledEval: evaluation failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 31 element param Evaluating global variable var/param being computed failed xmlXPathCompOpEval: function new not found XPath error : Unregistered function xmlXPathCompiledEval: evaluation failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 30 element param Evaluating global variable var/param being computed failed Attached the document that triggered that for me (if it is of any value). Regards, Kendy flat-xml.fodt ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] custom icon
Hi there, On Tue, 2011-02-01 at 23:39 +0700, Nguyen Vu Hung wrote: Is it possible to build LibOffice with a custom icon. Of course :-) For example, we want to use a customized icon by adding a drum to the background of LibO icon like this http://vi.openoffice.org/images/oooviet3.png That is quite easy. We are trying to consolidate the branding images in the code into: default_images/brand/ So you would just need to drop .png images into there; while you're there - I would re-brand the 'about' dialog, and also the shell images (inside shell/). Then just re-build, and you're done :-) HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] custom icon
On Thu, Feb 3, 2011 at 6:40 PM, Nguyen Vu Hung vuhung16p...@gmail.com wrote:
On Fri, Feb 4, 2011 at 12:32 AM, Michael Meeks michael.me...@novell.com
wrote:
Hi there,
On Tue, 2011-02-01 at 23:39 +0700, Nguyen Vu Hung wrote:
Is it possible to build LibOffice with a custom icon.
Of course :-)
Thank you!
For example, we want to use a customized icon
by adding a drum to the background of LibO icon like this
http://vi.openoffice.org/images/oooviet3.png
That is quite easy. We are trying to consolidate the branding images
in
the code into:
default_images/brand/
So you would just need to drop .png images into there; while you're
there - I would re-brand the 'about' dialog, and also the shell images
(inside shell/).
Well, the file format is .png.
What is the size of the png file and other technical specification
that I have to know?
I'd suggest you to look at the existing ones and just use the same
specifications. In this case, you are sure that they will work.
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
--
Jesús Corrius je...@softcatala.org
Document Foundation founding member
Skype: jcorrius | Twitter: @jcorrius
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Easy Hack: Remove obsolete BmpColorMode enum
Hello Michael, I was waiting to edit the wiki pages until I heard back that the patches look good, so I just now went and edited them before sending this. I haven't really looked at much else yet(I only had a few minutes to spare at the time), but I plan on doing more work in the future, and will keep on eye out for anything else that looks obsolete and/or pointless. You could probably expect some more Easy Hacks to be worked on by me in the near future. Chris Carpenter On Thu, Feb 3, 2011 at 12:00 PM, Michael Meeks michael.me...@novell.comwrote: Hi Chris, On Tue, 2011-02-01 at 23:44 -0600, Chris Carpenter wrote: Released under the LGPLv3+ / MPL Tested and runs under Debian Linux x86_64 Great work ! Thanks for that. Any chance you could move the Easy Hacks task across to the 'completed' page if you havn't already ? and/or did you spot anything else that is clearly obsolete and/or pointless nearby that is worth killing ? :-) Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Difficulty building VCL on win32
I was unable to build VCL because of an error with Graphite. I couldn't see any way to disable graphite in the configure script so I ended up hard-coding an #undef ENABLE_GRAPHITE into the files that failed. Here's the errors I get (same error from winlayout.cxx too). Anyone know what's wrong with my build that causes this? Compiling: vcl/win/source/gdi/salgdi3.cxx C:/cygwin/home/Steve/libre/libo/solver/330/wntmsci12.pro/inc\graphite/WinFont.h(32) : error C2386: 'stdext' : a symbol with this name already exists in the current scope C:/cygwin/home/Steve/libre/libo/solver/330/wntmsci12.pro/inc\graphite/WinFont.h(215) : error C2039: 'hash_map' : is not a member of 'stdext' ... dmake: Error code 2, while making '../../../wntmsci12.pro/slo/salgdi3.obj' ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Authorized information source about security fixes
Hi all, Several persons asked me if security fixes implemented in OOo 3.3.0 have been ported to LibreOffice. I know that is indeed the case, but it is embarrassing to not have an authorized information source allowing to confirm that. I think it is very important for LibreOffice's credibility with government institutions and companies. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Pushed] Re: [Fwd: [PATCH] new De-Java-ised flat XML export]
Hi Kendy, attached you find the missing changes to the wordml/excelml filter configurations to make them use the JAXT transformer service (as long as the OLE extracting extenstion functions haven't been ported to libxslt). Sorry again for the hassle and thanks for reviewing the patch. Bye, Peter Am Donnerstag, den 03.02.2011, 17:54 +0100 schrieb Jan Holesovsky: Hi Peter, On 2011-02-03 at 00:00 +0100, Jan Holesovsky wrote: I am just integrating that, fixing few minor things there (we should not do 'use namespace' in the headers); but looks great overall! I hope I'll be able to push later tonight. I've reviewed your patches, and have them building in my local tree. I'll do few tests tomorrow, and push :-) Wrt. the 'using namespace', I fixed those only in the sax header, but left the private headers (like LibXSLTTransformer.hxx) as they are. I also named your implementation of odfflatxml to OdfFlatXml.cxx, and removed a bit more in scp2. Please have a look at the git history when I push this, I hope I did not break your intentions too much ;-) I pushed everything but libxslt-xsltfilter-impl.patch; the flat odf export and import works like a charm - it is fast and nice, thank you for that! :-) Great stuff. Unfortunately, the libxslt-xsltfilter-impl.patch changes break the Word 2003 XML export for me (even though you wrote that it should use the old implementation for that one, right?). The error I am getting is: compilation error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 28 element stylesheet xsl:version: only 1.0 features are supported xmlXPathCompOpEval: function new not found XPath error : Unregistered function xmlXPathCompiledEval: evaluation failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 30 element param Evaluating global variable var/param being computed failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 31 element param Variable 'oleExtractor' has not been declared. xmlXPathCompOpEval: parameter error xmlXPathCompiledEval: evaluation failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 31 element param Evaluating global variable var/param being computed failed xmlXPathCompOpEval: function new not found XPath error : Unregistered function xmlXPathCompiledEval: evaluation failed runtime error: file file:///local/libreoffice/master/install/basis-link/share/xslt/export/wordml/ooo2wordml_draw.xsl line 30 element param Evaluating global variable var/param being computed failed Attached the document that triggered that for me (if it is of any value). Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice From 11959f6bd7166f7a16c9c507b73da04c2c6eddcc Mon Sep 17 00:00:00 2001 From: Peter Jentsch pj...@guineapics.de Date: Thu, 3 Feb 2011 21:56:27 +0100 Subject: [PATCH 16/16] add missing config entry for JAXP transformation to word/excel 2003 filters --- .../config/fragments/filters/MS_Excel_2003_XML.xcu |2 +- .../config/fragments/filters/MS_Word_2003_XML.xcu |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/filter/source/config/fragments/filters/MS_Excel_2003_XML.xcu b/filter/source/config/fragments/filters/MS_Excel_2003_XML.xcu index d0d2b13..a0bb672 100644 --- a/filter/source/config/fragments/filters/MS_Excel_2003_XML.xcu +++ b/filter/source/config/fragments/filters/MS_Excel_2003_XML.xcu @@ -2,7 +2,7 @@ prop oor:name=FlagsvalueIMPORT EXPORT ALIEN 3RDPARTYFILTER/value/prop prop oor:name=UIComponent/ prop oor:name=FilterServicevaluecom.sun.star.comp.Writer.XmlFilterAdaptor/value/prop -prop oor:name=UserDatavalue oor:separator=,com.sun.star.documentconversion.XSLTFilter,,com.sun.star.comp.Calc.XMLOasisImporter,com.sun.star.comp.Calc.XMLOasisExporter,../share/xslt/import/spreadsheetml/spreadsheetml2ooo.xsl,../share/xslt/export/spreadsheetml/ooo2spreadsheetml.xsl/value/prop +prop oor:name=UserDatavalue oor:separator=,com.sun.star.documentconversion.XSLTFilter,com.sun.star.comp.JAXTHelper,com.sun.star.comp.Calc.XMLOasisImporter,com.sun.star.comp.Calc.XMLOasisExporter,../share/xslt/import/spreadsheetml/spreadsheetml2ooo.xsl,../share/xslt/export/spreadsheetml/ooo2spreadsheetml.xsl/value/prop prop oor:name=FileFormatVersionvalue0/value/prop prop oor:name=Typevaluecalc_MS_Excel_2003_XML/value/prop prop oor:name=TemplateName/ diff --git a/filter/source/config/fragments/filters/MS_Word_2003_XML.xcu b/filter/source/config/fragments/filters/MS_Word_2003_XML.xcu index c953598..4568910 100644 ---
Re: [Libreoffice] [PUSHED] Re: Horizontal glyph adjustments are ignored with ICU layout
On Fri, Jan 28, 2011 at 02:17:44PM +, Caolán McNamara wrote: On Wed, 2011-01-26 at 17:03 +, Caolán McNamara wrote: On Wed, 2011-01-26 at 11:22 +0100, Jan Holesovsky wrote: Anybody here with ideas what we can do so that the patch helps Khaled, and is as safe as possible? - so that we can commit it, and fix the consequences later if anything happens? Where things are most likely to go wrong are with e.g. Indic text. What's ideally needed is some before and after tests with e.g. Hindi, Tamil, text that needs (the infamous) reordering processing. Ok, so I pulled down our RedHat Indic test cases and they appear to be the same before and after for this, so it doesn't obviously break anything. It seems more of a band-aid than a full fix to me, but it does improve the attached to fdo#31016 test case. Indeed. A real long term fix is to drop ICU layout engine altogether and switch to HarfBuzz, however HarfBuzz lacks Indic shaper right now (promised to be there by March), once it have one we should consider doing so (I'd try to give a hand). So I've pushed this now and added a little one-liner define around the relevant bit to make it easy to disable if any problems do arise. So thanks for this, CTL rendering is rather tricky, and while there's been a fair amount of work on Indic languages, Arabic is probably the one in worst shape. Next on the list is the horribly broken Kashida justification and make it optional. Regards, Khaled -- Khaled Hosny Egyptian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] ure/sal/inc/rtl/ustring.hxx - new method isEmpty()
Hi,
as I understand this, it would be nice to have this method in OString,
too. I've attached the patch.
Thomas
On 01/21/2011 05:55 PM, Michael Meeks wrote:
Hi Thomas,
On Fri, 2011-01-21 at 13:52 +0100, Thomas Arnhold wrote:
New method: isEmpty() - Checks if a string is empty.
I like it.
There are lots of use-cases that we need to get into sal: that we sadly
don't have at the moment: to make writing code easier and less
error-prone.
With isEmpty() this looks like:
if (aStr.isEmpty()) {...}
if (!aStr.isEmpty()) {...}
Prettier for sure.
There are some methods that are all 'pure' and all that (like those for
tokenising rtl::OUStrings) that get used in fairly unreadable ways
around the place. In a world of iterators, it is unclear to me why we
need to be managing string offsets and odd loops using 'getToken()'
Really, we need to be making OUStrings and StringBuffers easier to use,
so that we can use them everywhere - in place of the obsolete (mutable)
tools/inc/tools/string.hxx (UniString) - (mostly called 'String' outside
there).
I suppose, simply porting a good number of String instances would help
us fall over the missing pieces there.
Anyhow - nice patch, pushed to master; I added a:
@since LibreOffice 3.4
tag to the method call, since this low level piece is intended to be a
stable ABI that is managed in that way.
Thanks !
Michael.
From fee2cdb972482cb3682e83a72954d31c6ec6fcdc Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Thu, 3 Feb 2011 22:40:17 +0100
Subject: [PATCH] OString: New method isEmpty()
---
sal/inc/rtl/string.hxx | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/sal/inc/rtl/string.hxx b/sal/inc/rtl/string.hxx
index 86bc1a6..c1af815 100644
--- a/sal/inc/rtl/string.hxx
+++ b/sal/inc/rtl/string.hxx
@@ -223,6 +223,22 @@ public:
sal_Int32 getLength() const SAL_THROW(()) { return pData-length; }
/**
+ Checks if a string is empty.
+
+ @return sal_True if the string is empty;
+sal_False, otherwise.
+
+ @since LibreOffice 3.4
+*/
+sal_Bool isEmpty() const SAL_THROW(())
+{
+if ( pData-length )
+return sal_False;
+else
+return sal_True;
+}
+
+/**
Returns a pointer to the characters of this string.
pThe returned pointer is not guaranteed to point to a null-terminated
--
1.7.3.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Authorized information source about security fixes
On Thu, Feb 03, 2011 at 10:01:35PM +0100, Jean-Baptiste Faure wrote: been ported to LibreOffice. I know that is indeed the case, but it is Yes, it is. embarrassing to not have an authorized information source allowing to confirm that. Well, we say we base on OOo 3.3, no? I don't know what you count as authorized, but this is at least worth pointing people to: http://lists.debian.org/debian-openoffice/2011/01/msg00287.html Grüße/Regards, René -- .''`. René Engelhard -- Debian GNU/Linux Developer : :' : http://www.debian.org | http://people.debian.org/~rene/ `. `' r...@debian.org | GnuPG-Key ID: D03E3E70 `- Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Authorized information source about security fixes
Hi, On Thu, Feb 03, 2011 at 10:01:35PM +0100, Jean-Baptiste Faure wrote: Several persons asked me if security fixes implemented in OOo 3.3.0 have been ported to LibreOffice. I know that is indeed the case, but it is embarrassing to not have an authorized information source allowing to confirm that. And http://www.debian.org/security/2011/dsa-2151 would also be a source. Unfortunately Martin dropped the LibreOffice from the experimental sentence compared to my suggestion so it looks as if they were fixed in OOo 3.3.0 which is not true I don't think this matters much anyways, for this release it's too late anyways (and people can be told, and we say we base on OOo 3.3.0), and if there's security issues in LibO (and/or OOo) we need to properly announce them anyways. Grüße/Regards, René -- .''`. René Engelhard -- Debian GNU/Linux Developer : :' : http://www.debian.org | http://people.debian.org/~rene/ `. `' r...@debian.org | GnuPG-Key ID: D03E3E70 `- Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] (OT) Windows shared package manager, CoAPP ready for 1st binary release
Hi, Thought some might find this interesting. The CoApp project [1] is scheduled to release first CLI binary for folks to play with tomorrow. In a nutshell this is a community developed shared package manager for MS Windows under an apache license, lead by a MS engineer in the MS OSS center in Redmond, with many non-MS devs involved. For a quick overview, a teaser video[2], if you just want the elevator pitch :-) Not 100% certain, but I believe this early version will support non-CoApp specific MSI installation packages also, not sure to what extent however. The native windows GUI is yet to be wrapped up but it will more or less just run the CLI tool, IIRC. Anyway - as I said, perhaps someone here might be interested. Your are doing great work on Libo guys, Drew [1] https://launchpad.net/coapp [2] http://www.youtube.com/watch?v=OOavxGRSt-k ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] New mimetype icons - need patch review for -3-3
Hi, please find a set of patches to bring the new mimetype icons into LibO-3-3 here: http://users.freedesktop.org/~thorsten/0001-New-mimetype-icons-for-LibreOffice-artwork.patch http://users.freedesktop.org/~thorsten/0002-New-mimetype-icons-for-LibreOffice-components.patch http://users.freedesktop.org/~thorsten/0003-New-mimetype-icons-for-LibreOffice-libs-core.patch http://users.freedesktop.org/~thorsten/0004-New-mimetype-icons-for-LibreOffice-artwork.patch the source svg for those is here: http://users.freedesktop.org/~thorsten/LibreOffice_Initial_Icons.svg the scripts to convert, and distribute, are here: http://users.freedesktop.org/~thorsten/icon-update.tgz I'd need a patch review before committing that to -3-3. Linux Mac builds work fine look great, did not yet try win32. Oh, and it's tracked in this bug: https://bugs.freedesktop.org/show_bug.cgi?id=33229 Cheers, -- Thorsten pgpdoZ23PltWD.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Venha para a melhor loja de infoprodutos da net a tudo aqui eletronicos software
Seu cliente de e-mail não pode ler este e-mail. Para visualizá-lo on-line, por favor, clique aqui: http://www.mkt3000.com.br/envio/display.php?M=3456300C=a6d58090af737c6769de7bc3bae45cedS=96L=87N=12 Para parar de receber nossos Emails:http://www.mkt3000.com.br/envio/unsubscribe.php?M=3456300C=a6d58090af737c6769de7bc3bae45cedL=87N=96 Email Marketing ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Usability issue: no way to rotate an image on a frame
Hi there. I'm using LibreOffice 3.3.0 OOO330m19 (Build:6) 3.3.0.4 ArchLinux build-1 I have to rotate an image but there's no way to do it, at least not an obvious way: - Menu Picture doesn't provide tools for that - Click another time when selected does nothing either (like inkscape). - Contextual toolbars doesn't have that option either. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Usability issue: no way to rotate an image on a frame
Hello Joshua, On Fri, 2011-02-04 at 00:58 -0600, Joshua Ismael wrote: I have to rotate an image but there's no way to do it, at least not an obvious way: You probably mean you can't do it in Writer, right? In that case this is a known and old issue... thought it's no easy thing to hack. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] HTML formatting in comments?
Hi Thomas, On Thu, 2011-02-03 at 18:07 +0100, Thomas Arnhold wrote: Ok, didn't know, that idl files get handled another way. How do we clearly identify IDL and related files, which shouldn't be handled by doxygen?! Are these only files with the idl extension? And is the doxygen documentation complete without these files? IMHO the files that should use that custom markup should only be the *.idl files (mostly located in the offapi module). I would say that all use of that markup in hxx files should be banned / changed. I know that some files are using it to produce the doc linked here on OOo website: http://api.openoffice.org/docs/cpp/ref/names/index.html As an simple alternative we could define aliases for TRUE/FALSE and so on with doxygen, say it replaces TRUE/ with TRUE. Well, a simple script that spots all the occurences of these tags in C++ would help as well. It could at least show us the files containing comments to switch to Doxygen documentation style. Then sed is your friend for this kind of boring job :) -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] LibreOffice default UI font need to be changed
Look at
http://opengrok.go-oo.org./xref/libs-core/officecfg/registry/data/org/openoffice/VCL.xcu#129
prop oor:name=UI_SANS oor:type=xs:string oor:op=replace
valueAndale Sans UI;Arial Unicode MS;Lucida Sans Unicode;Tahoma;DejaVu
Sans;Albany AMT;Albany;Arial;Nimbus Sans L;Interface
User;WarpSans;Geneva;Tahoma;MS Sans
Serif;Helv;Dialog;Lucida;Helvetica;Charcoal;Chicago;Helmet;Interface
System;Sans Serif/value
/prop
You can see that the first-priority default UI font of every LibreOffice
applications are, Andale Sans UI. However, Andale Sans UI is not
available on all system. I guess Andale Sans UI will be installed with
StarOffice. So it's not logical to be used as the first-priority default UI
font.
Look at
http://opengrok.go-oo.org./xref/libs-gui/vcl/source/window/window.cxx#287
if ( ! aUserInterfaceFont.Len() )
{
String aFallbackFont (RTL_CONSTASCII_USTRINGPARAM( Andale Sans UI ));
if ( mpWindowImpl-mpFrameData-mpFontList-FindFontFamily(
aFallbackFont ) )
aUserInterfaceFont = aFallbackFont;
}
The font also is used as the last-resort fallback font. I suggest we
reconsider the use of this font and create a better font list that works
more cross-platform and cross-locale.
As a side-effect, this would help us fix a Thai locale-sensitive bug :
https://bugs.freedesktop.org/show_bug.cgi?id=33090
--
_/|\_ Samphan Raruenrom. Open Source Development Co., Ltd.
Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
