Re: [Libreoffice] LibreOffice default UI font is StarOffice Andale Sans UI ?
Anyone agree that we should change the LibreOffice default UI font list?
On Fri, Feb 4, 2011 at 2:54 PM, Samphan Raruenrom samp...@osdev.co.thwrote:
Look at
http://opengrok.go-oo.org./xref/libs-core/officecfg/registry/data/org/openoffice/VCL.xcu#129
prop oor:name=UI_SANS oor:type=xs:string oor:op=replace
valueAndale Sans UI;Arial Unicode MS;Lucida Sans Unicode;Tahoma;DejaVu
Sans;Albany AMT;Albany;Arial;Nimbus Sans L;Interface
User;WarpSans;Geneva;Tahoma;MS Sans
Serif;Helv;Dialog;Lucida;Helvetica;Charcoal;Chicago;Helmet;Interface
System;Sans Serif/value
/prop
You can see that the first-priority default UI font of every LibreOffice
applications are, Andale Sans UI. However, Andale Sans UI is not
available on all system. I guess Andale Sans UI will be installed with
StarOffice. So it's not logical to be used as the first-priority default UI
font.
Look at
http://opengrok.go-oo.org./xref/libs-gui/vcl/source/window/window.cxx#287
if ( ! aUserInterfaceFont.Len() )
{
String aFallbackFont (RTL_CONSTASCII_USTRINGPARAM( Andale Sans UI
));
if ( mpWindowImpl-mpFrameData-mpFontList-FindFontFamily(
aFallbackFont ) )
aUserInterfaceFont = aFallbackFont;
}
The font also is used as the last-resort fallback font. I suggest we
reconsider the use of this font and create a better font list that works
more cross-platform and cross-locale.
As a side-effect, this would help us fix a Thai locale-sensitive bug :
https://bugs.freedesktop.org/show_bug.cgi?id=33090
--
_/|\_ Samphan Raruenrom. Open Source Development Co., Ltd.
Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/
--
_/|\_ Samphan Raruenrom. Open Source Development Co., Ltd.
Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Commented out some unused functions in calc
* Alfonso Eusebio alfonso_euse...@yahoo.co.uk schrieb: If it's ok to remove the functions from the unused list directly I'm happy to do that. I was a bit concerned because some of those functions might be required at some point. That's what we have an VCS w/ proper history for ;-p In most cases they are just member functions (overloaded or not) that are not being used right now, but that doesn't mean that they might not be useful at some point. How complex are the functions in question ? Would it take much time to reimplent or just find them in the history, if and when they'd really become useful someday ? cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weig...@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice default UI font need to be changed
Hi,
On Fri, Feb 4, 2011 at 2:54 PM, Samphan Raruenrom samp...@osdev.co.th wrote:
Look at
http://opengrok.go-oo.org./xref/libs-core/officecfg/registry/data/org/openoffice/VCL.xcu#129
FYI
http://wiki.services.openoffice.org/wiki/Font-FAQ#Font_Fallback
prop oor:name=UI_SANS oor:type=xs:string oor:op=replace
valueAndale Sans UI;Arial Unicode MS;Lucida Sans Unicode;Tahoma;DejaVu
Sans;Albany AMT;Albany;Arial;Nimbus Sans L;Interface
User;WarpSans;Geneva;Tahoma;MS Sans
Serif;Helv;Dialog;Lucida;Helvetica;Charcoal;Chicago;Helmet;Interface
System;Sans Serif/value
/prop
For LibO 3.3, under Windows and Mac OS X, the default font is Times New Roman,
which is good enough for Vietnamese.
Arial Unicode MS font is available iff MS Office XP+ is installed.
You can see that the first-priority default UI font of every LibreOffice
applications are, Andale Sans UI. However, Andale Sans UI is not
available on all system. I guess Andale Sans UI will be installed with
StarOffice. So it's not logical to be used as the first-priority default UI
font.
Look at
http://opengrok.go-oo.org./xref/libs-gui/vcl/source/window/window.cxx#287
if ( ! aUserInterfaceFont.Len() )
{
String aFallbackFont (RTL_CONSTASCII_USTRINGPARAM( Andale Sans UI
));
The hardcoding is not good.
I think you should fire a patch.
The font also is used as the last-resort fallback font. I suggest we
reconsider the use of this font and create a better font list that works
more cross-platform and cross-locale.
+1
Times New Roman is OK Vietnamese under Windows and Mac OS X.
Under Linux, we can alsoe we Times New Roman if mscorefonts is intalled.
# Well, there will be a debate on legal issue on mscorefonts.
The default font for Japanese should be MS Gothic under Windows and
will be different on Linux and it even varies for different Linux
distributions Kohei-san.
As a side-effect, this would help us fix a Thai locale-sensitive bug :
https://bugs.freedesktop.org/show_bug.cgi?id=33090
FYI, probably Vietnamese has the same issue
http://www.mail-archive.com/discuss@documentfoundation.org/msg04855.html
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Problems with windows build
I only have VS2008 Express C++ edition installed. How much effort is likely required to get it working with 2010, or should I just work on getting it to use 2008? The only thing that didn't work for me using VS2010 was a crash in climaker.exe, everything else works perfectly fine. The LibO 3.3 I was using in the old machine was compiled with VS2010 (using a climaker.exe compiled with VS2008) The stack trace of the crash was the one Tor mentioned previously. So I guess it's just a matter of fixing this and we can announce support for this compiler. -- Jesús Corrius je...@softcatala.org Document Foundation founding member Skype: jcorrius | Twitter: @jcorrius ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Problems with windows build
Hi Jesús 2011/2/5 Jesús Corrius je...@softcatala.org: The stack trace of the crash was the one Tor mentioned previously. So I guess it's just a matter of fixing this and we can announce support for this compiler. I ended up uninstalling VS2010 and it seems to have built now (but I have other issues now). Thanks for your help. Regards Steve ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] remove old icon themes ...
Hi, Just to chime in here: Setting --with-theme does nothing for me, LO builds all icon sets, no matter what I ask it to... cheers Andreas On Tue, 2011-02-01 at 10:53 +, Michael Meeks wrote: On Tue, 2011-02-01 at 10:33 +, Caolán McNamara wrote: On Mon, 2011-01-31 at 16:51 +, Michael Meeks wrote: +--with-theme=default hicontrast tango But would that leave tools-options-libreoffice-view-icon size and style listing themes that aren't available ? Or does it all work out ok. It works out ok. The list shrinks to the set of available icon sets - and we fallback to the platform default icon set if we had previously been configured to use an icon set that no longer exists - ie. it just works(TM) ;-) [ at least in my tests here ]. ATB, Michael. -- Andreas Proschofsky Gentoo Developer / OpenOffice.org Twitter: @suka_hiroaki Identi.ca: @suka ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Authorized information source about security fixes
Jean-Baptiste Faure jbf.fa...@orange.fr schrieb: Hi all, Several persons asked me if security fixes implemented in OOo 3.3.0 have been ported to LibreOffice. I know that is indeed the case, but it is embarrassing to not have an authorized information source allowing to confirm that. I agree. Having a distinctive page like www.libreoffice.org/security with information on all security issues affecting LO, the versions that fixed it and links to the commits fixing it is very useful and following best practices. The best I've seen so far from a free software project are the security advisories issued by the Asterisk developers: http://downloads.asterisk.org/pub/security Cheers, Moritz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fdo#30879
Reviewed. (One more person review might help thou.) On 02/04/2011 09:57 PM, Noel Power wrote: This fix reverts a libreoffice specific change which introduced a regression. please review for libreoffice-3.3 branch fix ( on master ) is here http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=6eb4e55b0a61f793f635a8038895cb2e452dc280 thanks, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice default UI font need to be changed
Hi *,
On Sat, Feb 5, 2011 at 11:26 AM, Nguyen Vu Hung vuhung16p...@gmail.com wrote:
On Fri, Feb 4, 2011 at 2:54 PM, Samphan Raruenrom samp...@osdev.co.th wrote:
Look at
http://opengrok.go-oo.org./xref/libs-core/officecfg/registry/data/org/openoffice/VCL.xcu#129
FYI
http://wiki.services.openoffice.org/wiki/Font-FAQ#Font_Fallback
Yes. It's not only the defaults, but also a Fallback/Replacement list.
For LibO 3.3, under Windows and Mac OS X, the default font is Times New Roman,
which is good enough for Vietnamese.
Yes, because it don't choose fonts that are not available. If The
first in the list isn't available, then it goes on and tries the next
in the list.
You can see that the first-priority default UI font of every LibreOffice
applications are, Andale Sans UI. However, Andale Sans UI is not
available on all system. I guess Andale Sans UI will be installed with
StarOffice. So it's not logical to be used as the first-priority default UI
font.
It is not used when it is not available.
Look at
http://opengrok.go-oo.org./xref/libs-gui/vcl/source/window/window.cxx#287
if ( ! aUserInterfaceFont.Len() )
{
String aFallbackFont (RTL_CONSTASCII_USTRINGPARAM( Andale Sans UI
));
The hardcoding is not good.
I think you should fire a patch.
I don't think so - you need a default to have the fallback work. If
you wouldn't reset it to Andale Sans UI, i.e. a font that is known
to exist in the fallback-list, you had to check for existing fonts
yourself, parse the VCL.xcu before being able to provide a default.
The font also is used as the last-resort fallback font. I suggest we
reconsider the use of this font and create a better font list that works
more cross-platform and cross-locale.
+1
When there are issues cross-locale, then raise them. It is not that
the list didn't change since the beginning of the OOo project.
As a side-effect, this would help us fix a Thai locale-sensitive bug :
https://bugs.freedesktop.org/show_bug.cgi?id=33090
Not at all. The bug explicitly states that this occurs when using the
system-font, i.e. when the vcl.xcu is not used at all.
So changing LO's preferred fonts won't help
Again: The list defines preferred fonts and corresponding fallback
rules in the case when the most preferred one isn't available, it
then just falls back to the next font in the list (and checks for the
font's specific fallback rules that might have special tuning for some
locales), etc.
So just jump ahead without having made up your mind about it.
ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build fails in i18npool
On Sat, 2011-02-05 at 08:43 +0100, Francois Tigeot wrote: Hi, I can't get the build to stop failing in i18npool. The only error message is Exception on createRegistryServiceFactory and I can't get any more details. Try a git pull in ure and try to build again. I think this should work again now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Master Build Status
On Fri, 2011-02-04 at 21:33 -0800, Joseph Powers wrote: hash_map.resize( list.size ) The issue here is that unordered_map doesn't have a resize() method so we can no longer do this micro-optimization. hash_map::resize(n) Increases the bucket count to at least n., so unordered_map::rehash(size_type n); Changes the number of buckets so that there at least n buckets, should be equivalent FWIW. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] 118.11 Length Limit
On Fri, 2011-02-04 at 21:03 -0500, ad...@unserv.net wrote: Libre and Open Office both have the document Length limit in Draw set at 118.11. Is there a way I can hack it to be as long as I want? This *might* be it http://opengrok.go-oo.org/xref/impress/sd/source/ui/func/fupage.cxx#226 C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice default UI font need to be changed
On Sat, Feb 5, 2011 at 9:59 PM, Christian Lohmaier
lohmaier+libreoff...@googlemail.com wrote:
Hi *,
On Sat, Feb 5, 2011 at 11:26 AM, Nguyen Vu Hung vuhung16p...@gmail.com
wrote:
On Fri, Feb 4, 2011 at 2:54 PM, Samphan Raruenrom samp...@osdev.co.th
wrote:
I don't think so - you need a default to have the fallback work. If
you wouldn't reset it to Andale Sans UI, i.e. a font that is known
to exist in the fallback-list, you had to check for existing fonts
yourself, parse the VCL.xcu before being able to provide a default.
The font also is used as the last-resort fallback font. I suggest we
reconsider the use of this font and create a better font list that works
more cross-platform and cross-locale.
+1
When there are issues cross-locale, then raise them. It is not that
the list didn't change since the beginning of the OOo project.
If I understand the OP correctly, he wants LibO to
1. Handle different languages on different locales.
And because available fonts are different from OS (platform) to OS
(platform), so
2. LibO should be able to have a right list of fonts to use for different OSes.
Having a list, as the default configuration, of fonts in highest to
lowest priority
for different languages and locales is a good idea.
And, IMHO, to do so, I think we should so let user to edit font priority list.
# Not hardcoded in VCL.xcu
Please correct me if I am wrong.
--
Best Regards,
Nguyen Hung Vu [aka: NVH] ( in Vietnamese: Nguyễn Vũ Hưng )
vuhung16plus{remove}@gmail.dot.com , YIM: vuhung16 , Skype: vuhung16plus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice default UI font need to be changed
Hi *, On Sat, Feb 5, 2011 at 6:38 PM, Nguyen Vu Hung vuhung16p...@gmail.com wrote: On Sat, Feb 5, 2011 at 9:59 PM, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: [VCL.xcu / list of default fonts and fallback] When there are issues cross-locale, then raise them. It is not that the list didn't change since the beginning of the OOo project. If I understand the OP correctly, he wants LibO to 1. Handle different languages on different locales. This is already done. And because available fonts are different from OS (platform) to OS (platform), so Yes, that's why there isn't just one single font, but also a list of replacements. Not that another mechanism is fontconfig's font-fallback. 2. LibO should be able to have a right list of fonts to use for different OSes. Having a list, as the default configuration, of fonts in highest to lowest priority for different languages and locales is a good idea. So that's what is there now. And, IMHO, to do so, I think we should so let user to edit font priority list. This is already possible. Got to the Options, there is a font-replacement table. # Not hardcoded in VCL.xcu Please correct me if I am wrong. Well - you are wrong in the case that a) The fonts in VCL.xcu are just defaults and (sane) fallbacks for commonly used fonts. Exactly because the set of available fonts differ is the reason for existance of this file, and the differet sets of fallbacks. Both per-font fallbacks (font foo was requested, but it's not installed, what would be a good look-alike replacement), as well as prefer-lists (no specific font was requeste, let's see what to use as default). b) User interface font as the initial start of the thread (Andale Sans UI) is only used when not using the system font for UI display. Thus virtually no windows user, and no GNOME user will see it, KDE sometimes have crappy configuration so they just uncheck the option in LO/OOo instead of fixing their desktops font-settings), other linux users who don't use the major desktops are the only ones who are affected here, but as Andale Sans UI isn't available, it just tries the font that is next in the list. c) The other defaults (the ones for the document content (Headers, etc.) are easily reconfigured in the Options (Default fonts for documents), or can be set in a default document template d) Other replacements can be setup with the replacement table mentioned above. e) Changing VCL.xcu without giving thought into it will likely change appearance of documents when the fonts aren't available and now LO will choose a different font instead. That all being said: If there is an actual problem with one of the replacements for a given locale: Then of course it is possible to enhance/modify the list. Expecially for exotic locales with non-western writing systems the list might be lacking (in terms of glyph coverage, i.e. using a font that doesn't cover the necessary characters or similar). ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
I meant the repos in the bootstrap repo, of course, not the build repo. Am 31.01.2011 16:23, schrieb Norbert Thiebaud: I concur. my limited understanding of how submodule works lead me to believe that it would not be a nice fit with what we do 1/ it is more appropriate when the 'modules' have fairly independent life-cycle, which is not really our case. sure calc/writer/impress/base are fairly isolated from one another, but the coupling with libs-core/libs-gui/ure/... is pretty tight The submodules are independent in that they are seperate repositories and have their own commits, but as I understand it this is the case with LibreOffice already. On the other hand, a certain commit of each submodule is tied to every commit of the superproject. I don't know how this is done right now, maybe in the download script. Or do you get the most recent version of the subrepos no matter which version of the build repo you have checked out? I thought of git submodule when I saw the 'download' and 'g' scripts. I'm not sure what they are doing exactly, but 'make fetch' and 'download' seem to be similar to 'git submodule update --init' and 'g' seems to be similar to 'git submodule foreach'. Tobias ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build fails in i18npool
On Sat, Feb 05, 2011 at 04:00:39PM +, Caolán McNamara wrote: On Sat, 2011-02-05 at 08:43 +0100, Francois Tigeot wrote: I can't get the build to stop failing in i18npool. The only error message is Exception on createRegistryServiceFactory and I can't get any more details. Try a git pull in ure and try to build again. I think this should work again now. Thanks. I'm not sure if this was fixed by a git pull or some patching I did in other modules but this works now indeed. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] EasyHacks: Make existing tests work
Find attached changes to lib-gui/comphelper to get some tests working
again.
These patches are LGPLv3+/MPL.
This is my first contribution in this project - so don't hesitate with
critics if its not the common procedure.
From c1ae4fedb99ffa883f2aeac5fc0d26b9a496ec75 Mon Sep 17 00:00:00 2001
From: Wilhelm Pflueger wilhelm.pflue...@web.de
Date: Sat, 5 Feb 2011 22:56:20 +0100
Subject: [PATCH 1/2] Re-animated tests that were based on deprecated testshl.
---
comphelper/prj/build.lst |1 +
comphelper/qa/makefile.mk | 10 +++---
comphelper/qa/test_string.cxx | 22 --
comphelper/qa/test_weakbag.cxx | 10 ++
comphelper/qa/version.map |3 +--
5 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/comphelper/prj/build.lst b/comphelper/prj/build.lst
index a38f999..d5eced0 100644
--- a/comphelper/prj/build.lst
+++ b/comphelper/prj/build.lst
@@ -11,3 +11,4 @@ ph comphelper\source\comparenmake - all ph_compare ph_inc NULL
ph comphelper\source\officeinstdir nmake - all ph_officeinstdir ph_inc NULL
ph comphelper\source\xml nmake - all ph_xml NULL
ph comphelper\util nmake - all ph_util ph_container ph_evtatmgr ph_misc ph_procfact ph_property ph_streaming ph_compare ph_officeinstdir ph_xml NULL
+ph comphelper\qa nmake - all ph_complex NULL
\ No newline at end of file
diff --git a/comphelper/qa/makefile.mk b/comphelper/qa/makefile.mk
index 0360d30..9d68caa 100644
--- a/comphelper/qa/makefile.mk
+++ b/comphelper/qa/makefile.mk
@@ -40,8 +40,8 @@ DLLPRE = # no leading lib on .so files
INCPRE += $(MISC)$/$(TARGET)$/inc
SHL1TARGET = $(TARGET)_weakbag
-SHL1OBJS = $(SLO)$/test_weakbag.obj
-SHL1STDLIBS = $(CPPUHELPERLIB) $(CPPULIB) $(CPPUNITLIB) $(TESTSHL2LIB) $(SALLIB)
+SHL1OBJS = $(SLO)$/test_weakbag.obj $(SLO)$/test_string.obj
+SHL1STDLIBS = $(CPPUHELPERLIB) $(CPPULIB) $(CPPUNITLIB) $(TESTSHL2LIB) $(SALLIB) $(COMPHELPERLIB)
SHL1VERSIONMAP = version.map
SHL1IMPLIB = i$(SHL1TARGET)
DEF1NAME = $(SHL1TARGET)
@@ -49,8 +49,4 @@ DEF1NAME = $(SHL1TARGET)
SLOFILES = $(SHL1OBJS)
.INCLUDE: target.mk
-
-ALLTAR: test
-
-test .PHONY: $(SHL1TARGETN)
-$(TESTSHL2) $(SHL1TARGETN)
+.INCLUDE: _cppunit.mk
diff --git a/comphelper/qa/test_string.cxx b/comphelper/qa/test_string.cxx
index 7b997e6..3a631d9 100644
--- a/comphelper/qa/test_string.cxx
+++ b/comphelper/qa/test_string.cxx
@@ -2,7 +2,7 @@
/*
*
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- *
+ *
* Copyright 2000, 2010 Oracle and/or its affiliates.
*
* OpenOffice.org - a multi-platform office productivity suite
@@ -30,7 +30,9 @@
#include sal/config.h
#include comphelper/string.hxx
-#include testshl/simpleheader.hxx
+#include cppunit/TestFixture.h
+#include cppunit/extensions/HelperMacros.h
+#include cppunit/plugin/TestPlugIn.h
#include rtl/string.h
#include rtl/ustring.h
#include rtl/ustring.hxx
@@ -38,20 +40,20 @@
namespace {
-class Test: public CppUnit::TestFixture {
+class TestString: public CppUnit::TestFixture {
public:
void test();
-CPPUNIT_TEST_SUITE(Test);
+CPPUNIT_TEST_SUITE(TestString);
CPPUNIT_TEST(test);
CPPUNIT_TEST_SUITE_END();
};
-void Test::test() {
+void TestString::test() {
rtl::OUString s1(RTL_CONSTASCII_USTRINGPARAM(foobarbar));
sal_Int32 n1;
rtl::OUString s2(
-comphelper::string::searchAndReplace(
+comphelper::string::searchAndReplaceAsciiL(
s1, RTL_CONSTASCII_STRINGPARAM(bar),
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(baaz)), 0, n1));
CPPUNIT_ASSERT(
@@ -59,7 +61,7 @@ void Test::test() {
CPPUNIT_ASSERT(n1 == 3);
sal_Int32 n2;
rtl::OUString s3(
-comphelper::string::searchAndReplace(
+comphelper::string::searchAndReplaceAsciiL(
s2, RTL_CONSTASCII_STRINGPARAM(bar),
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(bz)),
n1 + RTL_CONSTASCII_LENGTH(baaz), n2));
@@ -68,7 +70,7 @@ void Test::test() {
CPPUNIT_ASSERT(n2 == 7);
sal_Int32 n3;
rtl::OUString s4(
-comphelper::string::searchAndReplace(
+comphelper::string::searchAndReplaceAsciiL(
s3, RTL_CONSTASCII_STRINGPARAM(bar),
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(baz)),
n2 + RTL_CONSTASCII_LENGTH(bz), n3));
@@ -76,10 +78,10 @@ void Test::test() {
CPPUNIT_ASSERT(n3 == -1);
}
-CPPUNIT_TEST_SUITE_NAMED_REGISTRATION(Test, alltests);
+CPPUNIT_TEST_SUITE_REGISTRATION(TestString);
}
-NOADDITIONAL;
+//NOADDITIONAL;
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/comphelper/qa/test_weakbag.cxx b/comphelper/qa/test_weakbag.cxx
index acb6e56..774260e 100644
--- a/comphelper/qa/test_weakbag.cxx
+++ b/comphelper/qa/test_weakbag.cxx
@@ -2,7 +2,7 @@
[Libreoffice] EasyHacks: Make existing tests work (ure/sal)
Attached please find some changes to make tests in ure/sal work.
One test fails and breaks the build though - if this is unwanted you may
revert the change to ure/sal/prj/build.lst. (This is not exactly what is
intended by tests - i mean to switch it off if it fails, but in the
Moment I don't know how to repair the failing method so that it works as
intended by the test.)
This is LGPLv3+/MPL.
So long.
From c2ea7912df3e7fd2e05b5babe7533f7413f77596 Mon Sep 17 00:00:00 2001
From: Wilhelm Pflueger wilhelm.pflue...@web.de
Date: Sat, 5 Feb 2011 22:31:57 +0100
Subject: [PATCH 1/2] Re-animated tests that were based on testshl.
One test in test_outstring_convert.cxx fails for method
rtl::OUString::convertToString().
---
sal/prj/build.lst |1 +
sal/qa/rtl/strings/test_oustring_compare.cxx |6 --
sal/qa/rtl/strings/test_oustring_convert.cxx |5 +++--
sal/qa/rtl/strings/test_oustring_endswith.cxx |5 +++--
sal/qa/rtl/strings/test_oustring_noadditional.cxx |4 ++--
sal/qa/rtl/strings/test_oustringbuffer_utf32.cxx | 15 +--
6 files changed, 22 insertions(+), 14 deletions(-)
diff --git a/sal/prj/build.lst b/sal/prj/build.lst
index cafca8a..02c1a44 100644
--- a/sal/prj/build.lst
+++ b/sal/prj/build.lst
@@ -18,3 +18,4 @@ sa sal\qa\ByteSequence nmake - all sa_qa_ByteSequence sa_cppunittester sa_util N
sa sal\qa\OStringBuffer nmake - all sa_qa_OStringBuffer sa_cppunittester sa_util NULL
sa sal\qa\osl\mutex nmake - all sa_qa_osl_mutex sa_cppunittester sa_util NULL
sa sal\qa\osl\profile nmake - all sa_qa_osl_profile sa_cppunittester sa_util NULL
+sa sal\qa\rtl\strings nmake - all sa_qa_rt_strings sa_cppunittester sa_util NULL
diff --git a/sal/qa/rtl/strings/test_oustring_compare.cxx b/sal/qa/rtl/strings/test_oustring_compare.cxx
index a274514..bb28cf4 100644
--- a/sal/qa/rtl/strings/test_oustring_compare.cxx
+++ b/sal/qa/rtl/strings/test_oustring_compare.cxx
@@ -29,7 +29,9 @@
// MARKER(update_precomp.py): autogen include statement, do not remove
#include precompiled_sal.hxx
-#include testshl/simpleheader.hxx
+#include cppunit/TestFixture.h
+#include cppunit/extensions/HelperMacros.h
+//#include cppunit/plugin/TestPlugIn.h
#include rtl/string.h
#include rtl/ustring.hxx
@@ -47,7 +49,7 @@ private:
} }
-CPPUNIT_TEST_SUITE_NAMED_REGISTRATION(test::oustring::Compare, alltest);
+CPPUNIT_TEST_SUITE_REGISTRATION(test::oustring::Compare);
void test::oustring::Compare::equalsIgnoreAsciiCaseAscii()
{
diff --git a/sal/qa/rtl/strings/test_oustring_convert.cxx b/sal/qa/rtl/strings/test_oustring_convert.cxx
index c0705e2..f675390 100644
--- a/sal/qa/rtl/strings/test_oustring_convert.cxx
+++ b/sal/qa/rtl/strings/test_oustring_convert.cxx
@@ -29,7 +29,8 @@
// MARKER(update_precomp.py): autogen include statement, do not remove
#include precompiled_sal.hxx
-#include testshl/simpleheader.hxx
+#include cppunit/TestFixture.h
+#include cppunit/extensions/HelperMacros.h
#include rtl/strbuf.hxx
#include rtl/string.hxx
#include rtl/ustring.hxx
@@ -49,7 +50,7 @@ private:
} }
-CPPUNIT_TEST_SUITE_NAMED_REGISTRATION(test::oustring::Convert, alltest);
+CPPUNIT_TEST_SUITE_REGISTRATION(test::oustring::Convert);
namespace {
diff --git a/sal/qa/rtl/strings/test_oustring_endswith.cxx b/sal/qa/rtl/strings/test_oustring_endswith.cxx
index 4f2ae1f..d2a41d2 100644
--- a/sal/qa/rtl/strings/test_oustring_endswith.cxx
+++ b/sal/qa/rtl/strings/test_oustring_endswith.cxx
@@ -29,7 +29,8 @@
// MARKER(update_precomp.py): autogen include statement, do not remove
#include precompiled_sal.hxx
-#include testshl/simpleheader.hxx
+#include cppunit/TestFixture.h
+#include cppunit/extensions/HelperMacros.h
#include rtl/strbuf.hxx
#include rtl/string.h
#include rtl/string.hxx
@@ -52,7 +53,7 @@ private:
} }
-CPPUNIT_TEST_SUITE_NAMED_REGISTRATION(test::oustring::EndsWith, alltest);
+CPPUNIT_TEST_SUITE_REGISTRATION(test::oustring::EndsWith);
namespace {
diff --git a/sal/qa/rtl/strings/test_oustring_noadditional.cxx b/sal/qa/rtl/strings/test_oustring_noadditional.cxx
index 679b581..d5a1de5 100644
--- a/sal/qa/rtl/strings/test_oustring_noadditional.cxx
+++ b/sal/qa/rtl/strings/test_oustring_noadditional.cxx
@@ -29,8 +29,8 @@
// MARKER(update_precomp.py): autogen include statement, do not remove
#include precompiled_sal.hxx
-#include testshl/simpleheader.hxx
+#include cppunit/plugin/TestPlugIn.h
-NOADDITIONAL;
+CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sal/qa/rtl/strings/test_oustringbuffer_utf32.cxx b/sal/qa/rtl/strings/test_oustringbuffer_utf32.cxx
index 172dda4..5f28954 100644
--- a/sal/qa/rtl/strings/test_oustringbuffer_utf32.cxx
+++ b/sal/qa/rtl/strings/test_oustringbuffer_utf32.cxx
@@ -29,7 +29,10 @@
// MARKER(update_precomp.py): autogen include statement, do not remove
#include precompiled_sal.hxx
-#include testshl/simpleheader.hxx
+#include cppunit/TestFixture.h
+#include
Re: [Libreoffice] Build fails in i18npool
On Sat, Feb 05, 2011 at 08:52:19PM +0100, Francois Tigeot wrote: On Sat, Feb 05, 2011 at 04:00:39PM +, Caolán McNamara wrote: On Sat, 2011-02-05 at 08:43 +0100, Francois Tigeot wrote: I can't get the build to stop failing in i18npool. The only error message is Exception on createRegistryServiceFactory and I can't get any more details. Try a git pull in ure and try to build again. I think this should work again now. Thanks. I'm not sure if this was fixed by a git pull or some patching I did in other modules but this works now indeed. ... and it's back with a vengeance The cause of the createRegistryServiceFactory exception is that the file localedata_en_AU.rdb doesn't exist. It seems this error is very common; I've found many references to build failures in i18npool with the createRegistryServiceFactory message. It appears on both LibreOffice and OpenOffice on all sort of platforms. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] remove old icon themes ...
Hi Andreas, On Sat, 2011-02-05 at 12:58 +0100, Andreas Proschofsky wrote: Just to chime in here: Setting --with-theme does nothing for me, LO builds all icon sets, no matter what I ask it to... Right ;-) they should all be built, and delivered into the solver, but only the ones you specify should be bundled, and end up in setup_osl.ins; cf. the: SCPDEFS+=-DTHEME_TANGO etc. stuff, and #ifdef THEME_TANGO etc. in the scp2, eg. scp2/source/ooo/file_ooo.scp. HTH :-) Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] win32 build errors in svtools modules
On 5 February 2011 21:46, Steven Butler sebut...@gmail.com wrote: I am stuck on the following error when trying to build svtools. My previous issue with saxparser and climaker seems to have disappeared after uninstalling VS2010 C# Express and pulling in latest git. _STL::listclass Link,class _STL::allocatorclass Link ::push_back(class Link const ) Replacing the use of std::list in htmlcfg.cxx with std::vector resolved the multiply defined symbol error. I have no idea why this should help as I would have thought using the same template instantiation in two different files would not cause an issue but apparently it does for MSVC2008. At least for me. I will see how much further into the build I can get now svtools is building. Regards Steve ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Does OO/LO have an API?
Hullo List, Is there an API for working with LO programmatically? Rather than create an ODF with the myriad of tools available, I'm looking to directly invoke a LO object within a script. I'm aware of the UNO bridge, but that requires a running instance of LO and connection to it as an external service. What I'm looking for is a way to create and manipulate a document -- with LO routines -- without incurring unnecessary overhead. Perhaps as a library. For the sake of argument, here might be an example Python script: - import libreoffice as LO textdoc = LO.createTextDocument() textdoc.properties.Title = My API Created Document textdoc.cursor = 0 # move cursor to document head textdoc.insertText( A sample line. ) textdoc.saveAs( /path/to/a/file.odt ) - After about 20 minutes of Googling, and random grepping through the code base, I'm having no luck. Does such a beast exist? Thanks, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
