[Libreoffice] [Bug 34404] LibreOffice 3.3.2 release blockers / stoppers
https://bugs.freedesktop.org/show_bug.cgi?id=34404 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Platform|Other |All CC||LibreOffice@bielefeldundbus ||s.de Depends on||34187, 34184 --- Comment #14 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-03-11 00:07:25 PST --- To be honest, I use LibO because of my idealism, but it's still not an office suite that can fulfill my needs. For that I still need OOo 3.1.1, for example because of unfixed Bug 34093 Bug 34187 - MAILMEGE E-Mail does not send mails Bug 34184 - [Task]: Make E-mail MAILMEGE usable -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHING] translate german comments in /sc/inc
Patch 4 only removes structuring //--- lines. I'm not sure if this is wanted. Maybe someone of the experts can comment on this? I would say yes, definitely. Vertical space is a non-renewable resource, as I think Michael so nicely put it. Such comments have no value if used between more or less all methods in a source file. Removing them should be done exactly as you say, in a diff / patch by itself that does nothing else, so that it is trivial to confirm that it indeed does nothing else. They have value if they (or similar comments) if given some semantic meaning, for instance if used to indicate parts of a source file that are differently licensed, cop-pasted from some other source, or something like that. Of course, in such a case only if accompanied by a textual explanation. Like // - From here to the next // - the code is copied from libfoo version 4.2 which is licensed under a MIT/X11 license. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Additional translations of German comments in libs-core/sfx2/source/bastyp, control, dialog
Hi, On Fri, Mar 11, 2011 at 09:45, Muthu Subramanian K sumu...@novell.com wrote: Hi Albert, oh...Will have a look at those patches too... I assumed those were the ones you resent...Will get back to you in a while. If you do manage to have a look on my other patches, please for now ignore the first concerning libs-core/editeng. Applying the patch will lead to merge conflicts. I will resolve this in my local repo and resend this patch. Would you also want to look at some simple hacks? features? Since you seem to be comfortable with C++? Yes, that is my plan. :) /Albert Thanks! Muthu Subramanian On 03/11/2011 02:12 AM, Albert Thuswaldner wrote: Hi Muthu, Thanks for pushing my patches! It is always nice to see them go in. On Thu, Mar 10, 2011 at 18:38, Muthu Subramanian K sumu...@novell.com wrote: Hi Albert, I have pushed after correcting a few typos - hope I have caught the important ones and most of the others. Sorry for the typos, I try to review my patches before sending them but some things you just don't see for some reason... If possible (in the future), please do compile and check the code before submitting the patch - I found some stray characters. Yeah, compiling the code was he plan from the beginning, haven't manage to do this yet, though. Thanks again for the (huge) patch...please do continue the good work. There are more patches of mine further up the list. If someone has the time to take care of them, please do. [Libreoffice] [PATCH] Additional translations of German comments in libs-core/editeng Albert Thuswaldner [Libreoffice] [PATCH] Additional translations of German comments in libs-core/editeng Albert Thuswaldner [Libreoffice] [PATCH] Additional translations of German comments in libs-core/sfx2/inc Albert Thuswaldner [Libreoffice] [PATCH] Additional translations of German comments in libs-core/sfx2/sdi Albert Thuswaldner [Libreoffice] [PATCH] Additional translations of German comments in libs-core/sfx2/source/appl Albert Thuswaldner [Libreoffice] [PATCH] Additional translations of German comments in libs-core/sfx2/source/appl Albert Thuswaldner I'm now a member of the mailing list. Please let me know if there are problems applying my patches (merge conflicts and so on) . I can always help out, fixing the patches and re-sending them. To make things as smooth as possible for you poor guys/gals having to push them. ;) Cheers /Albert @Martin: If possible, could you please help in re-reviewing this set? - would help us a lot - since the patch is big, there is a lot of probability that I might have missed some things. Thank you! - Muthu Subramanian On 03/10/2011 05:23 PM, Muthu Subramanian K wrote: Thank you for resending. I am reviewing them...I will push them in a while. Yes, translating the debug messages, DBG_ASSERTS would also be really helpful. On 03/08/2011 05:30 AM, Martin Kepplinger wrote: Am 08.03.2011 00:23, schrieb Albert Thuswaldner: Hi Here are last ones that did not get pushed to master. You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+ triple license. /Albert Hi Albert, Thanks for that work! These patches don't just translate german comments though. They translate debug-messages, delete comments, translate of course, fix typos and coding style issues. When nobody is faster, I could maybe look at them this week. But I'd need just another opinion on also translating DBG_ASSERT and such in one go, before I could push them. Sorry, I'm just not experienced enough here. thanks! martin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Additional translations of German comments in libs-core/editeng
Please ignore this patch for now, same-line changes have been made in master since I sent this patch. I will merge it in my local repo and resend the patch. /Albert On Sun, Mar 6, 2011 at 20:51, Albert Thuswaldner albert.thuswald...@gmail.com wrote: And now the actual patch /Albert On Sun, Mar 6, 2011 at 20:49, Albert Thuswaldner albert.thuswald...@gmail.com wrote: Hi, While tidying up my local repo I discovered some changes that did not get properly pushed to master. It is all my fault, my patch back then was humungous. You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+ triple license. /Albert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Calc Standard Filter behaviour
On Fri, Mar 11, 2011 at 2:48 AM, Kohei Yoshida kyosh...@novell.com wrote: But before I commit your patches, we'd like to confirm that you are submitting your patches under LGPLv3+/MPL dual licenses. I knew I'd forget something crucial - both are submitted under LGPLv3+/MPL. So, I'll retract my suggestion. I'm convinced that the best solution here is not to have auto completion. Sometimes less is more. :-) Haha, agreed. Thank you for your advice and patience. Tibby ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEWED] impress tasks pane fix (fdo#34718) - 3.3.2 blocker
On Thu, 2011-03-10 at 15:58 +0100, Radek Doulík wrote: http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=1f4078d8be0755ea33ec36edacdf805e1ce24270 Looks good to me too. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-design] General relationship between coders and designers (was: [PUSHED]fdo#31251...)
Hi Bernhard, On Wed, 2011-03-09 at 22:11 +0100, Bernhard Dippold wrote: At first I want to thank Sébastien not only for his work, but also for being open to the discussion here, even if this means to delay the final inclusion of his patch. Agreed - we all think Sebastien rocks ;-) That we can agree on first, and this debate is not in fact about him - he acted in an exemplary manner (so I dropped the CC). Firstly, I of course want to apologise that my mail made you mad - clearly I was trying to redress an imbalance I was concerned might exist, and over-emphasised one side to try to help re-balance things. Unfortunately, that tipped the balance completely the other way - which I can understand (in retrospect) sounds upsetting, sorry. Having said that, I do think there might be some difference of understanding here, so lets dive into more detail. Also, apologies for not reading the mail - I spent yesterday heads down, doing many hours of tedious, mostly mindless merging work - the kind of stuff that makes programmers feel like donkeys involving no interesting, creative decisions at all ;-) It is an intricate, painful, mind-blowingly tedious task - but someone has to do it :-) Anyhow ... If Michael (as one of the most relevant developer in our community) is right with attitude against non-coding contributors I hope I'm not against anything, particularly not designer developers :-) I am -for- encouraging coders to get their code into the product, and for designers to get their ideas realised *and* simultaneously to create a fun place for everyone to work together, with good relationships. Of course that seems to have gone wrong here, and needs fixing :-) and if this is the official position of the LibreOffice project So - of course, my view is not an official position. Having said that, it is perhaps worth discussing. In the sphere of design, I see the design team as having a whole spectum of responsibility. At one end - one similar to the coder's and at the other a critical advisory and leadership role. So - starting at the coder-like end: * hard ownership role: + I expect the design team to own all of the artwork, icon themes, etc. in the product. + if I go adding garish / new icons to a theme, I expect to get beaten up by you guys - this is yours, all yours :-) * middler-ground role + defaults / dialog layout etc. + clearly this is fuzzier: dialog layout is (currently) dependent on l10n, so some things can't be done: we can't wedge 10x buttons into a small space ;-) + defaults can have a huge impact on performance, maintenance, complexity and code flow + changes to dialog layout behaviour require coding support - which -must- be -persuaded- not dictated * weak ownership + lets re-architect the whole user interface + the weakness here is mostly one of coding resource, and impact on architecture + it is simply not possible or practicle to dictate terms to other teams + rejecting inclusion of working improvements + this has an incredibly negative impact on the growth and fun of the coding community. ie. Sebastian's work was merged before getting UI review, this I expect to continue. So - I suspect the arguments here are around the 'middle' and 'weak' categories, what belongs where and what happens in what order etc. Personally, I don't have a defined view of how that works. In everything that I'm involved in I prefer informal, relational process. This means that power such as a veto power and the like simply don't exist :-) If designers feel -extremely- strongly that something shouldn't go in - I'd want to listen very carefully since you contribute so much; but if the relevant developer feels similarly strongly, then we'd have a problem and need to dig more (and so it goes on). I don't think hard and fast rules capture the real world in an incredibly helpful way in these situations. When coders are allowed and encouraged to do their changes regardless of the voting of the relevant experts in areas their code contribution touches, we come back to a two-class community I don't think there is a two-class community, I think there are tons of people with different domain expertise - and that we should listen carefully to each of them and come up with a balanced solution that pleases as many people as possible: l10n, coders, designers, etc. I also don't believe that all developers by definition have no design sense and insight :-) I -do-not- see the design team having an ultimate say in this world, where their word is law, and their
[Libreoffice] minutes of tech steering call ... (Tuesday)
Attending: + Norbert, Andras, Thorsten, Caolan, Kendy, Bjoern, Petr, Rene * Previous Action items: + writer useless in Japan bug(s) + fixed as well as possible for now + magic fallback / Windows font needs some love + lots of obscure character range oddness import is ok, and export should look the same. Needs ODF ext'n for overriding char direction. + regressions nailed in 3.3.2 + Norbert has shared his up-load script + next step binary uploads, coming soon (Kendy) + 9 tinderboxes + 4x Windows, 2x Mac, rest Linux + +3 new windows tinderboxes in last week. + Fridrich working up-load piece + chase new Evolution addressbook bug (Michael) AA: + no action yet; get off backside (Michael) * 3.3.1 retrospective + wrong + a few icons missed here / there, nothing critical + a couple of days of slippage inherited from a late RC1 + right + no very obvious regressions added * 3.3.2 status + again lots of patches for review just before freeze deadline AA: + send a reminder a week beforehand (Petr) + download page javascript generated from php AA: needs tweaking - need to play with test site (Thorsten) + volunteers to improve this appreciated. + two nominated blockers: + random, non-producible Mac issue, Java + ReportBuilder related * aligning Debian / Ubuntu spec. (Bjoern / Rene) + shared git repo for packaging + things are getting better, much less divergence * python foo for debugging from dmalcolm (Caolan) + integration in gdb prototype here: https://bugs.freedesktop.org/show_bug.cgi?id=34745 + potential to make gdb finally usable ... * merge status / update (Michael / Kendy) + char-set related mis-importing of mercurial made things much worse than they could be + now fixed + consider resetting the merge, move to m101 + do a one-pass re-merge + kendy to push to repository tonight and re-verifying import quality AA: + post a dependency graph of split modules (Petr) + Web office review (Michael) + better integration with open-source CMS / DMS is good + HTML5 / VCL target star-portal like backend is good + scalability will be exciting + existing web solutions are featureless so, scalability a good problem to have. + UI issues are fun + should be a great party trick. + GSOC slots / resource requests etc. * Cebit AA: + fantastic conference - blog to follow (Thorsten) * starting to consider formalizing the ESC + ~11 people suggested ? + Rene, Caolan / David, Bjorn, Norbert, Thorsten, Myself, Andras ... +3 ... + Great pool of others guys to consider at minimum Rainer (QA), Design guy (?) Takashi Abe, Sebastian, Thomas Arnhold, Christina ... + v. flexible composition preferred with non-members routinely invited for calls etc. * for next time: + Bjoern's: after action acclimatisation report / thoughts -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Additional translations of German comments in libs-core/sfx2/source/bastyp, control, dialog
Hi, I have pushed all of your sfx2 changes except for sfx2-inc patch. It has merge conflict changes - it would be great if you could fix and resend it? Please do let me know if I have missed any other patch. Thank you! Muthu Subramanian On 03/11/2011 02:49 PM, Albert Thuswaldner wrote: Hi, On Fri, Mar 11, 2011 at 09:45, Muthu Subramanian K sumu...@novell.com wrote: Hi Albert, oh...Will have a look at those patches too... I assumed those were the ones you resent...Will get back to you in a while. If you do manage to have a look on my other patches, please for now ignore the first concerning libs-core/editeng. Applying the patch will lead to merge conflicts. I will resolve this in my local repo and resend this patch. Would you also want to look at some simple hacks? features? Since you seem to be comfortable with C++? Yes, that is my plan. :) /Albert Thanks! Muthu Subramanian On 03/11/2011 02:12 AM, Albert Thuswaldner wrote: Hi Muthu, Thanks for pushing my patches! It is always nice to see them go in. On Thu, Mar 10, 2011 at 18:38, Muthu Subramanian K sumu...@novell.com wrote: Hi Albert, I have pushed after correcting a few typos - hope I have caught the important ones and most of the others. Sorry for the typos, I try to review my patches before sending them but some things you just don't see for some reason... If possible (in the future), please do compile and check the code before submitting the patch - I found some stray characters. Yeah, compiling the code was he plan from the beginning, haven't manage to do this yet, though. Thanks again for the (huge) patch...please do continue the good work. There are more patches of mine further up the list. If someone has the time to take care of them, please do. [Libreoffice] [PATCH] Additional translations of German comments in libs-core/editeng Albert Thuswaldner [Libreoffice] [PATCH] Additional translations of German comments in libs-core/editeng Albert Thuswaldner [Libreoffice] [PATCH] Additional translations of German comments in libs-core/sfx2/inc Albert Thuswaldner [Libreoffice] [PATCH] Additional translations of German comments in libs-core/sfx2/sdi Albert Thuswaldner [Libreoffice] [PATCH] Additional translations of German comments in libs-core/sfx2/source/appl Albert Thuswaldner [Libreoffice] [PATCH] Additional translations of German comments in libs-core/sfx2/source/appl Albert Thuswaldner I'm now a member of the mailing list. Please let me know if there are problems applying my patches (merge conflicts and so on) . I can always help out, fixing the patches and re-sending them. To make things as smooth as possible for you poor guys/gals having to push them. ;) Cheers /Albert @Martin: If possible, could you please help in re-reviewing this set? - would help us a lot - since the patch is big, there is a lot of probability that I might have missed some things. Thank you! - Muthu Subramanian On 03/10/2011 05:23 PM, Muthu Subramanian K wrote: Thank you for resending. I am reviewing them...I will push them in a while. Yes, translating the debug messages, DBG_ASSERTS would also be really helpful. On 03/08/2011 05:30 AM, Martin Kepplinger wrote: Am 08.03.2011 00:23, schrieb Albert Thuswaldner: Hi Here are last ones that did not get pushed to master. You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+ triple license. /Albert Hi Albert, Thanks for that work! These patches don't just translate german comments though. They translate debug-messages, delete comments, translate of course, fix typos and coding style issues. When nobody is faster, I could maybe look at them this week. But I'd need just another opinion on also translating DBG_ASSERT and such in one go, before I could push them. Sorry, I'm just not experienced enough here. thanks! martin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Support for greek numbering style for bullets
Hi!
This is a patch originally developed against openoffice in summer 2009
that has not yet been accepted due to, in my opinion, purely bureocratic
reasons / lack of interest from main devs
(see http://openoffice.org/bugzilla/show_bug.cgi?id=91143 and particularly
the dates of comments) although it is something that the Greek community
wants.
I 'm hoping that Libre Office will be more friendly and if not merge
at least review :)
Cheers,
Pantelis
From d026447658aec554d922d284926e20e049024c68 Mon Sep 17 00:00:00 2001
From: Pantelis Koukousoulas pkt...@gmail.com
Date: Sat, 11 Jul 2009 07:45:21 +0300
Subject: [PATCH] Support for greek numerals
References:
http://www.spinellis.gr/blog/20090625/ (Greek Numerals in OpenOffice.org)
http://user.services.openoffice.org/en/forum/viewtopic.php?f=7t=7269
([Issue+Workaround] Custom Numbering in Bullets and Numbering)
http://www.opengr.net/forum/viewtopic.php?f=13t=51
And the references transitively mentioned in the above.
This functionality was implemented during Greek Coding Camp 2009.
NOTE: the present implementation uses the (modern) two-letter version of '6'
(sigma taf) instead of the ancient greek / katharevousa version that uses
the 'stigma' character.
OTOH, we do use the katharevousa 'qoppa' and 'sampi' because there is no
standard modern version that replaces them. If you have that many bullets
so that these symbols are needed, then you had it comin' anyway :p
Author: Pantelis Koukousoulas pkt...@gmail.com
License: LGPLv3 / MPL
Signed-off-by: Pantelis Koukousoulas pkt...@gmail.com
---
.../defaultnumberingprovider.cxx | 106
offapi/com/sun/star/style/NumberingType.idl | 14 +++
clone/components/cui/source/tabpages/numpages.src|3 +-
clone/writer/sw/source/ui/misc/numberingtypelistbox.src | 26 +++--
4 files changed, 136 insertions(+), 13 deletions(-)
Index: libo/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
===
--- libo.orig/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx 2011-03-08 19:42:55.0 +
+++ libo/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx 2011-03-10 12:24:58.0 +
@@ -44,6 +44,13 @@
#define S_CYR_A \xD0\xB0
#define S_CYR_B \xD0\xB1
+//Greek upper case
+#define C_GR_A \xCE\x91
+#define C_GR_B \xCE\x92
+//Greek lower case
+#define S_GR_A \xCE\xB1
+#define S_GR_B \xCE\xB2
+
#include math.h
#include sal/macros.h
#include rtl/ustring.hxx
@@ -170,6 +177,18 @@
0x0444, 0x0445, 0x0446, 0x0447, 0x045F, 0x0448
};
+static sal_Unicode table_GreekUpperLetter[] = {
+0x0391, 0x0392, 0x0393, 0x0394, 0x0395, 0x03DB, 0x0396, 0x0397, 0x0398,
+0x0399, 0x039A, 0x039B, 0x039C, 0x039D, 0x039E, 0x039F, 0x03A0, 0x03DF,
+0x03A1, 0x03A3, 0x03A4, 0x03A5, 0x03A6, 0x03A7, 0x03A8, 0x03A9, 0x03E0
+};
+
+static sal_Unicode table_GreekLowerLetter[] = {
+0x03B1, 0x03B2, 0x03B3, 0x03B4, 0x03B5, 0x03DB, 0x03B6, 0x03B7, 0x03B8,
+0x03B9, 0x03BA, 0x03BB, 0x03BC, 0x03BD, 0x03BE, 0x03BF, 0x03C0, 0x03DF,
+0x03C1, 0x03C3, 0x03C4, 0x03C5, 0x03C6, 0x03C7, 0x03C8, 0x03C9, 0x03E1
+};
+
static sal_Unicode table_Alphabet_fa[] = {
0x0622, 0x0628, 0x067E, 0x062A, 0x062B, 0x062C, 0x0686, 0x062D,
0x062E, 0x062F, 0x0630, 0x0631, 0x0632, 0x0698, 0x0633, 0x0634,
@@ -314,6 +333,82 @@
s += OUString::valueOf( table_small[ n%tableSize ] );
}
+// Greek Letter Numbering
+
+// KERAIA separates numerals from other text
+#define STIGMA(sal_Unicode) 0x03DB
+#define LEFT_KERAIA (sal_Unicode) 0x0375
+#define MYRIAD_SYM(sal_Unicode) 0x039C
+#define DOT_SYM (sal_Unicode) 0x002E
+#define SIGMA_OFFSET 19
+#define TAU_OFFSET20
+#define MYRIAD1
+
+/*
+* Return the 1-99 number's representation in the Greek numbering system.
+* Adding a left keraia to represent numbers in the range 1 ... 99 is
+* not orthodox, so it's better to use the myriad notation and call this method
+* only for numbers up to .
+*/
+static
+OUStringBuffer gr_smallNum(sal_Unicode table[], int n)
+{
+if (n )
+throw IllegalArgumentException();
+
+int i = 0;
+OUStringBuffer sb;
+for (int v = n; v 0; v /= 10, i++) {
+int digit = v % 10;
+if (digit == 0)
+continue;
+
+sal_Unicode sign = table[(digit - 1) + 9 * (i % 3)];
+if (sign == STIGMA) {
+sb.insert(0, table[TAU_OFFSET]);
+sb.insert(0, table[SIGMA_OFFSET]);
+} else {
+sb.insert(0, sign);
+}
+
+if (i 2)
+sb.insert(0, LEFT_KERAIA);
+}
+
+return sb;
+}
+
+static
+void lcl_formatCharsGR( sal_Unicode table[], int n, OUString s )
+{
+OUStringBuffer sb;
+int myriadPower = 2;
+
+for (int divisor = MYRIAD * MYRIAD; divisor 1; divisor /= MYRIAD, myriadPower--) {
+if (n divisor - 1)
Re: [Libreoffice] [PATCH] Support for greek numbering style for bullets
On Fri, Mar 11, 2011 at 2:37 PM, Pantelis Koukousoulas pkt...@gmail.com wrote: Hi! This is a patch originally developed against openoffice in summer 2009 that has not yet been accepted due to, in my opinion, purely bureocratic reasons / lack of interest from main devs (see http://openoffice.org/bugzilla/show_bug.cgi?id=91143 and particularly the dates of comments) although it is something that the Greek community wants. I 'm hoping that Libre Office will be more friendly and if not merge at least review :) Hi Pantelis, I tried recently to apply the original patch to LibreOffice, and did not apply cleanly. After several attempts, I managed to get it to apply, but I got some issues with the numbering, which I describe at http://openoffice.org/bugzilla/show_bug.cgi?id=91143#c19 (comment #19). Therefore, can you verify that the issue I got at http://openoffice.org/bugzilla/show_bug.cgi?id=91143#c19 is not exhibited anymore? The Greek mailing lists are active, available at http://wiki.documentfoundation.org/Local_Mailing_Lists#Greek We mentioned the Greek bullet points issue at http://listarchives.libreoffice.org/el/discuss/msg00018.html Thanks for taking up this issue and doing all the work. Simos http://simos.info/blog/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Support for greek numbering style for bullets
On Fri, Mar 11, 2011 at 3:05 PM, Simos Xenitellis simos.li...@googlemail.com wrote: Hi Pantelis, I tried recently to apply the original patch to LibreOffice, and did not apply cleanly. Hi, the issue is just that some files have changed paths. This version of the patch should apply to current git. I can also provide a patch against the ubuntu packages if you want to test (paths are slightly different there as well). After several attempts, I managed to get it to apply, but I got some issues with the numbering, which I describe at http://openoffice.org/bugzilla/show_bug.cgi?id=91143#c19 (comment #19). Therefore, can you verify that the issue I got at http://openoffice.org/bugzilla/show_bug.cgi?id=91143#c19 is not exhibited anymore? I see this problem with english numbering just as well. I think it has to do with a tabstop being inserted after the letter. You can select that the bullet numbers are right justified from Format Settings and that space instead of tab is used after the numbers and this fixes the issue I think. My code just selects the appropriate greek letter(s) for each number. I could use the ancient greek / katharevousa symbol for '6' instead of 'sigma' 'taf' and that would make it a single letter, but I think most people would prefer the modern version. The Greek mailing lists are active, available at http://wiki.documentfoundation.org/Local_Mailing_Lists#Greek We mentioned the Greek bullet points issue at http://listarchives.libreoffice.org/el/discuss/msg00018.html I didn't know this, thanks for mentioning the issue there as well :) Thanks for taking up this issue and doing all the work. Thanks for your testing and support :) Let's hope that getting code into Libre Office will be less trouble than with oo.org. Cheers, Pantelis ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fonts trouble in Math formulas
Hi ! I get problem when type/edit formulas in LO. Trouble in all version LO up to currently (3.3.2rc1). I use Debian. In OOo all Ok. Screenshot: http://radikal.ru/F/s46.radikal.ru/i111/1103/c3/7f1ecca20835.png.html Some top-placed symbols (vector, widevec, widehat...) displayed as squares, some visual incorrect: toward, ... Good Luck, Alexander. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Calc Standard Filter behaviour
On Fri, 2011-03-11 at 09:35 +, Tibby Lickle wrote: On Fri, Mar 11, 2011 at 2:48 AM, Kohei Yoshida kyosh...@novell.com wrote: But before I commit your patches, we'd like to confirm that you are submitting your patches under LGPLv3+/MPL dual licenses. I knew I'd forget something crucial - both are submitted under LGPLv3 +/MPL. Excellent! Just pushed to master. One minor point. We normally prefer that your fully name be used in each commit, to keep the record keeping easier. I would be great if you could adjust your git setting so that your full name be used in your commits. Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fonts trouble in Math formulas
On Fri, 2011-03-11 at 18:07 +0300, Alexander wrote: Hi ! I get problem when type/edit formulas in LO. Trouble in all version LO up to currently (3.3.2rc1). I use Debian. In OOo all Ok. And what version of OOo ?, this might simply be having an older opensymbol font installed somewhere that the new LibreOffice (or OpenOffice.org 3.3.0 as well) is finding first instead of the new version of opensymbol. And then expects to have symbols that didn't exist in the old version of the font. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Calc Standard Filter behaviour
On Fri, 2011-03-11 at 10:01 -0500, Kohei Yoshida wrote: On Fri, 2011-03-11 at 09:35 +, Tibby Lickle wrote: On Fri, Mar 11, 2011 at 2:48 AM, Kohei Yoshida kyosh...@novell.com wrote: But before I commit your patches, we'd like to confirm that you are submitting your patches under LGPLv3+/MPL dual licenses. I knew I'd forget something crucial - both are submitted under LGPLv3 +/MPL. Excellent! Just pushed to master. One minor point. We normally prefer that your fully name be used in each commit, to keep the record keeping easier. I would be great if you could adjust your git setting so that your full name be used in your commits. Thanks! I've signed off on this for the libreoffice-3.3 branch also, for the 3.3.3 release. If anyone agrees that this fix is worth going into 3.3.2, please give us two more sign off's. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Daily Build broken on Mac
c5ac0683e2930ac51b59affbaf35d0c1b73a1dc8 is the first bad commit commit c5ac0683e2930ac51b59affbaf35d0c1b73a1dc8 Author: Martin Hosken martin_hos...@sil.org Date: Fri Mar 4 19:55:17 2011 +0700 Upgrade to ICU 4.6 :04 04 acdefc5204f7c0049aef9442c773f74efc9d4b2d d6f35f4c4779fba378cb36a101925f75c3859909 M icu the latest failed build.log can be found at http://dev-builds.libreoffice.org/daily/MacOS/master/2011-03-11-09.00.57/ Looks like a icu4c-aix.patch, unsurprisingly ;-), does not apply anymore Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Daily Build broken on Mac
On Fri, 2011-03-11 at 09:46 -0600, Norbert Thiebaud wrote: Looks like a icu4c-aix.patch, unsurprisingly ;-), does not apply anymore I think I fixed that patch earlier. Though there seems to be another problem on mac as well. We also however a tricky windows problem, we munge the .vcproj files in icu into something buildable with nmake. However in icu 4.6 those are replaced with .vcxproj files, and the format is different, so the custom .mak file generator doesn't work with them. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Daily Build broken on Mac
On Fri, Mar 11, 2011 at 9:55 AM, Caolán McNamara caol...@redhat.com wrote: On Fri, 2011-03-11 at 09:46 -0600, Norbert Thiebaud wrote: Looks like a icu4c-aix.patch, unsurprisingly ;-), does not apply anymore I think I fixed that patch earlier. Though there seems to be another problem on mac as well. The build was based on libs-external-sys:41ce3af3c09055cc5512bb6ed34e914f14991028 so I did not have your patches.. I manually re-pulled and built icu. this seeems to work now Thanks. Norbert We also however a tricky windows problem, we munge the .vcproj files in icu into something buildable with nmake. However in icu 4.6 those are replaced with .vcxproj files, and the format is different, so the custom .mak file generator doesn't work with them. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHING] translate german comments in /sc/inc
just to remember: some patchs translating german comments to english are not pushed, 0044 is one and we have others inside this list of patchs. revol_ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Daily Build broken on Mac
On Fri, Mar 11, 2011 at 9:55 AM, Caolán McNamara caol...@redhat.com wrote: On Fri, 2011-03-11 at 09:46 -0600, Norbert Thiebaud wrote: Looks like a icu4c-aix.patch, unsurprisingly ;-), does not apply anymore I think I fixed that patch earlier. Though there seems to be another problem on mac as well. Humm correction. the patches now apply but the build still fail... there is an expeort of U_CC that doesn't paly well with the CC having spaces in it (for me it is ccache gcc-4.0) Norbert We also however a tricky windows problem, we munge the .vcproj files in icu into something buildable with nmake. However in icu 4.6 those are replaced with .vcxproj files, and the format is different, so the custom .mak file generator doesn't work with them. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Support for greek numbering style for bullets
According to further discussion with Simos, it seems that because the patch implements a new feature, a bug should be opened first. So, here is the bug https://bugs.freedesktop.org/show_bug.cgi?id=35218 with the patch attached. In my view, the patch is ready to merge (license LGPLv3/MPL is added to the patch header) unless someone has comments or suggestions :) Cheers, Pantelis ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Daily Build broken on Mac
Le 11/03/11 17:28, Norbert Thiebaud a écrit : Hi Norbert, Humm correction. the patches now apply but the build still fail... there is an expeort of U_CC that doesn't paly well with the CC having spaces in it (for me it is ccache gcc-4.0) Norbert Ah, that might explain why my own attempt to build from master today on Mac keeps failing...for some reason, I am seeing : - failed forking of processes ; - failures in building the submodules of SFX2 - if I build individually, it seems to be ok, then when I revert back to the main make, it fails elsewhere. I'm ploughing on though. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHING] translate german comments in /sc/inc
Yes - 0001 - 0003 are pushed as I wrote yesterday. I'll continue as time permits. Christina Rossmanith Am 11.03.2011 17:20, schrieb Kayo Hamid: just to remember: some patchs translating german comments to english are not pushed, 0044 is one and we have others inside this list of patchs. revol_ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Support for greek numbering style for bullets
On Fri, Mar 11, 2011 at 6:47 PM, Pantelis Koukousoulas pkt...@gmail.com wrote: According to further discussion with Simos, it seems that because the patch implements a new feature, a bug should be opened first. So, here is the bug https://bugs.freedesktop.org/show_bug.cgi?id=35218 with the patch attached. In my view, the patch is ready to merge (license LGPLv3/MPL is added to the patch header) unless someone has comments or suggestions :) Thanks Pantelis! The patch looks fine to me and can be committed. Simos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Free JRE for Windows?
I tried to find a binary build for the Java Runtime Environment for Windows so I can distribute and install it freely but I couldn't. Several components of LibreOffice depend on JRE and I encounter many warning message boxes on start up without it, so I it's important to make sure that a free version exists. So: * Is there a free binary build of JRE for Windows? * Is there any plans to release a LibreOffice+JRE version, the way OpenOffice.org does it? Thank you! --Osama Khalid pgpZYyHd33kJ2.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Free JRE for Windows?
On Fri, Mar 11, 2011 at 08:37:29PM +0300, Osama Khalid wrote: I tried to find a binary build for the Java Runtime Environment for Windows so I can distribute and install it freely but I couldn't. AFAIK, you can't distribute it freely, the license forbids it. Several components of LibreOffice depend on JRE and I encounter many warning message boxes on start up without it, so I it's important to make sure that a free version exists. The messages are pretty scarry indeed, but can be ignored most of the times. Java is not needed for basic features. * Is there a free binary build of JRE for Windows? * Is there any plans to release a LibreOffice+JRE version, the way OpenOffice.org does it? I'll let other people speak about general/windows plans. For the DragonFly port, my intention is to remove Java dependencies as best as I can. I don't want to inflict the pain of building a jdk on our users. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] 1/2 fdo#34896 make color palette size consistent
On Mon, 2011-03-07 at 18:20 +0100, Xavier ALT wrote: Le 06/03/2011 10:31, Xavier ALT a écrit : Hi, This patch series fix make the color palette size consistent everywhere. Related to bug fdo#34896 (https://bugs.freedesktop.org//show_bug.cgi?id=34896) Looks good to me, pushed now. Thanks for this. Improve these little niggles. Can you confirm that these patches are submitted under our recommended LGPLv3+/MPLv1.1 combo ? If someone still have time to review those two patches for the 3.3.2RC1 ? I think it doesn't really qualify for 3.3.2 IMO, its low risk, but its probably not worth any risk in the stable branch, lets let it bed in on the 3.4 master. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: [PATCH] 2/2 fdo#34896 make color palette size consistent
On Sun, 2011-03-06 at 10:33 +0100, Xavier ALT wrote: second patch. Also looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Doubt about bogus and commented code
Hello there,
I've seen quite often something like this:
-/*
- #i2345#
- if ( nSlotId = SID_SFX_START !SfxMenuManager::IsPopupFunction(nSlotId)
)
- {
- // Echte Popups sollen keine SlotIds haben; leider sind
- // da noch Altlasten mit herumzuschleppen ...
- String aTitle = pSVMenu-GetItemText( nSlotId );
- pSVMenu-SetPopupMenu( nSlotId, NULL );
- USHORT nPos = pSVMenu-GetItemPos( nSlotId );
- pSVMenu-RemoveItem( nPos );
- nSlotId = 1;- while ( pSVMenu-GetItemPos(nSlotId) != MENU_ITEM_NOTFOUND )
- nSlotId++; - pSVMenu-InsertItem( nSlotId, aTitle, 0, nPos ); -
pSVMenu-SetPopupMenu( nSlotId, pPopup ); - } -*/ What should I do with it ?
leave it like that ? delete it completery ? or delete the code and leave the
bogus ?
Btw, what about the peaces which say, FIXME ?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] An Improvement for libreoffice to access a file in disk
-This email and the patch follow the provisions of GPL 3.
hi,i modified the code of libreoffice to access the file in disk,mainly in
sot module and the speed for libreoffice to open a ppt file from disk is
25% faster.
My computer :
cpu:unicore-2 600Mhz,mem:1GB.DDR2
The main change:
I found that when libreoffice reads a byte from the file,it will traverse
the list of sectors and it is slow.So i use an array to save the list.when
reading a byte,we can use the array to obtain the address of this byte in
disk directly.This change wil accelerate the process of opening a ppt file
from disk.Theorily,it also can improve the perfommance
of libreoffice running ,but if the file is changed ,the array will be
failed。Therefore,i add an tag to mark whether the file is modified.If it is
changed,we can use the list,else we use the array.
The patch :
diff -u orig/sot/source/sdstor/stgdir.cxx optimized/sot/source/sdstor/stgdir.cxx
--- orig/sot/source/sdstor/stgdir.cxx 2010-07-23 11:31:38.046198867 +0800
+++ optimized/sot/source/sdstor/stgdir.cxx 2011-03-12 12:30:07.092985044
+0800
@@ -879,6 +879,7 @@
BOOL StgDirStrm::Store()
{
+ Dirty=true;
if( !pRoot-IsDirty() )
return TRUE;
if( !pRoot-StoreStreams( rIo ) )
diff -u orig/sot/source/sdstor/stgstrms.cxx
optimized/sot/source/sdstor/stgstrms.cxx
--- orig/sot/source/sdstor/stgstrms.cxx 2010-07-23 11:31:38.046198867 +0800
+++ optimized/sot/source/sdstor/stgstrms.cxx2011-03-12 12:41:12.756986414
+0800
@@ -327,6 +327,8 @@
pEntry = NULL;
nPos = nSize = 0;
nPageSize = rIo.GetPhysPageSize();
+ initFAT=true;
+ Dirty=false;
}
StgStrm::~StgStrm()
@@ -350,6 +352,32 @@
BOOL StgStrm::Pos2Page( INT32 nBytePos )
{
+ if(initFAT==true)
+ {
+ initFAT=false;
+
+ FAT[0]=nStart;
+ for(INT32 i=1;i8192;i++)
+ FAT[i]=-5;
+
+ INT32 nRel,nBgn,currentSuffix;
+ currentSuffix=0;
+ nRel=nSize/nPageSize;
+ if(nRel==0)
+ FAT[++currentSuffix]=-2;
+ else
+ {
+ nBgn=nStart;
+
+ while(nRel nBgn=0)
+ {
+ nBgn=pFat-GetNextPage(nBgn);
+ FAT[++currentSuffix]=nBgn;
+ nRel--;
+ }
+ }
+
+ }
INT32 nRel, nBgn;
// Values 0 seek to the end
if( nBytePos 0 || nBytePos = nSize )
@@ -363,7 +391,29 @@
nPos = nBytePos;
if( nOld == nNew )
return TRUE;
-if( nNew nOld )
+if(Dirty==false)
+ {
+ INT32 nDestPage=nNew/nPageSize;
+ INT32 nNewPage=FAT[nDestPage];
+
+ if(nNewPage!=-5)
+ {
+ nPage=nNewPage;
+ if(nBytePos==nSize!nOffset)
+ {
+ nPage=FAT[nDestPage-1];
+ nOffset=nPageSize;
+ }
+ return BOOL(nPage=0);
+ }
+ else
+ {
+ rIo.SetError( SVSTREAM_FILEFORMAT_ERROR );
+ nPage = STG_EOF;
+ nOffset = nPageSize;
+ }
+ }
+if( nNew = nOld )
{
// the new position is behind the current, so an incremental
// positioning is OK. Set the page relative position
@@ -879,6 +929,7 @@
INT32 StgDataStrm::Write( const void* pBuf, INT32 n )
{
+ Dirty=true;
INT32 nDone = 0;
if( ( nPos + n ) nSize )
{
@@ -1005,6 +1056,7 @@
INT32 StgSmallStrm::Write( const void* pBuf, INT32 n )
{
+ Dirty=true;
// you can safely assume that reads are not huge, since the
// small stream is likely to be 64 KBytes.
short nDone = 0;
diff -u orig/sot/source/sdstor/stgstrms.hxx
optimized/sot/source/sdstor/stgstrms.hxx
--- orig/sot/source/sdstor/stgstrms.hxx 2011-03-12 12:37:52.468985102 +0800
+++ optimized/sot/source/sdstor/stgstrms.hxx2011-03-12 12:37:49.297042325
+0800
@@ -84,6 +84,9 @@
BOOL Copy( INT32 nFrom, INT32 nBytes );
StgStrm( StgIo );
public:
+ INT32 FAT[8192];
+ BOOL initFAT;
+ BOOL Dirty;
virtual ~StgStrm();
StgIo GetIo(){ return rIo;}
INT32 GetPos() { return nPos; }
@@ -97,7 +100,7 @@
virtual BOOL SetSize( INT32 );
virtual BOOL Pos2Page( INT32 nBytePos );
virtual INT32 Read( void*, INT32 ) { return 0; }
-virtual INT32 Write( const void*, INT32 ) { return 0; }
+virtual INT32 Write( const void*, INT32 ) { Dirty=true; return 0; }
virtual StgPage* GetPhysPage( INT32 nBytePos, BOOL bForce = FALSE );
virtual BOOL IsSmallStrm() { return FALSE; }
};
--
Shantong Kang 康善同
Microprocessor
[Libreoffice] [PATCH] [PUSHING] translate german comments in /sc/inc
Pushed up to 0011 Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
