Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 12:51 AM, Francois Tigeot ftig...@wolfpond.org wrote:
On Mon, Aug 29, 2011 at 12:17:33AM -0600, Tor Lillqvist wrote:
I'd like to consolidate the different OUTPATH values to a single one or two
at most (unx and wnt). Thoughts ?
That will break cross-compilation as currently implemented. It isn't
entirely unthinkable that somebody might at some point want to cross-compile
from some (well, *the*) mainstream Linux platform, x86_64, to a rare Linux
platform.
I have no idea how cross-compilation is currently implemented, but can't that
be done with the same build directory name for all platforms ? I would think
the path which matters most in the end is the installation one...
no, in cross compile you may have to build object/executable that run
on the build machine on top of objects/executable for the target
machine (thinks about stuff we build and use during the build like
idlc or the like)
If we have just one OUTPATH for all Unixes, the above won't work.
Can't we at least get rid of the '350' subdirectory ? Apart from $OUTPATH it
seems to always be empty.
Due to the way the build system works, I have to put many of the lib/
subdirectories in LD_LIBRARY_PATH. Otherwise, LibreOffice can simply not be
packaged in pkgsrc:
LD_LIBRARY_PATH=${BUILDLINK_DIR}/lib:${WRKSRC}/desktop/unxdfly.pro/lib:${WRKSRC}/solver/350/unxdfly.pro/lib:${WRKSRC}/desktop/unxnbsd.pro/lib:${WRKSRC}/solver/350/unxnbsd.pro/lib:${X11BASE}/lib
For now, I only do this for DragonFly and NetBSD but this is not ideal and I
will
certainly blow up some limit if I add all the Linux variants...
I'm confused, why do you need to concatenate all of these ?
Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 01:07:03AM -0500, Norbert Thiebaud wrote:
On Tue, Aug 30, 2011 at 12:51 AM, Francois Tigeot ftig...@wolfpond.org
wrote:
On Mon, Aug 29, 2011 at 12:17:33AM -0600, Tor Lillqvist wrote:
I'd like to consolidate the different OUTPATH values to a single one or
two
at most (unx and wnt). Thoughts ?
I have no idea how cross-compilation is currently implemented, but can't
that
be done with the same build directory name for all platforms ? I would think
the path which matters most in the end is the installation one...
no, in cross compile you may have to build object/executable that run
on the build machine on top of objects/executable for the target
machine (thinks about stuff we build and use during the build like
idlc or the like)
Then we should only need two build directories:
- one for the host binaries
- one for the target binaries
Due to the way the build system works, I have to put many of the lib/
subdirectories in LD_LIBRARY_PATH. Otherwise, LibreOffice can simply not be
packaged in pkgsrc:
LD_LIBRARY_PATH=${BUILDLINK_DIR}/lib:${WRKSRC}/desktop/unxdfly.pro/lib:${WRKSRC}/solver/350/unxdfly.pro/lib:${WRKSRC}/desktop/unxnbsd.pro/lib:${WRKSRC}/solver/350/unxnbsd.pro/lib:${X11BASE}/lib
For now, I only do this for DragonFly and NetBSD but this is not ideal and
I will
certainly blow up some limit if I add all the Linux variants...
I'm confused, why do you need to concatenate all of these ?
The build system uses so many flags and tricks it can't run as-is under
the pkgsrc framework, many libraries are not found at link time.
Some platforms don't understand the -rlink-path and related options either.
Using LD_LIBRARY_PATH is the simplest way I've found to package LibreOffice
properly on most (all ?) supported systems.
--
Francois Tigeot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 12:15:50AM -0600, Tor Lillqvist wrote: I have no idea how cross-compilation is currently implemented, but can't that be done with the same build directory name for all platforms ? Not unless the way it is done currently is changed. New ideas, and patches to implement them welcome. But don't just break it. Don't worry, I don't have time to work on it currently anyway. In theory, we only need two things: - tools and binaries to complete the build (run on the host) - a place to put the final binaries and files needed to run on the target For instance, when cross-compiling to PowerPC Linux from x86_64 Linux (hypothetical example, but as such potentially useful), idlc would be in solver/350/unxlngx6.pro/bin, and the PowerPC binaries being produced in solver/350/unxlngppc.pro/bin. If I understand correctly, two build subdirectories are only what is needed here. The problem is they use the exact names of the currently used host and target platforms. We could simply name them build_tools and target_files for example and this would eliminate the problem. Can't we at least get rid of the '350' subdirectory ? Yes please. I'll give it a try then. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine
Kohei Yoshida wrote: I'm planning to switch to OneGit, anyway I'm not sure where my patches have been pushed at present. I see several commits under your name in the svg-export branch: http://cgit.freedesktop.org/libreoffice/core/log/?h=svg-export Perhaps this is where Thorsten pushed your patches to? *blush* yeah, but that was unintended. The code is on master branch proper, too. Cheers, -- Thorsten pgp0hkqnxq3if.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Build failure on Mac OSX
Hi all, When trying to build from master on Mac OSX, I get this after dmake gets built : ERROR: incomplete dependencies! Fetching dependencies for module translations from solver... failed and the build naturally stops. Which dependencies might they be ? The build.log gives no further information. Thanks for any suggestions offered, Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
Then we should only need two build directories: - one for the host binaries - one for the target binaries Bzzt, you are misunderstanding the GNU autofoo cross-compilation terminology;) (A *very* common trap to fall in...) In general, in GNU autofoo cross-compilation terminology, there are *three* platforms involved: build, host and target. The general case is when building a compiler. Consider buildng a gcc cross-compiler that should run on Windows and produce binaries for Android, and building this cross-compiler on Linux. (This is a real example.) Then build == Linux, host == Windows, target == Android. Now, LibreOffice is not a compiler, so for it host == target, and the term target should not really be used, as it means the platform a compiler or similar tool targets. So what you mean is that we need two build directories: one for the *build* platform binaries, one for the *host* platform binaries. (For instance, with host and build in their names.) Sure. That would be a pretty obvious change. It would match the file names Env.Host.sh and Env.Build.sh nicely, too. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine
Marco wrote: When I go to switch to OneGit which patches of mine will I find already merged ? Yes, except for the 0019- one. Let's rework that to have svgscript.hxx auto-generated there. Cheers, -- Thorsten pgpfEEYWFV6JL.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] instructions for building on windows with OneGit
Hi Are there up-to-date instructions somewhere for building on Windows with the new OneGit repos? I seem to be stuck building on the old repos. Thanks, Noel Grnadin Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] DrawPolyLine on Windows
Hello! Any code [patches] from me is always under normal license of LibreOffice. 29.08.2011 14:28, Tor Lillqvist пишет: Anyway, I committed and pushed your patch, thanks! Please do follow up with more patches if you notice other problems. Please confirm that you license your code under our normal LGPL/MPL combination. --tml -- Best Regards, Dmitry attachment: dmitry_ashkadov.vcf___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build failure on Mac OSX
Alexander Thurgood wrote: ERROR: incomplete dependencies! Fetching dependencies for module translations from solver... failed Looks like you (re-)configured your build to use a lang other than en-US. Can you manually do a make fetch report back whether that fixed it (beware, translations is a rather big repo)? Cheers, -- Thorsten pgpHzwWoBT1PZ.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build failure on Mac OSX
Le 30/08/11 11:38, Thorsten Behrens a écrit : Hi Thorsten, Looks like you (re-)configured your build to use a lang other than en-US. Can you manually do a make fetch report back whether that fixed it (beware, translations is a rather big repo)? Well that's strange because I've been building specifically with the switch --with-lang=en-US The only thing I did between yesterday, when the build was starting, but failing elsewhere in svx and hc2, was repulled with git pull ./g pull. Will try what you suggest, thanks. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] gdb debugging error
Hello, While I try to run gdb on soffice.bin I cannot start soffice.bin as it gives the following error: /home/LOff/libo/desktop/source/app/cmdlineargs.cxx, Line 140: CommandLineArgs: no ProcessServiceFactory./lib/bootstrap.uno.so Program received signal SIGSEGV, Segmentation fault. desktop::CommandLineArgs::ParseCommandLine_Impl (this=0xb7f62ba0, supplier=...) at /home/LOff/libo/desktop/source/app/cmdlineargs.cxx:144 Current language: auto The current source language is auto; currently c++. can you tell me how to fix it? Gabor ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] gdb debugging error
Hello Jenei, I suppose you runned make dev-install. If it's the case, have you runned all the commands quoted at the end : cd install directory . ooenv... (I think you perhaps missed this one since I had exactly the same error yesterday and this was the cause) ./soffice.bin Hope it helps. Julien. -- View this message in context: http://nabble.documentfoundation.org/gdb-debugging-error-tp3295063p3295244.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||40392 --- Comment #4 from Petr Mladek pmla...@suse.cz 2011-08-30 04:43:56 PDT --- Add bug 40392. LO window is on background when starting on MAC. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine
On Tue, 30 Aug 2011 09:36:00 +0200, Thorsten Behrens t...@documentfoundation.org wrote: Marco wrote: skip Well, I understand this one and your other comments, but I think you should take into account that all the script is embedded into the svg document. If a user incurs into a problem with the animation engine and mail his/her document to us we can get immediately which script release is. Good point - but then let's auto-generate that number, otherwise incrementing it will be forgotten every once in a while. Uhm, so the new number will be more a built number than a version number. Maybe it would be better to replace it with a full time stamp related to the last time the JavaScript code file was changed. Again, the script and its legal notice are embedded into a svg document, so it seems that it is meaningless the fragment OR THIS FILE HEADER. As far as the fact I didn't point out that in the commit notice, well it didn't seem to me a so big change (moreover I did not modified the legal notice itself). Meaningless or not, legal notices (which is all of the header) cannot be changed, except by the copyright holder. Ok sorry, I have no knowledge of software legal issues. So should I remove such a change ? From my point of view the C++ header is not anymore the right place where to look for JavaScript presentation engine changes. I think that the best solution is to include into the commit the JavaScript code file itself (and the python script too). Absolutely! Let's then get rid of the svgscript.hxx entirely, and generate that during build time, with your script - that also gives the nice option to plug in the version number you mentioned above from git. Yep, I was thinking of that by a while, what stopped me from deploying such a solution is: - it is not clear to me how to get the python script executed automatically (make file ?); - it does not seem that python is listed between the requirements to get LibreOffice built. Cheers, -- Marco -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
Hi Tor, On Tuesday, 2011-08-30 00:15:50 -0600, Tor Lillqvist wrote: Can't we at least get rid of the '350' subdirectory ? Yes please. The 350 should be 340 (isn't it?) for 3-4 branches, so different output hierarchies when switching branches is nice to have in order to not spoil already existing outputs. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
Hi, On Tuesday, 2011-08-30 00:15:50 -0600, Tor Lillqvist wrote: For instance, when cross-compiling to PowerPC Linux from x86_64 Linux (hypothetical example, but as such potentially useful), idlc would be in solver/350/unxlngx6.pro/bin, and the PowerPC binaries being produced in solver/350/unxlngppc.pro/bin. Additionally, when building both, with --enable--dbgutil and without, there are for example solver/350/unxlngx6 and solver/350/unxlngx6.pro Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
Sent from my iPhone On 30.08.2011, at 14:40, Eike Rathke o...@erack.de wrote: Hi Tor, On Tuesday, 2011-08-30 00:15:50 -0600, Tor Lillqvist wrote: Can't we at least get rid of the '350' subdirectory ? Yes please. The 350 should be 340 (isn't it?) for 3-4 branches, so different output hierarchies when switching branches is nice to have in order to not spoil already existing outputs. Maybe, once a build only generates output in that single directory. Until then, the point is rather moot, IMO. -Stephan___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine
Marco wrote: Ok sorry, I have no knowledge of software legal issues. So should I remove such a change ? Yes please. Yep, I was thinking of that by a while, what stopped me from deploying such a solution is: - it is not clear to me how to get the python script executed automatically (make file ?); - it does not seem that python is listed between the requirements to get LibreOffice built. No prob, those can be custom-built. If you can share original .js and the python script, we'll have that setup. Cheers, -- Thorsten pgpjAoRoBPrhC.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
Hi Stephan, On Tuesday, 2011-08-30 14:59:23 +0200, Stephan Bergmann wrote: Can't we at least get rid of the '350' subdirectory ? Yes please. The 350 should be 340 (isn't it?) for 3-4 branches, so different output hierarchies when switching branches is nice to have in order to not spoil already existing outputs. Maybe, once a build only generates output in that single directory. Until then, the point is rather moot, IMO. True, but instead of getting rid of solver/350 I'd rather introduce a module/$INPATH/350 ... on the other hand, having two cloned repos and build trees for different branches is a better approach. Just was thinking in terms of disk space, maybe a moot argument these days. So, I'm fine with removing 350. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Unknown property
Hi julien2412,
On Monday, 2011-08-29 15:58:21 -0700, julien2412 wrote:
I thought this patch would be ok :
diff --git a/sd/source/core/stlsheet.cxx b/sd/source/core/stlsheet.cxx
index 1d6fa46..7e0424e 100644
--- a/sd/source/core/stlsheet.cxx
+++ b/sd/source/core/stlsheet.cxx
@@ -90,6 +90,7 @@ static SvxItemPropertySet GetStylePropertySet()
{ RTL_CONSTASCII_STRINGPARAM(DisplayName),
WID_STYLE_DISPNAME, ::getCppuType((const OUString*)0), PropertyAttrib
SVX_UNOEDIT_NUMBERING_PROPERTIE,
+SVX_UNOEDIT_OUTLINER_PROPERTIES,
SHADOW_PROPERTIES
LINE_PROPERTIES
LINE_PROPERTIES_START_END
but when I tried it I got this :
Error: unknown which - dont ask me for defaults
with Id/Pos: 3901 From File
/home/maryline/compile-libreoffice/libo/svl/source/items/itempool.cxx at
Line 900
Error: Which-Id nicht im Pool-Bereich From File
/home/maryline/compile-libreoffice/libo/svl/source/inc/poolio.hxx at Line
212
Program received signal SIGSEGV, Segmentation fault.
Ouch, the SfxItemPool hit you ;-)
You can't simply add a property without adjusting the corresponding item
pool and its defaults. I think for the EditEngine and Draw case that's
in editeng/source/editeng/eerdll.cxx GlobalEditData::GetDefItems(),
though I don't know if nowadays it's sufficient to adapt just that place
and editeng/inc/editeng/eeitem.hxx, maybe someone familiar with Draw can
shed some light.
Could someone explain what do EE_PARA_NUMBULLET, WID_NUMLEVEL, ... that
we can read for the define of SVX_UNOEDIT_NUMBERING_PROPERTIE or
SVX_UNOEDIT_OUTLINER_PROPERTIES mean ?
Each core attribute/property is represented by a SfxPoolItem,
EE_PARA_NUMBULLET and so on are so-called Which-IDs, the ID an item has
in an SfxItemPool. For each item the pool knows a default value, shared
across all SfxItemSet instances that use the same pool, so only
differing values need to be stored. The pool is of a fixed map size and
anything unknown leads to unpredictable behavior and crashes at best.
Bjoern can sing a song about that ;-)
Eike
--
PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Escaped non-ASCII characters from source files.
Hi Takashi, On Tuesday, 2011-08-30 00:27:47 +0900, Takashi Nakamoto wrote: The attached patch solves a compilation error in libxml2 which occurs on Windows with some Asian locales. I would appreciate if someone pushes this. Makes sense. Please confirm that you contribute this and possibly further patches under LGPLv3+ and MPL 1.1 licenses. Thanks Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 03:42:22PM +0200, Eike Rathke wrote: On Tuesday, 2011-08-30 14:59:23 +0200, Stephan Bergmann wrote: Can't we at least get rid of the '350' subdirectory ? Yes please. The 350 should be 340 (isn't it?) for 3-4 branches, so different output hierarchies when switching branches is nice to have in order to not spoil already existing outputs. Maybe, once a build only generates output in that single directory. Until then, the point is rather moot, IMO. True, but instead of getting rid of solver/350 I'd rather introduce a module/$INPATH/350 ... on the other hand, having two cloned repos and build trees for different branches is a better approach. Just was thinking in terms of disk space, maybe a moot argument these days. There are better solutions for the disk space problem. In the past, projects such as XFree86 used symbolic links to create shadow copies of directories: http://xfree86.org/4.3.0/lndir.1.html That way, you can have two separate source trees and only use about the same disk space than with a single one. Git clone uses hard links when the source and clone repositories are on the same filesystem. That also prevents using twice the space. For my part, I'm using filesystem deduplication; even if I cp files, they only take space once on the disk. So, I'm fine with removing 350. I'll push the commit then :-) -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 1:35 AM, Francois Tigeot ftig...@wolfpond.org wrote: The build system uses so many flags and tricks it can't run as-is under the pkgsrc framework, many libraries are not found at link time. Some platforms don't understand the -rlink-path and related options either. Using LD_LIBRARY_PATH is the simplest way I've found to package LibreOffice properly on most (all ?) supported systems. I'm sorry but I really don't understand the problem you are trying to solve beside how hard can it be to figure-out on which system you are and use the proper path ? (see set_soenv.in for an authoritative list of possible values) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] vbaevents*.uno.so and libvbaswobj*uno.so location
Hi Rene, Caolan or Noel has recently suggested me to move vbaobj.uno.so into the Calc package because it links against libsc and is needed only by Calc. I have just seen the following note at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=620100: --- cut --- Changes: libreoffice (1:3.3.3-1) unstable; urgency=medium [...] - stop moving vbaevents*.uno.so to -calc. Move libvbaswobj*uno.so to -writer --- cut --- I am a bit curious about these changes. Are they needed to fix dependencies or do they avoid a functionality problems? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use a custom string to make numbering more flexible
Hi Mohammad, On Tuesday, 2011-08-30 02:41:05 +0430, Mohammad Elahi wrote: This patch is a try to make outline numbering more flexible. I just want to know the feedback of community. Looks good from a first glance at the code. One question occurred to me: How is this made persistent, i.e. stored in a document? Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] vbaevents*.uno.so and libvbaswobj*uno.so location
On Tue, Aug 30, 2011 at 05:07:33PM +0200, Petr Mladek wrote: Caolan or Noel has recently suggested me to move vbaobj.uno.so into the Calc package because it links against libsc and is needed only by Calc. Did that for a long time. Until this: I have just seen the following note at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=620100: Wrong URL? --- cut --- Changes: libreoffice (1:3.3.3-1) unstable; urgency=medium [...] - stop moving vbaevents*.uno.so to -calc. Move libvbaswobj*uno.so to -writer --- cut --- I am a bit curious about these changes. Are they needed to fix dependencies or do they avoid a functionality problems? http://lists.debian.org/debian-openoffice/2011/06/msg00024.html. And then my reply at http://lists.debian.org/debian-openoffice/2011/06/msg00025.html vbaevents lost its libsc link so it can go to -core and that would help the poster. and lib*sw*vbjaobj sounds like writer suff, afair it wven linked to something sw'ish. Grüße/Regards, René ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
Hi Kohei, On Tuesday, 2011-08-30 10:20:05 -0400, Kohei Yoshida wrote: You can try git-new-workdir http://kohei.us/2010/11/16/working-with-a-branch-using-git-new-workdir/ Way cool, thanks! I'll try that one day. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] vbaevents*.uno.so and libvbaswobj*uno.so location
On Tue, 2011-08-30 at 17:07 +0200, Petr Mladek wrote: Hi Rene, Caolan or Noel has recently suggested me to move vbaobj.uno.so into the Calc package because it links against libsc and is needed only by Calc. Wasn't me, but in Fedora we put vbaobj.uno.so into calc, vbaevents.uno.so into core, and vbaswobj.uno.so in writer. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 10:06:57AM -0500, Norbert Thiebaud wrote: On Tue, Aug 30, 2011 at 1:35 AM, Francois Tigeot ftig...@wolfpond.org wrote: The build system uses so many flags and tricks it can't run as-is under the pkgsrc framework, many libraries are not found at link time. Some platforms don't understand the -rlink-path and related options either. Using LD_LIBRARY_PATH is the simplest way I've found to package LibreOffice properly on most (all ?) supported systems. I'm sorry but I really don't understand the problem you are trying to solve Removing unneeded complexity. beside how hard can it be to figure-out on which system you are and use the proper path ? (see set_soenv.in for an authoritative list of possible values) It will not be too hard by itself but this will be one more script to maintain, with its own possible problems which will bite me in the future. I'd rather like to not have to manage a list in the first place, and keep the packaging script (and set_soenv.in) simple. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 05:42:42PM +0200, Eike Rathke wrote: Which reminds me there may be other places that rely on the $UPD path particle. Francois, did you adapt solenv/bin/linkoo as well? Good catch, I didn't. What does this file do ? I did a complete build before commiting the patch and there was no obvious problem. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use a custom string to make numbering more flexible
Hi Eike Looks good from a first glance at the code. One question occurred to me: How is this made persistent, i.e. stored in a document? It is not persistent yet. I think docx has the property appropriate to use for making it persistent, but I know no such a property in odt, it needs addition of some standards in odt. But odt is a standard, can I add any property to it? Thanks -Elahi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 10:43 AM, Francois Tigeot ftig...@wolfpond.org wrote: On Tue, Aug 30, 2011 at 10:06:57AM -0500, Norbert Thiebaud wrote: On Tue, Aug 30, 2011 at 1:35 AM, Francois Tigeot ftig...@wolfpond.org wrote: The build system uses so many flags and tricks it can't run as-is under the pkgsrc framework, many libraries are not found at link time. Some platforms don't understand the -rlink-path and related options either. Using LD_LIBRARY_PATH is the simplest way I've found to package LibreOffice properly on most (all ?) supported systems. I'm sorry but I really don't understand the problem you are trying to solve Removing unneeded complexity. beside how hard can it be to figure-out on which system you are and use the proper path ? (see set_soenv.in for an authoritative list of possible values) It will not be too hard by itself but this will be one more script to maintain, with its own possible problems which will bite me in the future. I'd rather like to not have to manage a list in the first place, and keep the packaging script (and set_soenv.in) simple. I don't know what you packaging script look like, but removing OUTPATH will not make set_soenv.in any substantially simpler. and no matter how hard you try there will be the nedd for per-platform value. how hard would it be for your packaging script to take advantage of Env.Host.sh ? you could get OUTPATH (1) (and/or any other similar variables) from there and then LD_LIBRARY_PATH=/$OUTPATH/xxx No need to maintain a separate list... Norbert (1) eval $(grep ^OUTPATH= Env.Host.sh) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] BUG 36594
Hello Eike, I made your recommended changes, but the querycomposer class seems to be modified since I last worked on this issu, as unfortunatelly it deletes all the linefeeds in the query string, so I cannot make it work. Now I could store in a second vector whether one line is just empty(it only contains a comment), or it contains query string, so then I iterate on this vector, and try to reconstruct my query with comments. Actually I've already checked that my delComment function works ok, it leaves the linefeeds on their place, so something else must go wrong. I could solve the issue, but I guess it will break the usability of the two functions in querycontroller.cxx alone, so they only could be used together just as before. Maybe I should just unite them into one function? thanks, Gabor ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] DrawPolyLine on Windows
Any code [patches] from me is always under normal license of LibreOffice. Unfortunately that is not quite clear enough; you need to say exactly what license(s) you mean. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 11:21:18AM -0500, Norbert Thiebaud wrote: On Tue, Aug 30, 2011 at 10:43 AM, Francois Tigeot ftig...@wolfpond.org wrote: On Tue, Aug 30, 2011 at 10:06:57AM -0500, Norbert Thiebaud wrote: On Tue, Aug 30, 2011 at 1:35 AM, Francois Tigeot ftig...@wolfpond.org wrote: I don't know what you packaging script look like, It's a Makefile: http://pkgsrc-wip.cvs.sourceforge.net/viewvc/pkgsrc-wip/wip/libreoffice/Makefile?hideattic=1revision=1.15view=markup how hard would it be for your packaging script to take advantage of Env.Host.sh ? you could get OUTPATH (1) (and/or any other similar variables) from there and then LD_LIBRARY_PATH=/$OUTPATH/xxx No need to maintain a separate list... (1) eval $(grep ^OUTPATH= Env.Host.sh) I could try that. Thanks for the tip! -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] ccache support
Hi all, On Wed, Aug 10, 2011 at 11:27:05AM +0200, Jan Holesovsky wrote: On 2011-08-08 at 11:33 +0200, Lubos Lunak wrote: I've pushed http://cgit.freedesktop.org/libreoffice/core/commit/?id=57cf026739a3d707378 ca38f59518b018fccca8f This try to automatically use ccache when present, unless CC= or CXX= was specified by the user or --disable-ccache was passed to autogen This also detect if CC or CXX is already an alias for ccache, in which case ccache is not prefixed to CC and/or CXX I disagree with this change, as it does not improve anything for anybody. Well, I am not that happy about using ccache by default either ;-) It collides with the icecream support, I'm not happy about this commit either: when packaging LibreOffice under pkgsrc, it doubles the size of the build tree for no gain in speed. The pkgsrc framework sanitizes the environment; $HOME is a temporary directory which is always removed and created anew for each build. I'm using ccache for development builds (from git), and I _don't_ want to use it when creating packages on the same machine. Could this change be reverted ? Instead of improving things, it degrades them. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 11:48 AM, Francois Tigeot ftig...@wolfpond.org wrote:
On Tue, Aug 30, 2011 at 11:21:18AM -0500, Norbert Thiebaud wrote:
On Tue, Aug 30, 2011 at 10:43 AM, Francois Tigeot ftig...@wolfpond.org
wrote:
On Tue, Aug 30, 2011 at 10:06:57AM -0500, Norbert Thiebaud wrote:
On Tue, Aug 30, 2011 at 1:35 AM, Francois Tigeot ftig...@wolfpond.org
wrote:
I don't know what you packaging script look like,
It's a Makefile:
http://pkgsrc-wip.cvs.sourceforge.net/viewvc/pkgsrc-wip/wip/libreoffice/Makefile?hideattic=1revision=1.15view=markup
btw, based on the file above and specifically the LD_LIBRARY_PATH
section I could see, it may well be that what you need is INPATH not
OUTPATH
and
${TOUCH} ${WRKSRC}/clone/repos_changed
I don't think repos_changed is used anymore (that was a trick in the
3.3 'build-repo' based build)
Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] ccache support
On Tue, Aug 30, 2011 at 11:58 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Tue, Aug 30, 2011 at 11:57 AM, Francois Tigeot ftig...@wolfpond.org wrote: Hi all, On Wed, Aug 10, 2011 at 11:27:05AM +0200, Jan Holesovsky wrote: On 2011-08-08 at 11:33 +0200, Lubos Lunak wrote: I've pushed http://cgit.freedesktop.org/libreoffice/core/commit/?id=57cf026739a3d707378 ca38f59518b018fccca8f This try to automatically use ccache when present, unless CC= or CXX= was specified by the user or --disable-ccache was passed to autogen This also detect if CC or CXX is already an alias for ccache, in which case ccache is not prefixed to CC and/or CXX I disagree with this change, as it does not improve anything for anybody. Well, I am not that happy about using ccache by default either ;-) It collides with the icecream support, I'm not happy about this commit either: when packaging LibreOffice under pkgsrc, it doubles the size of the build tree for no gain in speed. then use --disable-ccache as in CONFIGURE_ARGS+= --disable-ccache :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 11:58:08AM -0500, Norbert Thiebaud wrote:
On Tue, Aug 30, 2011 at 11:48 AM, Francois Tigeot ftig...@wolfpond.org
wrote:
On Tue, Aug 30, 2011 at 11:21:18AM -0500, Norbert Thiebaud wrote:
On Tue, Aug 30, 2011 at 10:43 AM, Francois Tigeot ftig...@wolfpond.org
wrote:
On Tue, Aug 30, 2011 at 10:06:57AM -0500, Norbert Thiebaud wrote:
On Tue, Aug 30, 2011 at 1:35 AM, Francois Tigeot ftig...@wolfpond.org
wrote:
I don't know what you packaging script look like,
It's a Makefile:
http://pkgsrc-wip.cvs.sourceforge.net/viewvc/pkgsrc-wip/wip/libreoffice/Makefile?hideattic=1revision=1.15view=markup
btw, based on the file above and specifically the LD_LIBRARY_PATH
section I could see, it may well be that what you need is INPATH not
OUTPATH
Afaik INPATH = $OUTPATH + something . That could be true
and
${TOUCH} ${WRKSRC}/clone/repos_changed
I don't think repos_changed is used anymore (that was a trick in the
3.3 'build-repo' based build)
It was needed in July at least; otherwise, some script tried to download all
the possible remotes files in src/
--
Francois Tigeot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
On Tue, Aug 30, 2011 at 12:01 PM, Francois Tigeot ftig...@wolfpond.org wrote:
On Tue, Aug 30, 2011 at 11:58:08AM -0500, Norbert Thiebaud wrote:
On Tue, Aug 30, 2011 at 11:48 AM, Francois Tigeot ftig...@wolfpond.org
wrote:
On Tue, Aug 30, 2011 at 11:21:18AM -0500, Norbert Thiebaud wrote:
On Tue, Aug 30, 2011 at 10:43 AM, Francois Tigeot ftig...@wolfpond.org
wrote:
On Tue, Aug 30, 2011 at 10:06:57AM -0500, Norbert Thiebaud wrote:
On Tue, Aug 30, 2011 at 1:35 AM, Francois Tigeot
ftig...@wolfpond.org wrote:
I don't know what you packaging script look like,
It's a Makefile:
http://pkgsrc-wip.cvs.sourceforge.net/viewvc/pkgsrc-wip/wip/libreoffice/Makefile?hideattic=1revision=1.15view=markup
btw, based on the file above and specifically the LD_LIBRARY_PATH
section I could see, it may well be that what you need is INPATH not
OUTPATH
Afaik INPATH = $OUTPATH + something . That could be true
and
${TOUCH} ${WRKSRC}/clone/repos_changed
I don't think repos_changed is used anymore (that was a trick in the
3.3 'build-repo' based build)
It was needed in July at least; otherwise, some script tried to download all
the possible remotes files in src/
hummm... maybe.. but right now git grep repos_changed return nothing at all
are you sure you are not confusing it with src.downloaded ?
Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] ccache support
On Tue, Aug 30, 2011 at 12:00:54PM -0500, Norbert Thiebaud wrote: On Tue, Aug 30, 2011 at 11:57 AM, Francois Tigeot ftig...@wolfpond.org wrote: I'm not happy about this commit either: when packaging LibreOffice under pkgsrc, it doubles the size of the build tree for no gain in speed. then use --disable-ccache as in CONFIGURE_ARGS+= --disable-ccache Nice, I don't even have to do the job anymore ;-) Still, this ccache stuff is too clever for its own good IMHO. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
Hi Francois, On Tuesday, 2011-08-30 17:49:06 +0200, Francois Tigeot wrote: Francois, did you adapt solenv/bin/linkoo as well? Good catch, I didn't. What does this file do ? I did a complete build before commiting the patch and there was no obvious problem. When doing make dev-install it creates symbolic links from the basis-link/program/ directory to the platform's solver directory for most libraries, where applicable. So, after having rebuilt some module(s) you can just run the application from the installation without having to copy libs around. Btw, one of my earlier mails Cc'ed franc...@freedesktop.org and I got a bounce for that: SMTP error from remote server after RCPT command: host gabe.freedesktop.org[131.252.210.177]: 550 5.1.1 franc...@freedesktop.org: Recipient address rejected: User unknown in local recipient table Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] ccache support
On Tue, Aug 30, 2011 at 12:16 PM, Francois Tigeot ftig...@wolfpond.org wrote: On Tue, Aug 30, 2011 at 12:00:54PM -0500, Norbert Thiebaud wrote: On Tue, Aug 30, 2011 at 11:57 AM, Francois Tigeot ftig...@wolfpond.org wrote: I'm not happy about this commit either: when packaging LibreOffice under pkgsrc, it doubles the size of the build tree for no gain in speed. then use --disable-ccache as in CONFIGURE_ARGS+= --disable-ccache Nice, I don't even have to do the job anymore ;-) Still, this ccache stuff is too clever for its own good IMHO. for reference here is the motivations that lead me to do it 1/ the configure.in help advertised that we where doing it (as in claimed that if ccache was present we would automatically use it) 2/ I had a spike in IRC questions/confusions from new tentative contributors on that topic, so I wanted to make it as newbie friendly as possible. iow a 'just fscking work' approach. 3/ I had issue with MacOS: in order to use ccache I had to set CC and CXX before autogen (or as autogen.sh parameters). but doing so meant that I had to take into account which compiler should be use. and on Mac that depend on the SDK being used... so basically I had to do manually the job of configure... to set the proper CC and CXX manually 4/ I considered that one-time builder were not the audience I cared about, and that distrib-builder are savvy enough to make the build system do what they want (iow add --disable-ccache if they decided that ccache is not useful to them) and really it is not _that_ clever: if ccache is disabled or icecream is enabled or there is no ccache on the system we do nothing special else if CC or CCX are manually preset we do nothing special (presumably if you bothered to explicitly pre-set it and wanted ccache you would have set it so) else (that was added later on remark that CCACHE_DIR may be to small to be useful) if the ccache size is less than 1GB then we do nothing and warn about it else if ccache size is between 1GB and 5GB then we warn that you should prolly set a bigger ccache size especially if you intend to do debug/symbol build fi if CC or CXX respectively point to ccache already (case when you alias gcc to ccache) then we do nothing special else we prepend ccache to CC or CXX respectively fi fi fi fi Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Platform-specific OUTPATH variables
Hi Eike, On Tue, Aug 30, 2011 at 07:42:54PM +0200, Eike Rathke wrote: On Tuesday, 2011-08-30 17:49:06 +0200, Francois Tigeot wrote: Francois, did you adapt solenv/bin/linkoo as well? Good catch, I didn't. What does this file do ? I did a complete build before commiting the patch and there was no obvious problem. When doing make dev-install it creates symbolic links from the basis-link/program/ directory to the platform's solver directory for most libraries, where applicable. So, after having rebuilt some module(s) you can just run the application from the installation without having to copy libs around. OK. It is now fixed. Btw, one of my earlier mails Cc'ed franc...@freedesktop.org and I got a bounce for that: That address doesn't exist; it could have been a bug or some sort of mistake... -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] DrawPolyLine on Windows
Licensing is very difficult question for me. I contribute some code [patch] without any limitations. So, if it is easier to integrate patch under LGPLv3/MPL licenses then I say «LGPLv3/MPL». 30.08.2011 20:37, Tor Lillqvist пишет: Any code [patches] from me is always under normal license of LibreOffice. Unfortunately that is not quite clear enough; you need to say exactly what license(s) you mean. --tml -- Best Regards, Dmitry attachment: dmitry_ashkadov.vcf___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use a custom string to make numbering more flexible
Hi Mohammad, On Tuesday, 2011-08-30 20:24:18 +0430, Mohammad Elahi wrote: How is this made persistent, i.e. stored in a document? It is not persistent yet. I think docx has the property appropriate to use for making it persistent, but I know no such a property in odt, it needs addition of some standards in odt. But odt is a standard, can I add any property to it? That would have to be proposed to the OASIS ODF TC for inclusion. You'd have to find a TC member who works with you on the proposal and submits it to the TC. Currently that could be Kohei for LibO. See also http://www.oasis-open.org/committees/tc_home.php?wg_abbrev=office#other Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] ccache support
On Tue, Aug 30, 2011 at 12:56:50PM -0500, Norbert Thiebaud wrote: On Tue, Aug 30, 2011 at 12:16 PM, Francois Tigeot ftig...@wolfpond.org wrote: Still, this ccache stuff is too clever for its own good IMHO. for reference here is the motivations that lead me to do it [Snip all sorts of good reasons] Well, don't be bothered too much by what I said, sometimes there aren't perfect solutions -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] BUG 36594
Hi Jenei,
On Tuesday, 2011-08-30 18:33:55 +0200, Jenei Gábor wrote:
I made your recommended changes, but the querycomposer class seems
to be modified since I last worked on this issu, as unfortunatelly
it deletes all the linefeeds in the query string, so I cannot make
it work.
Are you sure that wasn't my change that skipped the LFs? I may have
misremembered the original delComment, I thought that inserted LFs for
each comment.
Now I could store in a second vector whether one line is
just empty(it only contains a comment)
Instead, I'd use
struct QueryComment
{
sal_Int32 nPos;
rtl::OUString aComment;
};
typedef ::std::vector QueryComment QueryCommentVector;
and use nPos as an index into the original query where the comment
started. That way it can be reconstructed easily.
, or it contains query string,
so then I iterate on this vector, and try to reconstruct my query
with comments. Actually I've already checked that my delComment
function works ok, it leaves the linefeeds on their place, so
something else must go wrong.
Then that's my change, it skipped the LFs, just change the place where
append() is called and add 1 to the length to be appended.
Eike
--
PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Build break when generating RDBs
[ build ALL ] top level modules: i18npool
[ build ALL ] loaded modules: i18npool
[ build RDB ] i18npool_test_breakiterator
awk: cmd. line:1: $R/^\?xml version.*$R/ { next; } {
gsub($R/vnd.sun.star.expand:\$OOO_BASE_DIR\$R/program$R/,
vnd.sun.star.expand:$OOO_BASE_DIR,$0);
gsub($R/vnd.sun.star.expand:\$BRAND_BASE_DIR\$R/program$R/,
vnd.sun.star.expand:$BRAND_BASE_DIR,$0); print; }
awk: cmd. line:1:^ syntax error
awk: cmd. line:1: $R/^\?xml version.*$R/ { next; } {
gsub($R/vnd.sun.star.expand:\$OOO_BASE_DIR\$R/program$R/,
vnd.sun.star.expand:$OOO_BASE_DIR,$0);
gsub($R/vnd.sun.star.expand:\$BRAND_BASE_DIR\$R/program$R/,
vnd.sun.star.expand:$BRAND_BASE_DIR,$0); print; }
awk: cmd. line:1: ^ backslash not last character on line
make: ***
[/libreoffice/workdir/unxlngx6.pro/RdbTarget/i18npool_test_breakiterator.rdb]
Error 1
I'm getting the above build error which seems to be caused by $R being
added to the awk regex expression by gb_Helper_abbreviate_dirs.
The below patch makes the above error go away but it is replaced by
another one.
[ build ALL ] top level modules: i18npool
[ build ALL ] loaded modules: i18npool
[ build CUT ] i18npool_test_breakiterator
/bin/sh: line 1: 26578 Aborted LD_LIBRARY_PATH=$O$R/lib
STAR_RESOURCEPATH=$O$R/bin$R/ $O$R/bin$R/cppunit$R/cppunittester
$W$R/LinkTarget$R/CppunitTest$R/libtest_i18npool_test_breakiterator.so
--headless --invisible -env:UNO_TYPES= file:$R/$R/$O$R/bin$R/udkapi.rdb
file:$R/$R/$O$R/bin$R/types.rdb
-env:UNO_SERVICES=file:$R/$R/$O$R/xml$R/ure$R/services.rdb
file:$R/$R/$W$R/RdbTarget$R/i18npool_test_breakiterator.rdb
-env:URE_INTERNAL_LIB_DIR=file:$R/$R/$O$R/lib
-env:OOO_BASE_DIR=file:$R/$R/$O$R/lib -env:BRAND_BASE_DIR=file:$R/$R/$O$R/lib
$W$R/CppunitTest$R/i18npool_test_breakiterator.test.log 21
terminate called after throwing an instance of
'com::sun::star::loader::CannotActivateFactoryException'
make: ***
[/libreoffice/workdir/unxlngx6.pro/CppunitTest/i18npool_test_breakiterator.test]
Error 1
diff --git a/solenv/gbuild/RdbTarget.mk b/solenv/gbuild/RdbTarget.mk
index 904ebcf..13b7a81 100644
--- a/solenv/gbuild/RdbTarget.mk
+++ b/solenv/gbuild/RdbTarget.mk
@@ -30,7 +30,7 @@ gb_RdbTarget__get_old_component_target =
$(OUTDIR)/xml/$(1).component
$(call gb_RdbTarget_get_target,%) :
$(call gb_Output_announce,$*,$(true),RDB,1)
- $(call gb_Helper_abbreviate_dirs,\
+ $(subst $$R,,$(call gb_Helper_abbreviate_dirs,\
mkdir -p $(dir $@) \
echo '?xml version=1.0?components
xmlns=http://openoffice.org/2010/uno-components;' $@ \
$(gb_AWK) -- \
@@ -39,7 +39,7 @@ $(call gb_RdbTarget_get_target,%) :
$(foreach component,$(COMPONENTS),$(call
gb_ComponentTarget_get_target,$(component))) \
$(foreach component,$(OLD_COMPONENTS),$(call
gb_RdbTarget__get_old_component_target,$(component))) \
$@ \
- echo '/components' $@)
+ echo '/components' $@))
.PHONY : $(call gb_RdbTarget_get_clean_target,%)
$(call gb_RdbTarget_get_clean_target,%) :
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use a custom string to make numbering more flexible
Hi Kohei I was trying to make outline numbering in libreoffice more flexible by using a string to format numbers based on it. To use some escaped strings to represend number from different levels. maybe something like %0 for level 1 number and so on; But ODT standard lacks support for such a field. I would like to know how a new property such as num-prefix can be included in ODT standard? How is this made persistent, i.e. stored in a document? It is not persistent yet. I think docx has the property appropriate to use for making it persistent, but I know no such a property in odt, it needs addition of some standards in odt. But odt is a standard, can I add any property to it? That would have to be proposed to the OASIS ODF TC for inclusion. You'd have to find a TC member who works with you on the proposal and submits it to the TC. Currently that could be Kohei for LibO. Eike Thanks. -Elahi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] Fixing layout breakage in pivot table dialog
Hi there,
I'd like to have
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8bf60230255e0e8da66cafff578f148858cee4ca
cherry-picked to the 3.4 branch. A patch for this commit is attached as
well for convenience.
This fixes a slight layout problem in the main pivot table dialog, where
the text Drag the fields from the right into the desired position
appeared overlapping the row and data field areas on Windows XP. This
commit fixes it. On platforms other than Windows XP there is no such
issue.
Apparently our dialogs get vertically compressed on Windows XP (for
whatever reason). And because the size and position of the
page/row/column/data field areas are absolute, this caused the layout
breakage on XP.
Review sign-off appreciated.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
From 83c6787d538e556d4410bf96d41e36a7a7d58e7d Mon Sep 17 00:00:00 2001
From: Kohei Yoshida kohei.yosh...@suse.com
Date: Tue, 30 Aug 2011 13:11:47 -0400
Subject: [PATCH] Adjust the dialog size to make sure the bottom text is visible.
This ensures that the bottom text Drag the fields from ... is
visible on all platforms. Previously this text overlapped with
the data and row field windows on Windows XP.
---
sc/source/ui/dbgui/dpuiglobal.hxx |1 +
sc/source/ui/dbgui/pvlaydlg.cxx | 67 +
sc/source/ui/inc/pvlaydlg.hxx |1 +
3 files changed, 69 insertions(+), 0 deletions(-)
diff --git a/sc/source/ui/dbgui/dpuiglobal.hxx b/sc/source/ui/dbgui/dpuiglobal.hxx
index d27d827..d112580 100644
--- a/sc/source/ui/dbgui/dpuiglobal.hxx
+++ b/sc/source/ui/dbgui/dpuiglobal.hxx
@@ -36,6 +36,7 @@
#define FIELD_BTN_HEIGHT23
#define SELECT_FIELD_BTN_SPACE 2
#define FIELD_AREA_GAP 3 // gap between row/column/data/page areas
+#define TEXT_INFO_GAP5 // gap between the row/data areas and the text notice below.
#endif
diff --git a/sc/source/ui/dbgui/pvlaydlg.cxx b/sc/source/ui/dbgui/pvlaydlg.cxx
index 6616595..475c0ce 100644
--- a/sc/source/ui/dbgui/pvlaydlg.cxx
+++ b/sc/source/ui/dbgui/pvlaydlg.cxx
@@ -1345,6 +1345,73 @@ void ScDPLayoutDlg::CalcWndSizes()
aWndCol.CalcSize();
aWndData.CalcSize();
aWndSelect.CalcSize();
+
+AdjustDlgSize();
+}
+
+namespace {
+
+class MoveWndDown : public std::unary_functionWindow*, void
+{
+long mnDelta;
+public:
+MoveWndDown(long nDelta) : mnDelta(nDelta) {}
+void operator() (Window* p) const
+{
+Point aPos = p-GetPosPixel();
+aPos.Y() += mnDelta;
+p-SetPosPixel(aPos);
+}
+};
+
+}
+
+void ScDPLayoutDlg::AdjustDlgSize()
+{
+// On some platforms such as Windows XP, the dialog is not large enough to
+// show the 'Drag the fields from the right...' text at the bottom. Check
+// if it overlaps, and if it does, make the dialog size larger.
+Size aWndSize = GetSizePixel();
+
+Point aPosText = aFtInfo.GetPosPixel();
+Size aSizeText = aFtInfo.GetSizePixel();
+long nYRef = aWndData.GetPosPixel().Y() + aWndData.GetSizePixel().Height();
+if (aPosText.Y() nYRef)
+// This text is visible. No need to adjust.
+return;
+
+// Calculate the extra height necessary.
+long nBottomMargin = aWndSize.Height() - (aPosText.Y() + aSizeText.Height());
+long nHeightNeeded = nYRef + TEXT_INFO_GAP + aSizeText.Height() + nBottomMargin;
+long nDelta = nHeightNeeded - aWndSize.Height();
+if (nDelta = 0)
+// This should never happen but just in case
+return;
+
+// Make the main dialog taller.
+aWndSize.Height() += nDelta;
+SetSizePixel(aWndSize);
+
+// Move the relevant controls downward.
+std::vectorWindow* aWndToMove;
+aWndToMove.reserve(16);
+aWndToMove.push_back(aFtInfo);
+aWndToMove.push_back(aBtnMore);
+aWndToMove.push_back(aFlAreas);
+aWndToMove.push_back(aFtInArea);
+aWndToMove.push_back(aEdInPos);
+aWndToMove.push_back(aRbInPos);
+aWndToMove.push_back(aFtOutArea);
+aWndToMove.push_back(aLbOutPos);
+aWndToMove.push_back(aEdOutPos);
+aWndToMove.push_back(aRbOutPos);
+aWndToMove.push_back(aBtnIgnEmptyRows);
+aWndToMove.push_back(aBtnDetectCat);
+aWndToMove.push_back(aBtnTotalCol);
+aWndToMove.push_back(aBtnTotalRow);
+aWndToMove.push_back(aBtnFilter);
+aWndToMove.push_back(aBtnDrillDown);
+std::for_each(aWndToMove.begin(), aWndToMove.end(), MoveWndDown(nDelta));
}
namespace {
diff --git a/sc/source/ui/inc/pvlaydlg.hxx b/sc/source/ui/inc/pvlaydlg.hxx
index 875f25d..3ffcd64 100644
--- a/sc/source/ui/inc/pvlaydlg.hxx
+++ b/sc/source/ui/inc/pvlaydlg.hxx
@@ -196,6 +196,7 @@ private:
voidInitFocus ();
voidInitFields ();
voidCalcWndSizes();
+voidAdjustDlgSize();
Point DlgPos2WndPos ( const Point rPt, Window rWnd );
ScDPLabelData* GetLabelData
[Libreoffice] Need help to generate patch with git
Hi all, I'm still learning to use git and need some help. I have made a patch for issue 34431. But after I used the 'commit' command I noticed, that I had to change a file, which needs another 'commit'. Now the command 'format-patch' has produced two files, one for each commit. Is there a way, to get _one_ patch file? I want to use the same build to work on a different problem (Getting non-filled line end markers). How can I do that, so that later on, a 'format-patch' will generate only the new changes and not those for issue 34431 too? The current build process takes over 18 hours because parallelism not possible with make 3.8.1 in Cygwin. So I want to avoid to make a complete new clone and build. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Bug 34431 - More symbols (crosses, circles) needed for data points in charts
Hi, I have attached a patch to issue https://bugs.freedesktop.org/show_bug.cgi?id=34431, so that you can have a look at it and comment. I cannot test import/export with xlsx format because of crash in LO3.5daily. https://bugs.freedesktop.org/show_bug.cgi?id=40466. So perhaps pushing should be postponed until the crash is fixed? Do you agree with the mapping? You can also look at http://wiki.documentfoundation.org/User:Regina/DraftAdditionalSymbolsInCharts Do I have found all places where changes are needed? Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Hackers/Users-meeting 10 September, Eindhoven, The Netherlands
Hi All, On the 10th of September we are organising a Hackers/Users-meeting for LibreOffice and OpenOffice.org. The meeting is at MADlab in Eindhoven, The Netherlands. The meeting will begin at 10 o'clock. For more information see http://wiki.documentfoundation.org/NL/bijeenkomst_11-09-10 or email me. -- Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Update of AutoText numbered formula
Thank you for your answer. Caolán McNamara wrote: attaching the replacements (or git binary patch I suppose) to a bug against libreoffice at https://bugs.freedesktop.org/ would work in the interim. I opened bug 40499 https://bugs.freedesktop.org/show_bug.cgi?id=40499 and added each standard.bau as attachment. I could not proceed for bg locale, because 7-zip told me that files were corrupted. Could a bg locale user make the modification? Hope it could help. Laurent BP - LibreOffice 3.3.2 -- View this message in context: http://nabble.documentfoundation.org/Update-of-AutoText-numbered-formula-tp3293296p3296866.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Bug 34431 - More symbols (crosses, circles) needed for data points in charts
Hi Regina, I had the same problem with a patch recently. Did you find a solution? Josh On Wed, Aug 31, 2011 at 7:01 AM, Regina Henschel rb.hensc...@t-online.de wrote: Hi, I have attached a patch to issue https://bugs.freedesktop.org/show_bug.cgi?id=34431, so that you can have a look at it and comment. I cannot test import/export with xlsx format because of crash in LO3.5daily. https://bugs.freedesktop.org/show_bug.cgi?id=40466. So perhaps pushing should be postponed until the crash is fixed? Do you agree with the mapping? You can also look at http://wiki.documentfoundation.org/User:Regina/DraftAdditionalSymbolsInCharts Do I have found all places where changes are needed? Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Need help to generate patch with git
Hi Regina, I'm still learning to use git and need some help. I have made a patch for issue 34431. But after I used the 'commit' command I noticed, that I had to change a file, which needs another 'commit'. Now the command 'format-patch' has produced two files, one for each commit. Is there a way, to get _one_ patch file? I had the same problem with a patch recently. Did you find a solution? Sorry I asked the same question on a different thread - my mistake. Josh. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Need help to generate patch with git
On Tue, Aug 30, 2011 at 11:29:09PM +0200, Regina Henschel wrote: Hi all, I'm still learning to use git and need some help. I have made a patch for issue 34431. But after I used the 'commit' command I noticed, that I had to change a file, which needs another 'commit'. Now the command 'format-patch' has produced two files, one for each commit. Is there a way, to get _one_ patch file? For the second commit use `git commit --ammend`. Regards, Khaled -- Khaled Hosny Egyptian Arab ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Need help to generate patch with git
Hi Khaled, On Wednesday, 2011-08-31 02:05:10 +0200, Khaled Hosny wrote: Now the command 'format-patch' has produced two files, one for each commit. Is there a way, to get _one_ patch file? For the second commit use `git commit --ammend`. That works only on tip though to replace the current top commit. Or did I miss something? Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Need help to generate patch with git
Hi Regina, On Tue, 2011-08-30 at 23:29 +0200, Regina Henschel wrote: Hi all, I'm still learning to use git and need some help. I have made a patch for issue 34431. But after I used the 'commit' command I noticed, that I had to change a file, which needs another 'commit'. Now the command 'format-patch' has produced two files, one for each commit. Is there a way, to get _one_ patch file? Yes. You can use git rebase --interactive for that (or git rebase -i for short). It allows you to combine several of your local commits into a single commit. But be warned that this command is a bit hard to use and can screw with your commits when used incorrectly. So I recommend you have some practice runs to get comfortable with it first. That said, this is an indispensable command that I personally use all the time to combine several of my local commits before pushing. So it's worth spending some time to learn this command. I want to use the same build to work on a different problem (Getting non-filled line end markers). How can I do that, so that later on, a 'format-patch' will generate only the new changes and not those for issue 34431 too? What I recommend is that you create a separate branch for each problem to solve. Switching between branches is pretty fast with git, so that's another technique you can learn with git. You can easily delete branches after you are done. Creation and deletion of branches with git are very cheap, so I recommend you learn how to make effective use of git's branches. HTH, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kohei.yosh...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Need help to generate patch with git
On Wed, Aug 31, 2011 at 03:11:58AM +0200, Eike Rathke wrote: Hi Khaled, On Wednesday, 2011-08-31 02:05:10 +0200, Khaled Hosny wrote: Now the command 'format-patch' has produced two files, one for each commit. Is there a way, to get _one_ patch file? For the second commit use `git commit --ammend`. That works only on tip though to replace the current top commit. Or did I miss something? `git rebase` is your friend: http://help.github.com/rebase/ Regards, Khaled -- Khaled Hosny Egyptian Arab signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] [PUSHED] (was: Re: buglet in 1ec7b6a4 (?))
Hi Stephan, On Mon, 2011-08-29 at 12:08 +0200, Stephan Bergmann wrote: http://cgit.freedesktop.org/libreoffice/core/commit/autogen.sh?id=3ea37ac7005c64f378756a5dbc3fbfbc3bf8b053 does not fix this for the one-argument case, however, due to an error introduced in http://cgit.freedesktop.org/libreoffice/core/commit/autogen.sh?id=c0b9fdfbbaa46e984dbe6ea9e7f5adc943b9f248. Attached patch would fix that. Thanks. Just pushed to master. BTW, I believe this is your first commit to LibreOffice I believe (aside from your numerous commits to the OOo code base that is)? Can I ask you to confirm that your patch is under LGPLv3+/MPL 1.1 ? Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kohei.yosh...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fix pushed to the 3-4 branch
JYI, I cherry-picked this commit by Eike http://cgit.freedesktop.org/libreoffice/core/commit/?id=61674465b74f60d7ddb2d7a0fa0e17c9990f6301 to the 3-4 branch with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kohei.yosh...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report jobs stalled... no longer! :)
On 08/29/11 19:37, Jesse Adelman wrote: Hi Julien, Replies in-line below. On 08/29/11 03:19, julien2412 wrote: Hello Jesse, Just to be sure, is the cppcheck scan on the Master or on another branch ? jesse@dell-gx620 ~/source/LibreOffice/core $ git status # On branch master nothing to commit (working directory clean) jesse@dell-gx620 ~/source/LibreOffice/core $ Do you think the machine which runs automatic cppcheck scan is stable enough to consider using the git version of cppcheck or do you want to test it more to detect other RAM pbs ? Seems stable now. I think it is likely that the previous segfaults were largely due to the hardware problems with bad RAM. But, the only way to truly know is to Just Do It(tm). I want to do one last run with the changes I made to my automation scripts to get rid of the obsolete git repos (now, just core is tested). Then, we'll jump to the Git-based cppcheck. It might take a day. I just started watching the BBC's series House of Cards and I've got a serious need to complete watching all three of the trilogy. ;) It would be really great to have the last version. Indeed! :) Julien. -- View this message in context: http://nabble.documentfoundation.org/http-libreoffice-boldandbusted-com-cppcheck-report-jobs-stalled-tp2745270p3292351.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Cheers! OK, I just bumped to git cppcheck. We'll see how this next run goes! :) -- Jesse Adelman Senior Systems Shepherd ilikelinux Consulting/Bold and Busted, LLC http://ilikelinux.com/ http://boldandbusted.com/ Brisbane, CA Tel: (415) 656-4480 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
