[Libreoffice-commits] .: sc/source
sc/source/ui/view/viewfun5.cxx |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
New commits:
commit bd8be4eae82525434454cc3c7274f7a7a44158c0
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Mar 16 10:45:01 2012 +0100
don't paste content if user cancels html import, fdo#47393
diff --git a/sc/source/ui/view/viewfun5.cxx b/sc/source/ui/view/viewfun5.cxx
index fa305a5..2456402 100644
--- a/sc/source/ui/view/viewfun5.cxx
+++ b/sc/source/ui/view/viewfun5.cxx
@@ -323,9 +323,15 @@ sal_Bool ScViewFunc::PasteDataFormat( sal_uLong nFormatId,
aOptions.SetDetectSpecialNumber(pDlg-IsDateConversionSet());
aObj.SetExtOptions(aOptions);
}
+else
+{
+// prevent error dialog for user cancel action
+bRet = true;
+}
}
+if(!bRet)
+bRet = aObj.ImportStream( *xStream, String(), nFormatId );
// mba: clipboard always must contain absolute URLs (could be
from alien source)
-bRet = aObj.ImportStream( *xStream, String(), nFormatId );
}
else if (nFormatId == FORMAT_STRING aDataHelper.GetString(
nFormatId, aStr ))
{
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - nss/makefile.mk nss/nss-asm-fix.patch nss/nss-clang_os_Linux_x86_64_s_comments.patch openssl/makefile.mk openssl/openssl-asm-fix.patch
nss/makefile.mk|4 nss/nss-asm-fix.patch | 56 + nss/nss-clang_os_Linux_x86_64_s_comments.patch | 149 + openssl/makefile.mk| 13 +- openssl/openssl-asm-fix.patch | 11 + 5 files changed, 225 insertions(+), 8 deletions(-) New commits: commit 8f29699cd1723bd8b8acc25033708f9777576d6d Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Fri Mar 16 13:05:02 2012 +0100 asm fixes in openssl diff --git a/openssl/makefile.mk b/openssl/makefile.mk index f29b567..226e86c 100644 --- a/openssl/makefile.mk +++ b/openssl/makefile.mk @@ -50,6 +50,7 @@ OPENSSL_NAME=openssl-0.9.8o TARFILE_NAME=$(OPENSSL_NAME) TARFILE_MD5=63ddc5116488985e820075e65fbe6aa4 +PATCH_FILES=openssl-asm-fix.patch CONFIGURE_DIR=. CONFIGURE_ACTION=config @@ -83,7 +84,7 @@ OUT2INC += include/openssl/* UNAME=$(shell uname) .IF $(OS) == LINUX || $(OS) == FREEBSD || $(OS) == ANDROID -PATCH_FILES=openssllnx.patch +PATCH_FILES+=openssllnx.patch ADDITIONAL_FILES:= \ libcrypto_OOo_0_9_8o.map \ libssl_OOo_0_9_8o.map @@ -107,7 +108,7 @@ UNAME=$(shell uname) .ENDIF .IF $(OS) == SOLARIS -PATCH_FILES=opensslsol.patch +PATCH_FILES+=opensslsol.patch ADDITIONAL_FILES:= \ libcrypto_OOo_0_9_8o.map \ libssl_OOo_0_9_8o.map @@ -129,7 +130,7 @@ UNAME=$(shell uname) .ENDIF .IF $(OS) == IOS -PATCH_FILES=opensslios.patch +PATCH_FILES+=opensslios.patch CONFIGURE_ACTION=Configure ios-armv7 CONFIGURE_FLAGS=no-shared no-idea .ENDIF @@ -137,7 +138,7 @@ UNAME=$(shell uname) .IF $(OS) == WNT .IF $(COM)==GCC -PATCH_FILES=opensslmingw.patch +PATCH_FILES+=opensslmingw.patch CONFIGURE_ACTION=$(PERL) Configure CONFIGURE_FLAGS=mingw shared INSTALL_ACTION=mv libcrypto.a libcrypto_static.a mv libcrypto.dll.a libcrypto.a mv libssl.a libssl_static.a mv libssl.dll.a libssl.a @@ -149,7 +150,7 @@ OUT2BIN = ssleay32.dll OUT2BIN += libeay32.dll .ELSE -PATCH_FILES=openssl.patch +PATCH_FILES+=openssl.patch .IF $(MAKETARGETS) == # The env. vars CC and PERL are used by nmake, and nmake insists on '\'s # If WRAPCMD is set it is prepended before the compiler, don't touch that. diff --git a/openssl/openssl-asm-fix.patch b/openssl/openssl-asm-fix.patch new file mode 100644 index 000..bb722be --- /dev/null +++ b/openssl/openssl-asm-fix.patch @@ -0,0 +1,11 @@ +--- misc/build/openssl-0.9.8o/crypto/md32_common.h.sav 2010-03-29 13:23:11.0 +0200 misc/build/openssl-0.9.8o/crypto/md32_common.h 2012-03-16 12:39:14.986941958 +0100 +@@ -165,7 +165,7 @@ + asm ( \ + roll %1,%0\ + : =r(ret) \ +- : I(n), 0(a)\ ++ : I(n), 0((unsigned int)(a))\ + : cc);\ + ret; \ + }) commit cb3f52275b51546b579d7856b75dca4ecf791c6a Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Fri Mar 16 13:04:22 2012 +0100 asm fixes in nss diff --git a/nss/makefile.mk b/nss/makefile.mk index ea6f5e6..2bfa920 100644 --- a/nss/makefile.mk +++ b/nss/makefile.mk @@ -48,7 +48,7 @@ VER_PATCH=8 TARFILE_NAME=nss-$(VER_MAJOR).$(VER_MINOR).$(VER_PATCH)-with-nspr-4.8.6 TARFILE_MD5=71474203939fafbe271e1263e61d083e TARFILE_ROOTDIR=nss-$(VER_MAJOR).$(VER_MINOR).$(VER_PATCH) -PATCH_FILES=nss.patch nss.aix.patch nss-config.patch nss-linux3.patch nss-clang_os_Linux_x86_s_comments.patch nss-string-concat.patch +PATCH_FILES=nss.patch nss.aix.patch nss-config.patch nss-linux3.patch nss-clang_os_Linux_x86_s_comments.patch nss-clang_os_Linux_x86_64_s_comments.patch nss-string-concat.patch nss-asm-fix.patch .IF $(OS)==MACOSX PATCH_FILES+=nss_macosx.patch diff --git a/nss/nss-asm-fix.patch b/nss/nss-asm-fix.patch new file mode 100644 index 000..b45e179 --- /dev/null +++ b/nss/nss-asm-fix.patch @@ -0,0 +1,56 @@ +--- misc/build/nss-3.12.8/mozilla/security/nss/lib/freebl/mpi/mp_comba.c.sav 2012-03-16 12:30:23.255942001 +0100 misc/build/nss-3.12.8/mozilla/security/nss/lib/freebl/mpi/mp_comba.c 2012-03-16 12:29:01.730170001 +0100 +@@ -49,7 +49,7 @@ __asm__ ( + addq %%rax,%0 \n\t\ + adcq %%rdx,%1 \n\t\ + adcq $0,%2\n\t\ +- :=r(c0), =r(c1), =r(c2): 0(c0), 1(c1), 2(c2), g(i), g(j) :%rax,%rdx,%cc); ++ :=r(c0), =r(c1), =r(c2): 0(c0), 1(c1), 2(c2), g(i), g(j) :%rax,%rdx,cc); + + + +@@ -76,7 +76,7 @@ __asm__ ( + addq %%rax,%0 \n\t\ + adcq %%rdx,%1 \n\t\ + adcq $0,%2\n\t
[Libreoffice-commits] .: 4 commits - sc/inc sc/source
sc/inc/dpcache.hxx |2 -
sc/source/core/data/dpcache.cxx | 44 +++
sc/source/core/data/dpcachetable.cxx | 17 +++--
3 files changed, 9 insertions(+), 54 deletions(-)
New commits:
commit 357059019541c36e5eb0bc3c98d5ed2f12d41371
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Mar 16 09:35:40 2012 -0400
Prevent out-of-bound array access.
Source range may not start from column 0.
diff --git a/sc/source/core/data/dpcache.cxx b/sc/source/core/data/dpcache.cxx
index 70c..3e5b433 100644
--- a/sc/source/core/data/dpcache.cxx
+++ b/sc/source/core/data/dpcache.cxx
@@ -370,7 +370,7 @@ bool ScDPCache::InitFromDoc(ScDocument* pDoc, const
ScRange rRange)
for (sal_uInt16 nCol = nStartCol; nCol = nEndCol; ++nCol)
{
AddLabel(createLabelString(pDoc, nCol, nStartRow, nDocTab));
-Field rField = maFields[nCol];
+Field rField = maFields[nCol-nStartCol];
std::vectorBucket aBuckets;
aBuckets.reserve(nEndRow-nStartRow); // skip the topmost label cell.
commit b41cf4c6153e9c4f7f56d0441a649664ffd4c7c2
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Mar 16 00:00:59 2012 -0400
We shouldn't skip empty columns, or else column index becomes out of sync.
diff --git a/sc/source/core/data/dpcachetable.cxx
b/sc/source/core/data/dpcachetable.cxx
index 4b7338f..dc7a63a 100644
--- a/sc/source/core/data/dpcachetable.cxx
+++ b/sc/source/core/data/dpcachetable.cxx
@@ -161,6 +161,7 @@ void ScDPCacheTable::fillTable(
// Data rows
for (SCCOL nCol = 0; nCol nColCount; ++nCol)
{
+maFieldEntries.push_back( vectorSCROW() );
SCROW nMemCount = getCache()-GetDimMemberCount( nCol );
if ( nMemCount )
{
@@ -188,7 +189,6 @@ void ScDPCacheTable::fillTable(
aAdded[nOrder] = nIndex;
}
-maFieldEntries.push_back( vectorSCROW() );
for ( SCROW nRow = 0; nRow nMemCount; nRow++ )
{
if ( aAdded[nRow] != -1 )
@@ -216,6 +216,7 @@ void ScDPCacheTable::fillTable()
// Data rows
for (SCCOL nCol = 0; nCol nColCount; ++nCol)
{
+maFieldEntries.push_back( vectorSCROW() );
SCROW nMemCount = getCache()-GetDimMemberCount( nCol );
if ( nMemCount )
{
@@ -234,7 +235,6 @@ void ScDPCacheTable::fillTable()
pAdded[nOrder] = nIndex;
}
-maFieldEntries.push_back( vectorSCROW() );
for ( SCROW nRow = 0; nRow nMemCount; nRow++ )
{
if ( pAdded[nRow] != -1 )
commit 9776cc1503690e4ccb0dd1d8d6cf6c35d5c8f01d
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Mar 15 23:40:12 2012 -0400
Check all this in one place i.e. in ValidQuery().
diff --git a/sc/source/core/data/dpcache.cxx b/sc/source/core/data/dpcache.cxx
index 40ca039..70c 100644
--- a/sc/source/core/data/dpcache.cxx
+++ b/sc/source/core/data/dpcache.cxx
@@ -471,8 +471,12 @@ bool ScDPCache::InitFromDataBase (const
Referencesdbc::XRowSet xRowSet, const
bool ScDPCache::ValidQuery( SCROW nRow, const ScQueryParam rParam) const
{
+if (!rParam.GetEntryCount())
+return true;
+
if (!rParam.GetEntry(0).bDoQuery)
return true;
+
bool bMatchWholeCell = mpDoc-GetDocOptions().IsMatchWholeCell();
SCSIZE nEntryCount = rParam.GetEntryCount();
diff --git a/sc/source/core/data/dpcachetable.cxx
b/sc/source/core/data/dpcachetable.cxx
index c32d079..4b7338f 100644
--- a/sc/source/core/data/dpcachetable.cxx
+++ b/sc/source/core/data/dpcachetable.cxx
@@ -64,15 +64,6 @@ using ::com::sun::star::uno::UNO_QUERY;
using ::com::sun::star::uno::UNO_QUERY_THROW;
using ::com::sun::star::sheet::DataPilotFieldFilter;
-
-static sal_Bool lcl_HasQueryEntry( const ScQueryParam rParam )
-{
-return rParam.GetEntryCount() 0
-rParam.GetEntry(0).bDoQuery;
-}
-
-//
-
bool ScDPCacheTable::RowFlag::isActive() const
{
return mbShowByFilter mbShowByPage;
@@ -186,9 +177,9 @@ void ScDPCacheTable::fillTable(
maRowFlags.back().mbShowByFilter = false;
}
-if ( lcl_HasQueryEntry(rQuery)
-!getCache()-ValidQuery(nRow , rQuery) )
+if (!getCache()-ValidQuery(nRow, rQuery))
continue;
+
if ( bIgnoreEmptyRows getCache()-IsRowEmpty( nRow ) )
continue;
commit efdb67ca924dc0072c6984a68c9b97db260464b6
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Thu Mar 15 23:32:34 2012 -0400
We don't ever compare equality of two caches.
That'd be super-expensive anyway.
diff --git a/sc/inc/dpcache.hxx b/sc/inc/dpcache.hxx
index 1e26688..bd2fa5a 100644
--- a/sc/inc/dpcache.hxx
+++ b/sc/inc/dpcache.hxx
@@ -152,8 +152,6 @@ public:
const
[Libreoffice-commits] .: sw/source
sw/source/core/layout/dumpfilter.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 1a6b52a1bfc184524fc63d4a9d0b51055bf9af23 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Mar 16 14:24:22 2012 +0100 add indentation to sw's layout dumper diff --git a/sw/source/core/layout/dumpfilter.cxx b/sw/source/core/layout/dumpfilter.cxx index b5ee4ee..75c2f0e 100644 --- a/sw/source/core/layout/dumpfilter.cxx +++ b/sw/source/core/layout/dumpfilter.cxx @@ -146,6 +146,7 @@ namespace sw writeCallback, closeCallback, ( void* ) xOut.get(), NULL ); xmlTextWriterPtr writer = xmlNewTextWriter( outBuffer ); +xmlTextWriterSetIndent(writer, 1); xmlTextWriterStartDocument( writer, NULL, NULL, NULL ); // TODO This doesn't export the whole XML file, whereas dumpAsXML() does it nicely ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - cui/source desktop/source embeddedobj/source extensions/source filter/source framework/source odk/examples offapi/com sfx2/Library_sfx.mk sfx2/source shell/source
cui/source/dialogs/SpellDialog.cxx|2
cui/source/dialogs/about.cxx |2
cui/source/options/optlingu.cxx |2
desktop/source/deployment/gui/dp_gui_dialog2.cxx |2
desktop/source/deployment/gui/dp_gui_updatedialog.cxx |2
embeddedobj/source/msole/oleembed.cxx |2
extensions/source/update/check/updatecheck.cxx|2
filter/source/xsltdialog/xmlfiltertestdialog.cxx |2
framework/source/dispatch/mailtodispatcher.cxx|2
framework/source/dispatch/systemexec.cxx |2
framework/source/services/backingwindow.cxx |2
odk/examples/cpp/complextoolbarcontrols/MyProtocolHandler.cxx |2
offapi/com/sun/star/system/SystemShellExecuteFlags.idl|6
offapi/com/sun/star/system/XSystemShellExecute.idl|6
sfx2/Library_sfx.mk |1
sfx2/source/appl/app.hrc |2
sfx2/source/appl/app.src |7
sfx2/source/appl/appopen.cxx | 195 +++---
sfx2/source/appl/appserv.cxx |4
sfx2/source/appl/openuriexternally.cxx| 101 +
sfx2/source/appl/sfxhelp.cxx |2
sfx2/source/inc/openuriexternally.hxx | 57 ++
sfx2/source/view/view.hrc |2
sfx2/source/view/view.src | 18
sfx2/source/view/viewsh.cxx | 27 -
shell/source/unix/exec/shellexec.cxx | 44 ++
shell/source/win32/SysShExec.cxx | 26 +
shell/source/win32/SysShExec.hxx |6
shell/source/win32/SysShentry.cxx | 13
svtools/source/contnr/templwin.cxx|2
svtools/source/misc/templatefoldercache.cxx | 11
sw/source/ui/docvw/extedit.cxx|2
sw/source/ui/lingu/olmenu.cxx |2
swext/mediawiki/src/com/sun/star/wiki/Helper.java |2
toolkit/source/awt/vclxwindows.cxx|2
uui/source/newerverwarn.cxx |2
36 files changed, 362 insertions(+), 202 deletions(-)
New commits:
commit 32a5ad89a505be22fb8ca0b990a8991a7de6453a
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Mar 16 14:57:51 2012 +0100
fdo#37593 Make sure needsUpdate compares canonicalized paths
...so that it does not erroneously always claim an update is needed, so that
SvtDocumentTemplateDialog::UpdateHdl_Impl does not always jump back to
OpenTemplateRoot() shortly after opening the dialog (and thus jumps away
from
the last remembered folder).
diff --git a/svtools/source/misc/templatefoldercache.cxx
b/svtools/source/misc/templatefoldercache.cxx
index d7a5679..1486fb2 100644
--- a/svtools/source/misc/templatefoldercache.cxx
+++ b/svtools/source/misc/templatefoldercache.cxx
@@ -693,6 +693,17 @@ namespace svt
{
String sTemplatePath( aDirs.getToken(0, ';', nIndex) );
sTemplatePath = aPathOptions.ExpandMacros( sTemplatePath );
+
+// Make sure excess .. path segments (from expanding bootstrap
+// variables in paths) are normalized in the same way they are
+// normalized for paths read from the .templdir.cache file (where
+// paths have gone through makeRelocatable URL on writing out and
+// then through makeAbsoluteURL when reading back in), as otherwise
+// equalStates() in needsUpdate() could erroneously consider
+// m_aCurrentState and m_aPreviousState as different:
+sTemplatePath = getOfficeInstDirs()-makeAbsoluteURL(
+getOfficeInstDirs()-makeRelocatableURL(sTemplatePath));
+
// create a new entry
m_aCurrentState.push_back( new TemplateContent( INetURLObject(
sTemplatePath ) ) );
TemplateFolderContent::iterator aCurrentRoot =
m_aCurrentState.end();
commit d4b67611c421ebe9b75284106fe389b434419961
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Mar 16 11:16:14 2012 +0100
Introduced SystemShellExecuteFlags::URIS_ONLY
diff --git a/cui/source/dialogs/SpellDialog.cxx
b/cui/source/dialogs/SpellDialog.cxx
index 21ab29c..570e7eb 100644
--- a/cui/source/dialogs/SpellDialog.cxx
+++ b/cui/source/dialogs/SpellDialog.cxx
@@ -2146,7 +2146,7 @@ IMPL_LINK( SpellDialog, HandleHyperlink,
svt::FixedHyperlink*, pHyperlink )
uno::Reference com::sun::star::system::XSystemShellExecute
[Libreoffice-commits] .: libcdr/libcdr-0.0.4.patch libcdr/libcdr-0.0.5.patch libcdr/makefile.mk libcdr/prj ooo.lst.in
libcdr/libcdr-0.0.4.patch | 20 libcdr/libcdr-0.0.5.patch | 20 libcdr/makefile.mk|4 ++-- libcdr/prj/d.lst |1 + ooo.lst.in|2 +- 5 files changed, 24 insertions(+), 23 deletions(-) New commits: commit 06427dfad309bec7aad2c60ed7c21ae9c814b403 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Fri Mar 16 15:33:21 2012 +0100 Uploading libcdr-0.0.5 diff --git a/libcdr/libcdr-0.0.4.patch b/libcdr/libcdr-0.0.4.patch deleted file mode 100644 index 9e9079d..000 --- a/libcdr/libcdr-0.0.4.patch +++ /dev/null @@ -1,20 +0,0 @@ misc/libcdr-0.0.4/src/lib/libcdr_utils.h 2012-03-07 13:51:21.0 +0100 -+++ misc/build/libcdr-0.0.4/src/lib/libcdr_utils.h 2012-03-08 12:46:38.194534604 +0100 -@@ -54,17 +54,8 @@ - - #else - --#ifdef HAVE_CONFIG_H --#include config.h --#endif -- --#ifdef HAVE_STDINT_H - #include stdint.h --#endif -- --#ifdef HAVE_INTTYPES_H - #include inttypes.h --#endif - - #endif - diff --git a/libcdr/libcdr-0.0.5.patch b/libcdr/libcdr-0.0.5.patch new file mode 100644 index 000..b622bd6 --- /dev/null +++ b/libcdr/libcdr-0.0.5.patch @@ -0,0 +1,20 @@ +--- misc/libcdr-0.0.5/src/lib/libcdr_utils.h 2012-03-07 13:51:21.0 +0100 misc/build/libcdr-0.0.5/src/lib/libcdr_utils.h 2012-03-08 12:46:38.194534604 +0100 +@@ -54,17 +54,8 @@ + + #else + +-#ifdef HAVE_CONFIG_H +-#include config.h +-#endif +- +-#ifdef HAVE_STDINT_H + #include stdint.h +-#endif +- +-#ifdef HAVE_INTTYPES_H + #include inttypes.h +-#endif + + #endif + diff --git a/libcdr/makefile.mk b/libcdr/makefile.mk index 30ffd2f..475fb2c 100644 --- a/libcdr/makefile.mk +++ b/libcdr/makefile.mk @@ -59,8 +59,8 @@ INCPRE+=$(LCMS2_CFLAGS) INCPRE+=$(SOLARVER)$/$(INPATH)$/inc$/lcms2 .ENDIF -TARFILE_NAME=libcdr-0.0.4 -TARFILE_MD5=b99553516040a6f9d5885db56e8ca79f +TARFILE_NAME=libcdr-0.0.5 +TARFILE_MD5=4def42cfe3527ed7c515bea8cc3f23b8 PATCH_FILES=\ $(TARFILE_NAME).patch diff --git a/libcdr/prj/d.lst b/libcdr/prj/d.lst index f74aa63..e3ec3bd 100644 --- a/libcdr/prj/d.lst +++ b/libcdr/prj/d.lst @@ -2,5 +2,6 @@ mkdir: %_DEST%\inc\libcdr ..\%__SRC%\misc\build\libcdr*\src\lib\libcdr.h %_DEST%\inc\libcdr ..\%__SRC%\misc\build\libcdr*\src\lib\CDRDocument.h %_DEST%\inc\libcdr\ ..\%__SRC%\misc\build\libcdr*\src\lib\CDRStringVector.h %_DEST%\inc\libcdr\ +..\%__SRC%\misc\build\libcdr*\src\lib\CMXDocument.h %_DEST%\inc\libcdr\ ..\%__SRC%\lib\*.a %_DEST%\lib\*.a ..\%__SRC%\slb\*.lib %_DEST%\lib\*.lib diff --git a/ooo.lst.in b/ooo.lst.in index a57cc20..5de0e5a 100644 --- a/ooo.lst.in +++ b/ooo.lst.in @@ -90,7 +90,7 @@ f02578f5218f217a9f20e9c30e119c6a-boost_1_44_0.tar.bz2 d28864eb2b59bb57b034c0d4662a3cee-libvisio-0.0.15.tar.bz2 e7a384790b13c29113e22e596ade9687-LinLibertineG-20120116.zip 7c2549f6b0a8bb604e6c4c729ffdcfe6-libcmis-0.1.0.tar.gz -b99553516040a6f9d5885db56e8ca79f-libcdr-0.0.4.tar.bz2 +4def42cfe3527ed7c515bea8cc3f23b8-libcdr-0.0.5.tar.bz2 327348d67c979c88c2dec59a23a17d85-lcms2-2.3.tar.gz @GOOGLE_DOCS_EXTENSION_PACK@ @FREETYPE_TARBALL@ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - solenv/gbuild sw/source
solenv/gbuild/platform/WNT_INTEL_MSC.mk | 18 ++---
sw/source/core/layout/paintfrm.cxx | 44
2 files changed, 42 insertions(+), 20 deletions(-)
New commits:
commit 804d0a896731629397c5328c13c04a45bc55f459
Author: Michael Stahl mst...@redhat.com
Date: Fri Mar 16 15:35:49 2012 +0100
fdo#42750: delay painting borders until after subsidiary lines
With commit 0f0896c26fb260d1bbf31d7a886df3f61837f0f2, borders are drawn
immediately, but then the subsidiary lines are drawn over the borders,
hiding 1 twip wide borders completely.
diff --git a/sw/source/core/layout/paintfrm.cxx
b/sw/source/core/layout/paintfrm.cxx
index dac3e27..958e279 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -119,6 +119,7 @@
#include drawinglayer/primitive2d/textlayoutdevice.hxx
#include svx/sdr/contact/objectcontacttools.hxx
#include svx/unoapi.hxx
+#include comphelper/sequenceasvector.hxx
#include basegfx/matrix/b2dhommatrix.hxx
#include basegfx/matrix/b2dhommatrixtools.hxx
#include basegfx/polygon/b2dpolygon.hxx
@@ -219,6 +220,22 @@ public:
inline void Ins( const SwRect rRect, const sal_uInt8 nSCol );
};
+class BorderLines
+{
+::comphelper::SequenceAsVector
+ ::drawinglayer::primitive2d::Primitive2DReference m_Lines;
+public:
+void AddBorderLine(
+::drawinglayer::primitive2d::Primitive2DReference const xLine)
+{
+m_Lines.push_back(xLine);
+}
+drawinglayer::primitive2d::Primitive2DSequence GetBorderLines() const
+{
+return m_Lines.getAsConstList();
+}
+};
+
//- End of classes for border lines --
static ViewShell *pGlobalShell = 0;
@@ -252,6 +269,7 @@ static double aEdgeScale = 0.5;
// be compared with pLines before the work in order to avoid help lines
// to hide borders.
// bTablines is sal_True during the Paint of a table.
+static BorderLines *g_pBorderLines = 0;
static SwLineRects *pLines = 0;
static SwSubsRects *pSubsLines = 0;
// global variable for sub-lines of body, header, footer, section and footnote
frames.
@@ -334,6 +352,7 @@ class SwSavePaintStatics
SwFlyFrm *pSRetoucheFly,
*pSRetoucheFly2,
*pSFlyOnlyDraw;
+BorderLines*pBLines;
SwLineRects*pSLines;
SwSubsRects*pSSubsLines;
SwSubsRects*pSSpecSubsLines;
@@ -359,6 +378,7 @@ SwSavePaintStatics::SwSavePaintStatics() :
pSRetoucheFly ( pRetoucheFly ),
pSRetoucheFly2 ( pRetoucheFly2 ),
pSFlyOnlyDraw ( pFlyOnlyDraw ),
+pBLines ( g_pBorderLines),
pSLines ( pLines),
pSSubsLines ( pSubsLines),
pSSpecSubsLines ( pSpecSubsLines),
@@ -383,6 +403,7 @@ SwSavePaintStatics::SwSavePaintStatics() :
aScaleX = aScaleY = 1.0;
aMinDistScale = 0.73;
aEdgeScale = 0.5;
+g_pBorderLines = 0;
pLines = 0;
pSubsLines = 0;
pSpecSubsLines = 0L;
@@ -397,6 +418,7 @@ SwSavePaintStatics::~SwSavePaintStatics()
pRetoucheFly = pSRetoucheFly;
pRetoucheFly2 = pSRetoucheFly2;
pFlyOnlyDraw = pSFlyOnlyDraw;
+g_pBorderLines = pBLines;
pLines = pSLines;
pSubsLines = pSSubsLines;
pSpecSubsLines = pSSpecSubsLines;
@@ -2889,6 +2911,7 @@ SwRootFrm::Paint(SwRect const rRect, SwPrintData
const*const pPrintData) const
pSubsLines = new SwSubsRects;
pSpecSubsLines = new SwSubsRects;
}
+g_pBorderLines = new BorderLines;
aPaintRect._Intersection( aRect );
@@ -3002,6 +3025,9 @@ SwRootFrm::Paint(SwRect const rRect, SwPrintData
const*const pPrintData) const
DELETEZ( pSubsLines );
DELETEZ( pSpecSubsLines );
}
+// fdo#42750: delay painting these until after subsidiary lines
+ProcessPrimitives(g_pBorderLines-GetBorderLines());
+DELETEZ(g_pBorderLines);
pVout-Leave();
// #i68597#
@@ -4507,11 +4533,8 @@ void lcl_PaintLeftRightLine( const sal_Bool
_bLeft,
::lcl_SubTopBottom( aRect, rBox, _rAttrs, _rFrm, _rRectFn,
bPrtOutputDev );
}
-// TODO Postpone the processing of the primitives
if ( lcl_GetLineWidth( pLeftRightBorder ) 0 )
{
-drawinglayer::primitive2d::Primitive2DSequence aSequence( 1 );
-
double nExtentIS = lcl_GetExtent( pTopBorder, NULL );
double nExtentIE = lcl_GetExtent( pBottomBorder, NULL );
double nExtentOS = lcl_GetExtent( NULL, pTopBorder );
@@ -4533,21 +4556,22 @@ void lcl_PaintLeftRightLine( const sal_Bool
_bLeft,
Color aLeftColor = _bLeft ? pLeftRightBorder-GetColorOut( _bLeft ) :
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - solenv/gbuild
solenv/gbuild/platform/WNT_INTEL_MSC.mk |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit c6246139df005d6ac4627bc8f4665539effb6e94
Author: Noel Power noel.po...@novell.com
Date: Thu Mar 8 16:01:36 2012 +
fix uno bootstrapping for .NET ( and perhaps c++ ) fdo#46832
(cherry picked from commit c3d806be7d30a437607d924a4d33f13fe20dd1ba)
Signed-off-by: Michael Stahl mst...@redhat.com
Signed-off-by: Fridrich Å trba fridrich.st...@bluewin.ch
diff --git a/solenv/gbuild/platform/WNT_INTEL_MSC.mk
b/solenv/gbuild/platform/WNT_INTEL_MSC.mk
index 11d2a1e..2cf856c 100644
--- a/solenv/gbuild/platform/WNT_INTEL_MSC.mk
+++ b/solenv/gbuild/platform/WNT_INTEL_MSC.mk
@@ -368,7 +368,9 @@ $(call gb_Helper_abbreviate_dirs_native,\
$(if $(filter-out StaticLibrary,$(TARGETTYPE)),$(if
$(gb_PRODUCT),,oldnames.lib $(if $(filter libcmtd,$(LINKED_LIBS)),,msvcrtd.lib)
msvcprtd.lib kernel32.lib) user32.lib) \
$(if $(DLLTARGET),-out:$(DLLTARGET) -implib:$(1),-out:$(1));
RC=$$?; rm $${RESPONSEFILE} \
$(if $(DLLTARGET),; if [ ! -f $(DLLTARGET) ]; then rm -f $(1) false;
fi) \
- $(if $(filter Executable,$(TARGETTYPE)),; if [ -f $@.manifest ]; then
mt.exe $(MTFLAGS) -manifest $@.manifest -outputresource:$@\;1; fi) ; exit $$RC)
+ $(if $(filter Library,$(TARGETTYPE)),; if [ -f $(DLLTARGET).manifest ];
then mt.exe $(MTFLAGS) -manifest $(DLLTARGET).manifest
-outputresource:$(DLLTARGET)\;2; fi) \
+ $(if $(filter Executable,$(TARGETTYPE)),; if [ -f $(1).manifest ]; then
mt.exe $(MTFLAGS) -manifest $(1).manifest -outputresource:$(1)\;1; fi) \
+ ; exit $$RC)
endef
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - chart2/source
chart2/source/view/main/VLegendSymbolFactory.cxx |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
New commits:
commit 4ce99d42806e87378614207c8d5adf38d43c756c
Author: Katarina Machalkova bu...@bubli.org
Date: Mon Feb 20 22:20:12 2012 +0100
fdo#31551: Show actual line width in the legend
however, limit the line width from above by legend entry height
(which +- matches the font height)
Signed-off-by: Thorsten Behrens tbehr...@suse.com
diff --git a/chart2/source/view/main/VLegendSymbolFactory.cxx
b/chart2/source/view/main/VLegendSymbolFactory.cxx
index 31b2cbc..79db3c1 100644
--- a/chart2/source/view/main/VLegendSymbolFactory.cxx
+++ b/chart2/source/view/main/VLegendSymbolFactory.cxx
@@ -44,7 +44,8 @@ namespace
void lcl_setPropetiesToShape(
const Reference beans::XPropertySet xProp,
const Reference drawing::XShape xShape,
-::chart::VLegendSymbolFactory::tPropertyType ePropertyType )
+::chart::VLegendSymbolFactory::tPropertyType ePropertyType,
+const awt::Size aMaxSymbolExtent = awt::Size(0,0))
{
const ::chart::tPropertyNameMap aFilledSeriesNameMap(
::chart::PropertyMapper::getPropertyNameMapForFilledSeriesProperties());
const ::chart::tPropertyNameMap aLineSeriesNameMap(
::chart::PropertyMapper::getPropertyNameMapForLineSeriesProperties());
@@ -83,7 +84,8 @@ void lcl_setPropetiesToShape(
sal_Int32 nLineWidth = 0;
if( pLineWidthAny (*pLineWidthAny=nLineWidth) )
{
-const sal_Int32 nMaxLineWidthForLegend = 50;/*1/100 mm*///todo:
make this dependent from legend entry height
+// use legend entry height as upper limit for line width
+sal_Int32 nMaxLineWidthForLegend = aMaxSymbolExtent.Height;
if( nLineWidthnMaxLineWidthForLegend )
*pLineWidthAny = uno::makeAny( nMaxLineWidthForLegend );
}
@@ -134,7 +136,7 @@ Reference drawing::XShape
VLegendSymbolFactory::createSymbol(
xLine-setSize( awt::Size( rEntryKeyAspectRatio.Width, 0 ));
xLine-setPosition( awt::Point( 0,
rEntryKeyAspectRatio.Height/2 ));
-lcl_setPropetiesToShape( xLegendEntryProperties, xLine,
ePropertyType );
+lcl_setPropetiesToShape( xLegendEntryProperties, xLine,
ePropertyType, rEntryKeyAspectRatio );
}
Reference drawing::XShape xSymbol;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: binfilter/bf_sfx2
binfilter/bf_sfx2/source/appl/sfx2_appopen.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 985da32129e1cacd3231cca2f60c5b3f4d9b0b2e Author: Stephan Bergmann sberg...@redhat.com Date: Fri Mar 16 16:40:41 2012 +0100 Some include clean up diff --git a/binfilter/bf_sfx2/source/appl/sfx2_appopen.cxx b/binfilter/bf_sfx2/source/appl/sfx2_appopen.cxx index 1f4ff4a..c6ed362 100644 --- a/binfilter/bf_sfx2/source/appl/sfx2_appopen.cxx +++ b/binfilter/bf_sfx2/source/appl/sfx2_appopen.cxx @@ -37,9 +37,7 @@ #include com/sun/star/frame/XDispatchResultListener.hpp #include com/sun/star/util/URL.hpp #include com/sun/star/util/XURLTransformer.hpp -#include com/sun/star/system/XSystemShellExecute.hpp #include com/sun/star/document/XTypeDetection.hpp -#include com/sun/star/system/SystemShellExecuteFlags.hpp #include com/sun/star/document/MacroExecMode.hpp #include com/sun/star/document/UpdateDocMode.hpp #include com/sun/star/task/XInteractionRequest.hpp @@ -99,7 +97,6 @@ using namespace ::com::sun::star::frame; using namespace ::com::sun::star::lang; using namespace ::com::sun::star::uno; using namespace ::com::sun::star::util; -using namespace ::com::sun::star::system; using namespace ::com::sun::star::task; using namespace ::cppu; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/qa
sc/qa/unit/ucalc.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit eee16791673412f44435b6357248b34ef7613296 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri Mar 16 12:41:43 2012 -0400 Better wording. diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 5d71971..b7a2df2 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -1904,9 +1904,9 @@ void Test::testPivotTableCache() aDimName = aCache.GetDimensionName(2); CPPUNIT_ASSERT_MESSAGE(wrong dimension name, aDimName.equalsAscii(F3)); -// In each dimension, member ID values also represent their order; -// dimension members are sorted in ascending order. And values come -// before strings. Also, no duplicate dimension members exist. +// In each dimension, member ID values also represent their sort order. +// Value items are sorted before string ones. Also, no duplicate +// dimension members should exist. // Dimension 0 - a mix of strings and values. long nMemCount = aCache.GetDimMemberCount(0); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/qa
sc/qa/unit/ucalc.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 16ab673ccbed29d460aaca93cb09663fdd63dc19 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri Mar 16 12:43:33 2012 -0400 More wording tweak. Members are sorted only in source dims (for now). diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index b7a2df2..5324601 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -1904,9 +1904,10 @@ void Test::testPivotTableCache() aDimName = aCache.GetDimensionName(2); CPPUNIT_ASSERT_MESSAGE(wrong dimension name, aDimName.equalsAscii(F3)); -// In each dimension, member ID values also represent their sort order. -// Value items are sorted before string ones. Also, no duplicate -// dimension members should exist. +// In each dimension, member ID values also represent their sort order (in +// source dimensions only, not in group dimensions). Value items are +// sorted before string ones. Also, no duplicate dimension members should +// exist. // Dimension 0 - a mix of strings and values. long nMemCount = aCache.GetDimMemberCount(0); ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.in
configure.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9fea5d3c26c61f83eca26cc14c435eeda34c68bc Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Fri Mar 16 17:16:40 2012 +0100 fix gcc bug 26905 detection with clang it uses GOT instead of PLT on i386 with -02 diff --git a/configure.in b/configure.in index 72b45b9..4fc314a 100644 --- a/configure.in +++ b/configure.in @@ -4532,7 +4532,7 @@ _ACEOF if test $_os = Darwin; then gccvisbroken=no else -if $EGREP -q '@PLT' visibility.s; then +if $EGREP -q '@PLT|@GOT' visibility.s; then gccvisbroken=no else gccvisbroken=yes ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sw/Library_sw.mk
sw/Library_sw.mk |1 - 1 file changed, 1 deletion(-) New commits: commit cac985081415a4840a9d04332ee778b6ba48e7aa Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Fri Mar 16 18:07:36 2012 +0100 sw doesn't need to link oox that commit should have been cleaned up before it went upstream diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk index 2b0bce3..4d5cdd6 100644 --- a/sw/Library_sw.mk +++ b/sw/Library_sw.mk @@ -61,7 +61,6 @@ $(eval $(call gb_Library_add_linked_libs,sw,\ i18nisolang1 \ i18nutil \ lng \ -oox \ sal \ salhelper \ sax \ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: .gitignore
.gitignore |1 + 1 file changed, 1 insertion(+) New commits: commit dc3ea99bd09fa0f38e0b6ff939badaa449fd39b4 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Fri Mar 16 20:11:04 2012 +0100 add autogen.lastrun.bak to .gitignore diff --git a/.gitignore b/.gitignore index 441e4bc..c1aef58 100644 --- a/.gitignore +++ b/.gitignore @@ -49,6 +49,7 @@ /aclocal.m4 /autom4te.cache /autogen.lastrun +/autogen.lastrun.bak /ChangeLog /config.guess /config.log ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source
sc/source/core/data/cell.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 14ed2c61066b38d812bb68c4c1f02f8cb7c97f4d
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Thu Mar 15 22:22:10 2012 +0100
update the relatice refs after the absolute refs, fdo#47285
The algoithm for updating absolute refs needs to calculate the old
position based on the information before any updates to the RefData
Signed-off-by: Kohei Yoshida kohei.yosh...@gmail.com
diff --git a/sc/source/core/data/cell.cxx b/sc/source/core/data/cell.cxx
index 9b431fa..4ed94b9 100644
--- a/sc/source/core/data/cell.cxx
+++ b/sc/source/core/data/cell.cxx
@@ -861,9 +861,6 @@ ScFormulaCell::ScFormulaCell( const ScFormulaCell rCell,
ScDocument rDoc, cons
{
pCode = rCell.pCode-Clone();
-if ( nCloneFlags SC_CLONECELL_ADJUST3DREL )
-pCode-ReadjustRelative3DReferences( rCell.aPos, aPos );
-
// evtl. Fehler zuruecksetzen und neu kompilieren
// nicht im Clipboard - da muss das Fehlerflag erhalten bleiben
// Spezialfall Laenge=0: als Fehlerzelle erzeugt, dann auch Fehler
behalten
@@ -900,6 +897,9 @@ ScFormulaCell::ScFormulaCell( const ScFormulaCell rCell,
ScDocument rDoc, cons
pCode-AdjustAbsoluteRefs( rCell.pDocument, rCell.aPos, aPos );
}
+if ( nCloneFlags SC_CLONECELL_ADJUST3DREL )
+pCode-ReadjustRelative3DReferences( rCell.aPos, aPos );
+
if( !bCompile )
{ // Name references with references and ColRowNames
pCode-Reset();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - dbaccess/source fpicker/Library_fps_kde4.mk fpicker/Module_fpicker.mk fpicker/Package_kde4_moc.mk fpicker/source vcl/unx
dbaccess/source/ui/misc/charsets.cxx |2 -
fpicker/Library_fps_kde4.mk |8 ---
fpicker/Module_fpicker.mk|1
fpicker/Package_kde4_moc.mk | 36 ---
fpicker/source/unx/kde4/Makefile | 35 --
vcl/unx/kde4/KDESalGraphics.cxx |2 -
6 files changed, 2 insertions(+), 82 deletions(-)
New commits:
commit 43a56ce0cbed9187658340d0d4fbfa76c2c83d1b
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Fri Mar 16 20:57:07 2012 +0100
remove extraneous parentheses
diff --git a/vcl/unx/kde4/KDESalGraphics.cxx b/vcl/unx/kde4/KDESalGraphics.cxx
index 0be12fb..80c38ec 100644
--- a/vcl/unx/kde4/KDESalGraphics.cxx
+++ b/vcl/unx/kde4/KDESalGraphics.cxx
@@ -306,7 +306,7 @@ sal_Bool KDESalGraphics::drawNativeControl( ControlType
type, ControlPart part,
draw( QStyle::CE_PushButton, option, m_image,
vclStateValue2StateFlag(nControlState, value) );
}
-else if ( (type == CTRL_MENUBAR))
+else if (type == CTRL_MENUBAR)
{
if (part == PART_MENU_ITEM)
{
commit cd131c6366a2ee70d15fc4d4794ddf62b8db646e
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Fri Mar 16 20:36:14 2012 +0100
kde4 fpicker doesn't use Q_OBJECT, no need for moc
diff --git a/fpicker/Library_fps_kde4.mk b/fpicker/Library_fps_kde4.mk
index d806737..7c3e95f 100644
--- a/fpicker/Library_fps_kde4.mk
+++ b/fpicker/Library_fps_kde4.mk
@@ -27,10 +27,6 @@
$(eval $(call gb_Library_Library,fps_kde4))
-$(eval $(call gb_Library_add_package_headers,fps_kde4,\
- fpicker_kde4_moc \
-))
-
$(eval $(call
gb_Library_set_componentfile,fps_kde4,fpicker/source/unx/kde4/fps_kde4))
$(eval $(call gb_Library_add_api,fps_kde4,\
@@ -61,10 +57,6 @@ $(eval $(call gb_Library_add_exception_objects,fps_kde4,\
fpicker/source/unx/kde4/KDE4FPEntry \
))
-$(eval $(call gb_Library_add_generated_cxxobjects,fps_kde4,\
- CustomTarget/fpicker/source/unx/kde4/KDE4FilePicker.moc \
-))
-
# KDE/Qt consider -Wshadow more trouble than benefit
$(eval $(call gb_Library_add_cxxflags,fps_kde4,\
-Wno-shadow \
diff --git a/fpicker/Module_fpicker.mk b/fpicker/Module_fpicker.mk
index 0491e54..2faa777 100644
--- a/fpicker/Module_fpicker.mk
+++ b/fpicker/Module_fpicker.mk
@@ -62,7 +62,6 @@ endif
ifeq ($(ENABLE_KDE4),TRUE)
$(eval $(call gb_Module_add_targets,fpicker,\
Library_fps_kde4 \
- Package_kde4_moc \
))
endif
endif
diff --git a/fpicker/Package_kde4_moc.mk b/fpicker/Package_kde4_moc.mk
deleted file mode 100644
index 27ab13a..000
--- a/fpicker/Package_kde4_moc.mk
+++ /dev/null
@@ -1,36 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-# Version: MPL 1.1 / GPLv3+ / LGPLv3+
-#
-# The contents of this file are subject to the Mozilla Public License Version
-# 1.1 (the License); you may not use this file except in compliance with
-# the License or as specified alternatively below. You may obtain a copy of
-# the License at http://www.mozilla.org/MPL/
-#
-# Software distributed under the License is distributed on an AS IS basis,
-# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
-# for the specific language governing rights and limitations under the
-# License.
-#
-# Major Contributor(s):
-# Copyright (C) 2010 Red Hat, Inc., David Tardon dtar...@redhat.com
-# (initial developer)
-#
-# All Rights Reserved.
-#
-# For minor contributions see the git repository.
-#
-# Alternatively, the contents of this file may be used under the terms of
-# either the GNU General Public License Version 3 or later (the GPLv3+), or
-# the GNU Lesser General Public License Version 3 or later (the LGPLv3+),
-# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
-# instead of those above.
-
-$(eval $(call
gb_Package_Package,fpicker_kde4_moc,$(WORKDIR)/CustomTarget/fpicker/source/unx/kde4))
-
-$(eval $(call
gb_Package_add_customtarget,fpicker_kde4_moc,fpicker/source/unx/kde4))
-
-$(eval $(call gb_CustomTarget_add_dependencies,fpicker/source/unx/kde4,\
-fpicker/source/unx/kde4/KDE4FilePicker.hxx \
-))
-
-# vim:set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/fpicker/source/unx/kde4/Makefile b/fpicker/source/unx/kde4/Makefile
deleted file mode 100644
index cd0ad6e..000
--- a/fpicker/source/unx/kde4/Makefile
+++ /dev/null
@@ -1,35 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-# Version: MPL 1.1 / GPLv3+ / LGPLv3+
-#
-# The contents of this file are subject to the Mozilla Public License Version
-# 1.1 (the License); you may not use this file except in compliance with
-# the License or as specified alternatively below. You may obtain a copy of
-# the License at http://www.mozilla.org/MPL/
-#
-# Software distributed under the License is distributed on an AS IS basis,
-# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
-# for the specific language governing rights and
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sw/Library_sw.mk
sw/Library_sw.mk |1 - 1 file changed, 1 deletion(-) New commits: commit a3ace305bcbd0bf04badddff8ef6273287f30556 Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Fri Mar 16 18:07:36 2012 +0100 sw doesn't need to link oox that commit should have been cleaned up before it went upstream Signed-off-by: Michael Meeks michael.me...@suse.com diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk index 40e70f3..9529470 100644 --- a/sw/Library_sw.mk +++ b/sw/Library_sw.mk @@ -63,7 +63,6 @@ $(eval $(call gb_Library_add_linked_libs,sw,\ i18nisolang1 \ i18nutil \ lng \ -oox \ sal \ salhelper \ sax \ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source
sc/source/ui/view/viewfun5.cxx |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
New commits:
commit 76f3a63432e70d017760a2087652a1abc9b126d3
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Mar 16 10:45:01 2012 +0100
don't paste content if user cancels html import, fdo#47393
Signed-off-by: Kohei Yoshida kohei.yosh...@gmail.com
diff --git a/sc/source/ui/view/viewfun5.cxx b/sc/source/ui/view/viewfun5.cxx
index eae1329..cdf373a 100644
--- a/sc/source/ui/view/viewfun5.cxx
+++ b/sc/source/ui/view/viewfun5.cxx
@@ -322,9 +322,15 @@ sal_Bool ScViewFunc::PasteDataFormat( sal_uLong nFormatId,
aOptions.SetDetectSpecialNumber(pDlg-IsDateConversionSet());
aObj.SetExtOptions(aOptions);
}
+else
+{
+// prevent error dialog for user cancel action
+bRet = true;
+}
}
+if(!bRet)
+bRet = aObj.ImportStream( *xStream, String(), nFormatId );
// mba: clipboard always must contain absolute URLs (could be
from alien source)
-bRet = aObj.ImportStream( *xStream, String(), nFormatId );
}
else if (nFormatId == FORMAT_STRING aDataHelper.GetString(
nFormatId, aStr ))
{
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source
sc/source/ui/app/inputhdl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c39e96d984b5907f8e0c0247828c8e35f2e9ce72 Author: Noel Power noel.po...@novell.com Date: Thu Mar 15 20:10:12 2012 + fix to update inputbar when setting a range for a formula fdo#46809 Signed-off-by: Kohei Yoshida kohei.yosh...@gmail.com diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index 95d2b7f..e461b0b 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -1719,7 +1719,7 @@ void ScInputHandler::UpdateActiveView() else pTableView = NULL; -if (pInputWin pInputWin-IsInputActive()) +if (pInputWin eMode == SC_INPUT_TOP ) pTopView = pInputWin-GetEditView(); else pTopView = NULL; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: extensions/source
extensions/source/update/check/updatecheck.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d943c6ba374481b1f9a6561b790b0b0410b78b0e Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Fri Mar 16 21:28:42 2012 +0100 logical || - binary | diff --git a/extensions/source/update/check/updatecheck.cxx b/extensions/source/update/check/updatecheck.cxx index 54f9b4c..88f7234 100644 --- a/extensions/source/update/check/updatecheck.cxx +++ b/extensions/source/update/check/updatecheck.cxx @@ -160,7 +160,7 @@ rtl::OUString getImageFromFileName(const rtl::OUString aFile) oslProcessError rc = osl_executeProcess_WithRedirectedIO( aUnpackPath.pData, // [in] Image name aSystemPath.pData, 1, // [in] Arguments -osl_Process_WAIT || osl_Process_NORMAL, // [in] Options +osl_Process_WAIT | osl_Process_NORMAL, // [in] Options NULL, // [in] Security NULL, // [in] Working directory NULL, 0,// [in] Environment variables ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/tubes' - tubes/README
tubes/README | 37 + 1 file changed, 37 insertions(+) New commits: commit 6ae3da5cae73400d1ef7efe83274f35fd7b6c6c6 Author: Eike Rathke er...@redhat.com Date: Fri Mar 16 23:49:18 2012 +0100 ideas and todos diff --git a/tubes/README b/tubes/README index ca8764f..20cdcfa 100644 --- a/tubes/README +++ b/tubes/README @@ -1,5 +1,11 @@ Interface to Telepathy Tubes. +The idea is to provide 1-1 collaboration between contacts and many-many +collaboration via MUCs, using Telepathy DBus Tubes over Jabber/XMPP. + +First stab is at 1-1 contact channels, hopefully MUCs can be realized using +the same TeleConference abstraction. + To enable configure LibO with --enable-telepathy Status 2012-03-16: @@ -31,3 +37,34 @@ Status 2012-03-16: * unsure if the uniquify setup with tp_simple_handler_new_with_factory() would work at all, hence trying to have one instance un-uniquified, but to no avail + + +TODOs (once those basic problems are solved) + +* associate a document with a conference + * use SfxObjectShell as an abstraction and broadcast incoming changes? + * use UNO API? + * first setup just to get something working could share a document +accessible by all parties on a network share or some such +* may need one master responsible to save the document + * later document transfer will be needed, use Telepathy File Transfer +* dialog to pick own account +* dialog to pick contact or MUC to work with +* dialog to accept/reject collaboration requests + + +In applications, e.g. Calc: + +* stricter model,view,controller +* disable all actions we cannot process collaboratively +* separate input from view +* preprocess input to determine data type (text, number, date, ...) +* send typed/categorized data over wire before actually processing in model +* process serialized input as received +* Calc specific: + * use existing shared document feature with change-tracking enabled to +visualize changes +* may have the benefit of having already only a subset of trackable change + actions available + * let ScDocFunc handle also received changes +* have dialogs send their result item sets over the wire ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/tubes' - tubes/Module_tubes.mk
tubes/Module_tubes.mk |4 1 file changed, 4 insertions(+) New commits: commit a238f0dc92484930b8c8b2dcb018ba52caf1d5f4 Author: Eike Rathke er...@redhat.com Date: Sat Mar 17 00:02:48 2012 +0100 disable entire module if without --enable-telepathy diff --git a/tubes/Module_tubes.mk b/tubes/Module_tubes.mk index ce810e1..9ed4a48 100644 --- a/tubes/Module_tubes.mk +++ b/tubes/Module_tubes.mk @@ -27,6 +27,8 @@ $(eval $(call gb_Module_Module,tubes)) +ifeq ($(ENABLE_TELEPATHY),TRUE) + $(eval $(call gb_Module_add_targets,tubes,\ Library_tubes \ )) @@ -35,4 +37,6 @@ $(eval $(call gb_Module_add_check_targets,tubes,\ CppunitTest_tubes_test \ )) +endif + # vim:set shiftwidth=4 tabstop=4 noexpandtab: */ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/inc sc/source
sc/inc/dpcache.hxx |5 +++
sc/inc/dpitemdata.hxx | 10 +--
sc/source/core/data/dpcache.cxx| 28 --
sc/source/core/data/dpitemdata.cxx | 47 ++---
4 files changed, 72 insertions(+), 18 deletions(-)
New commits:
commit f81d15c3bab32938b5b475e16ae2a746a7a32ea9
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Mar 16 21:44:55 2012 -0400
Use shared string pool to share string instances among string item values.
This brings down the reload time from 22 seconds to 4.3 seconds with
my test document. This is what I've been looking for!
diff --git a/sc/inc/dpcache.hxx b/sc/inc/dpcache.hxx
index 839f64b..2591b3d 100644
--- a/sc/inc/dpcache.hxx
+++ b/sc/inc/dpcache.hxx
@@ -36,6 +36,7 @@
#include boost/noncopyable.hpp
#include boost/scoped_ptr.hpp
#include boost/ptr_container/ptr_vector.hpp
+#include boost/unordered_set.hpp
#include mdds/flat_segment_tree.hpp
#include vector
@@ -58,6 +59,8 @@ struct ScDPNumGroupInfo;
*/
class SC_DLLPUBLIC ScDPCache : boost::noncopyable
{
+typedef boost::unordered_setrtl::OUString, rtl::OUStringHash
StringSetType;
+
public:
typedef std::vectorScDPItemData ItemsType;
typedef std::setScDPObject* ObjectSetType;
@@ -112,6 +115,7 @@ private:
FieldsType maFields;
GroupFieldsType maGroupFields;
+mutable StringSetType maStringPool;
LabelsType maLabelNames;// Stores dimension names.
mdds::flat_segment_treeSCROW, bool maEmptyRows;
@@ -119,6 +123,7 @@ private:
bool mbDisposing;
public:
+const rtl::OUString* InternString(const rtl::OUString rStr) const;
void AddReference(ScDPObject* pObj) const;
void RemoveReference(ScDPObject* pObj) const;
const ObjectSetType GetAllReferences() const;
diff --git a/sc/inc/dpitemdata.hxx b/sc/inc/dpitemdata.hxx
index e30eae3..20535a8 100644
--- a/sc/inc/dpitemdata.hxx
+++ b/sc/inc/dpitemdata.hxx
@@ -49,7 +49,7 @@ class SC_DLLPUBLIC ScDPItemData
friend class ScDPCache;
public:
-enum Type { GroupValue = 0, RangeStart, Value, String, Error, Empty };
+enum Type { GroupValue = 0, RangeStart = 1, Value = 2, String = 3, Error =
4, Empty = 5 };
static const sal_Int32 DateFirst;
static const sal_Int32 DateLast;
@@ -63,12 +63,13 @@ public:
private:
union {
-rtl::OUString* mpString;
+const rtl::OUString* mpString;
GroupValueAttr maGroupValue;
double mfValue;
};
-Type meType;
+sal_uInt8 meType:3;
+bool mbStringInterned:1;
void DisposeString();
@@ -79,16 +80,19 @@ public:
ScDPItemData();
ScDPItemData(const ScDPItemData r);
ScDPItemData(const rtl::OUString rStr);
+ScDPItemData(const rtl::OUString* pStr);
ScDPItemData(sal_Int32 nGroupType, sal_Int32 nValue);
~ScDPItemData();
Type GetType() const;
void SetString(const rtl::OUString rS);
+void SetString(const rtl::OUString* pS);
void SetValue(double fVal);
void SetRangeStart(double fVal);
void SetRangeFirst();
void SetRangeLast();
void SetErrorString(const rtl::OUString rS);
+void SetErrorString(const rtl::OUString* pS);
bool IsCaseInsEqual(const ScDPItemData r) const;
// exact equality
diff --git a/sc/source/core/data/dpcache.cxx b/sc/source/core/data/dpcache.cxx
index 216c2ff..369c5b3 100644
--- a/sc/source/core/data/dpcache.cxx
+++ b/sc/source/core/data/dpcache.cxx
@@ -138,7 +138,9 @@ rtl::OUString createLabelString(ScDocument* pDoc, SCCOL
nCol, SCROW nRow, SCTAB
return aDocStr;
}
-void initFromCell(ScDocument* pDoc, SCCOL nCol, SCROW nRow, SCTAB nTab,
ScDPItemData rData, sal_uLong rNumFormat)
+void initFromCell(
+ScDPCache rCache, ScDocument* pDoc, SCCOL nCol, SCROW nRow, SCTAB nTab,
+ScDPItemData rData, sal_uLong rNumFormat)
{
rtl::OUString aDocStr = pDoc-GetString(nCol, nRow, nTab);
rNumFormat = 0;
@@ -147,7 +149,7 @@ void initFromCell(ScDocument* pDoc, SCCOL nCol, SCROW nRow,
SCTAB nTab, ScDPItem
if (pDoc-GetErrCode(aPos))
{
-rData.SetErrorString(aDocStr);
+rData.SetErrorString(rCache.InternString(aDocStr));
}
else if (pDoc-HasValueData(nCol, nRow, nTab))
{
@@ -157,12 +159,12 @@ void initFromCell(ScDocument* pDoc, SCCOL nCol, SCROW
nRow, SCTAB nTab, ScDPItem
}
else if (pDoc-HasData(nCol, nRow, nTab))
{
-rData.SetString(aDocStr);
+rData.SetString(rCache.InternString(aDocStr));
}
}
void getItemValue(
-ScDPItemData rData, const Referencesdbc::XRow xRow, sal_Int32 nType,
+ScDPCache rCache, ScDPItemData rData, const Referencesdbc::XRow xRow,
sal_Int32 nType,
long nCol, const Date rNullDate, short rNumType)
{
rNumType = NUMBERFORMAT_NUMBER;
@@ -232,7 +234,7 @@ void getItemValue(
case sdbc::DataType::VARBINARY:
case sdbc::DataType::LONGVARBINARY:
default:
-
[Libreoffice-commits] .: sc/inc
sc/inc/dpitemdata.hxx |8
1 file changed, 8 insertions(+)
New commits:
commit 99b9c0bfccd73a97d99666986cc9e84a0e8f9aeb
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Mar 16 23:34:31 2012 -0400
Added class description.
diff --git a/sc/inc/dpitemdata.hxx b/sc/inc/dpitemdata.hxx
index 20535a8..b0f361b 100644
--- a/sc/inc/dpitemdata.hxx
+++ b/sc/inc/dpitemdata.hxx
@@ -44,6 +44,14 @@
class ScDocument;
+/**
+ * When assigning a string value, you can also assign an interned string
+ * whose life-cycle is managed by the pivot cache that it belongs to. Those
+ * methods that take a string pointer assume that the string is interned.
+ *
+ * pDo make sure that an item with an interned string won't persist after
+ * the pivot cache has been destroyed or reloaded./p
+ */
class SC_DLLPUBLIC ScDPItemData
{
friend class ScDPCache;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/source
sc/source/filter/xml/xmldpimp.cxx | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
New commits:
commit 3ae3f098ed4e6495c0be0748dacf03dd8e0fe091
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Sat Mar 17 00:07:33 2012 -0400
Fixed potential memory leak UniString removal.
diff --git a/sc/source/filter/xml/xmldpimp.cxx
b/sc/source/filter/xml/xmldpimp.cxx
index ee8e3aa..8fa7312 100644
--- a/sc/source/filter/xml/xmldpimp.cxx
+++ b/sc/source/filter/xml/xmldpimp.cxx
@@ -1037,11 +1037,14 @@ SvXMLImportContext
*ScXMLDataPilotFieldContext::CreateChildContext( sal_uInt16 n
void ScXMLDataPilotFieldContext::AddMember(ScDPSaveMember* pMember)
{
if (pDim)
+{
pDim-AddMember(pMember);
-
-if (!pMember-GetIsVisible())
-// This member is hidden.
-mbHasHiddenMember = true;
+if (!pMember-GetIsVisible())
+// This member is hidden.
+mbHasHiddenMember = true;
+}
+else
+delete pMember;
}
void ScXMLDataPilotFieldContext::SetSubTotalName(const OUString rName)
@@ -1636,7 +1639,7 @@ void ScXMLDataPilotMemberContext::EndElement()
{
if (bHasName) // #i53407# don't check sName, empty name is allowed
{
-ScDPSaveMember* pMember = new ScDPSaveMember(String(sName));
+ScDPSaveMember* pMember = new ScDPSaveMember(sName);
if (!maDisplayName.isEmpty())
pMember-SetLayoutName(maDisplayName);
pMember-SetIsVisible(bDisplay);
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Krishnan Parthasarathi wants to chat
--- Krishnan Parthasarathi wants to stay in better touch using some of Google's coolest new products. If you already have Gmail or Google Talk, visit: http://mail.google.com/mail/b-ad3b4d22-dd01b71c3f-tJ2TNGCoo2Snk5DGUI3ShLvbVc4 You'll need to click this link to be able to chat with Krishnan Parthasarathi. To get Gmail - a free email account from Google with over 2,800 megabytes of storage - and chat with Krishnan Parthasarathi, visit: http://mail.google.com/mail/a-ad3b4d22-dd01b71c3f-tJ2TNGCoo2Snk5DGUI3ShLvbVc4 Gmail offers: - Instant messaging right inside Gmail - Powerful spam protection - Built-in search for finding your messages and a helpful way of organizing emails into conversations - No pop-up ads or untargeted banners - just text ads and related information that are relevant to the content of your messages All this, and its yours for free. But wait, there's more! By opening a Gmail account, you also get access to Google Talk, Google's instant messaging service: http://www.google.com/talk/ Google Talk offers: - Web-based chat that you can use anywhere, without a download - A contact list that's synchronized with your Gmail account - Free, high quality PC-to-PC voice calls when you download the Google Talk client We're working hard to add new features and make improvements, so we might also ask for your comments and suggestions periodically. We appreciate your help in making our products even better! Thanks, The Google Team To learn more about Gmail and Google Talk, visit: http://mail.google.com/mail/help/about.html http://www.google.com/talk/about.html (If clicking the URLs in this message does not work, copy and paste them into the address bar of your browser). ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] code cleanup in chart2uno.cxx in SC module
Hi License statement is on file. This series is a precursor to more tools/table.hxx removal, but I thought I'd push the code cleanup series separately to make it easier to review. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0002-restructure-insert-code-as-a-precursor-to-further-si.patch Description: application/mbox 0003-if-else-branches-contain-same-code.patch Description: application/mbox 0004-remove-unnecessary-use-of-local-variable-and-auto_pt.patch Description: application/mbox 0001-simplify-code-remove-unnecessary-and-complicated-all.patch Description: application/mbox ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
RE: [PATCH]bug 44516 improved label and business card document creation
From: Norbert Thiebaud [mailto:nthieb...@gmail.com]
Sent: maandag 27 februari 2012 08:26
...
yes, but the mix of various changes leading to such a big patch and
especially the removal of entry peppered in the middle of a massive
re-formating makes that, even with some diff + sed magic, I cannot
reduce that to something readable, so I cannot review it.
In order for _me_ to sign-off for 3.5 branch, I would need you to
break your patch along the lines discussed earlier...
I have done some editing with vi
-remove all leading spaces (:%s/ \{1,\}//g);
-insert linefeed between '' (:%s//\r/g);
-remove empty lines (:%s/\n\{2,\}/\r/g)
on both the Labels.xcu from before and after my commit.
I made a diff file (diff -a -b), which now shows only changes in contents. The
diff file is still 7448 lines long as all 1700+ definitions have been changed.
Will this help you to review the patch for pushing to 3.5 branch?
(Just yesterday an (duplicate) bug was reported for this patch)
Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] format clipboard
Here a copy of the mail I send to Cedric Bosdonnat… forgot to add the
list as Cc:.
Hello
Thanks you for asking me…
When you select a cell in Writer the selection type is a mix of
nsSelectionType::SEL_TBL_CELLS, nsSelectionType::SEL_TBL and
nsSelectionType::SEL_TXT.
So when the lcl_CreateEmptyItemSet function is called directly with the
nSelectionType (from rWrtShell.GetSelectionType()) the if statement
nSelectionType == nsSelectionType::SEL_TBL is false.
So in the SwFormatClipboard::Copy function there is another statement :
if( nSelectionType nsSelectionType::SEL_TBL_CELLS )//only copy table
attributes if really cells are selected (not only text in tables)
{
m_pTableItemSet = lcl_CreateEmptyItemSet(
nsSelectionType::SEL_TBL, rPool );
lcl_getTableAttributes( *m_pTableItemSet, rWrtShell );
}
That call lcl_CreateEmptyItemSet with just nsSelectionType::SEL_TBL if
the real selection type contain nsSelectionType::SEL_TBL_CELLS.
I found this way of doing a bit confusing and as tables parameters are
handle separately in the whole format paintbrush code I thought that
replacing :
m_pTableItemSet = lcl_CreateEmptyItemSet( nsSelectionType::SEL_TBL,
rPool );
by :
m_pTableItemSet = new SfxItemSet(rPool,
SID_ATTR_BORDER_INNER, SID_ATTR_BORDER_SHADOW,
//SID_ATTR_BORDER_OUTER is inbetween
RES_BACKGROUND, RES_SHADOW, //RES_BOX is inbetween
SID_ATTR_BRUSH_ROW, SID_ATTR_BRUSH_TABLE,
RES_BREAK, RES_BREAK,
RES_PAGEDESC, RES_PAGEDESC,
RES_LAYOUT_SPLIT, RES_LAYOUT_SPLIT,
RES_ROW_SPLIT, RES_ROW_SPLIT,
RES_KEEP, RES_KEEP,
RES_FRAMEDIR, RES_FRAMEDIR,
FN_PARAM_TABLE_HEADLINE, FN_PARAM_TABLE_HEADLINE,
FN_TABLE_BOX_TEXTORIENTATION, FN_TABLE_BOX_TEXTORIENTATION,
FN_TABLE_SET_VERT_ALIGN, FN_TABLE_SET_VERT_ALIGN,
0);
was not irrelevant.
After this replacement was made there where no reasons keeping the
nSelectionType == nsSelectionType::SEL_TBL block in the
lcl_CreateEmptyItemSet function.
I hope I answered your question.
BEWARE : this patch need the first patch
0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell from my preview
mail
http://lists.freedesktop.org/archives/libreoffice/2012-March/028157.html
Regards
Maxime de Roucy
--
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX
Tel. : 0 810 251 251
Le jeudi 15 mars 2012 à 17:06 +0100, Cedric Bosdonnat a écrit :
Hi Maxime,
On Wed, 2012-03-14 at 16:50 +0100, Maxime de Roucy wrote:
Here is some new patchs on the format clipboard. The first just add some
comment in the formatclipboard.hxx file. The second one depend on
modifications I made in the previous patch
0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch which is
itself dependant of the patch
0004-SwEditShell-use-of-the-STL-swap-function.patch which is waiting for
moderator approval to be published in the mailing list.
I pushed the first patch to the master branch... but there is something
weird in the second patch. Why did you remove the case where
nSelectionType is a table selection?
I'll push the second patch once that question is clarified.
--
Cedric
signature.asc
Description: This is a digitally signed message part
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW] fix for fdo#47285, sorting cells with relative refs may invalidate some
Hey, [1] fixes a problem when you sort cells with relative refs. The update for absolute refs needs the information about the original referenced cell and therefore the relative references should be updated after the absolute ones. The relative references don't need any information about their position and therefore there is no problem to update them after the absolute refs. Regards, Markus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=2118ec3630fe12ff2a663c94421780870f264e83 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW] fix for fdo#47393, unable to cancel html paste
Hey, [1] fixes the issue that we are unable to cancel the html paste dialog and paste the content even after pressing the cancel button. This patch is extremely safe and I think we can easily add it to 3-5. Regards, Markus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=bd8be4eae82525434454cc3c7274f7a7a44158c0 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Can't compile from source, i18npool project segfaults with parallel build
On Fri, Mar 16, 2012 at 4:44 AM, Thorsten Behrens t...@documentfoundation.org wrote: uh.li...@gmail.com wrote: I'm trying to build LibreOffce 3.5 and 3.5.1 from source, but build always failed with i18npool project. I'm using parallel build. Same build script compiles 3.4.5 and older versions. Tested with x86 and x86_64 machine. GCC 4.5.2. Making with -j1 in i18npool wokks, but automatic building whole suite with -j1 takes very long time. Can anybody confirm this? What additional information is needed? Hi there, please provide more information on the specific failure. From your description, it seems you might hit a gnumake bug - what is your gnumake version? You might want to try a self-built make: git clone git://anongit.freedesktop.org/libreoffice/contrib/dev-tools cd dev-tools/make-3.82-gbuild ./configure make and then in your build shell export GNUMAKE=path/to/your/selfbuild/make An alternative is ./configure --prefix=/opt/lo make sudo make install then there is no need to export GNUMAKE since lo's configure will search /opt/lo/bin for make Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Jan Holesovsky ke...@suse.cz changed: What|Removed |Added Depends on||44628 --- Comment #232 from Jan Holesovsky ke...@suse.cz 2012-03-16 03:52:20 PDT --- Added an annoying installation issue. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Regressions in Open Source projects ...
On Thu, 2012-03-15 at 21:22 +0100, Petr Mladek wrote: Actually I was talking about SUSE LibreOffice for Windows (which is apparently a one-off unsupported release created for the Intel AppUp store) :) Nah - SUSE will be maintaining that with our stable release. Though of course it doesn't come with enterprise support, and problem temporary fix builds and so on :-) It is certainly true that it is currently 3.4.2 based but that should be updated to something 3.4.5/6 based soonish as we pull up our customers to that [ though this version is only a base - the build will include a number of additional back-ports, other misc. fixes, different compile options etc. ]. To understand SUSE LibreOffice vs. vanilla LibreOffice the best analogy is something like the SUSE / RedHat 'Enterprise' linux kernels - these become increasingly less vanilla from release time out with tons of back-ported bits. Wrt. our plans for a SUSE / 3.5 based release, those are not public that I know of; but should happen in due course. The team is even now working hard to chew through regressions, and check that every L3 customer bug we've fixed in the past does not regress in our 3.5.x base - that of course results in lots of fixes improvements going into the libreoffice-3-5 branch I hope. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Jan Holesovsky ke...@suse.cz changed: What|Removed |Added Depends on|44628 | -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] fix for fdo#46230, shrink the copy area only in the text export
Hi Markus, On Tue, 2012-03-13 at 01:41 +0100, Markus Mohrhard wrote: calc. The problem is that we should not shrink the area already in ScTransferObj. We should wait until we need to export the data and limit this to the text export. Please test it especially in the context of n#677811. I see one of Rainer's favorite bugs already has a patch; but - since you've pushed it to master, were you asking for review for -3-5 ? re-titling to that for now ... http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a26fe4a39b6f3b2af269b801340c32c28806250 It looks reasonable to me, if so :-) Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-5] fix for fdo#46230, shrink the copy area only in the text export
Hello Michael, On Tue, 2012-03-13 at 01:41 +0100, Markus Mohrhard wrote: calc. The problem is that we should not shrink the area already in ScTransferObj. We should wait until we need to export the data and limit this to the text export. Please test it especially in the context of n#677811. I see one of Rainer's favorite bugs already has a patch; but - since you've pushed it to master, were you asking for review for -3-5 ? I was asking for review and Muthu or Kohei to check that the private Novell bug is not affected by this patch since I this time chose a more aggressive fix to finally eliminate all problems around copy/paste dnd to internal and external applications. re-titling to that for now ... Oh I always thought that [REVIEW] is the correct tag for current stable branch and [PATCH] for master but if not I will adapt this. http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a26fe4a39b6f3b2af269b801340c32c28806250 It looks reasonable to me, if so :-) According to Muthi I might need a follow-up patch for n#677811 because Outlook seems to use the HTML export and not the text export. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED-3-5] fdo#46728: EDITING: soffice.bin crashed with SIGSEGV in Window::GetCursor()
On Tue, 2012-03-13 at 18:04 +0100, Thorsten Behrens wrote: Caolan McNamara wrote: So, how about http://cgit.freedesktop.org/libreoffice/core/commit/?id=131e5d35a4edb9f8875a197e8e0382c168834f70 Seems to fix the crash. Worthwhile for 3-5 ? Eh. Inspected for syntactical equivalence, but this is quite massive. Hesitant to hand-wave that in w/o further deliberation. ;) So - I'd like to get this into 3-5 - no point in leaving known SEGV's lying around ;-) The only substantive changes I can see are: * around three calls to GetOverlayManager() that now happen once in the method instead of twice - once to check for NULL, and another time to invoke the method. + if there truly is a race here it could go either way and we fixed another crash ;-) + ie. a non-issue. * the final fix itself: +//Resolves: fdo#46728 ensure this exists until end of scope +rtl::ReferenceOverlayManager xRef(this); Which keeps the 'this' pointer alive long enough not to crash in the timeout handler - which seems a worthy goal at least ? :-) * and of course initializing the ref counts in the oddly named badbf0c commit. So - I'd like to get it in. Thorsten - please scream and revert if I've really got this wrong :-) Thanks Caolan; lovely cleanup too :-) Regards, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] fdo#31551 - lines in legend not shown with current width ...
Hi there, Katarina created a nice patch for this bug: https://bugs.freedesktop.org/show_bug.cgi?id=31551 which is here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd33b0d28e9f73b4911b43bedf334296b8025485 It seems (on the face of it) reasonably simple; does it make sense to have it in 3.5.2 (rc1 deadline is Monday IIRC) :-) Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Jan Holesovsky ke...@suse.cz changed: What|Removed |Added Depends on||44628 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Can't compile from source, i18npool project segfaults with parallel build
Hi there, On Fri, 2012-03-16 at 07:03 +0400, uh.li...@gmail.com wrote: I'm trying to build LibreOffce 3.5 and 3.5.1 from source, but build always failed with i18npool project. I'm using parallel build. Same build script compiles 3.4.5 and older versions. Tested with x86 and x86_64 machine. GCC 4.5.2. Making with -j1 in i18npool wokks, but automatic building whole suite Wow - that is bad :-) so - of course, we'd love to fix that properly. Do you get a core-dump that can be analysed ? which tool crashes ? can you do: $ ulimit -c unlimited and reproduce the problem, then poke at the result of running 'strings' on the core-dump (or whatever means you like) to work out what went wrong and where ? with -j1 takes very long time. Can anybody confirm this? What additional information is needed? As above would be good, and yes -j1 is really not ideal :-) I wonder what is causing that. Are you certain you have the latest gnumake version 3.82 ? there are known bugs in older versions :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call 2012-03-15 1500 UTC
On Thu, 2012-03-15 at 19:07 +0100, Bjoern Michaelsen wrote: AA: + announce very loudly if the call changes slot in UTC timezone (Michael) So - it's a good time to think about a new time. + 17:00 local might be preferable to quite a few (Eike) AA: + is that 1700 CET or CEST? (1600UTC or 1500UTC) That sounds like a good thing to look at; but of course we'd need to get a poll that 'actually works (TM)' wrt. the staggered daylight savings nightmare over the next 2 weeks. It'd be great to get something that Rene can join if that's possible, Eike - any chance you could setup a doodle (or other) poll - located at a date safely after the changes in April say - for a new time preferably stil on Thursday (?) :-) Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Fwd: [REVIEW 3-5] fdo#46832 fix uno bootstrapping]
any chance of this going into 3-5 ? ---BeginMessage--- external .NET ( and possibly c++ ) client(s) are failing on 3.5. This is due to missing embedded manifest info in dll(s) built with gbuild resulting in failure to properly load VC90 runtime. Please see http://cgit.freedesktop.org/libreoffice/core/commit/?id=c3d806be7d30a437607d924a4d33f13fe20dd1ba thanks, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ---End Message--- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] convert tools/table.hxx to std::map in Chart2PositionMap class
Hi License in on file. This patch applies on top of my cleanup patches from earlier today. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0001-Convert-tools-table.hxx-to-std-map-in-Chart2Position.patch Description: application/mbox ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 clio fyv...@ya.ru changed: What|Removed |Added Depends on||46102 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] removed unused code
Hi there,
another unused code removed (part of oox).
Regards,
Petr
From 2221c91a53383024121bfa01f01055510e3642ae Mon Sep 17 00:00:00 2001
From: Petr Vorel petr.vo...@gmail.com
Date: Fri, 16 Mar 2012 12:44:20 +0100
Subject: [PATCH] removed unused code
---
oox/inc/oox/drawingml/textbodyproperties.hxx |1 -
oox/inc/oox/drawingml/textliststyle.hxx|4 -
oox/inc/oox/export/chartexport.hxx |5 -
oox/source/drawingml/chart/objectformatter.cxx | 14 --
oox/source/drawingml/fillproperties.cxx|5 -
oox/source/drawingml/shape.cxx | 12 --
oox/source/drawingml/textbodyproperties.cxx|5 -
oox/source/drawingml/textliststyle.cxx | 11 --
oox/source/export/ColorPropertySet.cxx | 10 --
oox/source/export/ColorPropertySet.hxx |3 -
oox/source/export/chartexport.cxx | 187
oox/source/export/drawingml.cxx| 35 -
unusedcode.easy| 14 --
13 files changed, 0 insertions(+), 306 deletions(-)
diff --git a/oox/inc/oox/drawingml/textbodyproperties.hxx b/oox/inc/oox/drawingml/textbodyproperties.hxx
index e155d30..adb9c1f 100644
--- a/oox/inc/oox/drawingml/textbodyproperties.hxx
+++ b/oox/inc/oox/drawingml/textbodyproperties.hxx
@@ -47,7 +47,6 @@ struct TextBodyProperties
explicitTextBodyProperties();
-voidpushToPropMap( PropertyMap rPropMap ) const;
voidpushVertSimulation();
};
diff --git a/oox/inc/oox/drawingml/textliststyle.hxx b/oox/inc/oox/drawingml/textliststyle.hxx
index 5ce8ef7..29d8f29 100644
--- a/oox/inc/oox/drawingml/textliststyle.hxx
+++ b/oox/inc/oox/drawingml/textliststyle.hxx
@@ -51,10 +51,6 @@ public:
inline const TextParagraphPropertiesVector getAggregationListStyle() const { return maAggregationListStyle; };
inline TextParagraphPropertiesVector getAggregationListStyle() { return maAggregationListStyle; };
-#if OSL_DEBUG_LEVEL 0
-void dump() const;
-#endif
-
protected:
TextParagraphPropertiesVector maListStyle;
diff --git a/oox/inc/oox/export/chartexport.hxx b/oox/inc/oox/export/chartexport.hxx
index 5bca83f..e041c38 100644
--- a/oox/inc/oox/export/chartexport.hxx
+++ b/oox/inc/oox/export/chartexport.hxx
@@ -157,9 +157,6 @@ private:
::com::sun::star::uno::Reference
::com::sun::star::chart2::XDataSeriesaSeriesSeq,
sal_Bool bJapaneseCandleSticks, sal_Int32 nAttachedAxis );
-void exportDataSeq(
-const com::sun::star::uno::Reference ::com::sun::star::chart2::data::XDataSequence xValueSeq,
-sal_Int32 elementTokenId );
void exportSeriesText(
const com::sun::star::uno::Reference ::com::sun::star::chart2::data::XDataSequence xValueSeq );
void exportSeriesCategory(
@@ -176,8 +173,6 @@ private:
void exportFirstSliceAng();
void exportAxes( );
-void exportXAxis( AxisIdPair aAxisIdPair );
-void exportYAxis( AxisIdPair aAxisIdPair );
void exportAxis( AxisIdPair aAxisIdPair );
void _exportAxis(
const ::com::sun::star::uno::Reference ::com::sun::star::beans::XPropertySet xAxisProp,
diff --git a/oox/source/drawingml/chart/objectformatter.cxx b/oox/source/drawingml/chart/objectformatter.cxx
index ab9e4cc..2dfdaf9 100644
--- a/oox/source/drawingml/chart/objectformatter.cxx
+++ b/oox/source/drawingml/chart/objectformatter.cxx
@@ -728,11 +728,6 @@ public:
PropertySet rPropSet,
const TextCharacterProperties rTextProps );
-/** Sets automatic line properties to the passed property set. */
-voidconvertAutomaticLine(
-PropertySet rPropSet,
-sal_Int32 nSeriesIdx );
-
/** Sets automatic fill properties to the passed property set. */
voidconvertAutomaticFill(
PropertySet rPropSet,
@@ -1017,15 +1012,6 @@ void ObjectTypeFormatter::convertTextFormatting( PropertySet rPropSet, const Te
maTextFormatter.convertFormatting( rPropSet, rTextProps );
}
-void ObjectTypeFormatter::convertAutomaticLine( PropertySet rPropSet, sal_Int32 nSeriesIdx )
-{
-ShapePropertyMap aPropMap( mrModelObjHelper, *mrEntry.mpPropInfo );
-ModelRef Shape xShapeProp;
-maLineFormatter.convertFormatting( aPropMap, xShapeProp, nSeriesIdx );
-maEffectFormatter.convertFormatting( aPropMap, xShapeProp, nSeriesIdx );
-rPropSet.setProperties( aPropMap );
-}
-
void ObjectTypeFormatter::convertAutomaticFill( PropertySet rPropSet, sal_Int32 nSeriesIdx )
{
ShapePropertyMap aPropMap( mrModelObjHelper, *mrEntry.mpPropInfo );
diff --git a/oox/source/drawingml/fillproperties.cxx b/oox/source/drawingml/fillproperties.cxx
index 0a49985..07df75d 100644
--- a/oox/source/drawingml/fillproperties.cxx
+++ b/oox/source/drawingml/fillproperties.cxx
@@ -376,11
Re: [Libreoffice-ux-advise] [LibreOffice] find ctrl-g/ctrl-shift-g accelerator patch
Hi Cameron, Kendy, *, Jan Holesovsky wrote (06-03-12 11:20) This is some good research, I hope you don't mind if I CC: the devel mailing list, and the UX advise list too? :-) Really appreciate work on this subject! I think this is actually a good question for the UX advise list :-) My proposal would be to get rid of the RepeatSearch functionality (and I for one do use that quite often. And would be surprised if not more people do. Change to another short-cut is OK for me. And I guess people using it have little problem in remembering shot cuts, so if a change if needed for better consistency, another short cut for repeat would be more appreciated then removing it completely. As for the accelerators not working when a text area in a menu bar is selected, I think that might be a bigger problem. For example, this also prevents things like ctrl-s saving a document, which could potentially lead to data loss if someone doesn't know their work is not being saved. I don't know what changing that would actually involve, but I would be happy to work on it if people want that modification. Good point! I have just checked, and it is a more general problem - when you try that in eg. the 'Font size' combobox, you cannot do Ctrl-s either. Should I file an easy hack for that, or will you try to investigate this one too? :-) Maybe related: fdo#43822 ? Cheers, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
heads up excel filter bits moved to sc
I moved on-masse all the excel related ooxml import filter stuff from
oox to sc ( scfilt to be precise ). This will allow us now to access
core functionality on import rather than depending solely on UNO.
I managed to get a full build on linux, and partial ( but a least up to
sc ) for mingw windows. It's possible some other platforms might break
so be aware.
One hack in the sc build is that I need to include the workdir/{platform
dir}/oox/inc to pick up some generated headers. Is this nuts? is there a
better way? Short of regenerating the same stuff in sc ( duplication )
or making the oox generate the files into the solver directly I see no
alternative
Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Promoting RCs on Facebook
Volker Merschmann wrote (07-03-12 13:59) In the meantime I have found the names of the maintainers: Gerard Jensen, Don Crowley, Nikola Yanev I do not know any of them and they are not linked from the FB-page. Can anybody help? Don't know them either. But am willing to post a polite message, if in the mean time (we're only 9 days later ;-) ) not someone else took action on this. regards, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] fdo#37593 Make sure needsUpdate compares canonicalized paths
Please consider the below fix for
https://bugs.freedesktop.org/show_bug.cgi?id=37593 'File New
Template' no longer remembers my last open folder for inclusion in
libreoffice-3-5.
Stephan
On 03/16/2012 03:03 PM, Stephan Bergmann wrote:
commit 32a5ad89a505be22fb8ca0b990a8991a7de6453a
Author: Stephan Bergmannsberg...@redhat.com
Date: Fri Mar 16 14:57:51 2012 +0100
fdo#37593 Make sure needsUpdate compares canonicalized paths
...so that it does not erroneously always claim an update is needed, so
that
SvtDocumentTemplateDialog::UpdateHdl_Impl does not always jump back to
OpenTemplateRoot() shortly after opening the dialog (and thus jumps away
from
the last remembered folder).
diff --git a/svtools/source/misc/templatefoldercache.cxx
b/svtools/source/misc/templatefoldercache.cxx
index d7a5679..1486fb2 100644
--- a/svtools/source/misc/templatefoldercache.cxx
+++ b/svtools/source/misc/templatefoldercache.cxx
@@ -693,6 +693,17 @@ namespace svt
{
String sTemplatePath( aDirs.getToken(0, ';', nIndex) );
sTemplatePath = aPathOptions.ExpandMacros( sTemplatePath );
+
+// Make sure excess .. path segments (from expanding bootstrap
+// variables in paths) are normalized in the same way they are
+// normalized for paths read from the .templdir.cache file (where
+// paths have gone through makeRelocatable URL on writing out and
+// then through makeAbsoluteURL when reading back in), as otherwise
+// equalStates() in needsUpdate() could erroneously consider
+// m_aCurrentState and m_aPreviousState as different:
+sTemplatePath = getOfficeInstDirs()-makeAbsoluteURL(
+getOfficeInstDirs()-makeRelocatableURL(sTemplatePath));
+
// create a new entry
m_aCurrentState.push_back( new TemplateContent( INetURLObject(
sTemplatePath ) ) );
TemplateFolderContent::iterator aCurrentRoot =
m_aCurrentState.end();
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Promoting RCs on Facebook
Hi Cor, 2012/3/16 Cor Nouws oo...@nouenoff.nl: Volker Merschmann wrote (07-03-12 13:59) In the meantime I have found the names of the maintainers: Gerard Jensen, Don Crowley, Nikola Yanev I do not know any of them and they are not linked from the FB-page. Can anybody help? Don't know them either. But am willing to post a polite message, if in the mean time (we're only 9 days later ;-) ) not someone else took action on this. As there is no possiblity to write to the page owners I commented on https://www.facebook.com/libreoffice.org/posts/364685130219760 with some hints, but nobody of them replied. I think we have to wait for the next pre-release and see how they will act. Volker -- Volker Merschmann Member of The Document Foundation http://www.documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files
Hi there, On Tue, 2011-09-27 at 16:03 +0200, Knut Olav Bøhmer wrote: Here is the LibreOffice bug report: https://bugs.freedesktop.org/show_bug.cgi?id=41255 ... I did not check if the patch was applied in latest LibreOffice git repository. If it is, I can just close the bug. It isn't sadly ... it's fantastic to have your patch, thanks for doing that ! Caolan (who is really the expert here and wrote the original patch) had a few concerns about it. Thank you for all the help :) Sorry it's taken so long to get reviewed, I guess having more sample documents, a unit / regression test and/or digging out the link into Microsoft's documentation for these streams - which in theory is now published and complete might really help speed this up (?). ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW 3-5] fdo#46809 incomplete formula in formulabar
please see http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3b1592165d0513e90e28dfee92bc9db032fa221 this is mucho safe imo Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LO Calc AddOn ~ Web Services ~ Java Frame
Hi Nick, libreoffice...@gmail.com wrote (12-03-12 10:45) Dear Admin Developers, (I'm neither of them - just handling some mail with some delay ) Questions: 1. Any chance to do it using LO frame instead of Java ? If yes than will it work faster with LO frames (based on your experience) ? If you prevent waiting for Java to load, native LibreOffice dialogs would be faster. If not, I don't expect much difference. 2. Do you recommend to continue with Java dialog or LO dialog? ... P.S. Can we publish our Add On on LO site when it will be ready ? Sure, much appreciated: http://extensions.libreoffice.org/ greetings, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[GBUILD] Can we get rid of gbuild_simple ?
Hi, I'd like to propose removing gbuild_simple.mk over time. Surely there will be more custom targets as gbuild is growing and I can't see why we would need gbuild_simple. Instead we can write rules to Package_foo.mk makefiles or if that would be problem (because they will be ugly) We can start using CutomTarget_foo.mk which will be supposed to be ugly. The reasons are: 1, Sometimes we need to parse custom target's Makefile each time as in packimages case. I had to use: $(eval $(call gb_CustomTarget_add_outdir_dependencies,packimages/pack,\ $(gb_Helper_PHONY) \ )) to achieve that. 2, It is enough then to write dependencies only once. 3, No need to maintain gbuild_simple. 4, No recursive make running. I am sending two patches for packimages. Maybe we should use the second one and keep Package_foo.mk pretty ? One small disadvantage is that we need to depend on directory. It allows as to use compatible mode and keep old way of processing custom targets until they are replaced. There are 31 custom targets now, so that should not be a big problem. I can do it over time or maybe we could even write an easy hack for that. The important thing is to write new custom targets in CustomTarget_foo.mk makefile. What do you think ? Am I missing something ? Regards, Matus From 938249e500ea108a07c42df95122d6826df594fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C3=BA=C5=A1=20Kukan?= matus.ku...@gmail.com Date: Fri, 16 Mar 2012 13:10:12 +0100 Subject: [PATCH] packimages: do not use custom Makefile --- packimages/Package_images.mk | 51 ++ packimages/pack/Makefile | 70 -- 2 files changed, 44 insertions(+), 77 deletions(-) delete mode 100644 packimages/pack/Makefile diff --git a/packimages/Package_images.mk b/packimages/Package_images.mk index 21be311..6a72d96 100644 --- a/packimages/Package_images.mk +++ b/packimages/Package_images.mk @@ -25,17 +25,54 @@ # in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable # instead of those above. -$(eval $(call gb_Package_Package,packimages_images,$(WORKDIR)/CustomTarget/packimages/pack)) +CDPI := $(WORKDIR)/CustomTarget/packimages -$(eval $(call gb_Package_add_customtarget,packimages_images,packimages/pack)) - -$(eval $(call gb_CustomTarget_add_outdir_dependencies,packimages/pack,\ - $(gb_Helper_PHONY) \ -)) +$(eval $(call gb_Package_Package,packimages_images,$(CDPI))) $(eval $(call gb_Package_add_file,packimages_images,bin/images.zip,images.zip)) +$(eval $(call gb_Package_add_file,packimages_images,bin/images_brand.zip,images_brand.zip)) -$(foreach theme,$(WITH_THEMES) brand,\ +$(foreach theme,$(WITH_THEMES),\ $(eval $(call gb_Package_add_file,packimages_images,bin/images_$(theme).zip,images_$(theme).zip))) +# Custom sets, at 24x24 16x16 fall-back to Tango preferentially +# (Tango fallbacks to Industrial for the missing icons) +CUSTOM_images := $(foreach theme,$(WITH_THEMES),$(CDPI)/images_$(theme).zip) +CUSTOM_PREFERRED_FALLBACK_1 := -c $(SRCDIR)/icon-themes/tango +CUSTOM_PREFERRED_FALLBACK_2 := -c $(SRCDIR)/icon-themes/industrial + +$(call gb_Package_get_target,packimages_images): \ + $(CDPI)/images.zip $(CDPI)/images_brand.zip $(CUSTOM_images) + +$(CDPI)/images.zip: $(CDPI)/sorted.lst $(CDPI)/commandimagelist.ilst + $(call gb_Helper_abbreviate_dirs_native, \ + $(PERL) $(SOLARENV)/bin/packimages.pl -g $(SRCDIR)/icon-themes/galaxy \ + -m $(SRCDIR)/icon-themes/galaxy -c $(CDPI) \ + -l $(CDPI) -l $(OUTDIR)/res/img -s $ -o $@) + +$(CDPI)/images_%.zip: $(CDPI)/sorted.lst $(CDPI)/commandimagelist.ilst + $(call gb_Helper_abbreviate_dirs_native, \ + $(PERL) $(SOLARENV)/bin/packimages.pl -g $(SRCDIR)/icon-themes/galaxy \ + -m $(SRCDIR)/icon-themes/galaxy -c $(SRCDIR)/icon-themes/$* \ + $(CUSTOM_PREFERRED_FALLBACK_1) $(CUSTOM_PREFERRED_FALLBACK_2) \ + -l $(CDPI) -l $(OUTDIR)/res/img -s $ -o $@) + +# make sure to have one to keep packing happy +$(CDPI)/images_brand.zip: + @touch $@ + +# commandimagelist.ilst and sorted.lst are phony to rebuild everything each time +.PHONY: $(CDPI)/commandimagelist.ilst $(CDPI)/sorted.lst + +$(CDPI)/commandimagelist.ilst: + $(call gb_Helper_abbreviate_dirs_native, \ + find $(SRCDIR)/icon-themes/galaxy/cmd -name *.png | \ + sed s#$(SRCDIR)/icon-themes/galaxy#%MODULE%# | \ + $(PERL) $(SOLARENV)/bin/sort.pl $@.$(INPATH) \ + $(PERL) $(SOLARENV)/bin/diffmv.pl $@.$(INPATH) $@) + +$(CDPI)/sorted.lst: $(SRCDIR)/packimages/pack/image-sort.lst + $(call gb_Helper_abbreviate_dirs_native, \ + $(PERL) $(SOLARENV)/bin/image-sort.pl $ $(OUTDIR)/xml $@) + # vim: set noet sw=4 ts=4: diff --git a/packimages/pack/Makefile b/packimages/pack/Makefile deleted file mode 100644 index 5d88e25..000 --- a/packimages/pack/Makefile +++ /dev/null @@ -1,70 +0,0 @@ -# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- -# -# Version: MPL 1.1 / GPLv3+ / LGPLv3+ -# -# The contents of this file are subject to the Mozilla Public License
Re: [GBUILD] Can we get rid of gbuild_simple ?
On 03/16/2012 03:47 PM, Matúš Kukan wrote: 3, No need to maintain gbuild_simple. FWIW, in http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e67c03dc0225fc66343546b14e902b9d238b1a3 Enable -Wnon-virtual-dtor for GCC 4.6 I switched some CustomTarget Makefiles from including gbuild_simple.mk to plain gbuild.mk just recently, as they referenced variables that are only defined in proper gbuild.mk (gb_UnoApiTarget_CPPUMAKERTARGET). And that made me wonder what gbuild_simple.mk is actually necessary for, if anything. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED-3-5] fdo#31551 - lines in legend not shown with current width ...
Michael Meeks wrote: It seems (on the face of it) reasonably simple; does it make sense to have it in 3.5.2 (rc1 deadline is Monday IIRC) :-) Yes, it does - cherry-picked into -3-5. -- Thorsten pgp1Xk5QwBrtl.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [libreoffice-website] Re: Promoting RCs on Facebook
On Fri, 2012-03-16 at 15:34 +0100, Volker Merschmann wrote: Hi Cor, 2012/3/16 Cor Nouws oo...@nouenoff.nl: Volker Merschmann wrote (07-03-12 13:59) In the meantime I have found the names of the maintainers: Gerard Jensen, Don Crowley, Nikola Yanev I do not know any of them and they are not linked from the FB-page. Can anybody help? Don't know them either. But am willing to post a polite message, if in the mean time (we're only 9 days later ;-) ) not someone else took action on this. As there is no possiblity to write to the page owners I commented on https://www.facebook.com/libreoffice.org/posts/364685130219760 with some hints, but nobody of them replied. I think we have to wait for the next pre-release and see how they will act. Well, at least the general public can post to their page - more then can be said for some. Volker -- Volker Merschmann Member of The Document Foundation http://www.documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GBUILD] Can we get rid of gbuild_simple ?
And that made me wonder what gbuild_simple.mk is actually necessary for, if anything. Hear, hear. Having a separate gbuild_simple.mk makes things more complicated, not simpler. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] modify default behaviour of the format paintbrush
Hi Maxime, Maxime de Roucy wrote (14-03-12 18:38) Two new patchs that modify the default behaviour of the format paintbrush. 0001-Format-paintbrush-default-behaviour.patch To apply to the core repository. 0001-Change-format-paintbrush.patch To apply to the help repository. By default the paintbrush doesn't copy the paragraph formatting ; if Ctrl is hold, paragraph and character formatting are copied ; if Ctrl and Shift are hold, only the paragraph formatting is copied. I tried the paintbrush right now, and see that it does copy the paragraph style too (I vaguely remember that from a presentation at the first OOoCon I attended, 2004 :-) ) Is this change based on the idea, that people who use the paintbrush are not that much looking at styles, and thus that copying those styles might do more harm then good for them? Regards, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW: 3-5, 3-4][CANCELLED] fdo#43932 setting paper tray from print dialog
Hi David, David Tardon wrote (15-03-12 14:14) I am too, apparently. I am hereby cancelling this request pending further investigation. I know there are some bugs around paper settings and printing. If you didn't yet see them, I might try to see (next week) if there is some pattern in them. Might help? Cheers, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
EasyHack proposition - Crop image functionality improvement (fdo#34555)
Can some developer please look at https://bugs.freedesktop.org/show_bug.cgi?id=34555 and check if it's suitable to be filled as an EasyHack (and fill it if it is)? The current crop functionality in Writer and Calc is really ridiculously bad and source of many user complaints. All the needed functionality is already present in Draw. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45219, which changed state. Bug 45219 Summary: SLIDESHOW: Transparency gradient effect fade in with wrong VIEWING https://bugs.freedesktop.org/show_bug.cgi?id=45219 What|Old Value |New Value Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [REVIEW 3-5] fdo#46832 fix uno bootstrapping
On 08/03/12 17:14, Noel Power wrote: external .NET ( and possibly c++ ) client(s) are failing on 3.5. This is due to missing embedded manifest info in dll(s) built with gbuild resulting in failure to properly load VC90 runtime. Please see http://cgit.freedesktop.org/libreoffice/core/commit/?id=c3d806be7d30a437607d924a4d33f13fe20dd1ba pushed to libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=c6246139df005d6ac4627bc8f4665539effb6e94 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call 2012-03-15 1500 UTC
Hi, On Friday, 2012-03-16 12:39:32 +, Michael Meeks wrote: On Thu, 2012-03-15 at 19:07 +0100, Bjoern Michaelsen wrote: AA: + announce very loudly if the call changes slot in UTC timezone (Michael) So - it's a good time to think about a new time. + 17:00 local might be preferable to quite a few (Eike) AA: + is that 1700 CET or CEST? (1600UTC or 1500UTC) Actually 16:00 local time, as some of us will have another call on 17:00 CEST (actually that call follows US time but that's already in DST mode), so if we wanted to keep old schedule in European local time the ESC call should be 14:00 UTC now. That sounds like a good thing to look at; but of course we'd need to get a poll that 'actually works (TM)' wrt. the staggered daylight savings nightmare over the next 2 weeks. There's only one call left on Mar-22 that's in the in-between-DST days (CEST starts Mar-25 in most countries), changing that and again change from Mar-29 on calls for more confusion than keeping a possibly unfortunate schedule for Mar-22. It'd be great to get something that Rene can join if that's possible, Eike - any chance you could setup a doodle (or other) poll - located at a date safely after the changes in April say - for a new time preferably stil on Thursday (?) :-) Done, http://moreganize.com/bgxbvmFxmDl Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgprTOEX2ZzSs.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
relicensing agreement
Hi, In the spirit of relicensing effort I'm stating that: All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code. My submissions were using one of these emails: ar...@pld-linux.org ar...@maven.pl -- Arkadiusz MiśkiewiczPLD/Linux Team arekm / maven.plhttp://ftp.pld-linux.org/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] Consistent use of alpha in cairocanvas
Hi there, the cairocanvas was slightly inconsistent in it's use of the alpha channel, when copying from a vcl bitmap. Cosmetic change to use GetIndex() instead of GetBlue() (same component), and use 255 aka opaque if no alpha bitmap access available. Cherry-pick into -3-5 appreciated. http://cgit.freedesktop.org/libreoffice/core/commit/?id=83114b27fac8ef723cbbaa734237210d9ad56a15 Cheers, -- Thorsten pgpg4oEyInbtP.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] Another partial fix for fdo#45219
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=50309b9574c43de93a05576904813881eb7bc898 ensures that the pseudo-alphachannel of the vclcanvas gets the right content for transparent polygons - since this alphachannel is a 1bpp mask, we either make it fully transparent, or fully opaque. This fixes the polygon with uniform transparency set comes out ugly part of fdo#45219. Cheers, -- Thorsten pgpaNeg5NQcuk.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 brinzing oliver.brinz...@gmx.de changed: What|Removed |Added CC||oliver.brinz...@gmx.de --- Comment #233 from brinzing oliver.brinz...@gmx.de 2012-03-16 09:54:49 PDT --- . -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] Return proper transparency value even for ignore_color.
Hi there, found while reviewing the code - http://cgit.freedesktop.org/libreoffice/core/commit/?id=4b475f31eb9b290b477bb6992ff28e52248cee5d moves setting nTransparency out of the eColorType != IGNORE_COLOR branch, thusly ensuring that calling code gets a sensible return value even in IGNORE_COLOR cases. Cheers, -- Thorsten pgpVwwpPD4l3g.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] Use transparency for gradients fdo#45219
Hi there, previously, vclcanvas simply ignored transparency settings for gradient fills. http://cgit.freedesktop.org/libreoffice/core/commit/?id=3f5efa1e76e187070d412d102e4c057679065bcc fixes this by filling the appropriate area with either black or white (note that vclcanvas has 1bpp alpha). Cheers, -- Thorsten pgpTz04MoQjWH.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] Clear sprites to white fdo#45219.
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=b9266113514657be1cf9352e1457a5c62876784c uses transparent-white to clear the update area in an animated layer during slideshow. This is an especially ugly fix, since it's exposing the vclcanvas 1bpp-no-true-compositing shortcoming to client code. Alas, there's no real other fix, beyond re-doing lots of vclcanvas (or, rather more preferred, retiring it completely). Note that for real alpha, this shouldn't make a difference - (1,1,1,0) is still (0,0,0,0) premultiplied... ...we need to double-check on windows though. ;) Cheers, -- Thorsten pgpurPwGfPPMm.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] Clear whole layer in slideshow sprites fdo#45219
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=d32cf8d820be839c7303e3c5962c17f64cac2812 fixes the ugly dark rectangle in part of the shape subset of fdo#45219 - because the clearing rectangle was errorneously offset by the topleft corner of the sprite - it should rather start at (0,0). Second part of the fix came up during code review - maLayerBoundsPixel is lazy-initialized inside the getCanvas() call, and evaluation order of function parameters is unspecified. Cheers, -- Thorsten pgpNOEBwNjeLM.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] Remove nasty xor hack for non-Mac vclcanvas
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=315d82d741c37d1b77f5687b1bdc48a37fb9f29f removes one more XOR-hack to avoid clipping a polygon on win32/X11 - I would expect this optimization to rather be a pessimization nowadays, it at least runs nicely here on Xorg now. Cheers, -- Thorsten pgpMe15s0GZMo.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] correction of faulty comment
Attached very simple patch, the comment preceding class definition mentions wrong class. No effect on compiling/running at all, but a bit annoying when opengrokking for Svx...ToolBoxControls ;) WinfriedFrom 0f41a91d2529b58b0135d20a2cc139dad87626b2 Mon Sep 17 00:00:00 2001 From: Winfried Donkers o...@dci-electronics.nl Date: Fri, 16 Mar 2012 18:13:49 +0100 Subject: [PATCH] correction of typo in comment --- svx/inc/svx/linectrl.hxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/svx/inc/svx/linectrl.hxx b/svx/inc/svx/linectrl.hxx index 2c3d10c..8c43a11 100644 --- a/svx/inc/svx/linectrl.hxx +++ b/svx/inc/svx/linectrl.hxx @@ -154,7 +154,7 @@ public: }; // -// class SvxColorToolBoxControl +// class SvxLineEndToolBoxControl // class SVX_DLLPUBLIC SvxLineEndToolBoxControl : public SfxToolBoxControl -- 1.7.7 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LibreOffice / go-oo license ...
As Michael requested: All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code. If you want to use a different open source license, that's probably fine with me as well, just drop me a line to confirm. Enjoy :) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] Fix fdo#45219 wrong transparency for animated objects.
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c7e061997202df9e602e209cf40c61606582e8e fixes the most obvious glitch in fdo#45219 - multiple paints of the same sprite on top of each other, killing the hue for transparent objects. (std::unique in this case _needs_ to eliminate duplicate, but otherwise equal-under-SpriteWeakOrder entries. Also, std::unique wants a BinaryPredicate, not a StrictWeakOrder. Note further that the used rtl::Reference does have a working operator==) Cheers, -- Thorsten pgp2gRgfLB9cC.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [OBSOLETE][PATCH] convert tools/table.hxx usage to std::map in ICGM filter in CGMElements class
Hi Noel, This is already done in your commit 64cba6e58263e906aba6a110937f362d1e31ebe5 but in a different way though. Cheers, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
License statement
Hi, All my contributions, past and future, to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEWED] [PUSHED 3-5] fix for fdo#47307, crash in Insert names dialog
On Fri, 2012-03-16 at 00:30 +0100, Markus Mohrhard wrote: Hey, [1] prevents a crash in the insert names dialog. ScRangeManagerTable expects a reference to the range names and therefore using the temporary object in the insert names dialog is wrong. This fix is simple and I think we can add it to 3-5. Reviewed and pushed to 3-5 with my sign off. -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
LibreOffice was accepted for Google Summer of Code 2012
The title tells it all. And may the applications start to fall like a refreshing rain. For all interested students, accomplished Easy Hacks are a must for being eligible and being involved already with the community is a big plus. That is it for now ;) Have a nice weekend Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ANN] LibreOffice 3.4.6 RC2 available
Dear Community, The Document Foundation is happy to announce the second release candidate of LibreOffice 3.4.6. The upcoming 3.4.6 will be the sixth in a series of frequent bugfix releases for our 3.4 code line. Please be aware that LibreOffice 3.4.6 RC2 is not yet ready for production use, you should continue to use LibreOffice 3.4.5 for that. The release is available for Windows, Linux and Mac OS X from our QA builds download page at http://www.libreoffice.org/download/pre-releases/ Should you find bugs, please report them to the FreeDesktop Bugzilla: https://bugs.freedesktop.org For other ways to get involved with this exciting project - you can e.g. contribute code: https://www.libreoffice.org/get-involved/developers/ translate LibreOffice to your language: http://wiki.documentfoundation.org/Translation_for_3.4 or help with funding our operations: http://challenge.documentfoundation.org/ A list of known issues with 3.4.6 RC2 is available from our wiki: http://wiki.documentfoundation.org/Releases/3.4.6/RC2 Please find the list of changes against LibreOffice 3.4.6 RC1 here: http://download.documentfoundation.org/libreoffice/src/bugfixes-libreoffice-3-4-6-release-3.4.6.2.log Let us close again with a BIG Thank You! to all of you having contributed to the LibreOffice project - this release would not have been possible without your help. Yours, The Document Foundation Board of Directors pgpXaDNkIXvMg.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Can't compile from source, i18npool project segfaults with parallel build
16.03.2012 13:44, Thorsten Behrens пишет: uh.li...@gmail.com wrote: I'm trying to build LibreOffce 3.5 and 3.5.1 from source, but build always failed with i18npool project. I'm using parallel build. Same build script compiles 3.4.5 and older versions. Tested with x86 and x86_64 machine. GCC 4.5.2. Making with -j1 in i18npool wokks, but automatic building whole suite with -j1 takes very long time. Can anybody confirm this? What additional information is needed? Hi there, please provide more information on the specific failure. From your description, it seems you might hit a gnumake bug - what is your gnumake version? You might want to try a self-built make: git clone git://anongit.freedesktop.org/libreoffice/contrib/dev-tools cd dev-tools/make-3.82-gbuild ./configure make and then in your build shell export GNUMAKE=path/to/your/selfbuild/make HTH, -- Thorsten Oh, great thanks. The problem was of outdated gnumake. It was 3.81. Now everything is fine. -- Без гнева и пристрастий. Без Windows и глюков. wbr, Eugene Mikhaylov ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code
This patch removes unused code as listed in unusedcode.easy
From e2ce9edf1b94bff6443257b875fa13255ac71e81 Mon Sep 17 00:00:00 2001
From: Santiago Martinez smvar...@gmail.com
Date: Fri, 16 Mar 2012 20:12:53 +0100
Subject: [PATCH] Remove unused code as listed in unusedcode.easy
---
.../source/drivers/evoab2/NDatabaseMetaData.cxx|7 --
.../source/drivers/evoab2/NDatabaseMetaData.hxx|1 -
connectivity/source/drivers/evoab2/NStatement.cxx | 12
connectivity/source/drivers/evoab2/NStatement.hxx |1 -
connectivity/source/drivers/file/FNoException.cxx |5 --
connectivity/source/drivers/file/fanalyzer.cxx | 61
connectivity/source/inc/file/fanalyzer.hxx |2 -
unusedcode.easy|4 -
8 files changed, 0 insertions(+), 93 deletions(-)
diff --git a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
index 929150a..0a89e58 100644
--- a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx
@@ -147,13 +147,6 @@ namespace connectivity
}
-guint
-getFieldCount()
-{
-initFields();
-return nFields;
-}
-
const ColumnProperty *
getField(guint n)
{
diff --git a/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx b/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
index 45f93b9..2cb7207 100644
--- a/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
+++ b/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx
@@ -64,7 +64,6 @@ namespace connectivity
const SplitEvoColumns* get_evo_addr();
const ColumnProperty *getField(guint n);
-guint getFieldCount() ;
GType getGFieldType(guint nCol) ;
sal_Int32 getFieldType(guint nCol) ;
rtl::OUString getFieldTypeName(guint nCol) ;
diff --git a/connectivity/source/drivers/evoab2/NStatement.cxx b/connectivity/source/drivers/evoab2/NStatement.cxx
index 36786a4..81beb26 100644
--- a/connectivity/source/drivers/evoab2/NStatement.cxx
+++ b/connectivity/source/drivers/evoab2/NStatement.cxx
@@ -163,18 +163,6 @@ void SAL_CALL OCommonStatement::close( ) throw(SQLException, RuntimeException)
}
// -
-void OCommonStatement::reset() throw (SQLException)
-{
-::osl::MutexGuard aGuard( m_aMutex );
-checkDisposed(OCommonStatement_IBase::rBHelper.bDisposed);
-
-
-clearWarnings ();
-
-if (m_xResultSet.get().is())
-clearMyResultSet();
-}
-
void OCommonStatement::clearMyResultSet () throw (SQLException)
{
::osl::MutexGuard aGuard( m_aMutex );
diff --git a/connectivity/source/drivers/evoab2/NStatement.hxx b/connectivity/source/drivers/evoab2/NStatement.hxx
index d12956e..3d6d923 100644
--- a/connectivity/source/drivers/evoab2/NStatement.hxx
+++ b/connectivity/source/drivers/evoab2/NStatement.hxx
@@ -190,7 +190,6 @@ namespace connectivity
virtual ~OCommonStatement();
protected:
-void reset () throw( ::com::sun::star::sdbc::SQLException);
void clearMyResultSet () throw( ::com::sun::star::sdbc::SQLException);
void parseSql( const ::rtl::OUString sql, QueryData _out_rQueryData );
EBookQuery *whereAnalysis( const OSQLParseNode* parseTree );
diff --git a/connectivity/source/drivers/file/FNoException.cxx b/connectivity/source/drivers/file/FNoException.cxx
index 8090295..67599cb 100644
--- a/connectivity/source/drivers/file/FNoException.cxx
+++ b/connectivity/source/drivers/file/FNoException.cxx
@@ -66,11 +66,6 @@ void OPredicateCompiler::Clean()
m_aCodeList.clear();
}
// -
-void OSQLAnalyzer::clean()
-{
-m_aCompiler-Clean();
-}
-// -
void OSQLAnalyzer::bindParameterRow(OValueRefRow _pRow)
{
OCodeList rCodeList= m_aCompiler-m_aCodeList;
diff --git a/connectivity/source/drivers/file/fanalyzer.cxx b/connectivity/source/drivers/file/fanalyzer.cxx
index d5f327d..fcaba19 100644
--- a/connectivity/source/drivers/file/fanalyzer.cxx
+++ b/connectivity/source/drivers/file/fanalyzer.cxx
@@ -212,67 +212,6 @@ void OSQLAnalyzer::bindSelectRow(const OValueRefRow _pRow)
return pKeySet;
}
-//--
-void OSQLAnalyzer::describeParam(::rtl::ReferenceOSQLColumns rParameterColumns)
-{
-OCodeList rCodeList= m_aCompiler-m_aCodeList;
-OCodeStack aCodeStack;
-
-if (!rCodeList.size())
-return; // no predicate
-if (!rParameterColumns-get().size())
-return; // no parameters
-
-// Create columns, that have a more precise description for the included
Re: [REVIEWED][PUSHED 3-5] fix for fdo#47285, sorting cells with relative refs may invalidate some
On Fri, 2012-03-16 at 10:53 +0100, Markus Mohrhard wrote: Hey, [1] fixes a problem when you sort cells with relative refs. The update for absolute refs needs the information about the original referenced cell and therefore the relative references should be updated after the absolute ones. The relative references don't need any information about their position and therefore there is no problem to update them after the absolute refs. [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=2118ec3630fe12ff2a663c94421780870f264e83 I checked confirm that the change fixes the problem with relative references, while the absolute references aren't affected by the change. Pushed to 3-5 with my sign off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED-3-5] remove un-necessary oox linkage ...
Lubos just did a nice fix in master to not link oox into libswlo when we don't need it; it's a one-liner This is me signing it off for -3-5 I guess ;-) HTH, Michael. diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk index 2b0bce3..4d5cdd6 100644 --- a/sw/Library_sw.mk +++ b/sw/Library_sw.mk @@ -61,7 +61,6 @@ $(eval $(call gb_Library_add_linked_libs,sw,\ i18nisolang1 \ i18nutil \ lng \ -oox \ sal \ salhelper \ sax \ -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: EasyHack proposition - Crop image functionality improvement (fdo#34555)
On Fri, 16 Mar 2012 16:44:04 +0100, khagaroth khagar...@gmail.com wrote: Can some developer please look at https://bugs.freedesktop.org/show_bug.cgi?id=34555 and check if it's suitable to be filled as an EasyHack (and fill it if it is)? The current crop functionality in Writer and Calc is really ridiculously bad and source of many user complaints. All the needed functionality is already present in Draw. well, I started using the CropOOo extension and it does a nice job. http://aoo-extensions.sourceforge.net/en/project/cropooo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEWED][PUSHED 3-5] fix for fdo#47393, unable to cancel html paste
On Fri, 2012-03-16 at 10:56 +0100, Markus Mohrhard wrote: Hey, [1] fixes the issue that we are unable to cancel the html paste dialog and paste the content even after pressing the cancel button. This patch is extremely safe and I think we can easily add it to 3-5. Confirmed that the change fixes the report bug, and also checked the regular html import is unaffected. Pushed to 3-5 with my sign off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-5] fdo#46809 incomplete formula in formulabar
On Fri, 2012-03-16 at 08:37 -0600, Noel Power wrote: please see http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3b1592165d0513e90e28dfee92bc9db032fa221 Yes. We already discussed this did a thorough test yesterday on IRC. I confirm that this change resolves the out-of-sync range input with mouse between the cell and the input bar, and also does not re-introduce a crash when typing Japanese via scim (which was the reason for the change which introduced the regression). Pushed to 3-5 with my sign off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] revert fdo#33090 to fix fdo#46750 memory corrupter
So, I'd prefer to live with fdo#33090 (a Thai text rendering issue) than have the subtle memory corruption in fdo#46750 - so I suggest that we revert: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e601c32661735e9fd78def7ee11bfe21279cca71 in libreoffice-3-5 for Monday - unless anyone has a better idea ( Caolan did you get to the bottom of the maze to find a fix ? :-) Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW][3-5] Re: fdo#46926 needs another fix
On 13/03/12 10:31, Petr Mladek wrote: Caolán McNamara píše v Po 12. 03. 2012 v 13:50 +: On Fri, 2012-03-09 at 15:48 +0100, Michael Stahl wrote: On 07/03/12 11:37, Michael Stahl wrote: PS: please somebody review the above 2 commits and backport to libreoffice-3-5. additionally this one is necessary Full three patches cherry-picked to 3-5 now. Marking the thread as pushed. hi all, David found another problem, the rich comparison function also crashes. i've committed David's fix on master, please apply to libreoffice-3-5: http://cgit.freedesktop.org/libreoffice/core/commit/?id=742dca7366ba6ac3c58b1df6ee548788f4ce24e7 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW][3-5] fdo#42750 sw: thin table borders hidden by subsidiary lines
in Writer, the subsidiary lines for tables are drawn on top of the border lines, hiding them completely if they are very thin. this is a regression in LO 3.4: in commit 0f0896c26fb260d1bbf31d7a886df3f61837f0f2 the drawing of the borders was changed completely and they are now drawn immediately, while previously they were added to a pLines array first and painted later. this fix introduces a new array to store the borders and paints them after the subsidiary lines are done, effectively on top of the subsidiary lines. http://cgit.freedesktop.org/libreoffice/core/commit/?id=804d0a896731629397c5328c13c04a45bc55f459 there is quite a bit of complex stuff going on in paintfrm.cxx with border lines and subsidiary lines, e.g. the subsidiary lines are actually checked and the ones that overlap with border lines are removed and never painted, but unfortunately that does not work with the new way the border lines are painted (via drawinglayer), and so i'm not sure if there are not even more problems here. i've also tried to avoid adding a new global variable by adding a parameter to some methods, but it turned out it would be necessary to add this to SwFrm::Paint, which is overridden in a boatload of subclasses, so i didn't like have that in -3-5. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LibreOffice / openIndiana ...
On 05/03/12 16:03, Jonathan Adams wrote:
Still a work in progress ... and a couple of when it stops at this
point run this command kinda hacks.
diff patch is attached, you'll just have to see how far you can get with it..
hi Jonathan,
i've pushed a lot of this to master now, i.e. this commit and its
descendents:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=db96b0926794b53e547246e4c743e86f31eed461
could you please confirm that you contribute your patch under
MPL/LGPLv3+ license?
the best way is to send a blanket mail to this list with the license for
all your past and future contributions to LO, add yourself to this wiki
page and add a link to that mail in the wiki page:
http://wiki.documentfoundation.org/Development/Developers
some of the commits are cleaner re-implementations of what's in your
patch; hopefully the nss and soltools work for you.
the remainder is this stuff which i thought was too hacky to commit
as-is or should be unnecessary:
diff --git a/libexttextcat/makefile.mk b/libexttextcat/makefile.mk
index f4f5383..271e971 100644
--- a/libexttextcat/makefile.mk
+++ b/libexttextcat/makefile.mk
@@ -88,4 +88,4 @@ $(BIN)/fingerprint.zip:
$(PACKAGE_DIR)/$(PREDELIVER_FLAG_FILE)
$(COMMAND_ECHO)zip -j $(ZIP_VERBOSITY) $@
$(MISC)/build$/$(TARFILE_ROOTDIR)$/langclass$/fpdb.conf
$(COMMAND_ECHO)find $(MISC)/build$/$(TARFILE_ROOTDIR)$/langclass$/LM \
-name *.lm -print0 | \
-xargs -0 zip -j $(ZIP_VERBOSITY) $@
+/usr/gnu/bin/xargs -0 zip -j $(ZIP_VERBOSITY) $@
diff --git a/sal/Library_sal.mk b/sal/Library_sal.mk
index 60ab9c9..07a7441 100644
--- a/sal/Library_sal.mk
+++ b/sal/Library_sal.mk
@@ -62,7 +62,7 @@ $(eval $(call gb_Library_add_linked_libs,sal,\
$(if $(filter $(OS),LINUX), \
dl \
) \
- $(if $(filter $(OS),SOLARIS), \
+ $(if $(filter $(OS),NOTSOLARIS), \
nsl \
socket \
) \
diff --git a/sal/osl/unx/file.cxx b/sal/osl/unx/file.cxx
index b8a851f..4f1ab52 100644
--- a/sal/osl/unx/file.cxx
+++ b/sal/osl/unx/file.cxx
@@ -1228,7 +1228,7 @@ SAL_CALL osl_mapFile (
OSL_TRACE(
posix_madvise(..., POSIX_MADV_WILLNEED) failed with %d, e);
}
-#elif defined SOLARIS
+#elif defined NOTSOLARIS
if (madvise(static_cast caddr_t (p), nLength, MADV_WILLNEED) != 0)
{
OSL_TRACE(madvise(..., MADV_WILLNEED) failed with %d, errno);
diff --git a/sal/osl/unx/process.cxx b/sal/osl/unx/process.cxx
index cfaecde..7bcf262 100644
--- a/sal/osl/unx/process.cxx
+++ b/sal/osl/unx/process.cxx
@@ -501,15 +306,17 @@ static void ChildStatusProc(void *pData)
if (! INIT_GROUPS(data.m_name, data.m_gid) ||
(setuid(data.m_uid) != 0))
OSL_TRACE(Failed to change uid and guid, errno=%d (%s),
errno, strerror(errno));
-
-const rtl::OUString envVar(RTL_CONSTASCII_USTRINGPARAM(HOME));
-osl_clearEnvironment(envVar.pData);
+#if defined(LINUX) || defined (FREEBSD) || defined(NETBSD) ||
defined(OPENBSD) || defined(DRAGONFLY) || defined(SUN)
+unsetenv(HOME);
+#else
+putenv(HOME=);
+#endif
}
-if (data.m_pszDir)
-chstatus = chdir(data.m_pszDir);
+ if (data.m_pszDir)
+ chstatus = chdir(data.m_pszDir);
-if (chstatus == 0 ((data.m_uid == (uid_t)-1) || ((data.m_uid ==
getuid()) (data.m_gid == getgid()
+ if (chstatus == 0 ((data.m_uid == (uid_t)-1) || ((data.m_uid
== getuid()) (data.m_gid == getgid()
{
int i;
for (i = 0; data.m_pszEnv[i] != NULL; i++)
diff --git a/sal/osl/unx/util.c b/sal/osl/unx/util.c
index 7411e7f..886a3c7 100644
--- a/sal/osl/unx/util.c
+++ b/sal/osl/unx/util.c
@@ -313,8 +313,8 @@ void osl_InitSparcV9(void)
}
#endif
-#if( defined(__GNUC__) (defined(X86) || defined(X86_64)) )\
-|| ( defined(SOLARIS) defined (__SUNPRO_C) defined(__i386) )
+/* #if( defined(__GNUC__) (defined(X86) || defined(X86_64)) )\ */
+/*|| ( defined(SOLARIS) defined (__SUNPRO_C) defined(__i386) ) */
/* Safe default */
int osl_isSingleCPU = 0;
@@ -344,6 +344,6 @@ void osl_interlockedCountCheckForSingleCPU(void)
}
}
#endif /* defined(_SC_NPROCESSORS_CONF) */
-#endif
+/* #endif */
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/solenv/inc/tg_ext.mk b/solenv/inc/tg_ext.mk
index 0adec0c..016e6d3 100644
--- a/solenv/inc/tg_ext.mk
+++ b/solenv/inc/tg_ext.mk
@@ -172,7 +172,7 @@ $(PACKAGE_DIR)/$(UNTAR_FLAG_FILE) :
$(PRJ)/$(ROUT)/misc/$(TARFILE_MD5)-$(TARFILE
$(COMMAND_ECHO)cd $(PACKAGE_DIR)$(fake_root_dir) ( $(shell @$(TYPE)
$(PRJ)/$(ROUT)/misc/$(TARFILE_MD5)-$(TARFILE_NAME).unpack)) $(TOUCH)
$(UNTAR_FLAG_FILE)
@echo make writeable...
@-cd $(PACKAGE_DIR) chmod -R +rw $(TARFILE_ROOTDIR)
Patchtool
Hi everyone, For the last few days I have been working on a tool I call patchtool. Check it out here: http://thejosh.info/libreoffice/patchtool/ It scrapes the mailing-list archives, looking for messages with a subject of [PATCH] or [PUSHED]. Those messages go into a database, and get threaded together based on subject lines. If PUSHED is found in the subject or body of any message, the pushed flag is shown on the patch viewer. Attachments are searched also, but currently it just links to the ones in the mailing list archive. It's still a little rough, and at the moment I'm manually running the cron-script, but I like it thus far. I would like to add a feature where it downloads patches and does a git apply --check, and will flag patches which are clean (against master). Cheers, Josh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Patchtool
On Fri, Mar 16, 2012 at 6:33 PM, Josh Heidenreich josh.sickm...@gmail.com wrote: Hi everyone, For the last few days I have been working on a tool I call patchtool. Check it out here: http://thejosh.info/libreoffice/patchtool/ very cool... Do you have the source somewhere public ? I've had on my to-do list to do something in that line, but not only for patches :-) ( /me what to adapt that to deal with membership application, and license statment) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Patchtool
On Fri, Mar 16, 2012 at 6:33 PM, Josh Heidenreich josh.sickm...@gmail.com wrote: Hi everyone, I would like to add a feature where it downloads patches and does a git apply --check, and will flag patches which are clean (against master). And I would like to go further and apply and push these patch to gerrit for review... Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Patchtool
On Fri, Mar 16, 2012 at 06:47:56PM -0500, Norbert Thiebaud wrote: On Fri, Mar 16, 2012 at 6:33 PM, Josh Heidenreich josh.sickm...@gmail.com wrote: Hi everyone, I would like to add a feature where it downloads patches and does a git apply --check, and will flag patches which are clean (against master). And I would like to go further and apply and push these patch to gerrit for review... +over 9000! Great stuff there, Josh! Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] [PUSHED] correction of faulty comment
On Fri, 2012-03-16 at 18:15 +0100, Winfried Donkers wrote: Attached very simple patch, the comment preceding class definition mentions wrong class. No effect on compiling/running at all, but a bit annoying when opengrokking for Svx...ToolBoxControls ;) Simple enough. Pushed. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Regressions in Open Source projects ...
Hi, I do not want to invest too much time into this discussion, because that only hinders me and you all to contribute to the project and to solve the problems. But I strongly disagree with all belittlement of regressions. Although IMHO creation of 3.5.0 has been a good job, it would not be usable for me, if I were a normal user. Here some parts of my daily work with LibO OOo: a) Regression Bug 47096 EDITING: Alt + Drag and Drop for complete rows impossible in particular documents frequently forces me to use 3.4.5. b) Regression Bug 45385 EDITING: Copy Paste formula to different document adds source document filename to references (what even isn't accepted as a bug, but will be a showstopper for me to use LibO if no solution will be found) frequently forces me to use 3.4.5. c) 3.4 has no working e-mail mail merge, so I have to use 3.5 for this. d) No LibO version shows line width in Chart legend correctly because of Bug 31551 Lines in legend not shown with current width, so I have to use OOo 3.1.1 for some needs (inherited problem, 3.3 has the same problem like LibO). But unfortunately OOo 3.1.1 is very unstable with my master documents edited with LibO. May be you understand why I have some empathy for users fulminating on mailing lists and why I never recommended LibO to friends without many reservations? But we should use our time to find and eliminate these problems instead of whining, thanks to all pest control helpers. Best regards Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
