[Libreoffice-commits] .: 2 commits - sw/qa writerfilter/source
sw/qa/extras/rtftok/data/fdo48023.rtf |8
sw/qa/extras/rtftok/rtftok.cxx | 25 +
writerfilter/source/rtftok/rtfdocumentimpl.cxx | 17 +++--
3 files changed, 48 insertions(+), 2 deletions(-)
New commits:
commit e0190ffa766dbe26a9d4e9dd29e00baaf0ccd5b9
Author: Miklos Vajna vmik...@suse.cz
Date: Sat Apr 21 11:28:41 2012 +0200
rtftok: dump collected strings after encoding
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 2b30481..e50cc1f 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -818,9 +818,9 @@ int RTFDocumentImpl::resolveChars(char ch)
m_aStates.top().aLevelNumbers.push_back(sal_Int32(ch));
return 0;
}
-SAL_INFO(writerfilter, OSL_THIS_FUNC : collected ' aStr.getStr()
');
OUString aOUStr(OStringToOUString(aStr, m_aStates.top().nCurrentEncoding));
+SAL_INFO(writerfilter, OSL_THIS_FUNC : collected ' aOUStr
');
if (m_aStates.top().nDestinationState == DESTINATION_COLORTABLE)
{
commit f8bda240a09b4ece1c3401874b3cc8f325dbcedb
Author: Miklos Vajna vmik...@suse.cz
Date: Sat Apr 21 11:25:18 2012 +0200
fdo#48023 fix RTF import of Russian characters without an encoding specified
lcl_GetDefaultTextEncodingForRTF() in editeng did the same.
diff --git a/sw/qa/extras/rtftok/data/fdo48023.rtf
b/sw/qa/extras/rtftok/data/fdo48023.rtf
new file mode 100644
index 000..6d6a0d9
--- /dev/null
+++ b/sw/qa/extras/rtftok/data/fdo48023.rtf
@@ -0,0 +1,8 @@
+{\rtf
+{\fonttbl
+{\f1 Arial;}
+}
+\pard
+\f1 Ïðîãðàììèñò
+\par
+}
diff --git a/sw/qa/extras/rtftok/rtftok.cxx b/sw/qa/extras/rtftok/rtftok.cxx
index fa1321f..6870f02 100644
--- a/sw/qa/extras/rtftok/rtftok.cxx
+++ b/sw/qa/extras/rtftok/rtftok.cxx
@@ -82,6 +82,7 @@ public:
void testFdo44176();
void testFdo39053();
void testFdo48356();
+void testFdo48023();
CPPUNIT_TEST_SUITE(RtfModelTest);
#if !defined(MACOSX) !defined(WNT)
@@ -106,6 +107,7 @@ public:
CPPUNIT_TEST(testFdo44176);
CPPUNIT_TEST(testFdo39053);
CPPUNIT_TEST(testFdo48356);
+CPPUNIT_TEST(testFdo48023);
#endif
CPPUNIT_TEST_SUITE_END();
@@ -574,6 +576,29 @@ void RtfModelTest::testFdo48356()
CPPUNIT_ASSERT_EQUAL(1, i);
}
+void RtfModelTest::testFdo48023()
+{
+lang::Locale aLocale;
+aLocale.Language = ru;
+AllSettings aSettings(Application::GetSettings());
+AllSettings aSavedSettings(aSettings);
+aSettings.SetLocale(aLocale);
+Application::SetSettings(aSettings);
+load(fdo48023.rtf);
+Application::SetSettings(aSavedSettings);
+
+uno::Referencetext::XTextDocument xTextDocument(mxComponent,
uno::UNO_QUERY);
+uno::Referencecontainer::XEnumerationAccess
xParaEnumAccess(xTextDocument-getText(), uno::UNO_QUERY);
+uno::Referencecontainer::XEnumeration xParaEnum =
xParaEnumAccess-createEnumeration();
+uno::Referencecontainer::XEnumerationAccess
xRangeEnumAccess(xParaEnum-nextElement(), uno::UNO_QUERY);
+uno::Referencecontainer::XEnumeration xRangeEnum =
xRangeEnumAccess-createEnumeration();
+uno::Referencetext::XTextRange xTextRange(xRangeEnum-nextElement(),
uno::UNO_QUERY);
+
+// Implicit encoding detection based on locale was missing
+OUString aExpected(ÐÑогÑаммиÑÑ, 22, RTL_TEXTENCODING_UTF8);
+CPPUNIT_ASSERT_EQUAL(aExpected, xTextRange-getString());
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(RtfModelTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 2527cef..2b30481 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -513,13 +513,26 @@ sal_uInt32 RTFDocumentImpl::getColorTable(sal_uInt32
nIndex)
return 0;
}
+rtl_TextEncoding lcl_getDefaultTextEncoding()
+{
+
+const OUString rLanguage =
Application::GetSettings().GetLocale().Language;
+
+if (rLanguage == ru || rLanguage == uk)
+return RTL_TEXTENCODING_MS_1251;
+if (rLanguage == tr)
+return RTL_TEXTENCODING_MS_1254;
+else
+return RTL_TEXTENCODING_MS_1252;
+}
+
rtl_TextEncoding RTFDocumentImpl::getEncoding(sal_uInt32 nFontIndex)
{
if (!m_pSuperstream)
{
if (nFontIndex m_aFontEncodings.size())
return m_aFontEncodings[nFontIndex];
-return 0;
+return lcl_getDefaultTextEncoding();
}
else
return m_pSuperstream-getEncoding(nFontIndex);
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: fpicker/source
fpicker/source/win32/filepicker/IVistaFilePickerInternalNotify.hxx |8
+++-
fpicker/source/win32/filepicker/vistatypes.h |8
+++-
2 files changed, 14 insertions(+), 2 deletions(-)
New commits:
commit ea822495b776a8b0b9d6b99299fdbc7bfc8db340
Author: Thomas Arnhold tho...@arnhold.org
Date: Sat Apr 21 13:26:30 2012 +0200
Partially revert: Replace css macro with namespace for nicer namespacing
To fix the build. I can't test it on win32, thought it would work...
diff --git a/fpicker/source/win32/filepicker/IVistaFilePickerInternalNotify.hxx
b/fpicker/source/win32/filepicker/IVistaFilePickerInternalNotify.hxx
index ca1b223..47909d7 100644
--- a/fpicker/source/win32/filepicker/IVistaFilePickerInternalNotify.hxx
+++ b/fpicker/source/win32/filepicker/IVistaFilePickerInternalNotify.hxx
@@ -45,7 +45,11 @@
// namespace
//-
-namespace css = ::com::sun::star;
+#ifdef css
+#error Clash on using CSS as namespace define.
+#else
+#define css ::com::sun::star
+#endif
namespace fpicker{
namespace win32{
@@ -69,6 +73,8 @@ class IVistaFilePickerInternalNotify
}}}
+#undef css
+
#endif // FPICKER_WIN32_VISTA_FILEPICKER_INTERNALNOTIFY_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/fpicker/source/win32/filepicker/vistatypes.h
b/fpicker/source/win32/filepicker/vistatypes.h
index e1b1fc5..08b4613 100644
--- a/fpicker/source/win32/filepicker/vistatypes.h
+++ b/fpicker/source/win32/filepicker/vistatypes.h
@@ -40,7 +40,11 @@
// namespace
//-
-namespace css = ::com::sun::star;
+#ifdef css
+#error Clash on using CSS as namespace define.
+#else
+#define css ::com::sun::star
+#endif
namespace fpicker{
namespace win32{
@@ -60,6 +64,8 @@ typedef ComPtr IFileDialogCustomize, IID_IFileDialogCustomize
} // namespace win32
} // namespace fpicker
+#undef css
+
#endif // FPICKER_WIN32_VISTA_TYPES_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: cui/source
cui/source/tabpages/paragrph.src |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 29042d096a2c5812ae179e1553367afd21b0f71e Author: Miklos Vajna vmik...@suse.cz Date: Sat Apr 21 14:26:49 2012 +0200 cui: fix position of ED_LINEDISTMETRIC I broke that when I added CB_CONTEXTUALSPACING diff --git a/cui/source/tabpages/paragrph.src b/cui/source/tabpages/paragrph.src index d6de18e..e064ac7 100644 --- a/cui/source/tabpages/paragrph.src +++ b/cui/source/tabpages/paragrph.src @@ -235,7 +235,7 @@ TabPage RID_SVXPAGE_STD_PARAGRAPH Disable = TRUE ; Border = TRUE ; Hide = TRUE ; -Pos = MAP_APPFONT ( 135 , 133 ) ; +Pos = MAP_APPFONT ( 135 , 147 ) ; Size = MAP_APPFONT ( 40 , 12 ) ; Group = TRUE ; Left = TRUE ; ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sw/qa writerfilter/source
sw/qa/extras/rtftok/data/fdo48876.rtf |5 +
sw/qa/extras/rtftok/rtftok.cxx | 17 +
writerfilter/source/rtftok/rtfdocumentimpl.cxx | 10 --
3 files changed, 30 insertions(+), 2 deletions(-)
New commits:
commit 99b875aee04a808fb28715fb0e143a2b00332832
Author: Miklos Vajna vmik...@suse.cz
Date: Sat Apr 21 12:53:22 2012 +0200
fdo#48876 fix RTF import of \sl without \slmult
diff --git a/sw/qa/extras/rtftok/data/fdo48876.rtf
b/sw/qa/extras/rtftok/data/fdo48876.rtf
new file mode 100644
index 000..49a6eb0
--- /dev/null
+++ b/sw/qa/extras/rtftok/data/fdo48876.rtf
@@ -0,0 +1,5 @@
+{\rtf
+\sl54
+C
+\par
+}
diff --git a/sw/qa/extras/rtftok/rtftok.cxx b/sw/qa/extras/rtftok/rtftok.cxx
index 6870f02..0bb45e4 100644
--- a/sw/qa/extras/rtftok/rtftok.cxx
+++ b/sw/qa/extras/rtftok/rtftok.cxx
@@ -29,6 +29,8 @@
#include com/sun/star/drawing/XDrawPageSupplier.hpp
#include com/sun/star/lang/XServiceInfo.hpp
#include com/sun/star/style/CaseMap.hpp
+#include com/sun/star/style/LineSpacing.hpp
+#include com/sun/star/style/LineSpacingMode.hpp
#include com/sun/star/style/XStyleFamiliesSupplier.hpp
#include com/sun/star/table/BorderLine2.hpp
#include com/sun/star/table/BorderLineStyle.hpp
@@ -83,6 +85,7 @@ public:
void testFdo39053();
void testFdo48356();
void testFdo48023();
+void testFdo48876();
CPPUNIT_TEST_SUITE(RtfModelTest);
#if !defined(MACOSX) !defined(WNT)
@@ -108,6 +111,7 @@ public:
CPPUNIT_TEST(testFdo39053);
CPPUNIT_TEST(testFdo48356);
CPPUNIT_TEST(testFdo48023);
+CPPUNIT_TEST(testFdo48876);
#endif
CPPUNIT_TEST_SUITE_END();
@@ -599,6 +603,19 @@ void RtfModelTest::testFdo48023()
CPPUNIT_ASSERT_EQUAL(aExpected, xTextRange-getString());
}
+void RtfModelTest::testFdo48876()
+{
+load(fdo48876.rtf);
+uno::Referencetext::XTextDocument xTextDocument(mxComponent,
uno::UNO_QUERY);
+uno::Referencecontainer::XEnumerationAccess
xParaEnumAccess(xTextDocument-getText(), uno::UNO_QUERY);
+uno::Referencecontainer::XEnumeration xParaEnum =
xParaEnumAccess-createEnumeration();
+CPPUNIT_ASSERT(xParaEnum-hasMoreElements());
+uno::Referencebeans::XPropertySet xPropertySet(xParaEnum-nextElement(),
uno::UNO_QUERY);
+style::LineSpacing aSpacing;
+xPropertySet-getPropertyValue(ParaLineSpacing) = aSpacing;
+CPPUNIT_ASSERT_EQUAL(style::LineSpacingMode::MINIMUM, aSpacing.Mode);
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(RtfModelTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index e50cc1f..750e473 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -2379,9 +2379,15 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword,
int nParam)
}
break;
case RTF_SL:
-if (nParam 0)
{
-// NS_sprm::LN_PDyaLine could be used, but that won't work
with slmult
+// This is similar to RTF_ABSH, negative value means 'exact',
positive means 'at least'.
+RTFValue::Pointer_t pValue(new
RTFValue(NS_ooxml::LN_Value_wordprocessingml_ST_LineSpacingRule_atLeast));
+if (nParam 0)
+{
+pValue.reset(new
RTFValue(NS_ooxml::LN_Value_wordprocessingml_ST_LineSpacingRule_exact));
+pIntValue.reset(new RTFValue(-nParam));
+}
+
m_aStates.top().aParagraphAttributes-push_back(make_pair(NS_ooxml::LN_CT_Spacing_lineRule,
pValue));
m_aStates.top().aParagraphAttributes-push_back(make_pair(NS_ooxml::LN_CT_Spacing_line,
pIntValue));
}
break;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sw/source
sw/source/filter/ww8/wrtww8.cxx | 46 +---
sw/source/filter/ww8/wrtww8.hxx |5 ++--
2 files changed, 23 insertions(+), 28 deletions(-)
New commits:
commit a3c7602ba3ed1ab57adab797a5820c8b0cb42abe
Author: Arnaud Versini arnaud.vers...@gmail.com
Date: Sat Apr 21 15:02:50 2012 +0200
Use boost::ptr_vector in WW8_WrPct instead of SV_DECL_PTRARR_DEL
diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 0dbf05c..f3ade78 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -228,10 +228,6 @@ public:
SV_IMPL_PTRARR( WW8_WrFkpPtrs, WW8_FkpPtr )
-typedef WW8_WrPc* WW8_WrPcPtr;
-SV_DECL_PTRARR_DEL( WW8_WrPcPtrs, WW8_WrPcPtr, 4 )
-SV_IMPL_PTRARR( WW8_WrPcPtrs, WW8_WrPcPtr )
-
static void WriteDop( WW8Export rWrt )
{
WW8Dop rDop = *rWrt.pDop;
@@ -1153,14 +1149,13 @@ WW8_FC WW8_WrFkp::GetEndFc() const
//--
WW8_WrPct::WW8_WrPct(WW8_FC nfcMin, bool bSaveUniCode)
-: pPcts(new WW8_WrPcPtrs), nOldFc(nfcMin), bIsUni(bSaveUniCode)
+: nOldFc(nfcMin), bIsUni(bSaveUniCode)
{
AppendPc( nOldFc, bIsUni );
}
WW8_WrPct::~WW8_WrPct()
{
-delete pPcts;
}
// Piece fuellen und neues Piece erzeugen
@@ -1169,10 +1164,10 @@ void WW8_WrPct::AppendPc(WW8_FC nStartFc, bool
bIsUnicode)
WW8_CP nStartCp = nStartFc - nOldFc;// Textbeginn abziehen
if ( !nStartCp )
{
-if ( 0 != pPcts-Count() )
+if ( !aPcts.empty() )
{
-OSL_ENSURE( 1 == pPcts-Count(), Leeres Piece !!);
-pPcts-DeleteAndDestroy( pPcts-Count() - 1 , 1);
+OSL_ENSURE( 1 == aPcts.size(), Leeres Piece !!);
+aPcts.pop_back( );
}
}
@@ -1188,11 +1183,11 @@ void WW8_WrPct::AppendPc(WW8_FC nStartFc, bool
bIsUnicode)
nStartFc |= 0x4000; // Vorletztes Bit setzen fuer !Unicode
}
-if( pPcts-Count() )
-nStartCp += pPcts-GetObject( pPcts-Count()- 1 )-GetStartCp();
+if( !aPcts.empty() )
+nStartCp += aPcts.back().GetStartCp();
-WW8_WrPcPtr pPc = new WW8_WrPc( nStartFc, nStartCp );
-pPcts-Insert( pPc, pPcts-Count() );
+WW8_WrPc* pPc = new WW8_WrPc( nStartFc, nStartCp );
+aPcts.push_back( pPc );
bIsUni = bIsUnicode;
}
@@ -1202,31 +1197,30 @@ void WW8_WrPct::WritePc( WW8Export rWrt )
{
sal_uLong nPctStart;
sal_uLong nOldPos, nEndPos;
-sal_uInt16 i;
+boost::ptr_vectorWW8_WrPc::iterator aIter;
nPctStart = rWrt.pTableStrm-Tell();// Beginn
Piece-Table
*rWrt.pTableStrm ( char )0x02; // Statusbyte PCT
nOldPos = nPctStart + 1;// Position merken
SwWW8Writer::WriteLong( *rWrt.pTableStrm, 0 ); // Laenge folgt
-for( i = 0; i pPcts-Count(); ++i ) // Bereiche
+
+for( aIter = aPcts.begin(); aIter != aPcts.end(); ++aIter ) // Bereiche
SwWW8Writer::WriteLong( *rWrt.pTableStrm,
-pPcts-GetObject( i )-GetStartCp() );
+aIter-GetStartCp() );
// die letzte Pos noch errechnen
sal_uLong nStartCp = rWrt.pFib-fcMac - nOldFc;
if( bIsUni )
nStartCp = 1; // Bei Unicode Anzahl der Zeichen / 2
-nStartCp += pPcts-GetObject( i-1 )-GetStartCp();
+nStartCp += aPcts.back().GetStartCp();
SwWW8Writer::WriteLong( *rWrt.pTableStrm, nStartCp );
// Pieceverweise
-for ( i = 0; i pPcts-Count(); ++i )
+for ( aIter = aPcts.begin(); aIter != aPcts.end(); ++aIter )
{
-WW8_WrPcPtr pPc = pPcts-GetObject( i );
-
-SwWW8Writer::WriteShort( *rWrt.pTableStrm, pPc-GetStatus());
-SwWW8Writer::WriteLong( *rWrt.pTableStrm, pPc-GetStartFc());
+SwWW8Writer::WriteShort( *rWrt.pTableStrm, aIter-GetStatus());
+SwWW8Writer::WriteLong( *rWrt.pTableStrm, aIter-GetStartFc());
SwWW8Writer::WriteShort( *rWrt.pTableStrm, 0); // PRM=0
}
@@ -1243,19 +1237,19 @@ void WW8_WrPct::WritePc( WW8Export rWrt )
void WW8_WrPct::SetParaBreak()
{
-OSL_ENSURE( pPcts-Count(),SetParaBreak : aPcts.Count = 0 );
-pPcts-GetObject( pPcts-Count() - 1)-SetStatus();
+OSL_ENSURE( !aPcts.empty(),SetParaBreak : aPcts.empty() );
+aPcts.back().SetStatus();
}
WW8_CP WW8_WrPct::Fc2Cp( sal_uLong nFc ) const
{
OSL_ENSURE( nFc = (sal_uLong)nOldFc, FilePos liegt vorm letzten Piece );
-OSL_ENSURE( pPcts-Count(), Fc2Cp noch kein Piece vorhanden );
+OSL_ENSURE( ! aPcts.empty(), Fc2Cp noch kein Piece vorhanden );
nFc -= nOldFc;
if( bIsUni )
nFc /= 2;
-return nFc + pPcts-GetObject( pPcts-Count() - 1 )-GetStartCp();
+return nFc + aPcts.back().GetStartCp();
}
//--
diff --git a/sw/source/filter/ww8/wrtww8.hxx
[Libreoffice-commits] .: 2 commits - sw/source
sw/source/filter/ww8/ww8par.hxx |4 -
sw/source/filter/ww8/ww8par3.cxx | 112 +--
2 files changed, 52 insertions(+), 64 deletions(-)
New commits:
commit 2457f8f5b88028d0248943e2f80fce55913312f1
Author: Caolán McNamara caol...@redhat.com
Date: Sat Apr 21 14:54:15 2012 +0100
clarify DelNumRule comment
diff --git a/sw/source/filter/ww8/ww8par3.cxx b/sw/source/filter/ww8/ww8par3.cxx
index f909f77..357119b 100644
--- a/sw/source/filter/ww8/ww8par3.cxx
+++ b/sw/source/filter/ww8/ww8par3.cxx
@@ -1411,9 +1411,8 @@ WW8ListManager::WW8ListManager(SvStream rSt_,
SwWW8ImplReader rReader_)
WW8ListManager::~WW8ListManager()
{
/*
-named lists remain in doc!!!
-unnamed lists are deleted when unused
-pLFOInfos are in any case destructed
+ named lists remain in document
+ unused automatic lists are removed from document (DelNumRule)
*/
for(std::vectorWW8LSTInfo *::iterator aIter = maLSTInfos.begin();
aIter != maLSTInfos.end(); ++aIter)
@@ -1426,18 +1425,18 @@ WW8ListManager::~WW8ListManager()
delete *aIter;
}
boost::ptr_vectorWW8LFOInfo ::reverse_iterator aIter;
-for (aIter = pLFOInfos.rbegin() ;
-aIter pLFOInfos.rend();
-++aIter )
+for (aIter = pLFOInfos.rbegin() ;
+aIter pLFOInfos.rend();
+++aIter )
+{
+if (aIter-bOverride
+ aIter-pNumRule
+ !aIter-bUsedInDoc
+ aIter-pNumRule-IsAutoRule())
{
-if (aIter-bOverride
- aIter-pNumRule
- !aIter-bUsedInDoc
- aIter-pNumRule-IsAutoRule())
-{
-rDoc.DelNumRule( aIter-pNumRule-GetName() );
-}
+rDoc.DelNumRule( aIter-pNumRule-GetName() );
}
+}
}
bool IsEqualFormatting(const SwNumRule rOne, const SwNumRule rTwo)
commit 1f98094fc61f39f349c7d6cd3f59a8c9cd0626fc
Author: Arnaud Versini arnaud.vers...@gmail.com
Date: Sat Apr 7 19:46:32 2012 +0200
Use boost::ptr_vector in WW8ListManager instead of SV_DECL_PTRARR_DEL
diff --git a/sw/source/filter/ww8/ww8par.hxx b/sw/source/filter/ww8/ww8par.hxx
index de9219d..e2cc680 100644
--- a/sw/source/filter/ww8/ww8par.hxx
+++ b/sw/source/filter/ww8/ww8par.hxx
@@ -142,8 +142,6 @@ namespace com{namespace sun {namespace star{
//-
struct WW8LFOInfo;
-typedef WW8LFOInfo* WW8LFOInfo_Ptr;
-SV_DECL_PTRARR_DEL(WW8LFOInfos,WW8LFOInfo_Ptr,16)
class WW8Reader : public StgReader
{
@@ -177,7 +175,7 @@ private:
const WW8FibrFib;
SvStreamrSt;
std::vectorWW8LSTInfo* maLSTInfos;
-WW8LFOInfos* pLFOInfos;// D. aus PLF LFO, sortiert genau wie im WW8 Stream
+boost::ptr_vectorWW8LFOInfo pLFOInfos;// D. aus PLF LFO, sortiert genau
wie im WW8 Stream
sal_uInt16 nUniqueList; // current number for creating unique list
names
sal_uInt8* GrpprlHasSprm(sal_uInt16 nId, sal_uInt8 rSprms, sal_uInt8
nLen);
WW8LSTInfo* GetLSTByListId(sal_uInt32 nIdLst ) const;
diff --git a/sw/source/filter/ww8/ww8par3.cxx b/sw/source/filter/ww8/ww8par3.cxx
index 4a39b5d..f909f77 100644
--- a/sw/source/filter/ww8/ww8par3.cxx
+++ b/sw/source/filter/ww8/ww8par3.cxx
@@ -457,7 +457,6 @@ WW8LFOInfo::WW8LFOInfo(const WW8LFO rLFO)
{
}
-SV_IMPL_PTRARR( WW8LFOInfos, WW8LFOInfo_Ptr );
// Hilfs-Methoden
@@ -1052,7 +1051,7 @@ SwNumRule* WW8ListManager::CreateNextRule(bool bSimple)
//
WW8ListManager::WW8ListManager(SvStream rSt_, SwWW8ImplReader rReader_)
: maSprmParser(rReader_.GetFib().GetFIBVersion()), rReader(rReader_),
-rDoc(rReader.GetDoc()), rFib(rReader.GetFib()), rSt(rSt_), pLFOInfos(0),
+rDoc(rReader.GetDoc()), rFib(rReader.GetFib()), rSt(rSt_),
nUniqueList(1)
{
// LST und LFO gibts erst ab WW8
@@ -1062,7 +1061,6 @@ WW8ListManager::WW8ListManager(SvStream rSt_,
SwWW8ImplReader rReader_)
|| ( rFib.lcbPlfLfo 2) ) return; // offensichtlich keine Listen
da
// Arrays anlegen
-pLFOInfos = new WW8LFOInfos;
bool bLVLOk = true;
nLastLFOPosition = USHRT_MAX;
@@ -1243,7 +1241,7 @@ WW8ListManager::WW8ListManager(SvStream rSt_,
SwWW8ImplReader rReader_)
for (int i = 0; i nMaxSize; ++i)
pLFOInfo-maParaSprms[i] = pParentListInfo-maParaSprms[i];
}
-pLFOInfos-Insert(pLFOInfo, pLFOInfos-Count());
+pLFOInfos.push_back(pLFOInfo);
bOk = true;
}
@@ -1252,23 +1250,21 @@ WW8ListManager::WW8ListManager(SvStream rSt_,
SwWW8ImplReader rReader_)
//
// 2.2 fuer alle LFO die zugehoerigen LFOLVL einlesen
//
-sal_uInt16 nLFOInfos = pLFOInfos ? pLFOInfos-Count() : 0;
-for (sal_uInt16 nLfo = 0; nLfo nLFOInfos; ++nLfo)
+size_t nLFOInfos = pLFOInfos.size();
+for (size_t nLfo = 0; nLfo nLFOInfos; ++nLfo)
[Libreoffice-commits] .: 2 commits - writerfilter/source
writerfilter/source/filter/RtfFilter.cxx |4 ++-
writerfilter/source/rtftok/rtfcontrolwords.cxx | 18
writerfilter/source/rtftok/rtfcontrolwords.hxx |4 +++
writerfilter/source/rtftok/rtftokenizer.cxx| 28 -
writerfilter/source/rtftok/rtftokenizer.hxx|2 +
5 files changed, 41 insertions(+), 15 deletions(-)
New commits:
commit 22eb78b6eee38e11aec32909b6983becb309ce13
Author: Miklos Vajna vmik...@suse.cz
Date: Sat Apr 21 18:58:31 2012 +0200
fdo#44736 speed up RTF import a bit by sorting keywords
If we sort the keywords once in the constructor, then we can do binary
search when looking up RTF keywords, and that speeds up the import by
about 20% using the first testcase from the bug.
diff --git a/writerfilter/source/rtftok/rtfcontrolwords.cxx
b/writerfilter/source/rtftok/rtfcontrolwords.cxx
index cce0c2e..11c4d3d 100644
--- a/writerfilter/source/rtftok/rtfcontrolwords.cxx
+++ b/writerfilter/source/rtftok/rtfcontrolwords.cxx
@@ -27,6 +27,7 @@
#include rtfcontrolwords.hxx
#include sal/macros.h
+#include string.h
namespace writerfilter {
namespace rtftok {
@@ -1856,6 +1857,23 @@ RTFSymbol aRTFControlWords[] = {
};
int nRTFControlWords = SAL_N_ELEMENTS(aRTFControlWords);
+bool RTFSymbol::operator(const RTFSymbol rOther) const
+{
+return strcmp(sKeyword, rOther.sKeyword) 0;
+}
+
+RTFSymbol::RTFSymbol(const char* pKeyword)
+: sKeyword(pKeyword)
+{
+}
+
+RTFSymbol::RTFSymbol(const char *pKeyword, int pControlType, RTFKeyword pIndex)
+: sKeyword(pKeyword),
+nControlType(pControlType),
+nIndex(pIndex)
+{
+}
+
} // namespace rtftok
} // namespace writerfilter
diff --git a/writerfilter/source/rtftok/rtfcontrolwords.hxx
b/writerfilter/source/rtftok/rtfcontrolwords.hxx
index 5afb8c6..477ddb5 100644
--- a/writerfilter/source/rtftok/rtfcontrolwords.hxx
+++ b/writerfilter/source/rtftok/rtfcontrolwords.hxx
@@ -1866,6 +1866,10 @@ struct RTFSymbol
const char *sKeyword;
int nControlType;
RTFKeyword nIndex;
+
+bool operator(const RTFSymbol rOther) const;
+RTFSymbol(const char* pKeyword);
+RTFSymbol(const char *pKeyword, int pControlType, RTFKeyword pIndex);
};
extern RTFSymbol aRTFControlWords[];
diff --git a/writerfilter/source/rtftok/rtftokenizer.cxx
b/writerfilter/source/rtftok/rtftokenizer.cxx
index f247317..b40a912 100644
--- a/writerfilter/source/rtftok/rtftokenizer.cxx
+++ b/writerfilter/source/rtftok/rtftokenizer.cxx
@@ -45,8 +45,10 @@ namespace rtftok {
RTFTokenizer::RTFTokenizer(RTFDocumentImpl rImport, SvStream* pInStream,
uno::Referencetask::XStatusIndicator const xStatusIndicator)
: m_rImport(rImport),
m_pInStream(pInStream),
-m_xStatusIndicator(xStatusIndicator)
+m_xStatusIndicator(xStatusIndicator),
+m_aRTFControlWords(std::vectorRTFSymbol(aRTFControlWords,
aRTFControlWords + nRTFControlWords))
{
+std::sort(m_aRTFControlWords.begin(), m_aRTFControlWords.end());
}
RTFTokenizer::~RTFTokenizer()
@@ -266,13 +268,10 @@ int RTFTokenizer::dispatchKeyword(OString rKeyword, bool
bParam, int nParam)
return 0;
/*SAL_INFO(writefilter, OSL_THIS_FUNC : keyword '\\
rKeyword.getStr()
' with param? (bParam ? 1 : 0) param val: '
(bParam ? nParam : 0) ');*/
-int i, ret;
-for (i = 0; i nRTFControlWords; i++)
-{
-if (!strcmp(rKeyword.getStr(), aRTFControlWords[i].sKeyword))
-break;
-}
-if (i == nRTFControlWords)
+RTFSymbol aSymbol(rKeyword.getStr());
+std::vectorRTFSymbol::iterator low =
std::lower_bound(m_aRTFControlWords.begin(), m_aRTFControlWords.end(), aSymbol);
+int i = low - m_aRTFControlWords.begin();
+if (low == m_aRTFControlWords.end() || aSymbol *low)
{
SAL_INFO(writerfilter, OSL_THIS_FUNC : unknown keyword '\\
rKeyword.getStr() ');
RTFSkipDestination aSkip(m_rImport);
@@ -280,35 +279,36 @@ int RTFTokenizer::dispatchKeyword(OString rKeyword, bool
bParam, int nParam)
return 0;
}
-switch (aRTFControlWords[i].nControlType)
+int ret;
+switch (m_aRTFControlWords[i].nControlType)
{
case CONTROL_FLAG:
// flags ignore any parameter by definition
-ret = m_rImport.dispatchFlag(aRTFControlWords[i].nIndex);
+ret = m_rImport.dispatchFlag(m_aRTFControlWords[i].nIndex);
if (ret)
return ret;
break;
case CONTROL_DESTINATION:
// same for destinations
-ret = m_rImport.dispatchDestination(aRTFControlWords[i].nIndex);
+ret = m_rImport.dispatchDestination(m_aRTFControlWords[i].nIndex);
if (ret)
return ret;
break;
case CONTROL_SYMBOL:
// and symbols
-ret = m_rImport.dispatchSymbol(aRTFControlWords[i].nIndex);
+ret = m_rImport.dispatchSymbol(m_aRTFControlWords[i].nIndex);
[Libreoffice-commits] .: writerfilter/source
writerfilter/source/rtftok/rtfcontrolwords.cxx | 12
writerfilter/source/rtftok/rtfcontrolwords.hxx |2 --
writerfilter/source/rtftok/rtftokenizer.cxx|3 ++-
3 files changed, 2 insertions(+), 15 deletions(-)
New commits:
commit 9fda7a919f31a192b9bd2938139b6566b7fc2935
Author: Miklos Vajna vmik...@suse.cz
Date: Sat Apr 21 20:00:08 2012 +0200
rtftok: try to make tinderboxes happy
diff --git a/writerfilter/source/rtftok/rtfcontrolwords.cxx
b/writerfilter/source/rtftok/rtfcontrolwords.cxx
index 11c4d3d..516a9b8 100644
--- a/writerfilter/source/rtftok/rtfcontrolwords.cxx
+++ b/writerfilter/source/rtftok/rtfcontrolwords.cxx
@@ -1862,18 +1862,6 @@ bool RTFSymbol::operator(const RTFSymbol rOther) const
return strcmp(sKeyword, rOther.sKeyword) 0;
}
-RTFSymbol::RTFSymbol(const char* pKeyword)
-: sKeyword(pKeyword)
-{
-}
-
-RTFSymbol::RTFSymbol(const char *pKeyword, int pControlType, RTFKeyword pIndex)
-: sKeyword(pKeyword),
-nControlType(pControlType),
-nIndex(pIndex)
-{
-}
-
} // namespace rtftok
} // namespace writerfilter
diff --git a/writerfilter/source/rtftok/rtfcontrolwords.hxx
b/writerfilter/source/rtftok/rtfcontrolwords.hxx
index 477ddb5..1088982 100644
--- a/writerfilter/source/rtftok/rtfcontrolwords.hxx
+++ b/writerfilter/source/rtftok/rtfcontrolwords.hxx
@@ -1868,8 +1868,6 @@ struct RTFSymbol
RTFKeyword nIndex;
bool operator(const RTFSymbol rOther) const;
-RTFSymbol(const char* pKeyword);
-RTFSymbol(const char *pKeyword, int pControlType, RTFKeyword pIndex);
};
extern RTFSymbol aRTFControlWords[];
diff --git a/writerfilter/source/rtftok/rtftokenizer.cxx
b/writerfilter/source/rtftok/rtftokenizer.cxx
index b40a912..709bb30 100644
--- a/writerfilter/source/rtftok/rtftokenizer.cxx
+++ b/writerfilter/source/rtftok/rtftokenizer.cxx
@@ -268,7 +268,8 @@ int RTFTokenizer::dispatchKeyword(OString rKeyword, bool
bParam, int nParam)
return 0;
/*SAL_INFO(writefilter, OSL_THIS_FUNC : keyword '\\
rKeyword.getStr()
' with param? (bParam ? 1 : 0) param val: '
(bParam ? nParam : 0) ');*/
-RTFSymbol aSymbol(rKeyword.getStr());
+RTFSymbol aSymbol;
+aSymbol.sKeyword = rKeyword.getStr();
std::vectorRTFSymbol::iterator low =
std::lower_bound(m_aRTFControlWords.begin(), m_aRTFControlWords.end(), aSymbol);
int i = low - m_aRTFControlWords.begin();
if (low == m_aRTFControlWords.end() || aSymbol *low)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - linguistic/source sc/inc sc/source unusedcode.easy
linguistic/source/lngprophelp.cxx |1 +
sc/inc/cell.hxx |1 -
sc/source/core/data/cell.cxx |5 -
unusedcode.easy |1 -
4 files changed, 1 insertion(+), 7 deletions(-)
New commits:
commit d2bfa5cfdaaa68a3e2bd751cc45955e4ea41f36b
Author: Szabolcs Dezsi dezsisz...@hotmail.com
Date: Sat Apr 21 15:28:50 2012 +0200
Resolves: fdo#3: Changing spelling preferences requires application
restart
diff --git a/linguistic/source/lngprophelp.cxx
b/linguistic/source/lngprophelp.cxx
index b93971f..82a7c4d 100644
--- a/linguistic/source/lngprophelp.cxx
+++ b/linguistic/source/lngprophelp.cxx
@@ -522,6 +522,7 @@ void PropertyHelper_Spell::SetTmpPropVals( const
PropertyValues rPropVals )
nResMaxNumberOfSuggestions = GetDefaultNumberOfSuggestions();
bResIsSpellWithDigits = bIsSpellWithDigits;
bResIsSpellCapitalization = bIsSpellCapitalization;
+bResIsSpellUpperCase= bIsSpellUpperCase;
sal_Int32 nLen = rPropVals.getLength();
if (nLen)
commit dd2230c90ff41b667bf0d750801eb0d2ab3b0317
Author: Ferran Vidal vidalmargi...@hotmail.com
Date: Sat Apr 21 18:08:11 2012 +0200
Remove unused code from Spreadsheet application code
diff --git a/sc/inc/cell.hxx b/sc/inc/cell.hxx
index 08fbdfa..b4549d1 100644
--- a/sc/inc/cell.hxx
+++ b/sc/inc/cell.hxx
@@ -207,7 +207,6 @@ public:
DECL_FIXEDMEMPOOL_NEWDEL( ScStringCell )
#endif
-ScStringCell();
explicitScStringCell(const rtl::OUString rString);
#if OSL_DEBUG_LEVEL 0
diff --git a/sc/source/core/data/cell.cxx b/sc/source/core/data/cell.cxx
index 9ccadde..a4e5361 100644
--- a/sc/source/core/data/cell.cxx
+++ b/sc/source/core/data/cell.cxx
@@ -657,11 +657,6 @@ ScValueCell::~ScValueCell()
//
-ScStringCell::ScStringCell() :
-ScBaseCell( CELLTYPE_STRING )
-{
-}
-
ScStringCell::ScStringCell( const rtl::OUString rString ) :
ScBaseCell( CELLTYPE_STRING ),
maString( rString.intern() )
diff --git a/unusedcode.easy b/unusedcode.easy
index 89aa3c8..b62d53a 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -86,7 +86,6 @@ ScRTFColTwips_SAR::_ForEach(unsigned short, unsigned short,
unsigned char (*)(un
ScRangeData::ReplaceRangeNamesInUse(std::__debug::mapunsigned short, unsigned
short, std::lessunsigned short, std::allocatorstd::pairunsigned short
const, unsigned short const)
ScRangeData::ScRangeData(unsigned short)
ScSimpleRangeList::Range::contains(ScSimpleRangeList::Range const) const
-ScStringCell::ScStringCell()
ScTable::ReplaceRangeNamesInUse(short, int, short, int,
std::__debug::mapunsigned short, unsigned short, std::lessunsigned short,
std::allocatorstd::pairunsigned short const, unsigned short const)
ScTypedStrData::GetValue() const
ScValidationEntries_Impl::Insert(ScValidationData* const, unsigned short)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sdext/source
sdext/source/pdfimport/tree/pdfiprocessor.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bcb4defef7c9147a94ef19a51a18715449d3572d Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com Date: Sat Apr 21 10:06:19 2012 +0700 Fix fdo#45848 regression from 5dd4f9ecb2f50cf76b44472e4438297b6c65184c The change: -if(m_GlyphsList.size()1) +if(!m_GlyphsList.empty()) is incorrect, so change it back. diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.cxx b/sdext/source/pdfimport/tree/pdfiprocessor.cxx index d0ec397..12d2ab4 100644 --- a/sdext/source/pdfimport/tree/pdfiprocessor.cxx +++ b/sdext/source/pdfimport/tree/pdfiprocessor.cxx @@ -399,7 +399,7 @@ void PDFIProcessor::processGlyphLine() } -if(!m_GlyphsList.empty()) +if(m_GlyphsList.size()1) processGlyph( 0, m_GlyphsList[m_GlyphsList.size()-1], pPara, ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sdext/source
sdext/source/pdfimport/tree/pdfiprocessor.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fc0c85e8628bf90afd4a47c20b3d1bc2a9c01b36 Author: Korrawit Pruegsanusak detective.conan.1...@gmail.com Date: Sat Apr 21 10:06:19 2012 +0700 Fix fdo#45848 regression from 5dd4f9ecb2f50cf76b44472e4438297b6c65184c The change: -if(m_GlyphsList.size()1) +if(!m_GlyphsList.empty()) is incorrect, so change it back. (cherry picked from commit bcb4defef7c9147a94ef19a51a18715449d3572d) Signed-off-by: Caolán McNamara caol...@redhat.com diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.cxx b/sdext/source/pdfimport/tree/pdfiprocessor.cxx index 6d0e34e..a800643 100644 --- a/sdext/source/pdfimport/tree/pdfiprocessor.cxx +++ b/sdext/source/pdfimport/tree/pdfiprocessor.cxx @@ -399,7 +399,7 @@ void PDFIProcessor::processGlyphLine() } -if(!m_GlyphsList.empty()) +if(m_GlyphsList.size()1) processGlyph( 0, m_GlyphsList[m_GlyphsList.size()-1], pPara, ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - cui/source
cui/source/customize/macropg.cxx |1 -
cui/source/inc/iconcdlg.hxx |1 -
cui/source/options/cuisrchdlg.cxx |2 --
cui/source/options/fontsubs.cxx |4
cui/source/options/optdict.cxx|1 -
cui/source/options/optfltr.cxx|3 ---
cui/source/options/optgdlg.cxx|8
cui/source/options/optgdlg.hxx|1 -
cui/source/options/optinet2.hxx | 13 -
cui/source/options/optlingu.cxx |7 ---
cui/source/options/optmemory.cxx |2 --
cui/source/options/optmemory.hxx |1 -
cui/source/options/optpath.cxx|1 -
cui/source/tabpages/border.cxx|2 --
cui/source/tabpages/macroass.cxx |3 ---
cui/source/tabpages/numpages.cxx |1 -
cui/source/tabpages/transfrm.cxx |3 ---
17 files changed, 54 deletions(-)
New commits:
commit 2496eb6fd40ed6d91bdbc4a85e5b30b1afc707d1
Author: Takeshi Abe t...@fixedpoint.jp
Date: Sun Apr 22 05:08:10 2012 +0900
removed unused static data
diff --git a/cui/source/options/optdict.cxx b/cui/source/options/optdict.cxx
index 30f74ec..f850929 100644
--- a/cui/source/options/optdict.cxx
+++ b/cui/source/options/optdict.cxx
@@ -55,7 +55,6 @@ using namespace ::com::sun::star::linguistic2;
// static
-static const sal_uInt16 nNameLen= 8;
static const short NOACTDICT = -1;
static long nStaticTabs[]=
diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index ea17472..418455e 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cxx
@@ -1228,10 +1228,6 @@ static const OUString
sInstalledLocalesPath(RTL_CONSTASCII_USTRINGPARAM(org.ope
static OUString
sUserLocalePath(RTL_CONSTASCII_USTRINGPARAM(org.openoffice.Office.Linguistic/General));
//static const OUString
sUserLocalePath(RTL_CONSTASCII_USTRINGPARAM(org.openoffice.Office/Linguistic));
static const OUString sUserLocaleKey(RTL_CONSTASCII_USTRINGPARAM(UILocale));
-static const OUString
sSystemLocalePath(RTL_CONSTASCII_USTRINGPARAM(org.openoffice.System/L10N));
-static const OUString
sSystemLocaleKey(RTL_CONSTASCII_USTRINGPARAM(UILocale));
-static const OUString
sOfficeLocalePath(RTL_CONSTASCII_USTRINGPARAM(org.openoffice.Office/L10N));
-static const OUString
sOfficeLocaleKey(RTL_CONSTASCII_USTRINGPARAM(ooLocale));
static Sequence OUString seqInstalledLanguages;
OfaLanguagesTabPage::OfaLanguagesTabPage( Window* pParent, const SfxItemSet
rSet ) :
diff --git a/cui/source/options/optlingu.cxx b/cui/source/options/optlingu.cxx
index e433c44..198eff8 100644
--- a/cui/source/options/optlingu.cxx
+++ b/cui/source/options/optlingu.cxx
@@ -167,8 +167,6 @@ static void lcl_OpenURL( ::rtl::OUString sURL )
}
}
-static const sal_uInt16 nNameLen = 8;
-
static sal_uInt16 pRanges[] =
{
SID_ATTR_SPELL,
diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx
index 0b4dfa1..a4d3837 100644
--- a/cui/source/tabpages/numpages.cxx
+++ b/cui/source/tabpages/numpages.cxx
@@ -104,7 +104,6 @@
SV_IMPL_PTRARR(SvxNumSettingsArr_Impl,SvxNumSettings_ImplPtr);
static sal_Bool bLastRelative = sal_False;
static const sal_Char cNumberingType[] = NumberingType;
-static const sal_Char cValue[] = Value;
static const sal_Char cParentNumbering[] = ParentNumbering;
static const sal_Char cPrefix[] = Prefix;
static const sal_Char cSuffix[] = Suffix;
commit 2ce52cbb18e8083dc14c6701a2dab8ca32b81967
Author: Takeshi Abe t...@fixedpoint.jp
Date: Sun Apr 22 05:07:37 2012 +0900
removed unused defines
diff --git a/cui/source/customize/macropg.cxx b/cui/source/customize/macropg.cxx
index 94719ff..6e5a4ff 100644
--- a/cui/source/customize/macropg.cxx
+++ b/cui/source/customize/macropg.cxx
@@ -104,7 +104,6 @@ static long nTabs[] =
#defineITMEID_ASSMACRO2
-#define LB_EVENTS_ITEMPOS1
#define LB_MACROS_ITEMPOS2
diff --git a/cui/source/inc/iconcdlg.hxx b/cui/source/inc/iconcdlg.hxx
index 41bdf61..ed7079d 100644
--- a/cui/source/inc/iconcdlg.hxx
+++ b/cui/source/inc/iconcdlg.hxx
@@ -40,7 +40,6 @@
#include vector
#define CTRLS_OFFSET3
-#define BUTTON_DISTANCE 8
#define RET_USER100
#define RET_USER_CANCEL 101
diff --git a/cui/source/options/cuisrchdlg.cxx
b/cui/source/options/cuisrchdlg.cxx
index 7422230..aba0b5b 100644
--- a/cui/source/options/cuisrchdlg.cxx
+++ b/cui/source/options/cuisrchdlg.cxx
@@ -47,8 +47,6 @@
#include cuires.hrc
-#define ITEMID_SETITEM 0
-
#include svl/srchitem.hxx
#include svx/pageitem.hxx
#include dialmgr.hxx
diff --git a/cui/source/options/fontsubs.cxx b/cui/source/options/fontsubs.cxx
index 0646287..d59c5ee 100644
--- a/cui/source/options/fontsubs.cxx
+++ b/cui/source/options/fontsubs.cxx
@@ -46,10 +46,6 @@
/* */
/*/
-#define CBCOL_FIRST 0
-#define
[Libreoffice-commits] .: 2 commits - crashrep/source
crashrep/source/unx/main.cxx | 33 ++---
1 file changed, 10 insertions(+), 23 deletions(-)
New commits:
commit 461b786be77a2116673915d56e1bf875cac792b5
Author: Caolán McNamara caol...@redhat.com
Date: Sat Apr 21 21:42:18 2012 +0100
make comment reflect reality
diff --git a/crashrep/source/unx/main.cxx b/crashrep/source/unx/main.cxx
index d4c17bd..493c21f 100644
--- a/crashrep/source/unx/main.cxx
+++ b/crashrep/source/unx/main.cxx
@@ -1032,38 +1032,17 @@ static bool setup_version()
return 0 != g_strReportServer.length();
}
-#if 0
-// Use gconftool-2 to determine if gnome accessiblity is enabled
-// unused
-static bool get_accessibility_state()
-{
-bool bAccessible = false;
-FILE *fin = popen( gconftool-2 -g
/desktop/gnome/interface/accessibility, r);
-
-if ( fin )
-{
-char buffer[sizeof(true)];
-
-bAccessible = fgets( buffer, sizeof(buffer), fin ) 0 == strcmp(
buffer, true );
-
-pclose( fin );
-}
-
-return bAccessible;
-}
-#endif
-
int main( int argc, char** argv )
{
FILE *fin = freopen( /dev/null, w, stderr );
-if (!fin)
+if (!fin)
{
return -1;
}
setup_program_dir( argv[0] );
-// Don't start if accessiblity is enabled or report server is not given
+// Don't start if report server is not given
if ( setup_version() )
{
commit ad4f72560627a2d75c71a34f2a37ab1f5a2bf05d
Author: David Ostrovsky david.ostrov...@gmx.de
Date: Sat Apr 21 14:27:43 2012 +0200
WaE: crashrep warnings fixed
diff --git a/crashrep/source/unx/main.cxx b/crashrep/source/unx/main.cxx
index f9a6320..d4c17bd 100644
--- a/crashrep/source/unx/main.cxx
+++ b/crashrep/source/unx/main.cxx
@@ -592,7 +592,11 @@ static void setup_program_dir( const char* progname )
g_strProgramDir = aDir.substr( 0, pos + 1 );
aDir.erase( pos );
-chdir( aDir.c_str() );
+int ret = chdir( aDir.c_str() );
+if (!ret)
+{
+return;
+}
}
}
@@ -1051,7 +1055,11 @@ static bool get_accessibility_state()
int main( int argc, char** argv )
{
-freopen( /dev/null, w, stderr );
+FILE *fin = freopen( /dev/null, w, stderr );
+if (!fin)
+{
+return -1;
+}
setup_program_dir( argv[0] );
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - extensions/source
extensions/source/nsplugin/source/npshell.cxx | 10 --
extensions/source/scanner/sane.cxx| 26 +-
2 files changed, 29 insertions(+), 7 deletions(-)
New commits:
commit e37ae322b07a02714b22cb663e1d7ab4f2072730
Author: Caolán McNamara caol...@redhat.com
Date: Sat Apr 21 22:24:03 2012 +0100
fill in some sane defaults on read/write failure
diff --git a/extensions/source/nsplugin/source/npshell.cxx
b/extensions/source/nsplugin/source/npshell.cxx
index f6b4ea4..33c282f 100644
--- a/extensions/source/nsplugin/source/npshell.cxx
+++ b/extensions/source/nsplugin/source/npshell.cxx
@@ -761,7 +761,7 @@ NPP_StreamAsFile(NPP instance, NPStream *stream, const
char* fname)
return;
}
char buffer[NPP_BUFFER_SIZE] = {0};
-int ret;
+ssize_t ret;
while(0 = (ret = read(fdSrc, buffer, NPP_BUFFER_SIZE)))
{
if (0 == ret)
@@ -773,8 +773,10 @@ NPP_StreamAsFile(NPP instance, NPStream *stream, const
char* fname)
break;
}
ssize_t written_bytes = write(fdDst, buffer, ret);
-if (written_bytes == -1)
+if (written_bytes != ret)
{
+debug_fprintf(NSP_LOG_APPEND, NPP_StreamAsFile:short write to
%s. error: %s \n,
+localPathNew, strerror(errno));
return;
}
}
diff --git a/extensions/source/scanner/sane.cxx
b/extensions/source/scanner/sane.cxx
index ca2cec1..b89f9bd 100644
--- a/extensions/source/scanner/sane.cxx
+++ b/extensions/source/scanner/sane.cxx
@@ -526,21 +526,20 @@ static inline sal_uInt8 _ReadValue( FILE* fp, int depth )
// as we do
size_t items_read = fread( nWord, 1, 2, fp );
-// fread() does not distinguish between end-of-file and error, and
callers
-// must use feof(3) and ferror(3) to determine which occurred.
-if (items_read == 0)
+if (items_read != 2)
{
- // nothing todo?
- // WaE is happy!
+ SAL_WARN( extensions.scanner, short read, abandoning );
+ return 0;
}
+
return (sal_uInt8)( nWord / 256 );
}
sal_uInt8 nByte;
size_t items_read = fread( nByte, 1, 1, fp );
-if (items_read == 0)
+if (items_read != 1)
{
- // nothing todo?
- // WaE is happy!
+SAL_WARN( extensions.scanner, short read, abandoning );
+return 0;
}
return nByte;
}
@@ -819,22 +818,18 @@ sal_Bool Sane::Start( BitmapTransporter rBitmap )
aConverter.Seek( 1084 );
}
-for( nLine = nHeight-1;
- nLine = 0; nLine-- )
+for (nLine = nHeight-1; nLine = 0; --nLine)
{
fseek( pFrame, nLine * aParams.bytes_per_line, SEEK_SET );
if( eType == FrameStyle_BW ||
( eType == FrameStyle_Gray aParams.depth == 8 )
)
{
-size_t items_read = fread( pBuffer, 1,
aParams.bytes_per_line, pFrame );
-
-// fread() does not distinguish between end-of-file and
error, and callers
-// must use feof(3) and ferror(3) to determine which
occurred.
-if (items_read == 0)
+SANE_Int items_read = fread( pBuffer, 1,
aParams.bytes_per_line, pFrame );
+if (items_read != aParams.bytes_per_line)
{
-// nothing todo?
-// WaE is happy!
+SAL_WARN( extensions.scanner, short read, padding
with zeros );
+memset(pBuffer + items_read, 0, aParams.bytes_per_line
- items_read);
}
aConverter.Write( pBuffer, aParams.bytes_per_line );
}
commit 6ef852f160b88b2052c150374fb9aeab43a29804
Author: David Ostrovsky david.ostrov...@gmx.de
Date: Sat Apr 21 14:29:14 2012 +0200
WaE: extensions warnings fixed
diff --git a/extensions/source/nsplugin/source/npshell.cxx
b/extensions/source/nsplugin/source/npshell.cxx
index 81ce8fb..f6b4ea4 100644
--- a/extensions/source/nsplugin/source/npshell.cxx
+++ b/extensions/source/nsplugin/source/npshell.cxx
@@ -772,7 +772,11 @@ NPP_StreamAsFile(NPP instance, NPStream *stream, const
char* fname)
break;
}
-write(fdDst, buffer, ret);
+ssize_t written_bytes = write(fdDst, buffer, ret);
+if (written_bytes == -1)
+{
+return;
+}
}
close(fdSrc);
close(fdDst);
diff --git a/extensions/source/scanner/sane.cxx
b/extensions/source/scanner/sane.cxx
index aaefbf4..ca2cec1 100644
--- a/extensions/source/scanner/sane.cxx
+++ b/extensions/source/scanner/sane.cxx
@@ -524,11 +524,24 @@ static
[Libreoffice-commits] .: 3 commits - idlc/source l10ntools/source solenv/gbuild solenv/inc
idlc/source/wrap_scanner.cxx |6 ++ l10ntools/source/cfg_yy_wrapper.c |3 +++ l10ntools/source/src_yy_wrapper.c |3 +++ l10ntools/source/xrm_yy_wrapper.c |3 +++ solenv/gbuild/platform/macosx.mk |2 +- solenv/inc/unxmacx.mk |4 6 files changed, 20 insertions(+), 1 deletion(-) New commits: commit 8c1e9c7dfdc17b156931bbbe42851c08c7281be5 Author: Tor Lillqvist t...@iki.fi Date: Sun Apr 22 01:29:07 2012 +0300 WaE: comparison of integers of different signs and unused functions diff --git a/idlc/source/wrap_scanner.cxx b/idlc/source/wrap_scanner.cxx index f058db1..94a068a 100644 --- a/idlc/source/wrap_scanner.cxx +++ b/idlc/source/wrap_scanner.cxx @@ -26,7 +26,13 @@ * / +#ifdef __clang__ +#pragma clang diagnostic ignored -Wsign-compare +#endif #include scanner.cxx +void (*avoid_unused_yyunput_in_scanner_cxx)(int, char*) = yyunput; +int (*avoid_unused_yyinput_in_scanner_cxx)() = yyinput; + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ commit 1ac9f91198889cc5cee40ba9ef2b0255183ee195 Author: Tor Lillqvist t...@iki.fi Date: Sun Apr 22 00:59:45 2012 +0300 WaE: unused functions diff --git a/l10ntools/source/cfg_yy_wrapper.c b/l10ntools/source/cfg_yy_wrapper.c index ecfb35b..b22d2a7 100644 --- a/l10ntools/source/cfg_yy_wrapper.c +++ b/l10ntools/source/cfg_yy_wrapper.c @@ -2,4 +2,7 @@ // Helper to suppress warnings in lex generated c code, see #i57362# #include cfg_yy.c +void (*avoid_unused_yyunput_in_cfg_yy_c)() = yyunput; +int (*avoid_unused_yy_flex_strlen_in_cfg_yy_c)() = yy_flex_strlen; + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/l10ntools/source/src_yy_wrapper.c b/l10ntools/source/src_yy_wrapper.c index 974068d..da9c17f 100644 --- a/l10ntools/source/src_yy_wrapper.c +++ b/l10ntools/source/src_yy_wrapper.c @@ -2,4 +2,7 @@ // Helper to suppress warnings in lex generated c code, see #i57362# #include src_yy.c +void (*avoid_unused_yyunput_in_src_yy_c)() = yyunput; +int (*avoid_unused_yy_flex_strlen_in_src_yy_c)() = yy_flex_strlen; + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/l10ntools/source/xrm_yy_wrapper.c b/l10ntools/source/xrm_yy_wrapper.c index 2724ad0..191d16f 100644 --- a/l10ntools/source/xrm_yy_wrapper.c +++ b/l10ntools/source/xrm_yy_wrapper.c @@ -2,4 +2,7 @@ // Helper to suppress warnings in lex generated c code, see #i57362# #include xrm_yy.c +void (*avoid_unused_yyunput_in_xrm_yy_c)() = yyunput; +int (*avoid_unused_yy_flex_strlen_in_xrm_yy_c)() = yy_flex_strlen; + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ commit 1bf04b934a8f51ac50be4cb9b6eacbb092871383 Author: Tor Lillqvist t...@iki.fi Date: Sun Apr 22 00:09:44 2012 +0300 Don't use -Wl,-syslibroot when building against more current SDKs diff --git a/solenv/gbuild/platform/macosx.mk b/solenv/gbuild/platform/macosx.mk index ab955cf..d4d113d 100644 --- a/solenv/gbuild/platform/macosx.mk +++ b/solenv/gbuild/platform/macosx.mk @@ -95,7 +95,7 @@ gb_OBJCXXFLAGS := -x objective-c++ -fobjc-exceptions gb_OBJCFLAGS := -x objective-c -fobjc-exceptions gb_LinkTarget_LDFLAGS := \ - -Wl,-syslibroot,$(gb_SDKDIR) \ + $(if $(filter 1040 1050,$(MAC_OS_X_VERSION_MIN_REQUIRED)),-Wl$(COMMA)-syslibroot$(COMMA)$(gb_SDKDIR)) \ $(subst -L../lib , ,$(SOLARLIB)) \ #man ld says: obsolete -Wl,-multiply_defined,suppress \ diff --git a/solenv/inc/unxmacx.mk b/solenv/inc/unxmacx.mk index e402783..1ca6a82 100644 --- a/solenv/inc/unxmacx.mk +++ b/solenv/inc/unxmacx.mk @@ -178,8 +178,12 @@ LINK*=$(CXX) LINKC*=$(CC) LINKFLAGSDEFS*=-Wl,-multiply_defined,suppress + +.IF $(MAC_OS_X_VERSION_MIN_REQUIRED) = 1050 # assure backwards-compatibility EXTRA_LINKFLAGS*:=-Wl,-syslibroot,$(MACOSX_SDK_PATH) +.ENDIF + # Very long install_names are needed so that install_name_tool -change later on # does not complain that larger updated load commands do not fit: LINKFLAGSRUNPATH_URELIB=-install_name '@__URELIB/$(@:f)' ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PUSHED] Re: [Libreoffice] [PATCH] Fix fdo#39639 [EasyHack] Fix duplicate longname IDs
Hi, Kendy All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Thank you for the information! Victor Lee On Thu, Apr 5, 2012 at 1:42 AM, Jan Holesovsky ke...@suse.cz wrote: Hi Victor, Victor Lee píše v Ne 25. 12. 2011 v 01:41 +0900: I've reformatted the patch. The reason for deleting these IDs is stated here: https://bugs.freedesktop.org/show_bug.cgi?id=39639 Sorry for the late reply, and thank you for the advice! This is my first EasyHack. While cleaning Easy Hacks, I noticed that your patch was not pushed - terribly sorry for that :-(( Fixed that now: http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ba78d1ed9fca82156eebb460b398829b5a3b6db Please - can you confirm that your contribution is under the MPL / LGPLv3+ license? Ideally if you can send a mail like All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. [or similar] to the libreoffice@lists.freedesktop.org mailing list. Thank you for the patch, and sorry again that it fell through the cracks :-( Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36496, which changed state. Bug 36496 Summary: content of frames and captions not editable in text document https://bugs.freedesktop.org/show_bug.cgi?id=36496 What|Old Value |New Value Status|REOPENED|NEEDINFO Resolution||WORKSFORME Status|NEEDINFO|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Dependencies tree
On Sat, Apr 21, 2012 at 01:10:25AM +0200, Mat M m...@gmx.fr wrote: Does anyone already have a script (or binary) which is able to output a readable dependencies tree from build.lst files ? Just to not reinvent the wheel Try http://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/modules_dep ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED-3-5, REVIEW-3-5-3] fdo#48969 ODF import measure conversion regression
On Fri, Apr 20, 2012 at 10:39:08PM +0200, Fridrich Strba fridrich.st...@graduateinstitute.ch wrote: I cherry-picked the commits into 3-5 branch and added http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=580a7f24c373cd8cf068fc92fdb153025e6d0a1d for fixing backporting issues. We need 2 more reviewers to get all that bunch of 4 patches to 3.5.3. Would be nice to have this regression fixed asap. +1 from me, looks reasonable. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.3 RC1 test builds available
Hi Fridrich, *, this mail never reached the l10n@ and projects@ but only the LibO-QA. Is there a problem with the mail-system or something else? Greetings k-j Am 20.04.2012 12:44, schrieb Fridrich Strba: Hi *, for the upcoming new version 3.5.3, the RC1 builds now start to be available on pre-releases. This build is slated to be first release candidate build on the way towards 3.5.3, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.5_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. The list of fixed bugs relative to 3.5.2 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-3-release-3.5.3.1.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich (following words copyrighted by Thorsten) ___ List Name: Libreoffice-qa mailing list Mail address: libreoffice...@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -- Grüße k-j ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ANN] LibreOffice 3.5.3 RC1 available
Dear Community, The Document Foundation is happy to announce the first release candidate of LibreOffice 3.5.3. The upcoming 3.5.3 will be the third in a series of frequent bugfix releases on our feature-packed 3.5 code line. Please be aware that LibreOffice 3.5.3 RC1 is not ready for production use, you should continue to use LibreOffice 3.4.6 or 3.5.2 for that. The release is available for Windows, Linux and Mac OS X from our QA builds download page at http://www.libreoffice.org/download/pre-releases/ A note for Windows users: this Release Candidate will uninstall your current stable build and replace it. If you do not wish this to happen but still would like to test, you should follow the instructions for installing in parallel: http://wiki.documentfoundation.org/Installing_in_parallel Should you find bugs, please report them to the FreeDesktop Bugzilla: https://bugs.freedesktop.org A good way to assess the RC1 quality is to run some specific manual tests on it, our TCM wiki page has more details: http://wiki.documentfoundation.org/QA/Testing/Regression_Tests#Full_Regression_Test (and the announcement mail: http://lists.freedesktop.org/archives/libreoffice/2011-December/022464.html) For other ways to get involved with this exciting project - you can e.g. contribute code: https://www.libreoffice.org/get-involved/developers/ translate LibreOffice to your language: http://wiki.documentfoundation.org/Translation_for_3.5 or help with funding our operations: http://challenge.documentfoundation.org/ A list of known issues with 3.5.3 RC1 is available from our wiki: http://wiki.documentfoundation.org/Releases/3.5.3/RC1 Please find the list of changes against LibreOffice 3.5.2 here: http://download.documentfoundation.org/libreoffice/src/bugfixes-libreoffice-3-5-3-release-3.5.3.1.log Let us close again with a BIG Thank You! to all of you having contributed to the LibreOffice project - this release would not have been possible without your help. Yours, The Document Foundation Board of Directors pgpl33wl0QlvI.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#39643: Remove --disable-strip-solver configure option
Hi,
here is the patch to remove strip solver configure option.
Some places still has a strip code, for example in solenv/bin/deliver.pl
sub initialize_strip {
if ((!defined $ENV{CROSS_COMPILING}) || ($ENV{CROSS_COMPILING} ne
'YES')) {
$strip .= 'guw ' if ($^O eq 'cygwin');
[...]
was not sure if it is still needed.
Note: I've tested make dev-install only on Linux.
Ciao
David
From ee90882e30d4ef9c60ea81018286cbfc8b07b566 Mon Sep 17 00:00:00 2001
From: David Ostrovsky david.ostrov...@gmx.de
Date: Wed, 18 Apr 2012 22:31:41 +0200
Subject: [PATCH] fdo#39643: Remove --disable-strip-solver configure option
---
config_host.mk.in |1 -
configure.in | 30 -
solenv/bin/deliver.pl |3 +-
solenv/bin/make_installer.pl | 28 -
solenv/bin/modules/installer/environment.pm |1 -
solenv/bin/modules/installer/globals.pm |2 -
solenv/bin/modules/installer/parameter.pm |5 -
solenv/bin/modules/installer/simplepackage.pm |4 -
solenv/bin/modules/installer/strip.pm | 144 --
solenv/bin/modules/installer/windows/strip.pm | 158 -
solenv/bin/ooinstall |6 -
solenv/gbuild/gbuild.mk |6 -
solenv/gbuild/platform/solaris.mk |6 -
solenv/gbuild/platform/unxgcc.mk |6 -
14 files changed, 1 insertions(+), 399 deletions(-)
delete mode 100644 solenv/bin/modules/installer/strip.pm
delete mode 100644 solenv/bin/modules/installer/windows/strip.pm
diff --git a/config_host.mk.in b/config_host.mk.in
index fe5fc87..651bdc4 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -89,7 +89,6 @@ export DISABLE_SCRIPTING=@DISABLE_SCRIPTING@
export DISABLE_LINKOO=@DISABLE_LINKOO@
export DISABLE_NEON=@DISABLE_NEON@
export DISABLE_PYTHON=@DISABLE_PYTHON@
-export DISABLE_STRIP=@DISABLE_STRIP@
export DLLTOOL=@DLLTOOL@
export DMAKEROOT=@SRC_ROOT@/solenv/inc/startup
export DOCDIR=@DOCDIR@
diff --git a/configure.in b/configure.in
index 4f981fc..1f1be80 100644
--- a/configure.in
+++ b/configure.in
@@ -611,19 +611,6 @@ AC_ARG_ENABLE(symbols,
AS_HELP_STRING([--enable-symbols],
[Include debugging symbols in output. WARNING - a complete build needs
8 Gb of space and takes much longer (enables -g compiler flag).])
-[
- Enabling symbols disables the stripping of the solver
- (--disable-strip-solver).
-],
-,)
-
-AC_ARG_ENABLE(strip-solver,
-AS_HELP_STRING([--disable-strip-solver],
-[Disable the stripping of the solver. By default the solver is stripped
- unless a build with debugging symbols (--enable-symbols) is requested.])
-[
- This switch allows to override this setting.
-],
,)
AC_ARG_ENABLE(werror,
@@ -3483,23 +3470,6 @@ else
fi
AC_SUBST(ENABLE_SYMBOLS)
-dnl Determine if the solver is to be stripped or not.
-dnl ===
-AC_MSG_CHECKING([whether to strip the solver or not.])
-if test $enable_strip_solver = no; then
-DISABLE_STRIP=TRUE
-AC_MSG_RESULT([no])
-else
-if test -n $ENABLE_SYMBOLS; then
-DISABLE_STRIP=TRUE
-AC_MSG_RESULT([no])
-else
-DISABLE_STRIP=
-AC_MSG_RESULT([yes])
-fi
-fi
-AC_SUBST(DISABLE_STRIP)
-
if test $enable_headless = yes; then
# be sure to do not mess with uneeded stuff
test_randr=no
diff --git a/solenv/bin/deliver.pl b/solenv/bin/deliver.pl
index c524ce5..7a97446 100755
--- a/solenv/bin/deliver.pl
+++ b/solenv/bin/deliver.pl
@@ -673,8 +673,7 @@ sub is_unstripped {
}
sub initialize_strip {
-if (((!defined $ENV{CROSS_COMPILING}) || ($ENV{CROSS_COMPILING} ne 'YES'))
-((!defined $ENV{DISABLE_STRIP}) || ($ENV{DISABLE_STRIP} eq ))) {
+if ((!defined $ENV{CROSS_COMPILING}) || ($ENV{CROSS_COMPILING} ne 'YES')) {
$strip .= 'guw ' if ($^O eq 'cygwin');
$strip .= 'strip';
$strip .= -x if ($ENV{OS} eq 'MACOSX');
diff --git a/solenv/bin/make_installer.pl b/solenv/bin/make_installer.pl
index baf4b08..2cc423c 100644
--- a/solenv/bin/make_installer.pl
+++ b/solenv/bin/make_installer.pl
@@ -58,7 +58,6 @@ use installer::scpzipfiles;
use installer::scriptitems;
use installer::setupscript;
use installer::simplepackage;
-use installer::strip qw(strip_libraries);
use installer::substfilenamefiles;
use installer::systemactions;
use installer::windows::assembly;
@@ -82,7 +81,6 @@ use installer::windows::removefile;
use installer::windows::registry;
use installer::windows::selfreg;
use installer::windows::shortcut;
-use installer::windows::strip;
use installer::windows::update;
use installer::windows::upgrade;
use installer::worker;
@@ -1227,19 +1225,6 @@ for ( my $n = 0; $n = $#installer::globals::languageproducts; $n++ )
[PATCH] fdo#39999: Changing spelling preferences requires application restart
Hi! Bug's page After applying this patch, checking 'Check uppercase words' in options works without restarting LO. It's very simple, a single line, but it took me a while to find the right place to start... :) I hope that the patch is OK. Szabolcs From 4918f04e6f7e57314b58061860bc5b7a6f3ea60c Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi dezsisz...@hotmail.com Date: Sat, 21 Apr 2012 15:28:50 +0200 Subject: [PATCH] Changing 'Check uppercase words' works without restart --- linguistic/source/lngprophelp.cxx |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/linguistic/source/lngprophelp.cxx b/linguistic/source/lngprophelp.cxx index b93971f..82a7c4d 100644 --- a/linguistic/source/lngprophelp.cxx +++ b/linguistic/source/lngprophelp.cxx @@ -522,6 +522,7 @@ void PropertyHelper_Spell::SetTmpPropVals( const PropertyValues rPropVals ) nResMaxNumberOfSuggestions = GetDefaultNumberOfSuggestions(); bResIsSpellWithDigits = bIsSpellWithDigits; bResIsSpellCapitalization = bIsSpellCapitalization; +bResIsSpellUpperCase= bIsSpellUpperCase; sal_Int32 nLen = rPropVals.getLength(); if (nLen) -- 1.7.7 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Replace SV_DECL_PTRARR_DEL by ptr_vector in WW8ListManager
On Sat, 2012-04-14 at 15:30 +0200, Arnaud Versini wrote: Hi This patch replace SV_DECL_PTRARR_DEL by a simple ptr_vector in WW8ListManager. Looks good, pushed now, sorry for the delay I'm not sure about this comment in the destructor, the object is always destroyed, I think we should use a ptr_vector too, or don't destroy unconditionally (*aIter). The comment is correct, best read split like... named lists remain in doc!!! unnamed lists are deleted when unused which refers to the conditional use of DelNumRule to remove unused automatic numbering rules from the final imported document, while pLFOInfos are in any case destructed refers to the deletion of the contents of pLFOInfos (etc). Committed a change to the comment now. Yup, you could use a ptr_vector there if you wanted. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] minutes of ESC call ...
On Thu, Apr 19, 2012 at 10:47 AM, Francois Tigeot ftig...@wolfpond.org wrote: Hey, On Thu, Apr 19, 2012 at 04:11:18PM +0100, Michael Meeks wrote: * tinderboxen / status (Norbert) + bytemark machine #2 + working on *BSD in virtualbox with little joy help appreciated (Norbert) + need 3x BSD virtual-boxes (ideally) I'd like to know a bit more about this item; Norbert, would you prefer real boxes if possible ? We do not have the resources for that.. but if you volunteer such a box... sure, by all means... what is needed ? - a box that do build, preferably in reasonable time... but since right now there are no *BSD tinderbox, anytime is more reasonable than +inf :-) - download the contrib/buildbot repo : http://cgit.freedesktop.org/libreoffice/contrib/buildbot/ - read http://cgit.freedesktop.org/libreoffice/contrib/buildbot/tree/README.tinbuild2 - bear in mind that the tinbuild2 script and dep and un-apologetically bash. I have zero interest in wasting time to get to the lowest common denominator. (*) - look at https://wiki.documentfoundation.org/Development/Tinderbox#List_of_registered_Tinderboxes and when the time comes, register your box there... be mindful of the naming convention... - once all that is up and running, and if there is a need/benefit to have dailies uploaded, then we will work on the next step to get the right credential to do that. Norbert (*) as tinbuild2 has never been exercised aaik on *BSD platform, there may-be some quirk. fortunately tinbuil2 has a way to do 'platform overload' look at http://cgit.freedesktop.org/libreoffice/contrib/buildbot/tree/bin/tinbuild_internals_Darwin.sh for such example for MacOS see the comment in the top of http://cgit.freedesktop.org/libreoffice/contrib/buildbot/tree/bin/tinbuild2 for some more explanations ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
PATCH: Remove unused code from Spreadsheet-application-code
Hello,These is the patch that I've created.
Licence: made available under the MPL/LGPLv3+
Ferran Vidal
From 8d19526ff84cab319babf7e6b1f03c05fea5bdf0 Mon Sep 17 00:00:00 2001
From: Ferran Vidal vidalmargi...@hotmail.com
Date: Sat, 21 Apr 2012 18:08:11 +0200
Subject: [PATCH] Remove unused code from Spreadsheet application code
---
sc/inc/cell.hxx |1 -
sc/source/core/data/cell.cxx |5 -
unusedcode.easy |2 --
3 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/sc/inc/cell.hxx b/sc/inc/cell.hxx
index 08fbdfa..b4549d1 100644
--- a/sc/inc/cell.hxx
+++ b/sc/inc/cell.hxx
@@ -207,7 +207,6 @@ public:
DECL_FIXEDMEMPOOL_NEWDEL( ScStringCell )
#endif
-ScStringCell();
explicitScStringCell(const rtl::OUString rString);
#if OSL_DEBUG_LEVEL 0
diff --git a/sc/source/core/data/cell.cxx b/sc/source/core/data/cell.cxx
index 9ccadde..a4e5361 100644
--- a/sc/source/core/data/cell.cxx
+++ b/sc/source/core/data/cell.cxx
@@ -657,11 +657,6 @@ ScValueCell::~ScValueCell()
//
-ScStringCell::ScStringCell() :
-ScBaseCell( CELLTYPE_STRING )
-{
-}
-
ScStringCell::ScStringCell( const rtl::OUString rString ) :
ScBaseCell( CELLTYPE_STRING ),
maString( rString.intern() )
diff --git a/unusedcode.easy b/unusedcode.easy
index 89aa3c8..ef08833 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -1,5 +1,4 @@
CertificateExtension_XmlSecImpl::setCertExtn(com::sun::star::uno::Sequencesigned char, com::sun::star::uno::Sequencesigned char, unsigned char)
-CharAttribList::Clear()
Dialog::Dialog(Window*, ResId const)
EditEngine::GetNextVisPortion(ParaPortion const*) const
FmFieldWinMgr::GetChildWindowId()
@@ -86,7 +85,6 @@ ScRTFColTwips_SAR::_ForEach(unsigned short, unsigned short, unsigned char (*)(un
ScRangeData::ReplaceRangeNamesInUse(std::__debug::mapunsigned short, unsigned short, std::lessunsigned short, std::allocatorstd::pairunsigned short const, unsigned short const)
ScRangeData::ScRangeData(unsigned short)
ScSimpleRangeList::Range::contains(ScSimpleRangeList::Range const) const
-ScStringCell::ScStringCell()
ScTable::ReplaceRangeNamesInUse(short, int, short, int, std::__debug::mapunsigned short, unsigned short, std::lessunsigned short, std::allocatorstd::pairunsigned short const, unsigned short const)
ScTypedStrData::GetValue() const
ScValidationEntries_Impl::Insert(ScValidationData* const, unsigned short)
--
1.7.5.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] minutes of ESC call ...
On Sat, Apr 21, 2012 at 09:09:34AM -0500, Norbert Thiebaud wrote: On Thu, Apr 19, 2012 at 10:47 AM, Francois Tigeot ftig...@wolfpond.org wrote: On Thu, Apr 19, 2012 at 04:11:18PM +0100, Michael Meeks wrote: * tinderboxen / status (Norbert) + bytemark machine #2 + working on *BSD in virtualbox with little joy help appreciated (Norbert) + need 3x BSD virtual-boxes (ideally) I'd like to know a bit more about this item; Norbert, would you prefer real boxes if possible ? We do not have the resources for that.. but if you volunteer such a box... sure, by all means... There was some talk recently in the DragonFly BSD project about providing test boxes for external developers; I'm collecting information in that context. what is needed ? - a box that do build, preferably in reasonable time... but since right now there are no *BSD tinderbox, anytime is more reasonable than +inf :-) We were thinking of Xeon E3 machines, perhaps in a mini-cluster form like this one: http://www.supermicro.nl/products/nfo/MicroCloud.cfm - download the contrib/buildbot repo : [...] and when the time comes, register your box there... be mindful of the naming convention... If boxes are finally set up, they will be DragonFly + pkgsrc packages only, special software will have to be maintained by the developers themselves. I won't be able to help on that front, my hands are already full integrating LO into pkgsrc :-/ -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] fdo#39999: Changing spelling preferences requires application restart
On Sat, 2012-04-21 at 15:34 +0200, Dézsi Szabolcs wrote: After applying this patch, checking 'Check uppercase words' in options works without restarting LO. It's very simple, a single line, but it took me a while to find the right place to start... :) That's great, looks very good to me, pushed. Much appreciated. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] PATCH: Remove unused code from Spreadsheet-application-code
On Sat, 2012-04-21 at 17:20 +0100, Ferran Vidal i Marginet wrote: Hello, These is the patch that I've created. Looks good, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] minutes of ESC call ...
On Sat, Apr 21, 2012 at 2:18 PM, Francois Tigeot ftig...@wolfpond.org wrote: On Sat, Apr 21, 2012 at 09:09:34AM -0500, Norbert Thiebaud wrote: On Thu, Apr 19, 2012 at 10:47 AM, Francois Tigeot ftig...@wolfpond.org wrote: On Thu, Apr 19, 2012 at 04:11:18PM +0100, Michael Meeks wrote: * tinderboxen / status (Norbert) + bytemark machine #2 + working on *BSD in virtualbox with little joy help appreciated (Norbert) + need 3x BSD virtual-boxes (ideally) I'd like to know a bit more about this item; Norbert, would you prefer real boxes if possible ? We do not have the resources for that.. but if you volunteer such a box... sure, by all means... There was some talk recently in the DragonFly BSD project about providing test boxes for external developers; I'm collecting information in that context. what is needed ? - a box that do build, preferably in reasonable time... but since right now there are no *BSD tinderbox, anytime is more reasonable than +inf :-) We were thinking of Xeon E3 machines, perhaps in a mini-cluster form like this one: http://www.supermicro.nl/products/nfo/MicroCloud.cfm - download the contrib/buildbot repo : [...] and when the time comes, register your box there... be mindful of the naming convention... If boxes are finally set up, they will be DragonFly + pkgsrc packages only, special software will have to be maintained by the developers themselves. I won't be able to help on that front, my hands are already full integrating LO into pkgsrc :-/ what do you mean by 'special software' ? Right now the tinbuild2 scrip does make clean + make... but that can be overridden via a local extension to redifine do_make and do_clean function (or any other do_* function, so it _could_ call pkgsrc ... in fact the tinbuild2 implementation is very much inspired by emerge (gentoo) so that should be familiar... there are 'build' phases (clean, autogen, make, test, push) each of them have a pre/do/post step that can be used. you can develop extension completely locally and we could integrate them later as a platform specific extension in tinderbuild2 itself. The goal would be for that box to be doing what _you_ would normally do to build lo on your platform, so that breakage are detected early... you can set it up so that it report to the web-service, but not necessarily spam everybody, if most of the breakage are related to the build system rather than the product itself (see the -m options to control email spamming and tinderbox reporting) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH][PUSHED][REVIEW 3-5-3] fix fdo#45848 pdfimport regression
On Sat, 2012-04-21 at 10:09 +0700, Korrawit Pruegsanusak wrote: Hello all, Please find the attached patch to fix fdo#45848. I've tested the patch at libreoffice-3.5.2.2 tag on Windows XP, but not tested on master yet. Of course, please review and push it to appropriate branch(es). :) Pushed to master and 3-5. Need more reviewers to get it into 3-5-3 C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED:3-5][REVIEW:3-5-3] fdo#48356 fix RTF import of special unicode characters
On Fri, 2012-04-20 at 15:49 +0200, Andras Timar wrote: Hi, 2012/4/20 Miklos Vajna vmik...@suse.cz: Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=69259c6 The fix works. Looks ok +1, one more reviewer required for 3-5-3, right ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] WaE fixed in crashrep and extensions modules
On Sat, 2012-04-21 at 15:50 +0200, David Ostrovsky wrote: Hi, I'm getting build errors in crashrep and extensions modules (whith enabled --enable-werror option). With these patches the warnings/errors are fixed. Looks good, pushed, thanks for these. I wonder why *I* didn't see them before though seeing as I build with -Werror. crashrep is disabled by default, so that's understandable, but the scanner stuff in extensions is built by default and I've got... export CFLAGS=-Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 export CXXFLAGS=-Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 export ARCH_FLAGS=-Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 in my (Fedora 16) environment to generally get those extra warnings (I thought). I knew that e.g. Ubuntu configured gcc to add some extra warnings etc by default, but I had thought the above covered those additions. Wonder what I'm missing to get your warnings ?, i.e. what's your compiler version and distro ? For the second patch I added a follow up commit of e37ae322b07a02714b22cb663e1d7ab4f2072730 to fill in the todos. e.g. I reckon it's best to compare how many bytes/members were written/read with write/read fread/fwrite vs what was requested to detect partial failure short read/write as well as the added detection of out and out utter failure. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
patch cell.cxx
Hi. i send a patch for libreoffice (fich cell.cxx)
thanks
From d0214f5201839066f495a285721dfddbcdeb816a Mon Sep 17 00:00:00 2001
From: Jose Manuel jmreca...@gmail.com
Date: Sun, 22 Apr 2012 00:21:24 +0200
Subject: [PATCH] cell.cxx
---
core/sc/source/core/data/cell.cxx |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/core/sc/source/core/data/cell.cxx b/core/sc/source/core/data/cell.cxx
index 9ccadde..a4e5361 100644
--- a/core/sc/source/core/data/cell.cxx
+++ b/core/sc/source/core/data/cell.cxx
@@ -657,11 +657,6 @@ ScValueCell::~ScValueCell()
//
-ScStringCell::ScStringCell() :
-ScBaseCell( CELLTYPE_STRING )
-{
-}
-
ScStringCell::ScStringCell( const rtl::OUString rString ) :
ScBaseCell( CELLTYPE_STRING ),
maString( rString.intern() )
--
1.7.4.1
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.3 RC1 test builds available
Hi Fridrich, *, this mail never reached the l10n@ and projects@ but only the LibO-QA. Is there a problem with the mail-system or something else? Greetings k-j Am 20.04.2012 12:44, schrieb Fridrich Strba: Hi *, for the upcoming new version 3.5.3, the RC1 builds now start to be available on pre-releases. This build is slated to be first release candidate build on the way towards 3.5.3, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.5_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. The list of fixed bugs relative to 3.5.2 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-3-release-3.5.3.1.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich (following words copyrighted by Thorsten) ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -- Grüße k-j ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Information in Master builds About box
The new About box in branch 3.6.x is indeed extremely nice. But the version information is extremely incomplete version 3.6.0alpha0+ (Build ID: e00e693) For QA this is mostly useless. The only information you can get from this is about the core repository... Any other build using the same core will have the same info, even if all else changed. Please go back to LibreOffice 3.5.3.1 Build ID: 21cb047-d7e6025-9ba54fc-b4a51a8-f42372b We already wasted a lot of time to reach this conclusion... (I still think that some democracy would help this project) Regards, Pedro -- View this message in context: http://nabble.documentfoundation.org/Information-in-Master-builds-About-box-tp3927916p3927916.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Bug Triage best practice: Change or not change assignee?
Hi, On Sat, Apr 21, 2012 at 09:53:22AM +0200, Rainer Bielefeld wrote: I believe it is a very bad idea to use that field to show who should contribute additional information to the bug report, the Assigned To field should remain reserved for the competent person person who will fix the bug (or at least will manage the fixing), please also see Bugzilla Help, and I never saw an other usage for that field (and I saw a lot, you know.) Assignee is and has always been the guy who owns the bug. Thats the guy who needs to take the next action for the bug to be resolved. It doesnt make any difference if that action is changing code, bisecting, designing a new feature or providing additional info. And fixing the bug is not the changing code part -- that is very easy once the issue is identified. Additionally assigning a NEEDINFO-bug to competent person who will fix the bug makes no sense at all -- as long as the bug is NEEDINFO, there is no way to know who that would be. So I can't see that the new Wiki text describes common sense or general use, but it defines a new standard. This is how ~every other open source project manages its bugs, so its is only natural to do the same on LibreOffice. Diverting from that standard is want needs justification, not the other way around. Everyting else (like this infoprovider-nonsense) will only cause confusion. Dont do things you need to explain, do things that explain themselves. Assigning the bug back to the reporter selfevidently makes clear that he is required to take action to move the bug along. This is how bug tracker users everywhere have been working for ages: - bug needs more info to be solved = assign to reporter - bug is triaged = assign to dev - bug is fixed = assign to QA or reporter for verification - bug is verified = assign to the guy who makes the release for closing when release in the product c) Generally please do not modify existing proceedings without discussion, people like me use information in Bugzilla for queries, and every change breaks those queries and causes additional work (like this discussion, too) Please dont expect users to do things different then everywhere else because you would need to adjust your queries. d) IMHO it has become a standard that people add themselves to assigned to, this standard would be broken with the proceeding due to Wiki Its no standard at all, as it is not done like that anywhere else. So I suggest proceeding: - only set Status NEEDINFO with text request in comment, but without assignation to reporter I dont see that vital, but it usually helps to bring the point across (better than any Dear Reporter comment, although that helps too). - if info is required not from reporter ad infoprovider key word. No, that would be absolutely useless. This infoprovider nonsense is rarely used in bug trackers -- the only major user of this aberration is the Novell bugzilla, all others use the sane workflow above. It is unintuitive and uncommon and would require end users (who are the most likely infoproviders) to read the doc -- which they do not (unlike QA volunteers). In addition it dilutes the clear responsibility of the assignee field: The assignee is the current owner of the bug and the guy who is expected to move it along. That usually helps move things along or someone else will pick the bug up. You are risking lots of silent deadlocks of the assignee-thinks-infoprovider-has-to-action- this-and-infoprovider-thinks-assignee-has-to-action-this-kind by this. If there is info needed from someone else than the reporter, it is assigned to that guy. Thats common sense and how it is done everywhere else. If you want to do that different for LibreOffice, you need some serious justification. Needing to adjust queries is not one (we should never have done it like that in the first place). So please revert the wiki again and let LibreOffice handle this like pretty much every other open source project. We should get over that infoprovider-nonsense as quick as possible and good riddance. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Information in Master builds About box
On Sat, Apr 21, 2012 at 03:18:41AM -0700, Pedro wrote: For QA this is mostly useless. The only information you can get from this is about the core repository... Which is where 99% of the action is, so please refrain from exaggerations. LibreOffice 3.5.3.1 Build ID: 21cb047-d7e6025-9ba54fc-b4a51a8-f42372b I dont know why the change was done, but I think a better way would be to use 'git submodules' to include the state of the other repos in the core commit-id. Norbert was having a look at that, IIRC. @Norbert: Any conclusions from your research for gerrit wrt git submodules? (I still think that some democracy would help this project) LibreOffice is proudly founded on meritocratic foundations. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call ...
On Thu, Apr 19, 2012 at 10:47 AM, Francois Tigeot ftig...@wolfpond.org wrote: Hey, On Thu, Apr 19, 2012 at 04:11:18PM +0100, Michael Meeks wrote: * tinderboxen / status (Norbert) + bytemark machine #2 + working on *BSD in virtualbox with little joy help appreciated (Norbert) + need 3x BSD virtual-boxes (ideally) I'd like to know a bit more about this item; Norbert, would you prefer real boxes if possible ? We do not have the resources for that.. but if you volunteer such a box... sure, by all means... what is needed ? - a box that do build, preferably in reasonable time... but since right now there are no *BSD tinderbox, anytime is more reasonable than +inf :-) - download the contrib/buildbot repo : http://cgit.freedesktop.org/libreoffice/contrib/buildbot/ - read http://cgit.freedesktop.org/libreoffice/contrib/buildbot/tree/README.tinbuild2 - bear in mind that the tinbuild2 script and dep and un-apologetically bash. I have zero interest in wasting time to get to the lowest common denominator. (*) - look at https://wiki.documentfoundation.org/Development/Tinderbox#List_of_registered_Tinderboxes and when the time comes, register your box there... be mindful of the naming convention... - once all that is up and running, and if there is a need/benefit to have dailies uploaded, then we will work on the next step to get the right credential to do that. Norbert (*) as tinbuild2 has never been exercised aaik on *BSD platform, there may-be some quirk. fortunately tinbuil2 has a way to do 'platform overload' look at http://cgit.freedesktop.org/libreoffice/contrib/buildbot/tree/bin/tinbuild_internals_Darwin.sh for such example for MacOS see the comment in the top of http://cgit.freedesktop.org/libreoffice/contrib/buildbot/tree/bin/tinbuild2 for some more explanations ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call ...
On Sat, Apr 21, 2012 at 09:09:34AM -0500, Norbert Thiebaud wrote: On Thu, Apr 19, 2012 at 10:47 AM, Francois Tigeot ftig...@wolfpond.org wrote: On Thu, Apr 19, 2012 at 04:11:18PM +0100, Michael Meeks wrote: * tinderboxen / status (Norbert) + bytemark machine #2 + working on *BSD in virtualbox with little joy help appreciated (Norbert) + need 3x BSD virtual-boxes (ideally) I'd like to know a bit more about this item; Norbert, would you prefer real boxes if possible ? We do not have the resources for that.. but if you volunteer such a box... sure, by all means... There was some talk recently in the DragonFly BSD project about providing test boxes for external developers; I'm collecting information in that context. what is needed ? - a box that do build, preferably in reasonable time... but since right now there are no *BSD tinderbox, anytime is more reasonable than +inf :-) We were thinking of Xeon E3 machines, perhaps in a mini-cluster form like this one: http://www.supermicro.nl/products/nfo/MicroCloud.cfm - download the contrib/buildbot repo : [...] and when the time comes, register your box there... be mindful of the naming convention... If boxes are finally set up, they will be DragonFly + pkgsrc packages only, special software will have to be maintained by the developers themselves. I won't be able to help on that front, my hands are already full integrating LO into pkgsrc :-/ -- Francois Tigeot ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 43003] : Macro Function as Array doesn't update
https://bugs.freedesktop.org/show_bug.cgi?id=43003 sasha.libreoff...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||sasha.libreoff...@gmail.com Ever Confirmed|0 |1 --- Comment #1 from sasha.libreoff...@gmail.com 2012-04-20 23:13:09 PDT --- Reproducible in 3.3.4 and 3.5.2 on Fedora 64 bit Cell F1 contains call to Basic function that returns ordinary (scalar) value. It updates after press F9. Cells B1,C1 contain call to Basic function that returns array value. It not updates after press F9. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43003] Calc EDITING: Cells, containing call to Macro Function as Array doesn't update, even if press F9
https://bugs.freedesktop.org/show_bug.cgi?id=43003 sasha.libreoff...@gmail.com changed: What|Removed |Added Summary|: Macro Function as Array |Calc EDITING: Cells, |doesn't update |containing call to Macro ||Function as Array doesn't ||update, even if press F9 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46407] Upgraded to most recent release and it won't open.
https://bugs.freedesktop.org/show_bug.cgi?id=46407 Uli metadi...@live.de changed: What|Removed |Added Severity|critical|major Version|LibO 3.5.2 Release |LibO 3.5.3 RC1 --- Comment #5 from Uli metadi...@live.de 2012-04-20 23:56:20 PDT --- 1. does it help you to start LO with fresh user configuration? I deleted the old 3 folder, that's in Win7 named C:\Users\username\AppData\Roaming\LibreOffice\3 Next start LibreOffice creates a new folder 3, but ends the first time without notice. The second start does run, but the crashes remain on opening an existing document. The 'restore' will even success, but then the process terminates again. 2. Try to remove extensions Don't have extensions. It's official installed, orginially in 3.4, upgraded to 3.5 and updated to 3.5.2. Only change in custom installation is that i don't install the quick starter 'feature'. Have now updated to 3.5.3 RC1, LibreOffice is back! ;) Did not need to delete 3 again, works now for me, on opening from shell and also on opening using the dialog. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47521] Presentation mode
https://bugs.freedesktop.org/show_bug.cgi?id=47521 Florian Reisinger reisi...@gmail.com changed: What|Removed |Added AssignedTo|reisi...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #5 from Florian Reisinger reisi...@gmail.com 2012-04-20 23:57:48 PDT --- PS: I reset assignee to defaul ( I have just seen it ;) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48337] EDITING: 'Keep scaling' in Crop tab of Picture dialog has no effect
https://bugs.freedesktop.org/show_bug.cgi?id=48337 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|NEEDINFO|NEW AssignedTo|scrapi...@yahoo.de |libreoffice-b...@lists.free ||desktop.org CC||LibreOffice@bielefeldundbus ||s.de Summary|'Keep scaling' in Crop tab |EDITING: 'Keep scaling' in |of Picture dialog has no|Crop tab of Picture dialog |effect |has no effect --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-04-21 00:33:37 PDT --- [Reproducible] with LibreOffice 3.5.3.1 German UI/Locale [Build-ID: 21cb047-d7e6025-9ba54fc-b4a51a8-f42372b] on German WIN7 Home Premium (64bit), please see attached sample. I also can reproduce the problem in DRAW, so I believe that the roots for the problem are in DRAW. I will contribute a step by step instruction later before I modify Component and assign. @Nino: stoana can't fix that bug, so removed from Assigned to. The Wiki info is not common sense, and I do not accept the Wiki suggestion because of severe disadvantages. https://bugs.freedesktop.org/page.cgi?id=fields.html#assigned_to @stoana: If this is not the effect you wanted to report please submit a new Bug and set me to CC. (Wenn das nicht das Problem ist, das du melden wolltest, öffne bitte einen neuen Bug-Report und setze mich bei CC ein! Eine genauere Beschreibung des Problems wäre hilfreich.). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43031] Naming convention for Master builds
https://bugs.freedesktop.org/show_bug.cgi?id=43031 sasha.libreoff...@gmail.com changed: What|Removed |Added CC||sasha.libreoff...@gmail.com --- Comment #2 from sasha.libreoff...@gmail.com 2012-04-21 00:50:24 PDT --- Currently LibO not uses exe files for installs and not extracts installer to folder. May be problems is fixed? Problem was this: After unpacking an installation folder is created, named e.g. LibO-dev 3.5 (4ec47f5f) Installation Files and impossible was to understand, what for folder it is -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48337] EDITING: 'Keep scaling' in Crop tab of Picture dialog has no effect
https://bugs.freedesktop.org/show_bug.cgi?id=48337 --- Comment #5 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-04-21 01:07:59 PDT --- Damned, I reproduced the problem in DRAW, but I did not note how, and now I fail to create a step by step instruction. I will retry later. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47521] SLIDESHOW does not work for particular .ppt
https://bugs.freedesktop.org/show_bug.cgi?id=47521 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Severity|critical|normal Summary|Presentation mode |SLIDESHOW does not work for ||particular .ppt --- Comment #6 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-04-21 01:19:35 PDT --- Some time ago we had a bug (I can't find it) where reporter thought that move to next slide did not work, but in fact all contents of silde came up immediately and not one by one click by click due to custom animation. So he had to click several times without any visible reaction until slide changed. This sounds similar, but there we did not have the partial view (what might be additional problem from Bug 46901). I did not check all Version dependencies, indeed, let's wait for reporter's sample. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43049] Printer driver for fax not working
https://bugs.freedesktop.org/show_bug.cgi?id=43049 sasha.libreoff...@gmail.com changed: What|Removed |Added CC||sasha.libreoff...@gmail.com --- Comment #3 from sasha.libreoff...@gmail.com 2012-04-21 01:20:41 PDT --- Thanks for bugreport And if we change Printer language type (on second screenshot) from PDF to Postscript level 2, problem remains? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47653] [EasyHack] Create VirtualBox image to generate stacktraces for crashes
https://bugs.freedesktop.org/show_bug.cgi?id=47653 Elton Chung el...@layerjet.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|libreoffice-b...@lists.free |el...@layerjet.com |desktop.org | QAContact||libreoffice-b...@lists.free ||desktop.org --- Comment #1 from Elton Chung el...@layerjet.com 2012-04-21 01:35:18 PDT --- Assigning to myself. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33896] User-created new dictionaries are uneditable and undeletable
https://bugs.freedesktop.org/show_bug.cgi?id=33896 manj_k courrier.oou.fr@googlemail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||NOTABUG AssignedTo|felix.kov...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #3 from manj_k courrier.oou.fr@googlemail.com 2012-04-21 01:36:58 PDT --- Probably caused by user configuration. Closed due to inactivity of the reporter. Reset Assignee to default. RESOLVED NOTABUG CLOSED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43045] add a one click (one key) command to apply a Custom Animation command to selected objects w/o using tasks menus
https://bugs.freedesktop.org/show_bug.cgi?id=43045 sasha.libreoff...@gmail.com changed: What|Removed |Added Platform|Other |All Status|UNCONFIRMED |NEW Severity|normal |enhancement CC||sasha.libreoff...@gmail.com Ever Confirmed|0 |1 --- Comment #2 from sasha.libreoff...@gmail.com 2012-04-21 01:42:08 UTC --- Thanks for new idea I agree that this functionality may greatly improve productivity of creating presentations. Workaround: if we need add the same animation for several drawing objects on the same slide, we can select them all and add animation. It will added to them all. It works only for drawing objects and only on one slide. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43045] Impress functionality request: add a one click (one key) command to apply a Custom Animation command to selected objects w/o using tasks menus
https://bugs.freedesktop.org/show_bug.cgi?id=43045 sasha.libreoff...@gmail.com changed: What|Removed |Added Summary|add a one click (one key) |Impress functionality |command to apply a Custom |request: add a one click |Animation command to|(one key) command to apply |selected objects w/o using |a Custom Animation command |tasks menus |to selected objects w/o ||using tasks menus -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43072] SPELL: seems disconnected
https://bugs.freedesktop.org/show_bug.cgi?id=43072 sasha.libreoff...@gmail.com changed: What|Removed |Added CC||sasha.libreoff...@gmail.com --- Comment #1 from sasha.libreoff...@gmail.com 2012-04-21 01:45:17 UTC --- Thanks for bugreport Please, verify if in last version of LibreOffice still reproducible -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49033] New: Change case - Sentence case doesn't honor selection; case of entire sentence changes
https://bugs.freedesktop.org/show_bug.cgi?id=49033 Bug #: 49033 Summary: Change case - Sentence case doesn't honor selection; case of entire sentence changes Classification: Unclassified Product: LibreOffice Version: LibO 3.5.2 Release Platform: Other OS/Version: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: mikekagan...@hotmail.com If a part of a sentence is selected, the Format-Change case-Sentence case ignores this selection and changes the case of all characters in this sentence. This is very annoying, when I try to normalize case of a sentence like CURRENT IS EQUAL TO 10 A - the unit should stay uppercase, and it isn't selected, but still becomes lowercase. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49034] New: Draw, Impress EDITING: Ctrl-Z behaves unexpectedly when editing text inside of draw objects
https://bugs.freedesktop.org/show_bug.cgi?id=49034 Bug #: 49034 Summary: Draw, Impress EDITING: Ctrl-Z behaves unexpectedly when editing text inside of draw objects Classification: Unclassified Product: LibreOffice Version: LibO 3.5.2 Release Platform: All OS/Version: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Presentation AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: sasha.libreoff...@gmail.com Strange behaviour in Draw and Impress of Ctrl-Z Steps to reproduce: 0. Start Draw or Impress 1. Draw rectangle 2. Double click inside of it and enter some text (1 char. enough) Now in my case I see centre aligned text with size of font 18 3. Press Ctrl-Z Expected: last character disappears Actually: aligning of text becomes Left aligned 4. Press Ctrl-Z Expected: last character disappears Actually: size of font 18 becomes 24 Reproduced in 3.5.2 on Fedora 64 bit and Windows 7 32 bit Not reproducible in 3.3.4, so regression or undocumented functionality -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43100] EDITING: It is better for spaces at the end of line to cause a new line (enhancement)
https://bugs.freedesktop.org/show_bug.cgi?id=43100 --- Comment #4 from sasha.libreoff...@gmail.com 2012-04-21 02:17:37 PDT --- Workaround: use Ctrl-Shift-Space instead of spaces -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43131] VIEWING: Button bar display on Win7 with high contrast desktop setting
https://bugs.freedesktop.org/show_bug.cgi?id=43131 sasha.libreoff...@gmail.com changed: What|Removed |Added Platform|Other |All OS/Version|All |Windows (All) Status|UNCONFIRMED |NEW CC||sasha.libreoff...@gmail.com Ever Confirmed|0 |1 --- Comment #1 from sasha.libreoff...@gmail.com 2012-04-21 02:39:18 PDT --- Reproducible in 3.5.2 on Windows 7 32 bit only in LibreOffice starting window. When we select some document, then all looks correctly. Windows 7 switches to High Contrast by pressing Alt-Shift-PrtScreen combination. When we switch to High Contrast, LibreOffice switches to High Contrast icon theme. But when we disable High Contrast in Windows, LibreOffice not switches to previous icon theme again. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43031] Naming convention for Master builds
https://bugs.freedesktop.org/show_bug.cgi?id=43031 --- Comment #4 from sasha.libreoff...@gmail.com 2012-04-21 02:46:40 PDT --- Releases and candidates are msi. Master not tested, but here I see msi: http://dev-builds.libreoffice.org/daily/Win-x86@15-Prague_Win32/libreoffice-3-5/2012-04-20_21.51.25/ -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43031] Naming convention for Master builds
https://bugs.freedesktop.org/show_bug.cgi?id=43031 --- Comment #6 from sasha.libreoff...@gmail.com 2012-04-21 02:59:58 PDT --- So, what information should be added to filename? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48160] FORMATTING: Conditional formatting broken
https://bugs.freedesktop.org/show_bug.cgi?id=48160 starmat...@yahoo.de changed: What|Removed |Added CC||starmat...@yahoo.de --- Comment #5 from starmat...@yahoo.de 2012-04-21 03:02:30 PDT --- You have to insert a, b and c (with capitals) in the conditional format window instead of plain a,b or c. This works for me. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49035] New: Problems with recognizing Chinese fonts when running PDF export in headless mode
https://bugs.freedesktop.org/show_bug.cgi?id=49035 Bug #: 49035 Summary: Problems with recognizing Chinese fonts when running PDF export in headless mode Classification: Unclassified Product: LibreOffice Version: LibO 3.5.1 Release Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: PDF export AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: sam...@gmail.com Same issue reported here: https://issues.apache.org/ooo/show_bug.cgi?id=111292 It seems like the headless mode does not know how to properly auto-substitute fonts. If you create a docx document with Chinese characters and use a font like Arial Unicode MS (a font that does not exist on my Linux system). Headless mode will churn out a PDF with square blocks. But, if I open the document in GUI mode, the program knows how to substitute the unknown font for something that exist in my system. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49035] Problems with recognizing Chinese fonts when running PDF export in headless mode
https://bugs.freedesktop.org/show_bug.cgi?id=49035 --- Comment #1 from Sam sam...@gmail.com 2012-04-21 03:17:47 PDT --- This also applies for Japanese. And I suspect this affects all East Asian languages. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49035] Problems with recognizing Chinese fonts when running PDF export in headless mode
https://bugs.freedesktop.org/show_bug.cgi?id=49035 Sam sam...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=38311 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47521] SLIDESHOW does not work for particular .ppt
https://bugs.freedesktop.org/show_bug.cgi?id=47521 Kingtib thibault.vandenber...@oxylane.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||FIXED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48876] RTF: RTF formatting is not correct
https://bugs.freedesktop.org/show_bug.cgi?id=48876 Miklos Vajna vmik...@suse.cz changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Miklos Vajna vmik...@suse.cz 2012-04-21 03:43:49 UTC --- Reproduced. The \nosupersub bug will be fixed in 3.5.3, see bug 47326. Assign to me for the incorrect \sl handling, will fix it in a bit. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48876] RTF: RTF formatting is not correct
https://bugs.freedesktop.org/show_bug.cgi?id=48876 Miklos Vajna vmik...@suse.cz changed: What|Removed |Added AssignedTo|libreoffice-b...@lists.free |vmik...@suse.cz |desktop.org | -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43031] Naming convention for Master builds: Please add Pull time to Build information
https://bugs.freedesktop.org/show_bug.cgi?id=43031 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||pmla...@suse.cz Ever Confirmed|0 |1 Summary|Naming convention for |Naming convention for |Master builds |Master builds: Please add ||Pull time to Build ||information --- Comment #7 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-04-21 03:44:37 UTC --- I agree, sometimes it's difficult to compare results without precise pull time information (what you find in the file name and for master and daliy builds in the additional text file in the download folder). Currently I have a list where I collect all info th the various builds I have, but that's annoying, it would be fine to have that in Help / About. But we should not overwhelm normal users with such expert information, so I still believe we should have a details button in the dialog 8or something similar) leading to such information. @Petr: any Idea how to get that info with acceptable costs and in an appropriate way into the dialog? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48410] File Menu (in German Datei) has double function on D key
https://bugs.freedesktop.org/show_bug.cgi?id=48410 Jochen d...@jochenschiffers.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48410] File Menu (in German Datei) has double function on D key
https://bugs.freedesktop.org/show_bug.cgi?id=48410 --- Comment #2 from Jochen d...@jochenschiffers.de 2012-04-21 03:57:55 PDT --- Problem solved. Bug was a translocation-problem. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48970] EDITING: Deleting a column in particular.xls corrupts following columns
https://bugs.freedesktop.org/show_bug.cgi?id=48970 --- Comment #4 from Jiri Kosina ji...@jikos.cz 2012-04-21 04:05:53 PDT --- (In reply to comment #3) I see the effect with LibreOffice 3.5.3.1 German UI/Locale [Build-ID: 21cb047-d7e6025-9ba54fc-b4a51a8-f42372b] on German WIN7 Home Premium (64bit), cell contents in cells below Jméno a příjmení no longer visible after deletion of one of the columns A ... C. But may be that is more or less intended? There is a conditional formatting Excel_CondFormat_1_2_1 for cells in column D what makes cell contents invisible, and may be after column deletion condition for that formatting are fulfilled? Currently I do not see a bug. I doubt that this is intended, as in Microsoft Office the contents of the cells is still visible after the same deletion operation. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48970] EDITING: Deleting a column in particular.xls corrupts following columns
https://bugs.freedesktop.org/show_bug.cgi?id=48970 Jiri Kosina ji...@jikos.cz changed: What|Removed |Added Status|NEEDINFO|NEW -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49028] FILEOPEN: Spreadsheet Opens, Sheets are There, but Data Not Displayed (works in Excel)
https://bugs.freedesktop.org/show_bug.cgi?id=49028 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||LibreOffice@bielefeldundbus ||s.de Ever Confirmed|0 |1 --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-04-21 04:07:02 PDT --- Effect is Reproducible with LibreOffice 3.5.3.1 German UI/Locale [Build-ID: 21cb047-d7e6025-9ba54fc-b4a51a8-f42372b] on German WIN7 Home Premium (64bit). Same effect sith OOo 3.4 Beta. Might be invalid / damaged document? My old GNUMERIC complains errors like services: invalid cell [C-1]0 @Eric Olsen: How has that document been created? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48970] EDITING: Deleting a column in particular.xls corrupts following columns
https://bugs.freedesktop.org/show_bug.cgi?id=48970 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|NEW |NEEDINFO Status Whiteboard||infoprovider: Rainer ||Bielefeld --- Comment #5 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-04-21 04:09:34 PDT --- I will do some further research with MS Office later -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49028] FILEOPEN: Spreadsheet Opens, Sheets are There, but Data Not Displayed (works in Excel)
https://bugs.freedesktop.org/show_bug.cgi?id=49028 --- Comment #2 from Eric Olsen er...@sedonacorp.com 2012-04-21 04:32:21 PDT --- Document created with xlsx4j (http://www.docx4java.org/trac/docx4j). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43072] SPELL: seems disconnected
https://bugs.freedesktop.org/show_bug.cgi?id=43072 --- Comment #2 from Gabor Toth gabor...@gmail.com 2012-04-21 05:12:31 PDT --- Yes, same stuff. Same way. On 21/04/2012, bugzilla-dae...@freedesktop.org bugzilla-dae...@freedesktop.org wrote: https://bugs.freedesktop.org/show_bug.cgi?id=43072 sasha.libreoff...@gmail.com changed: What|Removed |Added CC||sasha.libreoff...@gmail.com --- Comment #1 from sasha.libreoff...@gmail.com 2012-04-21 01:45:17 UTC --- Thanks for bugreport Please, verify if in last version of LibreOffice still reproducible -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You reported the bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48929] Presentation mode with video closes the software
https://bugs.freedesktop.org/show_bug.cgi?id=48929 --- Comment #2 from Eliane Domingos elianedomin...@gmail.com 2012-04-21 05:46:38 PDT --- Maybe when I inserted the video the link option was selected by default. I made a new presentation file, but the situation is different now. The software don't crash, but don't play the video. When the video is not embedded and you try to see the file in the presentation mode, the software is closed. When you embedded the video, the software don't crash and don't play the video. Link for the files: https://docs.google.com/open?id=0Bzmb-ZecnWluZlh5dVJobUltWDg -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48410] File Menu (in German Datei) has double function on D key
https://bugs.freedesktop.org/show_bug.cgi?id=48410 --- Comment #3 from Jochen d...@jochenschiffers.de 2012-04-21 05:50:51 PDT --- Problem solved. Bug was a translocation-problem. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48809] FORMATTING: Changing fonttype
https://bugs.freedesktop.org/show_bug.cgi?id=48809 --- Comment #2 from David Schiebaan dw.schieb...@hccnet.nl 2012-04-21 05:54:55 PDT --- Hi Julian, My answers to your questions are below. regards, David Schiebaan On 17 Apr 2012 at 21:40, bugzilla-dae...@freedesktop.org wrote: https://bugs.freedesktop.org/show_bug.cgi?id=48809 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever Confirmed|0 |1 --- Comment #1 from Julien Nabet serval2...@yahoo.fr 2012-04-17 14:40:46 PDT --- On pc Debian x86-64, I don't reproduce this problem with 3.5 branch updated today (so not exactly 3.5.2). I use Windows 7 64-bit UK. At work I have Windows 7 64-bit Dutch which hasn't gor the problem. If I remember correctly the update ar work to 3.5 from 3.4 didn't go well and I had to deinstall 3.4 and install 3.5. I am not sure if I used the same upgrading route at home because not long ago had to reinstall Windows 7 so there is a chance I installed only 3.5. Do you reproduce this with a brand new file ? Yes. Did you install specific fonts ? No. Have you got any LO specific extensions ? What is a LO specific extension? Could you try with a brand new profile for the test ? What profile do you mean? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You reported the bug. - No virus found in this message. Checked by AVG - www.avg.com Version: 2012.0.1913 / Virus Database: 2411/4950 - Release Date: 04/21/12 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39825] Does not find Firefox profile for digital certificate signing
https://bugs.freedesktop.org/show_bug.cgi?id=39825 --- Comment #5 from Ferry Toth ft...@telfort.nl 2012-04-21 06:06:50 PDT --- I just found the problem on my system. I had at some point installed Thinderbird, although I removed that later (Kubuntu). The .thunderbird folder still existed and there were no certificates there. I will attach a document with script that can help debug which certificate store is used by LO. Of course it would e useful if LO would select the correct store for the Tools Settings menu (similar to selecting the correct JRE). Ferry -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39825] Does not find Firefox profile for digital certificate signing
https://bugs.freedesktop.org/show_bug.cgi?id=39825 --- Comment #6 from Ferry Toth ft...@telfort.nl 2012-04-21 06:07:39 PDT --- Created attachment 60415 -- https://bugs.freedesktop.org/attachment.cgi?id=60415 Contains macro to verify the certificate path - don't be alarmed. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49040] New: RTF FILE OPENS IN WRITER MANGLED
https://bugs.freedesktop.org/show_bug.cgi?id=49040 Bug #: 49040 Summary: RTF FILE OPENS IN WRITER MANGLED Classification: Unclassified Product: LibreOffice Version: unspecified Platform: All OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Extensions AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: alberto_toc...@yahoo.com.br I always get notes in fiscal rtf extension, and this note as it has pictures, unconfigured opens in Writer, and I am forced to open in Microsoft Word to print usually remains. Call solution to this problem. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48559] FILEOPEN: Some rtf files open corrupted
https://bugs.freedesktop.org/show_bug.cgi?id=48559 Miklos Vajna vmik...@suse.cz changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #2 from Miklos Vajna vmik...@suse.cz 2012-04-21 06:35:26 PDT --- I can reproduce this with 3.5.2, for example at the bottom of the second page the Revision and Translation lines are overlapped. On master, the issue is not there, it turns out this is a duplicate of bug 48876, which is on its way to -3-5 already. (For performance issues, we already have bug 44736.) Thanks for the report, though! *** This bug has been marked as a duplicate of bug 48876 *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36692] FILESAVE: Footnotes and header are saved incorrectly in .doc
https://bugs.freedesktop.org/show_bug.cgi?id=36692 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||WORKSFORME CC||b...@eikota.de --- Comment #3 from Roman Eisele b...@eikota.de 2012-04-21 06:43:06 PDT --- I have tested this issue again with * LibreOffice 3.4.5 * LibreOffice 3.5.2.2, both with German UI and both running on MacOS X 10.6.8, German UI. I have exported Zack's original .odt file to .doc (the Word 97/2000/XP/2003 variant) files with both LibreOffice versions and then opened both .doc files with MS Word 2010 running on Windows 7 (German UI). I will attach screenshots of the results. Looking at them and comparing them with the look of Zack's original .odt file in LibreOffice 3.4.5 or 3.5.2.2. either (I will attach another screenshot, just for completeness), I judge that this issue is completely or almost completely resolved: * The header line is right-aligned now like like in the .odt file. * The main headline is centered now like like in the .odt file. * The body text has double line spacing now like like in the .odt file. * The placement of the footnotes is now like in the .odt file. * The overall page layout is nearly identical now. There is a one-line difference at the end of page 2, with impact on placement of footnote #6 (see screenshots), but I regard this as minor difference which will always occur when converting between different file formats (or just between different word processors). The only ugly difference left is the beginning of the underline of hyperlinks in footnotes, when the text of the footnote begins with a hyperlink immediately; in LibreOffice/.odt, the underline properly begins at the http://, but in Word/.doc, the space (tab) between footnote number and footnote text gets an underline, too. IMHO this a very minor minor issue which would never occur if you would start all footnotes with some text, e.g. 'See ...', 'Cf. ...' etc. before the hyperlink, what would be (IMHO again) better citation style. But if this issue is of special importance for somebody, it would be appropriate to file a specific bug report for it, because a) a very precise bug report about exactly one issue is much more likely to get fixed, and b) this hyperlink-at-start-of-footnote issue is of less severity than the original bundle of issues reported by Zack, therefore needs other 'Importance' settings. Because there are only minor formatting differences left now; because this bug is fixed now both in LibreOffice 3.4.x and 3.5.x (and in 3.6.x, too); because the bug seems to be fixed already for some time (see comment #2 by s-joyemusequna, dated 2012-01-28), I think we can and should close this bug report. Feel free to reopen it if the issue reported by Zack is still reproducible for you or returns. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36692] FILESAVE: Footnotes and header are saved incorrectly in .doc
https://bugs.freedesktop.org/show_bug.cgi?id=36692 --- Comment #5 from Roman Eisele b...@eikota.de 2012-04-21 06:44:42 PDT --- Created attachment 60421 -- https://bugs.freedesktop.org/attachment.cgi?id=60421 How Zacks ODT looks in LibO 3.5.5.2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36692] FILESAVE: Footnotes and header are saved incorrectly in .doc
https://bugs.freedesktop.org/show_bug.cgi?id=36692 --- Comment #6 from Roman Eisele b...@eikota.de 2012-04-21 06:45:22 PDT --- Created attachment 60422 -- https://bugs.freedesktop.org/attachment.cgi?id=60422 How the LO 3.4.5 exported DOC file looks in MS Word 2010 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36692] FILESAVE: Footnotes and header are saved incorrectly in .doc
https://bugs.freedesktop.org/show_bug.cgi?id=36692 --- Comment #7 from Roman Eisele b...@eikota.de 2012-04-21 06:45:52 PDT --- Created attachment 60423 -- https://bugs.freedesktop.org/attachment.cgi?id=60423 How the LO 3.5.2.2. exported DOC file looks in MS Word 2010 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37486] First Master Slide background overwriting other master slide backgrounds saving to .odp
https://bugs.freedesktop.org/show_bug.cgi?id=37486 Christopher M. Penalver christopher.penal...@gmx.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||WORKSFORME Priority|low |lowest --- Comment #3 from Christopher M. Penalver christopher.penal...@gmx.com 2012-04-21 07:09:57 PDT --- Unreproducible in: lsb_release -rd Description:Ubuntu precise (development branch) Release:12.04 apt-cache policy libreoffice-impress libreoffice-impress: Installed: 1:3.5.2-2ubuntu1 Candidate: 1:3.5.2-2ubuntu1 Version table: *** 1:3.5.2-2ubuntu1 0 500 http://us.archive.ubuntu.com/ubuntu/ precise/main i386 Packages 100 /var/lib/dpkg/status -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47702] VIEWING: no recent files are shown
https://bugs.freedesktop.org/show_bug.cgi?id=47702 --- Comment #1 from Jose Manuel jmreca...@gmail.com 2012-04-21 07:10:53 PDT --- [Not Reproducible] with LibreOffice 3.3.4 - Ubuntu 11.04 (32bit) Spanish UI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47553] FILEOPEN document with Punjabi Font will CRASH
https://bugs.freedesktop.org/show_bug.cgi?id=47553 Roman Eisele b...@eikota.de changed: What|Removed |Added CC||b...@eikota.de --- Comment #8 from Roman Eisele b...@eikota.de 2012-04-21 07:12:14 PDT --- (In reply to comment #4) Perhaps a Windows specific bug ? Could someone try on MacOs ? It looks like a Windows-specific bug: I can open and edit the provided sample file without any problems both with LibreOffice 3.4.6 and 3.5.2.2, both with German UI, both running on MacOS X 10.6.8. No crash, no problems. I have installed the font (Asses) before. NB: The MacOS X Fontbook application reports some minor problems with the Asses font: structure and content of the 'kern' table are not OK. FontLab opens the font file without problems, but shows only one single kern pair; this looks, well, strange, and may be the sign of a damaged 'kern' table which FontLab could not import completely. Is it possible that font kerning problems cause the crash on Windows (but not on MacOS or Linux)? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48809] FORMATTING: Changing fonttype
https://bugs.freedesktop.org/show_bug.cgi?id=48809 --- Comment #3 from David Schiebaan dw.schieb...@hccnet.nl 2012-04-21 07:12:56 PDT --- Hi Julian, Stop searching for a solution. I made a terrible error. The version of LibreOffice I was using wasn't 3.5.2 but 3.5.1. After upgrading to 3.5.2 the problem disappeared. Thanks for trying to help me. Regards, David Schiebaan On 17 Apr 2012 at 21:40, bugzilla-daemon@freedesktop.o wrote: https://bugs.freedesktop.org/show_bug.cgi?id=48809 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever Confirmed|0 |1 --- Comment #1 from Julien Nabet serval2...@yahoo.fr 2012-04-17 14:40:46 PDT --- On pc Debian x86-64, I don't reproduce this problem with 3.5 branch updated today (so not exactly 3.5.2). Do you reproduce this with a brand new file ? Did you install specific fonts ? Have you got any LO specific extensions ? Could you try with a brand new profile for the test ? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You reported the bug. - No virus found in this message. Checked by AVG - www.avg.com Version: 2012.0.1913 / Virus Database: 2411/4950 - Release Date: 04/21/12 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46115] [bad links] Missing page http://it.libreoffice.org/supporto/documentazione/
https://bugs.freedesktop.org/show_bug.cgi?id=46115 Jose Manuel jmreca...@gmail.com changed: What|Removed |Added Platform|x86 (IA32) |All OS/Version|Linux (All) |All -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46845] Iterations not converging in Calc
https://bugs.freedesktop.org/show_bug.cgi?id=46845 Jose Manuel jmreca...@gmail.com changed: What|Removed |Added Platform|x86 (IA32) |All OS/Version|Linux (All) |All Version|LibO 3.3.4 release |unspecified -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46823] EDITING: BOLD automatically lost
https://bugs.freedesktop.org/show_bug.cgi?id=46823 Jose Manuel jmreca...@gmail.com changed: What|Removed |Added Platform|x86 (IA32) |All OS/Version|Linux (All) |All Version|LibO 3.3.4 release |LibO 3.5.1 RC1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46757] : Word count not working well with Changes - record. Inconsistent.
https://bugs.freedesktop.org/show_bug.cgi?id=46757 Jose Manuel jmreca...@gmail.com changed: What|Removed |Added Platform|x86 (IA32) |Other OS/Version|Linux (All) |All Version|LibO 3.3.4 release |LibO 3.5.0 Beta3 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46733] Deleting columns in a table can delete several columns if any cells in that column are merged with other cells
https://bugs.freedesktop.org/show_bug.cgi?id=46733 Jose Manuel jmreca...@gmail.com changed: What|Removed |Added Platform|x86 (IA32) |All OS/Version|Linux (All) |other Version|LibO 3.3.4 release |LibO 3.5.0 Release -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46754] UI: Impossible to hide Horizontal scrollbar in Writer
https://bugs.freedesktop.org/show_bug.cgi?id=46754 Jose Manuel jmreca...@gmail.com changed: What|Removed |Added Platform|x86 (IA32) |All OS/Version|Linux (All) |other Version|LibO 3.3.4 release |LibO 3.5.0 Release -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47511] PDF: Writer: exporting a document as pdf file will crash Writer.
https://bugs.freedesktop.org/show_bug.cgi?id=47511 Roman Eisele b...@eikota.de changed: What|Removed |Added CC||b...@eikota.de --- Comment #1 from Roman Eisele b...@eikota.de 2012-04-21 07:20:55 PDT --- I'm sorry but I can't reproduce this problem; for me, export as PDF works with LibreOffice 3.5.2.2 (on MacOS X 10.6.8) like before. This means, the information given in the original report is not enough to reproduce this problem. Could you, please, -- provide a sample file which you can't export as PDF? Or do you see this problem with all files? Which file types did you use: ODT documents, DOC files, DOCX files? -- tell us which settings you use in the 'Export as PDF ...' dialog? Just the default settings, or did you change some setttings? -- tell us which operating system you use (Windows? which version? which language?)? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43253] VIEWING: Zooming in Split View
https://bugs.freedesktop.org/show_bug.cgi?id=43253 --- Comment #3 from Javier Catalá j_cat...@yahoo.com 2012-04-21 07:55:50 PDT --- [Reproducible] with LibreOffice 3.5.2 - Windows Vista Home Premium (32bit) Spanish UI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47416] context menu, Font host at max 100 fonts
https://bugs.freedesktop.org/show_bug.cgi?id=47416 --- Comment #2 from Javier Catalá j_cat...@yahoo.com 2012-04-21 07:59:38 PDT --- [Reproducible] with LibreOffice 3.5.2 - Windows Vista Home Premium (32bit) Spanish UI -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
